> -----Original Message-----
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Tuesday, January 15, 2019 12:59 AM
> To: Pattan, Reshma <reshma.pat...@intel.com>
> Cc: dev@dpdk.org; sta...@dpdk.org; Yigit, Ferruh <ferruh.yi...@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup
>
> 11/01/2019 18:51, Reshma Pattan:
> > Virtual devices added in pdump application using rte_eal_hotplug_add
> > should be removed explicitly while existing the pdump application,
> > otherwise the
>
> existing -> exiting ?
>
> > subsequent run of the pdump application will fail with the reason that
> > virtual devices with the same name already exists in primary.
> >
> > Fixes: 6362f362a2 ("app/pdump: use EAL hotplug instead of ethdev
> > attach")
> > CC: sta...@dpdk.org
> > CC: ferruh.yi...@intel.com
>
> Why is it marked as a fix of this commit?
> Is it a miss in the conversion from ethdev attach calls?
> Or a changed behaviour with hotplug functions?
>
>
It is changed behaviour with hotplug functions.
Thanks,
Reshma
