On 12/5/2016 3:59 PM, thomas.monjalon at 6wind.com (Thomas Monjalon) wrote: > 2016-12-05 16:34, Thomas Monjalon: >> Clean up the code to always use the flags RTE_MACHINE_CPUFLAG_* >> generated by the DPDK makefile rte.cpuflags.mk. > > This patch does not work because RTE_MACHINE_CPUFLAG_* are generated > for the whole library when including rte.vars.mk. > So the flags are not accurate when overriding the flags per file like > it is done in rte_acl. > > So the questions are: > - should we use RTE_MACHINE_CPUFLAG_? > - should we override the flags per file? > - will we be able to use the function attribute __target__? >
Hi Thomas, This patch is waiting for a comment for two years, is it still valid, if not can we mark it as rejected? For record, it is: https://patches.dpdk.org/patch/17684/ Thanks, ferruh