Re: [dpdk-dev] [PATCH] eventdev: fix eth Tx adapter queue count checks

2018-12-02 Thread Rao, Nikhil
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Saturday, December 1, 2018 8:09 PM > To: Rao, Nikhil > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] eventdev: fix eth Tx adapter queue count checks > > -Original Message- > > Date:

[dpdk-dev] [PATCH v2] net/i40e: firmware status check

2018-12-02 Thread Xiaoyun Li
Check the firmware status at init time. If the firmware is in recovery mode, alert the user to check it. Signed-off-by: Xiaoyun Li --- v2: * Rebase to the newest codes. --- drivers/net/i40e/i40e_ethdev.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net

Re: [dpdk-dev] [PATCH v3] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

2018-12-02 Thread Tone Zhang (Arm Technology China)
Hi all, Could anyone please have a review and re-test the change? Thanks a lot! Br, Tone > -Original Message- > From: dev On Behalf Of tone.zhang > Sent: Monday, November 19, 2018 10:37 AM > To: dev@dpdk.org > Cc: Gavin Hu (Arm Technology China) ; Honnappa > Nagarahalli ; Steve Capper

[dpdk-dev] [PATCH v2] net/i40e: adjust the RSS table

2018-12-02 Thread Xiaoyun Li
When starting the device, the RSS table is initialized. So the RSS update before device_start would be overwitten. This patch allows users to update the RSS reta table before device_start and adjusts the order to set entries sequentially. Signed-off-by: Xiaoyun Li --- v2: * Adds support to updat

[dpdk-dev] [PATCH v2 20/20] net/ice: support meson build

2018-12-02 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- drivers/net/ice/base/meson.build | 30 ++ drivers/net/ice/meson.build | 15 +++ drivers/net/meson.build | 1 + 3 files changed, 46 insertions(+) create mode 100644 drivers/net/ice/base/meson.build create mode 1

[dpdk-dev] [PATCH v2 19/20] doc: add ICE description and update release note

2018-12-02 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- MAINTAINERS| 1 + doc/guides/nics/features/ice.ini | 39 +++ doc/guides/nics/ice.rst| 87 ++ doc/guides/rel_notes/release_19_02.rst | 4 ++ 4 files changed, 131 insertions

[dpdk-dev] [PATCH v2 18/20] net/ice: support descriptor ops

2018-12-02 Thread Wenzhuo Lu
Add below ops, rx_descriptor_done rx_descriptor_status tx_descriptor_status Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 3 ++ drivers/net/ice/ice_lan_rxtx.c | 84 +++

[dpdk-dev] [PATCH v2 14/20] net/ice: support statistics

2018-12-02 Thread Wenzhuo Lu
Add below ops, stats_get stats_reset xstats_get xstats_get_names xstats_reset Signed-off-by: Wenzhuo Lu Signed-off-by: Jia Guo --- drivers/net/ice/ice_ethdev.c | 574 +++ 1 file changed, 574 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drive

[dpdk-dev] [PATCH v2 16/20] net/ice: support basic RX/TX

2018-12-02 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 17 ++ drivers/net/ice/ice_lan_rxtx.c | 568 - drivers/net/ice/ice_rxtx.h | 8 + 3 files changed, 591 in

[dpdk-dev] [PATCH v2 15/20] net/ice: support queue information getting

2018-12-02 Thread Wenzhuo Lu
Add below ops, rxq_info_get txq_info_get rx_queue_count Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 3 ++ drivers/net/ice/ice_lan_rxtx.c | 66 ++ drivers

[dpdk-dev] [PATCH v2 13/20] net/ice: support EEPROM information getting

2018-12-02 Thread Wenzhuo Lu
Add below ops, get_eeprom_length get_eeprom Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_ethdev.c | 45 1 file changed, 45 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 289c

[dpdk-dev] [PATCH v2 17/20] net/ice: support advance RX/TX

2018-12-02 Thread Wenzhuo Lu
Add RX functions, scatter and bulk. Add TX function, simple. Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_lan_rxtx.c | 660 - 1 file changed, 658 insertions(+), 2 delet

[dpdk-dev] [PATCH v2 12/20] net/ice: support FW version getting

2018-12-02 Thread Wenzhuo Lu
Add ops fw_version_get. Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethd

[dpdk-dev] [PATCH v2 07/20] net/ice: support MTU setting

2018-12-02 Thread Wenzhuo Lu
Add ops link_update. Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 36 1 file changed, 36 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/

[dpdk-dev] [PATCH v2 11/20] net/ice: support RX queue interruption

2018-12-02 Thread Wenzhuo Lu
Add below ops, rx_queue_intr_enable rx_queue_intr_disable Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 234 +++ 1 file changed, 234 insertions(+) diff --git

[dpdk-dev] [PATCH v2 06/20] net/ice: support link update

2018-12-02 Thread Wenzhuo Lu
Add ops link_update. Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 334 +++ 1 file changed, 334 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/dri

[dpdk-dev] [PATCH v2 09/20] net/ice: support VLAN ops

2018-12-02 Thread Wenzhuo Lu
Add below ops, ice_vlan_filter_set ice_vlan_offload_set ice_vlan_tpid_set ice_vlan_pvid_set Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 598 +++ 1 file chan

[dpdk-dev] [PATCH v2 10/20] net/ice: support RSS

2018-12-02 Thread Wenzhuo Lu
Add below ops, reta_update reta_query rss_hash_update rss_hash_conf_get Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 246 +++ 1 file changed, 246 insertions(

[dpdk-dev] [PATCH v2 08/20] net/ice: support MAC ops

2018-12-02 Thread Wenzhuo Lu
Add below ops, mac_addr_set mac_addr_add mac_addr_remove Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 239 +++ 1 file changed, 239 insertions(+) diff --git

[dpdk-dev] [PATCH v2 05/20] net/ice: support packet type getting

2018-12-02 Thread Wenzhuo Lu
Add ops dev_supported_ptypes_get. Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_ethdev.c | 2 + drivers/net/ice/ice_lan_rxtx.c | 601 + drivers/net/ice/ice_rxtx.h | 2 + 3 files changed, 605 insertions(+) diff --git

[dpdk-dev] [PATCH v2 04/20] net/ice: support getting device information

2018-12-02 Thread Wenzhuo Lu
Add ops dev_infos_get. Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 123 +++ 1 file changed, 123 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/d

[dpdk-dev] [PATCH v2 02/20] net/ice: support device initialization

2018-12-02 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- config/common_base | 9 + drivers/net/Makefile| 1 + drivers/net/ice/Makefile| 75 drivers/net/ice/ice_ethdev.c

[dpdk-dev] [PATCH v2 03/20] net/ice: support device and queue ops

2018-12-02 Thread Wenzhuo Lu
Normally when starting/stopping the device the queue should be started and stopped. Support them both in this patch. Below ops are added, dev_configure dev_start dev_stop dev_close dev_reset rx_queue_start rx_queue_stop tx_queue_start tx_queue_stop rx_queue_setup rx_queue_release tx_queue_setup tx

[dpdk-dev] [PATCH v2 00/20] A new net PMD - ice

2018-12-02 Thread Wenzhuo Lu
This patch set adds the support of a new net PMD, Intel® Ethernet Network Adapters E810, also called ice. Besides enabling this new NIC, also some other features supported on this NIC. Like below, Basic features: 1, Basic device operations: probe, initialization, start/stop, configure, info get.

Re: [dpdk-dev] [PATCH] net/ixgbe: enable LRO for x550

2018-12-02 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Friday, November 30, 2018 3:51 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH] net/ixgbe: enable LRO for x550 > > There is need for enable LRO for x550 NIC, it also support this feature. > > Sig

Re: [dpdk-dev] [PATCH] bus/vmbus: fix race in sub channel creation

2018-12-02 Thread Mohammed Gamal
On Fri, 2018-11-30 at 12:24 -0800, Stephen Hemminger wrote: > When using multiple queues, there was a race with the kernel > in setting up the second channel. This is do due to a kernel change > whiche does not allow accessing sysfs files for Hyper-V > channels that are not opened. > > The fix is

[dpdk-dev] [PATCH v6 7/9] app/procinfo: add support for debug ring

2018-12-02 Thread Vipin Varghese
Function show_ring is used for displaying the RING of the primary process. Signed-off-by: Vipin Varghese --- V3: - replace space to tab in printf - Reshma Pathan - change ring display information - Vipin Varghese --- app/proc-info/main.c | 34 +- 1 file changed

[dpdk-dev] [PATCH v6 9/9] doc/procinfo: add information for debug options

2018-12-02 Thread Vipin Varghese
Document update for debug options and information for PMD instances like port, traffic manager, crypto, mempool and ring instances. Signed-off-by: Vipin Varghese Acked-by: John McNamara --- V6: - add ack for v5 - John Mcnamara - update entry for mempool iter - Vipin Varghese V3: - update d

[dpdk-dev] [PATCH v6 4/9] app/procinfo: add support for show port

2018-12-02 Thread Vipin Varghese
Function show_port is used for displaying the port PMD information under under primary process. The information shows basic, per queue and security. Signed-off-by: Vipin Varghese --- V5: - convert 100 to MAX_STRING_LEN - Reshma Pattan - RSS made for port - Reshma Pattan - update bdr_str to st

[dpdk-dev] [PATCH v6 5/9] app/procinfo: add support for show tm

2018-12-02 Thread Vipin Varghese
Function show_tm is used for displaying the tm PMD under the primary process. This covers basic and per node|level details with stats. Signed-off-by: Vipin Varghese --- V6: - replace or with logical or - Reshma Pathan & Konstantin Ananyev V3: - memset for struct elements - Vipin Varghese - c

[dpdk-dev] [PATCH v6 6/9] app/procinfo: add support for show crypto

2018-12-02 Thread Vipin Varghese
Function show_crypto is used for displaying the crypto PMD under the primary process. Signed-off-by: Vipin Varghese --- v4: - add space to compare - Vipin Varghese V3: - replace MACRO to function - Reshma Pathan & Stephen Hemminger - add memset for struct elements - Reshma Pathan - change d

[dpdk-dev] [PATCH v6 8/9] app/procinfo: add support for show iter mempool

2018-12-02 Thread Vipin Varghese
Function show_mempool is used for displaying valid MEMPOOL. Function iter_mempool is used for iterating mempool elements for a mempool for max of 256 bytes. In case of show_mempool for invalid name, whole list is dump. Signed-off-by: Vipin Varghese --- V6: - split iter mempool - Vipin Varghese

[dpdk-dev] [PATCH v6 1/9] app/procinfo: add usage for new debug

2018-12-02 Thread Vipin Varghese
Update the file with MACRO for stats border, usage text information and string comparision. Signed-off-by: Vipin Varghese --- V6: - add mempool iterate elements option - Vipin Varghese V3: - change the usage details - Vipin Varghese V2: - change word dbg to show - Stephen Hemminger --- app

[dpdk-dev] [PATCH v6 2/9] app/procinfo: add compare for new options

2018-12-02 Thread Vipin Varghese
Add code for new debug options to compare usage strings and set enable flag. Signed-off-by: Vipin Varghese --- V6: - check for iter mempool - Vipin Varghese V3: - variables from debug to show - Vipin Varghese V2: - compare string from dbg to show - Stephen Hemminger --- app/proc-info/main.

[dpdk-dev] [PATCH v6 0/9] app/proc-info: improve debug of proc-info tool

2018-12-02 Thread Vipin Varghese
This patch adds new debug functions to existing proc-info tool. Motivation == DPDK proc-info tool is been widely used as secondary process to collect stats for any primary process. But these are limited to DPDK NIC ports and basic memory usage. Motivation == This patch tries to

[dpdk-dev] [PATCH v6 3/9] app/procinfo: add prototype for debug instances

2018-12-02 Thread Vipin Varghese
Add prototype function calls for the show functions. Signed-off-by: Vipin Varghese --- V6: - add call to iter mempool - Vipin Varghese V3: - update function names from debug to show - Vipin Varghese V2: - removed if else ladder - Vipin Varghese --- app/proc-info/main.c | 50 +++

Re: [dpdk-dev] [PATCH] net/i40e: adjust the RSS table

2018-12-02 Thread Zhang, Qi Z
> -Original Message- > From: Li, Xiaoyun > Sent: Friday, November 23, 2018 9:36 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Li, Xiaoyun > Subject: [PATCH] net/i40e: adjust the RSS table > > When starting the device, the RSS table is set. For 8 queues, the RSS hash > table > would be lik

[dpdk-dev] [PATCH] pdump: remove deprecated APIs

2018-12-02 Thread Tiwei Bie
We already changed to use generic IPC in pdump since below commit: commit 660098d61f57 ("pdump: use generic multi-process channel") The `rte_pdump_set_socket_dir()`, the `path` parameter of `rte_pdump_init()` and the `enum rte_pdump_socktype` have been deprecated since then. This commit removes t

[dpdk-dev] [PATCH] lib/librte_lpm: remove recursively included header file

2018-12-02 Thread Congwen Zhang
includes itself: rte_lpm.h -> rte_lpm_sse.h -> rte_lpm.h Signed-off-by: Congwen Zhang --- lib/librte_lpm/rte_lpm_sse.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_lpm/rte_lpm_sse.h b/lib/librte_lpm/rte_lpm_sse.h index 3b27e97..44770b6 100644 --- a/lib/librte_lpm/rte_lpm_sse.h +

[dpdk-dev] [PATCH] net/ixgbe: remove recursively included header file

2018-12-02 Thread Congwen Zhang
includes itself: ixgbe_type.h -> ixgbe_mbx.h -> ixgbe_type.h Signed-off-by: Congwen Zhang --- drivers/net/ixgbe/base/ixgbe_mbx.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_mbx.h b/drivers/net/ixgbe/base/ixgbe_mbx.h index 5d32cbc..55fa9ee 100644 --- a/drive

Re: [dpdk-dev] [PATCH 0/4] Allow using external memory without malloc

2018-12-02 Thread Yongseok Koh
> On Dec 1, 2018, at 9:48 PM, Shahaf Shuler wrote: > > Hi Anatoly, > > Thursday, November 29, 2018 3:49 PM, Anatoly Burakov: >> Subject: [PATCH 0/4] Allow using external memory without malloc >> >> Currently, the only way to use externally allocated memory is through >> rte_malloc API's. Whi

Re: [dpdk-dev] [RFC] DFS (DPDK Filesystem)

2018-12-02 Thread Wiles, Keith
Sent from my iPhone > On Nov 30, 2018, at 10:01 AM, Wiles, Keith wrote: > > Plain text format is a real pain unless I time travel to the 1990’s :-( > >> On Nov 30, 2018, at 7:13 AM, Zhang, Qi Z wrote: >> >> Hi Keith: >> >> >>> -Original Message- >>> From: dev [mailto:dev-boun...@

Re: [dpdk-dev] [PATCH] doc: fix a typo in testpmd guide

2018-12-02 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen > Sent: Saturday, December 1, 2018 6:15 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Rami Rosen > Subject: [dpdk-dev] [PATCH] doc: fix a typo in testpmd guide > > This patch fixes a typo in testpmd guid

Re: [dpdk-dev] 19.02 Intel Roadmap

2018-12-02 Thread O'Driscoll, Tim
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Sunday, December 2, 2018 2:01 AM > To: Thomas Monjalon > Cc: O'Driscoll, Tim ; dev@dpdk.org > Subject: Re: [dpdk-dev] 19.02 Intel Roadmap > > On Sun, 02 Dec 2018 01:17:09 +0100 > Thomas Monjalon

Re: [dpdk-dev] [PATCH v2] kni: use kni_ethtool_ops only with unknown drivers

2018-12-02 Thread Igor Ryzhov
Stephen, ethtool_get_link returns EOPNOTSUPP if device doesn't supply get_link: static int ethtool_get_link(struct net_device *dev, char __user *useraddr) { struct ethtool_value edata = { .cmd = ETHTOOL_GLINK }; if (!dev->ethtool_ops->get_link) return -EOPNOTSUPP; edata.data = netif_running(dev