[dpdk-dev] [PATCH 2/2] net/i40e: correct offload not supported mask

2018-10-25 Thread Xiaolong Ye
Just as the name I40E_TX_OFFLOAD_NOTSUP_MASK indicates, it should be the mask of unsupported features (either not in PKT_TX_OFFLOAD_MASK or in I40E_TX_OFFLOAD_MASK), however, xor will not get desired result here, assume bit 0 of PKT_TX_OFFLOAD_MASK and I40E_TX_OFFLOAD_MAKS are 0 which means corresp

[dpdk-dev] [PATCH v2] net/i40e: fix Rx instability with vector mode

2018-10-25 Thread Beilei Xing
Previously, there is instability during vector Rx if descriptor number is not power of 2, e.g. process hang and some Rx packets are unexpectedly empty. That's because vector Rx mode assumes Rx descriptor number is power of 2 when doing bit mask. This patch allows vector mode only when the number of

Re: [dpdk-dev] [PATCH v2 7/7] net/mlx5: e-switch VXLAN rule cleanup routines

2018-10-25 Thread Yongseok Koh
On Thu, Oct 25, 2018 at 01:32:23PM -0700, Slava Ovsiienko wrote: > > -Original Message- > > From: Yongseok Koh > > Sent: Thursday, October 25, 2018 3:37 > > To: Slava Ovsiienko > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH v2 7/7] net/mlx5: e-switch VXLAN rule cleanup routin

Re: [dpdk-dev] [PATCH v2 5/7] net/mlx5: e-switch VXLAN tunnel devices management

2018-10-25 Thread Yongseok Koh
On Thu, Oct 25, 2018 at 01:21:12PM -0700, Slava Ovsiienko wrote: > > -Original Message- > > From: Yongseok Koh > > Sent: Thursday, October 25, 2018 3:28 > > To: Slava Ovsiienko > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH v2 5/7] net/mlx5: e-switch VXLAN tunnel devices > >

Re: [dpdk-dev] [PATCH] net/ixgbe: fix ixgbevf link status

2018-10-25 Thread Wu, Yanglong
Hi, qi: This patch we are going to fix the problem H3C: 82599 Niantic VF can't get correct link status when use cable :https://jira01.devtools.intel.com/browse/DPDK-5543?filter=-3 The commit log describe about the gap between kernel and dpdk and why we design this workaround to get right lin

Re: [dpdk-dev] [PATCH v9 8/8] net/virtio: enable packed virtqueues by default

2018-10-25 Thread Tiwei Bie
On Wed, Oct 24, 2018 at 04:32:36PM +0200, Jens Freimann wrote: > Signed-off-by: Jens Freimann > --- > drivers/net/virtio/virtio_ethdev.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/virtio/virtio_ethdev.h > b/drivers/net/virtio/virtio_ethdev.h > index 6c9247639..d9b4feee

Re: [dpdk-dev] [PATCH v9 1/8] net/virtio: vring init for packed queues

2018-10-25 Thread Tiwei Bie
On Thu, Oct 25, 2018 at 05:12:48PM +0200, Jens Freimann wrote: > On Thu, Oct 25, 2018 at 03:51:19PM +0200, Maxime Coquelin wrote: > > > > > > On 10/25/18 3:48 PM, Jens Freimann wrote: > > > On Thu, Oct 25, 2018 at 05:21:15PM +0800, Tiwei Bie wrote: > > > > On Wed, Oct 24, 2018 at 04:32:29PM +0200

Re: [dpdk-dev] [PATCH v9 6/8] net/virtio: implement receive path for packed queues

2018-10-25 Thread Tiwei Bie
On Thu, Oct 25, 2018 at 03:54:16PM +0200, Jens Freimann wrote: > On Thu, Oct 25, 2018 at 05:39:09PM +0800, Tiwei Bie wrote: > > On Wed, Oct 24, 2018 at 04:32:34PM +0200, Jens Freimann wrote: > > > Implement the receive part. > > > > > > Signed-off-by: Jens Freimann > > > --- > > > drivers/net/vi

[dpdk-dev] [PATCH v7 3/5] hash: fix key store element alignment

2018-10-25 Thread Honnappa Nagarahalli
Fix the key store array element alignment such that every array element is aligned on KEY_ALIGNMENT boundary. This is required to make 'pdata' in 'struct rte_hash_key' align on its natural boundary for atomic load/store. Fixes: 473d1bebce43 ("hash: allow to store data in hash table") Cc: sta...@dp

[dpdk-dev] [PATCH v7 5/5] test/hash: read-write lock-free concurrency test

2018-10-25 Thread Honnappa Nagarahalli
From: Dharmik Thakkar Unit tests to check for hash lookup and bulk-lookup perf with lock-free enabled and with lock-free disabled. Unit tests performed with readers running in parallel with writers. Tests include: - hash lookup on existing keys with: - hash add causing NO key-shifts of existi

[dpdk-dev] [PATCH v7 2/5] hash: support do not free on delete

2018-10-25 Thread Honnappa Nagarahalli
rte_hash_lookup_xxx APIs return the index of slot in the key store. Application(reader) can use that index to reference other data structures in its scope. Because of this, the index should not be freed till the application completes using the index. RTE_HASH_EXTRA_FLAGS_NO_FREE_ON_DEL is introduce

[dpdk-dev] [PATCH v7 4/5] hash: add lock-free read-write concurrency

2018-10-25 Thread Honnappa Nagarahalli
Add lock-free read-write concurrency. This is achieved by the following changes. 1) Add memory ordering to avoid race conditions. The only race condition that can occur is - using the key store element before the key write is completed. Hence, while inserting the element the release memory order

[dpdk-dev] [PATCH v7 1/5] hash: separate multi-writer from rw-concurrency

2018-10-25 Thread Honnappa Nagarahalli
RW concurrency is required with single writer and multiple reader usecase as well. Hence, multi-writer should not be enabled by default when RW concurrency is enabled. Fixes: f2e3001b53ec ("hash: support read/write concurrency") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by

[dpdk-dev] [PATCH v7 0/5] Address reader-writer concurrency in rte_hash

2018-10-25 Thread Honnappa Nagarahalli
Currently, reader-writer concurrency problems in rte_hash are addressed using reader-writer locks. Use of reader-writer locks results in following issues: 1) In many of the use cases for the hash table, writer threads are running on control plane. If the writer is preemp

[dpdk-dev] Regarding -: net_vmxnet3: link status Interrupt is not working in DPDK 17.11.2 version

2018-10-25 Thread Verma, Siddharth
Hi , link status Interrupt is not working in DPDK 17.11.2 version for net_vmxnet3 driver , we are doing port connect/disconnect using vmware/ESXI but we are getting any LSI from DPDK. Looks like dpdk is not generating any event . Please do let me know, whether I am missing any configuraion/patch

Re: [dpdk-dev] [PATCH v3 3/6] test/hash: test more corner cases in unit test

2018-10-25 Thread Honnappa Nagarahalli
> > This commit improves the readwrite unit test to cover more corner cases and > reduces the testing time by reducing the total key count. > > Signed-off-by: Yipeng Wang > Acked-by: Bruce Richardson > --- > test/test/test_hash_readwrite.c | 31 +-- > 1 file changed,

Re: [dpdk-dev] [PATCH v2 3/7] net/mlx5: e-switch VXLAN flow translation routine

2018-10-25 Thread Yongseok Koh
On Thu, Oct 25, 2018 at 07:37:56AM -0700, Slava Ovsiienko wrote: > > -Original Message- > > From: Yongseok Koh > > Sent: Tuesday, October 23, 2018 13:06 > > To: Slava Ovsiienko > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH v2 3/7] net/mlx5: e-switch VXLAN flow translation >

Re: [dpdk-dev] [PATCH v2 2/7] net/mlx5: e-switch VXLAN flow validation routine

2018-10-25 Thread Yongseok Koh
On Thu, Oct 25, 2018 at 06:53:11AM -0700, Slava Ovsiienko wrote: > > -Original Message- > > From: Yongseok Koh > > Sent: Tuesday, October 23, 2018 13:05 > > To: Slava Ovsiienko > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH v2 2/7] net/mlx5: e-switch VXLAN flow validation > >

[dpdk-dev] [PATCH v3 2/6] test/hash: change multiwriter test to use jhash

2018-10-25 Thread Yipeng Wang
With sequential key, the test will cover more corner cases with jhash instead of crc hash, since jhash generates more random hash pattern on sequential key. It is useful for functional verification. Signed-off-by: Yipeng Wang --- test/test/test_hash_multiwriter.c | 3 ++- 1 file changed, 2 inser

[dpdk-dev] [PATCH v3 5/6] test/hash: remove hash scaling unit test

2018-10-25 Thread Yipeng Wang
The hash scaling unit test is not really needed any more since the multi-writer is supported now inside the library and it is tested by multi-writer unit test. Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson --- test/test/Makefile| 1 - test/test/autotest_data.py| 6 --

[dpdk-dev] [PATCH v3 3/6] test/hash: test more corner cases in unit test

2018-10-25 Thread Yipeng Wang
This commit improves the readwrite unit test to cover more corner cases and reduces the testing time by reducing the total key count. Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson --- test/test/test_hash_readwrite.c | 31 +-- 1 file changed, 25 insertions(+),

[dpdk-dev] [PATCH v3 4/6] test/hash: add readwrite test for ext table

2018-10-25 Thread Yipeng Wang
This commit improves the readwrite test to consider extendable table feature. Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson --- test/test/test_hash_readwrite.c | 42 + 1 file changed, 34 insertions(+), 8 deletions(-) diff --git a/test/test/test_h

[dpdk-dev] [PATCH v3 1/6] hash: fix unnecessary pause

2018-10-25 Thread Yipeng Wang
There is a rte_pause in hash table reset function. Since the loop is not a polling loop on shared data structure, the rte_pause is not needed. Fixes: b26473ff8f4a ("hash: add reset function") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson --- lib/librte_hash/rte_cuck

[dpdk-dev] [PATCH v3 6/6] test/hash: fix to add read-write test to autotest

2018-10-25 Thread Yipeng Wang
Add read-write concurrency test to meson and autotest file. Fixes: 0eb3726ebcf1 ("test/hash: add test for read/write concurrency") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang --- test/test/autotest_data.py | 6 ++ test/test/meson.build | 1 + 2 files changed, 7 insertions(+) diff -

[dpdk-dev] [PATCH v3 0/6] hash: improve multiple places

2018-10-25 Thread Yipeng Wang
This patch set depends on Honnappa's patch set: http://patchwork.dpdk.org/cover/47268/ This patch set fixes/improves a couple of places mostly on unit tests: commit 1: remove unnecessary code in hash library. commit 2: use jhash in multiwriter unit test. commit 3: cover more test case in unit tes

Re: [dpdk-dev] [PATCH v2 1/4] hash: fix unnecessary pause

2018-10-25 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >> --- >> lib/librte_hash/rte_cuckoo_hash.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/lib/librte_hash/rte_cuckoo_hash.c >> b/lib/librte_hash/rte_cuckoo_hash.c >> inde

Re: [dpdk-dev] [PATCH v6 2/5] hash: support do not free on delete

2018-10-25 Thread Honnappa Nagarahalli
> 24/10/2018 03:32, Honnappa Nagarahalli: > > /** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Free a hash key in the hash table given the position > > + * of the key. This operation is not multi-thread safe and should > > + * only be called fr

Re: [dpdk-dev] [PATCH v6 0/5] Address reader-writer concurrency in rte_hash

2018-10-25 Thread Honnappa Nagarahalli
> > 24/10/2018 03:32, Honnappa Nagarahalli: > > Dharmik Thakkar (1): > > test/hash: read-write lock-free concurrency test > > > > Honnappa Nagarahalli (4): > > hash: separate multi-writer from rw-concurrency > > hash: support do not free on delete > > hash: fix key store element alignment

Re: [dpdk-dev] [PATCH v2 3/4] test/hash: add readwrite test for ext table

2018-10-25 Thread Honnappa Nagarahalli
> Subject: [PATCH v2 3/4] test/hash: add readwrite test for ext table > > This commit improves the readwrite test to consider extendable table > feature and add more functional tests to cover more corner cases. > I think the part covering the more corner cases should go into a separate commit.

Re: [dpdk-dev] [PATCH v1 3/3] test/hash: add readwrite test for ext table

2018-10-25 Thread Honnappa Nagarahalli
> > On Wed, Oct 10, 2018 at 02:48:05PM -0700, Yipeng Wang wrote: > > This commit improves the readwrite test to consider extendable table > > feature and add more functional tests to cover more corner cases. > > > > Signed-off-by: Yipeng Wang --- > > test/test/test_hash_readwrite.c | 70 > > +

Re: [dpdk-dev] [PATCH v2 1/4] hash: fix unnecessary pause

2018-10-25 Thread Honnappa Nagarahalli
> > There is a rte_pause in hash table reset function. > Since the loop is not a polling loop on shared data structure, the rte_pause > is not needed. > > Fixes: b26473ff8f4a ("hash: add reset function") > Cc: sta...@dpdk.org > > Signed-off-by: Yipeng Wang > --- > lib/librte_hash/rte_cuckoo_ha

Re: [dpdk-dev] [PATCH v7 10/10] doc/vm_power_manager: add JSON interface API info

2018-10-25 Thread Thomas Monjalon
17/10/2018 15:05, David Hunt: > * added JSON interface API info Should be in patch 7 > * added meson/ninja build info Should be in patch 9 > * added Release Note changes Should be in patch 7 > Signed-off-by: David Hunt > Acked-by: Marko Kovacevic

Re: [dpdk-dev] [PATCH v8 05/13] telemetry: add client feature and sockets

2018-10-25 Thread Thomas Monjalon
25/10/2018 23:16, Richardson, Bruce: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 25/10/2018 22:44, Bruce Richardson: > > > On Thu, Oct 25, 2018 at 10:41:53PM +0200, Thomas Monjalon wrote: > > > > 25/10/2018 22:29, Thomas Monjalon: > > > > > 24/10/2018 18:03, Kevin Laatz: > > > > > > --

Re: [dpdk-dev] [PATCH v12 1/5] lib/librte_power: traffic pattern aware power control

2018-10-25 Thread Thomas Monjalon
19/10/2018 13:07, Liang Ma: > The proposed solution focuses on how many times empty polls are executed. > The less the number of empty polls, means current core is busy with > processing workload, therefore, the higher frequency is needed. The high > empty poll number indicates the current core not

Re: [dpdk-dev] [PATCH v12 1/5] lib/librte_power: traffic pattern aware power control

2018-10-25 Thread Thomas Monjalon
19/10/2018 13:07, Liang Ma: > --- a/lib/librte_power/Makefile > +++ b/lib/librte_power/Makefile > @@ -6,8 +6,9 @@ include $(RTE_SDK)/mk/rte.vars.mk > # library name > LIB = librte_power.a > > +CFLAGS += -DALLOW_EXPERIMENTAL_API We don't need this flag if we don't use experimental API from othe

Re: [dpdk-dev] [PATCH v12 5/5] doc: update release notes for empty poll library

2018-10-25 Thread Thomas Monjalon
Hi, This patch, like other doc patches should be merged with related code patches. 19/10/2018 13:07, Liang Ma: > Update the release nots for Traffic Pattern Aware Control > Library(empty poll). > > Signed-off-by: Liang Ma > --- > doc/guides/rel_notes/release_18_11.rst | 21 +++

Re: [dpdk-dev] [PATCH v2 1/7] net/mlx5: e-switch VXLAN configuration and definitions

2018-10-25 Thread Yongseok Koh
On Thu, Oct 25, 2018 at 05:50:26AM -0700, Slava Ovsiienko wrote: > > -Original Message- > > From: Yongseok Koh > > Sent: Tuesday, October 23, 2018 13:02 > > To: Slava Ovsiienko > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH v2 1/7] net/mlx5: e-switch VXLAN configuration and >

Re: [dpdk-dev] [PATCH v12 1/5] lib/librte_power: traffic pattern aware power control

2018-10-25 Thread Thomas Monjalon
26/10/2018 01:22, Thomas Monjalon: > Hi, > > It fails to compile (tried with meson build-gcc-static): > > lib/librte_power/rte_power_empty_poll.h:20:10: fatal error: > rte_timer.h: No such file or directory > > It looks to be fixed with this one-line change: > > --- a/lib/librte_power/mes

Re: [dpdk-dev] [PATCH v12 1/5] lib/librte_power: traffic pattern aware power control

2018-10-25 Thread Thomas Monjalon
Hi, It fails to compile (tried with meson build-gcc-static): lib/librte_power/rte_power_empty_poll.h:20:10: fatal error: rte_timer.h: No such file or directory It looks to be fixed with this one-line change: --- a/lib/librte_power/meson.build +++ b/lib/librte_power/meson.build @@ -8,3 +

Re: [dpdk-dev] [PATCH] doc: update release note for hash library

2018-10-25 Thread Thomas Monjalon
25/10/2018 20:45, Wang, Yipeng1: > > -Original Message- > > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > > > > > > +* **Added extendable bucket feature to hash library (rte_hash).** > > > + > > > + This new “extendable bucket” feature provides 100% insertion > > > + g

Re: [dpdk-dev] [PATCH v6 0/5] Address reader-writer concurrency in rte_hash

2018-10-25 Thread Thomas Monjalon
24/10/2018 03:32, Honnappa Nagarahalli: > Dharmik Thakkar (1): > test/hash: read-write lock-free concurrency test > > Honnappa Nagarahalli (4): > hash: separate multi-writer from rw-concurrency > hash: support do not free on delete > hash: fix key store element alignment > hash: add lock

Re: [dpdk-dev] [PATCH v6 2/5] hash: support do not free on delete

2018-10-25 Thread Thomas Monjalon
24/10/2018 03:32, Honnappa Nagarahalli: > /** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > + * Free a hash key in the hash table given the position > + * of the key. This operation is not multi-thread safe and should > + * only be called from one thread by

Re: [dpdk-dev] [PATCH v8 0/4] hash: add extendable bucket and partial key hashing

2018-10-25 Thread Thomas Monjalon
22/10/2018 20:39, Yipeng Wang: > This patch has dependency on another bug fix patch set: > http://patchwork.dpdk.org/cover/45611/ > > This patch set makes two major optimizations over the current rte_hash > library. > > First, it adds Extendable Bucket Table feature: a new structure that can > ac

[dpdk-dev] [PATCH] net/bonding: avoid making copy of mac address

2018-10-25 Thread Chas Williams
From: Chas Williams Calling rte_eth_macaddr_get to get a copy of the MAC address causes a hot spot according to profiling. We can easily get the current MAC address by just examining the bonded device. Signed-off-by: Chas Williams --- drivers/net/bonding/rte_eth_bond_pmd.c | 14 --

Re: [dpdk-dev] [PATCH v4 0/5] hash: fix multiple issues

2018-10-25 Thread Thomas Monjalon
28/09/2018 16:11, Yipeng Wang: > This patch set was part of extendable hash table patch > set before V2. According to Bruce's comment, this patch set > is now separated from the original patch set for easier > review and merge. > https://mails.dpdk.org/archives/dev/2018-September/112555.html > > T

Re: [dpdk-dev] [PATCH v8 05/13] telemetry: add client feature and sockets

2018-10-25 Thread Richardson, Bruce
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, October 25, 2018 9:50 PM > To: Richardson, Bruce > Cc: Laatz, Kevin ; dev@dpdk.org; Van Haaren, Harry > ; step...@networkplumber.org; > gaetan.ri...@6wind.com; shreyansh.j...@nxp.com; > mattias.r

Re: [dpdk-dev] [PATCH v8 05/13] telemetry: add client feature and sockets

2018-10-25 Thread Thomas Monjalon
25/10/2018 22:44, Bruce Richardson: > On Thu, Oct 25, 2018 at 10:41:53PM +0200, Thomas Monjalon wrote: > > 25/10/2018 22:29, Thomas Monjalon: > > > 24/10/2018 18:03, Kevin Laatz: > > > > --- a/lib/librte_telemetry/meson.build > > > > +++ b/lib/librte_telemetry/meson.build > > > > @@ -5,3 +5,5 @@ so

Re: [dpdk-dev] [PATCH v8 05/13] telemetry: add client feature and sockets

2018-10-25 Thread Bruce Richardson
On Thu, Oct 25, 2018 at 10:41:53PM +0200, Thomas Monjalon wrote: > 25/10/2018 22:29, Thomas Monjalon: > > 24/10/2018 18:03, Kevin Laatz: > > > --- a/lib/librte_telemetry/meson.build > > > +++ b/lib/librte_telemetry/meson.build > > > @@ -5,3 +5,5 @@ sources = files('rte_telemetry.c') > > > headers

Re: [dpdk-dev] [PATCH v8 05/13] telemetry: add client feature and sockets

2018-10-25 Thread Thomas Monjalon
25/10/2018 22:29, Thomas Monjalon: > 24/10/2018 18:03, Kevin Laatz: > > --- a/lib/librte_telemetry/meson.build > > +++ b/lib/librte_telemetry/meson.build > > @@ -5,3 +5,5 @@ sources = files('rte_telemetry.c') > > headers = files('rte_telemetry.h', 'rte_telemetry_internal.h') > > deps += ['metrics

Re: [dpdk-dev] [PATCH v8 03/13] telemetry: initial telemetry infrastructure

2018-10-25 Thread Thomas Monjalon
We forgot to add rte_telemetry.h in doxygen: doc/api/doxy-api-index.md doc/api/doxy-api.conf.in We need a section @file at the top of the header file to make it appear in doxygen. 24/10/2018 18:03, Kevin Laatz: > --- /dev/null > +++ b/lib/librte_telemetry/rte_telemetry.h > @@ -0,

Re: [dpdk-dev] [PATCH v2 7/7] net/mlx5: e-switch VXLAN rule cleanup routines

2018-10-25 Thread Slava Ovsiienko
> -Original Message- > From: Yongseok Koh > Sent: Thursday, October 25, 2018 3:37 > To: Slava Ovsiienko > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v2 7/7] net/mlx5: e-switch VXLAN rule cleanup routines > > On Mon, Oct 15, 2018 at 02:13:35PM +, Viacheslav Ovsiienko wrote:

Re: [dpdk-dev] [PATCH v8 11/13] doc: add telemetry documentation

2018-10-25 Thread Thomas Monjalon
24/10/2018 18:03, Kevin Laatz: > --- a/MAINTAINERS > +++ b/MAINTAINERS > +Telemetry - EXPERIMENTAL > +M: Kevin Laatz > +F: lib/librte_telemetry/ > +F: usertools/dpdk-telemetry-client.py > +F: doc/guides/howto/telemetry.rst It would be a bit better to introduce it in previous patches when files ar

[dpdk-dev] [PATCH v3] mlx5: use pkg-config to handle SUSE libmnl

2018-10-25 Thread Stephen Hemminger
SUSE decided to install the libmnl include file in a non-standard place: /usr/include/libmnl/libmnl/libmnl.h This was probably a mistake by the SUSE package maintainer, but hard to get fixed. Workaround the problem by pkg-config to find the necessary include directive for libmnl. Fixes: 20b71e92e

Re: [dpdk-dev] [PATCH v8 05/13] telemetry: add client feature and sockets

2018-10-25 Thread Thomas Monjalon
24/10/2018 18:03, Kevin Laatz: > --- a/lib/librte_telemetry/meson.build > +++ b/lib/librte_telemetry/meson.build > @@ -5,3 +5,5 @@ sources = files('rte_telemetry.c') > headers = files('rte_telemetry.h', 'rte_telemetry_internal.h') > deps += ['metrics', 'ethdev'] > cflags += '-DALLOW_EXPERIMENTAL

Re: [dpdk-dev] [PATCH v2 5/7] net/mlx5: e-switch VXLAN tunnel devices management

2018-10-25 Thread Slava Ovsiienko
> -Original Message- > From: Yongseok Koh > Sent: Thursday, October 25, 2018 3:28 > To: Slava Ovsiienko > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v2 5/7] net/mlx5: e-switch VXLAN tunnel devices > management > > On Mon, Oct 15, 2018 at 02:13:33PM +, Viacheslav Ovsiienko

[dpdk-dev] [PATCH v6 2/6] net/mlx5: add VXLAN encap action to Direct Verbs

2018-10-25 Thread Dekel Peled
This patch implements the VXLAN encap action in DV flow for MLX5 PMD. Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow.h| 2 + drivers/net/mlx5/mlx5_flow_dv.c | 351 +++- 2 files changed, 348 insertions(+), 5 deletions(-) diff --git a/drivers/n

[dpdk-dev] [PATCH v6 4/6] net/mlx5: add NVGRE encap action to Direct Verbs

2018-10-25 Thread Dekel Peled
This patch implements the nvgre encap action in DV flow for MLX5 PMD. Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow.h| 4 drivers/net/mlx5/mlx5_flow_dv.c | 27 --- 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/drivers/net/mlx5/mlx5_

[dpdk-dev] [PATCH v6 5/6] net/mlx5: add NVGRE decap action to Direct Verbs

2018-10-25 Thread Dekel Peled
This patch implements the NVGRE decap action in DV flow for MLX5 PMD. Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow.h| 4 drivers/net/mlx5/mlx5_flow_dv.c | 23 +++ 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow

[dpdk-dev] [PATCH v6 6/6] net/mlx5: add raw data encap decap to Direct Verbs

2018-10-25 Thread Dekel Peled
This patch implements the encap and decap actions, using raw data, in DV flow for MLX5 PMD. Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow.h| 12 ++- drivers/net/mlx5/mlx5_flow_dv.c | 227 ++-- 2 files changed, 224 insertions(+), 15 deletions(-

[dpdk-dev] [PATCH v6 0/6] add encap and decap actions to Direct Verbs flow in MLX5 PMD

2018-10-25 Thread Dekel Peled
This series adds support of encap and decap actions in DV format. L2 tunnel support for VXLAN and NVGRE, and L2/L3 tunnel support using raw data buffer. It is using the generic encapsulation framework from [1]. [1] "ethdev: add generic L2/L3 tunnel encapsulation actions" http://mails.dpdk.org

[dpdk-dev] [PATCH v6 3/6] net/mlx5: add VXLAN decap action to Direct Verbs

2018-10-25 Thread Dekel Peled
This patch implements the VXLAN decap action in DV flow for MLX5 PMD. Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow.h| 1 + drivers/net/mlx5/mlx5_flow_dv.c | 103 ++-- 2 files changed, 100 insertions(+), 4 deletions(-) diff --git a/drivers/n

[dpdk-dev] [PATCH v6 1/6] net/mlx5: add flow action functions to glue

2018-10-25 Thread Dekel Peled
This patch adds glue functions for operations: - Create packet reformat (encap/decap) flow action. - Destroy flow action. The new operations depend on HAVE_IBV_FLOW_DV_SUPPORT. Signed-off-by: Dekel Peled Acked-by: Yongseok Koh --- drivers/net/mlx5/Makefile| 2 +- drivers/net/mlx5/meson.bu

Re: [dpdk-dev] [PATCH] doc: update release note for hash library

2018-10-25 Thread Wang, Yipeng1
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > > > > +* **Added extendable bucket feature to hash library (rte_hash).** > > + > > + This new “extendable bucket” feature provides 100% insertion > > + guarantee to the capacity specified by the user

Re: [dpdk-dev] [PATCH v2] mlx5: use pkg-config to handle SUSE libmnl

2018-10-25 Thread Luca Boccassi
On Thu, 2018-10-25 at 11:04 -0700, Stephen Hemminger wrote: > SUSE decided to install the libmnl include file in a non-standard > place: /usr/include/libmnl/libmnl/libmnl.h > > This was probably a mistake by the SUSE package maintainer, > but hard to get fixed. Workaround the problem by pkg-config

[dpdk-dev] [PATCH v2] mlx5: use pkg-config to handle SUSE libmnl

2018-10-25 Thread Stephen Hemminger
SUSE decided to install the libmnl include file in a non-standard place: /usr/include/libmnl/libmnl/libmnl.h This was probably a mistake by the SUSE package maintainer, but hard to get fixed. Workaround the problem by pkg-config to find the necessary include directive for libmnl. Fixes: 20b71e92e

[dpdk-dev] [PATCH 3/3] net/ena: change version to v1.1.1

2018-10-25 Thread Michal Krawczyk
Version change is connected with major bug fixes. Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 191153a8f..0c0ed9302 100644 --- a/drivers/net/en

[dpdk-dev] [PATCH 2/3] net/ena: fix passing RSS hash to mbuf

2018-10-25 Thread Michal Krawczyk
The driver was passing to the mbuf Rx queue ID instead of hash received from the device. Now, the RSS hash from the Rx descriptor is being set. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Cc: sta...@dpdk.org Signed-off-by: Stewart Allen Acked-by: Michal Krawczyk --- drivers/net/ena/en

[dpdk-dev] [PATCH 0/3] net/ena: upgrade to v1.1.1

2018-10-25 Thread Michal Krawczyk
Hi, version upgrade containt two major fixes: * Memory leak fix on ena_start(), if it was called right after stop() * Provide application with valid hash, instead of queue ID The first issue was introduced in 18.08 when the additional states were added, and the second one was from the beginning.

[dpdk-dev] [PATCH 1/3] net/ena: recreate HW IO rings on start and stop

2018-10-25 Thread Michal Krawczyk
On the start the driver was refilling all Rx buffs, but the old ones were not released. That way running start/stop for a few times was causing device to run out of descriptors. To fix the issue, IO rings are now being destroyed on stop, and recreated on start. That way the device is not losing an

Re: [dpdk-dev] [PATCH] mlx5: use pkg-config to handle SUSE libmnl

2018-10-25 Thread Luca Boccassi
On Thu, 2018-10-25 at 10:46 -0700, Stephen Hemminger wrote: > SUSE decided to install the libmnl include file in a non-standard > place: /usr/include/libmnl/libmnl/libmnl.h > > This was probably a mistake by the SUSE package maintainer, > but hard to get fixed. Workaround the problem by pkg-config

[dpdk-dev] [PATCH] mlx5: use pkg-config to handle SUSE libmnl

2018-10-25 Thread Stephen Hemminger
SUSE decided to install the libmnl include file in a non-standard place: /usr/include/libmnl/libmnl/libmnl.h This was probably a mistake by the SUSE package maintainer, but hard to get fixed. Workaround the problem by pkg-config to find the necessary include directive for libmnl. Fixes: 20b71e92e

Re: [dpdk-dev] [PATCH] test/bpf: use hton instead of __builtin_bswap

2018-10-25 Thread Malvika Gupta
Hi Konstantin, At time of upstreaming the patch, I had compiled it on Cortex-A72 and it had worked with the -I parameter. But when tried building it on x86-64, I encountered the error that you were facing. From my understanding of this problem, this is a portability issue. As you pointed out, g

Re: [dpdk-dev] [PATCH] net/i40e: fix Rx instability with vector mode

2018-10-25 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Thursday, October 25, 2018 2:41 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix Rx instability with vector mode > > Previously, there is instability during vector Rx if descriptor number is not

Re: [dpdk-dev] [dpdk-users] Regarding -: net_vmxnet3: link status Interrupt is not working in DPDK 17.11.2 version

2018-10-25 Thread Stephen Hemminger
On Thu, 25 Oct 2018 16:52:07 +0530 siddharth verma wrote: > Hi , > link status Interrupt is not working in DPDK 17.11.2 version for > net_vmxnet3 driver , we are doing port connect/disconnect using vmware/ESXI > but we are getting any LSI from DPDK. Looks like dpdk is not generating any > event .

Re: [dpdk-dev] [PATCH v2 4/9] app/procinfo: add code for debug port

2018-10-25 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > +#include > +#include I am getting meson build error on this include. Make is fine though. Can you run "./devtools/test-meson-builds.sh" script to fix meson build errors if any . Thanks, Reshma

Re: [dpdk-dev] [PATCH v2 5/5] app/testpmd: setup attached ports on probe event

2018-10-25 Thread Iremonger, Bernard
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, October 25, 2018 4:11 PM > To: Iremonger, Bernard ; Wu, Jingjing > ; Lu, Wenzhuo > Cc: dev@dpdk.org; ophi...@mellanox.com; wis...@mellanox.com; Yigit, > Ferruh ; arybche...@solarflare.com > Subject:

Re: [dpdk-dev] [PATCH v2 4/5] app/testpmd: move ethdev events registration

2018-10-25 Thread Iremonger, Bernard
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, October 25, 2018 4:11 PM > To: Iremonger, Bernard ; Wu, Jingjing > ; Lu, Wenzhuo > Cc: dev@dpdk.org; ophi...@mellanox.com; wis...@mellanox.com; Yigit, > Ferruh ; arybche...@solarflare.com > Subject:

Re: [dpdk-dev] [PATCH v1 4/9] app/procinfo: add code for debug port

2018-10-25 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > Sent: Tuesday, October 23, 2018 2:58 PM > + printf("\t -- RSS len %u key (hex):", Why "(hex)" in printf?

Re: [dpdk-dev] [PATCH v1 4/9] app/procinfo: add code for debug port

2018-10-25 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > Sent: Tuesday, October 23, 2018 2:58 PM > To: dev@dpdk.org; Tahhan, Maryam ; Pattan, > Reshma > Cc: Patel, Amol ; Tummala, Sivaprasad > ; Byrne, Stephen1 > ; Glynn, Michael J > ; Varghese, Vipin > Subject: [PATCH v1 4/9] app/procinfo: add

Re: [dpdk-dev] [PATCH] bus/vdev: fix device argument corrupt after bus scan

2018-10-25 Thread Gaëtan Rivet
On Thu, Oct 25, 2018 at 03:18:20PM +, Zhang, Qi Z wrote: > > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Thursday, October 25, 2018 10:03 AM > > To: Zhang, Qi Z > > Cc: tho...@monjalon.net; dev@dpdk.org; sta...@dpdk.org > > Subject: Re: [PA

Re: [dpdk-dev] [PATCH v2] net/ixgbe: update PMD Tx offload mask

2018-10-25 Thread Zhang, Qi Z
> -Original Message- > From: Ye, Xiaolong > Sent: Thursday, October 25, 2018 2:45 AM > To: Yan, Zhirun > Cc: dev@dpdk.org; Zhang, Qi Z ; Xing, Beilei > > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: update PMD Tx offload mask > > On 10/25, Zhirun Yan wrote: > >Tx offload mask is upda

Re: [dpdk-dev] [PATCH v1 2/9] app/procinfo: add compare for new options

2018-10-25 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > +/**< Enable port debug. */ In comment , Enable displaying port info? > +static uint32_t enable_dbg_port; Do you want to consider replacing "debug" to "show" in code here other places? As you have already changed the commands to "show."

Re: [dpdk-dev] [PATCH] bus/vdev: fix device argument corrupt after bus scan

2018-10-25 Thread Zhang, Qi Z
> -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Thursday, October 25, 2018 10:03 AM > To: Zhang, Qi Z > Cc: tho...@monjalon.net; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] bus/vdev: fix device argument corrupt after bus scan > > On Thu, Oct 2

Re: [dpdk-dev] [PATCH v9 1/8] net/virtio: vring init for packed queues

2018-10-25 Thread Jens Freimann
On Thu, Oct 25, 2018 at 03:51:19PM +0200, Maxime Coquelin wrote: On 10/25/18 3:48 PM, Jens Freimann wrote: On Thu, Oct 25, 2018 at 05:21:15PM +0800, Tiwei Bie wrote: On Wed, Oct 24, 2018 at 04:32:29PM +0200, Jens Freimann wrote: Signed-off-by: Jens Freimann ??struct vring { unsigne

Re: [dpdk-dev] [PATCH v2 9/9] doc/procinfo: add information for debug options

2018-10-25 Thread Varghese, Vipin
> - --stats-reset | --xstats-reset] > + --stats-reset | --xstats-reset --dbg-port | --dbg-tm | --dbg-crypto | > + --dbg-mempool[=name] | --dbg-ring[=name]] I have noticed that the word 'dbg' has not been updated to 'show'. I will send v3.

[dpdk-dev] [PATCH v2 5/5] app/testpmd: setup attached ports on probe event

2018-10-25 Thread Thomas Monjalon
After probing is done, each new port must be setup. The new ports are currently guessed by iterating on ports matching the devargs string used for probing. When probing a port, it is possible that one more port probing get triggered (e.g. PF is automatically probed when probing a VF representor).

[dpdk-dev] [PATCH v2 4/5] app/testpmd: move ethdev events registration

2018-10-25 Thread Thomas Monjalon
The callback for ethdev events was registered on port start, so it was missing some events. It is now registered at the beginning of the main function. Signed-off-by: Thomas Monjalon --- app/test-pmd/testpmd.c | 72 -- 1 file changed, 42 insertions(+), 30

[dpdk-dev] [PATCH v2 3/5] app/testpmd: check not configuring port twice

2018-10-25 Thread Thomas Monjalon
It is possible to request probing of a device twice, and possibly get new ports for this device. However, the ports which were already probed and setup must not be setup again. That's why it is checked whether the port is already part of fwd_ports_ids array at the beginning of the function setup_at

[dpdk-dev] [PATCH v2 2/5] app/testpmd: merge ports list update functions

2018-10-25 Thread Thomas Monjalon
The arrays ports_ids and fwd_ports_ids require the same kind of update when some ports are removed or added. The functions update_fwd_ports() and remove_unused_fwd_ports() are merged in the new function remove_invalid_ports(). The part for adding new port is moved into setup_attached_port(). Sign

[dpdk-dev] [PATCH v2 0/5] app/testpmd: improve attach/detach support

2018-10-25 Thread Thomas Monjalon
While working on EAL probe/remove and ethdev iterator/close, some scenarios appeared to not be managed by testpmd, especially because it was not designed for multi-ports devices: - configure dependent port (detected via event) - configuring twice (if already probed before) - detaching twice

[dpdk-dev] [PATCH v2 1/5] app/testpmd: check not detaching device twice

2018-10-25 Thread Thomas Monjalon
The command "port detach" is removing the EAL rte_device of the ethdev port specified as parameter. The function name and some comments are updated to make clear that we are detaching the whole device. After detaching, the pointer, which maps a port to its device, is reset. This way, it is possibl

Re: [dpdk-dev] [PATCH] bus/vdev: fix device argument corrupt after bus scan

2018-10-25 Thread Gaëtan Rivet
On Thu, Oct 25, 2018 at 02:56:55PM +, Zhang, Qi Z wrote: > > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Thursday, October 25, 2018 4:51 AM > > To: Zhang, Qi Z > > Cc: tho...@monjalon.net; dev@dpdk.org; sta...@dpdk.org > > Subject: Re: [PAT

Re: [dpdk-dev] [PATCH] bus/vdev: fix device argument corrupt after bus scan

2018-10-25 Thread Zhang, Qi Z
> -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Thursday, October 25, 2018 4:51 AM > To: Zhang, Qi Z > Cc: tho...@monjalon.net; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] bus/vdev: fix device argument corrupt after bus scan > > On Thu, Oct 25

Re: [dpdk-dev] [PATCH] devtools: add git log checks for PHY

2018-10-25 Thread Thomas Monjalon
15/10/2018 16:53, Ferruh Yigit: > Signed-off-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH] devtools: add exception for OCTEON TX

2018-10-25 Thread Thomas Monjalon
10/10/2018 15:01, Anoob Joseph: > The 'TX' in OCTEON TX would cause a warning. Adding an exception for > that. > > OCTEON TX is a registered product under Cavium > > Signed-off-by: Anoob Joseph Applied, thanks

Re: [dpdk-dev] [PATCH] devtools: fix alignment of Marvell build options

2018-10-25 Thread Thomas Monjalon
18/10/2018 18:08, Ferruh Yigit: > On 10/18/2018 4:36 PM, Thomas Monjalon wrote: > > Really minor issue: > > There were extra spaces making the alignment wrong. > > > > Fixes: e95faac15110 ("crypto/mrvl: rename PMD to mvsam") > > Cc: t...@semihalf.com > > Fixes: 4ccc8d770d3b ("net/mvneta: add PMD s

Re: [dpdk-dev] [PATCH v9 2/8] net/virtio: add packed virtqueue defines

2018-10-25 Thread Jens Freimann
On Thu, Oct 25, 2018 at 05:22:37PM +0800, Tiwei Bie wrote: On Wed, Oct 24, 2018 at 04:32:30PM +0200, Jens Freimann wrote: Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ring.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_ring.h b

Re: [dpdk-dev] [PATCH v9 3/8] net/virtio: add packed virtqueue helpers

2018-10-25 Thread Jens Freimann
On Thu, Oct 25, 2018 at 05:23:53PM +0800, Tiwei Bie wrote: On Wed, Oct 24, 2018 at 04:32:31PM +0200, Jens Freimann wrote: Add helper functions to set/clear and check descriptor flags. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ring.h | 26 ++ 1 file cha

Re: [dpdk-dev] [PATCH v2 3/7] net/mlx5: e-switch VXLAN flow translation routine

2018-10-25 Thread Slava Ovsiienko
> -Original Message- > From: Yongseok Koh > Sent: Tuesday, October 23, 2018 13:06 > To: Slava Ovsiienko > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v2 3/7] net/mlx5: e-switch VXLAN flow translation > routine > > On Mon, Oct 15, 2018 at 02:13:31PM +, Viacheslav Ovsiienko w

Re: [dpdk-dev] [PATCH] doc: add deprecated list in doxygen

2018-10-25 Thread Thomas Monjalon
18/10/2018 18:16, Ferruh Yigit: > On 10/18/2018 5:09 PM, Thomas Monjalon wrote: > > The option GENERATE_DEPRECATEDLIST will create a page > > "Deprecated List" in "Related Pages" menu. > > +1 > > Acked-by: Ferruh Yigit Applied

  1   2   >