[dpdk-dev] a doubt about rss types action in rte_flow

2018-10-17 Thread Peng, Yuan
Hi Adrien, I have a doubt about the action rss types in rte_flow. testpmd> flow create 0 ingress pattern end actions rss types end / end what is the expected function of the command? Does it mean enable RSS in no types? So actually it can disable rss all? There are different execution result of

Re: [dpdk-dev] [PATCH v2] net/mlx5: flow counters support on the Linux-rdma v19 base

2018-10-17 Thread Shahaf Shuler
Hi Slava, Please see some comments below. Also - please rebase on top of series https://patches.dpdk.org/project/dpdk/list/?series=1961 It moves the verbs flow query to the mlx5_flow_verbs.c Wednesday, October 17, 2018 4:54 PM, Slava Ovsiienko: > Subject: [PATCH v2] net/mlx5: flow counters suppo

[dpdk-dev] [PATCH v1] igb_uio: fix unexpected removal for hot-unplug

2018-10-17 Thread Jeff Guo
When a device is hot-unplugged, pci_remove will be invoked unexpectedly before pci_release, it will caused kernel hung issue which will throw the error info of "Trying to free already-free IRQ XXX". And on the other hand, if pci_remove before pci_release, the interrupt will not got chance to be dis

Re: [dpdk-dev] [PATCH v10 7/8] igb_uio: fix unexpected remove issue for hotplug

2018-10-17 Thread Jeff Guo
hi, ferruh On 9/27/2018 11:07 PM, Ferruh Yigit wrote: On 8/17/2018 11:48 AM, Jeff Guo wrote: When a device is hotplugged out, the PCI resource is released in the kernel, the UIO file descriptor will disappear and the irq will be released. After this, a kernel crash will be caused if the igb uio

Re: [dpdk-dev] [PATCH v8 5/8] net/virtio: implement transmit path for packed queues

2018-10-17 Thread Tiwei Bie
On Tue, Oct 16, 2018 at 11:01:31AM +0200, Jens Freimann wrote: [...] > +void > +vq_ring_free_chain_packed(struct virtqueue *vq, uint16_t desc_idx) > +{ > + struct vring_desc_packed *dp; > + struct vq_desc_extra *dxp = NULL, *dxp_tail = NULL; > + uint16_t desc_idx_last = desc_idx; > + >

[dpdk-dev] [PATCH v4 5/5] test/hash: read-write lock-free concurrency test

2018-10-17 Thread Honnappa Nagarahalli
From: Dharmik Thakkar Unit tests to check for hash lookup and bulk-lookup perf with lock-free enabled and with lock-free disabled. Unit tests performed with readers running in parallel with writers. Tests include: - hash lookup on existing keys with: - hash add causing NO key-shifts of existi

[dpdk-dev] [PATCH v4 3/5] hash: fix key store element alignment

2018-10-17 Thread Honnappa Nagarahalli
Fix the key store array element alignment such that every array element is aligned on KEY_ALIGNMENT boundary. This is required to make 'pdata' in 'struct rte_hash_key' align on its natural boundary for atomic load/store. Fixes: 473d1bebce43 ("hash: allow to store data in hash table") Cc: Pablo de

[dpdk-dev] [PATCH v4 2/5] hash: support do not free on delete

2018-10-17 Thread Honnappa Nagarahalli
rte_hash_lookup_xxx APIs return the index of slot in the key store. Application(reader) can use that index to reference other data structures in its scope. Because of this, the index should not be freed till the application completes using the index. RTE_HASH_EXTRA_FLAGS_NO_FREE_ON_DEL is introduce

[dpdk-dev] [PATCH v4 1/5] hash: separate multi-writer from rw-concurrency

2018-10-17 Thread Honnappa Nagarahalli
RW concurrency is required with single writer and multiple reader usecase as well. Hence, multi-writer should not be enabled by default when RW concurrency is enabled. Fixes: f2e3001b53ec ("hash: support read/write concurrency") Cc: yipeng1.w...@intel.com Signed-off-by: Honnappa Nagarahalli Revi

[dpdk-dev] [PATCH v4 4/5] hash: add lock-free read-write concurrency

2018-10-17 Thread Honnappa Nagarahalli
Add lock-free read-write concurrency. This is achieved by the following changes. 1) Add memory ordering to avoid race conditions. The only race condition that can occur is - using the key store element before the key write is completed. Hence, while inserting the element the release memory order

[dpdk-dev] [PATCH v4 0/5] Address reader-writer concurrency in rte_hash

2018-10-17 Thread Honnappa Nagarahalli
This patch has dependency on the following patches in the order: http://patchwork.dpdk.org/cover/45611/ http://patchwork.dpdk.org/project/dpdk/list/?series=1822 Currently, reader-writer concurrency problems in rte_hash are addressed using reader-writer locks. Use of reader-writ

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix physic port socket initialization

2018-10-17 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 17, 2018 9:05 PM > To: Ananyev, Konstantin ; Phil Yang (Arm > Technology China) ; dev@dpdk.org > Subject: Re: [PATCH v2] app/testpmd: fix physic port socket initialization > > On 10/17/2018 12:02 PM, Ananyev, Konstantin

Re: [dpdk-dev] [PATCH v5 7/7] app/testpmd: check not detaching device twice

2018-10-17 Thread Thomas Monjalon
+Cc Bernard 18/10/2018 03:35, Thomas Monjalon: > The command "port detach" is removing the EAL rte_device > of the ethdev port specified as parameter. > > After detaching, the pointer, which maps a port to its device, > is resetted. This way, it is possible to check whether a port > is still asso

[dpdk-dev] [PATCH v5 7/7] app/testpmd: check not detaching device twice

2018-10-17 Thread Thomas Monjalon
The command "port detach" is removing the EAL rte_device of the ethdev port specified as parameter. After detaching, the pointer, which maps a port to its device, is resetted. This way, it is possible to check whether a port is still associated to a (not removed) device. Signed-off-by: Thomas Mon

[dpdk-dev] [PATCH v5 6/7] eal: remove deprecated attach/detach functions

2018-10-17 Thread Thomas Monjalon
These hotplug functions were deprecated and have some new replacements. As announced earlier, the oldest ones are now removed. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst| 5 --- doc/guides/rel_notes/release_18_11.rst | 6 +++ lib

[dpdk-dev] [PATCH v5 5/7] ethdev: remove deprecated attach/detach functions

2018-10-17 Thread Thomas Monjalon
The hotplug attach/detach features are implemented in EAL layer. There is a new ethdev iterator to retrieve ports from ethdev layer. As announced earlier, the (buggy) ethdev functions are now removed. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v5 4/7] doc: replace doxygen example in contribution guide

2018-10-17 Thread Thomas Monjalon
The provided example of doxygen header is about a deprecated function. It is replaced by rte_spinlock_trylock() which is small and good enough for the purpose. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- doc/guides/contributing/documentation.rst | 15 +-- 1 file

[dpdk-dev] [PATCH v5 3/7] ethdev: allow iterating with pure class filter

2018-10-17 Thread Thomas Monjalon
If no rte_device is given in the iterator, eth_dev_match() is looking at all ports without any restriction, except the ethdev kvargs filter. It allows to iterate with a devargs filter referencing only some ethdev parameters. The format (from the new devargs syntax) is: class=eth,paramY=Y

[dpdk-dev] [PATCH v5 1/7] bus/vdev: add iteration filter on name

2018-10-17 Thread Thomas Monjalon
A virtual device can be matched with following syntax: bus=vdev,name=X Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- drivers/bus/vdev/vdev_params.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vdev/vdev_params.c

[dpdk-dev] [PATCH v5 2/7] ethdev: add iterator to match devargs input

2018-10-17 Thread Thomas Monjalon
The iterator will return the ethdev port ids matching a devargs string. It is recommended to use the macro RTE_ETH_FOREACH_MATCHING_DEV() for usage convenience. The class string is prefixed with '+' in order to skip the validation of the parameter keys. It is tolerated for the compatibility with t

[dpdk-dev] [PATCH v5 0/7] replace attach/detach functions

2018-10-17 Thread Thomas Monjalon
The functions for EAL attach/detach had already some replacements, so they are removed. The functions for ethdev attach/detach are removed and replaced thanks to a new ethdev iterator working with devargs. rte_eth_dev_attach(devargs, &port_id) is replaced by: rte_dev_probe(devargs); RT

[dpdk-dev] [PATCH v5 4/6] ethdev: free all common data when releasing port

2018-10-17 Thread Thomas Monjalon
This is a clean-up of common ethdev data freeing. All data freeing are moved to rte_eth_dev_release_port() and done only in case of primary process. It is probably fixing some memory leaks for PMDs which were not freeing all data. Signed-off-by: Thomas Monjalon --- drivers/net/af_packet/rte_eth

[dpdk-dev] [PATCH v5 3/6] ethdev: fix doxygen comments of shared data fields

2018-10-17 Thread Thomas Monjalon
Some doxygen comments were wrongly associated to the next field because of syntax /** instead of /**< Some other cleanups (like alignment) are done. Signed-off-by: Thomas Monjalon --- lib/librte_ethdev/rte_ethdev_core.h | 28 +--- 1 file changed, 13 insertions(+), 15 del

[dpdk-dev] [PATCH v5 5/6] ethdev: remove release function for secondary process

2018-10-17 Thread Thomas Monjalon
After previous changes, the function rte_eth_dev_release_port() can be used for primary or secondary process as well. The only difference with rte_eth_dev_release_port_secondary() is the shared lock used in rte_eth_dev_release_port(). The function rte_eth_dev_release_port_secondary() was recently

[dpdk-dev] [PATCH v5 6/6] ethdev: complete closing of port

2018-10-17 Thread Thomas Monjalon
After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is deprecated. Instead of blindly removing the associated rte_device, the driver should check if no more port (ethdev, cryptodev, etc) is

[dpdk-dev] [PATCH v5 0/6] ethdev port freeing

2018-10-17 Thread Thomas Monjalon
The function rte_eth_dev_detach() is freeing a port and its underlying rte_device object. The issue is that we may have several ports associated to the same rte_device. The right replacement is to free the port, and free the rte_device if no more ports. At ethdev level, the public function for por

[dpdk-dev] [PATCH v5 2/6] app/testpmd: allow detaching a port not closed

2018-10-17 Thread Thomas Monjalon
The testpmd application aim is for testing; so order of operations should not be enforced. There was a test to forbid detaching before closing a port. However, it may interesting to test what happens in such case. It is possible for a PMD to automatically close the port when detaching. in order t

[dpdk-dev] [PATCH v5 1/6] app/testpmd: fix ports list after removing several at once

2018-10-17 Thread Thomas Monjalon
From: Wisam Jaddo When detaching a port, the full rte_device is removed. If the rte_device was hosting several ports, the testpmd list of ports must be updated for multiple removals. Signed-off-by: Wisam Jaddo --- app/test-pmd/testpmd.c | 36 +--- 1 file changed

[dpdk-dev] [PATCH] devargs: fix freeing during device removal

2018-10-17 Thread Thomas Monjalon
After calling unplug function of a bus, the device is expected to be freed. It is too late for getting devargs to remove. Anyway, the buses which implement unplug are already freeing the devargs, except the PCI bus. So the call to rte_devargs_remove() is removed from EAL and added in PCI. Fixes: 2

Re: [dpdk-dev] Multiple compilation failures in recent commits on branch master.

2018-10-17 Thread Dan Gora
Ok, never mind.. I see that it was fixed right after I pulled yesterday... commit 41c24ea294fe6c69ee8c1b814c2475af0e74d821 (net/dpaa2: fix MAC address initialization) On Wed, Oct 17, 2018 at 8:44 PM Dan Gora wrote: > > Hi All, > > I sent a patch yesterday to fix a compilation failure in the > t

[dpdk-dev] Multiple compilation failures in recent commits on branch master.

2018-10-17 Thread Dan Gora
Hi All, I sent a patch yesterday to fix a compilation failure in the test_external_mem test and I pulled origin yesterday and now there is another compilation failure which was introduced in commit c3e0a706fd7595733cf51 (net/dpaa2: read hardware provided MAC for DPNI devices): /home/dg/Network_Fa

[dpdk-dev] [PATCH v5] compress/qat: enable dynamic huffman encoding

2018-10-17 Thread Fiona Trahe
Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe Acked-by: Arek Kusztal --- v5 changes: - update release note v4 changes: - use #define for IM buffer logs, disable all by default and use param for clearer hexdump length. v3 cha

Re: [dpdk-dev] [PATCH] doc: update release note for hash library

2018-10-17 Thread Honnappa Nagarahalli
> > This patch updates release note for the new extendable bucket feature and > the partial-key hashing. > > Signed-off-by: Yipeng Wang > --- > doc/guides/rel_notes/release_18_11.rst | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/doc/guides/rel_notes/release_18_11.rst > b/doc/

[dpdk-dev] [PATCH v4 2/3] net/mlx5: add flow query abstraction interface

2018-10-17 Thread Moti Haimovsky
Flow engine now supports multiple driver paths with each having its own flow query implantation routine. This patch adds an abstraction to the flow query routine in accordance to commit 0c76d1c9a18d ("net/mlx5: add abstraction for multiple flow drivers") done by Yongseok Koh. Signed-off-by: Moti H

[dpdk-dev] [PATCH v4 1/3] net/mlx5: refactor TC-flow infrastructure

2018-10-17 Thread Moti Haimovsky
This commit refactors tc_flow as a preparation to coming commits that sends different type of messages and expect differ type of replies while still using the same underlying routines. Signed-off-by: Moti Haimovsky --- v3: * Rebase on top of d80c8167c4fe ("net/mlx5: fix compilation issue on A

[dpdk-dev] [PATCH v4 3/3] net/mlx5: support e-switch flow count action

2018-10-17 Thread Moti Haimovsky
This commit adds support for configuring flows destined to the mlx5 eswitch with 'count' action and for querying these counts at runtime. Each flow rule configured by the mlx5 driver is implicitly assigned with flow counters. These counters can be retrieved when querying the flow rule via Netlink,

[dpdk-dev] [PATCH v4 0/3] support e-switch flow count action

2018-10-17 Thread Moti Haimovsky
The following patches add support in mlx5 PMD for configuring and reading flow counters from the device e-switch. Moti Haimovsky (3): net/mlx5: refactor TC-flow infrastructure net/mlx5: add flow query abstraction interface net/mlx5: support e-switch flow count action drivers/net/mlx5/mlx5.

[dpdk-dev] [PATCH v5 3/3] app/testpmd: add MPLSoGRE encapsulation

2018-10-17 Thread Ori Kam
Example for MPLSoGRE tunnel: ETH / IPV4 / GRE / MPLS / IP / L4..L7 In order to encapsulate such a tunnel there is a need to remove L2 of the inner packet and encap the remaining tunnel, this is done by applying 2 rte flow commands l2_decap followed by mplsogre_encap. Both commands must appear in t

[dpdk-dev] [PATCH v5 1/3] ethdev: add raw encapsulation action

2018-10-17 Thread Ori Kam
Currenlty the encap/decap actions only support encapsulation of VXLAN and NVGRE L2 packets (L2 encapsulation is where the inner packet has a valid Ethernet header, while L3 encapsulation is where the inner packet doesn't have the Ethernet header). In addtion the parameter to to the encap action is

[dpdk-dev] [PATCH v5 2/3] app/testpmd: add MPLSoUDP encapsulation

2018-10-17 Thread Ori Kam
MPLSoUDP is an example for L3 tunnel encapsulation. L3 tunnel type is a tunnel that is missing the layer 2 header of the inner packet. Example for MPLSoUDP tunnel: ETH / IPV4 / UDP / MPLS / IP / L4..L7 In order to encapsulate such a tunnel there is a need to remove L2 of the inner packet and enc

[dpdk-dev] [PATCH v5 0/3] ethdev: add generic raw tunnel encapsulation actions

2018-10-17 Thread Ori Kam
This series implement the raw tunnel encapsulation actions and is based on rfc [1] "add generic L2/L3 tunnel encapsulation actions" Currenlty the encap/decap actions only support encapsulation of VXLAN and NVGRE L2 packets (L2 encapsulation is where the inner packet has a valid Ethernet header, wh

Re: [dpdk-dev] [PATCH] ethdev: add function name to log message

2018-10-17 Thread Ferruh Yigit
On 10/17/2018 10:26 AM, Gaëtan Rivet wrote: > Hi Ferruh, > > On Tue, Oct 16, 2018 at 04:55:43PM +0100, Ferruh Yigit wrote: >> On 10/12/2018 3:54 PM, Stephen Hemminger wrote: >>> On Fri, 12 Oct 2018 14:43:57 +0200 >>> Adrien Mazarguil wrote: >>> On Fri, Oct 12, 2018 at 11:45:01AM +0100, Ferru

Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement

2018-10-17 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona >Sent: 17 October 2018 22:15 >To: Verma, Shally ; Daly, Lee >Cc: Jozwiak, TomaszX ; dev@dpdk.org; >akhil.go...@nxp.com; Trahe, Fiona >Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance >measurement > >External Email > >> --

Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement

2018-10-17 Thread Trahe, Fiona
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Wednesday, October 17, 2018 8:43 AM > To: Trahe, Fiona ; Daly, Lee > Cc: Jozwiak, TomaszX ; dev@dpdk.org; > akhil.go...@nxp.com > Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance

Re: [dpdk-dev] [PATCH v6 3/3] app/testpmd: set packet dump based on verbosity level

2018-10-17 Thread Ferruh Yigit
On 10/17/2018 5:24 PM, Iremonger, Bernard wrote: > Hi Raslan, > >> -Original Message- >> From: Raslan Darawsheh [mailto:rasl...@mellanox.com] >> Sent: Wednesday, October 17, 2018 4:22 PM >> To: Wu, Jingjing >> Cc: tho...@monjalon.net; dev@dpdk.org; shah...@mellanox.com; >> rasl...@mellano

Re: [dpdk-dev] [PATCH v2 2/5] test: add quick run tests under test-fast suite

2018-10-17 Thread Pattan, Reshma
> -Original Message- > From: Vemula, Hari KumarX > Sent: Friday, October 12, 2018 3:33 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Pattan, Reshma > ; Vemula, Hari KumarX > > Subject: [PATCH v2 2/5] test: add quick run tests under test-fast suite > > From: Hari Kumar Vemula > +

Re: [dpdk-dev] [PATCH v6 3/3] app/testpmd: set packet dump based on verbosity level

2018-10-17 Thread Iremonger, Bernard
Hi Raslan, > -Original Message- > From: Raslan Darawsheh [mailto:rasl...@mellanox.com] > Sent: Wednesday, October 17, 2018 4:22 PM > To: Wu, Jingjing > Cc: tho...@monjalon.net; dev@dpdk.org; shah...@mellanox.com; > rasl...@mellanox.com; xuemi...@mellanox.com; or...@mellanox.com; > jerin.j

Re: [dpdk-dev] [PATCH v2 2/5] test: add quick run tests under test-fast suite

2018-10-17 Thread Pattan, Reshma
> -Original Message- > From: Vemula, Hari KumarX > Sent: Friday, October 12, 2018 3:33 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Pattan, Reshma > ; Vemula, Hari KumarX > > Subject: [PATCH v2 2/5] test: add quick run tests under test-fast suite > > + > + itr = 0 > +for

Re: [dpdk-dev] [PATCH v6 1/3] app/testpmd: move dumping packets to a separate function

2018-10-17 Thread Ferruh Yigit
On 10/17/2018 4:22 PM, Raslan Darawsheh wrote: > verbosity for the received/sent packets is needed in all of the > forwarding engines so moving it to be in a separate function > > Acked-by: Bernard Iremonger > Signed-off-by: Raslan Darawsheh Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2 2/5] test: add quick run tests under test-fast suite

2018-10-17 Thread Pattan, Reshma
> -Original Message- > From: Vemula, Hari KumarX > Sent: Friday, October 12, 2018 3:33 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Pattan, Reshma > ; Vemula, Hari KumarX > > Subject: [PATCH v2 2/5] test: add quick run tests under test-fast suite > > From: Hari Kumar Vemula > > >

Re: [dpdk-dev] [PATCH v8 3/3] net/tap: allow secondary process to access primary device queues

2018-10-17 Thread Ferruh Yigit
On 10/17/2018 3:45 PM, Raslan Darawsheh wrote: > In the case the device is created by the primary process, > the secondary must request some file descriptors to attach the queues. > The file descriptors are shared via IPC Unix socket. > > Thanks to the IPC synchronization, the secondary process >

Re: [dpdk-dev] [PATCH v5 01/13] eal: add param register infrastructure

2018-10-17 Thread Gaëtan Rivet
Some suggestions, On Tue, Oct 16, 2018 at 04:57:50PM +0100, Kevin Laatz wrote: > This commit adds infrastructure to EAL that allows an application to > register it's init function with EAL. This allows libraries to be > initialized at the end of EAL init. > > This infrastructure allows libraries

Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement

2018-10-17 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona >Sent: 17 October 2018 20:04 >To: Daly, Lee ; Verma, Shally >Cc: Jozwiak, TomaszX ; dev@dpdk.org; >akhil.go...@nxp.com; Trahe, Fiona >Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance >measurement > >External Email > >Hi S

Re: [dpdk-dev] [PATCH v4 0/6] kni: add API to set link status on kernel interface

2018-10-17 Thread Ferruh Yigit
On 10/17/2018 2:04 AM, Dan Gora wrote: > Hi All, > > Attached is version 4 of a patchset to add a new API function to > set the link status on kernel interfaces created with the KNI kernel > module. > > v4 > > * Rework rte_kni_update_link to only take linkup/linkdown as parameter, > return

Re: [dpdk-dev] [PATCH v5 1/3] app/testpmd: move dumping packets to a separate function

2018-10-17 Thread Raslan Darawsheh
Sending a newer version with the fix. Kindest regards, Raslan Darawsheh > -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, October 17, 2018 3:59 PM > To: Yigit, Ferruh ; Raslan Darawsheh > ; Wu, Jingjing > Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf > Shuler ; Xueming(St

[dpdk-dev] [PATCH v6 2/3] app/testpmd: add packet dump callback functions

2018-10-17 Thread Raslan Darawsheh
add new rx/tx callback functions to be used for dumping the packets. Signed-off-by: Raslan Darawsheh Acked-by: Bernard Iremonger --- changes in v6: rebase the work on top of the fix for compilation --- --- app/test-pmd/config.c | 67 ++

[dpdk-dev] [PATCH v6 3/3] app/testpmd: set packet dump based on verbosity level

2018-10-17 Thread Raslan Darawsheh
when changing verbosity level it will configure rx/tx callbacks to dump packets based on the verbosity value as following: 1- dump only received packets: testpmd> set verbose 1 2- dump only sent packets: testpmd> set verbose 2 3- dump sent and received packets: test

[dpdk-dev] [PATCH v6 1/3] app/testpmd: move dumping packets to a separate function

2018-10-17 Thread Raslan Darawsheh
verbosity for the received/sent packets is needed in all of the forwarding engines so moving it to be in a separate function Acked-by: Bernard Iremonger Signed-off-by: Raslan Darawsheh --- changes in v6: - fix compilation issue for patch --- --- app/test-pmd/Makefile| 1 + app/te

Re: [dpdk-dev] [PATCH v4 3/6] kni: set default carrier state of interface

2018-10-17 Thread Ferruh Yigit
On 10/17/2018 2:04 AM, Dan Gora wrote: > +static int __init > +kni_parse_carrier_state(void) > +{ > + if (!carrier) > + dflt_carrier = 0; > + > + if (strcmp(carrier, "off") == 0) > + dflt_carrier = 0; > + else if (strcmp(carrier, "on") == 0) > + dflt_

Re: [dpdk-dev] [PATCH] test: disable alarm autotest in FreeBSD

2018-10-17 Thread Pattan, Reshma
> -Original Message- > From: Poornima, PallantlaX > Sent: Wednesday, September 19, 2018 3:39 PM > To: dev@dpdk.org > Cc: Burakov, Anatoly ; Pattan, Reshma > ; Poornima, PallantlaX > > Subject: [PATCH] test: disable alarm autotest in FreeBSD > > Disabled the alarm_autotest UT in FreeBSD

Re: [dpdk-dev] [PATCH] examples/service_cores: check lcores before test run

2018-10-17 Thread Van Haaren, Harry
> -Original Message- > From: Varghese, Vipin > Sent: Friday, October 12, 2018 6:14 AM > To: dev@dpdk.org; Van Haaren, Harry > Cc: Byrne, Stephen1 ; Varghese, Vipin > > Subject: [PATCH] examples/service_cores: check lcores before test run > > The service core samples has varied profiles c

[dpdk-dev] [PATCH v8 1/3] net/tap: add queue and port ids in Rx/Tx queues structures

2018-10-17 Thread Raslan Darawsheh
Port and queue ids are added to easily map the file descriptors stored in each process private. Signed-off-by: Raslan Darawsheh --- drivers/net/tap/rte_eth_tap.c | 3 +++ drivers/net/tap/rte_eth_tap.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers

Re: [dpdk-dev] [PATCH v7 3/3] net/tap: allow secondary process to access primary device queues

2018-10-17 Thread Raslan Darawsheh
You right about that fixed in the new version Kindest regards, Raslan Darawsheh > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 17, 2018 3:07 PM > To: Raslan Darawsheh ; keith.wi...@intel.com > Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf > Shuler ; Ori Kam > Subject:

[dpdk-dev] [PATCH v8 3/3] net/tap: allow secondary process to access primary device queues

2018-10-17 Thread Raslan Darawsheh
In the case the device is created by the primary process, the secondary must request some file descriptors to attach the queues. The file descriptors are shared via IPC Unix socket. Thanks to the IPC synchronization, the secondary process is now able to do Rx/Tx on a TAP created by the primary pro

[dpdk-dev] [PATCH v8 2/3] net/tap: move fds of Rx/Tx queues to be in process private

2018-10-17 Thread Raslan Darawsheh
fd's cannot be shared between processes, and each process need to have it's own fd's pointer. Signed-off-by: Raslan Darawsheh --- This patch has dependancy on the following patch http://patches.dpdk.org/patch/46185/ --- --- drivers/net/tap/rte_eth_tap.c | 93 +-

Re: [dpdk-dev] [PATCH] test: reduce test duration for efd autotest

2018-10-17 Thread Pattan, Reshma
> -Original Message- > From: Parthasarathy, JananeeX M > Sent: Wednesday, September 26, 2018 3:19 PM > To: dev@dpdk.org > Cc: Marohn, Byron ; De Lara Guarch, Pablo > ; Pattan, Reshma > ; Parthasarathy, JananeeX M > > Subject: [PATCH] test: reduce test duration for efd autotest > > +

Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement

2018-10-17 Thread Trahe, Fiona
Hi Shally, Lee, > -Original Message- > From: Daly, Lee > Sent: Monday, October 15, 2018 8:10 AM > To: Verma, Shally > Cc: Jozwiak, TomaszX ; dev@dpdk.org; Trahe, Fiona > ; akhil.go...@nxp.com > Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance > measurement > > Than

[dpdk-dev] [PATCH v1] devargs: fix variadic parsing memory leak

2018-10-17 Thread Gaetan Rivet
rte_devargs_parsef will leak memory each time it is called. The device string must be freed. Fixes: a23bc2c4e01b ("devargs: add non-variadic parsing function") CC: sta...@dpdk.org Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 6 +- 1 file changed, 5 insertions(

Re: [dpdk-dev] [PATCH v5 01/13] eal: add param register infrastructure

2018-10-17 Thread Thomas Monjalon
17/10/2018 16:09, Laatz, Kevin: > Hi Thomas, > > > On 17/10/2018 14:46, Thomas Monjalon wrote: > > 17/10/2018 13:45, Gaëtan Rivet: > >> Hi Thomas, > >> > >> On Wed, Oct 17, 2018 at 11:41:53AM +0200, Thomas Monjalon wrote: > >>> I still think all the wording is incorrect. > >>> Please start by des

Re: [dpdk-dev] [PATCH v5 01/13] eal: add param register infrastructure

2018-10-17 Thread Laatz, Kevin
Hi Thomas, On 17/10/2018 14:46, Thomas Monjalon wrote: 17/10/2018 13:45, Gaëtan Rivet: Hi Thomas, On Wed, Oct 17, 2018 at 11:41:53AM +0200, Thomas Monjalon wrote: I still think all the wording is incorrect. Please start by describing what is "param", "flag" and "option" in your mind. They ar

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: support metadata as flow rule criteria

2018-10-17 Thread Andrew Rybchenko
On 10/17/18 3:03 PM, Dekel Peled wrote: As described in [1], a new rte_flow item is added to support metadata to use as flow rule match pattern. The metadata is an opaque item, fully controlled by the application. The use of metadata is relevant for egress rules only. It can be set in the flow r

Re: [dpdk-dev] [PATCH v5 01/13] eal: add param register infrastructure

2018-10-17 Thread Laatz, Kevin
Hi Thomas, On 17/10/2018 12:45, Gaëtan Rivet wrote: Hi Thomas, On Wed, Oct 17, 2018 at 11:41:53AM +0200, Thomas Monjalon wrote: I still think all the wording is incorrect. Please start by describing what is "param", "flag" and "option" in your mind. They are all mentioned in this file. Are you

Re: [dpdk-dev] [PATCH v3 6/7] hash: enable lock-free reader-writer concurrency

2018-10-17 Thread Honnappa Nagarahalli
> >Subject: [PATCH v3 6/7] hash: enable lock-free reader-writer > >concurrency > > > >Add the flag to enable reader-writer concurrency during run time. The > >rte_hash_del_xxx APIs do not free the keystore element when this flag > >is enabled. Hence a new API, rte_hash_free_key_with_position, to fr

[dpdk-dev] [PATCH v2] net/mlx5: flow counters support on the Linux-rdma v19 base

2018-10-17 Thread Viacheslav Ovsiienko
Mellanox mlx5 PMD supports Flow Counters via Verbs library. The current implementation is based on the Mellanox proprietary Verbs library included in MLNX OFED packages. The Flow Counter support is recently added into linux-rdma release (v19), so the mlx5 PMD update is needed to provide Counter fea

[dpdk-dev] [PATCH] [pktgen] Fix the compiling with Lua from source

2018-10-17 Thread Bing Zhao
In some other distributions excpet Ubuntu, the Lua verison is quite old and some interfaces show incompatible. If manually building Lua version 5.3 from source code. By default, only the static library is generated for using. Then due to the fact that there is some dependence between library files

Re: [dpdk-dev] [PATCH v5 01/13] eal: add param register infrastructure

2018-10-17 Thread Thomas Monjalon
17/10/2018 13:45, Gaëtan Rivet: > Hi Thomas, > > On Wed, Oct 17, 2018 at 11:41:53AM +0200, Thomas Monjalon wrote: > > I still think all the wording is incorrect. > > Please start by describing what is "param", "flag" and "option" in your > > mind. > > They are all mentioned in this file. > > Are

Re: [dpdk-dev] [PATCH] test: reduce test duration for efd autotest

2018-10-17 Thread Pattan, Reshma
> -Original Message- > From: Parthasarathy, JananeeX M > Sent: Wednesday, September 26, 2018 3:19 PM > To: dev@dpdk.org > > struct rte_efd_table *handle = NULL; > uint32_t num_rules_in = TABLE_SIZE; > - uint8_t simple_key[EFD_TEST_KEY_LEN]; You need to remove EFD_TEST_K

Re: [dpdk-dev] [PATCH v3] net/softnic: add support for flow API vxlan encap action

2018-10-17 Thread Dumitrescu, Cristian
> -Original Message- > From: Pattan, Reshma > Sent: Tuesday, October 16, 2018 3:29 PM > To: dev@dpdk.org; Dumitrescu, Cristian > Cc: Pattan, Reshma > Subject: [PATCH v3] net/softnic: add support for flow API vxlan encap action > > Added support to handle vxlan encap action of rte flow

Re: [dpdk-dev] [PATCH] net/softnic: add support for vxlan encap

2018-10-17 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Cristian Dumitrescu > Sent: Friday, October 12, 2018 12:52 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/softnic: add support for vxlan encap > > Add CLI support for VXLAN encap. > > Signed-off-by: Cr

[dpdk-dev] [PATCH v7 10/10] doc/vm_power_manager: add JSON interface API info

2018-10-17 Thread David Hunt
* added JSON interface API info * added meson/ninja build info * added Release Note changes Signed-off-by: David Hunt Acked-by: Marko Kovacevic --- doc/guides/rel_notes/release_18_11.rst| 8 + .../sample_app_ug/vm_power_management.rst | 300 +- 2 files changed, 306

[dpdk-dev] [PATCH v7 07/10] examples/power: add json string handling

2018-10-17 Thread David Hunt
Add JSON string handling to vm_power_manager for JSON strings received through the fifo. The format of the JSON strings are detailed in the next patch, the vm_power_manager user guide documentation updates. This patch introduces a new dependency on Jansson, a C library for encoding, decoding and m

[dpdk-dev] [PATCH v7 09/10] examples/power: add meson/ninja build support

2018-10-17 Thread David Hunt
Add meson.build in vm_power_manager and the guest_cli subdirectory. Building can be achieved by going to the build directory, and using meson configure -Dexamples=vm_power_manager,vm_power_manager/guest_cli Then, when ninja is invoked, it will build dpdk-vm_power_manger and dpdk-guest_cli Work s

[dpdk-dev] [PATCH v7 06/10] examples/power: increase allowed number of clients

2018-10-17 Thread David Hunt
Now that we're handling host policies, containers and virtual machines, we'll rename MAX_VMS to MAX_CLIENTS, and increase from 4 to 64 Signed-off-by: David Hunt Acked-by: Anatoly Burakov --- examples/vm_power_manager/channel_manager.h | 4 ++-- examples/vm_power_manager/channel_monitor.c | 10

[dpdk-dev] [PATCH v7 08/10] examples/power: clean up verbose messages

2018-10-17 Thread David Hunt
Some messages appearing several times a second, removing as they are unnecessary. Other less severe messages change from INFO to DEBUG Signed-off-by: David Hunt Acked-by: Anatoly Burakov --- examples/vm_power_manager/channel_monitor.c | 19 +-- 1 file changed, 5 insertions(+), 1

[dpdk-dev] [PATCH v7 05/10] examples/power: add host channel to power manager

2018-10-17 Thread David Hunt
This patch adds a fifo channel to the vm_power_manager app through which we can send commands and polices. Intended for sending JSON strings. The fifo is at /tmp/powermonitor/fifo Signed-off-by: David Hunt Acked-by: Anatoly Burakov --- examples/vm_power_manager/channel_manager.c | 109 +

[dpdk-dev] [PATCH v7 03/10] lib/power: add changes for host commands/policies

2018-10-17 Thread David Hunt
This patch does a couple of things: * Adds a new message type for removing policies (PKT_POLICY_REMOVE) Used when we want to remove a previously created policy. * Adds a core_type bool to the channel packet struct to specify whether the type of core we want to control is cirtual or phys

[dpdk-dev] [PATCH v7 02/10] examples/power: allow for number of vms to be zero

2018-10-17 Thread David Hunt
Previously the vm_power_manager app required to have some vms defined, so the call to get_all_vm() always set the noVms variable. Now we're accepting policies from the host OS (without any VMs defined), so it is now valid to have zero VMs. This patch initialises the relevant variables to zero just

[dpdk-dev] [PATCH v7 04/10] examples/power: add necessary changes to guest app

2018-10-17 Thread David Hunt
The changes here are minimal, as the guest app functionality is not changing at all, but there is a new element in the channel_packet struct that needs to have a default set (channel_packet->core_type). Signed-off-by: David Hunt Acked-by: Anatoly Burakov --- examples/vm_power_manager/guest_cli/

[dpdk-dev] [PATCH v7 01/10] examples/power: add checks around hypervisor

2018-10-17 Thread David Hunt
Allow vm_power_manager to run without requiring qemu to be present on the machine. This will be required for instances where the JSON interface is used for commands and polices, without any VMs present. A use case for this is a container enviromnent. Signed-off-by: David Hunt Acked-by: Anatoly Bu

[dpdk-dev] [PATCH v7 0/10] add json power policy interface for containers

2018-10-17 Thread David Hunt
The current vm_power_manager example app has the capability to accept power policies from virtual machines via virtio-serial channels. These power policies allow a virtual machine to give information to the power manager to allow the power manager take care of the power management of the virtual m

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix physic port socket initialization

2018-10-17 Thread Ferruh Yigit
On 10/17/2018 12:02 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: phil.y...@arm.com [mailto:phil.y...@arm.com] >> Sent: Wednesday, October 17, 2018 2:37 AM >> To: dev@dpdk.org >> Cc: Ananyev, Konstantin ; Yigit, Ferruh >> >> Subject: [PATCH v2] app/testpmd: fix physi

Re: [dpdk-dev] [PATCH v5 1/3] app/testpmd: move dumping packets to a separate function

2018-10-17 Thread Iremonger, Bernard
Hi Raslan, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, October 17, 2018 1:28 PM > To: Raslan Darawsheh ; Wu, Jingjing > > Cc: tho...@monjalon.net; dev@dpdk.org; shah...@mellanox.com; > xuemi...@mellanox.com; or...@mellanox.com; > jerin.ja...@caviumnetworks.com; david.mar

[dpdk-dev] [PATCH v5 8/8] doc/guides/sample_app_ug: add guides for fips validation

2018-10-17 Thread Marko Kovacevic
Document explains how to run the fips sample app and instructions users need to parser all the request files and generate the response files. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang Acked-by: Arek Kusztal --- MAINTAINERS | 4 + doc/guides/rel_

[dpdk-dev] [PATCH v5 7/8] examples/cryptodev_fips_validate: add ccm parser and enablement for test types

2018-10-17 Thread Marko Kovacevic
Added enablement for CCM parser, to allow the application to parser the ccm request files and to validate all test types supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang Acked-by: Arek Kusztal --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fips_

[dpdk-dev] [PATCH v5 3/8] examples/cryptodev_fips_validate: add hmac parser

2018-10-17 Thread Marko Kovacevic
Added enablement for HMAC parser, to allow the application to parser the hmac request files and to validate all tests supported Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang Acked-by: Arek Kusztal --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fips_pars

[dpdk-dev] [PATCH v5 5/8] examples/cryptodev_fips_validate: add gcm parser

2018-10-17 Thread Marko Kovacevic
Added enablement for GCM parser, to allow the application to parser the GCM request file and to validate all tests supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang Acked-by: Arek Kusztal --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fips_parse_

[dpdk-dev] [PATCH v5 4/8] examples/cryptodev_fips_validate: add TDES parser and enablement for test types

2018-10-17 Thread Marko Kovacevic
Added enablement for TDES parser, to allow the application to parser the TDES request files and to validate all test types supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang Acked-by: Arek Kusztal --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fip

[dpdk-dev] [PATCH v5 6/8] examples/cryptodev_fips_validate: add cmac parser and enablement for test types

2018-10-17 Thread Marko Kovacevic
Added enablement for CMAC parser, to allow the application to parser the cmac request files and to validate all test types supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang Acked-by: Arek Kusztal --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fip

[dpdk-dev] [PATCH v5 0/8] FIPS validation capability

2018-10-17 Thread Marko Kovacevic
This sample application is made for the purpose so that users of DPDK who wish to get FIPS certification for their platforms, this sample app enables users to parse test vectors that is gotten from NIST and be able to get a generated response file which they can then verify and be sure their system

[dpdk-dev] [PATCH v5 2/8] examples/cryptodev_fips_validate: add aes parser and enablement for test types

2018-10-17 Thread Marko Kovacevic
Added enablement for AES-CBC parser, to allow the application to parser the aes request file and to validate all test types supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang Acked-by: Arek Kusztal --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fi

  1   2   >