Sending a newer version with the fix.
Kindest regards,
Raslan Darawsheh
> -----Original Message-----
> From: Iremonger, Bernard <bernard.iremon...@intel.com>
> Sent: Wednesday, October 17, 2018 3:59 PM
> To: Yigit, Ferruh <ferruh.yi...@intel.com>; Raslan Darawsheh
> <rasl...@mellanox.com>; Wu, Jingjing <jingjing...@intel.com>
> Cc: Thomas Monjalon <tho...@monjalon.net>; dev@dpdk.org; Shahaf
> Shuler <shah...@mellanox.com>; Xueming(Steven) Li
> <xuemi...@mellanox.com>; Ori Kam <or...@mellanox.com>;
> jerin.ja...@caviumnetworks.com; david.march...@6wind.com
> Subject: RE: [PATCH v5 1/3] app/testpmd: move dumping packets to a
> separate function
>
> Hi Raslan,
>
> > -----Original Message-----
> > From: Yigit, Ferruh
> > Sent: Wednesday, October 17, 2018 1:28 PM
> > To: Raslan Darawsheh <rasl...@mellanox.com>; Wu, Jingjing
> > <jingjing...@intel.com>
> > Cc: tho...@monjalon.net; dev@dpdk.org; shah...@mellanox.com;
> > xuemi...@mellanox.com; or...@mellanox.com;
> > jerin.ja...@caviumnetworks.com; david.march...@6wind.com;
> Iremonger,
> > Bernard <bernard.iremon...@intel.com>
> > Subject: Re: [PATCH v5 1/3] app/testpmd: move dumping packets to a
> > separate function
> >
> > On 10/17/2018 8:27 AM, Raslan Darawsheh wrote:
> > > verbosity for the received/sent packets is needed in all of the
> > > forwarding engines so moving it to be in a separate function
> > >
> > > Acked-by: Bernard Iremonger <bernard.iremon...@intel.com>
> > > Signed-off-by: Raslan Darawsheh <rasl...@mellanox.com>
> >
> > <...>
> >
> > > +static inline void
> > > +dump_pkt_burst(uint16_t port_id, uint16_t queue, struct rte_mbuf
> *pkts[],
> > > + uint16_t nb_pkts, int is_rx) {
> >
> > This is causing build error when only this patch applied:
> >
> > .../app/test-pmd/util.c:25:1: error: unused function 'dump_pkt_burst'
> > [-Werror,-Wunused-function]
> > dump_pkt_burst(uint16_t port_id, uint16_t queue, struct rte_mbuf
> > *pkts[], ^
>
> Builds ok with gcc but fails with clang
>
> Regards,
>
> Bernard.
