Re: [dpdk-dev] [PATCH v4 3/6] kni: set default carrier state of interface

[Ferruh Yigit]

On 10/17/2018 2:04 AM, Dan Gora wrote:
> +static int __init
> +kni_parse_carrier_state(void)
> +{
> +     if (!carrier)
> +             dflt_carrier = 0;
> +
> +     if (strcmp(carrier, "off") == 0)
> +             dflt_carrier = 0;
> +     else if (strcmp(carrier, "on") == 0)
> +             dflt_carrier = 1;
> +     else
> +             return -1;
> +
> +     return 0;
> +}

I think intention here is:

 if (!carrier)
        return 0;