Re: [dpdk-dev] [PATCH v4 2/4] ring: read tail using atomic load

2018-09-19 Thread Jerin Jacob
-Original Message- > Date: Mon, 17 Sep 2018 16:11:17 +0800 > From: Gavin Hu > To: dev@dpdk.org > CC: gavin...@arm.com, honnappa.nagaraha...@arm.com, steve.cap...@arm.com, > ola.liljed...@arm.com, jerin.ja...@caviumnetworks.com, n...@arm.com, > sta...@dpdk.org > Subject: [PATCH v4 2/4] ri

Re: [dpdk-dev] [PATCH 2/2] test/eventdev: remove eth Rx adapter vdev workaround

2018-09-19 Thread Jerin Jacob
-Original Message- > Date: Thu, 6 Sep 2018 14:41:43 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org, Nikhil Rao , > vipin.vargh...@intel.com, sta...@dpdk.org > Subject: [PATCH 2/2] test/eventdev: remove eth Rx adapter vdev workaround > X-Mailer: git-send-e

Re: [dpdk-dev] [PATCH 1/2] eventdev: fix eth Rx adapter hotplug incompatibility

2018-09-19 Thread Jerin Jacob
-Original Message- > Date: Thu, 6 Sep 2018 14:41:42 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org, Nikhil Rao , sta...@dpdk.org > Subject: [PATCH 1/2] eventdev: fix eth Rx adapter hotplug incompatibility > X-Mailer: git-send-email 1.8.3.1 > > > Use RTE_

Re: [dpdk-dev] [PATCH] vmxnet3: stats_reset implementation

2018-09-19 Thread Yogev Chaimovich
I'll add it. Actually I didn't know why it wasn't implemented. Thanks. -Original Message- From: Yong Wang Sent: Monday, September 17, 2018 8:21 PM To: Yogev Chaimovich Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] vmxnet3: stats_reset implementation > On Sep 17, 2018, at 12:45 AM,

[dpdk-dev] [PATCH] vmxnet3: stats_reset implementation

2018-09-19 Thread Yogev Chaimovich
'stats_reset()' callback was missing because the device backend doesn’t support it. This commit adds a workaround to this and implements the callback by taking a snapshot of the stats (SNAPSHOT) each time 'stats_reset()' is called. When getting stats with 'stats_get()', hw stats which always incr

Re: [dpdk-dev] [PATCH v3 5/5] vhost: message handling implemented as a callback array

2018-09-19 Thread Nikolay Nikolaev
On Wed, Sep 19, 2018 at 10:37 AM Maxime Coquelin wrote: > > > > On 09/15/2018 07:20 AM, Nikolay Nikolaev wrote: > > Introduce vhost_message_handlers, which maps the message request > > type to the message handler. Then replace the switch construct > > with a map and call. > > > > Failing vhost_use

Re: [dpdk-dev] [PATCH] net/bonding: ensure fairness among slaves

2018-09-19 Thread Matan Azrad
Hi Chas Please see small comments. > From: Chas Williams > Some PMDs, especially ones with vector receives, require a minimum > number of receive buffers in order to receive any packets. If the first slave > read leaves less than this number available, a read from the next slave may > return 0 i

Re: [dpdk-dev] [PATCH] test/event: remove RSS config in eth Rx adapter test

2018-09-19 Thread Jerin Jacob
-Original Message- > Date: Wed, 5 Sep 2018 15:12:06 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org, Nikhil Rao , sta...@dpdk.org > Subject: [PATCH] test/event: remove RSS config in eth Rx adapter test > X-Mailer: git-send-email 1.8.3.1 > > External Email

[dpdk-dev] [PATCH v2] doc: update API deprecation for device reset

2018-09-19 Thread Qi Zhang
Device reset may have the dependency, for example, a VF reset expects PF ready, or a NIC function as a part of a SOC need to wait for other parts of the system be ready, these are time-consuming tasks and will block current thread. So we rename rte_eth_dev_reset to rte_eth_dev_reset_async as an as

[dpdk-dev] [RFC v3] ethdev: claim device reset as async

2018-09-19 Thread Qi Zhang
Device reset should be implemented in an async way since it is possible to be invoked in interrupt thread and sometimes to reset a device need to wait for some dependency, for example, a VF expects for PF ready or a NIC function as part of a SOC wait for the whole system reset complete, and all the

Re: [dpdk-dev] [PATCH v2 2/2] examples/vdpa: introduce a new sample for vDPA

2018-09-19 Thread Wang, Xiao W
Hi Xiaolong, > -Original Message- > From: Ye, Xiaolong > Sent: Thursday, September 20, 2018 6:23 AM > To: Wang, Xiao W > Cc: dev@dpdk.org; Maxime Coquelin ; Bie, > Tiwei ; Wang, Zhihong ; > Rami Rosen ; Wang, Haiyue > > Subject: Re: [PATCH v2 2/2] examples/vdpa: introduce a new sample fo

Re: [dpdk-dev] [PATCH] examples/eventdev_pipeline: add Tx adapter support

2018-09-19 Thread Rao, Nikhil
On 9/19/2018 4:12 PM, Pavan Nikhilesh wrote: On Wed, Sep 19, 2018 at 08:24:01AM +0530, Rao, Nikhil wrote: On 9/5/2018 7:15 PM, Pavan Nikhilesh wrote: Signed-off-by: Pavan Nikhilesh --- This patch depends on the following series: http://patches.dpdk.org/project/dpdk/list/?series=1121

[dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-09-19 Thread Thomas Monjalon
When trying to include stdbool.h in DPDK base headers, there are a lot of conflicts with drivers which redefine bool/true/false in their compatibility layer. It is fixed by including stdbool.h in these drivers. Some errors with usage of bool type are also fixed in some drivers. Note: the driver q

Re: [dpdk-dev] [PATCH 0/4] fix missing Tx multi segs capabilities

2018-09-19 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Didier Pallard > Sent: Wednesday, September 19, 2018 4:04 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 0/4] fix missing Tx multi segs capabilities > > In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a h

[dpdk-dev] [PATCH v3 3/4] app/test-eventdev: add Tx adapter support

2018-09-19 Thread Pavan Nikhilesh
Convert existing Tx service based pipeline to Tx adapter based APIs and simplify worker functions. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_atq.c| 269 --- app/test-eventdev/test_pipeline_common.c | 202 + app/test-eventdev/test_p

[dpdk-dev] [PATCH v3 2/4] app/test-eventdev: remove redundant newlines

2018-09-19 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c index 12a58fbbf..cdf9010b4 100644 --- a/app/

[dpdk-dev] [PATCH v3 4/4] doc: update eventdev application guide

2018-09-19 Thread Pavan Nikhilesh
Update eventdev application guide to reflect Tx adapter related changes. Signed-off-by: Pavan Nikhilesh --- cc: .../eventdev_pipeline_atq_test_generic.svg| 848 +++--- ...ntdev_pipeline_atq_test_internal_port.svg} | 26 +- .../eventdev_pipeline_queue_test_generic.svg | 570 ++

[dpdk-dev] [PATCH v3 1/4] app/test-eventdev: fix minor typos

2018-09-19 Thread Pavan Nikhilesh
Fix minor typos. Fixes: 314bcf58ca8f ("app/eventdev: add pipeline queue worker functions") Signed-off-by: Pavan Nikhilesh --- v3 Changes: - Force all the ports to use the non-internal cap mode when we detect that one of the port doesn't have internal port capability. app/test-eventdev/test

[dpdk-dev] [PATCH 5/5] net/bnx2x: fix to add phy lock

2018-09-19 Thread Mody, Rasesh
This patch adds phy_lock, acquire/release the lock when performing PHY transactions. Without this fix driver can run into synchronization issues with management FW when modifying PHY settings. Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/

[dpdk-dev] [PATCH 4/5] net/bnx2x: fix call to link handling periodic function

2018-09-19 Thread Mody, Rasesh
If link handling periodic function is allowed to be called in interrupt context, the periodic function can get called too frequently and exhaust the retry credits to check link status. This change makes sure link handling periodic function is not called in interrupt context. Fixes: 540a211084a7 (

[dpdk-dev] [PATCH 3/5] net/bnx2x: fix to disable further interrupts

2018-09-19 Thread Mody, Rasesh
Fix to disable further fastpath/slowpath interrupts. These will be enabled again by their respective handlers Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/driv

[dpdk-dev] [PATCH v2 5/5] examples/kni: improve zeroing statistics

2018-09-19 Thread Dan Gora
The worker threads incrementing the rx/tx_packets race with the signal handler from the main thread zeroing the entire statistics structure. This can cause the statistics to fail to be zeroed, even when there is no traffic on those interfaces. Improve zeroing the statistics by only incrementing rx

[dpdk-dev] [PATCH v2 3/5] examples/kni: monitor and update link status continually

2018-09-19 Thread Dan Gora
Update KNI example to continuously monitor the Ethernet link status of the physical link and update the carrier status of the corresponding interfaces with rte_kni_update_link(). Signed-off-by: Dan Gora --- examples/kni/Makefile | 2 ++ examples/kni/main.c | 82 +--

[dpdk-dev] [PATCH v2 4/5] examples/kni: add log msgs to show and clear stats

2018-09-19 Thread Dan Gora
Add logging messages showing the commands necessary for the user to have the application display and zero the statistics. Signed-off-by: Dan Gora --- examples/kni/main.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.

[dpdk-dev] [PATCH v2 2/5] kni: set default carrier state to 'off'

2018-09-19 Thread Dan Gora
Set the carrier state to 'off' when the interface is instantiated or when it is marked 'up' or 'down'. This is necessary to set the interface to a known operational state until the carrier state is changed with rte_kni_update_link(). Signed-off-by: Dan Gora --- kernel/linux/kni/kni_misc.c | 2 +

[dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-19 Thread Dan Gora
Add a new API function to KNI, rte_kni_update_link() to allow DPDK applications to update the link status for KNI network interfaces in the linux kernel. Signed-off-by: Dan Gora --- lib/librte_kni/rte_kni.c | 57 lib/librte_kni/rte_kni.h | 18 ++ lib/li

[dpdk-dev] [PATCH v2 0/5] kni: add API to set link status on kernel interface

2018-09-19 Thread Dan Gora
Hi All, Attached is version 2 of a patchset to add a new API function to set the link status on kernel interfaces created with the KNI kernel module. -dan v2 * Fix bug where "Fixed" and "AutoNeg" were transposed in the link status log message. * Add rte_kni_update_link() to rte_kni_vers

[dpdk-dev] [Bug 92] i40e RX capabilities include scatter/gather on VF, but not on PF

2018-09-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=92 Bug ID: 92 Summary: i40e RX capabilities include scatter/gather on VF, but not on PF Product: DPDK Version: 18.08 Hardware: All OS: All Status: CONFIRMED

[dpdk-dev] vhost memory hotplug deadlock

2018-09-19 Thread Stephen Hemminger
The Vhost memory handling will self deadlock. The sequence is: rte_zmalloc malloc_heap_alloc heap_alloc_on_socket alloc_more_mem_on_socket try_expand_heap_primary Acquires memor

Re: [dpdk-dev] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-09-19 Thread Luca Boccassi
On Thu, 2018-08-16 at 14:32 +0100, Luca Boccassi wrote: > During bond 802.3ad receive, a burst of packets is fetched from > each slave into a local array and appended to per-slave ring buffer. > Packets are taken from the head of the ring buffer and returned to > the caller.  The number of mbufs pr

Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx

2018-09-19 Thread Ferruh Yigit
On 9/19/2018 8:34 AM, David Marchand wrote: > Hello Ferruh, > > On Fri, Sep 14, 2018 at 1:37 PM, Ferruh Yigit wrote: >> On 9/4/2018 11:02 AM, Shahaf Shuler wrote: >>> Tuesday, September 4, 2018 1:13 PM, Ferruh Yigit: Subject: [PATCH v2] ethdev: make default behavior CRC strip on Rx

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix mbuf flags with cksum good

2018-09-19 Thread Ferruh Yigit
On 9/6/2018 5:02 PM, Alejandro Lucero wrote: > If checksum offload enabled and hardware reports checksum as good, > update mbuf ol_flags with proper *_CKSUM_GOOD bits. > > Fixes: b812daadad0d ("nfp: add Rx and Tx") > Cc: sta...@dpdk.org > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-n

Re: [dpdk-dev] [dpdk-stable] [PATCH] net: fix Intel prepare function for IP checksum offload

2018-09-19 Thread Ferruh Yigit
On 9/19/2018 3:42 PM, Didier Pallard wrote: > Current Intel tx prepare function does not properly handle the > case where only IP checksum is requested, without requesting > any L4 checksum or TSO: IP checksum is not properly reset to 0 > and output packet may contain invalid IP checksum. > > Fixe

Re: [dpdk-dev] [PATCH v2 1/2] librte_ip_frag: add function to delete expired entries

2018-09-19 Thread Thomas Monjalon
> > A fragmented packets is supposed to live no longer than max_cycles, > > but the lib deletes an expired packet only occasionally when it scans > > a bucket to find an empty slot while adding a new packet. > > Therefore a fragment might sit in the table forever. > > > > Signed-off-by: Alex Kisel

[dpdk-dev] false positive in check-symbol-change.sh tool

2018-09-19 Thread Thomas Monjalon
Hi Neil, I think I've discovered a false positive with the script devtools/check-symbol-change.sh When checking the patch http://patches.dpdk.org/patch/40601/, which is adding an experimental section with a symbol in it, we can see this message: ERROR: symbol rte_frag_table_del_expired_entries is

Re: [dpdk-dev] [PATCH v3 0/8] Add Marvell NETA PMD

2018-09-19 Thread Ferruh Yigit
On 9/19/2018 4:07 PM, Andrzej Ostruszka wrote: > On 14.09.2018 18:20, Ferruh Yigit wrote: >> On 8/31/2018 1:59 PM, Andrzej Ostruszka wrote: >>> This patch series introduces new PMD for Marvell NETA adapters (MVNETA). >>> See the documentation for more info. > [...] >> Hi Andrzej, >> >> Patchset is

Re: [dpdk-dev] [PATCH v3 1/8] net/mvneta: add neta PMD skeleton

2018-09-19 Thread Ferruh Yigit
On 9/19/2018 4:14 PM, Andrzej Ostruszka wrote: > On 14.09.2018 18:23, Ferruh Yigit wrote: >> On 8/31/2018 1:59 PM, Andrzej Ostruszka wrote: > [...] >> For link status feature "link_update" eth_dev_ops needs to be implemented, >> please either implement it or remove feature. (I saw this done later,

Re: [dpdk-dev] [PATCH] net/*/base: allow use of experimental APIs in base code

2018-09-19 Thread Ferruh Yigit
On 9/3/2018 3:41 PM, Ilya Maximets wrote: > On 31.08.2018 16:35, Bruce Richardson wrote: >> The driver setting of "allow_experimental_apis" was not being used when >> building the base code. To allow this we can manually put in a check >> in the base code files for the setting and set the appropria

Re: [dpdk-dev] [PATCH v2 00/12] net/mvpp2: add new features

2018-09-19 Thread Ferruh Yigit
On 9/4/2018 2:49 PM, Tomasz Duszynski wrote: > This patch series introduces fixes and adds support for traffic metering, > traffic manager and Tx S/G. Additionally it aligns with for MUSDK 18.09. > > Changes since v2: > * Align with MUSDK 18.09 library > * Add support for Tx Gather. > * Add docume

[dpdk-dev] [PATCH] devtools: use a common prefix for temporary files

2018-09-19 Thread Thomas Monjalon
Some temporary files were generated in /tmp, others in the current directory, and none was "dpdk prefixed". All these files have a common path prefix now: $TMPDIR/dpdk. TMPDIR is /tmp by default. Note: the previous use of mktemp, with a template but without -t, was generating a file in the curren

Re: [dpdk-dev] [PATCH v2 10/12] net/mvpp2: align documentation with MUSDK 18.09

2018-09-19 Thread Ferruh Yigit
On 9/4/2018 2:49 PM, Tomasz Duszynski wrote: > From: Natalie Samsonov > > Update documentation to align with MUSDK 18.09. > > Signed-off-by: Natalie Samsonov > --- > doc/guides/nics/mvpp2.rst | 26 -- > 1 file changed, 12 insertions(+), 14 deletions(-) > > diff --git a

Re: [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity

2018-09-19 Thread Mody, Rasesh
>From: Stephen Hemminger >Sent: Tuesday, September 18, 2018 8:07 AM > >On Tue, 18 Sep 2018 11:40:28 +0200 >Thomas Monjalon wrote: > >> 25/07/2018 20:20, Stephen Hemminger: >> > No need for profanity in comments. >> > >> > Signed-off-by: Stephen Hemminger >> > --- >> > drivers/net/bnx2x/elink.c

Re: [dpdk-dev] [PATCH v4 1/8] net/mvneta: add neta PMD skeleton

2018-09-19 Thread Stephen Hemminger
On Wed, 19 Sep 2018 17:01:27 +0200 Andrzej Ostruszka wrote: > +/** > + * Create private device structure. > + * > + * @param dev_name > + * Pointer to the port name passed in the initialization parameters. > + * > + * @return > + * Pointer to the newly allocated private device structure. > +

Re: [dpdk-dev] [PATCH v4 1/8] net/mvneta: add neta PMD skeleton

2018-09-19 Thread Stephen Hemminger
On Wed, 19 Sep 2018 17:01:27 +0200 Andrzej Ostruszka wrote: > + > +- Custom Linux Kernel sources > + > + .. code-block:: console > + > + git clone > https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b > linux-4.4.52-armada-17.10 > + In general the rule for DPDK is that drive

[dpdk-dev] [PATCH v1] devargs: remove comment regarding rte-log

2018-09-19 Thread Gaetan Rivet
rte_log() is available in the context of this compilation unit, do not deter from using it. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_com

Re: [dpdk-dev] [PATCH v2 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

2018-09-19 Thread Luca Boccassi
On Wed, 2018-09-19 at 11:47 -0400, Chas Williams wrote: > On Wed, Sep 19, 2018 at 8:58 AM Luca Boccassi > wrote: > > > > The vmxnet3 driver can't call back into dev_close(), and possibly > > dev_stop(), in dev_uninit().  When dev_uninit() is called, anything > > that those routines would want to

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: ensure fairness among slaves

2018-09-19 Thread Luca Boccassi
On Wed, 2018-09-19 at 11:48 -0400, Chas Williams wrote: > From: Chas Williams > > Some PMDs, especially ones with vector receives, require a minimum > number > of receive buffers in order to receive any packets.  If the first > slave > read leaves less than this number available, a read from the

[dpdk-dev] [PATCH v2 13/13] eal: add generic dev parameter

2018-09-19 Thread Gaetan Rivet
Add the --dev parameter to the EAL. This new parameter takes a generic device declaration as argument. It uses the new devargs parsing API. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 4 +++ lib/librte_eal/common/eal_common_options.c | 36 +++---

[dpdk-dev] [PATCH v2 11/13] bus/pci: process declarative PCI devargs

2018-09-19 Thread Gaetan Rivet
Introduce the facility to process future PCI parameters. Once the matching between PCI devices and devargs has been done, it is possible to process each devargs. New parameters would have the PCI device handle to work with when parsing the device (bus specific) parameters. Signed-off-by: Gaetan R

[dpdk-dev] [PATCH v2 12/13] ethdev: process declarative eth devargs

2018-09-19 Thread Gaetan Rivet
Process the eth parameters of a devargs. For each parameters that have a setter implemented, the relevant field in rte_eth_dev field is written. Currently only "name" is implemented. Signed-off-by: Gaetan Rivet --- lib/librte_ethdev/ethdev_private.h | 5 +++ lib/librte_ethdev/rte_class_eth.c

[dpdk-dev] [PATCH v2 10/13] bus/vdev: pre-process declarative vdev devargs

2018-09-19 Thread Gaetan Rivet
The new devargs format does not recognize a particular device name. Each bus uses its specific format. Process each devargs privately prior to attempting a bus scan. Prepare them if they are using the new devargs format. Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/vdev.c | 10 -

[dpdk-dev] [PATCH v2 09/13] bus/pci: pre-process declarative PCI devargs

2018-09-19 Thread Gaetan Rivet
The new devargs format does not recognize a particular device name. Each bus uses its specific format. Instead of introducing a new bus API, process those devargs privately for the moment. Prepare them for matching during scan against the bus devices. Signed-off-by: Gaetan Rivet --- drivers/bus

[dpdk-dev] [PATCH v2 08/13] app/testpmd: add show device command

2018-09-19 Thread Gaetan Rivet
A new interactive command is offered: show device This commands lists all rte_device element matching the device description. e.g.: show device bus=pci show device bus=vdev show device bus=vdev/class=eth show device bus=vdev,driver=net_ring/class=eth show device bus=vdev/class

[dpdk-dev] [PATCH v2 06/13] ethdev: register ether layer as a class

2018-09-19 Thread Gaetan Rivet
Implement the operators of an rte_class for the ethdev abstraction layer. Register the layer as such. Signed-off-by: Gaetan Rivet Acked-by: Andrew Rybchenko --- lib/librte_ethdev/Makefile| 3 +- lib/librte_ethdev/meson.build | 1 + lib/librte_ethdev/rte_class_eth.c | 79 +

[dpdk-dev] [PATCH v2 07/13] ethdev: add device matching field name

2018-09-19 Thread Gaetan Rivet
The eth device class can now parse a field name, matching the eth_dev name with one passed as "class=eth,name=xx" Signed-off-by: Gaetan Rivet Acked-by: Andrew Rybchenko --- lib/librte_ethdev/rte_class_eth.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/librte_ethdev/rte

[dpdk-dev] [PATCH v2 05/13] ethdev: add private generic device iterator

2018-09-19 Thread Gaetan Rivet
This iterator can be customized with a comparison function that will trigger a stopping condition. It can be leveraged to write several different iterators that have similar but non-identical purposes. It is private to librte_ethdev. Signed-off-by: Gaetan Rivet --- lib/librte_ethdev/Makefile

[dpdk-dev] [PATCH v2 04/13] bus/vdev: add device matching field driver

2018-09-19 Thread Gaetan Rivet
The vdev bus parses a field "driver", matching a vdev driver name with one passed as follows: "bus=vdev,driver=" Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/vdev_params.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vdev/vdev_param

[dpdk-dev] [PATCH v2 03/13] bus/vdev: implement device iteration

2018-09-19 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/Makefile | 3 +- drivers/bus/vdev/meson.build| 5 +++- drivers/bus/vdev/vdev.c | 10 --- drivers/bus/vdev/vdev_params.c | 51 + drivers/bus/vdev/vdev_private.h | 26 + 5 files

[dpdk-dev] [PATCH v2 02/13] bus/pci: add device matching field id

2018-09-19 Thread Gaetan Rivet
The PCI bus can now parse a matching field "id" as follows: "bus=pci,id=:00:00.0" or "bus=pci,id=00:00.0" Signed-off-by: Gaetan Rivet --- drivers/bus/pci/pci_params.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH v2 01/13] bus/pci: implement device iteration and comparison

2018-09-19 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/bus/pci/Makefile | 3 +- drivers/bus/pci/meson.build | 6 +++- drivers/bus/pci/pci_common.c | 3 +- drivers/bus/pci/pci_params.c | 53 drivers/bus/pci/private.h| 25 + 5 files changed, 86 inse

[dpdk-dev] [PATCH v2 00/13] Implement new devargs framework

2018-09-19 Thread Gaetan Rivet
Last release saw the introduction of the new devargs system. To this end, the "class" abstraction was described as well as a common API for querying and declaring devices. This patchset implements the "eth" device class and the query/declaration part of the framework for PCI and vdev buses, enabli

[dpdk-dev] [PATCH] net/bonding: ensure fairness among slaves

2018-09-19 Thread Chas Williams
From: Chas Williams Some PMDs, especially ones with vector receives, require a minimum number of receive buffers in order to receive any packets. If the first slave read leaves less than this number available, a read from the next slave may return 0 implying that the slave doesn't have any packe

Re: [dpdk-dev] [PATCH v2 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

2018-09-19 Thread Chas Williams
On Wed, Sep 19, 2018 at 8:58 AM Luca Boccassi wrote: > > The vmxnet3 driver can't call back into dev_close(), and possibly > dev_stop(), in dev_uninit(). When dev_uninit() is called, anything > that those routines would want to clean up has already been released. > Further, for complete cleanup,

Re: [dpdk-dev] [PATCH v2 2/2] examples/vdpa: introduce a new sample for vDPA

2018-09-19 Thread Ye Xiaolong
On 09/19, Wang, Xiao W wrote: >Hi Xiaolong, > [snip] >> +.. note:: >> +We need to bind VFIO-pci to VFs before running vdpa sample. > >Replace "VFIO-pci" with "vfio-pci". Got it. > >> + >> +* modprobe vfio-pci >> +* ./usertools/dpdk-devbind.py -b vfio-pci 06:00.2 06:00.3 >> + >> +Then

Re: [dpdk-dev] [PATCH v2 1/2] vhost: introduce API to get vDPA device number

2018-09-19 Thread Ye Xiaolong
On 09/19, Wang, Xiao W wrote: >Hi, > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Friday, September 14, 2018 2:07 AM >> To: dev@dpdk.org; Maxime Coquelin ; Bie, >> Tiwei ; Wang, Zhihong >> Cc: Wang, Xiao W ; Rami Rosen >> ; Wang, Haiyue ; Ye, >> Xiaolong >> Subject: [PATCH v2 1/2]

Re: [dpdk-dev] DEV_RX_OFFLOAD_SCATTER not available in i40e an cxgbe

2018-09-19 Thread Rahul Lakkireddy
On Tuesday, September 09/18/18, 2018 at 14:54:07 +0530, Martin Weiser wrote: > Hi, > > is there a specific reason that the rx offload capability > DEV_RX_OFFLOAD_SCATTER is not available in the i40e and cxgbe drivers in > DPDK 18.08? > We previously used this feature with DPDK 17.11 to handle jumb

Re: [dpdk-dev] [RFC v2 2/3] ethdev: add flow api actions to modify TCP/UDP port numbers

2018-09-19 Thread Rahul Lakkireddy
On Tuesday, September 09/18/18, 2018 at 14:59:10 +0530, Xiaoyu Min wrote: > > > > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > index 638331c17..f60be0862 100644 > > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > +++ b/doc/gui

Re: [dpdk-dev] [PATCH] net/failsafe: fix crash on slave queue release

2018-09-19 Thread Gaëtan Rivet
On Fri, Aug 31, 2018 at 05:16:32PM +0100, Andrew Rybchenko wrote: > From: Igor Romanov > > Releasing a queue that is already released by slave may cause a > segmentation fault. For example, after a successfull device > configuration a queue is set up. Afterwards the device is reconfigured > with

Re: [dpdk-dev] [RFC v2 1/3] ethdev: add flow api actions to modify IP addresses

2018-09-19 Thread Rahul Lakkireddy
On Tuesday, September 09/18/18, 2018 at 13:26:06 +0530, Xiaoyu Min wrote: > > > > static int > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > > index f8ba71cdb..48c3c606e 100644 > > --- a/lib/librte_ethdev/rte_flow.h > > +++ b/lib/librte_ethdev/rte_flow.h > > @@ -15

Re: [dpdk-dev] [PATCH v3 1/8] net/mvneta: add neta PMD skeleton

2018-09-19 Thread Andrzej Ostruszka
On 14.09.2018 18:23, Ferruh Yigit wrote: > On 8/31/2018 1:59 PM, Andrzej Ostruszka wrote: [...] > For link status feature "link_update" eth_dev_ops needs to be implemented, > please either implement it or remove feature. (I saw this done later, please > add this on relevant patch) > >> +MTU updat

Re: [dpdk-dev] [PATCH v7 1/2] librte_lpm: Improve performance of the delete and add functions

2018-09-19 Thread Thomas Monjalon
18/09/2018 12:57, Alex Kiselev: > lpm6: store rules in hash table for lpm6 > > Rework the lpm6 rule subsystem and replace > current rules algorithm complexity O(n) > with hashtables which allow dealing with > large (50k) rule sets. > > Signed-off-by: Alex Kiselev > Acked-by: Bruce Richardson S

Re: [dpdk-dev] [PATCH v2 2/2] net/failsafe: support multicast address list set

2018-09-19 Thread Gaëtan Rivet
On Wed, Sep 19, 2018 at 04:50:57PM +0200, Gaëtan Rivet wrote: > Hi, > > Sorry about the delay on this, overall it looks ok; > I have an issue however, see inline. > > On Mon, Sep 03, 2018 at 07:55:22AM +0100, Andrew Rybchenko wrote: > > From: Evgeny Im > > > > Signed-off-by: Evgeny Im > > Sign

Re: [dpdk-dev] [PATCH v3 0/8] Add Marvell NETA PMD

2018-09-19 Thread Andrzej Ostruszka
On 14.09.2018 18:20, Ferruh Yigit wrote: > On 8/31/2018 1:59 PM, Andrzej Ostruszka wrote: >> This patch series introduces new PMD for Marvell NETA adapters (MVNETA). >> See the documentation for more info. [...] > Hi Andrzej, > > Patchset is mostly looks good to me, there is no major issue but I h

[dpdk-dev] [PATCH 4/4] net/ixgbe: fix missing Tx multi segs capability

2018-09-19 Thread Didier Pallard
In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not a

[dpdk-dev] [PATCH 3/4] net/i40e: fix missing Tx multi segs capability

2018-09-19 Thread Didier Pallard
In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not a

[dpdk-dev] [PATCH 0/4] fix missing Tx multi segs capabilities

2018-09-19 Thread Didier Pallard
In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not a

[dpdk-dev] [PATCH 2/4] net/fm10k: fix missing Tx multi segs capability

2018-09-19 Thread Didier Pallard
In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not a

[dpdk-dev] [PATCH 1/4] net/e1000: fix missing Tx multi segs capability

2018-09-19 Thread Didier Pallard
In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not a

[dpdk-dev] [PATCH v4 8/8] net/mvneta: add reset statistics callback

2018-09-19 Thread Andrzej Ostruszka
From: Natalie Samsonov Add support for resetting of driver statistics. Signed-off-by: Natalie Samsonov --- drivers/net/mvneta/mvneta_ethdev.c | 40 +++--- drivers/net/mvneta/mvneta_ethdev.h | 1 + 2 files changed, 34 insertions(+), 7 deletions(-) diff --git a/

[dpdk-dev] [PATCH v4 7/8] net/mvneta: add support for basic stats

2018-09-19 Thread Andrzej Ostruszka
From: Zyta Szpak Add support for getting of basic statistics for the driver. Signed-off-by: Yelena Krivosheev Signed-off-by: Natalie Samsonov Signed-off-by: Zyta Szpak --- doc/guides/nics/features/mvneta.ini | 1 + doc/guides/nics/mvneta.rst | 1 + drivers/net/mvneta/mvneta_ethdev

Re: [dpdk-dev] [PATCH 0/2] net/failsafe: support runtime queue setup

2018-09-19 Thread Gaëtan Rivet
Hi, for the series, Acked-by: Gaetan Rivet On Fri, Aug 31, 2018 at 05:09:36PM +0100, Andrew Rybchenko wrote: > The patch series should be applied on top of [1] and [2]. > > [1] https://patches.dpdk.org/project/dpdk/list/?series=1082 > [2] https://patches.dpdk.org/patch/43946/ > > Ian Dolzhansk

[dpdk-dev] [PATCH v4 6/8] net/mvneta: add MAC filtering

2018-09-19 Thread Andrzej Ostruszka
From: Zyta Szpak Add callbacks for adding/removing MAC addresses. Signed-off-by: Yelena Krivosheev Signed-off-by: Natalie Samsonov Signed-off-by: Zyta Szpak --- doc/guides/nics/features/mvneta.ini | 1 + doc/guides/nics/mvneta.rst | 1 + drivers/net/mvneta/mvneta_ethdev.c | 69 ++

[dpdk-dev] [PATCH v4 5/8] net/mvneta: support for promiscuous

2018-09-19 Thread Andrzej Ostruszka
From: Zyta Szpak Add callbacks for enabling/disabling of promiscuous mode. Signed-off-by: Yelena Krivosheev Signed-off-by: Zyta Szpak --- doc/guides/nics/features/mvneta.ini | 1 + doc/guides/nics/mvneta.rst | 1 + drivers/net/mvneta/mvneta_ethdev.c | 54 ++

[dpdk-dev] [PATCH v4 4/8] net/mvneta: add link update

2018-09-19 Thread Andrzej Ostruszka
From: Zyta Szpak Add callback for updating information about link status/info. Signed-off-by: Natalie Samsonov Signed-off-by: Zyta Szpak --- doc/guides/nics/features/mvneta.ini | 1 + doc/guides/nics/mvneta.rst | 1 + drivers/net/mvneta/mvneta_ethdev.c | 71 +++

[dpdk-dev] [PATCH v4 3/8] net/mvneta: support for setting of MTU

2018-09-19 Thread Andrzej Ostruszka
From: Zyta Szpak Add callback for setting of MTU. Signed-off-by: Natalie Samsonov Signed-off-by: Zyta Szpak --- doc/guides/nics/features/mvneta.ini | 1 + doc/guides/nics/mvneta.rst | 1 + drivers/net/mvneta/mvneta_ethdev.c | 78 + 3 files chang

[dpdk-dev] [PATCH v4 2/8] net/mvneta: add Rx/Tx support

2018-09-19 Thread Andrzej Ostruszka
From: Zyta Szpak Add part of PMD for actual reception/transmission. Signed-off-by: Yelena Krivosheev Signed-off-by: Dmitri Epshtein Signed-off-by: Zyta Szpak --- doc/guides/nics/features/mvneta.ini | 3 + doc/guides/nics/mvneta.rst | 4 + drivers/net/mvneta/Makefile |

[dpdk-dev] [PATCH v4 1/8] net/mvneta: add neta PMD skeleton

2018-09-19 Thread Andrzej Ostruszka
From: Zyta Szpak Add neta pmd driver skeleton providing base for the further development. Signed-off-by: Natalie Samsonov Signed-off-by: Yelena Krivosheev Signed-off-by: Dmitri Epshtein Signed-off-by: Zyta Szpak Signed-off-by: Andrzej Ostruszka --- MAINTAINERS

[dpdk-dev] [PATCH v4 0/8] Add Marvell NETA PMD

2018-09-19 Thread Andrzej Ostruszka
This patch series introduces new PMD for Marvell NETA adapters (MVNETA). See the documentation for more info. It is split for easier reviewing. v4: * rebased on top of next-net (DEV_RX_OFFLOAD_CRC_STRIP removed) * Rx/Tx functionality moved to new mvneta_rxtx.c file * removed eth_mvneta alia

Re: [dpdk-dev] [PATCH v2 2/2] examples/vdpa: introduce a new sample for vDPA

2018-09-19 Thread Wang, Xiao W
Hi Xiaolong, > -Original Message- > From: Ye, Xiaolong > Sent: Friday, September 14, 2018 2:07 AM > To: dev@dpdk.org; Maxime Coquelin ; Bie, > Tiwei ; Wang, Zhihong > Cc: Wang, Xiao W ; Rami Rosen > ; Wang, Haiyue ; Ye, > Xiaolong > Subject: [PATCH v2 2/2] examples/vdpa: introduce a new

Re: [dpdk-dev] [PATCH v2 1/2] vhost: introduce API to get vDPA device number

2018-09-19 Thread Wang, Xiao W
Hi, > -Original Message- > From: Ye, Xiaolong > Sent: Friday, September 14, 2018 2:07 AM > To: dev@dpdk.org; Maxime Coquelin ; Bie, > Tiwei ; Wang, Zhihong > Cc: Wang, Xiao W ; Rami Rosen > ; Wang, Haiyue ; Ye, > Xiaolong > Subject: [PATCH v2 1/2] vhost: introduce API to get vDPA device

Re: [dpdk-dev] [PATCH v2 2/2] net/failsafe: support multicast address list set

2018-09-19 Thread Gaëtan Rivet
Hi, Sorry about the delay on this, overall it looks ok; I have an issue however, see inline. On Mon, Sep 03, 2018 at 07:55:22AM +0100, Andrew Rybchenko wrote: > From: Evgeny Im > > Signed-off-by: Evgeny Im > Signed-off-by: Andrew Rybchenko > --- > doc/guides/nics/features/failsafe.ini | 1

[dpdk-dev] [PATCH] net: fix Intel prepare function for IP checksum offload

2018-09-19 Thread Didier Pallard
Current Intel tx prepare function does not properly handle the case where only IP checksum is requested, without requesting any L4 checksum or TSO: IP checksum is not properly reset to 0 and output packet may contain invalid IP checksum. Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") Cc: sta..

Re: [dpdk-dev] [PATCH] net/ifc: add live migration support

2018-09-19 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ye Xiaolong > Sent: Friday, September 14, 2018 4:40 AM > To: Wang, Xiao W > Cc: Bie, Tiwei ; dev@dpdk.org; Wang, Zhihong > > Subject: Re: [dpdk-dev] [PATCH] net/ifc: add live migration support > > Reviewed-and

Re: [dpdk-dev] [PATCH v2 0/7] update ixgbe base code

2018-09-19 Thread Zhang, Qi Z
> -Original Message- > From: Li, Xiaoyun > Sent: Monday, September 17, 2018 5:28 PM > To: Zhang, Qi Z ; Lu, Wenzhuo > ; Yigit, Ferruh > Cc: dev@dpdk.org; Li, Xiaoyun > Subject: [PATCH v2 0/7] update ixgbe base code > > Update the ixgbe base code to version cid-ixgbe.2018.08.28.tar.gz.

Re: [dpdk-dev] [PATCH v3 0/9] Improve running DPDK without hugetlbfs mounpoint

2018-09-19 Thread Thomas Monjalon
19/09/2018 15:55, Burakov, Anatoly: > On 19-Sep-18 2:04 PM, Thomas Monjalon wrote: > >> Anatoly Burakov (9): > >>fbarray: fix detach in noshconf mode > >>eal: don't allow legacy mode with in-memory mode > >>mem: raise maximum fd limit unconditionally > >>memalloc: rename lock list t

[dpdk-dev] [PATCH] app/testpmd: fix missing jump action in flow action

2018-09-19 Thread Reshma Pattan
Added missing JUMP flow action in flow_action array. Without this the flow rule cannot be created for JUMP action. Fixes: 938a184a18 ("app/testpmd: implement basic support for flow API") Signed-off-by: Reshma Pattan --- app/test-pmd/config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/a

[dpdk-dev] [PATCH v2 20/20] doc: add external memory sample application guide

2018-09-19 Thread Anatoly Burakov
Add a guide for external memory sample application. The application is identical to Basic Forwarding example in everything except parts of initialization code, so the bits that are identical will not be described. It is also not necessary to describe how external memory is being allocated due to t

[dpdk-dev] [PATCH v2 15/20] malloc: allow detaching from external memory

2018-09-19 Thread Anatoly Burakov
Add API to detach from existing chunk of external memory in a process. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 27 ++ lib/librte_eal/common/rte_malloc.c | 27 ++ lib/librte_eal/rte_eal_version.map |

[dpdk-dev] [PATCH v2 08/20] malloc: add name to malloc heaps

2018-09-19 Thread Anatoly Burakov
We will need to refer to external heaps in some way. While we use heap ID's internally, for external API use it has to be something more user-friendly. So, we will be using a string to uniquely identify a heap. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc_heap.h |

[dpdk-dev] [PATCH v2 16/20] test: add unit tests for external memory support

2018-09-19 Thread Anatoly Burakov
Add simple unit tests to test external memory support. The tests are pretty basic and mostly consist of checking if invalid API calls are handled correctly, plus a simple allocation/deallocation test for malloc and memzone. Signed-off-by: Anatoly Burakov --- test/test/Makefile| 1 +

  1   2   >