>From: Stephen Hemminger <step...@networkplumber.org>
>Sent: Tuesday, September 18, 2018 8:07 AM
>
>On Tue, 18 Sep 2018 11:40:28 +0200
>Thomas Monjalon <tho...@monjalon.net> wrote:
>
>> 25/07/2018 20:20, Stephen Hemminger:
>> > No need for profanity in comments.
>> >
>> > Signed-off-by: Stephen Hemminger <sthem...@microsoft.com>
>> > ---
>> > drivers/net/bnx2x/elink.c | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
>> > index 34a29373af3b..08fe817720a1 100644
>> > --- a/drivers/net/bnx2x/elink.c
>> > +++ b/drivers/net/bnx2x/elink.c
>> > @@ -3993,11 +3993,11 @@ static elink_status_t
>elink_get_mod_abs_int_cfg(struct bnx2x_softc *sc,
>> > PORT_HW_CFG_E3_MOD_ABS_MASK) >>
>> > PORT_HW_CFG_E3_MOD_ABS_SHIFT;
>> >
>> > - /* Should not happen. This function called upon interrupt
>> > + /*
>> > + * Should not happen. This function called upon
>> > + interrupt
>> > * triggered by GPIO ( since EPIO can only generate interrupts
>> > * to MCP).
>> > * So if this function was called and none of the GPIOs was
>> > set,
>> > - * it means the shit hit the fan.
>> > */
>>
>> It makes the comment ends with a comma, like the end is missing.
>>
>>
>>
>
>Yes, better language would be.
> /* This should not happen since this function is called
> * from interrupt triggered by GPI ..
+1
I've re-worded the last bit.
/* This should not happen since this function is called
* from interrupt triggered by GPIO (since EPIO can only
* generate interrupts to MCP).
* So if this function was called and none of the GPIOs was set,
* it means something disastrous has already happened.
*/
Thanks!
-Rasesh
