Re: [dpdk-dev] [PATCH 2/8] net/ixgbe/base: cleanup codes

2018-09-16 Thread Li, Xiaoyun
OK. I will put the two related patches in one patch to avoid in between build. Thanks. > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, September 13, 2018 17:03 > To: Li, Xiaoyun ; Lu, Wenzhuo > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/8] net/ixgbe/base: cleanup codes

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

2018-09-16 Thread Matan Azrad
Hi Chas From: Chas Williams > On Thu, Sep 13, 2018 at 11:40 AM Matan Azrad > wrote: > > > > Hi Chas > > > > From: Chas Williams > > > On Wed, Sep 12, 2018 at 1:56 AM Matan Azrad > > > wrote: > > > > > > > > Hi Chas > > > > > > > > From: Chas Williams > > > > > On Mon, Aug 6, 2018 at 3:35 PM M

Re: [dpdk-dev] compressdev: append dest data in PMDs instead of in application

2018-09-16 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona >Sent: 16 September 2018 15:38 >To: Verma, Shally ; dev@dpdk.org >Cc: Daly, Lee ; Jozwiak, TomaszX >; Akhil Goyal ; Sahu, >Sunila ; Gupta, Ashish ; >Trahe, Fiona >Subject: RE: compressdev: append dest data in PMDs instead of in application > >E

Re: [dpdk-dev] [PATCH v2 03/33] crypto/octeontx: add PCI probe and remove

2018-09-16 Thread Joseph, Anoob
Hi Akhil, See inline. Thanks, Anoob On 14-09-2018 18:09, Akhil Goyal wrote: External Email On 9/4/2018 9:28 AM, Anoob Joseph wrote: From: Ankur Dwivedi Adding basic PCI probe/remove functions for OcteonTX crypto device. Initialization function for logging is also added. Signed-off-by: A

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-16 Thread Joseph, Anoob
Hi Akhil, Please see inline. Thanks, Anoob On 14-09-2018 17:41, Akhil Goyal wrote: External Email Hi Anoob, On 9/4/2018 9:28 AM, Anoob Joseph wrote: From: Ankur Dwivedi This adds Makefile, meson.build and config file options. Also adds the version map files and maintainers file to claim

[dpdk-dev] [PATCH v2] vhost: fix corner case for enqueue operation

2018-09-16 Thread Jiayu Hu
When perform enqueue operations on the split and packed ring, if the reserved buffer length from the descriptor table execeeds 65535, the returned length by fill_vec_buf_split/_packed() is overflowed. This patch is to avoid this corner case. Fixes: f689586b ("vhost: shadow used ring update") Fixes

Re: [dpdk-dev] [PATCH] bonding: add QinQ packet xmit hash support

2018-09-16 Thread Lilijun (Jerry, Cloud Networking)
> -Original Message- > From: chasmosau...@gmail.com [mailto:chasmosau...@gmail.com] On > Behalf Of Chas Williams > Sent: Monday, September 17, 2018 12:02 AM > To: Lilijun (Jerry, Cloud Networking) > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] bonding: add QinQ packet xmit hash > s

Re: [dpdk-dev] [PATCH v2 2/4] doc: remove redundant prerequisite info for dpaa devices

2018-09-16 Thread Hemant Agrawal
07/09/2018 09:25, Hemant Agrawal: > Signed-off-by: Hemant Agrawal > --- > doc/guides/cryptodevs/dpaa_sec.rst | 25 ++-- > doc/guides/eventdevs/dpaa.rst | 48 +++ > doc/guides/nics/dpaa.rst | 59 > +- > 3

Re: [dpdk-dev] [PATCH 00/13] driver/net: NXP DPAA driver enhancements

2018-09-16 Thread Hemant Agrawal
OK. We will rework and re-post the series. -Original Message- From: Thomas Monjalon Sent: Monday, September 17, 2018 1:14 AM To: Hemant Agrawal Cc: dev@dpdk.org; Ferruh Yigit ; dpdk-up Subject: Re: [dpdk-dev] [PATCH 00/13] driver/net: NXP DPAA driver enhancements Importance: High 14

Re: [dpdk-dev] [PATCH] doc: add cross compile part for sample applications

2018-09-16 Thread Gavin Hu (Arm Technology China)
Hi Thomas, V2 was submitted, thanks for review! http://patchwork.dpdk.org/patch/44768/ Best Regards, Gavin > -Original Message- > From: Thomas Monjalon > Sent: Friday, September 14, 2018 10:55 PM > To: Gavin Hu (Arm Technology China) > Cc: dev@dpdk.org; Honnappa Nagarahalli > Subject:

[dpdk-dev] [PATCH v2] doc: add cross compile part for sample applications

2018-09-16 Thread Gavin Hu
Fixes: 7cacb05655 ("doc: add generic build instructions for sample apps") Cc: sta...@dpdk.org Signed-off-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli --- doc/guides/sample_app_ug/compiling.rst | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/doc/guides/sampl

Re: [dpdk-dev] [PATCH 00/13] driver/net: NXP DPAA driver enhancements

2018-09-16 Thread Thomas Monjalon
14/09/2018 12:56, Ferruh Yigit: > On 8/29/2018 11:47 AM, Hemant Agrawal wrote: > > > > Hemant Agrawal (9): > > net/dpaa: configure frame queue on MAC ID basis > > net/dpaa: fix jumbo buffer config > > net/dpaa: implement scatter offload support > > net/dpaa: minor debug log enhancements >

Re: [dpdk-dev] [PATCH] vmxnet3: stats_reset implementation

2018-09-16 Thread Yogev Chaimovich
No problem. I wrote this description - I hope it's understandable. I also attached the new commit to this mail. " 'stats_reset()' callback was missing. This commit implements the callback by taking a snapshot of the stats (SNAPSHOT) each time 'stats_reset()' is called. When getting stats with 'st

[dpdk-dev] [PATCH 2/3] ethdev: convert testpmd encap commands to new API

2018-09-16 Thread Ori Kam
Currently there are 2 encapsulation commands in testpmd one for VXLAN and one for NVGRE, both of those commands are using the old rte encap command. This commit update the commands to work with the new tunnel encap actions. The reason that we have different encapsulation commands, one for VXLAN a

[dpdk-dev] [PATCH 3/3] ethdev: remove vxlan and nvgre encapsulation commands

2018-09-16 Thread Ori Kam
This patch removes the VXLAN and NVGRE encapsulation commands. Those commands are subset of the TUNNEL_ENCAP command so there is no need to keep both versions. Signed-off-by: Ori Kam --- doc/guides/prog_guide/rte_flow.rst | 107 - lib/librte_ethdev/rte_flow.h

[dpdk-dev] [PATCH 1/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-09-16 Thread Ori Kam
Currenlty the encap/decap actions only support encapsulation of VXLAN and NVGRE L2 packets (L2 encapsulation is where the inner packet has a valid Ethernet header, while L3 encapsulation is where the inner packet doesn't have the Ethernet header). In addtion the parameter to to the encap action is

[dpdk-dev] [PATCH 0/3] add generic L2/L3 tunnel encapsulation actions

2018-09-16 Thread Ori Kam
This series implement the generic L2/L3 tunnel encapsulation actions and is based on rfc [1] "add generic L2/L3 tunnel encapsulation actions" Currenlty the encap/decap actions only support encapsulation of VXLAN and NVGRE L2 packets (L2 encapsulation is where the inner packet has a valid Ethernet

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

2018-09-16 Thread Chas Williams
On Thu, Sep 13, 2018 at 11:40 AM Matan Azrad wrote: > > Hi Chas > > From: Chas Williams > > On Wed, Sep 12, 2018 at 1:56 AM Matan Azrad > > wrote: > > > > > > Hi Chas > > > > > > From: Chas Williams > > > > On Mon, Aug 6, 2018 at 3:35 PM Matan Azrad > > > > wrote: > > > > > > > > > > > > > > >

Re: [dpdk-dev] [PATCH] bonding: add QinQ packet xmit hash support

2018-09-16 Thread Chas Williams
I think this change already went in dpdk-next-net: commit 61e99d7e944885e8d625ded41b5877653e0b637e Author: Yunjian Wang Date: Tue Aug 7 16:10:46 2018 +0800 net/bonding: add support to match on 0x88A8 ethertype We assume VLAN ethtertype is 0x8100 in get_vlan_offset() function, but

[dpdk-dev] [PATCH v2 3/3] app/testpmd: add debug command Tx metadata set

2018-09-16 Thread Dekel Peled
As described in [1],[2] this series adds option to set metadata value as match pattern when creating a new flow rule. This patch introduces code for debug porpuse only. The new debug command takes a 32 bit value and stores it per port. testpmd will add to any Tx packet sent from this port the meta

[dpdk-dev] [PATCH v2 2/3] app/testpmd: support metadata as flow rule criteria

2018-09-16 Thread Dekel Peled
As described in [1], this series adds option to set metadata value as match pattern when creating a new flow rule. This patch introduces additional options in testpmd commands. New item type "meta" "data", new offload flag "match_metadata". [1] "ethdev: support metadata as flow rule criteria" Si

[dpdk-dev] [PATCH v2 0/3] *** SUBJECT HERE ***

2018-09-16 Thread Dekel Peled
This series implements the match-metadata feature described in [1]. [1] "[RFC,v2] ethdev: support metadata as flow rule criteria" V2: * Fix some checkpatch coding style issues (wrongly sent). Dekel Peled (3): ethdev: support metadata as flow rule criteria app/testpmd: support metadata as flo

[dpdk-dev] [PATCH v2 1/3] ethdev: support metadata as flow rule criteria

2018-09-16 Thread Dekel Peled
As described in [1], a new rte_flow item is added to support metadata to use as flow rule match pattern. The metadata is an opaque item, fully controlled by the application. The use of metadata is relevant for egress rules only. It can be set in the flow rule using the RTE_FLOW_ITEM_META. In orde

[dpdk-dev] [PATCH] net/mlx5: support metadata as flow rule criteria

2018-09-16 Thread Dekel Peled
As described in series starting at [1], it adds option to set metadata value as match pattern when creating a new flow rule. This patch adds metadata support in mlx5 driver, in several parts: - Add the setting of metadata value in matcher when creating a new flow rule. - Add the passing of metadat

[dpdk-dev] [PATCH 2/3] app/testpmd: support metadata as flow rule criteria

2018-09-16 Thread Dekel Peled
As described in [1], this series adds option to set metadata value as match pattern when creating a new flow rule. This patch introduces additional options in testpmd commands. New item type "meta" "data", new offload flag "match_metadata". [1] "ethdev: support metadata as flow rule criteria" Si

[dpdk-dev] [PATCH 3/3] app/testpmd: add debug command tx_metadata set

2018-09-16 Thread Dekel Peled
As described in [1],[2] this series adds option to set metadata value as match pattern when creating a new flow rule. This patch introduces code for debug porpuse only. The new debug command takes a 32 bit value and stores it per port. testpmd will add to any Tx packet sent from this port the meta

[dpdk-dev] [PATCH 1/3] ethdev: support metadata as flow rule criteria

2018-09-16 Thread Dekel Peled
As described in [1], a new rte_flow item is added to support metadata to use as flow rule match pattern. The metadata is an opaque item, fully controlled by the application. The use of metadata is relevant for egress rules only. It can be set in the flow rule using the RTE_FLOW_ITEM_META. In orde

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-09-16 Thread Jerin Jacob
-Original Message- > Date: Sat, 15 Sep 2018 22:36:18 +0530 > From: "Joseph, Anoob" > To: "Ananyev, Konstantin" , "dev@dpdk.org" > > Cc: "Awal, Mohammad Abdul" , "Doherty, > Declan" , "Jerin Jacob > (jerin.ja...@caviumnetworks.com)" , > Narayana Prasad > Subject: Re: [dpdk-dev] [RFC]

Re: [dpdk-dev] [RFC] eal: allow hotplug to skip an already probed device

2018-09-16 Thread Ophir Munk
> -Original Message- > From: Ophir Munk > Sent: Thursday, September 13, 2018 9:30 AM > To: Thomas Monjalon ; dev@dpdk.org > Cc: gaetan.ri...@6wind.com; Olga Shern ; Shahaf > Shuler ; Asaf Penso > Subject: RE: [dpdk-dev] [RFC] eal: allow hotplug to skip an already probed > device > > >

Re: [dpdk-dev] compressdev: append dest data in PMDs instead of in application

2018-09-16 Thread Trahe, Fiona
Hi Shally, > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Saturday, September 15, 2018 12:32 PM > To: Trahe, Fiona ; dev@dpdk.org > Cc: Daly, Lee ; Jozwiak, TomaszX > ; Akhil Goyal > ; Sahu, Sunila ; Gupta, Ashish > > Subject: RE: compressdev: append

Re: [dpdk-dev] [PATCH] test/hash: solve unit test hash compilation error

2018-09-16 Thread Thomas Monjalon
Hi, 27/08/2018 16:26, Dharmik Thakkar: > Enable print_key_info() function compilation always. > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Gavin Hu > Suggested-by: Honnappa Nagarahalli Please describe the issue you are fixing and add a tag "Fixes:" to

Re: [dpdk-dev] [PATCH] acl: fix invalid results for rule with zero priority

2018-09-16 Thread Thomas Monjalon
24/08/2018 18:47, Konstantin Ananyev: > If user specifies priority=0 for some of ACL rules > that can cause rte_acl_classify to return wrong results. > The reason is that priority zero is used internally for no-match nodes. > See more details at: https://bugs.dpdk.org/show_bug.cgi?id=79. > The simp

Re: [dpdk-dev] [PATCH] mbuf: remove deprecated segment free functions

2018-09-16 Thread Thomas Monjalon
10/09/2018 10:06, Andrew Rybchenko: > On 09/10/2018 08:18 AM, David Marchand wrote: > > __rte_mbuf_raw_free and __rte_pktmbuf_prefree_seg have been deprecated for > > a long time now (early 17.05), are not part of the abi and are easily > > replaced with existing api. > > > > Signed-off-by: David M

Re: [dpdk-dev] [PATCH v2] bus/vdev: fix wrong error log on secondary device scan

2018-09-16 Thread Thomas Monjalon
> > When a secondary process handles VDEV_SCAN_ONE mp action, it is possible > > the device is already be inserted. This happens when we have multiple > > secondary > > processes which cause multiple broadcasts from primary during > > bus->scan. So we don't need to log any error for -EEXIST. > >

Re: [dpdk-dev] [PATCH 3/4] ethdev: add Rx offload outer L4 checksum definitions

2018-09-16 Thread Jerin Jacob
-Original Message- > Date: Sun, 16 Sep 2018 05:53:30 + > From: Shahaf Shuler > To: Jerin Jacob > CC: Wenzhuo Lu , Jingjing Wu , > Bernard Iremonger , John McNamara > , Marko Kovacevic , > Thomas Monjalon , Ferruh Yigit > , Andrew Rybchenko , > Olivier Matz , "dev@dpdk.org" > Sub

Re: [dpdk-dev] [PATCH] malloc: fix potential null pointer dereference

2018-09-16 Thread Thomas Monjalon
15/08/2018 10:56, Burakov, Anatoly: > On 15-Aug-18 8:20 AM, Tiwei Bie wrote: > > We need to do the NULL pointer check first after malloc(). > > > > Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Tiwei Bie > > Acked-by: Anatoly

Re: [dpdk-dev] [PATCH] compat: fix symbol version support with meson

2018-09-16 Thread Thomas Monjalon
30/08/2018 19:31, Luca Boccassi: > On Thu, 2018-08-30 at 18:07 +0100, Bruce Richardson wrote: > > For meson builds, the define to enable the symbol version > > macros in rte_compat.h was missing. This led to symbols being > > omitted from shared objects. For example, checking rte_distributor.so > >

Re: [dpdk-dev] [PATCH v6 1/2] net/mlx5: support meson build

2018-09-16 Thread Shahaf Shuler
Thursday, September 13, 2018 3:42 PM, Bruce Richardson: > Subject: Re: [PATCH v6 1/2] net/mlx5: support meson build > > On Thu, Sep 13, 2018 at 03:11:05PM +0300, Shahaf Shuler wrote: > > From: Nelio Laranjeiro > > > > Compile Mellanox driver when its external dependencies are met. A > > glue ver

Re: [dpdk-dev] [PATCH] net/mlx5: add bluefield vf support

2018-09-16 Thread Shahaf Shuler
Tuesday, September 11, 2018 8:49 PM, Yongseok Koh: > Subject: Re: [PATCH] net/mlx5: add bluefield vf support > > > > On Sep 2, 2018, at 6:55 AM, Ori Kam wrote: > > > > Signed-off-by: Ori Kam > > --- > Acked-by: Yongseok Koh Applied to next-net-mlx, thanks.

Re: [dpdk-dev] [PATCH v2 1/4] build: include missing hypervisor files in Meson build

2018-09-16 Thread Thomas Monjalon
31/08/2018 13:00, Bruce Richardson: > On Fri, Aug 31, 2018 at 11:41:51AM +0100, Luca Boccassi wrote: > > They are built by the legacy makefiles but not by Meson. > > > > Fixes: 8f40ee0734c8 ("eal/x86: get hypervisor name") > > > > Signed-off-by: Luca Boccassi > > Acked-by: Bruce Richardson Sh

Re: [dpdk-dev] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined

2018-09-16 Thread Thomas Monjalon
02/09/2018 20:35, Honnappa Nagarahalli: > GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not > optional for ArmV8. Hence NEON related code can be enabled > when __aarch64__ is defined. > > Bugzilla ID: 82 > Cc: sta...@dpdk.org > > Reported-by: Raslan Darawsheh > Reported-by: Thomas F

Re: [dpdk-dev] [PATCH v2 2/4] doc: remove redundant prerequisite info for dpaa devices

2018-09-16 Thread Thomas Monjalon
07/09/2018 09:25, Hemant Agrawal: > Signed-off-by: Hemant Agrawal > --- > doc/guides/cryptodevs/dpaa_sec.rst | 25 ++-- > doc/guides/eventdevs/dpaa.rst | 48 +++ > doc/guides/nics/dpaa.rst | 59 > +- > 3 f

Re: [dpdk-dev] [dpdk-stable] [PATCH] mk: disable OcteonTx for buggy compilers only on arm64

2018-09-16 Thread Thomas Monjalon
03/09/2018 15:32, Ferruh Yigit: > On 9/3/2018 10:31 AM, Jerin Jacob wrote: > > Disable octeontx for gcc 4.8.5 as the compiler is emitting "internal > > compiler error" for aarch64. The GCC "internal compiler error" was > > observed only for arm64 architecture so disable the PMD only > > for arm64.