Re: [dpdk-dev] [PATCH v2 3/4] app/test-eventdev: add Tx adapter support

2018-09-04 Thread Rao, Nikhil
On 9/4/2018 7:42 PM, Pavan Nikhilesh wrote: Convert existing Tx service based pipeline to Tx adapter based APIs and simplify worker functions. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_atq.c| 269 --- app/test-eventdev/test_pipeline_common.c |

[dpdk-dev] [PATCH v5] linuxapp, eal: Fix the memory leak issue of logid

2018-09-04 Thread Ziye Yang
From: Ziye Yang This patch is used to fix the memory leak issue of logid. We use the ASAN test in SPDK when intergrating DPDK and find this memory leak issue. Signed-off-by: Ziye Yang --- lib/librte_eal/linuxapp/eal/eal.c | 21 - lib/librte_eal/linuxapp/eal/eal_log.c |

[dpdk-dev] [PATCH v4] linuxapp, eal: Fix the memory leak issue of logid

2018-09-04 Thread Ziye Yang
From: Ziye Yang This patch is used to fix the memory leak issue of logid. We use the ASAN test in SPDK when intergrating DPDK and find this memory leak issue. Signed-off-by: Ziye Yang --- lib/librte_eal/linuxapp/eal/eal.c | 21 - lib/librte_eal/linuxapp/eal/eal_log.c |

Re: [dpdk-dev] MLX5 should define the timestamp field in the doc

2018-09-04 Thread Shahaf Shuler
Hi Tom, Tuesday, September 4, 2018 5:26 PM, Tom Barbette: > >Hi all, > >As far as I know, MLX5 is the only driver to support hardware timestamping. > >It would be great to update the doc to explain what the hardware timestamp is >supposed to be. We probably need to update the doc, but the

Re: [dpdk-dev] [PATCH v3] doc: Clarify IOMMU usage with "uio_pci_generic" kernel module

2018-09-04 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: tone.zhang > Sent: Wednesday, September 5, 2018 1:18 PM > To: dev@dpdk.org > Cc: Gavin Hu (Arm Technology China) ; > bruce.richard...@intel.com; bl...@debian.org; roszenr...@gmail.com; nd > > Subject: [PATCH v3] doc: Clarify IOMMU usage with "uio_pci_generi

[dpdk-dev] [PATCH v3] doc: Clarify IOMMU usage with "uio_pci_generic" kernel module

2018-09-04 Thread tone.zhang
If the devices used for DPDK are bound to the "uio_pci_generic" kernel module, the IOMMU should be disabled in order not to break the IO transmission because of the virtual / physical address mapping. The patch clarifies the IOMMU configurations on both x86_64 and arm64 systems. Signed-off-by: to

[dpdk-dev] [PATCH v3] linuxapp, eal: Fix the memory leak issue of logid

2018-09-04 Thread Ziye Yang
From: Ziye Yang This patch is used to fix the memory leak issue of logid. We use the ASAN test in SPDK when intergrating DPDK and find this memory leak issue. Signed-off-by: Ziye Yang --- lib/librte_eal/linuxapp/eal/eal.c | 13 - lib/librte_eal/linuxapp/eal/eal_log.c | 12 +

[dpdk-dev] [PATCH v2] doc: Clarify IOMMU usage with "uio_pci_generic" kernel module

2018-09-04 Thread tone.zhang
If the devices used for DPDK are bound to the "uio_pci_generic" kernel module, the IOMMU should be disabled in order not to break the IO transmission because of the virtual / physical address mapping. The patch clarifies the IOMMU configurations on both x86_64 and arm64 systems. Signed-off-by: to

[dpdk-dev] [PATCH 2/3] net/virtio-user: avoid parsing process mappings

2018-09-04 Thread Tiwei Bie
Recently some memory APIs were introduced to allow users to get the file descriptor and offset for each memory segment. We can leverage those APIs to get rid of the /proc magic on memory table preparation in vhost-user backend. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_user/vhost_us

[dpdk-dev] [PATCH 0/3] Some fixes/improvements for virtio-user memory table

2018-09-04 Thread Tiwei Bie
This series consists of some fixes and improvements for virtio-user's memory table preparation. This series supersedes below patches: https://patches.dpdk.org/patch/43807/ https://patches.dpdk.org/patch/43918/ The second patch in this series depends on the below patch set: http://patches.dpdk.org

[dpdk-dev] [PATCH 3/3] net/virtio-user: fix memory hotplug support in vhost-kernel

2018-09-04 Thread Tiwei Bie
It's possible to have much more hugepage backed memory regions than what vhost-kernel supports due to the memory hotplug, which may cause problems. A better solution is to have the virtio-user pass all the memory ranges reserved by DPDK to vhost-kernel. Fixes: 12ecb2f63b12 ("net/virtio-user: suppo

[dpdk-dev] [PATCH 1/3] net/virtio-user: fix deadlock in memory events callback

2018-09-04 Thread Tiwei Bie
Deadlock can occur when allocating memory if a vhost-kernel based virtio-user device is in use. To fix the deadlock, we will take memory hotplug lock explicitly in virtio-user when necessary, and always call the _thread_unsafe memory functions. Bugzilla ID: 81 Fixes: 12ecb2f63b12 ("net/virtio-user

Re: [dpdk-dev] [PATCH] eal: force IOVA mode to physical

2018-09-04 Thread Eric Zhang
On 08/30/2018 08:59 AM, santosh wrote: On Thursday 30 August 2018 05:43 PM, Hemant wrote: External Email Hi, On 8/30/2018 3:13 PM, Gaëtan Rivet wrote: Hi, On Thu, Aug 30, 2018 at 10:09:04AM +0100, Burakov, Anatoly wrote: On 29-Aug-18 4:58 PM, eric zhang wrote: This patch adds a configur

Re: [dpdk-dev] [PATCH] doc: Clarify IOMMU usage with "uio-pci" kernel module

2018-09-04 Thread Tone Zhang (Arm Technology China)
Hi Rami, Yes, I mean “uio_pci_generic” kernel module. I will update the change accordingly. Thanks. Br, Tone From: Rami Rosen Sent: Wednesday, September 5, 2018 3:55 AM To: Tone Zhang (Arm Technology China) Cc: dev@dpdk.org; nd Subject: Re: [dpdk-dev] [PATCH] doc: Clarify IOMMU usage with "

[dpdk-dev] [PATCH] vhost: fix vhost interrupt support

2018-09-04 Thread Tiwei Bie
When VIRTIO_RING_F_EVENT_IDX is negotiated, we need to update the avail event to enable the notification. Fixes: 3f8ff12821e4 ("vhost: support interrupt mode") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- lib/librte_vhost/Makefile | 1 + lib/librte_vhost/vhost.c | 18 -- l

Re: [dpdk-dev] [PATCH v3] hash table: add an iterator over conflicting entries

2018-09-04 Thread Wang, Yipeng1
Thanks for your reply. >-Original Message- >From: Michel Machado [mailto:mic...@digirati.com.br] >Exposing the private fields would bind the interface with the >current implementation of the hash table. In the way we are proposing, >one should be able to replace the underlying algorit

Re: [dpdk-dev] [PATCH] doc: Clarify IOMMU usage with "uio-pci" kernel module

2018-09-04 Thread Rami Rosen
Hi Tone, >if the devices for used DPDK bound to the ``uio-pci`` kernel module, please make The three kernel modules which can be used for DPDK binding are vfio-pci, uio_pci_generic and igb_uio. Don't you mean here uio_pci_generic ? Regards, Rami Rosen בתאריך יום ג׳, 4 בספט׳ 2018, 11:59, מאת ton

Re: [dpdk-dev] [PATCH v3] hash table: add an iterator over conflicting entries

2018-09-04 Thread Wang, Yipeng1
Hmm, I guess my comment is for code readability. If we don’t need the extra state that would be great. I think "rte_hash" is defined as an internal data structure but expose the type to the public header. Would this work? I propose to malloc inside function mostly because I think it is cleaner

Re: [dpdk-dev] [PATCH v3] hash table: add an iterator over conflicting entries

2018-09-04 Thread Wang, Yipeng1
Thanks for the patch. Do we need both of the state and istate struct? struct rte_hash_iterator_state seems not doing much. How about we only have one "state" struct and just not expose the internals to the public API, similar to the rte_hash struct or rte_member_setsum struct. And in _init fun

[dpdk-dev] [PATCH 3/3] net/softnic: modify softnic to use librte_table headers

2018-09-04 Thread Kevin Laatz
This commit modifies SoftNIC to make use of the new header files in librte_table. As we are now using the new header files in librte_table in SoftNIC, we no longer need the old header files so they can be removed. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kevin Laatz --- drivers/net/so

[dpdk-dev] [PATCH 2/3] examples/ip_pipeline: modify application to use librte_table headers

2018-09-04 Thread Kevin Laatz
This commit modifies the IP Pipeline application to use the new header files in librte_table. As we are now using the new header files, we can remove the old ones from the application directory. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kevin Laatz --- examples/ip_pipeline/action.c

[dpdk-dev] [PATCH 1/3] lib/librte_table: add hash_func header files

2018-09-04 Thread Kevin Laatz
This commit adds rte_table_hash_func.h and rte_table_hash_func_arm64.h to librte_table. This will replace hash_func.h and hash_func_arm64.h in the IP Pipeline application and in SoftNIC. This also adds a scalar implemetation of the x86_64 intrinsic for crc32 as a generic fallback. Signed-off-by: C

[dpdk-dev] [PATCH v3 4/9] memalloc: rename lock list to fd list

2018-09-04 Thread Anatoly Burakov
Previously, we were only using lock lists to store per-page lock fd's because we cannot use modern fcntl() file description locks to lock parts of the page in single file segments mode. Now, we will be using this list to store either lock fd's (along with memseg list fd) in single file segments mo

[dpdk-dev] [PATCH v3 8/9] mem: allow querying offset into segment fd

2018-09-04 Thread Anatoly Burakov
In a few cases, user may need to query offset into fd for a particular memory segment (for example, to selectively map pages). This commit adds a new API to do that. Signed-off-by: Anatoly Burakov --- Notes: v3: - Fix single file segments mode not working lib/librte_eal/bsdapp/eal/eal_

[dpdk-dev] [PATCH v3 7/9] mem: add external API to retrieve page fd from EAL

2018-09-04 Thread Anatoly Burakov
Now that we can retrieve page fd's internally, we can expose it as an external API. This will add two flavors of API - thread-safe and non-thread-safe. Fix up internal API's to return values we need without modifying rte_errno internally if called from within EAL. We do not want calling code to ac

[dpdk-dev] [PATCH v3 2/9] eal: don't allow legacy mode with in-memory mode

2018-09-04 Thread Anatoly Burakov
In-memory mode was never meant to support legacy mode, because we cannot sort anonymous pages anyway. Fixes: 72b49ff623c4 ("mem: support --in-memory mode") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_options.c | 6 ++ 1 file changed, 6 insertions(

[dpdk-dev] [PATCH v3 3/9] mem: raise maximum fd limit unconditionally

2018-09-04 Thread Anatoly Burakov
Previously, when we allocated hugepages, we closed the fd's corresponding to them after we've done our mappings. Since we did mmap(), we didn't actually lose the reference, but file descriptors used for mmap() do not count against the fd limit. Since we are going to store all of our fd's, we will h

[dpdk-dev] [PATCH v3 9/9] mem: support using memfd segments for in-memory mode

2018-09-04 Thread Anatoly Burakov
Enable using memfd-created segments if supported by the system. This will allow having real fd's for pages but without hugetlbfs mounts, which will enable in-memory mode to be used with virtio. The implementation is mostly piggy-backing on existing real-fd code, except that we no longer need to u

[dpdk-dev] [PATCH v3 6/9] memalloc: add EAL-internal API to get and set segment fd's

2018-09-04 Thread Anatoly Burakov
Enable setting and retrieving segment fd's internally. For now, retrieving fd's will not be used anywhere until we get an external API, but it will be useful for things like virtio, where we wish to share segment fd's. Setting segment fd's will not be available as a public API at this time, but i

[dpdk-dev] [PATCH v3 1/9] fbarray: fix detach in noshconf mode

2018-09-04 Thread Anatoly Burakov
In noshconf mode, no shared files are created, but we're still trying to unlink them, resulting in detach/destroy failure even though it should have succeeded. Fix it by exiting early in noshconf mode. Fixes: 3ee2cde248a7 ("fbarray: support --no-shconf mode") Cc: sta...@dpdk.org Signed-off-by: An

[dpdk-dev] [PATCH v3 5/9] memalloc: track page fd's in non-single file mode

2018-09-04 Thread Anatoly Burakov
Previously, we were only tracking lock file fd's in single-file segments mode, but did not track fd's in non-single file mode because we didn't need to (mmap() call still kept the lock). Now that we are going to expose these fd's to the world, we need to have access to them, so track them even in n

[dpdk-dev] [PATCH v3 0/9] Improve running DPDK without hugetlbfs mounpoint

2018-09-04 Thread Anatoly Burakov
This patchset further improves DPDK support for running without hugetlbfs mountpoints. First of all, it enables using memfd-created hugepages in in-memory mode. This way, instead of anonymous hugepages, we can get proper fd's for each page (or for the entire segment, if we're using single-file seg

[dpdk-dev] [PATCH v2 7/9] mem: add external API to retrieve page fd from EAL

2018-09-04 Thread Anatoly Burakov
Now that we can retrieve page fd's internally, we can expose it as an external API. This will add two flavors of API - thread-safe and non-thread-safe. Fix up internal API's to return values we need without modifying rte_errno internally if called from within EAL. We do not want calling code to ac

[dpdk-dev] [PATCH v2 1/9] fbarray: fix detach in noshconf mode

2018-09-04 Thread Anatoly Burakov
In noshconf mode, no shared files are created, but we're still trying to unlink them, resulting in detach/destroy failure even though it should have succeeded. Fix it by exiting early in noshconf mode. Fixes: 3ee2cde248a7 ("fbarray: support --no-shconf mode") Cc: sta...@dpdk.org Signed-off-by: An

[dpdk-dev] [PATCH v2 2/9] eal: don't allow legacy mode with in-memory mode

2018-09-04 Thread Anatoly Burakov
In-memory mode was never meant to support legacy mode, because we cannot sort anonymous pages anyway. Fixes: 72b49ff623c4 ("mem: support --in-memory mode") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_options.c | 6 ++ 1 file changed, 6 insertions(

[dpdk-dev] [PATCH v2 8/9] mem: allow querying offset into segment fd

2018-09-04 Thread Anatoly Burakov
In a few cases, user may need to query offset into fd for a particular memory segment (for example, to selectively map pages). This commit adds a new API to do that. Signed-off-by: Anatoly Burakov --- lib/librte_eal/bsdapp/eal/eal_memalloc.c | 6 +++ lib/librte_eal/common/eal_common_memory.c

[dpdk-dev] [PATCH v2 9/9] mem: support using memfd segments for in-memory mode

2018-09-04 Thread Anatoly Burakov
Enable using memfd-created segments if supported by the system. This will allow having real fd's for pages but without hugetlbfs mounts, which will enable in-memory mode to be used with virtio. The implementation is mostly piggy-backing on existing real-fd code, except that we no longer need to u

[dpdk-dev] [PATCH v2 5/9] memalloc: track page fd's in non-single file mode

2018-09-04 Thread Anatoly Burakov
Previously, we were only tracking lock file fd's in single-file segments mode, but did not track fd's in non-single file mode because we didn't need to (mmap() call still kept the lock). Now that we are going to expose these fd's to the world, we need to have access to them, so track them even in n

[dpdk-dev] [PATCH v2 3/9] mem: raise maximum fd limit unconditionally

2018-09-04 Thread Anatoly Burakov
Previously, when we allocated hugepages, we closed the fd's corresponding to them after we've done our mappings. Since we did mmap(), we didn't actually lose the reference, but file descriptors used for mmap() do not count against the fd limit. Since we are going to store all of our fd's, we will h

[dpdk-dev] [PATCH v2 6/9] memalloc: add EAL-internal API to get and set segment fd's

2018-09-04 Thread Anatoly Burakov
Enable setting and retrieving segment fd's internally. For now, retrieving fd's will not be used anywhere until we get an external API, but it will be useful for things like virtio, where we wish to share segment fd's. Setting segment fd's will not be available as a public API at this time, but i

[dpdk-dev] [PATCH v2 0/9] Improve running DPDK without hugetlbfs mounpoint

2018-09-04 Thread Anatoly Burakov
This patchset further improves DPDK support for running without hugetlbfs mountpoints. First of all, it enables using memfd-created hugepages in in-memory mode. This way, instead of anonymous hugepages, we can get proper fd's for each page (or for the entire segment, if we're using single-file seg

[dpdk-dev] [PATCH v2 4/9] memalloc: rename lock list to fd list

2018-09-04 Thread Anatoly Burakov
Previously, we were only using lock lists to store per-page lock fd's because we cannot use modern fcntl() file description locks to lock parts of the page in single file segments mode. Now, we will be using this list to store either lock fd's (along with memseg list fd) in single file segments mo

Re: [dpdk-dev] [PATCH v2] bus/vdev: fix wrong error log on secondary device scan

2018-09-04 Thread Eads, Gage
Acked-by: Gage Eads Thanks! Gage > -Original Message- > From: Zhang, Qi Z > Sent: Monday, September 3, 2018 3:50 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Burakov, Anatoly ; > Eads, Gage ; Zhang, Qi Z ; > sta...@dpdk.org > Subject: [PATCH v2] bus/vdev: fix wrong error log on secon

[dpdk-dev] MLX5 should define the timestamp field in the doc

2018-09-04 Thread Tom Barbette
Hi all, As far as I know, MLX5 is the only driver to support hardware timestamping. It would be great to update the doc to explain what the hardware timestamp is supposed to be. If it's nanoseconds, then just a shift regarding system time is enough ? Does it also need a multiplication? Can we

[dpdk-dev] [PATCH] net/pcap: physical interface MAC address support

2018-09-04 Thread Juhamatti Kuusisaari
Support for PCAP physical interface MAC with phy_mac=1 devarg. Signed-off-by: Juhamatti Kuusisaari --- drivers/net/pcap/rte_eth_pcap.c | 64 ++--- 1 file changed, 59 insertions(+), 5 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth

[dpdk-dev] [PATCH v2 4/4] doc: update eventdev application guide

2018-09-04 Thread Pavan Nikhilesh
Update eventdev application guide to reflect Tx adapter related changes. Signed-off-by: Pavan Nikhilesh --- .../eventdev_pipeline_atq_test_generic.svg| 848 +++--- ...ntdev_pipeline_atq_test_internal_port.svg} | 26 +- .../eventdev_pipeline_queue_test_generic.svg | 570 +++-

[dpdk-dev] [PATCH v2 2/4] app/test-eventdev: remove redundant newlines

2018-09-04 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c index a54068df3..832ab8b6e 100644 --- a/app/

[dpdk-dev] [PATCH v2 3/4] app/test-eventdev: add Tx adapter support

2018-09-04 Thread Pavan Nikhilesh
Convert existing Tx service based pipeline to Tx adapter based APIs and simplify worker functions. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_atq.c| 269 --- app/test-eventdev/test_pipeline_common.c | 206 + app/test-eventdev/test_p

[dpdk-dev] [PATCH v2 1/4] app/test-eventdev: fix minor typos

2018-09-04 Thread Pavan Nikhilesh
Fix minor typos. Fixes: 314bcf58ca8f ("app/eventdev: add pipeline queue worker functions") Signed-off-by: Pavan Nikhilesh --- v2 Changes: - remove stray newlines in logs. - update pipeline description (Nikhil). - add Tx adapter error condition when some ethdev, eventdev pair have internal p

[dpdk-dev] [PATCH v7 4/4] doc/guides/sample_app_ug/l3_forward_power_man.rst: empty poll update

2018-09-04 Thread Liang Ma
add empty poll mode command line example Signed-off-by: Liang Ma --- doc/guides/sample_app_ug/l3_forward_power_man.rst | 21 + 1 file changed, 21 insertions(+) diff --git a/doc/guides/sample_app_ug/l3_forward_power_man.rst b/doc/guides/sample_app_ug/l3_forward_power_man.rst

[dpdk-dev] [PATCH v7 3/4] doc/guides/proguides/power-man: update the power API

2018-09-04 Thread Liang Ma
update the document for empty poll API. Signed-off-by: Liang Ma --- doc/guides/prog_guide/power_man.rst | 87 + 1 file changed, 87 insertions(+) diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst index eba1cc6..d8a4ef7 100

[dpdk-dev] [PATCH v7 1/4] lib/librte_power: traffic pattern aware power control

2018-09-04 Thread Liang Ma
1. Abstract For packet processing workloads such as DPDK polling is continuous. This means CPU cores always show 100% busy independent of how much work those cores are doing. It is critical to accurately determine how busy a core is hugely important for the following reasons: * No indication o

[dpdk-dev] [PATCH v7 2/4] examples/l3fwd-power: simple app update for new API

2018-09-04 Thread Liang Ma
Add the support for new traffic pattern aware power control power management API. Example: ./l3fwd-power -l xxx -n 4 -w :xx:00.0 -w :xx:00.1 -- -p 0x3 -P --config="(0,0,xx),(1,0,xx)" --empty-poll -l 14 -m 9 -h 1 Please Reference l3fwd-power document for all parameter except empty-poll

[dpdk-dev] [PATCH 3/3] crypto/mvsam: get number of CIOs dynamically

2018-09-04 Thread Tomasz Duszynski
From: Dmitri Epshtein MUSDK 18.09 introduced API for getting CIOs number dynamically. Use that instead of predefined constant. Signed-off-by: Dmitri Epshtein Reviewed-by: Natalie Samsonov Tested-by: Natalie Samsonov --- drivers/crypto/mvsam/rte_mrvl_pmd.c | 2 +- 1 file changed, 1 insertion(

[dpdk-dev] [PATCH 1/3] doc: update mvsam documentation

2018-09-04 Thread Tomasz Duszynski
From: Dmitri Epshtein Update mvsam documentation. Signed-off-by: Dmitri Epshtein Signed-off-by: Tomasz Duszynski Signed-off-by: Natalie Samsonov --- doc/guides/cryptodevs/features/mvsam.ini | 10 +++ doc/guides/cryptodevs/mvsam.rst | 147 ++- 2 files cha

[dpdk-dev] [PATCH 0/3] crypto/mvsam: align with MUSDK 18.09

2018-09-04 Thread Tomasz Duszynski
This patch series aligns MVSAM PMD with MUSDK 18.09. Dmitri Epshtein (2): doc: update mvsam documentation crypto/mvsam: get number of CIOs dynamically Tomasz Duszynski (1): crypto/mvsam: update features list doc/guides/cryptodevs/features/mvsam.ini | 12 +++ doc/guides/cryptodevs/mvsam.r

[dpdk-dev] [PATCH 2/3] crypto/mvsam: update features list

2018-09-04 Thread Tomasz Duszynski
Add following features to the device's features list and update documentation accordingly: * OOP SGL in LB out * OOP LB in LB out Signed-off-by: Tomasz Duszynski --- doc/guides/cryptodevs/features/mvsam.ini | 2 ++ drivers/crypto/mvsam/rte_mrvl_pmd.c | 4 +++- 2 files changed, 5 insertions(

Re: [dpdk-dev] [PATCH] test/bpf: use hton instead of __builtin_bswap

2018-09-04 Thread Ananyev, Konstantin
Hi, > > Convert host machine endianness to networking endianness for > comparison of incoming packets with BPF filter > > > Signed-off-by: Malvika Gupta > Reviewed-by: Gavin Hu > Reviewed-by: Brian Brooks > Suggested-by: Brian Brooks > --- > test/bpf/t1.c | 7 --- > test/bpf/t3.c | 3 +

[dpdk-dev] [PATCH v2 12/12] net/mvpp2: add Tx S/G support

2018-09-04 Thread Tomasz Duszynski
From: Zyta Szpak The patch introduces scatter/gather support on transmit path. A separate Tx callback is added and set if the application requests multisegment Tx offload. Multiple descriptors are sent per one packet. Signed-off-by: Zyta Szpak Signed-off-by: Natalie Samsonov Reviewed-by: Yelen

[dpdk-dev] [PATCH v2 10/12] net/mvpp2: align documentation with MUSDK 18.09

2018-09-04 Thread Tomasz Duszynski
From: Natalie Samsonov Update documentation to align with MUSDK 18.09. Signed-off-by: Natalie Samsonov --- doc/guides/nics/mvpp2.rst | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/doc/guides/nics/mvpp2.rst b/doc/guides/nics/mvpp2.rst index a452

[dpdk-dev] [PATCH v2 11/12] net/mvpp2: document MTR and TM usage

2018-09-04 Thread Tomasz Duszynski
From: Natalie Samsonov Document MTR (metering) and TM (traffic management) usage plus do some small updates here and there. Signed-off-by: Natalie Samsonov --- doc/guides/nics/img/mvpp2_tm.png | Bin 0 -> 5355 bytes doc/guides/nics/mvpp2.rst| 386 +--

[dpdk-dev] [PATCH v2 09/12] net/mvpp2: align with MUSDK 18.09

2018-09-04 Thread Tomasz Duszynski
This patch introduces necessary changes required by MUSDK 18.09 library. * As of MUSDK 18.09, pp2_cookie_t is no longer available. Now RX descriptor cookie is defined as plain u64 so existing cast is no longer valid. * MUSDK 18.09 increased number of available bpools (buffer hw pools) by in

[dpdk-dev] [PATCH v2 08/12] net/mvpp2: update MTU and MRU related calculations

2018-09-04 Thread Tomasz Duszynski
From: Natalie Samsonov This commit updates MTU and MRU related calculations. Signed-off-by: Natalie Samsonov Reviewed-by: Yelena Krivosheev Reviewed-by: Dmitri Epshtein --- drivers/net/mvpp2/mrvl_ethdev.c | 70 +++-- drivers/net/mvpp2/mrvl_ethdev.h | 7 ++

[dpdk-dev] [PATCH v2 07/12] net/mvpp2: detach tx_qos from rx cls/qos config

2018-09-04 Thread Tomasz Duszynski
From: Yuval Caduri Functional change: Open receive cls/qos related features, only if the config file contains an rx_related configuration entry. This allows to configure tx_related entries, w/o unintentionally opening rx cls/qos. Code: 'use_global_defaults' is by default set to '1'. Only if an r

[dpdk-dev] [PATCH v2 06/12] net/mvpp2: add traffic manager support

2018-09-04 Thread Tomasz Duszynski
Add traffic manager support. Signed-off-by: Tomasz Duszynski Signed-off-by: Natalie Samsonov Reviewed-by: Liron Himi --- drivers/net/mvpp2/Makefile |1 + drivers/net/mvpp2/meson.build |3 +- drivers/net/mvpp2/mrvl_ethdev.c | 26 + drivers/net/mvpp2/mrvl_ethdev.h | 31 ++ dri

[dpdk-dev] [PATCH v2 05/12] net/mvpp2: add init and deinit to flow

2018-09-04 Thread Tomasz Duszynski
Add init and deinit functionality to flow implementation. Init puts structures used by flow in a sane sate. Deinit deallocates all resources used by flow. Signed-off-by: Tomasz Duszynski Signed-off-by: Natalie Samsonov Reviewed-by: Liron Himi Reviewed-by: Shlomi Gridish --- drivers/net/mvpp2

[dpdk-dev] [PATCH v2 01/12] net/mvpp2: initialize ppio only once

2018-09-04 Thread Tomasz Duszynski
From: Natalie Samsonov This changes stop/start/configure behavior due to issue in MUSDK library itself. From now on, ppio can be reconfigured only after interface is closed. Signed-off-by: Natalie Samsonov Reviewed-by: Yuval Caduri --- drivers/net/mvpp2/mrvl_ethdev.c | 53 +++

[dpdk-dev] [PATCH v2 02/12] net/mvpp2: move common code

2018-09-04 Thread Tomasz Duszynski
Cleanup sources by moving common code to the pmd header file. Signed-off-by: Tomasz Duszynski Signed-off-by: Natalie Samsonov Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 9 - drivers/net/mvpp2/mrvl_ethdev.h | 11 +++ drivers/net/mvpp2/mrvl_flow.c | 5 -

[dpdk-dev] [PATCH v2 03/12] net/mvpp2: add metering support

2018-09-04 Thread Tomasz Duszynski
Add support for configuring plcr via DPDK generic metering API. Signed-off-by: Tomasz Duszynski Signed-off-by: Natalie Samsonov Reviewed-by: Liron Himi --- drivers/net/mvpp2/Makefile | 1 + drivers/net/mvpp2/meson.build | 3 +- drivers/net/mvpp2/mrvl_ethdev.c | 24 ++ drivers/net/m

[dpdk-dev] [PATCH v2 04/12] net/mvpp2: change default policer configuration

2018-09-04 Thread Tomasz Duszynski
Change QoS configuration file syntax for port's default policer setup. Since default policer configuration is performed before any other policer configuration we can pick a default id. This simplifies default policer configuration since user no longer has to choose ids from range [0, PP2_CLS_PLCR

[dpdk-dev] [PATCH v2 00/12] net/mvpp2: add new features

2018-09-04 Thread Tomasz Duszynski
This patch series introduces fixes and adds support for traffic metering, traffic manager and Tx S/G. Additionally it aligns with for MUSDK 18.09. Changes since v2: * Align with MUSDK 18.09 library * Add support for Tx Gather. * Add documentation related to MTR and TM. * Align documentation with M

Re: [dpdk-dev] Tx vlan offload problem with igb and DPDK v17.11

2018-09-04 Thread Victor Huertas
Forget about it, I found a bug in my software. Once solved, no problem with PKT_TX_VLAN_PKT at all. Regards, El lun., 3 sept. 2018 a las 19:32, Victor Huertas () escribió: > Hi all, > > I have realized that the PKT_TX_VLAN_PKT flag for Tx Vlan Offload doesn't > work in my application. > > Accor

Re: [dpdk-dev] [PATCH] net/bonding: use evenly distributed default RSS RETA

2018-09-04 Thread Chas Williams
On Wed, Aug 29, 2018 at 3:48 AM Andrew Rybchenko wrote: > From: Igor Romanov > > Default Redirection Table that is set in bonding driver is distributed > evenly over all Rx queues only within every RETA group (the first RETA > entries in every group are always start with zero). But in the most >

Re: [dpdk-dev] [PATCH] net/bonding: don't ignore RSS key on device configuration

2018-09-04 Thread Chas Williams
On Wed, Aug 29, 2018 at 3:51 AM Andrew Rybchenko wrote: > From: Igor Romanov > > Bonding driver ignores the value of RSS key (that is set in the port RSS > configuration) in bond_ethdev_configure(). So the only way to set > non-default RSS key is by using rss_hash_update(). This is not an > expe

[dpdk-dev] [PATCH 15/16] malloc: allow detaching from external memory

2018-09-04 Thread Anatoly Burakov
Add API to detach from existing chunk of external memory in a process. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 27 ++ lib/librte_eal/common/rte_malloc.c | 27 ++ lib/librte_eal/rte_eal_version.map |

[dpdk-dev] [PATCH 04/16] mem: do not check for invalid socket ID

2018-09-04 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_memzone.c | 8 +--- lib/libr

[dpdk-dev] [PATCH 08/16] malloc: add name to malloc heaps

2018-09-04 Thread Anatoly Burakov
We will need to refer to external heaps in some way. While we use heap ID's internally, for external API use it has to be something more user-friendly. So, we will be using a string to uniquely identify a heap. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc_heap.h |

[dpdk-dev] [PATCH 05/16] flow_classify: do not check for invalid socket ID

2018-09-04 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov --- lib/librte_flow_classify/rte_flow_classify.c | 3 +-- 1 file chan

[dpdk-dev] [PATCH 03/16] malloc: index heaps using heap ID rather than NUMA node

2018-09-04 Thread Anatoly Burakov
Switch over all parts of EAL to use heap ID instead of NUMA node ID to identify heaps. Heap ID for DPDK-internal heaps is NUMA node's index within the detected NUMA node list. Heap ID for external heaps will be order of their creation. Signed-off-by: Anatoly Burakov --- config/common_base

[dpdk-dev] [PATCH 13/16] malloc: allow removing memory from named heaps

2018-09-04 Thread Anatoly Burakov
Add an API to remove memory from specified heaps. This will first check if all elements within the region are free, and that the region is the original region that was added to the heap (by comparing its length to length of memory addressed by the underlying memseg list). Signed-off-by: Anatoly Bu

[dpdk-dev] [PATCH 09/16] malloc: add function to query socket ID of named heap

2018-09-04 Thread Anatoly Burakov
When we will be creating external heaps, they will have their own "fake" socket ID, so add a function that will map the heap name to its socket ID. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 14 lib/librte_eal/common/rte_malloc.c | 37 +++

[dpdk-dev] [PATCH 12/16] malloc: allow adding memory to named heaps

2018-09-04 Thread Anatoly Burakov
Add an API to add externally allocated memory to malloc heap. The memory will be stored in memseg lists like regular DPDK memory. Multiple segments are allowed within a heap. If IOVA table is not provided, IOVA addresses are filled in with RTE_BAD_IOVA. Signed-off-by: Anatoly Burakov --- lib/lib

[dpdk-dev] [PATCH 14/16] malloc: allow attaching to external memory chunks

2018-09-04 Thread Anatoly Burakov
In order to use external memory in multiple processes, we need to attach to primary process's memseg lists, so add a new API to do that. It is the responsibility of the user to ensure that memory is accessible and that it has been previously added to the malloc heap by another process. Signed-off-

[dpdk-dev] [PATCH 07/16] sched: do not check for invalid socket ID

2018-09-04 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov --- lib/librte_sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(

[dpdk-dev] [PATCH 11/16] malloc: allow destroying heaps

2018-09-04 Thread Anatoly Burakov
Add an API to destroy specified heap. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 23 + lib/librte_eal/common/malloc_heap.c| 22 lib/librte_eal/common/malloc_heap.h| 3 ++ lib/librte_eal/common/rte_malloc.c | 58 ++

[dpdk-dev] [PATCH 16/16] test: add unit tests for external memory support

2018-09-04 Thread Anatoly Burakov
Add simple unit tests to test external memory support. The tests are pretty basic and mostly consist of checking if invalid API calls are handled correctly, plus a simple allocation/deallocation test for malloc and memzone. Signed-off-by: Anatoly Burakov --- test/test/Makefile| 1 +

[dpdk-dev] [PATCH 10/16] malloc: allow creating malloc heaps

2018-09-04 Thread Anatoly Burakov
Add API to allow creating new malloc heaps. They will be created with socket ID's going above RTE_MAX_NUMA_NODES, to avoid clashing with internal heaps. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 19 lib/librte_eal/common/malloc_heap.c| 30 ++

[dpdk-dev] [PATCH 01/16] mem: add length to memseg list

2018-09-04 Thread Anatoly Burakov
Previously, to calculate length of memory area covered by a memseg list, we would've needed to multiply page size by length of fbarray backing that memseg list. This is not obvious and unnecessarily low level, so store length in the memseg list itself. Signed-off-by: Anatoly Burakov --- drivers/

[dpdk-dev] [PATCH 06/16] pipeline: do not check for invalid socket ID

2018-09-04 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov --- lib/librte_pipeline/rte_pipeline.c | 3 +-- 1 file changed, 1 ins

[dpdk-dev] [PATCH 02/16] mem: allow memseg lists to be marked as external

2018-09-04 Thread Anatoly Burakov
When we allocate and use DPDK memory, we need to be able to differentiate between DPDK hugepage segments and segments that were made part of DPDK but are externally allocated. Add such a property to memseg lists. All current calls for memseg walk functions were adjusted to ignore external segments

[dpdk-dev] [PATCH 00/16] Support externally allocated memory in DPDK

2018-09-04 Thread Anatoly Burakov
This is a proposal to enable using externally allocated memory in DPDK. In a nutshell, here is what is being done here: - Index internal malloc heaps by NUMA node index, rather than NUMA node itself (external heaps will have ID's in order of creation) - Add identifier string to malloc heap, to

[dpdk-dev] [PATCH] app/testpmd: add check for rx offload security flag

2018-09-04 Thread Kevin Laatz
Add a check for the DEV_RX_OFFLOAD_SECURITY flag to the port_offload_cap_display(). Signed-off-by: Kevin Laatz --- app/test-pmd/config.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 14ccd68..4c60c7e 100644 --- a/app/test-pmd/con

[dpdk-dev] [PATCH v3] net/i40e: add interface to choose latest vector path

2018-09-04 Thread Xiaoyun Li
Right now, vector path is limited to only use on later platform. This patch adds a devarg enable-latest-vec to allow the users to use the latest vector path that the platform supported. Namely, using AVX2 vector path on broadwell is possible. Signed-off-by: Xiaoyun Li --- v3: * Polish the doc an

Re: [dpdk-dev] [PATCH] ethdev: make default behavior CRC strip on Rx

2018-09-04 Thread Shahaf Shuler
Hi Ferruh, Monday, September 3, 2018 5:45 PM, Ferruh Yigit: > Subject: [PATCH] ethdev: make default behavior CRC strip on Rx > > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. > > PMDs that support keeping CRC s

Re: [dpdk-dev] Tx vlan offload problem with igb and DPDK v17.11

2018-09-04 Thread Victor Huertas
Hi all, I have solved the issue of the PKT_TX_VLAN_PKT using the SW version rte_vlan_insert function. However I would like to tell you what I have seen during my tests. I hope it can shed a light on the issue you the developers should correct. When I use m->old_flags |= PKT_TX_VLAN_PKT my Wires

Re: [dpdk-dev] [PATCH] doc: Clarify IOMMU usage with "uio-pci" kernel module

2018-09-04 Thread Tone Zhang (Arm Technology China)
-Original Message- From: Luca Boccassi Sent: Tuesday, September 4, 2018 6:15 PM To: Bruce Richardson ; Tone Zhang (Arm Technology China) Cc: dev@dpdk.org; nd Subject: Re: [dpdk-dev] [PATCH] doc: Clarify IOMMU usage with "uio-pci" kernel module On Tue, 2018-09-04 at 11:06 +0100, Bru

Re: [dpdk-dev] [PATCH] doc: Clarify IOMMU usage with "uio-pci" kernel module

2018-09-04 Thread Luca Boccassi
On Tue, 2018-09-04 at 11:06 +0100, Bruce Richardson wrote: > On Tue, Sep 04, 2018 at 04:59:07PM +0800, tone.zhang wrote: > > When binding the devices used by DPDK to the "uio-pci" kernel > > module, > > the IOMMU should be disabled in order not to break the IO > > transmission > > because of the vi

Re: [dpdk-dev] [PATCH] doc: Clarify IOMMU usage with "uio-pci" kernel module

2018-09-04 Thread Bruce Richardson
On Tue, Sep 04, 2018 at 04:59:07PM +0800, tone.zhang wrote: > When binding the devices used by DPDK to the "uio-pci" kernel module, > the IOMMU should be disabled in order not to break the IO transmission > because of the virtual / physical address mapping. > > The patch clarifies the IOMMU config

Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx

2018-09-04 Thread Shahaf Shuler
Tuesday, September 4, 2018 1:13 PM, Ferruh Yigit: > Subject: [PATCH v2] ethdev: make default behavior CRC strip on Rx > > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. > > PMDs that support keeping CRC should adv

Re: [dpdk-dev] [PATCH] net/ixgbe: Strip SR-IOV transparent VLANs in VF

2018-09-04 Thread Robert Shearman
Hi Qi, On 04/09/2018 03:16, Zhang, Qi Z wrote: -Original Message- From: Robert Shearman [mailto:robertshear...@gmail.com] Sent: Monday, September 3, 2018 9:14 PM To: Zhang, Qi Z ; dev@dpdk.org Cc: Lu, Wenzhuo ; Ananyev, Konstantin ; Robert Shearman Subject: Re: [dpdk-dev] [PATCH] net/ix

  1   2   >