Tuesday, September 4, 2018 1:13 PM, Ferruh Yigit: > Subject: [PATCH v2] ethdev: make default behavior CRC strip on Rx > > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. > > PMDs that support keeping CRC should advertise > DEV_RX_OFFLOAD_KEEP_CRC > Rx offload capability. > > Applications that require keeping CRC should check PMD capability first > and if it is supported can enable this feature by setting > DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in rte_eth_dev_configure() > > Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com> > Acked-by: Tomasz Duszynski <t...@semihalf.com> > --- > v2: > * fix flag check > * add KEEP_CRC flag into "show port cap #" > > Note "show port cap #" and > "show port # [r/t]x_offload capabilities/configuration" > does same thing, in long term I suggest removing "show port cap" one
Acked-by: Shahaf Shuler <shah...@mellanox.com>
