[dpdk-dev] [PATCH] net/mlx5: handle expected errno properly

2018-08-22 Thread Xiaoyu Min
rte_errno is a per thread variable and is widely used as an error indicator, which means a function could affect other functions' results by setting rte_errno carelessly During rxq setup, an EINVAL rte_errno is expected since the queues are not created yet So rte_errno is cleared when it is EINVAL

Re: [dpdk-dev] [PATCH] bus/fslmc: fix shared build

2018-08-22 Thread Shreyansh Jain
On Tuesday 21 August 2018 04:55 PM, Pablo de Lara wrote: When building DPDK as shared library, disabling optimizations, the following compilation issue appears: portal/dpaa2_hw_dpio.o: In function `dpaa2_mem_ptov': drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:289: undefined reference to `rte_dpaa2_m

[dpdk-dev] [PATCH] net/virtio-user: fix memory hotplug support

2018-08-22 Thread Tiwei Bie
Deadlock can occur when allocating memory if a vhost-kernel based virtio-user device is in use. Besides, it's possible to have much more than 64 non-contiguous hugepage backed memory regions due to the memory hotplug, which may cause problems when handling VHOST_SET_MEM_TABLE request. A better solu

Re: [dpdk-dev] [RFC] ethdev: add generic MAC address rewrite actions

2018-08-22 Thread Jack MIN
On Tue, Aug 21, 2018 at 01:44:32PM +0530, Rahul Lakkireddy wrote: > On Tuesday, August 08/14/18, 2018 at 14:45:45 +0530, Jack MIN wrote: > > On Mon, Aug 13, 2018 at 03:38:18PM +0530, Rahul Lakkireddy wrote: > > > On Tuesday, August 08/07/18, 2018 at 14:20:10 +, Jack Min wrote: > > > > There is

[dpdk-dev] Missing patches for 17.11.4

2018-08-22 Thread Yongseok Koh
Hi, I found that some emails from stable mailing list haven't arrived at my mailbox. I'm still trying to figure out why but meanwhile I searched the archive and have applied missing patches manually like listed below. Please make sure your patch has been applied if you have sent one for 17.11.4.

Re: [dpdk-dev] [PATCH v2 4/4] eventdev: add auto test for eth Tx adapter

2018-08-22 Thread Rao, Nikhil
> -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Wednesday, August 22, 2018 9:53 PM > To: Rao, Nikhil ; jerin.ja...@caviumnetworks.com; > olivier.m...@6wind.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 4/4] eventdev: add auto test for eth Tx a

Re: [dpdk-dev] 17.11.4 patches review and test

2018-08-22 Thread Yongseok Koh
> On Aug 22, 2018, at 5:19 PM, Yongseok Koh wrote: > > On Tue, Aug 21, 2018 at 12:07:49PM +0200, Alejandro Lucero wrote: >> Hi Yonngseok, >> >> There is a patchset aimed at 17.11.x: >> >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatches.dpdk.org%2Fcover%2F42741%2F&da

Re: [dpdk-dev] 17.11.4 patches review and test

2018-08-22 Thread Yongseok Koh
On Tue, Aug 21, 2018 at 12:07:49PM +0200, Alejandro Lucero wrote: > Hi Yonngseok, > > There is a patchset aimed at 17.11.x: > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatches.dpdk.org%2Fcover%2F42741%2F&data=02%7C01%7Cyskoh%40mellanox.com%7C1d7083071364473c772208d6074d

Re: [dpdk-dev] 17.11.4 patches review and test

2018-08-22 Thread Yongseok Koh
> On Aug 21, 2018, at 12:38 AM, Marco Varlese wrote: > > On Mon, 2018-08-20 at 22:35 +, Mody, Rasesh wrote: >>> From: dev On Behalf Of Marco Varlese >>> Sent: Monday, August 20, 2018 2:21 AM >>> >>> Hi, >>> >>> The code in 17.11.4-rc1 does not compile for me. >> >> This needs to be fixe

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-22 Thread Eric Kinzie
On Wed Aug 22 11:42:37 + 2018, Matan Azrad wrote: > Hi Luca > > From: Luca Boccassi > > On Wed, 2018-08-22 at 07:09 +, Matan Azrad wrote: > > > Hi Chas > > > > > > From: Chas Williams > > > > On Tue, Aug 21, 2018 at 11:43 AM Matan Azrad > > > .com> wrote: > > > > H

Re: [dpdk-dev] [PATCH v2] ethdev: change vtune profiling approach

2018-08-22 Thread Ferruh Yigit
On 7/24/2018 2:17 PM, Wiles, Keith wrote: > > >> On Jul 19, 2018, at 7:21 AM, ilia.kura...@intel.com wrote: >> >> From: Ilia Kurakin >> >> The patch changes rx_burst profiling approach: >> 1. VTune's instrumentation is removed >> 2. empty hook callback for profiling is added >> This wa

Re: [dpdk-dev] [PATCH v2] ethdev: fix device info getting

2018-08-22 Thread Ferruh Yigit
On 8/14/2018 1:57 AM, Lu, Wenzhuo wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Rybchenko [mailto:arybche...@solarflare.com] >> Sent: Monday, August 13, 2018 4:39 PM >> To: Lu, Wenzhuo ; Thomas Monjalon >> ; Yigit, Ferruh >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH

[dpdk-dev] [RFC v1] net/mlx5: support e-switch flow count action

2018-08-22 Thread Moti Haimovsky
Today, it is possible to offload an interface flow rules to the hardware using DPDK flow commands. With mlx5 it is also possible to offload a limited set of flow rules to the mlxsw (or e-switch) using the same DPDK flow commands. A 'transfer' attribute was added to the flow rule creation command in

Re: [dpdk-dev] [PATCH v2 4/4] eventdev: add auto test for eth Tx adapter

2018-08-22 Thread Pavan Nikhilesh
On Wed, Aug 22, 2018 at 09:43:02PM +0530, Rao, Nikhil wrote: > > > + ev_qid = qcnt; > > > + qconf.nb_atomic_flows = dev_info.max_event_queue_flows; > > > + qconf.nb_atomic_order_sequences = 32; > > > + qconf.schedule_type = RTE_SCHED_TYPE_ATOMIC; > > > + qconf.priority

Re: [dpdk-dev] [PATCH v2 4/4] eventdev: add auto test for eth Tx adapter

2018-08-22 Thread Rao, Nikhil
On 8/17/2018 5:25 PM, Pavan Nikhilesh wrote: Hi Nikhil, Few comments inline. Nit: Please use --in-reply-to while sending next versions. (https://core.dpdk.org/contribute/) Thanks, Pavan On Fri, Aug 17, 2018 at 09:50:52AM +0530, Nikhil Rao wrote: This patch adds tests for the eth Tx ad

Re: [dpdk-dev] [dpdk-stable] [PATCH 0/2] support MAC changes when no live changes allowed

2018-08-22 Thread Ferruh Yigit
On 7/18/2018 9:58 AM, Ferruh Yigit wrote: > On 7/9/2018 6:14 PM, Alejandro Lucero wrote: >> This is a patched to fix a functionality coming with the first public >> release: changing/setting MAC address. >> >> The original patch assumes all NICs can safely change or set the MAC >> in any case. Howe

[dpdk-dev] [RFC] net/mlx5: support e-switch TCP-flags flow filter

2018-08-22 Thread Moti Haimovsky
Today, it is possible to offload an interface flow rules to the hardware using DPDK flow commands. With mlx5 it is also possible to offload a limited set of flow rules to the mlxsw (or e-switch) using the same DPDK flow commands. A 'transfer' attribute was added to the flow rule creation command in

[dpdk-dev] [RFC] net/mlx5: support eswitch flow count action

2018-08-22 Thread Moti Haimovsky
Today, it is possible to offload an interface flow rules to the hardware using DPDK flow commands. With mlx5 it is also possible to offload a limited set of flow rules to the mlxsw (or e-switch) using the same DPDK flow commands. A 'transfer' attribute was added to the flow rule creation command in

Re: [dpdk-dev] [PATCH] bpf: fix a typo

2018-08-22 Thread Ananyev, Konstantin
> -Original Message- > From: Rami Rosen [mailto:ramir...@gmail.com] > Sent: Wednesday, August 22, 2018 3:46 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Rami Rosen > > Subject: [PATCH] bpf: fix a typo > > This trivial patch fixes a typo in rte_bpf_ethdev.h, > > Signed-off-by: Ra

Re: [dpdk-dev] 18.08 build error on ppc64el - bool as vector type

2018-08-22 Thread Christian Ehrhardt
Just FYI the simple change hits similar issues later on. The (not really) proposed patch would have to be extended to be as following. We really need a better solution (or somebody has to convince me that my change is better than a band aid). Description: Fix ppc64le build error between altivec

[dpdk-dev] [PATCH] build: enable Arm NEON flags when __aarch64__ is defined

2018-08-22 Thread Honnappa Nagarahalli
GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not optional for ArmV8. Hence NEON related code can be enabled when __aarch64__ is defined. Bugzilla ID: 82 Signed-off-by: Honnappa Nagarahalli Reviewed-by: Phil Yang Reviewed-by: Gavin Hu Reported-by: Raslan Darawsheh Reported-by: Tho

[dpdk-dev] [PATCH] bpf: fix a typo

2018-08-22 Thread Rami Rosen
This trivial patch fixes a typo in rte_bpf_ethdev.h, Signed-off-by: Rami Rosen --- lib/librte_bpf/rte_bpf_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_bpf/rte_bpf_ethdev.h b/lib/librte_bpf/rte_bpf_ethdev.h index 31731e7a9..11d09cdc2 100644 --- a/lib/lib

[dpdk-dev] [PATCH 1/1] remove unnecessray fw declarations

2018-08-22 Thread Rami Rosen
Signed-off-by: Rami Rosen --- app/test-pmd/testpmd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index ee48db2a3..8a31722db 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -435,9 +435,6 @@ static int eth_event_callback(

[dpdk-dev] [PATCH] app/testpmd: fix duplicate exit

2018-08-22 Thread Brian Archbold
In interactive mode, when the "quit" command is issued, pmd_test_exit() is being called twice, once through the "quit" command and the other after termination of prompt. Remove duplicated exit routine by removing call from "quit" command. Steps to reproduce: - Run testpmd in interactive mode. - t

Re: [dpdk-dev] [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter

2018-08-22 Thread Rao, Nikhil
On 8/21/2018 2:41 PM, Jerin Jacob wrote: -Original Message- Date: Tue, 21 Aug 2018 14:22:15 +0530 From: "Rao, Nikhil" To: Jerin Jacob CC: olivier.m...@6wind.com, dev@dpdk.org, nikhil@intel.com Subject: Re: [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter

Re: [dpdk-dev] [RFC] ethdev: support metadata as flow rule criteria

2018-08-22 Thread Andrew Rybchenko
On 13.08.2018 10:46, Dekel Peled wrote: Current implementation of rte_flow allows match pattern of flow rule, based on packet data or header fields. This limits the application use of match patterns. For example, consider a vswitch application which controls a set of VMs, connected with virtio,

Re: [dpdk-dev] [RFC] ethdev: support metadata as flow rule criteria

2018-08-22 Thread Ananyev, Konstantin
Hi Dekel, > > > > > > > > > > > -Original Message- > > > > From: Dekel Peled [mailto:dek...@mellanox.com] > > > > Sent: Monday, August 13, 2018 10:47 AM > > > > To: dev@dpdk.org > > > > Cc: Ori Kam ; Shahaf Shuler > > > > > > > > Subject: [RFC] ethdev: support metadata as flow rule criter

[dpdk-dev] RTE-FLOW: PF vs PHY_PORT

2018-08-22 Thread Vivek Sharma
Hi Devs, I am trying to enable RTE-FLOW support on one of our platforms & having hard time in figuring out PF vs PHY_PORT differences and DPDK rationale for introducing these two distinct identities. Rte-Flow distinguishes between RTE_FLOW_ITEM_TYPE_PF & RTE_FLOW_ITEM_TYPE_PHY_PORT and

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-22 Thread Matan Azrad
Hi Luca From: Luca Boccassi > On Wed, 2018-08-22 at 07:09 +, Matan Azrad wrote: > > Hi Chas > > > > From: Chas Williams > > > On Tue, Aug 21, 2018 at 11:43 AM Matan Azrad > > .com> wrote: > > > Hi Chas > > > > > > From: Chas Williams > > > > On Tue, Aug 21, 2018 at 6:5

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-22 Thread Luca Boccassi
On Wed, 2018-08-22 at 07:09 +, Matan Azrad wrote: > Hi Chas > > From: Chas Williams > > On Tue, Aug 21, 2018 at 11:43 AM Matan Azrad > .com> wrote: > > Hi Chas > > > > From: Chas Williams > > > On Tue, Aug 21, 2018 at 6:56 AM Matan Azrad > > x.

[dpdk-dev] [RFC] net/mlx5: add DV flow support

2018-08-22 Thread Ori Kam
Currently the flow steering in MLX5 is done using 2 external APIs (drivers) the verbs API to control the NIC flows and TC API to control the ESWITCH flows. Also in the current implementation some functions are called number of times and each time with different job to do. In order to support advan

Re: [dpdk-dev] [PATCH v2 2/2] librte_ip_frag: add mbuf counter

2018-08-22 Thread Alex Kiselev
Hi Konstantin. Could we please make a final decision about counting mbufs, since It still feels to me like an unfinished business? Below are my final argumens. if they are not sound to you, just nack ;) > Hi Konstantin. >> Hi Alex, >> Sorry for delay in reply. >>> >> There might be situations

Re: [dpdk-dev] [RFC] ethdev: support metadata as flow rule criteria

2018-08-22 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Tuesday, August 21, 2018 4:08 PM > To: Dekel Peled ; dev@dpdk.org; Adrien Mazarguil > ; olivier.m...@6wind.com > Cc: Ori Kam ; Shahaf Shuler > > Subject: RE: [RFC] ethdev: support m

[dpdk-dev] [PATCH] vmxnet3: stats_reset implementation

2018-08-22 Thread yogev ch
Signed-off-by: yogev ch --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 78 ++-- drivers/net/vmxnet3/vmxnet3_ethdev.h | 3 ++ 2 files changed, 78 insertions(+), 3 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c in

[dpdk-dev] 18.05.1 patches review and test

2018-08-22 Thread Christian Ehrhardt
Hi all, Here is a list of patches targeted for stable release 18.05.1. Please help review and test. The planned date for the final release is August, 29th. Before that, please shout if anyone has objections with these patches being applied. Also for the companies committed to running regression t

Re: [dpdk-dev] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-22 Thread Matan Azrad
Hi Chas From: Chas Williams >On Tue, Aug 21, 2018 at 11:43 AM Matan Azrad wrote: >Hi Chas > >From: Chas Williams >> On Tue, Aug 21, 2018 at 6:56 AM Matan Azrad >> wrote: >> Hi >> >> From: Chas Williams >> > This will need to be implemented f