> -----Original Message----- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Wednesday, August 22, 2018 9:53 PM > To: Rao, Nikhil <nikhil....@intel.com>; jerin.ja...@caviumnetworks.com; > olivier.m...@6wind.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 4/4] eventdev: add auto test for eth Tx adapter > > On Wed, Aug 22, 2018 at 09:43:02PM +0530, Rao, Nikhil wrote: > > > > + ev_qid = qcnt; > > > > + qconf.nb_atomic_flows = dev_info.max_event_queue_flows; > > > > + qconf.nb_atomic_order_sequences = 32; > > > > + qconf.schedule_type = RTE_SCHED_TYPE_ATOMIC; > > > > + qconf.priority = RTE_EVENT_DEV_PRIORITY_HIGHEST; > > > > + qconf.event_queue_cfg = RTE_EVENT_QUEUE_CFG_SINGLE_LINK; > > > > + err = rte_event_queue_setup(TEST_DEV_ID, ev_qid, &qconf); > > > > + TEST_ASSERT_SUCCESS(err, "Failed to setup queue %u", > > > > + ev_qid); > > > > > > On reconfigure, setup all the ports and queues so that the newly > > > configured values are seen by them. > > > > Is that required since dev_conf matches dev_info except for the number > > of queues ? > > Some drivers require this as without port setup newly configured queues > might not be visible. > OK.
> > > > > > > > > + > > > > + err = rte_event_port_link(TEST_DEV_ID, ev_port, &ev_qid, NULL, > 1); > > > > + TEST_ASSERT(err == 1, "Failed to link queue port %u", > > > > + ev_port); > > > > + > > > > + err = rte_event_eth_tx_adapter_start(TEST_INST_ID); > > > > + TEST_ASSERT(err == 0, "Expected 0 got %d", err); > > > > + > > > > + err = rte_event_dev_service_id_get(0, &eid); > > > > + TEST_ASSERT(err == 0, "Expected 0 got %d", err); > > > > > > An event device might not be needing a service core, check the > > > capabilities before requesting service id above. > > > > > > > The internal_port capability is checked at the beginning of the > > function, if its not set, I think its Ok to assume that we need a > > service core ? > > That check is to see if TX adapter requires service core, the above one is > checking if eventdev requires serivce core. Got it, I was misreading the comment. Thanks, Nikhil
