On 7/24/2018 2:17 PM, Wiles, Keith wrote: > > >> On Jul 19, 2018, at 7:21 AM, ilia.kura...@intel.com wrote: >> >> From: Ilia Kurakin <ilia.kura...@intel.com> >> >> The patch changes rx_burst profiling approach: >> 1. VTune's instrumentation is removed >> 2. empty hook callback for profiling is added >> This way all VTune-specific logic moves to the VTune side. >> Hook is enabled only when CONFIG_RTE_ETHDEV_PROFILE_WITH_VTUNE option >> is turned on. VTune uses this hook to attach to the polling cycle. It >> is not possible to attach to the rx_burst directly, as it is inline. >> >> Signed-off-by: Ilia Kurakin <ilia.kura...@intel.com> >> >> --- >> >> -v2 change: >> fix coding style issue, re-merge >> >> config/common_base | 2 +- >> doc/guides/prog_guide/profile_app.rst | 34 ++--------- >> lib/librte_ethdev/ethdev_profile.c | 103 >> +++++----------------------------- >> lib/librte_ethdev/ethdev_profile.h | 6 +- >> lib/librte_ethdev/rte_ethdev.c | 4 +- >> 5 files changed, 25 insertions(+), 124 deletions(-) >> > > Looks good and a cleaner method. > > Acked-by: Keith Wiles <keith.wi...@intel.com>
Acked-by: Ferruh Yigit <ferruh.yi...@intel.com>
