Re: [dpdk-dev] [PATCH] maintainers: claim maintainership for ARM v7 and v8

2018-08-08 Thread Jerin Jacob
-Original Message- > Date: Thu, 9 Aug 2018 09:58:03 +0800 > From: Gavin Hu > To: dev@dpdk.org > CC: gavin...@arm.com, honnappa.nagaraha...@arm.com, song@arm.com, > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] maintainers: claim maintainership for ARM v7 > and v8 > X-Mailer: git-send

[dpdk-dev] [PATCH] maintainers: claim maintainership for ARM v7 and v8

2018-08-08 Thread Gavin Hu
Claim the maintainership as Jianbo Liu is not working on this any more. Aslo remove the co-maintainership for Marvel mvpp2 amd mrvl crypto driver and doc. Cc: sta...@dpdk.org Signed-off-by: Gavin Hu Reviewed-by: Song Zhu Reviewed-by: Honnappa Nagarahalli --- MAINTAINERS | 6 ++ 1 file cha

Re: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe

2018-08-08 Thread Zhao1, Wei
Hi, Ferruh What do you think of the patch implementation? > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, August 2, 2018 10:28 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Yigit, Ferruh ; sta...@dpdk.org; Zhao1, Wei > ; Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH] net/ixg

Re: [dpdk-dev] [RFC 1/4] ethdev: claim device reset as async

2018-08-08 Thread Zhang, Qi Z
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, August 8, 2018 11:13 PM > To: Zhang, Qi Z > Cc: tho...@monjalon.net; Ananyev, Konstantin > ; Doherty, Declan > ; Yigit, Ferruh ; > dev@dpdk.org; Shelton, Benjamin H ; > Vangati, Narende

Re: [dpdk-dev] [PATCH v2] doc: add tested platforms with Mellanox NICs

2018-08-08 Thread Thomas Monjalon
08/08/2018 17:32, Raslan Darawsheh: > Signed-off-by: Raslan Darawsheh > --- > changes in v2: > add Bluefield as one of the tested platforms for Mellanox. Applied, thanks

Re: [dpdk-dev] [PATCH] doc: add tested Intel platforms with Intel NICs

2018-08-08 Thread Thomas Monjalon
06/08/2018 12:56, Lijuan Tu: > Add tested Intel platforms with Intel NICs to the release note. > > Signed-off-by: Lijuan Tu Applied, thanks

Re: [dpdk-dev] [PATCH] doc: update mlx4 and mlx5 release notes

2018-08-08 Thread Thomas Monjalon
05/08/2018 13:13, Shahaf Shuler: > Signed-off-by: Shahaf Shuler Applied, thanks

Re: [dpdk-dev] [PATCH v3 2/2] eal: remove experimental tag from user mbuf pool ops func

2018-08-08 Thread Thomas Monjalon
07/08/2018 23:34, Olivier Matz: > From: Olivier Matz > > Remove experimental tag from rte_eal_mbuf_user_pool_ops(). > > Signed-off-by: Olivier Matz > Acked-by: Santosh Shukla > --- > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -261,6 +261,12 @@ DPDK

Re: [dpdk-dev] [PATCH] doc: announce deprecation of flow copy function

2018-08-08 Thread Thomas Monjalon
08/08/2018 05:11, Jerin Jacob: > -Original Message- > > Date: Fri, 3 Aug 2018 16:37:52 +0200 > > From: Adrien Mazarguil > > To: Neil Horman > > Cc: dev@dpdk.org, Thomas Monjalon , Ferruh Yigit > > , Gaetan Rivet > > Subject: [dpdk-dev] [PATCH] doc: announce deprecation of flow copy func

[dpdk-dev] [PATCH] doc: update deprecation notice about devargs

2018-08-08 Thread Thomas Monjalon
The devargs parsing function has changed in 18.08. The devargs rework should be completed in 18.11. Fixes: a23bc2c4e01b ("devargs: add non-variadic parsing function") Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/deprecation.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [dpdk-dev] [PATCH] doc: fix PDF build

2018-08-08 Thread Thomas Monjalon
> > The SVG images must be referenced without their extension, > > because it is converted to PNG for PDF. > > > > Fixes: 54c4cbb6ccf1 ("doc: add graphics to bbdev guide") > > > > Signed-off-by: Thomas Monjalon > > --- > > Acked-by: Amr Mokhtar > > Thanks! Applied

Re: [dpdk-dev] [PATCH] doc: fix PDF build

2018-08-08 Thread Mokhtar, Amr
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday 8 August 2018 22:25 > To: Mokhtar, Amr > Cc: De Lara Guarch, Pablo ; Kovacevic, > Marko ; Mcnamara, John > ; dev@dpdk.org > Subject: [PATCH] doc: fix PDF build > > The SVG images must be referenc

[dpdk-dev] [PATCH] doc: fix PDF build

2018-08-08 Thread Thomas Monjalon
The SVG images must be referenced without their extension, because it is converted to PNG for PDF. Fixes: 54c4cbb6ccf1 ("doc: add graphics to bbdev guide") Signed-off-by: Thomas Monjalon --- doc/guides/prog_guide/bbdev.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

[dpdk-dev] How to run tests

2018-08-08 Thread Vivian Kong
Hi everyone, Got a newbie question - I was able to build the source with `make install DESTDIR=~/dpdk-install T=x86_64-native-linuxapp-gcc`. How do I go about running the tests? I looked into the directory "x86_64-native-linuxapp-gcc" but I didn't see the "app/test" executable. Am I missing s

[dpdk-dev] [PATCH] net/mlx5: fix minimum size of Multi-Packet Rx queue

2018-08-08 Thread Yongseok Koh
The size of Rx queue is determined by dividing the number of descriptors by the number of strides. As device can't support single slot queue, if the number of descriptors is same as the number of strides, MPRQ shouldn't be enabled. Otherwise, this will cause HW fault. For example, if rxd is set to

[dpdk-dev] [PATCH] bus/pci: remove unneeded include

2018-08-08 Thread Rami Rosen
This trivial patch removes an uneeded include from drivers/bus/pci/linux/pci.c. Signed-off-by: Rami Rosen --- drivers/bus/pci/linux/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c index 004600f..04648ac 100644 --- a/drivers/bus/p

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/qede: fix ntuple filter configuration

2018-08-08 Thread Thomas Monjalon
08/08/2018 07:38, Rasesh Mody: > From: Shahed Shaikh > > PMD did not pass down the intended queue id while > configuring the ntuple filter. > > Fixes: 622075356e8f ("net/qede: support ntuple and flow director filter") > Cc: sta...@dpdk.org > > Signed-off-by: Shahed Shaikh Series applied, than

Re: [dpdk-dev] [PATCH] build: simplify logic for default library dependencies

2018-08-08 Thread Bruce Richardson
On Thu, Jul 26, 2018 at 03:55:56PM +0200, Thomas Monjalon wrote: > 19/07/2018 16:37, Bruce Richardson: > > EAL is a standard dependency of all libraries, except for those built > > before it. We can therefore simplify the logic by just checking if EAL > > has been processed, and make it a standard

[dpdk-dev] [PATCH v2] doc: add tested platforms with Mellanox NICs

2018-08-08 Thread Raslan Darawsheh
Signed-off-by: Raslan Darawsheh --- changes in v2: add Bluefield as one of the tested platforms for Mellanox. --- Signed-off-by: Raslan Darawsheh --- doc/guides/rel_notes/release_18_08.rst | 165 + 1 file changed, 165 insertions(+) diff --git a/doc/guides/rel

[dpdk-dev] [RFC 0/2] vhost: packed ring support completion

2018-08-08 Thread Maxime Coquelin
Initial series ading packed ring layout support to the vhost library was missing the save and restore of the wrap counter on vring base requests used for migration. First patch saves/restores the wrap counter value into/ from bit 31 of the vring state num field. Patch 2 advertise support for the

[dpdk-dev] [RFC 1/2] vhost: add packed ring support to vring base requests

2018-08-08 Thread Maxime Coquelin
For consistency with Vhost kernel backend, save the wrap counter value into bit 31 of num's vring state field. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/lib/librte_vhost/vhost_user.c b/li

[dpdk-dev] [RFC 2/2] vhost: advertize packed ring layout support

2018-08-08 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index 760a09c0d..9b0ebb754 100644 --- a/lib/librte_vhost/vhost.h +++ b/lib/librte_vhost/vhost.h @@ -275,7 +275,8 @@

Re: [dpdk-dev] [RFC 1/4] ethdev: claim device reset as async

2018-08-08 Thread Andrew Rybchenko
On 08.08.2018 18:13, Stephen Hemminger wrote: On Wed, 8 Aug 2018 15:00:42 +0800 Qi Zhang wrote: rte_eth_dev_reset should be implemented in an async way since it is possible be invoked in interrupt thread and sometimes to reset a device need to wait for some dependency, for example, a VF expec

Re: [dpdk-dev] [RFC 1/4] ethdev: claim device reset as async

2018-08-08 Thread Stephen Hemminger
On Wed, 8 Aug 2018 15:00:42 +0800 Qi Zhang wrote: > rte_eth_dev_reset should be implemented in an async way since it is > possible be invoked in interrupt thread and sometimes to reset a > device need to wait for some dependency, for example, a VF expects > for PF ready, or a NIC function as par

Re: [dpdk-dev] [PATCH] hash table: add a bucket iterator function

2018-08-08 Thread Michel Machado
On 08/03/2018 11:24 AM, Stephen Hemminger wrote: Often for time based cleanup it is better to have a second linked list that is ordered by time value. Then the cleanup code can start at the oldest stop when it reaches the last item that could expire. That does mean having some form of lock and

Re: [dpdk-dev] [PATCH v2] ring: fix c11 memory ordering issue

2018-08-08 Thread He, Jia
Hi Gavin > -Original Message- > From: Gavin Hu [mailto:gavin...@arm.com] > Sent: 2018年8月7日 11:20 > To: dev@dpdk.org > Cc: gavin...@arm.com; honnappa.nagaraha...@arm.com; > steve.cap...@arm.com; ola.liljed...@arm.com; > jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; He, Jia > ; sta.

Re: [dpdk-dev] [PATCH v3 2/2] eal: remove experimental tag from user mbuf pool ops func

2018-08-08 Thread Hemant
On 8/8/2018 3:04 AM, Olivier Matz wrote: From: Olivier Matz Remove experimental tag from rte_eal_mbuf_user_pool_ops(). Signed-off-by: Olivier Matz Acked-by: Santosh Shukla ---   Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v3 1/2] eal: remove deprecated function returning mbuf pool ops name

2018-08-08 Thread Hemant
On 8/8/2018 3:04 AM, Olivier Matz wrote: From: Olivier Matz rte_eal_mbuf_default_mempool_ops() is replaced by rte_mbuf_best_mempool_ops(). Signed-off-by: Olivier Matz Reviewed-by: Anatoly Burakov Acked-by: Santosh Shukla ---   Acked-by: Hemant Agrawal

Re: [dpdk-dev] [RFC 1/4] ethdev: claim device reset as async

2018-08-08 Thread Kevin Traynor
On 08/08/2018 08:00 AM, Qi Zhang wrote: > rte_eth_dev_reset should be implemented in an async way since it is > possible be invoked in interrupt thread and sometimes to reset a > device need to wait for some dependency, for example, a VF expects > for PF ready, or a NIC function as part of a SOC wa

Re: [dpdk-dev] eventdev: method for finding out unlink status

2018-08-08 Thread Elo, Matias (Nokia - FI/Espoo)
>>> >>> I think the end result we're hoping for is something like pseudo code >>> below, >>> (keep in mind that the event/sw has a service-core thread running it, >>> so no >>> application code there): >>> >>> int worker_poll = 1; >>> >>> worker() { >>

[dpdk-dev] Multi-thread mempool usage

2018-08-08 Thread Matteo Lanzuisi
Hi all, recently I began using "dpdk-17.11-11.el7.x86_64" rpm (RedHat rpm) on RedHat 7.5 kernel 3.10.0-862.6.3.el7.x86_64 as a porting of an application from RH6 to RH7. On RH6 I used dpdk-2.2.0. This application is made up by one or more threads (each one on a different logical core) readin

Re: [dpdk-dev] [PATCH] kni: Fix kni_autotest for new Rx/Tx offloads API

2018-08-08 Thread Ferruh Yigit
On 8/2/2018 6:49 AM, Thomas Monjalon wrote: > 01/08/2018 21:50, Dan Gora: >> Hi Thomas, >> >> thanks... Is it worthwhile to mark this patch as eligible for backporting? > > I don't think so. > Ferruh? Same here, I don't think required to backport this. > > >> On Wed, Aug 1, 2018 at 1:43 PM, Th

[dpdk-dev] [PATCH] net/e1000: Typos (rx_offload<->tx_offload)

2018-08-08 Thread Yaroslav Brustinov
Signed-off-by: Yaroslav Brustinov --- drivers/net/e1000/igb_rxtx.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index b955068..8aefd97 100644 --- a/drivers/net/e1000/igb_rxtx.c +++ b/drivers/net/e1000/

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] ring: fix c11 memory ordering issue

2018-08-08 Thread Thomas Monjalon
08/08/2018 05:07, Jerin Jacob: > From: Gavin Hu > > > > Hi Jia, > > > > Thanks for your feedback, let's see if there are requests from others to > > split the fix. > > +1 to split it as small patches. If possible, 4 patches, 2 for bug fix > and 2 for optimization. > > Like you mentioned over

[dpdk-dev] [RFC 0/4] ethdev: claim device reset as async

2018-08-08 Thread Qi Zhang
Device reset may have the dependency, for example, a VF reset expects PF ready, or a NIC function as a part of a SOC need to wait for other parts of the system be ready, these are time-consuming tasks and will block current thread. So we claimed rte_eth_dev_reset as an async API, that makes things

[dpdk-dev] [RFC 4/4] testpmd: enable async device reset

2018-08-08 Thread Qi Zhang
rte_eth_dev_reset is claimed as an async API, so re-work on the device reset handling. Signed-off-by: Qi Zhang --- app/test-pmd/testpmd.c | 55 +- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/t

[dpdk-dev] [RFC 3/4] net/ixgbe: enable async device reset

2018-08-08 Thread Qi Zhang
Handle device reset in a separate thread and raise RTE_ETH_EVENT_RESET_COMPLETE event when it is done. Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 48 +++- 1 file changed, 38 insertions(+), 10 deletions(-) diff --git a/drivers/net/ixgbe/ixg

[dpdk-dev] [RFC 2/4] net/i40e: enable async device reset

2018-08-08 Thread Qi Zhang
Handle device reset in a separate thread and raise RTE_ETH_EVENT_RESET_COMPLETE event when it is done. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c| 28 +++- drivers/net/i40e/i40e_ethdev_vf.c | 28 +++- 2 files changed, 46 inserti

[dpdk-dev] [RFC 1/4] ethdev: claim device reset as async

2018-08-08 Thread Qi Zhang
rte_eth_dev_reset should be implemented in an async way since it is possible be invoked in interrupt thread and sometimes to reset a device need to wait for some dependency, for example, a VF expects for PF ready, or a NIC function as part of a SOC wait for the whole system reset complete, all thes