On 08.08.2018 18:13, Stephen Hemminger wrote:
On Wed, 8 Aug 2018 15:00:42 +0800
Qi Zhang <qi.z.zh...@intel.com> wrote:
rte_eth_dev_reset should be implemented in an async way since it is
possible be invoked in interrupt thread and sometimes to reset a
device need to wait for some dependency, for example, a VF expects
for PF ready, or a NIC function as part of a SOC wait for the whole
system reset complete, all these time consuming task will block the
the interrupt thread.
The patch claims rte_eth_dev_reset is an async function and introduce
a new event RTE_ETH_EVENT_RESET_COMPLETE. PMD should raise this event
when finish reset in background. The applicaiton should always wait
for this event before continue to configure and restart the device.
If you have to change every driver to spawn a thread, then this doesn't
seem that useful. If you have to have a thread, then the base layer
code in EAL should do it.
Lots of DPDK changes seem to require every driver to change (a nuisance),
and then every driver changes in the same boilerplate way (indicates
poor design choice).
+1
