Re: [dpdk-dev] [PATCH] vhost: fix wait for valid descriptor

2018-07-26 Thread Tiwei Bie
On Thu, Jul 26, 2018 at 05:48:04PM +0200, Thomas Monjalon wrote: > What is the status of this patch? > > > 11/02/2018 05:21, Tan, Jianfeng: > > > > > -Original Message- > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Kulasek > > > Sent: Saturday, February 10, 2018 1:35

[dpdk-dev] [PATCH v2] doc: add SPDX and copyright to rel notes

2018-07-26 Thread Hemant Agrawal
using "The DPDK Contributors" as decided by techboard. Signed-off-by: Hemant Agrawal --- doc/guides/rel_notes/deprecation.rst | 3 +++ doc/guides/rel_notes/release_16_04.rst | 3 +++ doc/guides/rel_notes/release_16_07.rst | 3 +++ doc/guides/rel_notes/release_16_11.rst | 3 +++ doc/guides/rel_

[dpdk-dev] [PATCH v2] net/i40e: fix max frame size checking

2018-07-26 Thread Yanglong Wu
Check patcket size according to TSO or no-TSO. Fixes: bfeed0262b0c ("net/i40e: check illegal packets") Signed-off-by: Yanglong Wu --- v2: change as comments. --- drivers/net/i40e/i40e_ethdev.h | 1 + drivers/net/i40e/i40e_rxtx.c | 9 + 2 files changed, 6 insertions(+), 4 deletions(-)

[dpdk-dev] Questions about TX descriptors run out occasionally

2018-07-26 Thread Hui Liu
Hi Experts, I'm developing my own dpdk-based application via Intel 82599ES port. My Application is doing a job to send ICMP requests (packet size varies from 64 bytes to 1472 bytes, 200,000 pps, 1.1Gbps) and receive responses, with ARP request/response and ICMP response handling when necessary. It

[dpdk-dev] [PATCH v2] net/i40e: remove PF interrupt handler for multi-driver

2018-07-26 Thread Beilei Xing
When multi-dirver is enabled, internal Rx interrupt/LSC/adminq share the same source, that will cause lots of CPU cycles wasted during receiving packets. So remove the PF interrupt handler only when multi-driver is enabled. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 130

[dpdk-dev] [PATCH 1/2] doc: add multithread description to hash library

2018-07-26 Thread Yipeng Wang
Added multithreading related description into programmer guide of hash library. Signed-off-by: Yipeng Wang --- doc/guides/prog_guide/hash_lib.rst | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/doc/guides/prog_guide/hash_lib.rst b/doc/guides/pr

[dpdk-dev] [PATCH 2/2] hash: add more accurate thread-safety comments

2018-07-26 Thread Yipeng Wang
Describing the thread-safety support more accurately for API documentation. Fixes: f2e3001b53ec ("hash: support read/write concurrency") Signed-off-by: Yipeng Wang --- lib/librte_hash/rte_hash.h | 52 ++ 1 file changed, 39 insertions(+), 13 deletions(

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix ixgbevf link status

2018-07-26 Thread Wang, Dong1
Hi Yanglong, I think the risk (or bug) is in ixgbevf_check_link(), not how to invoke this function(). Anyone who call ixgbevf_check_link() with "wait = 0", they must can't get right link status when 82599 use DA Cable. In ixgbevf kernel driver, ixgbe_check_mac_link_vf(), "wait" didn't be refer

[dpdk-dev] [dpdk-announce] release candidate 18.08-rc2

2018-07-26 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v18.08-rc2 The number of commits (188) is reasonnable. We can expect some activity in drivers code and unit tests for -rc3, and hopefully no -rc4 before the release. The release notes so far: http

[dpdk-dev] [PATCH v13] devtools: alert on new instances of rte_panic and rte_exit

2018-07-26 Thread Arnon Warshavsky
This patch adds a new function that is called per every checked patch, and alerts for new instances of rte_panic/rte_exit. The check excludes comments, and alerts in the case of a positive balance between additions and removals. Signed-off-by: Arnon Warshavsky Reviewed-by: Stephen Hemminger Test

Re: [dpdk-dev] [PATCH v12] devtools: alert on new instances of rte_panic and rte_exit

2018-07-26 Thread Arnon Warshavsky
> > One more nit: the title says "additions/removals" but the function is > only about additions. > > > Yup. No removals there..

Re: [dpdk-dev] [PATCH v12] devtools: alert on new instances of rte_panic and rte_exit

2018-07-26 Thread Thomas Monjalon
> 16/07/2018 14:44, Arnon Warshavsky: > > + ! $verbose || printf '\nChecking forbidden tokens additions/removals:\n' > > + report=$(cat $tmpinput | check_forbidden_additions) One more nit: the title says "additions/removals" but the function is only about additions.

Re: [dpdk-dev] [PATCH] rawdev: remove experimental flag

2018-07-26 Thread Thomas Monjalon
16/07/2018 08:18, Hemant Agrawal: > Acked-by: Hemant Agrawal Applied, thanks

Re: [dpdk-dev] [PATCH v2] vfio: remove experimental tag from vfio APIs

2018-07-26 Thread Thomas Monjalon
18/06/2018 12:02, Burakov, Anatoly: > On 08-Jun-18 10:40 AM, Hemant Agrawal wrote: > > Signed-off-by: Hemant Agrawal A comment reminding in which release these functions have been introduced would be better... > > --- > > v2: remove duplicate entry from map file > > > > Reviewed-by: Anatoly Bu

Re: [dpdk-dev] [PATCH v12] devtools: alert on new instances of rte_panic and rte_exit

2018-07-26 Thread Arnon Warshavsky
> > + read -d '' awk_script << 'EOF' > > EOF must be quoted? > Missed that one. Yes, the quotes are there to prevent parameter expansion of the awk variables. The script breaks without them

Re: [dpdk-dev] [PATCH v2 1/2] eal: remove deprecated function returning mbuf pool ops name

2018-07-26 Thread Thomas Monjalon
26/06/2018 11:56, Olivier Matz: > rte_eal_mbuf_default_mempool_ops() is replaced by > rte_mbuf_best_mempool_ops(). > > Signed-off-by: Olivier Matz > --- > > v2: > * remove rte_eal_mbuf_user_pool_ops from .map in next patch instead of this > > doc/guides/rel_notes/deprecation.rst| 9 --

Re: [dpdk-dev] [PATCH] mbuf: remove experimental tag from pool ops functions

2018-07-26 Thread Thomas Monjalon
25/06/2018 17:27, Olivier Matz: > On Mon, Jun 11, 2018 at 07:49:37PM +0530, santosh wrote: > > On Monday 11 June 2018 07:37 PM, Jerin Jacob wrote: > > >> Signed-off-by: Hemant Agrawal > > > > Acked-by: Santosh Shukla > > Shouldn't we add something in doc/guides/rel_notes/release_18_08.rst, > li

Re: [dpdk-dev] [PATCH 1/2] mempool: remove deprecated functions

2018-07-26 Thread Thomas Monjalon
11/07/2018 12:59, Andrew Rybchenko: > Functions rte_mempool_populate_phys(), rte_mempool_virt2phy() and > rte_mempool_populate_phys_tab() are just wrappers for corresponding > IOVA functions and were deprecated in v17.11. > > Functions rte_mempool_xmem_create(), rte_mempool_xmem_size(), > rte_memp

Re: [dpdk-dev] [PATCH 0/3] deprecate attach and detach functions

2018-07-26 Thread Thomas Monjalon
11/07/2018 16:14, Andrew Rybchenko: > As discussed in [1] EAL hotplug should be used directly to add/remove devices. > > app/pdump changes are build-tested only. > > [1] http://mails.dpdk.org/archives/dev/2018-July/107507.html > > Andrew Rybchenko (3): > app/pdump: use hotplug add instead of a

Re: [dpdk-dev] [PATCH v12] devtools: alert on new instances of rte_panic and rte_exit

2018-07-26 Thread Thomas Monjalon
26/07/2018 22:57, Arnon Warshavsky: > > > + if [ $? -ne 0 ] ; then > > > + ret=1 > > > + fi > > > + printf '%s\n' "$report" > > > > You are printing the report, no matter of the result? Why? > > Is it because a warning does not return as an error? > > > There is maybe an imp

Re: [dpdk-dev] [PATCH v12] devtools: alert on new instances of rte_panic and rte_exit

2018-07-26 Thread Arnon Warshavsky
> > +check_forbidden_additions() { # > > This function looks to work with stdin, not a file. > Better to remove the comment about a . > It can actually work with both but you are right. The comment is not beneficial there Will fix with the rest of the list below ... > > > + if [ $? -ne 0 ]

Re: [dpdk-dev] [PATCH] doc: fix spelling error in vdev_netvsc

2018-07-26 Thread Thomas Monjalon
25/07/2018 19:51, Stephen Hemminger: > Signed-off-by: Stephen Hemminger Fixes: 56252de779a6 ("net/vdev_netvsc: add automatic probing") Cc: sta...@dpdk.org Applied, thanks

Re: [dpdk-dev] [PATCH] Use SPDX license tag

2018-07-26 Thread Thomas Monjalon
Hi Chao, 13/06/2018 14:06, Chao Zhu: > Signed-off-by: Chao Zhu > --- > drivers/net/i40e/i40e_rxtx_vec_altivec.c | 35 > ++ > lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c | 34 ++--- > lib/librte_eal/common/arch/ppc_64/rte_cycles.c | 4 +++

Re: [dpdk-dev] [PATCH] buildtools: change license to SPDX

2018-07-26 Thread Thomas Monjalon
05/06/2018 13:27, Neil Horman: > On Tue, Jun 05, 2018 at 01:20:25PM +0530, Hemant Agrawal wrote: > > Cc: nhor...@tuxdriver.com > > > > Signed-off-by: Hemant Agrawal > > > Acked-by: Neil Horman Applied, thanks

Re: [dpdk-dev] [PATCH] doc: add SPDX and copyright to rel notes

2018-07-26 Thread Thomas Monjalon
05/06/2018 09:50, Hemant Agrawal: > --- a/doc/guides/rel_notes/release_2_2.rst > +++ b/doc/guides/rel_notes/release_2_2.rst > @@ -1,3 +1,5 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + > DPDK Release 2.2 There is no Copyright for 2.2 ?

Re: [dpdk-dev] [PATCH v1] doc/samples: update vm power manager sample docs

2018-07-26 Thread Thomas Monjalon
> > Add information on the ability of guest app to sent a policy to the host > > app. > > > > Add information on the branch ratio out-of-band method of workload > > monitoring and power management. > > > > Signed-off-by: David Hunt > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH v2] doc: fix incorrect create bonding command in testpmd

2018-07-26 Thread Thomas Monjalon
25/07/2018 13:31, Shreyansh Jain: > Fixes: ac718398f477 ("doc: testpmd application user guide") > Cc: bernard.iremon...@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Shreyansh Jain > Reviewed-by: Ferruh Yigit > Acked-by: Bernard Iremonger Applied, thanks

Re: [dpdk-dev] [PATCH v12] devtools: alert on new instances of rte_panic and rte_exit

2018-07-26 Thread Thomas Monjalon
Hi, I am sorry, I always give low priority to tooling review. I was going to apply this one, but I've seen some details to improve. 16/07/2018 14:44, Arnon Warshavsky: > +check_forbidden_additions() { # This function looks to work with stdin, not a file. Better to remove the comment about a .

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 10/10] mk: remove unnecessary make rules of test

2018-07-26 Thread Thomas Monjalon
17/07/2018 18:00, Reshma Pattan: > make rule test-basic is duplicate of test rule. > removed unused test-mempool and test-ring make rules. > > Fixes: a3df7f8d9c ("mk: rename test related rules") > Fixes: a3df7f8d9c ("mk: rename test related rules") > CC: sta...@dpdk.org > CC: ferruh.yi...@intel.co

Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again

2018-07-26 Thread Thomas Monjalon
17/07/2018 18:00, Reshma Pattan: > Previously, unit tests were running in groups. There were technical reasons > why that was the case (mostly having to do with limiting memory), but it was > hard to maintain and update the autotest script. > > In 18.05, limiting of memory at DPDK startup was no

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] test/hash: fix multiwriter with non consecutive cores

2018-07-26 Thread Thomas Monjalon
17/07/2018 15:31, Pablo de Lara: > When non consecutive cores are passed into the test application, > the distribution of the keys that each thread needs to insert > is not correct, since it assumes that there are no cores skipped > between the master core and the worker core. > > Fixes: be856325c

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/bonding: don't request CRC STRIP offload

2018-07-26 Thread Thomas Monjalon
20/07/2018 17:59, Ferruh Yigit: > bonding PMD doesn't announce CRC STRIP offload support, don't request > this offload in unit test otherwise unit test fails. > > Fixes: f52f1a65e461 ("ethdev: force offloading API rules") > Cc: sta...@dpdk.org > > Reported-by: Meijuan Zhao > Signed-off-by: Ferru

Re: [dpdk-dev] [PATCH v3] test: fix incorrect return types

2018-07-26 Thread Thomas Monjalon
17/07/2018 18:44, Reshma Pattan: > UTs should return either TEST_SUCCESS or TEST_FAILED only. > They should not return 0, -1 and any other value. > > Fixes: 9c9befea4f ("test: add flow classify unit tests") > CC: jasvinder.si...@intel.com > CC: bernard.iremon...@intel.com > CC: sta...@dpdk.org >

Re: [dpdk-dev] [PATCH v2] test: fix prefix discovery

2018-07-26 Thread Thomas Monjalon
25/07/2018 15:44, Anatoly Burakov: > Config file has moved, but the tests weren't updated to point to > its new location. Update the code to find current prefix. > > Also, this function is duplicated across multiple tests, so move it > into process.h and force compile failures for any attempts to

Re: [dpdk-dev] [PATCH] test: ensure EAL flags autotest works properly on BSD

2018-07-26 Thread Thomas Monjalon
> FreeBSD does not support running multiple primary processes concurrently, > because all DPDK instances will allocate memory from the same place (memory > provided by contigmem driver). > While it is technically possible to launch a DPDK process using no-shconf > switch, it will actually corrup

Re: [dpdk-dev] [dpdk-stable] [PATCH] bus/pci: fix a typo

2018-07-26 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, July 26, 2018 8:21 PM > To: Rosen, Rami > Cc: sta...@dpdk.org; dev@dpdk.org; gaetan.ri...@6wind.com; Mcnamara, John > > Subject: Re: [dpdk-stable] [PATCH] bus/pci: fix a typo > > 26/07/2018 20:

Re: [dpdk-dev] [dpdk-stable] [PATCH] bus/pci: fix a typo

2018-07-26 Thread Thomas Monjalon
26/07/2018 20:31, Rami Rosen: > This patch fixes a trivial typo in pci_common.c. > > Signed-off-by: Rami Rosen Fixes: 23eaa9059ec2 ("bus/pci: use given name as generic name") Cc: gaetan.ri...@6wind.com > --- a/drivers/bus/pci/pci_common.c > +++ b/drivers/bus/pci/pci_common.c > if (devargs

Re: [dpdk-dev] [PATCH] vhost: add API for getting last_idx of vrings

2018-07-26 Thread Thomas Monjalon
26/07/2018 21:11, Stojaczyk, DariuszX: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > What is the status of this patch? > > It can be abandoned. I can see Zhihong added equivalent APIs called > rte_vhost_get_vring_base/set_vring_base back in April. OK, thank you

Re: [dpdk-dev] [PATCH] vhost: add API for getting last_idx of vrings

2018-07-26 Thread Stojaczyk, DariuszX
It can be abandoned. I can see Zhihong added equivalent APIs called rte_vhost_get_vring_base/set_vring_base back in April. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, July 26, 2018 5:44 PM > To: Maxime Coquelin ; Kulasek, TomaszX > > Cc: de

Re: [dpdk-dev] [dpdk-stable] [PATCH] bus/pci: fix a typo

2018-07-26 Thread Mcnamara, John
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Rami Rosen > Sent: Thursday, July 26, 2018 7:31 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Rosen, Rami > Subject: [dpdk-stable] [PATCH] bus/pci: fix a typo > > This patch fixes a trivial typo in pci_com

[dpdk-dev] [PATCH] bus/pci: fix a typo

2018-07-26 Thread Rami Rosen
This patch fixes a trivial typo in pci_common.c. Signed-off-by: Rami Rosen --- drivers/bus/pci/pci_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 94b0f41..8253a50 100644 --- a/drivers/bus/pci/pci_comm

Re: [dpdk-dev] [PATCH v1] lib/metrics: disallow NULL as metric name

2018-07-26 Thread Thomas Monjalon
20/07/2018 17:30, Ferruh Yigit: > On 7/2/2018 2:46 PM, Remy Horton wrote: > > This patch adds a sanity check so that names passed into > > rte_metrics_reg_names() and the wrapper rte_metrics_reg_name() > > cannot be NULL. > > > > Fixes: 349950ddb9c5 ("metrics: add information metrics library") > >

Re: [dpdk-dev] [PATCH v1] lib/metrics: fix silent fail when uninitialised

2018-07-26 Thread Thomas Monjalon
02/07/2018 16:55, Remy Horton: > If rte_metrics_init() had not been called and hence the internal > metric storage is not allocated, rte_metrics_get_values() and > rte_metrics_get_name() would silently fail by returning zero > (i.e. no metrics registered). This patch changes the result of > this sc

Re: [dpdk-dev] [PATCH v1] lib/metrics: add check for invalid metric keys

2018-07-26 Thread Thomas Monjalon
Remy, You are not new to DPDK. Please pay attention to details: - subject does not start with lib/ - fixes of old commits must have Cc: sta...@dpdk.org 20/07/2018 17:31, Ferruh Yigit: > On 7/6/2018 2:21 PM, Remy Horton wrote: > > This patchset adds a check to rte_metrics_update_values() > > that p

Re: [dpdk-dev] [PATCH v2] lib/bitratestats: add NULL sanity checks

2018-07-26 Thread Thomas Monjalon
20/07/2018 17:31, Ferruh Yigit: > On 7/12/2018 11:49 AM, Remy Horton wrote: > > If rte_stats_bitrate_reg() or rte_stats_bitrate_calc() are > > passed NULL as the parameter for the stats structure, the > > result is a crash. Fixed by adding a sanity check that makes > > sure the passed-in pointer is

Re: [dpdk-dev] [PATCH] examples/l3fwd: remove redudant include.

2018-07-26 Thread Thomas Monjalon
02/07/2018 19:55, Rami Rosen: > This patch removes unneeded include of rte_mempool.h in > two modules in examples/l3fwd. > > Fixes: 26b5b020 ("examples/l3fwd: modularize") > > Signed-off-by: Rami Rosen Applied, thanks

Re: [dpdk-dev] [PATCH] examples/exception_path: fix possible out-of-bounds read

2018-07-26 Thread Thomas Monjalon
16/07/2018 18:03, Bruce Richardson: > When printing out stats from the exception_path app, all possible > lcore_ids are iterated. However, the app only supports up to 64 cores. > To prevent possible errors, and to remove coverity warnings, > explicitly check for out-of-range lcore ids before printi

Re: [dpdk-dev] [PATCH v1] doc/samples: update vm power manager sample docs

2018-07-26 Thread Mcnamara, John
> -Original Message- > From: Hunt, David > Sent: Wednesday, July 25, 2018 2:00 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Hunt, David > > Subject: [PATCH v1] doc/samples: update vm power manager sample docs > > Add information on the ability of guest app to sent a policy to the host

Re: [dpdk-dev] [PATCH v3] examples/flow_filtering: add rte_fdir_conf initialization

2018-07-26 Thread Thomas Monjalon
22/07/2018 12:39, Rosen Xu: > Rte_fdir_conf of rte_eth_conf should be initialized before > port initialization. It is a workaround solution when working > with Intel I40e. [...] > + /* > + * Initialize fdir_conf of ete_eth_conf Typo and lack of punctuation. > +

Re: [dpdk-dev] [PATCH] examples/l3fw-power: do not exit on power lib init failure

2018-07-26 Thread De Lara Guarch, Pablo
Hi Radu, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Radu Nicolau > Sent: Wednesday, July 18, 2018 2:50 PM > To: dev@dpdk.org > Cc: Hunt, David ; Yao, Lei A ; > Nicolau, Radu > Subject: [dpdk-dev] [PATCH] examples/l3fw-power: do not exit on power lib init >

Re: [dpdk-dev] [PATCH v3 1/2] app/testpmd: fix use of uninitialized field

2018-07-26 Thread Thomas Monjalon
> > print_err_msg uses message field that may be not initialized causing > > segmentation fault. > > > > Fixes: 12f76f5247e2 ("app/testpmd: add command to resume a TM node") > > Cc: t...@semihalf.com > > > > Signed-off-by: Krzysztof Kanas > > Acked-by: Bernard Iremonger Series applied, thanks

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix buffer leak in tm cmdline

2018-07-26 Thread Thomas Monjalon
05/07/2018 07:45, Nithin Dabilpuram: > Free the buffer allocated for shared_shaper_id array in > case of configuration without shared shapers. > > Signed-off-by: Nithin Dabilpuram > Acked-by: Jasvinder Singh Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix dcb config failure

2018-07-26 Thread Thomas Monjalon
> > After adding RSS hash offload check, default rss_hf will fail on devices > > that do > > not support all bits. This will lead to dcb config failure. The patch fixes > > this > > issue by taking rss_hf as a suggested value and only setting bits that the > > device supports based on rte_eth_dev

Re: [dpdk-dev] [PATCH] app/testpmd: fix logically dead code

2018-07-26 Thread Thomas Monjalon
> > Remove logically dead code, tm_port_rate cannot be greater than > > UINT32_MAX. > > > > Coverity issue: 302846 > > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") > > > > Signed-off-by: Kevin Laatz > > Acked-by: Bernard Iremonger Applied, thanks

Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

2018-07-26 Thread Thomas Monjalon
> Anoob Joseph (12): > examples/l2fwd: move macro definitions to common header > examples/l2fwd: move structure definitions to common header > examples/l2fwd: move globally accessed vars to common header > examples/l2fwd: move dataplane code to new file > examples/l2fwd: remove unused hea

[dpdk-dev] [PATCH] lib/latencystats: free up the memzone

2018-07-26 Thread Reshma Pattan
Free up the memzone allocated during the rte_latencystats_init(). Fixes: 5cd3cac9ed ("latency: added new library for latency stats") CC: sta...@dpdk.org CC: remy.hor...@intel.com Signed-off-by: Reshma Pattan --- lib/librte_latencystats/rte_latencystats.c | 8 +++- 1 file changed, 7 insertio

Re: [dpdk-dev] [PATCH v7 1/4] test: add ring pmd based packet rx/tx for UT

2018-07-26 Thread Pattan, Reshma
Hi, > -Original Message- > From: Somarowthu, Naga SureshX > Sent: Thursday, July 26, 2018 1:50 PM > To: dev@dpdk.org > Cc: Horton, Remy ; Pattan, Reshma > ; Somarowthu, Naga SureshX > > Subject: [PATCH v7 1/4] test: add ring pmd based packet rx/tx for UT > dpdk-dpdk]$ ./devtools/check-g

Re: [dpdk-dev] [PATCH v5] eal/service: improve error checking of coremasks

2018-07-26 Thread Thomas Monjalon
26/07/2018 18:31, Harry van Haaren: > This commit improves the error checking performed on the > core masks (or lists) of the service cores, in particular > with respect to the data-plane (RTE) cores of DPDK. > > With this commit, invalid configurations are detected at > runtime, and warning messa

[dpdk-dev] [PATCH v5] eal/service: improve error checking of coremasks

2018-07-26 Thread Harry van Haaren
This commit improves the error checking performed on the core masks (or lists) of the service cores, in particular with respect to the data-plane (RTE) cores of DPDK. With this commit, invalid configurations are detected at runtime, and warning messages are printed to inform the user. For example

Re: [dpdk-dev] [pull-request] next-eventdev 18.08 RC2

2018-07-26 Thread Thomas Monjalon
25/07/2018 14:34, Jerin Jacob: > http://dpdk.org/git/next/dpdk-next-eventdev > > for you to fetch changes up to f094d5a870e88536eab6210f5eb8586906563809: > > app/eventdev: use proper teardown sequence (2018-07-25 17:59:55 +0530) > > --

[dpdk-dev] [PATCH v4] eal/service: improve error checking of coremasks

2018-07-26 Thread Harry van Haaren
This commit improves the error checking performed on the core masks (or lists) of the service cores, in particular with respect to the data-plane (RTE) cores of DPDK. With this commit, invalid configurations are detected at runtime, and warning messages are printed to inform the user. For example

Re: [dpdk-dev] [PATCH v7 0/4] add unit tests for bitrate, latency and pdump libraries

2018-07-26 Thread Pattan, Reshma
Hi, > -Original Message- > From: Somarowthu, Naga SureshX > Sent: Thursday, July 26, 2018 1:50 PM > To: dev@dpdk.org > Cc: Horton, Remy ; Pattan, Reshma > ; Somarowthu, Naga SureshX > > Subject: [PATCH v7 0/4] add unit tests for bitrate, latency and pdump > libraries > > 1/4: add ring p

Re: [dpdk-dev] [PATCH] vhost: fix wait for valid descriptor

2018-07-26 Thread Thomas Monjalon
What is the status of this patch? 11/02/2018 05:21, Tan, Jianfeng: > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Kulasek > > Sent: Saturday, February 10, 2018 1:35 AM > > To: y...@fridaylinux.org > > Cc: dev@dpdk.org; yuanhan@linux.intel.com

Re: [dpdk-dev] [PATCH] vhost: add API for getting last_idx of vrings

2018-07-26 Thread Thomas Monjalon
What is the status of this patch? 19/04/2018 16:57, Maxime Coquelin: > Hi Tomasz, > > On 03/28/2018 11:31 AM, Kulasek, TomaszX wrote: > > Hi Maxime, > > > >> -Original Message- > >> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > >> Sent: Wednesday, March 28, 2018 10:57 > >>

Re: [dpdk-dev] [PATCH v4 0/5] use IOVAs check based on DMA mask

2018-07-26 Thread Thomas Monjalon
10/07/2018 19:25, Alejandro Lucero: > This patchset applies on 17.11.3. > > Similar changes will be submitted to main DPDK branch soon. In patchwork, I mark this patchset as Deferred, waiting a new version for 18.11.

Re: [dpdk-dev] [pull-request] next-net 18.08 RC2

2018-07-26 Thread Thomas Monjalon
23/07/2018 23:35, Ferruh Yigit: > http://dpdk.org/git/next/dpdk-next-net Pulled, thanks

Re: [dpdk-dev] [pull-request] next-pipeline 18.08 pre-rc2

2018-07-26 Thread Thomas Monjalon
25/07/2018 19:35, Cristian Dumitrescu: > http://dpdk.org/git/next/dpdk-next-pipeline Pulled, thanks

[dpdk-dev] [Bug 77] [Interrupt app]: failed to start interrupt app.

2018-07-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=77 lei.a@intel.com changed: What|Removed |Added Status|CONFIRMED |RESOLVED CC|

[dpdk-dev] [Bug 77] [Interrupt app]: failed to start interrupt app.

2018-07-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=77 Bug ID: 77 Summary: [Interrupt app]: failed to start interrupt app. Product: DPDK Version: 18.08 Hardware: x86 OS: Linux Status: CONFIRMED Severity: major

Re: [dpdk-dev] [PATCH] net/mlx4: verify RSS supports num Rx Qs being used

2018-07-26 Thread Matan Azrad
Hi Moti Small comment below. From: Mordechay Haimovsky > This patch verifies that the number of Rx queues configured for RSS is > supported by the device hardware. > RSS support in mlx4 requires contiguous chunk of QPs to be reserved, there is > a > hardware limitation on the amount of contiguou

Re: [dpdk-dev] [PATCH v3] eal/service: improve error checking of coremasks

2018-07-26 Thread Thomas Monjalon
Hi Harry, Are you OK to make a v4? 13/07/2018 19:33, Thomas Monjalon: > 13/07/2018 19:25, Harry van Haaren: > > v3: > > - Use WARNING instead of ERR log level (Vipin) > > - Put strings on one line for grep-ability (Harry) > > We can consider it is OK to have sentences on different lines. > Who

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix testpmd exit for ctrl+d

2018-07-26 Thread Thomas Monjalon
24/07/2018 16:46, Pattan, Reshma: > + CC: Olivier and Mordechay Haimovsky. > > > Testpmd should be existed gracefully when ctrl+d is typed. > > This behaviour is not handled properly, fix this by calling > > pmd_test_exit() instead of rte_panic. > > > > Fixes: 0ad778b398c6 ("app/testpmd: rework

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: removed softnic CLI modifications

2018-07-26 Thread Thomas Monjalon
25/07/2018 22:27, Aaron Conole: > Moti Haimovsky writes: > > > This patch reverts the testpmd CLI prompt routine modifications done > > in order to support softnic. > > The reason of doing so is due to testpmd abnormal exit observed on > > several setups caused by the softnic modifications to thi

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: add example script for rss

2018-07-26 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Cristian Dumitrescu > Sent: Thursday, July 26, 2018 2:38 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] examples/ip_pipeline: add example script for > rss > > Add example script to demonstrate Receive Side

Re: [dpdk-dev] [PATCH] build: simplify logic for default library dependencies

2018-07-26 Thread Thomas Monjalon
19/07/2018 16:37, Bruce Richardson: > EAL is a standard dependency of all libraries, except for those built > before it. We can therefore simplify the logic by just checking if EAL > has been processed, and make it a standard dependency if so. > > Signed-off-by: Bruce Richardson I guess there is

Re: [dpdk-dev] [PATCH] maintainers: update for szedata2 PMD

2018-07-26 Thread Thomas Monjalon
17/07/2018 16:01, Jan Remeš: > On Tue, Jul 17, 2018 at 3:52 PM, Matej Vido wrote: > > > > I will no longer be maintaining szedata2 PMD. Jan will take over this > > role. > > > > Signed-off-by: Matej Vido > > --- > > Netcope szedata2 > > -M: Matej Vido > > +M: Jan Remes > > Acked-by: Jan Remes

Re: [dpdk-dev] [RFC 00/11] Support externally allocated memory in DPDK

2018-07-26 Thread Burakov, Anatoly
On 19-Jul-18 11:58 AM, László Vadkerti wrote: On Jul 13, 2018, at 7:57 PM, Wiles, Keith wrote: On Jul 13, 2018, at 12:10 PM, Burakov, Anatoly wrote: On 06-Jul-18 2:17 PM, Anatoly Burakov wrote: This is a proposal to enable using externally allocated memory in DPDK. In a nutshell, here is w

[dpdk-dev] [PATCH] examples/ip_pipeline: add example script for rss

2018-07-26 Thread Cristian Dumitrescu
Add example script to demonstrate Receive Side Scaling (RSS). Signed-off-by: Cristian Dumitrescu --- examples/ip_pipeline/examples/rss.cli | 112 ++ 1 file changed, 112 insertions(+) create mode 100644 examples/ip_pipeline/examples/rss.cli diff --git a/examples/

Re: [dpdk-dev] [PATCH v2 0/2] dpdk header fixes for aarch64

2018-07-26 Thread Thomas Monjalon
> Andy Green (2): > ring: fix declaration after code > ring: fix sign conversion warning Applied, thanks

Re: [dpdk-dev] [PATCH v3] drivers/net: fix segfault in secondary process

2018-07-26 Thread Thomas Monjalon
20/07/2018 16:54, Ferruh Yigit: > Calling rte_eth_dev_info_get() on secondary process cause a crash > because eth_dev->device is not set properly. > > Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process") > Cc: sta...@dpdk.org > > Reported-by: Vipin Varghese > Signed-off-by:

Re: [dpdk-dev] [PATCH] net/i40e: fix max frame size checking

2018-07-26 Thread Ananyev, Konstantin
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, July 26, 2018 1:48 PM > To: Ananyev, Konstantin ; Wu, Yanglong > ; dev@dpdk.org > Cc: Bie, Tiwei ; Yao, Lei A ; Wu, > Yanglong > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix max frame size checking > > > > > -Original

[dpdk-dev] [PATCH v7 1/4] test: add ring pmd based packet rx/tx for UT

2018-07-26 Thread Naga Suresh Somarowthu
Added ring pmd based packet rx/tx helper functions for verifying Latency, Bitrate and pdump lib UTs. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan Reviewed-by: Anatoly Burakov --- test/test/Makefile| 1 + test/test/sample_packet_forward.c | 115

[dpdk-dev] [PATCH v7 3/4] test: add unit tests for latencystats library

2018-07-26 Thread Naga Suresh Somarowthu
Unit Test Cases added for latencystats library. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan --- test/test/Makefile| 1 + test/test/autotest_data.py| 6 ++ test/test/test_latencystats.c | 216 ++ 3 files changed, 22

[dpdk-dev] [PATCH v7 4/4] test: add unit test for pdump library

2018-07-26 Thread Naga Suresh Somarowthu
Unit test cases are added for pdump library. Primary process will act as server, forks a child secondary process. Secondary process acts as client. Server will do pdump init to serve any pdump client requests. Server will create a vdev, send/receive packets continuously in a separate thread. Client

[dpdk-dev] [PATCH v7 2/4] test: add unit tests for bitrate library

2018-07-26 Thread Naga Suresh Somarowthu
Unit Test Cases for BitRate library. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan Reviewed-by: Remy Horton --- test/test/Makefile| 1 + test/test/autotest_data.py| 6 ++ test/test/test_bitratestats.c | 227 ++ 3 fi

[dpdk-dev] [PATCH v7 0/4] add unit tests for bitrate, latency and pdump libraries

2018-07-26 Thread Naga Suresh Somarowthu
1/4: add ring pmd based packet helper functions for UT 2/4: unit test cases added for bitrate library 3/4: unit test cases added for latencystats library 4/4: unit test cases added for pdump library Patches 2/4,3/4 depends on 1/4 Patch 4/4 depends on 1/4 and the b

Re: [dpdk-dev] [PATCH] net/i40e: fix max frame size checking

2018-07-26 Thread Zhang, Qi Z
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, July 26, 2018 8:33 PM > To: Zhang, Qi Z ; Wu, Yanglong > ; dev@dpdk.org > Cc: Bie, Tiwei ; Yao, Lei A ; Wu, > Yanglong > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix max frame size checking > > > > > -Original Me

Re: [dpdk-dev] [PATCH] net/i40e: fix max frame size checking

2018-07-26 Thread Ananyev, Konstantin
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, July 26, 2018 1:26 PM > To: Zhang, Qi Z ; Ananyev, Konstantin > ; Wu, Yanglong > ; dev@dpdk.org > Cc: Bie, Tiwei ; Yao, Lei A ; Wu, > Yanglong > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix max frame size checking > > > >

Re: [dpdk-dev] [PATCH] net/i40e: fix max frame size checking

2018-07-26 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Thursday, July 26, 2018 8:14 PM > To: Ananyev, Konstantin ; Wu, Yanglong > ; dev@dpdk.org > Cc: Bie, Tiwei ; Yao, Lei A ; Wu, > Yanglong > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix max fr

Re: [dpdk-dev] [PATCH] net/i40e: fix max frame size checking

2018-07-26 Thread Zhang, Qi Z
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, July 26, 2018 5:17 PM > To: Wu, Yanglong ; dev@dpdk.org > Cc: Zhang, Qi Z ; Bie, Tiwei ; Yao, > Lei A ; Wu, Yanglong > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix max frame size checking > > > > > -Original Mess

Re: [dpdk-dev] [PATCH] mk: fix application compilation with lmnl and mlx5

2018-07-26 Thread Thomas Monjalon
24/07/2018 11:32, Adrien Mazarguil: > On Tue, Jul 24, 2018 at 11:29:09AM +0200, Nelio Laranjeiro wrote: > > When Mellanox MLX5 PMD is compiled with > > CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS=y, the external dependency on libmln > > is missing. > > > > Fixes: 4d5cce06231a ("net/mlx5: lay groundwork for

[dpdk-dev] DPDK Release Status Meeting 26/07/2018

2018-07-26 Thread Mcnamara, John
DPDK Release Status Meeting 26/07/2018 == Minutes from the weekly DPDK Release Status Meeting. The DPDK Release Status Meeting is intended for DPDK Committers to discuss the status of the master tree and sub-trees, and for project managers to track progress or

Re: [dpdk-dev] [PATCH v6 4/4] test: add unit test for pdump library

2018-07-26 Thread Burakov, Anatoly
On 25-Jul-18 6:06 PM, Naga Suresh Somarowthu wrote: Unit test cases are added for pdump library. Primary process will act as server, forks a child secondary process. Secondary process acts as client. Server will do pdump init to serve any pdump client requests. Server will create a vdev, send/rec

Re: [dpdk-dev] [PATCH v6 1/4] test: add ring pmd based packet rx/tx for UT

2018-07-26 Thread Burakov, Anatoly
On 25-Jul-18 6:05 PM, Naga Suresh Somarowthu wrote: Added ring pmd based packet rx/tx helper functions for verifying Latency, Bitrate and pdump lib UTs. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan --- + ret = test_get_mempool(mp, poolname); + if (ret < 0)

Re: [dpdk-dev] [PATCH] config: reduce memory requirements for DPDK

2018-07-26 Thread Burakov, Anatoly
On 25-Jul-18 6:43 PM, Kevin Traynor wrote: On 07/24/2018 01:03 PM, Thomas Monjalon wrote: 24/07/2018 13:04, Burakov, Anatoly: On 24-Jul-18 11:23 AM, Thomas Monjalon wrote: 24/07/2018 12:03, Anatoly Burakov: It has been reported that current memory limitations do not work well on an 8-socket m

Re: [dpdk-dev] [PATCH 3/4] eal: don't crash if alarm set fails

2018-07-26 Thread Burakov, Anatoly
On 25-Jul-18 7:20 PM, Stephen Hemminger wrote: There is no need to call rte_exit and crash the application here; better to let the application handle the error itself. Remove the gratuitous profanity which would be visible if the rte_exit was still there. Signed-off-by: Stephen Hemminger ---

Re: [dpdk-dev] [PATCH v2] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

2018-07-26 Thread Ananyev, Konstantin
> > Hi Konstantin, > > On Wed, Jul 25, 2018 at 09:11:30AM +, Ananyev, Konstantin wrote: > > Hi Cody, > > > > > -Original Message- > > > From: Cody Doucette [mailto:douce...@bu.edu] > > > Sent: Thursday, July 19, 2018 4:58 PM > > > To: Ananyev, Konstantin ; Olivier Matz > > > ; Dumi

Re: [dpdk-dev] [PATCH v5] vfio: fix workaround of BAR mapping

2018-07-26 Thread Thomas Monjalon
20/07/2018 10:13, Takeshi Yoshimura: > Currently, VFIO will try to map around MSI-X table in the BARs. When > MSI-X table (page-aligned) size is equal to (page-aligned) size of BAR, > VFIO will just skip the BAR. > > Recent kernel versions will allow VFIO to map the entire BAR containing > MSI-X t

Re: [dpdk-dev] [PATCH 3/4] eal: don't crash if alarm set fails

2018-07-26 Thread Burakov, Anatoly
On 25-Jul-18 7:20 PM, Stephen Hemminger wrote: There is no need to call rte_exit and crash the application here; better to let the application handle the error itself. Remove the gratuitous profanity which would be visible if the rte_exit was still there. Signed-off-by: Stephen Hemminger ---

Re: [dpdk-dev] [PATCH] Revert "mem: allocate in reverse to reduce fragmentation"

2018-07-26 Thread Burakov, Anatoly
On 26-Jul-18 10:18 AM, Thomas Monjalon wrote: 24/07/2018 14:21, Anatoly Burakov: This reverts commit 179f916e88e4a0fdd5ad4d20e226771d3d271c41. A few regressions with virtio/vhost have been discovered, due to the strong dependency of virtio/vhost on the underlying memory layout. Specifically, vi

  1   2   >