Hi Radu, > -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Radu Nicolau > Sent: Wednesday, July 18, 2018 2:50 PM > To: dev@dpdk.org > Cc: Hunt, David <david.h...@intel.com>; Yao, Lei A <lei.a....@intel.com>; > Nicolau, Radu <radu.nico...@intel.com> > Subject: [dpdk-dev] [PATCH] examples/l3fw-power: do not exit on power lib init > failure > > Do not exit the application if power library fails to initialize or high > performance > cores configuration cannot be used.
I would say this deserves more explanation. It doesn't look correct to me to keep log an error that the power library couldn't be initialized and still the sample application keeps running. Actually, the way init_power_library is coded, it returns the output of the call of rte_power_init on the last core (ret is overwritten for each core), which looks wrong to me. Thanks, Pablo > > Signed-off-by: Radu Nicolau <radu.nico...@intel.com> > ---
