Re: [dpdk-dev] Does lthread_cond_wait need a mutex?

Hi~ I would be appreciate it if you could provide your lthread code for me. And I found that DPDK lthreads does not provide lthread_cond_timedwait API which I am looking for. Thanks. Regards, Wubenqing From: Wiles, Keith Dat

Re: [dpdk-dev] [PATCH v4 0/9] examples/vm_power: 100% Busy Polling

13/07/2018 16:22, David Hunt: > [1/9] examples/vm_power: add check for port count > [2/9] examples/vm_power: add core list parameter > [3/9] examples/vm_power: add oob monitoring functions > [4/9] examples/vm_power: allow greater than 64 cores > [5/9] examples/vm_power: add thread for oob core moni

Re: [dpdk-dev] [PATCH v3] net/tap: add queues when attaching from secondary process

20/07/2018 17:35, Wiles, Keith: > > On Jul 20, 2018, at 4:15 AM, Thomas Monjalon wrote: > > + /* FIXME: handle replies.nb_received > 1 */ > > I am not a big fan of having TODO or FIXME comments in the code. What don't you like in such comments? > Can we remove them and just describe the probl

Re: [dpdk-dev] [PATCH] devtools: fix checkpatch for filename with space

20/07/2018 20:25, Neil Horman: > On Fri, Jul 20, 2018 at 01:41:03PM +0200, Thomas Monjalon wrote: > > If the patch filename or the temporary file path have a space > > in their name, the script checkpatches.sh does not work. > > The variables for the filenames must be enclosed in quotes > > in orde

[dpdk-dev] [PATCH v3] crypto/qat: add support for 8 byte 3DES

Added extra case to support 8 byte key size for 3DES CBC. Also changed capabilities to reflect the change. Signed-off-by: Marko Kovacevic Signed-off-by: Fiona Trahe --- v3: rebased against QAT refactored code. v2: Fixed implementation (Fiona) drivers/crypto/qat/qat_sym_capabilities.h | 2 +

[dpdk-dev] [PATCH v3 5/6] doc: add Octeonx zip guide

Add Octeontx ZIP PMD feature support and user guide with build and run instructions. Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- MAINTAINERS | 2 + doc/guides/compressdevs/features/octeontx.ini | 10 +++ doc/guides

[dpdk-dev] [PATCH v3 4/6] compress/octeontx: add ops enq deq apis

Add enqueue/dequeue APIs to perform compression/decompression operations Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- drivers/compress/octeontx/otx_zip.c | 49 + drivers/compress/octeontx/otx_zip.h | 169 +++

[dpdk-dev] [PATCH v3 6/6] usertools: update devbind for octeontx zip device

From: Sunila Sahu add the cavium octeontx zip pci device details. Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- usertools/dpdk-devbind.py | 9 + 1 file changed, 9 insertions(+) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.p

[dpdk-dev] [PATCH v3 3/6] compress/octeontx: add xform and stream create support

implement non-shareable private xform for applications to initiate stateless Compression/decompression. Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- drivers/compress/octeontx/otx_zip.h | 19 +++- drivers/compress/octeontx/otx_zip_pmd.c | 149 +

[dpdk-dev] [PATCH v3 2/6] compress/octeontx: add device setup PMD ops

Add compression PMD device and queue pair setup ops. Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- drivers/compress/octeontx/otx_zip.c | 71 + drivers/compress/octeontx/otx_zip.h | 57 ++- drivers/compress/octeontx/otx_zip_pmd.c |

[dpdk-dev] [PATCH v3 1/6] compress/octeontx: add octeontx zip PMD

From: Sunila Sahu Octentx zipvf PMD provides hardware acceleration for deflate and lzs compression and decompression operations using Octeontx zip co-processor, which provide 8 virtualized zip devices. This patch add basic initialization routine to register zip VFs to compressdev library. Signe

[dpdk-dev] [PATCH v3 0/6] compress: add Octeontx ZIP compression PMD

From: Shally Verma This patch series add compression PMD for cavium octeontx ZIP module in DPDK compress drivers. Currently PMD only tested for deflate, stateless compression and decompression with direct memory buffers. Changes in v3: - update doc - add comp feature flags - remove stateful pmd

[dpdk-dev] Bypass support in the i40e PMD driver

Hi, I'm currently working with the PE310G4BPI71 Bypass card from Silicom, Inc., This board is based on the i40E chip (Intel X710 - Fortville). In DPDK, this card makes use of the i40e PMD driver, and I've noticed that bypass configuration is only supported in the IXGBE PMD driver today. Can anyone

Re: [dpdk-dev] [PATCH] devtools: fix checkpatch for filename with space

On Fri, Jul 20, 2018 at 01:41:03PM +0200, Thomas Monjalon wrote: > If the patch filename or the temporary file path have a space > in their name, the script checkpatches.sh does not work. > The variables for the filenames must be enclosed in quotes > in order to preserve spaces. > > Fixes: 4bec481

[dpdk-dev] [PATCH] compress/qat: enable dynamic huffman encoding

Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- config/common_base | 1 + config/rte_config.h | 1 + doc/guides/compressdevs/features/qat.ini | 1 + doc/guides/compressdevs/qat_com

Re: [dpdk-dev] [PATCH] test/compress: limit max number of segments in sgl test

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Friday, July 20, 2018 6:25 PM > To: Trahe, Fiona ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] test/compress: limit max number of segments > in sgl test > > > > > -Original

Re: [dpdk-dev] [PATCH] test/compress: limit max number of segments in sgl test

> -Original Message- > From: Trahe, Fiona > Sent: Thursday, July 19, 2018 6:40 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > > Subject: [PATCH] test/compress: limit max number of segments in sgl test > > Signed-off-by: Fiona Trahe Acked-by: Pablo de Lara

Re: [dpdk-dev] [PATCH 1/2] common/qat: add sgl header

> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, July 17, 2018 6:56 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; Jozwiak, TomaszX > Subject: [PATCH 1/2] common/qat: add sgl header > > This patch refactors the sgl struct so it includes a flexible array

[dpdk-dev] [PATCH v2] examples/ip_pipeline: add help command to cli

Add a help to the existing application cli. This will enable users to display the usage help with descriptions within the cli. Signed-off-by: Kevin Laatz Acked-by: Cristian Dumitrescu --- v2: - removed redundant return - removed trailing whitespace --- examples/ip_pipeline/cli.c | 770

Re: [dpdk-dev] [PATCH] mempool: check for invalid args on creation

On 17.07.2018 13:37, Pablo de Lara wrote: Currently, a mempool can be created if the number of objects is zero or the size of these is zero. In these scenarios, rte_mempool_create should return NULL, as the mempool created is useless. Signed-off-by: Pablo de Lara --- lib/librte_mempool/rte_me

[dpdk-dev] [PATCH] examples/ip_pipeline: add help command to cli

Add a help to the existing application cli. This will enable users to display the usage help with descriptions within the cli. Signed-off-by: Kevin Laatz Acked-by: Cristian Dumitrescu --- examples/ip_pipeline/cli.c | 772 - 1 file changed, 555 inserti

Re: [dpdk-dev] [PATCH v3] net/tap: add queues when attaching from secondary process

> On Jul 20, 2018, at 4:15 AM, Thomas Monjalon wrote: > > From: Raslan Darawsheh > > In the case the device is created by the primary process, > the secondary must request some file descriptors to attach the queues. > The file descriptors are shared via IPC Unix socket. > > Thanks to the IP

Re: [dpdk-dev] [PATCH v2] lib/bitratestats: add NULL sanity checks

On 7/12/2018 11:49 AM, Remy Horton wrote: > If rte_stats_bitrate_reg() or rte_stats_bitrate_calc() are > passed NULL as the parameter for the stats structure, the > result is a crash. Fixed by adding a sanity check that makes > sure the passed-in pointer is not NULL. > > Fixes: 2ad7ba9a6567 ("bitr

Re: [dpdk-dev] [PATCH v1] lib/metrics: add check for invalid metric keys

On 7/6/2018 2:21 PM, Remy Horton wrote: > This patchset adds a check to rte_metrics_update_values() > that prevents the updating of metrics when presented with > an invalid metric key. Previously, doing the latter could > result in a crash. > > Fixes: 349950ddb9c5 ("metrics: add information metric

Re: [dpdk-dev] [PATCH v1] lib/metrics: disallow NULL as metric name

On 7/2/2018 2:46 PM, Remy Horton wrote: > This patch adds a sanity check so that names passed into > rte_metrics_reg_names() and the wrapper rte_metrics_reg_name() > cannot be NULL. > > Fixes: 349950ddb9c5 ("metrics: add information metrics library") > > Signed-off-by: Remy Horton Acked-by: Fer

Re: [dpdk-dev] [PATCH v2] net/softnic: fix memory illegal access

On 7/20/2018 12:05 PM, Jasvinder Singh wrote: > While deleting the elements from the linked list, TAILQ_FOREACH causes > read from the freed pointer. Fixes the issue by using TAILQ_FOREACH_SAFE > instead. > > Coverity issue: 302867 > Fixes: bef50bcb1c47 ("net/softnic: implement start and stop") >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix invalid port id error

On 7/19/2018 6:45 PM, Chas Williams wrote: > This seems fine. The bond PMD seems to call back into itself early. > > On Wed, Jul 18, 2018 at 7:19 AM Radu Nicolau wrote: > >> setting up the bonding options before calling rte_eth_dev_probing_finish >> triggers an invalid port id error because of

[dpdk-dev] [PATCH] test/bonding: don't request CRC STRIP offload

bonding PMD doesn't announce CRC STRIP offload support, don't request this offload in unit test otherwise unit test fails. Fixes: f52f1a65e461 ("ethdev: force offloading API rules") Cc: sta...@dpdk.org Reported-by: Meijuan Zhao Signed-off-by: Ferruh Yigit --- test/test/test_link_bonding.c | 1

[dpdk-dev] [PATCH] eal: fix error message for unsupported platforms

When building with meson on e.g. cygwin, the error message about an unsupported platform referenced an unknown variable since "host_machine" was missing an "_". Fixes: 844514c73569 ("eal: build with meson") Signed-off-by: Bruce Richardson --- lib/librte_eal/meson.build | 2 +- 1 file changed, 1

[dpdk-dev] [PATCH v3] drivers/net: fix segfault in secondary process

Calling rte_eth_dev_info_get() on secondary process cause a crash because eth_dev->device is not set properly. Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process") Cc: sta...@dpdk.org Reported-by: Vipin Varghese Signed-off-by: Ferruh Yigit Reviewed-by: Qi Zhang --- Cc: Ste

[dpdk-dev] [PATCH] build: fix meson build on FreeBSD

A number of drivers have dependencies on libraries which are only built on Linux, and so they need to be disabled on FreeBSD. Rather than basing the disabling on OS, in each case we base the building of the library on the presence of the required dependency. Fixes: 50385c106021 ("net/ifc: add to m

Re: [dpdk-dev] [PATCH v2] drivers/net: fix segfault in secondary process

On 7/20/2018 1:23 PM, Thomas Monjalon wrote: > 20/07/2018 14:44, Ferruh Yigit: >> --- a/drivers/net/tap/rte_eth_tap.c >> +++ b/drivers/net/tap/rte_eth_tap.c >> if (rte_eal_process_type() == RTE_PROC_SECONDARY && >> strlen(params) == 0) { >> -eth_dev = rte_eth_dev_attach_se

[dpdk-dev] [PATCH] build: improve error message for missing dependency

When building a driver or library and a required internal dependency is missing, the error message printed was: Tried to get unknown variable "shared_rte_". However, a better way to handle this is to catch the missing variable earlier and convert it into a proper message, informing the user t

[dpdk-dev] [PATCH] doc: include note for pci address naming in ip pipeline

Add a note to the 'link' command in the IP Pipeline documentation specifying the PCI device name format required to run the application. Signed-off-by: Kevin Laatz --- doc/guides/sample_app_ug/ip_pipeline.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/sample_app_ug/ip_pipelin

Re: [dpdk-dev] [RFC v2] mem: poison memory when freed

On 19-Jul-18 5:20 PM, Stephen Hemminger wrote: DPDK malloc library allows broken programs to work because the semantics of zmalloc and malloc are the same. This patch enables a more secure model which will catch (and crash) programs that reuse memory already freed if RTE_MALLOC_DEBUG is enabled

Re: [dpdk-dev] [PATCH 0/4] couple hotplug fix

12/07/2018 16:01, Qi Zhang: > The patchset fix couple issues that related with hotplug add and hotplug > remove. > > Qi Zhang (4): > eal: fix hotplug add and hotplug remove > bus/pci: fix PCI address compare > bus/pci: enable vfio unmap resource for secondary > vfio: remove uneccessary IPC

Re: [dpdk-dev] [PATCH v2] drivers/net: fix segfault in secondary process

20/07/2018 14:44, Ferruh Yigit: > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > if (rte_eal_process_type() == RTE_PROC_SECONDARY && > strlen(params) == 0) { > - eth_dev = rte_eth_dev_attach_secondary(name); > + eth_dev = rte_eth_

[dpdk-dev] [PATCH v2] drivers/net: fix segfault in secondary process

Calling rte_eth_dev_info_get() on secondary process cause a crash because eth_dev->device is not set properly. Adding a helper function rte_eth_vdev_secondary_probe() that initializes eth_dev fields properly. Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process") Cc: sta...@dpd

[dpdk-dev] [PATCH] devtools: fix checkpatch for filename with space

If the patch filename or the temporary file path have a space in their name, the script checkpatches.sh does not work. The variables for the filenames must be enclosed in quotes in order to preserve spaces. Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") Signed-off-by: Thomas

Re: [dpdk-dev] [PATCH 00/10] kni: Interface detach and link status fixes.

On 6/29/2018 2:54 AM, Dan Gora wrote: > Hi All, > > The following patches are to fix a problem with detaching a KNI > interface using rte_kni_release and to add a new API function > to allow users to change the link status (up/down, speed, etc) > of the interface in the linux kernel. In previous

[dpdk-dev] [PATCH v3] net/tap: add queues when attaching from secondary process

From: Raslan Darawsheh In the case the device is created by the primary process, the secondary must request some file descriptors to attach the queues. The file descriptors are shared via IPC Unix socket. Thanks to the IPC synchronization, the secondary process is now able to do Rx/Tx on a TAP c

[dpdk-dev] [PATCH v2] net/softnic: fix memory illegal access

While deleting the elements from the linked list, TAILQ_FOREACH causes read from the freed pointer. Fixes the issue by using TAILQ_FOREACH_SAFE instead. Coverity issue: 302867 Fixes: bef50bcb1c47 ("net/softnic: implement start and stop") Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitres

[dpdk-dev] [PATCH v2] net/tap: add queues when attaching from secondary process

From: Raslan Darawsheh In the case the device is created by the primary process, the secondary must request some file descriptors to attach the queues. The file descriptors are shared via IPC Unix socket. Thanks to the IPC synchronization, the secondary process is now able to do Rx/Tx on a TAP c

Re: [dpdk-dev] [PATCH] net/softnic: fix memory illegal access

> -Original Message- > From: Van Haaren, Harry > Sent: Friday, July 20, 2018 11:32 AM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: RE: [dpdk-dev] [PATCH] net/softnic: fix memory illegal access > > > -Original Message- > > From: dev [mailto:dev-bou

Re: [dpdk-dev] [PATCH v2 0/5] L2fwd-crypto fixes

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Friday, July 20, 2018 11:41 AM > To: Trahe, Fiona ; Doherty, Declan > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 0/5] L2fwd-crypto fixes > > Hi Fiona, > > > -Origi

Re: [dpdk-dev] [PATCH v2 0/5] L2fwd-crypto fixes

Hi Fiona, > -Original Message- > From: Trahe, Fiona > Sent: Friday, July 20, 2018 10:02 AM > To: De Lara Guarch, Pablo ; Doherty, Declan > > Cc: dev@dpdk.org; Trahe, Fiona > Subject: RE: [PATCH v2 0/5] L2fwd-crypto fixes > > Hi Pablo, > > > -Original Message- > > From: De Lara

Re: [dpdk-dev] [PATCH v2] compress/isal: add chained mbuf support

Hi Lee, > -Original Message- > From: Daly, Lee > Sent: Wednesday, July 11, 2018 1:40 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Daly, Lee > Subject: [PATCH v2] compress/isal: add chained mbuf support > > This patch adds chained mbuf support for input or output buffers during > c

Re: [dpdk-dev] [PATCH] net/softnic: fix memory illegal access

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Friday, July 20, 2018 10:45 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [dpdk-dev] [PATCH] net/softnic: fix memory illegal access > > While deleting the elements from the li

Re: [dpdk-dev] [PATCH] net/softnic: fix memory illegal access

On Fri, Jul 20, 2018 at 10:44:39AM +0100, Jasvinder Singh wrote: > While deleting the elements from the linked list, TAILQ_FOREACH causes > read from the freed pointer. Fixes the issue by using for loop instead > of TAILQ_FOREACH. > > Coverity issue: 302867 > Fixes: bef50bcb1c47 ("net/softnic: imp

Re: [dpdk-dev] [PATCH] drivers/net: fix segfault in secondary process

On 7/19/2018 5:32 PM, Stephen Hemminger wrote: > On Thu, 19 Jul 2018 17:45:56 +0100 > Ferruh Yigit wrote: > >> Calling rte_eth_dev_info_get() on secondary process cause a crash >> because eth_dev->device is not set properly. >> >> Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary pr

[dpdk-dev] [PATCH] net/bonding: set started flag at the end of dev start

Race condition can appear in the bond_mode_8023ad_periodic_cb() callback when bonding port is stopped, reconfigured and restarted. Fixes: 2efb58cbab6e ("bond: new link bonding library") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/net/bonding/rte_eth_bond_pmd.c | 3 +-- 1 file ch

[dpdk-dev] [PATCH] net/softnic: fix memory illegal access

While deleting the elements from the linked list, TAILQ_FOREACH causes read from the freed pointer. Fixes the issue by using for loop instead of TAILQ_FOREACH. Coverity issue: 302867 Fixes: bef50bcb1c47 ("net/softnic: implement start and stop") Signed-off-by: Jasvinder Singh Acked-by: Cristian D

Re: [dpdk-dev] [PATCH v2] devtools: fix symbol check for filename with space

19/07/2018 17:37, Neil Horman: > On Thu, Jul 19, 2018 at 02:09:47PM +0200, Thomas Monjalon wrote: > > 19/07/2018 13:14, Neil Horman: > > > On Wed, Jul 18, 2018 at 11:26:58PM +0200, Thomas Monjalon wrote: > > > > If the patch filename or the temporary file path have a space > > > > in their name, th

Re: [dpdk-dev] [PATCH] mem: fix static analysis warning

17/07/2018 17:41, Anatoly Burakov: > Technically, single file segments codepath will never get > triggered when using in-memory mode, because EAL prohibits > mixing these two options at initialization time. However, > code analyzers do not know that, and some will complain > about either using unin

Re: [dpdk-dev] [PATCH] malloc: don't skip pad on free

19/07/2018 18:37, Andrew Rybchenko: > On 19.07.2018 12:42, Anatoly Burakov wrote: > > Previously, we were skipping erasing pad because we were > > expecting it to be freed when we were merging adjacent > > segments. However, if there were no adjacent segments to > > merge, we would've skipped erasi

Re: [dpdk-dev] [PATCH] devargs: fix devargs truncation when format string is used

18/07/2018 10:42, Gaëtan Rivet: > Hi, > > On Wed, Jul 18, 2018 at 08:23:30AM +0100, Andrew Rybchenko wrote: > > Space for string terminating NUL character should be provided to > > snprintf() to avoid the last symbol truncation. > > > > Fixes: a23bc2c4e01b ("devargs: add non-variadic parsing func

Re: [dpdk-dev] [PATCH v2 0/5] L2fwd-crypto fixes

Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, July 19, 2018 9:40 AM > To: Doherty, Declan ; Trahe, Fiona > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v2 0/5] L2fwd-crypto fixes > > v2 changes: > - Split patch into multiple patches for b

Re: [dpdk-dev] [PATCH 0/3] net/sfc: improve Rx checksumming support

On 7/15/2018 10:56 AM, Andrew Rybchenko wrote: > Andrew Rybchenko (3): > net/sfc: move Rx checksum offload check to device level > net/sfc: fix Rx queue offloads reporting in queue info > net/sfc: prepare to support Rx datapath without checksum Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 0/3] net/sfc: improve Rx checksumming support

On 7/19/2018 5:28 PM, Andrew Rybchenko wrote: > On 19.07.2018 19:07, Andrew Rybchenko wrote: >> On 19.07.2018 13:56, Ferruh Yigit wrote: >>> On 7/15/2018 10:56 AM, Andrew Rybchenko wrote: Andrew Rybchenko (3):    net/sfc: move Rx checksum offload check to device level    net/sfc: fix

Re: [dpdk-dev] [PATCH v2 4/5] examples/l2fwd-crypto: fix session mempool size

Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, July 19, 2018 9:40 AM > To: Doherty, Declan ; Trahe, Fiona > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v2 4/5] examples/l2fwd-crypto: fix session mempool size > > The session mempool size f

[dpdk-dev] [PATCH v5] vfio: fix workaround of BAR mapping

Currently, VFIO will try to map around MSI-X table in the BARs. When MSI-X table (page-aligned) size is equal to (page-aligned) size of BAR, VFIO will just skip the BAR. Recent kernel versions will allow VFIO to map the entire BAR containing MSI-X tables (*), so instead of trying to map around the