19/07/2018 17:37, Neil Horman:
> On Thu, Jul 19, 2018 at 02:09:47PM +0200, Thomas Monjalon wrote:
> > 19/07/2018 13:14, Neil Horman:
> > > On Wed, Jul 18, 2018 at 11:26:58PM +0200, Thomas Monjalon wrote:
> > > > If the patch filename or the temporary file path have a space
> > > > in their name, the script check-symbol-change.sh does not work.
> > > > The variables for the filenames must be enclosed in quotes
> > > > in order to preserve spaces.
> > > >
> > > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
> > > > Cc: nhor...@tuxdriver.com
> > > >
> > > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
> > > > ---
> > > > v2: one occurence of "$mapfile" was missed in v1
> > > I don't have any issue with this change, but the only way I see to
> > > introduce a
> > > space into the tempfile name is to set $TMPDIR to '/path/with silly
> > > spaces' or
> > > something simmilar. I think we discussed this before, but it would
> > > alsmot make
> > > sense to, instead of quoting everything, instead specify -p ./ to ensure
> > > the
> > > tempfile has no spaces.
> >
> > When I save patches from my inbox, the filename has some spaces.
> >
> > I think quoting variables is mandatory.
> >
> >
> Sure, it doesn't hurt anything really
>
> Acked-by: Neil Horman <nhor...@tuxdriver.com>
Applied
