Re: [dpdk-dev] [PATCH v11 07/25] eal: introduce device class abstraction

2018-07-13 Thread Thomas Monjalon
Hi, Some doxygen parameters must be fixed. See below: 11/07/2018 23:44, Gaetan Rivet: > +/** > + * Register a Class handle. > + * > + * @param > + * A pointer to a rte_class structure describing the class > + * to be registered. > + */ > +__rte_experimental > +void rte_class_register(struct r

[dpdk-dev] Questions about locating the rte_mbuf payload

2018-07-13 Thread Sungho Hong
Hello I have sent the packet with the data "hellohellohello*" in a message struct using DPDK struct message{ data[PKT_SIZE] } I am sending this data from a client to server, and the server receives this data. the data received in the server can be viewed from the packet dump provided

Re: [dpdk-dev] [PATCH] net/enic: pick the right Rx handler after changing MTU

2018-07-13 Thread Hyong Youb Kim
Hi Ferruh, Please ignore this patch, as it never assigns the default handler to rx_pkt_burst. We will send a v2. Sorry about that. On Fri, Jul 13, 2018 at 05:54:52PM -0700, John Daley wrote: > From: Hyong Youb Kim > > enic_set_mtu always reverts to the default Rx handler after changing > MTU. T

[dpdk-dev] [PATCH v2] net/qede: move SPDX tags to source files

2018-07-13 Thread Rasesh Mody
We were using LICENSE.qede_pmd to reference inclusion of SPDX licensing tag from all the source file. Remove the LICENSE.qede_pmd file and directly include SPDX tags in source files. Signed-off-by: Rasesh Mody --- drivers/net/qede/LICENSE.qede_pmd |3 --- drivers/net/qede/Makefil

[dpdk-dev] [PATCH v2] net/bnx2x: move SPDX tags to source files

2018-07-13 Thread Rasesh Mody
We were using LICENSE.bnx2x_pmd to reference inclusion of SPDX licensing tag from all the source file. Remove the LICENSE.bnx2x_pmd file and directly include SPDX tags in source files. Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/LICENSE.bnx2x_pmd |3 --- drivers/net/bnx2x/Makefile

Re: [dpdk-dev] [PATCH v2 1/6] net/mlx5: lay groundwork for switch offloads

2018-07-13 Thread Yongseok Koh
On Jul 13, 2018, at 6:27 PM, Adrien Mazarguil mailto:adrien.mazarg...@6wind.com>> wrote: With mlx5, unlike normal flow rules implemented through Verbs for traffic emitted and received by the application, those targeting different logical ports of the device (VF representors for instance) are off

[dpdk-dev] [PATCH] net/enic: pick the right Rx handler after changing MTU

2018-07-13 Thread John Daley
From: Hyong Youb Kim enic_set_mtu always reverts to the default Rx handler after changing MTU. Try to use the simpler, non-scatter handler in this case as well. Fixes: 1187012c1ede ("net/enic: add simple Rx handler") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/

Re: [dpdk-dev] [PATCH v2 5/6] doc: add Octeonx zip guide

2018-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Monday, July 2, 2018 5:55 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > mcha...@caviumnetworks.com; Ashish Gupta > ; Sunila Sahu > > Subject: [PATCH v2 5/6] do

Re: [dpdk-dev] [PATCH v2 3/6] compress/octeontx: add xform and stream create support

2018-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Monday, July 2, 2018 5:55 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > mcha...@caviumnetworks.com; Ashish Gupta > ; Ashish Gupta > ; Sunila Sahu > > Subject:

Re: [dpdk-dev] [PATCH v2 2/6] compress/octeontx: add device setup PMD ops

2018-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Monday, July 2, 2018 5:55 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > mcha...@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subject: [PATCH v2 2/6] co

Re: [dpdk-dev] [PATCH v2] ethdev: check queue stats mapping input arguments

2018-07-13 Thread Thomas Monjalon
11/07/2018 10:41, Kiran Kumar: > With current implementation, we are not checking for queue_id range > and stat_idx range in stats mapping function. This patch will add > check for queue_id and stat_idx range. > > Fixes: 5de201df892 ("ethdev: add stats per queue") > > Signed-off-by: Kiran Kumar

Re: [dpdk-dev] [PATCH v12 0/4] Hyper-V netvsc PMD and VMBus

2018-07-13 Thread Thomas Monjalon
13/07/2018 19:06, Stephen Hemminger: > Final version of the Hyper-V native bus (VMBus) > and network device (netvsc) drivers. This virtual device > is used in Microsoft Hyper-V in Windows 10, Windows Server 2016 > and Azure. Most of this code was extracted from FreeBSD and some of > this is from ea

Re: [dpdk-dev] [PATCH] hash: validate hash bucket entries while compiling

2018-07-13 Thread Thomas Monjalon
13/07/2018 22:20, Honnappa Nagarahalli: > Hi Pablo, > Thank you for your response. I recently noticed this macro > 'RTE_BUILD_BUG_ON'. Does it make sense to use this macro instead (though the > error message will be more cryptic)? Yes, I've hesitated to suggest RTE_BUILD_BUG_ON, but decided to p

Re: [dpdk-dev] [PATCH v12 3/4] net/netvsc: add hyper-v netvsc network device

2018-07-13 Thread Thomas Monjalon
For information, some cleanup done before pushing: --- a/MAINTAINERS +++ b/MAINTAINERS -F: drivers/net/hyperv/ +F: drivers/net/netvsc/ Unknown symbol: --- a/drivers/bus/vmbus/rte_bus_vmbus_version.map +++ b/drivers/bus/vmbus/rte_bus_vmbus_version.map @@ -17,7 +17,6 @@ DPDK_18.08 { rte_

Re: [dpdk-dev] [PATCH v2 1/4] mbuf: add accessor function for private data area

2018-07-13 Thread Thomas Monjalon
26/06/2018 09:39, Olivier Matz: > Hi Dan, > > On Mon, Jun 18, 2018 at 04:35:34PM -0700, Dan Gora wrote: > > Add an inline accessor function to return the starting address of > > the private data area in the supplied mbuf. > > > > This allows applications to easily access the private data area bet

Re: [dpdk-dev] [PATCH v2 2/4] examples/ipsec-secgw: use rte fcn to access private area

2018-07-13 Thread Thomas Monjalon
19/06/2018 01:36, Dan Gora: > Update get_priv() to use rte_mbuf_to_priv() to access the private > area in the mbuf. > > Signed-off-by: Dan Gora > --- > - return RTE_PTR_ADD(m, sizeof(struct rte_mbuf)); > + return (ipsec_mbuf_metadata *)rte_mbuf_to_priv(m); The cast is wrong (struct is mi

Re: [dpdk-dev] [PATCH] hash: validate hash bucket entries while compiling

2018-07-13 Thread Honnappa Nagarahalli
Hi Pablo, Thank you for your response. I recently noticed this macro 'RTE_BUILD_BUG_ON'. Does it make sense to use this macro instead (though the error message will be more cryptic)? Thank you, Honnappa -Original Message- From: De Lara Guarch, Pablo Sent: Thursday, July 12, 2018 3:05 A

Re: [dpdk-dev] [RFC 00/11] Support externally allocated memory in DPDK

2018-07-13 Thread Wiles, Keith
> On Jul 13, 2018, at 12:10 PM, Burakov, Anatoly > wrote: > > On 06-Jul-18 2:17 PM, Anatoly Burakov wrote: >> This is a proposal to enable using externally allocated memory >> in DPDK. >> In a nutshell, here is what is being done here: >> - Index malloc heaps by NUMA node index, rather than NU

Re: [dpdk-dev] [PATCH] app/eventdev: fix order test service init

2018-07-13 Thread Eads, Gage
> -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Friday, July 13, 2018 3:51 AM > To: jerin.ja...@caviumnetworks.com; Eads, Gage > Cc: dev@dpdk.org; sta...@dpdk.org; Pavan Nikhilesh > > Subject: [dpdk-dev] [PATCH] app/eventdev: fix order test

Re: [dpdk-dev] [PATCH v3] eal/service: improve error checking of coremasks

2018-07-13 Thread Varghese, Vipin
Thanks for the change in log level Acked-by: Vipin Varghese > -Original Message- > From: Van Haaren, Harry > Sent: Friday, July 13, 2018 10:56 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; > tho...@monjalon.net; Varghese, Vipin > Subject: [PATCH v3] eal/service: improve error checking

Re: [dpdk-dev] [PATCH v3] eal/service: improve error checking of coremasks

2018-07-13 Thread Thomas Monjalon
13/07/2018 19:25, Harry van Haaren: > v3: > - Use WARNING instead of ERR log level (Vipin) > - Put strings on one line for grep-ability (Harry) We can consider it is OK to have sentences on different lines. Who is grepping 2 sentences at once? > v2, thanks for review: > - Consistency in message e

Re: [dpdk-dev] [PATCH v2] eal/service: improve error checking of coremasks

2018-07-13 Thread Van Haaren, Harry
Hi Thomas, I've sent a v3 for this patch. Twice actually, including dev@dpdk.org the 2nd time :) Thanks for the ping, -Harry > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, July 12, 2018 8:35 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Va

[dpdk-dev] [PATCH v3] eal/service: improve error checking of coremasks

2018-07-13 Thread Harry van Haaren
This commit improves the error checking performed on the core masks (or lists) of the service cores, in particular with respect to the data-plane (RTE) cores of DPDK. With this commit, invalid configurations are detected at runtime, and warning messages are printed to inform the user. For example

Re: [dpdk-dev] [RFC 0/1] A Distributed Software Event Device

2018-07-13 Thread Mattias Rönnblom
On 2018-07-12 22:39, Wiles, Keith wrote: On Jul 11, 2018, at 4:21 PM, Mattias Rönnblom wrote: This is the Distributed Software (DSW) event device, which distributes the task of scheduling events among all the eventdev ports and their lcore threads. DSW is primarily designed for atomic-only

Re: [dpdk-dev] [RFC 00/11] Support externally allocated memory in DPDK

2018-07-13 Thread Burakov, Anatoly
On 06-Jul-18 2:17 PM, Anatoly Burakov wrote: This is a proposal to enable using externally allocated memory in DPDK. In a nutshell, here is what is being done here: - Index malloc heaps by NUMA node index, rather than NUMA node itself - Add identifier string to malloc heap, to uniquely identify

[dpdk-dev] [PATCH v12 3/4] net/netvsc: add hyper-v netvsc network device

2018-07-13 Thread Stephen Hemminger
The driver supports Hyper-V networking directly like virtio for KVM or vmxnet3 for VMware. This code is based off of the FreeBSD driver. The file and variable names are kept the same to help with understanding (with most of the BSD style warts removed). This version supports the latest NetVSP 6.1

[dpdk-dev] [PATCH v12 4/4] net/netvsc: add documentation

2018-07-13 Thread Stephen Hemminger
From: Stephen Hemminger Matching documentation for new netvsc device. Includes a brief note about the restart issue. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/netvsc.ini| 23 ++ doc/guides/nics/index.rst | 1 + doc/guides/nics/netvsc.rst

[dpdk-dev] [PATCH v12 2/4] bus/vmbus: add hyper-v virtual bus support

2018-07-13 Thread Stephen Hemminger
This patch adds support for an additional bus type Virtual Machine BUS (VMBUS) on Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Only Linux is supported at present, but the code

[dpdk-dev] [PATCH v12 1/4] eal: add rte_uuid support

2018-07-13 Thread Stephen Hemminger
Since uuid functions may not be available everywhere, implement uuid functions in DPDK. These are based off the BSD licensed libuuid in util-link. Signed-off-by: Stephen Hemminger --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/common/Makefile | 2 +- lib/librte_

[dpdk-dev] [PATCH v12 0/4] Hyper-V netvsc PMD and VMBus

2018-07-13 Thread Stephen Hemminger
Final version of the Hyper-V native bus (VMBus) and network device (netvsc) drivers. This virtual device is used in Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Only Linux is s

Re: [dpdk-dev] [RFC 08/11] malloc: allow adding memory to named heaps

2018-07-13 Thread Alejandro Lucero
On Fri, Jul 6, 2018 at 2:17 PM, Anatoly Burakov wrote: > Add an API to add externally allocated memory to malloc heap. The > memory will be stored in memseg lists like regular DPDK memory. > Multiple segments are allowed within a heap. If IOVA table is > not provided, IOVA addresses are filled in

Re: [dpdk-dev] [PATCH v2 09/10] autotest: update result for skipped test cases

2018-07-13 Thread Burakov, Anatoly
On 13-Jul-18 5:20 PM, Reshma Pattan wrote: Fixed in autotest_test_funcs.py to handle test cases which returns "Skipped" as result. The issue was skipped test cases got timed out, causing delay in autotests execution. Cc: sta...@dpdk.org Signed-off-by: Jananee Parthasarathy Signed-off-by: Reshm

Re: [dpdk-dev] [PATCH v2 08/10] autotest: add new test cases to autotest

2018-07-13 Thread Burakov, Anatoly
On 13-Jul-18 5:20 PM, Reshma Pattan wrote: Autotest is enhanced with additional test cases being added to autotest_data.py You're also removing PCI autotest - commit message needs to call this out as well. Cc: sta...@dpdk.org Signed-off-by: Reshma Pattan Signed-off-by: Jananee Parthasara

Re: [dpdk-dev] [RFC 06/11] malloc: enable allocating from named heaps

2018-07-13 Thread Alejandro Lucero
On Fri, Jul 6, 2018 at 2:17 PM, Anatoly Burakov wrote: > Add new malloc API to allocate memory from heap referenced to by > specified name. > > Signed-off-by: Anatoly Burakov > --- > lib/librte_eal/common/include/rte_malloc.h | 25 ++ > lib/librte_eal/common/malloc_heap.c

Re: [dpdk-dev] [RFC 05/11] malloc: enable retrieving statistics from named heaps

2018-07-13 Thread Alejandro Lucero
On Fri, Jul 6, 2018 at 2:17 PM, Anatoly Burakov wrote: > Add internal functions to look up heap by name, and enable > dumping statistics for a specified named heap. > > Signed-off-by: Anatoly Burakov > --- > lib/librte_eal/common/include/rte_malloc.h | 19 +++-- > lib/librte_eal/common/

Re: [dpdk-dev] [PATCH v2 1/6] compress/octeontx: add octeontx zip PMD support

2018-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Monday, July 2, 2018 5:55 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > mcha...@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subject: [PATCH v2 1/6] co

[dpdk-dev] [PATCH v2 10/10] mk: update make targets for classified testcases

2018-07-13 Thread Reshma Pattan
Makefiles are updated with new test case lists. Test cases are classified as - P1 - Main test cases, P2 - Cryptodev/driver test cases, P3 - Perf test cases which takes longer than 10s, P4 - Logging/Dump test cases. Makefile is updated with different targets for the above classified groups. Test ca

[dpdk-dev] [PATCH v2 09/10] autotest: update result for skipped test cases

2018-07-13 Thread Reshma Pattan
Fixed in autotest_test_funcs.py to handle test cases which returns "Skipped" as result. The issue was skipped test cases got timed out, causing delay in autotests execution. Cc: sta...@dpdk.org Signed-off-by: Jananee Parthasarathy Signed-off-by: Reshma Pattan --- test/test/autotest_test_funcs.

[dpdk-dev] [PATCH v2 08/10] autotest: add new test cases to autotest

2018-07-13 Thread Reshma Pattan
Autotest is enhanced with additional test cases being added to autotest_data.py Cc: sta...@dpdk.org Signed-off-by: Reshma Pattan Signed-off-by: Jananee Parthasarathy --- test/test/autotest_data.py | 370 - 1 file changed, 362 insertions(+), 8 deletio

[dpdk-dev] [PATCH v2 06/10] autotest: remove autotest grouping

2018-07-13 Thread Reshma Pattan
Previously, all autotests were grouped into (seemingly arbitrary) groups. The goal was to run all tests in parallel (so that autotest finishes faster), but we couldn't just do it willy-nilly because DPDK couldn't allocate and free hugepages on-demand, so we had to find autotest groupings that could

[dpdk-dev] [PATCH v2 05/10] autotest: improve filtering

2018-07-13 Thread Reshma Pattan
Improve code for filtering test groups. Also, move reading binary symbols into filtering stage, so that tests that are meant to be skipped are never attempted to be executed in the first place. Before running tests, print out any tests that were skipped because they weren't compiled. Cc: sta...@dp

[dpdk-dev] [PATCH v2 04/10] autotest: visually separate different test categories

2018-07-13 Thread Reshma Pattan
Help visually identify parallel vs. non-parallel autotests. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/autotest_runner.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py index f6b669a2e..d9d5f7a97 100644 ---

[dpdk-dev] [PATCH v2 02/10] autotest: fix invalid code on reports

2018-07-13 Thread Reshma Pattan
There are no reports defined for any test, so this codepath was never triggered, but it's still wrong because it's referencing variables that aren't there. Fix it by passing target into the test function, and reference correct log variable. Fixes: e2cc79b75d9f ("app: rework autotest.py") Cc: sta..

[dpdk-dev] [PATCH v2 07/10] autotest: properly parallelize unit tests

2018-07-13 Thread Reshma Pattan
Now that everything else is in place, we can run unit tests in a different fashion to what they were running as before. Previously, we had all autotests as part of groups (largely obtained through trial and error) to ensure parallel execution while still limiting amounts of memory used by those tes

[dpdk-dev] [PATCH v2 01/10] autotest: fix printing

2018-07-13 Thread Reshma Pattan
Previously, printing was done using tuple syntax, which caused output to appear as a tuple as opposed to being one string. Fix this by using addition operator instead. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: An

[dpdk-dev] [PATCH v2 00/10] Make unit tests great again

2018-07-13 Thread Reshma Pattan
Previously, unit tests were running in groups. There were technical reasons why that was the case (mostly having to do with limiting memory), but it was hard to maintain and update the autotest script. In 18.05, limiting of memory at DPDK startup was no longer necessary, as DPDK allocates memor

[dpdk-dev] [PATCH v2 03/10] autotest: make autotest runner python 2/3 compliant

2018-07-13 Thread Reshma Pattan
Autotest runner was still using python 2-style print syntax. Fix it by importing print function from the future, and fix the calls to be python-3 style. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov

Re: [dpdk-dev] [PATCH v2] test/power: fix 32-bit build

2018-07-13 Thread Thomas Monjalon
13/07/2018 06:51, Pablo de Lara: > Compilation issue: > > test/test/test_power_acpi_cpufreq.c:556:31: > error: format ‘%lx’ expects argument of type ‘long unsigned int’, > but argument 2 has type ‘uint64_t {aka long long unsigned int}’ > -Werror=format=] > > printf("ACPI: Capabilities %lx\n", c

Re: [dpdk-dev] [RFC 04/11] malloc: add name to malloc heaps

2018-07-13 Thread Alejandro Lucero
On Fri, Jul 6, 2018 at 2:17 PM, Anatoly Burakov wrote: > We will need to refer to external heaps in some way. While we use > heap ID's internally, for external API use it has to be something > more user-friendly. So, we will be using a string to uniquely > identify a heap. > > Signed-off-by: Anat

Re: [dpdk-dev] [RFC 03/11] malloc: index heaps using heap ID rather than NUMA node

2018-07-13 Thread Burakov, Anatoly
On 13-Jul-18 5:05 PM, Alejandro Lucero wrote: - /* get pointer to global configuration */ - mcfg = rte_eal_get_configuration()->mem_config; - - for (i = 0; i < RTE_MAX_NUMA_NODES; i++) { - if ((socket != SOCKET_ID_ANY) && (socket != i)) + for (idx = 0; idx <

Re: [dpdk-dev] [RFC 03/11] malloc: index heaps using heap ID rather than NUMA node

2018-07-13 Thread Alejandro Lucero
On Fri, Jul 6, 2018 at 2:17 PM, Anatoly Burakov wrote: > Switch over all parts of EAL to use heap ID instead of NUMA node > ID to identify heaps. Heap ID for DPDK-internal heaps is NUMA > node's index within the detected NUMA node list. > > Signed-off-by: Anatoly Burakov > --- > config/common_b

Re: [dpdk-dev] [PATCH v2 1/5] compress/zlib: add ZLIB PMD support

2018-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Wednesday, July 11, 2018 1:41 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Athreya, Narayana Prasad > ; Challa, Mahipal > ; Gupta, Ashish ; > Sahu, Sunila > Subject: RE: [PATCH v2 1/5] compress/zl

Re: [dpdk-dev] [PATCH v2 4/5] compress/zlib: add enq deq apis

2018-07-13 Thread De Lara Guarch, Pablo
Hi Shally, Sorry for the delay. Comments inline. > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Thursday, July 12, 2018 6:46 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Athreya, Narayana Prasad > ; Challa, Mahipal > ; Sahu, Sunila ; Sahu, > Sun

Re: [dpdk-dev] warnings when including DPDK headers from a C++17 source file

2018-07-13 Thread Stephen Hemminger
On Fri, 13 Jul 2018 13:51:21 + "Montorsi, Francesco" wrote: > Hi all, > > > I just noticed that, because of the removal of the "register" keyword in > C++17, when I compile my DPDK-enabled code with -std=c++17 I get the > following: > > > > In file included from > ../../../Third-Party

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix incorrect IPv4 checksum at TX

2018-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Radu Nicolau > Sent: Wednesday, June 6, 2018 2:33 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix incorrect IPv4 > checksum at TX > > > On 6/6/2018 1:04 PM

Re: [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name

2018-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Daly, Lee > Sent: Wednesday, July 11, 2018 5:15 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH 1/3] compress/isal: fix logtype name > > > > > -Original Message- > > From: De Lara Guarch, Pablo > > Sent: We

Re: [dpdk-dev] [PATCH v2] compress/isal: fix offset usage

2018-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Friday, July 13, 2018 3:20 PM > To: Daly, Lee > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH v2] compress/isal: fix offset usage > > > > > -O

Re: [dpdk-dev] [PATCH v2] crypto/qat: fix checks for 3gpp algo bit params

2018-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Friday, July 13, 2018 3:15 PM > To: Trahe, Fiona ; dev@dpdk.org; > dmitry.ereminsoleni...@linaro.org > Subject: Re: [dpdk-dev] [PATCH v2] crypto/qat: fix checks for 3gpp algo bit > p

Re: [dpdk-dev] [PATCH] test/compress: add trace with device name

2018-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Friday, July 13, 2018 3:18 PM > To: Trahe, Fiona ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] test/compress: add trace with device name > > > > > -Original Message- >

[dpdk-dev] [PATCH v4 9/9] examples/vm_power: make branch ratio configurable

2018-07-13 Thread David Hunt
For different workloads and poll loops, the theshold may be different for when you want to scale up and down. This patch allows changing of the default branch ratio by using the -b command line argument (or --branch-ratio=) Signed-off-by: David Hunt Acked-by: Radu Nicolau --- examples/vm_power

[dpdk-dev] [PATCH v4 7/9] examples/vm_power: add branch ratio policy type

2018-07-13 Thread David Hunt
Add the capability for the vm_power_manager to receive a policy of type BRANCH_RATIO. This will add any vcpus in the policy to the oob monitoring thread. Signed-off-by: David Hunt Acked-by: Radu Nicolau --- examples/vm_power_manager/channel_monitor.c | 23 +++-- lib/librte_power

[dpdk-dev] [PATCH v4 8/9] examples/vm_power: add cli args to guest app

2018-07-13 Thread David Hunt
Add new command line arguments to the guest app to make testing and validation of the policy usage easier. These arguments are mainly around setting up the power management policy that is sent from the guest vm to to the vm_power_manager in the host New command line parameters:

[dpdk-dev] [PATCH v4 6/9] examples/vm_power: add port-list to command line

2018-07-13 Thread David Hunt
add in the long form of -p, which is --port-list Signed-off-by: David Hunt Acked-by: Radu Nicolau --- examples/vm_power_manager/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c index aef97b9ae..f9990f153 100644 --- a/

[dpdk-dev] [PATCH v4 5/9] examples/vm_power: add thread for oob core monitor

2018-07-13 Thread David Hunt
Change the app to now require three cores, as the third core will be used to run the oob montoring thread. Signed-off-by: David Hunt Acked-by: Radu Nicolau --- examples/vm_power_manager/main.c | 37 +--- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/

[dpdk-dev] [PATCH v4 4/9] examples/vm_power: allow greater than 64 cores

2018-07-13 Thread David Hunt
To facilitate more info per core, change the global_cpu_mask from a uint64_t to an array. This also removes the limit on 64 cores, allocing the aray at run-time based on the number of cores found in the system. Signed-off-by: David Hunt Acked-by: Radu Nicolau --- examples/vm_power_manager/power

[dpdk-dev] [PATCH v4 3/9] examples/vm_power: add oob monitoring functions

2018-07-13 Thread David Hunt
This patch introduces the out-of-band (oob) core monitoring functions. The functions are similar to the channel manager functions. There are function to add and remove cores from the list of cores being monitored. There is a function to initialise the monitor setup, run the monitor thread, and exi

[dpdk-dev] [PATCH v4 2/9] examples/vm_power: add core list parameter

2018-07-13 Thread David Hunt
Add in the '-l' command line parameter (also --core-list) So the user can now pass --corelist=4,6,8-10 and it will expand out to 4,6,8,9,10 using the parse function provided in parse.c (parse_set). This list of cores is then used to enable out-of-band monitoring to scale up and down these cores ba

[dpdk-dev] [PATCH v4 1/9] examples/vm_power: add check for port count

2018-07-13 Thread David Hunt
If we don't pass any ports to the app, we don't need to create any mempools, and we don't need to init any ports. Signed-off-by: David Hunt Acked-by: Radu Nicolau --- examples/vm_power_manager/main.c | 81 +--- 1 file changed, 43 insertions(+), 38 deletions(-) diff

[dpdk-dev] [PATCH v4 0/9] examples/vm_power: 100% Busy Polling

2018-07-13 Thread David Hunt
This patch set adds the capability to do out-of-band power monitoring on a system. It uses a thread to monitor the branch counters in the targeted cores, and calculates the branch ratio if the running code. If the branch ratio is low (0.01), then the code is most likely running in a tight poll loo

Re: [dpdk-dev] [PATCH v7 00/16] compress/qat: add compression PMD

2018-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Friday, July 13, 2018 3:28 AM > To: Trahe, Fiona ; Jozwiak, TomaszX > ; Griffin, John ; Jain, > Deepak K > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v7 00/16] compress/qat: add compression PMD > > Create compre

Re: [dpdk-dev] [PATCH v2] compress/isal: fix offset usage

2018-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Daly, Lee > Sent: Wednesday, July 11, 2018 3:22 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Daly, Lee ; sta...@dpdk.org > Subject: [PATCH v2] compress/isal: fix offset usage > > This patch allows the ISA-L compression PMD, to be used with offsets in

Re: [dpdk-dev] [PATCH] test/compress: add trace with device name

2018-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, July 10, 2018 12:07 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > > Subject: [PATCH] test/compress: add trace with device name > > Print out name of device on which test is running at start of test suite. >

Re: [dpdk-dev] [PATCH] net/thunderx: add support for Rx VLAN offload

2018-07-13 Thread rkudurumalla
On 07/04/2018 11:06 PM, Ferruh Yigit wrote: > External Email > > On 7/1/2018 5:46 PM, Pavan Nikhilesh wrote: >> From: "Kudurumalla, Rakesh" >> >> This feature is used to offload stripping of vlan header from recevied >> packets and update vlan_tci field in mbuf when >> DEV_RX_OFFLOAD_VLAN_STRI

Re: [dpdk-dev] [PATCH v2] crypto/qat: fix checks for 3gpp algo bit params

2018-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Wednesday, July 11, 2018 7:03 PM > To: dev@dpdk.org; dmitry.ereminsoleni...@linaro.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > > Subject: [PATCH v2] crypto/qat: fix checks for 3gpp algo bit params > > QAT driver checks byte alignme

Re: [dpdk-dev] [PATCH] ethdev: fix missing function in map file

2018-07-13 Thread Thomas Monjalon
13/07/2018 11:11, Nelio Laranjeiro: > Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows") > > Signed-off-by: Nelio Laranjeiro > Acked-by: Adrien Mazarguil > > -- > > Changes in v2: > > - add missing documentation. > - add missing __rte_experimental in source file. > - update the

[dpdk-dev] [PATCH] net/mlx5: fix representors detection

2018-07-13 Thread Nelio Laranjeiro
On systems where the required Netlink commands are not supported but Mellanox OFED is installed, representors information must be retrieved through sysfs. Fixes: 4c10141488fe ("net/mlx5: add port representor awareness") Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net

[dpdk-dev] warnings when including DPDK headers from a C++17 source file

2018-07-13 Thread Montorsi, Francesco
Hi all, I just noticed that, because of the removal of the "register" keyword in C++17, when I compile my DPDK-enabled code with -std=c++17 I get the following: In file included from ../../../Third-Party/cpp-libs/dpdk/include/rte_ether.h:53:0, from ../../../Third-Party/cpp-

Re: [dpdk-dev] [PATCH v3 0/8] Support running DPDK without hugetlbfs mountpoint

2018-07-13 Thread Thomas Monjalon
> Anatoly Burakov (8): > fbarray: support no-shconf mode > ipc: add support for no-shconf mode > eal: add support for no-shconf for hugepage info > eal: add support for no-shconf in hugepage data file > eal: do not create runtime dir in no-shconf mode > mem: add support for hugepage-unl

[dpdk-dev] [PATCH] doc: fix lists in release notes

2018-07-13 Thread Thomas Monjalon
Some blank lines and hyphens are missing, so lists were badly interpreted and rendered. Signed-off-by: Thomas Monjalon --- Already applied. --- doc/guides/rel_notes/release_18_08.rst | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/doc/guides/rel_notes/release_18

Re: [dpdk-dev] [PATCH] qat: fix checks for 3gpp algorithms vs bit mode

2018-07-13 Thread De Lara Guarch, Pablo
Hi Fiona, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Trahe, Fiona > Sent: Wednesday, July 11, 2018 7:04 PM > To: Dmitry Eremin-Solenikov ; > dev@dpdk.org > Cc: Trahe, Fiona > Subject: Re: [dpdk-dev] [PATCH] qat: fix checks for 3gpp algorithms vs bit > mod

[dpdk-dev] [PATCH v2] test/power: fix 32-bit build

2018-07-13 Thread Pablo de Lara
Compilation issue: test/test/test_power_acpi_cpufreq.c:556:31: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘uint64_t {aka long long unsigned int}’ -Werror=format=] printf("ACPI: Capabilities %lx\n", caps.capabilities); ~

Re: [dpdk-dev] [PATCH] test/power: fix 32-bit build

2018-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Friday, July 13, 2018 5:13 AM > To: Nicolau, Radu ; Hunt, David > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] test/power: fix 32-bit build > > Compilation issue: > > test/test/test_power_acpi_cpufreq.c:556:31:

[dpdk-dev] [PATCH v3 5/8] eal: do not create runtime dir in no-shconf mode

2018-07-13 Thread Anatoly Burakov
Now that the rest of the EAL is adjusted to not create any shared files, prevent runtime directory from ever being created. Signed-off-by: Anatoly Burakov --- Notes: RFC->v1: - Use --no-shconf only lib/librte_eal/bsdapp/eal/eal.c | 3 ++- lib/librte_eal/linuxapp/eal/eal.c | 3 ++- 2

[dpdk-dev] [PATCH v3 7/8] eal: add --in-memory option

2018-07-13 Thread Anatoly Burakov
This command-line option will cause DPDK to operate entirely in memory and not create any shared files at runtime, including any shared configuration or hugetlbfs files. This is useful for debug purposes, as well as for certain use cases like containers or automatic memory cleanup. Currently, this

[dpdk-dev] [PATCH v3 3/8] eal: add support for no-shconf for hugepage info

2018-07-13 Thread Anatoly Burakov
Do not create any shared hugepage size info files if we were asked to not create any shared files. Signed-off-by: Anatoly Burakov --- Notes: RFC->v1: - Use --no-shconf only lib/librte_eal/bsdapp/eal/eal_hugepage_info.c | 4 lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 4 +++

[dpdk-dev] [PATCH v3 6/8] mem: add support for hugepage-unlink mode

2018-07-13 Thread Anatoly Burakov
Unlink hugepages after creating them, to honor the hugepage-unlink mode. We cannot resize non-existing files, so make single file segments explicitly unsupported. Signed-off-by: Anatoly Burakov --- Notes: v1->v2: - Move check for hugepage unlink into this patch, to be consistent wi

[dpdk-dev] [PATCH v3 0/8] Support running DPDK without hugetlbfs mountpoint

2018-07-13 Thread Anatoly Burakov
This patchset adds a new command-line option "--in-memory", which takes old debug options "--huge-unlink" and "--no-shconf", and enhances them with additional functionality. This will allow DPDK to reserve hugepages anonymously instead of using hugetlbfs mountpoints. Coupled with the fact that this

[dpdk-dev] [PATCH v3 4/8] eal: add support for no-shconf in hugepage data file

2018-07-13 Thread Anatoly Burakov
Do not create a shared hugepage data file if we were asked to not create any shared files. Signed-off-by: Anatoly Burakov --- Notes: RFC->v1: - Use --no-shconf only lib/librte_eal/linuxapp/eal/eal_memory.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v3 8/8] mem: support in-memory mode

2018-07-13 Thread Anatoly Burakov
Implement the final piece of the in-memory mode puzzle - enable running DPDK entirely in memory, without creating any files. To do it, use mmap with MAP_HUGETLB and size flags to enable DPDK to work without hugetlbfs mountpoints. In order to enable this, a few things needed to be changed. First o

[dpdk-dev] [PATCH v3 2/8] ipc: add support for no-shconf mode

2018-07-13 Thread Anatoly Burakov
IPC is an inter-process communication mechanism. Since no secondaries can ever be expected to run in no-shconf mode, IPC will be useless, so do not enable it in the first place. In the interests of API usage convenience, we will still allow registering callbacks, but obviously they won't ever be tr

[dpdk-dev] [PATCH v3 1/8] fbarray: support no-shconf mode

2018-07-13 Thread Anatoly Burakov
When using --no-shconf option, the expectation is that no multiprocess will be supported as no shared files are created. However, fbarray still creates some shared files that prevent multiple processes with the same prefix from starting. Fix this by avoiding creating shared files whenever noshconf

Re: [dpdk-dev] [PATCH] test/power: fix 32-bit build

2018-07-13 Thread Radu Nicolau
On 7/13/2018 5:12 AM, Pablo de Lara wrote: Compilation issue: test/test/test_power_acpi_cpufreq.c:556:31: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘uint64_t {aka long long unsigned int}’ -Werror=format=] printf("ACPI: Capabilities %lx\n", c

Re: [dpdk-dev] [PATCH v2 8/9] doc: add deprecation notice for EAL command line options

2018-07-13 Thread Burakov, Anatoly
On 13-Jul-18 1:13 PM, Thomas Monjalon wrote: 13/07/2018 12:27, Anatoly Burakov: Options --no-shconf and --huge-unlink will be removed, and replaced with --in-memory option, which will be a superset of these two, and an offially support method to run DPDK entirely in memory. Signed-off-by: Anato

Re: [dpdk-dev] [PATCH v2 7/9] eal: add --in-memory option

2018-07-13 Thread Burakov, Anatoly
On 13-Jul-18 1:13 PM, Thomas Monjalon wrote: 13/07/2018 12:27, Anatoly Burakov: This command-line option will cause DPDK to operate entirely in memory and not create any shared files at runtime, including any shared configuration or hugetlbfs files. This is useful for debug purposes, as well as

[dpdk-dev] [PATCH] test/power: fix 32-bit build

2018-07-13 Thread Pablo de Lara
Compilation issue: test/test/test_power_acpi_cpufreq.c:556:31: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘uint64_t {aka long long unsigned int}’ -Werror=format=] printf("ACPI: Capabilities %lx\n", caps.capabilities); ~

Re: [dpdk-dev] [PATCH v2 9/9] mem: support in-memory mode

2018-07-13 Thread Thomas Monjalon
There is a compilation error: ../lib/librte_eal/linuxapp/eal/eal_memalloc.c: In function ‘alloc_seg’: ../lib/librte_eal/linuxapp/eal/eal_memalloc.c:619:3: error: ‘map_offset’ may be used uninitialized in this function 13/07/2018 12:27, Anatoly Burakov: > Implement the final piece of the in-memor

Re: [dpdk-dev] [PATCH v2 8/9] doc: add deprecation notice for EAL command line options

2018-07-13 Thread Thomas Monjalon
13/07/2018 12:27, Anatoly Burakov: > Options --no-shconf and --huge-unlink will be removed, and > replaced with --in-memory option, which will be a superset > of these two, and an offially support method to run DPDK > entirely in memory. > > Signed-off-by: Anatoly Burakov The deprecation notice

Re: [dpdk-dev] [PATCH v2 7/9] eal: add --in-memory option

2018-07-13 Thread Thomas Monjalon
13/07/2018 12:27, Anatoly Burakov: > This command-line option will cause DPDK to operate entirely in > memory and not create any shared files at runtime, including any > shared configuration or hugetlbfs files. This is useful for debug > purposes, as well as for certain use cases like containers or

Re: [dpdk-dev] [PATCH v2] eal: move runtime config file to new location

2018-07-13 Thread Thomas Monjalon
13/07/2018 12:44, Anatoly Burakov: > As per deprecation notice [1], move DPDK runtime config to default > DPDK runtime data location. Also, remove the deprecation notice and > update release notes to indicate the changes. > > [1] http://dpdk.org/dev/patchwork/patch/40418/ > > Signed-off-by: Anato

Re: [dpdk-dev] [PATCH v2 5/7] eal: bring forward init of interrupt handling

2018-07-13 Thread David Marchand
On Fri, Jul 13, 2018 at 11:10 AM, Tiwei Bie wrote: > On Fri, Jul 13, 2018 at 10:09:42AM +0200, David Marchand wrote: > [...] >> Well, there was an issue vith virtio at one time (interrupt handler >> did not have the right iopl for virtio callback). >> http://git.dpdk.org/dpdk/commit/lib/librte_eal

  1   2   >