Previously, detach port on secondary process will mess primary
process and cause same device can't be attached again, by take
advantage of rte_eth_release_port_private, we can support this
with minor change.
Signed-off-by: Qi Zhang
---
drivers/net/tap/rte_eth_tap.c | 17 +++--
1 file
Previously, detach port on secondary process will mess primary
process and cause same device can't be attached again, by take
advantage of rte_eth_release_port_private, we can support this
with minor change.
Signed-off-by: Qi Zhang
---
drivers/net/softnic/rte_eth_softnic.c | 19 -
Previously, detach port on secondary process will mess primary
process and cause same device can't be attached again, by take
advantage of rte_eth_release_port_private, we can support this
with minor change.
Signed-off-by: Qi Zhang
---
drivers/net/pcap/rte_eth_pcap.c | 15 ++-
1 file
Previously, detach port on secondary process will mess primary
process and cause same device can't be attached again, by take
advantage of rte_eth_release_port_private, we can support this
with minor change.
Signed-off-by: Qi Zhang
---
drivers/net/af_packet/rte_eth_af_packet.c | 11 +++
Previously, detach port on secondary process will mess primary
process and cause same device can't be attached again, by take
advantage of rte_eth_release_port_private, we can support this
with minor change.
Signed-off-by: Qi Zhang
---
drivers/net/e1000/em_ethdev.c | 9 +
1 file changed,
Previously, detach port on secondary process will mess primary
process and cause same device can't be attached again, by take
advantage of rte_eth_release_port_private, we can support this
with minor change.
Signed-off-by: Qi Zhang
---
drivers/net/fm10k/fm10k_ethdev.c | 9 +
1 file chang
Previously, detach port on secondary process will mess primary
process and cause same device can't be attached again, by take
advantage of rte_eth_release_port_private, we can support this
with minor change.
Signed-off-by: Qi Zhang
---
drivers/net/e1000/igb_ethdev.c | 9 +
1 file changed
This patch cover the multi-process hotplug case when a share device
attach/detach request be issued from secondary process, the implementation
references malloc_mp.c.
device attach on secondary:
a) secondary send async request to primary and wait on a condition
which will be released by matched
Previously, detach port on secondary process will mess primary
process and cause same device can't be attached again, by take
advantage of rte_eth_release_port_private, we can support this
with minor change.
Signed-off-by: Qi Zhang
---
drivers/net/i40e/i40e_ethdev.c| 2 ++
drivers/net/i40e/i
Previously, detach port on secondary process will mess primary
process and cause same device can't be attached again, by take
advantage of rte_eth_release_port_private, we can support this
with minor change.
Signed-off-by: Qi Zhang
---
drivers/net/ixgbe/ixgbe_ethdev.c | 12
1 file c
v2:
- rename rte_ethdev_mp.* to ethdev_mp.*
- rename rte_ethdev_lock.* to ethdev_lock.*
- move internal funciton to ethdev_private.h
- separate rte_eth_dev_[un]lock into rte_eth_dev_[un]lock and
rte_eth_dev_[un]lock_with_callback
- lock callbacks will be removed automatically after device is det
We are going to introduce the solution to handle different hotplug
cases in multi-process situation, it include below scenario:
1. Attach a share device from primary
2. Detach a share device from primary
3. Attach a share device from secondary
4. Detach a share device from secondary
5. Attach a pr
Add driver API rte_eth_release_port_private to support the
requirement that an ethdev only be released on secondary process,
so only local state be set to unused , share data will not be
reset so primary process can still use it.
Signed-off-by: Qi Zhang
---
v2:
- rename rte_eth_release_port_loca
Introduce API rte_eth_dev_lock and rte_eth_dev_unlock to let
application lock or unlock on specific ethdev, a locked device
can't be detached, this help application to prevent unexpected
device detaching, especially in multi-process environment.
Also introduce the new API rte_eth_dev_lock_with_cal
Previously, detach port on secondary process will mess primary
process and cause same device can't be attached again, by take
advantage of rte_eth_release_port_private, we can support this
with minor change.
Signed-off-by: Qi Zhang
---
drivers/net/vhost/rte_eth_vhost.c | 11 +++
1 file c
Previously, detach port on secondary process will mess primary
process and cause same device can't be attached again, by take
advantage of rte_eth_release_port_private, we can support this
with minor change.
Signed-off-by: Qi Zhang
---
drivers/net/octeontx/octeontx_ethdev.c | 16
The sample code demonstrate device (ethdev only) management
at multi-process envrionment. User can attach/detach a device
on primary process and see it is synced on secondary process
automatically, also user can lock a device to prevent it be
detached or unlock it to go back to default behaviour.
Previously, detach port on secondary process will mess primary
process and cause same device can't be attached again, by take
advantage of rte_eth_release_port_private, we can support this
with minor change.
Signed-off-by: Qi Zhang
---
drivers/net/kni/rte_eth_kni.c | 11 +++
1 file chang
Previously, detach port on secondary process will mess primary
process and cause same device can't be attached again, by take
advantage of rte_eth_release_port_private, we can support this
with minor change.
Signed-off-by: Qi Zhang
---
drivers/net/null/rte_eth_null.c | 16 +++-
1 fil
Previously, detach port on secondary process will mess primary
process and cause same device can't be attached again, by take
advantage of rte_eth_release_port_private, we can support this
with minor change.
Signed-off-by: Qi Zhang
---
drivers/net/failsafe/failsafe.c | 16
1 fil
Previously, detach port on secondary process will mess primary
process and cause same device can't be attached again, by take
advantage of rte_eth_release_port_private, we can support this
with minor change.
Signed-off-by: Qi Zhang
---
drivers/net/bonding/rte_eth_bond_pmd.c | 11 +++
1 f
When hot plug a new device, it is not necessary to scan everything
on the bus since the devname and devargs are already there. So new
rte_bus ops "scan_one" is introduced, bus driver can implement this
function to simplify the hotplug process.
Signed-off-by: Qi Zhang
---
v2:
- fix spelling
- add
The patch implemented the ops scan_one for vdev bus, it gives two benefits
1. Improve scan efficiency when a device is attached as hotplug, since no
need to populate a new device by iterating all devargs in devargs_list.
2. It also avoid sync IPC invoke (which happens in vdev->scan on secondary
pro
Hi all,
I cannot build DPDK for tile-tilegx-linuxapp-gcc on v16.07.2:
I got the following error:
-
CC eal.o
In file included from /opt/tilera/dpdk-stable-16.07.
2/lib/librte_eal/linuxapp/eal/eal.c:68:
/opt/tilera/dpdk-stable-16.07.2/tile-tilegx-linuxapp-gcc/include/rte_cycles.h:40:24:
error:
On 20.06.2018 21:12, Ferruh Yigit wrote:
On 6/20/2018 6:39 PM, Andrew Rybchenko wrote:
On 06/20/2018 08:24 PM, Ferruh Yigit wrote:
On 6/20/2018 8:42 AM, Andrew Rybchenko wrote:
On 06/19/2018 09:02 PM, Ferruh Yigit wrote:
DEV_RX_OFFLOAD_KEEP_CRC offload flag added. PMDs that supports keeping
C
On 6/19/2018 3:37 PM, ido goshen wrote:
> Fixes: 4c173302c307 ("pcap: add new driver")
> Cc: sta...@dpdk.org
>
> Change open_rx/tx_pcap/iface functions to open only a single pcap/dumper
> and not loop num_of_queue times
> The num_of_queue loop is already acheived by the caller rte_kvargs_process
>
On 6/20/2018 7:06 PM, Ido Goshen wrote:
> Although there's no functional need for them I considered keeping it for
> maintainability reasons:
> 1. Keep the call flow more aligned with pcap (file) that has separated
> open_rx_pcap()/open_tx_pcap()
> 2. If in future there'll rise a need for differe
On 6/20/2018 6:39 PM, Andrew Rybchenko wrote:
> On 06/20/2018 08:24 PM, Ferruh Yigit wrote:
>> On 6/20/2018 8:42 AM, Andrew Rybchenko wrote:
>>> On 06/19/2018 09:02 PM, Ferruh Yigit wrote:
DEV_RX_OFFLOAD_KEEP_CRC offload flag added. PMDs that supports keeping
CRC should advertise this off
On 6/18/2018 10:49 AM, Ido Goshen wrote:
> I'm really not sure that just setting the pcaps/dumpers.num_of_queue w/o
> actually creating multiple queues is good enough.
> If one uses N queues there are good changes he is using N cores.
> To be consistent with DPDK behavior it should be safe to conc
On 6/19/2018 3:37 PM, ido goshen wrote:
> Signed-off-by: ido goshen
<...>
> /*
> + * Opens a NIC for reading packets from it
> + */
> +static inline int
> +open_rx_iface(const char *key, const char *value, void *extra_args)
> +{
> + return open_iface(key, value, extra_args);
> +}
> +
> +/*
On 06/20/2018 08:24 PM, Ferruh Yigit wrote:
On 6/20/2018 8:42 AM, Andrew Rybchenko wrote:
On 06/19/2018 09:02 PM, Ferruh Yigit wrote:
DEV_RX_OFFLOAD_KEEP_CRC offload flag added. PMDs that supports keeping
CRC should advertise this offload capability.
DEV_RX_OFFLOAD_CRC_STRIP flag will remain o
On 6/20/2018 8:42 AM, Andrew Rybchenko wrote:
> On 06/19/2018 09:02 PM, Ferruh Yigit wrote:
>> DEV_RX_OFFLOAD_KEEP_CRC offload flag added. PMDs that supports keeping
>> CRC should advertise this offload capability.
>>
>> DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release
>> default behavior
On 6/20/2018 6:07 PM, Dan Gora wrote:
> Hi Ferruh,
>
> The documentation for rte_eth_dev_configure() should get updated as
> well to document this requirement to strip the unsupported RSS hash
> function bits. The current documentation only refers to the tx/rx
> offload bits:
>
> * - Any o
On 6/20/2018 6:03 PM, Dan Gora wrote:
> Hi Ferruh,
>
> Thanks for this.. I had started working on a patch to do this as well
> because I got bit by this error.
>
> Shouldn't all of the example applications also add the code to strip
> the unsupported Tx and Rx offload bits as well? It would help
Hi Ferruh,
The documentation for rte_eth_dev_configure() should get updated as
well to document this requirement to strip the unsupported RSS hash
function bits. The current documentation only refers to the tx/rx
offload bits:
* - Any offloading set in eth_conf->[rt]xmode.offloads must be
On 6/20/2018 5:39 PM, Ferruh Yigit wrote:
> On 6/20/2018 12:35 AM, Stephen Hemminger wrote:
>> On Tue, 19 Jun 2018 13:08:55 +0100
>> Ferruh Yigit wrote:
>>
>>> Error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option is
>>> enabled.
>>>
>>> build error:
>>> In function ‘strncpy’,
>>> inli
Hi Ferruh,
Thanks for this.. I had started working on a patch to do this as well
because I got bit by this error.
Shouldn't all of the example applications also add the code to strip
the unsupported Tx and Rx offload bits as well? It would help new
users (like me!) to understand that this is a r
On 6/20/2018 10:01 AM, De Lara Guarch, Pablo wrote:
>
>
>> -Original Message-
>> From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Ferruh Yigit
>> Sent: Tuesday, June 19, 2018 1:09 PM
>> To: Yigit, Ferruh
>> Cc: dev@dpdk.org; sta...@dpdk.org
>> Subject: [dpdk-stable] [PATCH] kni
On 6/20/2018 12:35 AM, Stephen Hemminger wrote:
> On Tue, 19 Jun 2018 13:08:55 +0100
> Ferruh Yigit wrote:
>
>> Error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option is
>> enabled.
>>
>> build error:
>> In function ‘strncpy’,
>> inlined from ‘igb_get_drvinfo’ at
>> .../dpdk/build/
On 6/20/2018 2:44 PM, Shahaf Shuler wrote:
>
> Hi Ferruh,
>
> Tuesday, June 19, 2018 9:03 PM, Ferruh Yigit
>> Subject: [dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC
>>
>
> [...]
>
>
>> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
>> index de3f869ed..28cf
Hi Ferruh,
On 20/6/2018 4:01 PM, Ferruh Yigit wrote:
ethdev layer introduced checks for application requested RSS hash
functions and returns error for ones unsupported by hardware
This check breaks some sample applications which blindly configures
RSS hash functions without checking underlying
Add the support for new traffic pattern aware power control
power management API.
Example:
./l3fwd-power -l xxx -n 4 -w :xx:00.0 -w :xx:00.1 -- -p 0x3
-P --config="(0,0,xx),(1,0,xx)" --empty-poll
Please Reference l3fwd-power document for all parameter except
empty-poll.
Once enable e
1. Abstract
For packet processing workloads such as DPDK polling is continuous.
This means CPU cores always show 100% busy independent of how much work
those cores are doing. It is critical to accurately determine how busy
a core is hugely important for the following reasons:
* No indication o
The DPAA bus driver is defining some macros without prefix.
So it can conflict with other libraries like libbsd:
drivers/bus/dpaa/include/compat.h:53:
error: "__packed" redefined
/usr/include/bsd/sys/cdefs.h:120:
note: this is the location of the pre
ethdev layer introduced checks for application requested RSS hash
functions and returns error for ones unsupported by hardware
This check breaks some sample applications which blindly configures
RSS hash functions without checking underlying hardware support.
Updated examples to mask out unsuppor
Hi Ferruh,
Tuesday, June 19, 2018 9:03 PM, Ferruh Yigit
> Subject: [dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC
>
[...]
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index de3f869ed..28cf168aa 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/driv
>
> How about moving this as separate library(pipeline dev) with driver(plugin)
> interface
> and librte_pipeline based API being used as one plugin/driver. This will
> enable us
> to hook another HW based or HW-SW combination of plugins in future.
This is exactly what we are looking to do. The
On 6/19/2018 7:23 PM, Dasha Kolistratova wrote:
> Hi! I’m trying to launch NFF-GO (https://github.com/intel-go/nff-go)
> on AWS instances and faced a problem (Program received signal SIGFPE,
> Arithmetic exception.) which was caused by:
>
>
> 0x006f703c in ena_rss_init_default (adapter=0x
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Tuesday, June 19, 2018 2:03 PM
<...>
> Subject: [PATCH] ethdev: add new offload flag to keep CRC
>
> DEV_RX_OFFLOAD_KEEP_CRC offload flag added. PMDs that supports
> keeping CRC should advertise this offload
From: Alex Kiselev [mailto:a...@therouter.net]
> add functions to add/remove MAC addresses
> Signed-off-by: Alex Kiselev
Acked-by: Matan Azrad
From: Helin Zhang
For subtree of dpdk-next-net-intel, Qi Zhang has agreed to take
the committer role, to replace Helin Zhang. Also Beilei Xing has
agreed to be the backup committer of the subtree.
Signed-off-by: Helin Zhang
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-
Igb VF nic need to support check descriptor status APIs, they are
rte_eth_rx_descriptor_status and rte_eth_tx_descriptor_status.
So, this patch add ops with function pointer that enable feature.
Signed-off-by: Wei Zhao
---
v2:
add release note document info.
---
doc/guides/rel_notes/release_18
Fm10k nic need to support check descriptor status APIs, they are
rte_eth_rx_descriptor_status and rte_eth_tx_descriptor_status.
So, this patch add ops with function pointer that enable feature.
Signed-off-by: Wei Zhao
---
v2:
-fix DD check error in tx descriptor
---
doc/guides/rel_notes/relea
> -Original Message-
> From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Tuesday, June 19, 2018 1:09 PM
> To: Yigit, Ferruh
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [dpdk-stable] [PATCH] kni: fix build with gcc 8.1
>
> Error observed when CONFIG_RTE_K
> Please see comments below.
From: Matan Azrad
>> +/*
>> + * Remove additional MAC addresses from the slave */ int
>> +slave_remove_mac_addresses(struct rte_eth_dev *bonded_eth_dev,
>> + uint16_t slave_port_id)
>> +{
>> + int i, ret = 0;
>> + struct ether_addr *mac_addr;
>>
add functions to add/remove MAC addresses
Signed-off-by: Alex Kiselev
---
drivers/net/bonding/rte_eth_bond_api.c | 12 ++-
drivers/net/bonding/rte_eth_bond_pmd.c | 131 -
drivers/net/bonding/rte_eth_bond_private.h | 8 ++
3 files changed, 146 insertions(+),
On 06/20/2018 03:44 PM, Tiwei Bie wrote:
On Fri, Jun 08, 2018 at 05:07:23PM +0800, Marvin Liu wrote:
[...]
@@ -634,6 +634,24 @@ virtio_dev_rx_queue_setup_finish(struct rte_eth_dev *dev, uint16_t queue_idx)
virtio_rxq_rearm_vec(rxvq);
nbufs +=
On Fri, Jun 08, 2018 at 05:07:23PM +0800, Marvin Liu wrote:
[...]
>
> @@ -634,6 +634,24 @@ virtio_dev_rx_queue_setup_finish(struct rte_eth_dev
> *dev, uint16_t queue_idx)
> virtio_rxq_rearm_vec(rxvq);
> nbufs += RTE_VIRTIO_VPMD_RX_REARM_THRESH;
>
On 06/19/2018 09:02 PM, Ferruh Yigit wrote:
DEV_RX_OFFLOAD_KEEP_CRC offload flag added. PMDs that supports keeping
CRC should advertise this offload capability.
DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release
default behavior in PMDs are to keep the CRC until this flag removed
Until
On Fri, Jun 08, 2018 at 05:07:22PM +0800, Marvin Liu wrote:
> IN_ORDER Rx function can support merge-able feature. Descriptors
> allocation and free will be done in bulk.
>
> Virtio dequeue logic:
> dequeue_burst_rx(burst mbufs)
> for (each mbuf b) {
> if (b need merge) {
>
>-Original Message-
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com]
>Sent: 20 June 2018 12:56
>To: Verma, Shally
>Cc: Trahe, Fiona ; dev@dpdk.org; Athreya, Narayana
>Prasad ;
>Challa, Mahipal ; Gupta, Ashish
>; Sahu, Sunila
>
>Subject: RE: [PATCH v1 7/7] drivers/c
Hi Shally,
> -Original Message-
> From: Verma, Shally [mailto:shally.ve...@cavium.com]
> Sent: Wednesday, June 20, 2018 7:02 AM
> To: De Lara Guarch, Pablo
> Cc: Trahe, Fiona ; dev@dpdk.org; Athreya, Narayana
> Prasad ; Challa, Mahipal
> ; Gupta, Ashish ;
> Sahu, Sunila
> Subject: RE: [P
On Wed, Jun 20, 2018 at 05:34:23AM +, Shahaf Shuler wrote:
> Adding the maintainers,
>
> Tuesday, June 19, 2018 4:09 PM, Raslan Darawsheh:
> >Subject: [PATCH] net/mlx5: fix Rss level validation
>
> Rss -> RSS
>
> >
> >When setting the level in rss action it's checking for the value stored i
On Tue, Jun 19, 2018 at 11:00:25PM +, Yongseok Koh wrote:
>[...]
> >>> I did not understood it was only a concern about the success of the
> >>> function, even it is better to avoid as most as possible a useless
> >>> store, in this specific case, as errno (rte_errno) has a garbage value,
> >>>
On Tue, Jun 19, 2018 at 04:13:13PM -0700, Yongseok Koh wrote:
> rte_errno should be saved only if error has occurred because rte_errno
> could have garbage value.
>
> Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Yongseok Koh
Ack
65 matches
Mail list logo
