Hi Ferruh, The documentation for rte_eth_dev_configure() should get updated as well to document this requirement to strip the unsupported RSS hash function bits. The current documentation only refers to the tx/rx offload bits:
* - Any offloading set in eth_conf->[rt]xmode.offloads must be within * the [rt]x_offload_capa returned from rte_eth_dev_infos_get(). * Any type of device supported offloading set in the input argument * eth_conf->[rt]xmode.offloads to rte_eth_dev_configure() is enabled * on all queues and it can't be disabled in rte_eth_[rt]x_queue_setup(). thanks dan On Wed, Jun 20, 2018 at 10:03 AM, Dan Gora <d...@adax.com> wrote: > Hi Ferruh, > > Thanks for this.. I had started working on a patch to do this as well > because I got bit by this error. > > Shouldn't all of the example applications also add the code to strip > the unsupported Tx and Rx offload bits as well? It would help new > users (like me!) to understand that this is a requirement for all > callers of rte_eth_dev_configure(). > > rte_eth_dev_info_get(port_id, &dev_info); > > /* Only set the offload bits which are actually supported */ > port_conf.txmode.offloads &= dev_info.tx_offload_capa; > port_conf.rxmode.offloads &= dev_info.rx_offload_capa; > > thanks > dan
