Hi Ferruh,

On 20/6/2018 4:01 PM, Ferruh Yigit wrote:
ethdev layer introduced checks for application requested RSS hash
functions and returns error for ones unsupported by hardware

This check breaks some sample applications which blindly configures
RSS hash functions without checking underlying hardware support.

Updated examples to mask out unsupported RSS has functions during device
configuration.
Prints a log if configuration values updated by this check.

Fixes: aa1a6d87f15d ("ethdev: force RSS offload rules again")

Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com>
---
Return error added in this release, so no need to backport the fix to
previous versions.

Cc: David Hunt <david.h...@intel.com>
Cc: Liang Ma <liang.j...@intel.com>
Cc: Xueming Li <xuemi...@mellanox.com>
---
  examples/bond/main.c                          | 12 ++++++++++
  examples/distributor/main.c                   | 11 ++++++++++
  examples/eventdev_pipeline/main.c             | 11 ++++++++++
  examples/ip_pipeline/link.c                   |  8 +++++--
  examples/ip_reassembly/main.c                 | 12 ++++++++++
  examples/ipsec-secgw/ipsec-secgw.c            | 12 ++++++++++
  examples/l3fwd-acl/main.c                     | 12 ++++++++++
  examples/l3fwd-power/main.c                   | 14 ++++++++++--
  examples/l3fwd-vf/main.c                      | 12 ++++++++++
  examples/l3fwd/main.c                         | 12 ++++++++++
  examples/load_balancer/init.c                 | 12 ++++++++++
  examples/multi_process/symmetric_mp/main.c    | 12 ++++++++++
  .../performance-thread/l3fwd-thread/main.c    | 12 ++++++++++
  examples/qos_meter/main.c                     | 22 +++++++++++++++++++
  examples/vmdq_dcb/main.c                      | 13 +++++++++++
  15 files changed, 183 insertions(+), 4 deletions(-)


--snip--

I tested distributor_app, l3-fwd and l3-fwd-power, they all started OK, giving the additional message that some flags were not available on my hardware.
Looks good.

Regards,
Dave.

Reply via email to