Re: [dpdk-dev] [PATCH] drivers: cleanup unnecessary global variables

2018-04-19 Thread Shreyansh Jain
On Friday 20 April 2018 12:21 AM, Pavan Nikhilesh wrote: Signed-off-by: Pavan Nikhilesh --- drivers/bus/dpaa/base/fman/netcfg_layer.c | 5 - drivers/bus/dpaa/base/qbman/bman_driver.c | 4 ++-- drivers/bus/dpaa/base/qbman/qman.c| 2 +- drivers/bus/dpaa/base/qbman/qman

Re: [dpdk-dev] [PATCH v2 0/6] crypto: add asym crypto support

2018-04-19 Thread Verma, Shally
Ping. Could you please review and provide feedback. Thanks Shally >-Original Message- >From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shally Verma >Sent: 05 April 2018 16:55 >To: pablo.de.lara.gua...@intel.com >Cc: declan.dohe...@intel.com; fiona.tr...@intel.com; Athreya, Narayana

Re: [dpdk-dev] [PATCH] net/mvpp2: fix build

2018-04-19 Thread Tomasz Duszynski
On Thu, Apr 19, 2018 at 06:09:34PM +0200, Thomas Monjalon wrote: > The iterator RTE_ETH_FOREACH_DEV (added in below commit) > requires to enable experimental APIs. > > Fixing also the config option rename in the build test. > > Fixes: 8728ccf37615 ("fix ethdev ports enumeration") > Fixes: fe9396872

Re: [dpdk-dev] [PATCH v2 2/2] devtools: improve kernel script execution check

2018-04-19 Thread Kuusisaari, Juhamatti
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, April 19, 2018 4:25 PM > To: Kuusisaari, Juhamatti ; > tho...@monjalon.net > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/2] devtools: improve kernel script > execution check > > On 4/19/

Re: [dpdk-dev] [PATCH 0/9 v2] Introduce DPAA2 QDMA raw driver

2018-04-19 Thread Nipun Gupta
Hi Shreyansh, I have taken care of all your comments from the v1 series as all were appropriate :) Also I have rebased on master branch and will rebase CMDIF series over this one. This lead to addition of patch 4 and some more changes in patch 3 here. Please re-review these. Thanks, Nipun > -

[dpdk-dev] [PATCH v2 3/3] net/bnxt: fix mbuf data_off initialization

2018-04-19 Thread Ajit Khaparde
Initialize mbuf->data_off to RTE_PKTMBUF_HEADROOM after allocation. Without this, it might be possible that the DMA address provided to the HW may not be in sync to what is indicated to the application in bnxt_rx_pkt. Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code") Cc: sta...@dpdk.org Signe

[dpdk-dev] [PATCH v2 1/3] net/bnxt: cache address of doorbell to subsequent access

2018-04-19 Thread Ajit Khaparde
While creating TX, Rx, CQ rings use cached DB address instead of getting it from the PCI memory resource. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 1 + drivers/net/bnxt/bnxt_cpr.c| 2 +- drivers/net/bnxt/bnxt_ethdev.c | 12 drivers/net/bnxt/bnxt_ring.c

[dpdk-dev] [PATCH v2 2/3] net/bnxt: fix set_rx_mask from using invalid vnic id

2018-04-19 Thread Ajit Khaparde
In some cases bnxt_hwrm_cfa_l2_set_rx_mask is being called before VNICs are allocated. The FW returns an error in such cases. Move bnxt_init_nic to bnxt_dev_init such that the ids are initialized to an invalid id. Prevent sending the command to the FW only with a valid vnic id. Fixes: 244bc98b0da7

[dpdk-dev] [PATCH v2 0/3] bnxt patchset

2018-04-19 Thread Ajit Khaparde
Please apply. Ajit Khaparde (3): net/bnxt: cache address of doorbell to subsequent access net/bnxt: fix set_rx_mask from using invalid vnic id net/bnxt: fix mbuf data_off initialization drivers/net/bnxt/bnxt.h| 1 + drivers/net/bnxt/bnxt_cpr.c| 2 +- drivers/net/bnxt/bnxt_eth

[dpdk-dev] [PATCH 6/9 v2] raw/dpaa2_qdma: support configuration APIs

2018-04-19 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf | 1 + drivers/raw/dpaa2_qdma/Makefile| 2 + drivers/raw/dpaa2_qdma/dpaa2_qdma.c| 375 + driver

[dpdk-dev] [PATCH 7/9 v2] raw/dpaa2_qdma: support enq and deq operations

2018-04-19 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c| 332 + drivers/raw/dpaa2_qdma/dpaa2_qdma.h| 21 ++ drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h| 70 + .../raw/dpaa2_qdma/rte_pmd_dpaa2_qdma_version.map | 4 + 4

[dpdk-dev] [PATCH 8/9 v2] doc: add DPAA2 QDMA rawdev guide

2018-04-19 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- MAINTAINERS | 1 + doc/guides/index.rst | 1 + doc/guides/rawdevs/dpaa2_qdma.rst | 140 ++ doc/guides/rawdevs/index.rst | 14 4 files changed, 156 insertions(+) create mode 100644

[dpdk-dev] [PATCH 9/9 v2] doc: add dpaa2 qdma rawdev to release notes

2018-04-19 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- doc/guides/rel_notes/release_18_05.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index bc9cdda..89ea502 100644 --- a/doc/guides/rel_notes/release_18_05.rst +++ b/doc/g

[dpdk-dev] [PATCH 5/9 v2] raw/dpaa2_qdma: introduce the DPAA2 QDMA driver

2018-04-19 Thread Nipun Gupta
DPAA2 QDMA driver uses MC DPDMAI object. This driver enables the user (app) to perform data DMA without involving CPU in the DMA process Signed-off-by: Nipun Gupta --- MAINTAINERS| 8 + config/common_base | 1 + config/c

[dpdk-dev] [PATCH 2/9 v2] bus/fslmc: support scanning and probing of QDMA devices

2018-04-19 Thread Nipun Gupta
'dpdmai' devices detected on fsl-mc bus are represented by DPAA2 QDMA devices in DPDK. Signed-off-by: Nipun Gupta Acked-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_bus.c | 2 ++ drivers/bus/fslmc/fslmc_vfio.c | 1 + drivers/bus/fslmc/rte_fslmc.h | 2 ++ 3 files changed, 5 insertions(+) di

[dpdk-dev] [PATCH 3/9 v2] bus/fslmc: add macros required by QDMA for FLE and FD

2018-04-19 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h index 72aae43..1b67bed 100644 --- a/drivers/bus/fslmc/portal/dpaa2_h

[dpdk-dev] [PATCH 4/9 v2] bus/fslmc: fix typecasting in IOVA/virt conversion macros

2018-04-19 Thread Nipun Gupta
Fixes: df0011c92312 ("bus/fslmc: add physical-virtual address translation helpers") Cc: sta...@dpdk.org Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drive

[dpdk-dev] [PATCH 0/9 v2] Introduce DPAA2 QDMA raw driver

2018-04-19 Thread Nipun Gupta
This patch set introduces DPAA2 based QDMA device driver. It provide means to initiate a DMA transaction from CPU. The initiated DMA is performed without CPU being involved in the actual DMA transaction. This patch series is rebased on dpdk master branch Patches 1-4: Makes necessary changes in

[dpdk-dev] [PATCH 1/9 v2] bus/fslmc: support MC DPDMAI object

2018-04-19 Thread Nipun Gupta
This patch adds the DPDMAI (Data Path DMA Interface) object support in MC driver. Signed-off-by: Cristian Sovaiala Signed-off-by: Nipun Gupta Acked-by: Shreyansh Jain --- drivers/bus/fslmc/Makefile | 9 +- drivers/bus/fslmc/mc/dpdmai.c | 429 +++

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/3] net/bnxt: check vnic_id before issuing set_rx_mask

2018-04-19 Thread Ajit Khaparde
On Thu, Apr 19, 2018 at 5:47 PM, Ferruh Yigit wrote: > On 4/20/2018 12:57 AM, Ajit Khaparde wrote: > > In some cases bnxt_hwrm_cfa_l2_set_rx_mask is being called before > > VNICs are allocated. The FW returns an error in such cases. > > Prevent sending the command the FW by checking for a valid v

Re: [dpdk-dev] [PATCH v3 2/4] ethdev: add packet field set aciton in flow API

2018-04-19 Thread Zhang, Qi Z
Hi Adrien: > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Thursday, April 19, 2018 10:49 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Doherty, Declan ; Chandran, > Sugesh ; Glynn, Michael J > ; Liu, Yu Y ; Ananyev, > Konstantin ; Richardson, Bruce >

Re: [dpdk-dev] rte_panic SIGABRT core dump

2018-04-19 Thread Stephen Hemminger
On Fri, 20 Apr 2018 00:59:01 +0530 shiva m wrote: > Hi, > > Need help in avoiding core dump in case rte_eal_init() fails in some > special cases. > > Part of my code causing rte_panic during system bootup and causes a core > dump. I do not want this core dump. > > I tried catching SIGABRT in m

Re: [dpdk-dev] [PATCH 2/2] ipc: fix timeout not properly handled in async

2018-04-19 Thread Tan, Jianfeng
> -Original Message- > From: Tan, Jianfeng > Sent: Friday, April 20, 2018 9:22 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Burakov, Anatoly; Tan, Jianfeng > Subject: [PATCH 2/2] ipc: fix timeout not properly handled in async > > In original implementation, timeout event for an async

[dpdk-dev] [PATCH 1/2] ipc: clearn up code

2018-04-19 Thread Jianfeng Tan
Following below commit, we change some internal function and variable names: commit ce3a7312357b ("eal: rename IPC request as synchronous one") Also use calloc to supersede malloc + memset for code clean up. Signed-off-by: Jianfeng Tan --- lib/librte_eal/common/eal_common_proc.c | 82

[dpdk-dev] [PATCH 2/2] ipc: fix timeout not properly handled in async

2018-04-19 Thread Jianfeng Tan
In original implementation, timeout event for an async request will be ignored. As a result, an async request will never trigger the action if it cannot receive any reply any more. We fix this by counting timeout as a processed reply. Fixes: f05e26051c15 ("eal: add IPC asynchronous request") Sig

[dpdk-dev] [PATCH 0/2] code clean up and fix in ipc

2018-04-19 Thread Jianfeng Tan
Patch 1 is to rename some variable names for better readability. Patch 2 is a bug fix. Jianfeng Tan (2): ipc: clearn up code ipc: fix timeout not properly handled in async lib/librte_eal/common/eal_common_proc.c | 88 - 1 file changed, 44 insertions(+), 44 de

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/3] net/bnxt: check vnic_id before issuing set_rx_mask

2018-04-19 Thread Ferruh Yigit
On 4/20/2018 12:57 AM, Ajit Khaparde wrote: > In some cases bnxt_hwrm_cfa_l2_set_rx_mask is being called before > VNICs are allocated. The FW returns an error in such cases. > Prevent sending the command the FW by checking for a valid vnic id Hi Ajit, Commit title doesn't explain "why" but explai

Re: [dpdk-dev] [PATCH v2] vhost: add virtio configuration space messages

2018-04-19 Thread Liu, Changpeng
Hi Maxime, We'll submit a new v3 version soon after tested with QEMU 2.12 release. > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Thursday, April 19, 2018 10:40 PM > To: Liu, Changpeng ; Kulasek, TomaszX > ; y...@fridaylinux.org > Cc: Verkamp, Dan

Re: [dpdk-dev] [PATCH] drivers/net: fix link autoneg value for virtual PMDs

2018-04-19 Thread Thomas Monjalon
20/04/2018 02:01, Ferruh Yigit: > These drivers never attempt link speed negotiation. Change link_autoneg > value to ETH_LINK_FIXED to be more accurate and consistent between PMDs. > > Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value") > Cc: sta...@dpdk.org > > Signed-off-by: Ferruh Y

[dpdk-dev] [PATCH 2/2] mbuf: improve API doc for tunnel Tx offloads

2018-04-19 Thread Thomas Monjalon
Add few details to remind TSO flag, checksum flags and header lengths. The doxygen syntax for MPLS-in-UDP is fixed. Fixes: d95188551fa1 ("mbuf: introduce new Tx offload flag for MPLS-in-UDP") Cc: harish.pa...@cavium.com Signed-off-by: Thomas Monjalon --- lib/librte_mbuf/rte_mbuf.h | 8 +---

[dpdk-dev] [PATCH 1/2] mbuf: fix Tx checksum offload API doc

2018-04-19 Thread Thomas Monjalon
When introducing rte_eth_tx_prepare(), the constraints on checksum pre-filling for Tx offloads were relaxed because implemented in the PMDs with rte_net_intel_cksum_flags_prepare() helper. As a consequence, these old requirements are removed for: - PKT_TX_OUTER_IP_CKSUM - PKT_TX_IP_

[dpdk-dev] [PATCH 0/2] mbuf: improve Tx offload API doc

2018-04-19 Thread Thomas Monjalon
When reviewing the new tunnel offload flags proposed by Xueming, I have seen that some old doxygen comments should be improved or fixed. Thomas Monjalon (2): mbuf: fix Tx checksum offload API doc mbuf: improve API doc for tunnel Tx offloads lib/librte_ether/rte_ethdev.h | 3 +++ lib/librte_

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/vmxnet3: keep link state consistent

2018-04-19 Thread Ferruh Yigit
On 3/18/2018 1:45 AM, Chas Williams wrote: > From: Chas Williams > > The vmxnet3 never attempts link speed negotiation. As a virtual device > the link speed is vague at best. However, it is important for certain > applications, like bonding, to see a consistent link_status. 802.3ad > requires

[dpdk-dev] [PATCH] drivers/net: fix link autoneg value for virtual PMDs

2018-04-19 Thread Ferruh Yigit
These drivers never attempt link speed negotiation. Change link_autoneg value to ETH_LINK_FIXED to be more accurate and consistent between PMDs. Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- Cc: Chas Williams Cc: Thomas Monjal

[dpdk-dev] [PATCH 1/3] net/bnxt: cache address of doorbell to subsequent access

2018-04-19 Thread Ajit Khaparde
While creating TX, Rx, CQ rings use cached DB address instead of getting it from the PCI memory resource. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 1 + drivers/net/bnxt/bnxt_cpr.c| 2 +- drivers/net/bnxt/bnxt_ethdev.c | 12 drivers/net/bnxt/bnxt_ring.c

[dpdk-dev] [PATCH 2/3] net/bnxt: check vnic_id before issuing set_rx_mask

2018-04-19 Thread Ajit Khaparde
In some cases bnxt_hwrm_cfa_l2_set_rx_mask is being called before VNICs are allocated. The FW returns an error in such cases. Prevent sending the command the FW by checking for a valid vnic id. Fixes: 244bc98b0da7 ("net/bnxt: set L2 Rx mask") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde ---

[dpdk-dev] [PATCH 3/3] net/bnxt: initialize mbuf data_off

2018-04-19 Thread Ajit Khaparde
Initialize mbuf->data_off to RTE_PKTMBUF_HEADROOM after allocation. Without this, it might be possible that the DMA address provided to the HW may not be in sync to what is indicated to the application in bnxt_rx_pkt. Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code") Cc: sta...@dpdk.org Signe

[dpdk-dev] [PATCH 0/3] bnxt patchset

2018-04-19 Thread Ajit Khaparde
Please apply. Ajit Khaparde (3): net/bnxt: cache address of doorbell to subsequent access net/bnxt: check vnic_id before issuing set_rx_mask net/bnxt: initialize mbuf data_off drivers/net/bnxt/bnxt.h| 1 + drivers/net/bnxt/bnxt_cpr.c| 2 +- drivers/net/bnxt/bnxt_ethdev.c | 19

Re: [dpdk-dev] [PATCH v3] drivers/net: update link status

2018-04-19 Thread Ferruh Yigit
On 4/17/2018 12:30 PM, Ferruh Yigit wrote: > Update link status related feature document items and minor updates in > some link status related functions. > > Signed-off-by: Ferruh Yigit > Acked-by: Adrien Mazarguil Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/vmxnet3: increase rx data ring descriptor size

2018-04-19 Thread Ferruh Yigit
On 4/19/2018 10:54 PM, Yong Wang wrote: >> -Original Message- >> From: Shraddha Joshi [mailto:jshrad...@vmware.com] >> Sent: Thursday, April 19, 2018 11:19 AM >> To: Yong Wang >> Cc: dev@dpdk.org; Shraddha Joshi >> Subject: [PATCH] net/vmxnet3: increase rx data ring descriptor size >> >>

Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix for PCI FLR after ungraceful exit

2018-04-19 Thread Ferruh Yigit
On 4/18/2018 9:15 PM, Rasesh Mody wrote: > From: Rasesh Mody > > This patch provides a fix for PCI function level reset after an > ungraceful exit from an application. The fix is to enable internal > target read as part of device attach before getting device information > from device config space

Re: [dpdk-dev] [PATCH] net/vmxnet3: increase rx data ring descriptor size

2018-04-19 Thread Yong Wang
> -Original Message- > From: Shraddha Joshi [mailto:jshrad...@vmware.com] > Sent: Thursday, April 19, 2018 11:19 AM > To: Yong Wang > Cc: dev@dpdk.org; Shraddha Joshi > Subject: [PATCH] net/vmxnet3: increase rx data ring descriptor size > > Vmxnet3 driver supports receive data ring viz.

Re: [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.5

2018-04-19 Thread Luca Boccassi
On Thu, 2018-04-19 at 15:09 +0200, Maxime Coquelin wrote: > Hi Luca, Yuanhan, > > On 03/02/2018 12:20 AM, Lee Roberts wrote: > > Fix kni compilation under RHEL 7.5. > > > > Signed-off-by: Lee Roberts > > --- > >   lib/librte_eal/linuxapp/kni/compat.h | 5 + > >   1 file changed, 5 insertions(

Re: [dpdk-dev] [PATCH] net/mvpp2: update maintainers

2018-04-19 Thread Ferruh Yigit
On 4/19/2018 11:48 AM, Tomasz Duszynski wrote: > Jacek will no longer be maintaining mvpp2 net PMD. > Special thanks to him for his development and support. > > Signed-off-by: Tomasz Duszynski Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] drivers: cleanup unnecessary global variables

2018-04-19 Thread Ferruh Yigit
On 4/19/2018 7:51 PM, Pavan Nikhilesh wrote: > Signed-off-by: Pavan Nikhilesh Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] net/mvpp2: fix build

2018-04-19 Thread Ferruh Yigit
On 4/19/2018 5:09 PM, Thomas Monjalon wrote: > The iterator RTE_ETH_FOREACH_DEV (added in below commit) > requires to enable experimental APIs. > > Fixing also the config option rename in the build test. > > Fixes: 8728ccf37615 ("fix ethdev ports enumeration") > Fixes: fe93968722af ("net/mrvl: re

Re: [dpdk-dev] [PATCH] config: fix meson build

2018-04-19 Thread Ferruh Yigit
On 4/19/2018 9:31 PM, Ferruh Yigit wrote: > New config option "CONFIG_RTE_MAX_VFIO_CONTAINERS=64" introduced and > this config option is used by eal_vfio.c > > Meson config file, rte_config.h, missing this config option causing > build error with meson, fixed by adding missing config. > > Fixes:

[dpdk-dev] [PATCH] config: fix meson build

2018-04-19 Thread Ferruh Yigit
New config option "CONFIG_RTE_MAX_VFIO_CONTAINERS=64" introduced and this config option is used by eal_vfio.c Meson config file, rte_config.h, missing this config option causing build error with meson, fixed by adding missing config. Fixes: 52d790189dcd ("vfio: extend data structure for multi con

Re: [dpdk-dev] [PATCH v5 0/4] introduce new tunnel types

2018-04-19 Thread Ferruh Yigit
On 4/19/2018 3:57 PM, Thomas Monjalon wrote: > 19/04/2018 16:24, Xueming(Steven) Li: >> From: Iremonger, Bernard >>> I have just cloned the current dpdk master, patch 3 still fails to apply, >>> dpdk-dev-v5-3-4-app-testpmd- >>> introduce-new-tunnel-VXLAN-GPE.patch >>> >>> git am ./dpdk-dev-v5-3-4

[dpdk-dev] rte_panic SIGABRT core dump

2018-04-19 Thread shiva m
Hi, Need help in avoiding core dump in case rte_eal_init() fails in some special cases. Part of my code causing rte_panic during system bootup and causes a core dump. I do not want this core dump. I tried catching SIGABRT in my application and did _exit() in my handler. Still I see core dump fil

[dpdk-dev] [PATCH] drivers: cleanup unnecessary global variables

2018-04-19 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- drivers/bus/dpaa/base/fman/netcfg_layer.c | 5 - drivers/bus/dpaa/base/qbman/bman_driver.c | 4 ++-- drivers/bus/dpaa/base/qbman/qman.c| 2 +- drivers/bus/dpaa/base/qbman/qman_driver.c | 4 ++-- drivers/bus/dpaa/base/qbman/qman_priv.h

[dpdk-dev] [PATCH] net/vmxnet3: increase rx data ring descriptor size

2018-04-19 Thread Shraddha Joshi
Vmxnet3 driver supports receive data ring viz. a set of small sized buffers that are always mapped by the emulation. If a packet fits into the receive data ring buffer, the emulation delivers the packet via the receive data ring. Increasing the receive data ring descriptor size from 128 to 256 sho

Re: [dpdk-dev] [PATCH v4 11/11] devtools: prevent new instances of rte_panic and rte_exit

2018-04-19 Thread Aaron Conole
Arnon Warshavsky writes: > This patch adds a new function that is called > per every checked patch, > and alerts for new instances of rte_panic/rte_exit. > The check excludes comments, and alerts in the case > of a positive balance between additions and removals. > > Signed-off-by: Arnon Warshavs

Re: [dpdk-dev] [PATCH v4 10/11] eal: replace rte_panic instances in init sequence

2018-04-19 Thread Aaron Conole
Arnon Warshavsky writes: > Local functions to this file, > changing from void to int are non-abi-breaking. > For handling the single function that cannot > change from void to int due to abi, > where this is the only place it is called in, > I added a state variable that is being checked > right

Re: [dpdk-dev] [PATCH v4 10/11] eal: replace rte_panic instances in init sequence

2018-04-19 Thread Kevin Traynor
On 04/19/2018 03:57 PM, Burakov, Anatoly wrote: > On 19-Apr-18 3:48 PM, Arnon Warshavsky wrote: >> Copy on the commit message and volatile. >> >> Regarding the new function defunct_and_remain_in_endless_loop () >> I don't think I can put that in a separate patch without breaking the >> current pat

Re: [dpdk-dev] [PATCH v4 09/11] eal: replace rte_panic instances in ethdev

2018-04-19 Thread Kevin Traynor
On 04/19/2018 07:01 AM, Arnon Warshavsky wrote: > Local function to this file, > changing from void to int is non-abi-breaking > > Signed-off-by: Arnon Warshavsky > --- > lib/librte_ether/rte_ethdev.c | 36 +--- > 1 file changed, 25 insertions(+), 11 deletions(-)

Re: [dpdk-dev] [PATCH v4 08/11] eal: replace rte_panic instances in interrupts thread

2018-04-19 Thread Kevin Traynor
On 04/19/2018 07:01 AM, Arnon Warshavsky wrote: > replace panic calls with log and retrun value. > Thread function removes the noretrun attribute. > > Signed-off-by: Arnon Warshavsky > --- > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 27 --- > 1 file changed, 20 inser

Re: [dpdk-dev] [PATCH v4 05/11] eal: replace rte_panic instances in eventdev

2018-04-19 Thread Kevin Traynor
On 04/19/2018 07:01 AM, Arnon Warshavsky wrote: > replace panic calls with log and retrun value. > > -- > v4 - fix split literal strings in log messages > > Signed-off-by: Arnon Warshavsky > --- > lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +--- > lib/librte_eventdev/rte_eventdev_pmd_v

Re: [dpdk-dev] [PATCH v4 04/11] ixgbe: replace rte_panic instances in ixgbe driver

2018-04-19 Thread Kevin Traynor
On 04/19/2018 07:01 AM, Arnon Warshavsky wrote: > replace panic calls with log and retrun value. typo return, seems to be in a few commit msgs > Local function to this file, > changing from void to int is non-abi-breaking > > Signed-off-by: Arnon Warshavsky > --- > drivers/net/ixgbe/ixgbe_ethd

Re: [dpdk-dev] [PATCH v4 03/11] e1000: replace rte_panic instances in e1000 driver

2018-04-19 Thread Kevin Traynor
On 04/19/2018 07:01 AM, Arnon Warshavsky wrote: > replace panic calls with log and retrun value. > Local function to this file, > changing from void to int is non-abi-breaking > -- > v4 - keep error message literal string in a singhle line > > Signed-off-by: Arnon Warshavsky > --- > drivers/net/

Re: [dpdk-dev] [PATCH v4 02/11] bond: replace rte_panic instances in bonding driver

2018-04-19 Thread Kevin Traynor
On 04/19/2018 07:01 AM, Arnon Warshavsky wrote: > replace panic calls with log and retrun value. > Local functions to this file, > changing from void to int are non-abi-breaking > -- > v4 - fix split literal strings in log messages > > Signed-off-by: Arnon Warshavsky > --- > drivers/net/bonding/

Re: [dpdk-dev] [PATCH 1/2] build: fix kernel compile on cross-build

2018-04-19 Thread Hemant Agrawal
> > > -Original Message- > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce > > > Richardson > > > > > > When cross-compiling, if no kernel_dir was specified, then the > > > kernel modules were still being compiled for the build machine. Fix > > > this by only building modules

[dpdk-dev] [PATCH 4/4] crypto/dpaa_sec: update maximum queue pairs to 2

2018-04-19 Thread Hemant Agrawal
From: Nipun Gupta Signed-off-by: Nipun Gupta --- drivers/crypto/dpaa_sec/dpaa_sec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h b/drivers/crypto/dpaa_sec/dpaa_sec.h index 1433595..5b25aa1 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.h

[dpdk-dev] [PATCH 3/4] crypto/dpaa2_sec: fix HMAC supported digest sizes

2018-04-19 Thread Hemant Agrawal
For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported digest sizes are not a fixed value, but a range between 1 and the maximum digest size for those algorithms. Fixes: f947fd77185f ("crypto/dpaa2_sec: fix HMAC supported key sizes") Cc: sta...@dpdk.org Signed-off-by: Nipun Gupta Signed-off-by

[dpdk-dev] [PATCH 1/4] crypto/dpaa_sec: support dynamic logging

2018-04-19 Thread Hemant Agrawal
This patch adds the support for dynamic logging in dpaa_sec. Signed-off-by: Hemant Agrawal --- config/common_base | 3 - config/defconfig_arm64-dpaa-linuxapp-gcc | 7 -- doc/guides/cryptodevs/dpaa_sec.rst | 21 +++-- drivers/crypto/dpaa_sec/Makefile | 5

[dpdk-dev] [PATCH 2/4] crypto/dpaa_sec: fix HMAC supported digest sizes

2018-04-19 Thread Hemant Agrawal
For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported digest sizes are not a fixed value, but a range between 1 and the maximum digest size for those algorithms. Also setting iv_size as 0. Fixes: c3e85bdcc6e6 ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") Cc: sta...@dpdk.org Sign

[dpdk-dev] [PATCH v3 4/5] drivers/net: not use private eth dev data

2018-04-19 Thread Jianfeng Tan
We introduced private rte_eth_dev_data to allow vdev to be created both in primary process and secondary process(es). This is not friendly to multi-process model, for example, it leads to port id contention issue if two processes both find the data entry is free. And to get stats of primary vdev i

[dpdk-dev] [PATCH v3 5/5] drivers/net: share vdev data to secondary process

2018-04-19 Thread Jianfeng Tan
dpdk-procinfo, as a secondary process, cannot fetch stats for vdev. This patch enables that by attaching the port from the shared data. We also fill the eth dev ops, with only some ops works in secondary process, for example, stats_get(). Note that, we still cannot Rx/Tx packets on the ports whic

[dpdk-dev] [PATCH v3 1/5] eal: bring forward multi-process channel init

2018-04-19 Thread Jianfeng Tan
Adjust the init sequence: put mp channel init before bus scan so that we can init the vdev bus through mp channel in the secondary process before the bus scan. Signed-off-by: Jianfeng Tan Reviewed-by: Qi Zhang --- lib/librte_eal/bsdapp/eal/eal.c | 23 +-- lib/librte_eal/li

[dpdk-dev] [PATCH v3 3/5] bus/vdev: bus scan by multi-process channel

2018-04-19 Thread Jianfeng Tan
To scan the vdevs in primary, we send request to primary process to obtain the names for vdevs. Only the name is shared from the primary. In probe(), the device driver is supposed to locate (or request more) the detail information from the primary. Signed-off-by: Jianfeng Tan Reviewed-by: Qi Zha

[dpdk-dev] [PATCH v3 2/5] bus/vdev: add lock on vdev device list

2018-04-19 Thread Jianfeng Tan
As we could add virtual devices from different threads now, we add a spin lock to protect the vdev device list. Suggested-by: Anatoly Burakov Signed-off-by: Jianfeng Tan Reviewed-by: Qi Zhang --- drivers/bus/vdev/vdev.c | 61 + 1 file changed, 47

[dpdk-dev] [PATCH v3 0/5] allow procinfo and pdump on eth vdev

2018-04-19 Thread Jianfeng Tan
v3: - Update doc. - Rebase on master. v2: - Add spinlock for vdev device list as suggested by Anatoly. - Add ring, cxgbe and remove the free in each PMDs as suggested by Matan. - Rebase on master. As we know, we have below limitations in vdev: - dpdk-procinfo cannot get the stats of (

Re: [dpdk-dev] [PATCH v1 6/6] doc: advertise bucket mempool driver

2018-04-19 Thread Olivier Matz
On Mon, Mar 26, 2018 at 05:12:59PM +0100, Andrew Rybchenko wrote: > Signed-off-by: Andrew Rybchenko > --- > doc/guides/rel_notes/release_18_05.rst | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/doc/guides/rel_notes/release_18_05.rst > b/doc/guides/rel_notes/release_18_05.rst

Re: [dpdk-dev] [PATCH v1 2/6] mempool: implement abstract mempool info API

2018-04-19 Thread Olivier Matz
On Mon, Mar 26, 2018 at 05:12:55PM +0100, Andrew Rybchenko wrote: > From: "Artem V. Andreev" > > Primarily, it is intended as a way for the mempool driver to provide > additional information on how it lays up objects inside the mempool. > > Signed-off-by: Artem V. Andreev > Signed-off-by: Andre

[dpdk-dev] [PATCH v2 5/8] net/sfc: process RSS settings on Rx configure step

2018-04-19 Thread Andrew Rybchenko
From: Ivan Malov One may submit advanced RSS settings as part of rte_eth_conf to customise RSS configuration from the very beginning. Currently the driver does not check that piece of settings and proceeds with default choices for RSS hash functions and RSS key. This patch implements the require

[dpdk-dev] [PATCH v2 8/8] net/sfc: convert to the advanced EFX RSS interface

2018-04-19 Thread Andrew Rybchenko
From: Ivan Malov The current code has the following drawbacks: - It is assumed that TCP 4-tuple hash is always supported, which is untrue in the case of packed stream FW variant. - The driver is unaware of UDP hash support available with latest firmware. In order to cope with the ment

[dpdk-dev] [PATCH v2 7/8] net/sfc: factor out RSS fields from adapter info

2018-04-19 Thread Andrew Rybchenko
From: Ivan Malov RSS handling will need more sophisticated fields in the adapter context storage in future patches. This patch groups existing fields in a dedicated structure and updates the rest of the code. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc.c

[dpdk-dev] [PATCH v2 6/8] net/sfc: remove conditional compilation for RSS

2018-04-19 Thread Andrew Rybchenko
From: Ivan Malov RSS is one of the most valuable features in the driver, and one would hardly need to disable it at build time. This patch withdraws unnecessary conditionals for RSS snippets. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc.c| 10 -

[dpdk-dev] [PATCH v2 4/8] net/sfc/base: honour packed stream RSS restriction

2018-04-19 Thread Andrew Rybchenko
From: Ivan Malov Packed stream firmware variant on EF10 adapters has a number of properties which must be taken into account: - Only one exclusive RSS context is available per port. - Only IP addresses can contribute to the hash value. Huntington and Medford have one more limitation which is

[dpdk-dev] [PATCH v2 3/8] net/sfc/base: support more RSS hash configurations

2018-04-19 Thread Andrew Rybchenko
From: Ivan Malov Modern firmwares on EF10 adapters have support for more traffic classes eligible for hash computation. Also, it has become possible to adjust hashing per individual class and select distinct packet fields which will be able to contribute to the hash value. This patch adds suppor

[dpdk-dev] [PATCH v2 0/8] net/sfc: RSS improvements

2018-04-19 Thread Andrew Rybchenko
The patch series should be applied on top of [1]. checkpatches.sh warnings are bacause of positive errno used inside the driver. checkpatches.sh checks are OK. [1] https://dpdk.org/ml/archives/dev/2018-April/098047.html Andrew Rybchenko (1): net/sfc/base: cope with clang warning on negative s

[dpdk-dev] [PATCH v2 2/8] net/sfc/base: add a new means to control RSS hash

2018-04-19 Thread Andrew Rybchenko
From: Ivan Malov Currently, libefx has no support for additional RSS modes available with later controllers. In order to support this, libefx should be able to list available hash configurations. This patch provides basic infrastructure for the new interface. The client drivers will be able to q

[dpdk-dev] [PATCH v2 1/8] net/sfc/base: cope with clang warning on negative shift

2018-04-19 Thread Andrew Rybchenko
clang 4.0.1-6 on Ubuntu generates false positive warning that shift is negative. It is done regardless of the fact that the branch is not taken because of previous check. The warning is generate in EFX_INSERT_NATIVE32 used by EFX_INSERT_FIELD_NATIVE32. All similar cases are fixed as well. It is

Re: [dpdk-dev] [PATCH v1 3/6] mempool: support block dequeue operation

2018-04-19 Thread Olivier Matz
On Mon, Mar 26, 2018 at 05:12:56PM +0100, Andrew Rybchenko wrote: > From: "Artem V. Andreev" > > If mempool manager supports object blocks (physically and virtual > contiguous set of objects), it is sufficient to get the first > object only and the function allows to avoid filling in of > informa

Re: [dpdk-dev] [PATCH v1 0/6] mempool: add bucket driver

2018-04-19 Thread Olivier Matz
Hi Andrew, Sorry for the late feedback, few comments below. On Mon, Mar 26, 2018 at 05:12:53PM +0100, Andrew Rybchenko wrote: > The initial patch series [1] (RFCv1 is [2]) is split into two to simplify > processing. It is the second part which relies on the first one [3]. > > It should be appli

Re: [dpdk-dev] [PATCH v2 0/3] ZUC PMD fixes

2018-04-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, April 19, 2018 3:56 PM > To: dev@dpdk.org > Cc: Trahe, Fiona ; De Lara Guarch, Pablo > > Subject: [PATCH v2 0/3] ZUC PMD fixes > > ZUC library provides an API to encrypt buffers in parallel with different > keys. > Ho

[dpdk-dev] [PATCH] mem: unmap unneeded space

2018-04-19 Thread Anatoly Burakov
When we ask to reserve virtual areas, we usually include alignment in the mapping size, and that memory ends up being wasted. Wasting a gigabyte of VA space while trying to reserve one gigabyte is pretty expensive on 32-bit, so after we're done mapping, unmap unneeded space. Signed-off-by: Anatoly

Re: [dpdk-dev] [PATCH] bus/fslmc: fix the compilation with clang 3.4

2018-04-19 Thread Thomas Monjalon
19/04/2018 15:21, Maxime Coquelin: > On 04/19/2018 02:32 PM, Hemant Agrawal wrote: > > error: redefinition of typedef 'dma_addr_t' is a C11 feature > > [-Werror,-Wtypedef-redefinition] > > > > Fixes: 4bc5ab88dbd6 ("net/dpaa2: fix Tx only mode") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Heman

[dpdk-dev] minutes of Techboard meeting 2018-04-11

2018-04-19 Thread Richardson, Bruce
0) Check action items from last meetings - list of files and initial authors for SPDX compliance - Good progress here - For completeness all files should have license and copyright - For files used

Re: [dpdk-dev] [PATCH 1/7] net/sfc/base: add a new means to control RSS hash

2018-04-19 Thread Andrew Rybchenko
On 04/06/2018 08:21 PM, Andrew Rybchenko wrote: From: Ivan Malov Currently, libefx has no support for additional RSS modes available with later controllers. In order to support this, libefx should be able to list available hash configurations. This patch provides basic infrastructure for the n

Re: [dpdk-dev] [PATCH 1/2] build: fix kernel compile on cross-build

2018-04-19 Thread Bruce Richardson
On Thu, Apr 19, 2018 at 03:46:14PM +, Hemant Agrawal wrote: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > > > When cross-compiling, if no kernel_dir was specified, then the kernel > > modules > > were still being compiled for the

[dpdk-dev] [PATCH] net/mvpp2: fix build

2018-04-19 Thread Thomas Monjalon
The iterator RTE_ETH_FOREACH_DEV (added in below commit) requires to enable experimental APIs. Fixing also the config option rename in the build test. Fixes: 8728ccf37615 ("fix ethdev ports enumeration") Fixes: fe93968722af ("net/mrvl: rename PMD as mvpp2") Reported-by: Ferruh Yigit Signed-off-

Re: [dpdk-dev] Why packet replication is more efficient when done using memcpy( ) as compared to rte_mbuf_refcnt_update() function?

2018-04-19 Thread Wiles, Keith
> On Apr 19, 2018, at 9:30 AM, Shailja Pandey wrote: > >> The two code fragments are doing two different ways the first is using a >> loop to create possible more then one replication and the second one is not, >> correct? The loop can cause performance hits, but should be small. > Sorry for

Re: [dpdk-dev] [PATCH] crypto/mrvl: update maintainers

2018-04-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski > Sent: Thursday, April 19, 2018 11:48 AM > To: dev@dpdk.org > Cc: d...@marvell.com; nsams...@marvell.com; Tomasz Duszynski > > Subject: [dpdk-dev] [PATCH] crypto/mrvl: update maintainers > > Ja

Re: [dpdk-dev] [PATCH 1/2] eal: add macro to mark variable mostly read only

2018-04-19 Thread Pavan Nikhilesh
On Thu, Apr 19, 2018 at 04:37:23PM +0100, Bruce Richardson wrote: > On Thu, Apr 19, 2018 at 08:48:33PM +0530, Pavan Nikhilesh wrote: > > On Thu, Apr 19, 2018 at 01:09:58PM +0100, Bruce Richardson wrote: > > > On Thu, Apr 19, 2018 at 02:50:52PM +0530, Pavan Nikhilesh wrote: > > > > On Wed, Apr 18, 2

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types

2018-04-19 Thread Xueming(Steven) Li
> -Original Message- > From: Adrien Mazarguil > Sent: Wednesday, April 18, 2018 10:30 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; Nelio Laranjeiro > ; Wenzhuo Lu > ; Jingjing Wu ; Thomas Monjalon > ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only confi

[dpdk-dev] [PATCH v4 2/2] app/testpmd: new parameter for port config all rss command

2018-04-19 Thread Xueming Li
This patches add "default" parameter to "port config all rss" command. "default" means all supported hash types reported by device info. Signed-off-by: Xueming Li --- app/test-pmd/cmdline.c | 13 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 +++- 2 files ch

[dpdk-dev] [PATCH v4 1/2] ethdev: add supported hash function check

2018-04-19 Thread Xueming Li
Add supported RSS hash function check in device configuration to have better error verbosity for application developers. Signed-off-by: Xueming Li --- lib/librte_ether/rte_ethdev.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/li

Re: [dpdk-dev] [PATCH 1/2] build: fix kernel compile on cross-build

2018-04-19 Thread Hemant Agrawal
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > When cross-compiling, if no kernel_dir was specified, then the kernel modules > were still being compiled for the build machine. Fix this by only building > modules > on cross-compile when we

Re: [dpdk-dev] [PATCH v4 0/5] handle seq no overflow in IPsec offload

2018-04-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anoob Joseph > Sent: Wednesday, April 11, 2018 7:41 AM > To: Akhil Goyal ; Doherty, Declan > ; Wu, Jingjing ; Nicolau, > Radu ; Thomas Monjalon ; > Lu, Wenzhuo > Cc: Anoob Joseph ; Jerin Jacob > ; Narayana Prasad

  1   2   3   >