Re: [dpdk-dev] [PATCH v4 2/5] vhost: support selective datapath

2018-03-30 Thread Maxime Coquelin
On 03/10/2018 11:01 AM, Zhihong Wang wrote: This patch set introduces support for selective datapath in DPDK vhost-user lib. vDPA stands for vhost Data Path Acceleration. The idea is to support virtio ring compatible devices to serve virtio driver directly to enable datapath acceleration. A se

Re: [dpdk-dev] [PATCH v4 1/5] vhost: export vhost feature definitions

2018-03-30 Thread Maxime Coquelin
On 03/10/2018 11:01 AM, Zhihong Wang wrote: This patch exports vhost-user protocol features to support device driver development. Signed-off-by: Zhihong Wang --- Changes in v3: 1. Keep macro names the same as in the spec. lib/librte_vhost/rte_vhost.h | 30 ++

Re: [dpdk-dev] [PATCH v2] vhost: add support for interrupt mode

2018-03-30 Thread Tan, Jianfeng
On 3/29/2018 10:37 PM, Junjie Chen wrote: In some cases we want vhost dequeue work in interrupt mode to release cpus to others when no data to transmit. So we install interrupt handler of vhost device and interrupt vectors for each rx queue when creating new backend according to vhost intrerupt

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-30 Thread Thomas Monjalon
21/03/2018 15:27, Remy Horton: > +/* > + * Preferred Rx/Tx port parameters. > + */ > +struct rte_eth_dev_portconf { > + uint16_t burst_size; > + uint16_t ring_size; > + uint16_t nb_queues; > +}; Please add a doxygen comment for each field, thanks.

Re: [dpdk-dev] [pull-request] next-net 18.05 PRE-RC1

2018-03-30 Thread Thomas Monjalon
30/03/2018 14:21, Ferruh Yigit: > http://dpdk.org/git/next/dpdk-next-net Pulled except the series below: > Remy Horton (4): > ethdev: add support for PMD-tuned Tx/Rx parameters > net/e1000: add TxRx tuning parameters > net/i40e: add TxRx tuning parameters > app/testpmd:

Re: [dpdk-dev] [PATCH v2 0/4] ethdev: add per-PMD tuning of RxTx parmeters

2018-03-30 Thread Thomas Monjalon
30/03/2018 12:34, Ferruh Yigit: > On 3/27/2018 7:43 PM, Ferruh Yigit wrote: > > On 3/21/2018 2:27 PM, Remy Horton wrote: > >> The optimal values of several transmission & reception related parameters, > >> such as burst sizes, descriptor ring sizes, and number of queues, varies > >> between differe

Re: [dpdk-dev] [PATCH v2 4/4] testpmd: make use of per-PMD TxRx parameters

2018-03-30 Thread Thomas Monjalon
21/03/2018 15:27, Remy Horton: > /* > * Configurable number of RX/TX ring descriptors. Configurable, really? > + * Defaults are supplied by drivers via ethdev. And fallback values are in ethdev. > */ > -#define RTE_TEST_RX_DESC_DEFAULT 1024 > -#define RTE_TEST_TX_DESC_DEFAULT 1024 > +#defi

Re: [dpdk-dev] [PATCH v6 2/2] app/testpmd: add commands to test new Tx offload API

2018-03-30 Thread Wu, Jingjing
> -Original Message- > From: Dai, Wei > Sent: Thursday, March 22, 2018 1:00 AM > To: Lu, Wenzhuo ; Wu, Jingjing > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v6 2/2] app/testpmd: add commands to test new Tx offload API > > Add following testpmd run-time commands to support test of > n

[dpdk-dev] [pull-request] next-crypto 18.05 pre-rc1

2018-03-30 Thread Pablo de Lara
The following changes since commit 984af543c254be1fc3f0ae46f381d75dcd0af361: mk: fix kernel modules build dependency (2018-03-30 13:01:17 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to de607114fcbb9eeacb0cf1ebc8aee675

Re: [dpdk-dev] [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: Ravi Kumar [mailto:ravi1.ku...@amd.com] > Sent: Monday, March 19, 2018 12:24 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com > Subject: [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD > > Signed-off-by: Ravi Kumar Patchset

[dpdk-dev] [PATCH] maintainers: claim responsibility for vmxnet3 pmd

2018-03-30 Thread Yong Wang
Signed-off-by: Yong Wang --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 75d3e92c8..7bc370cf4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -552,7 +552,7 @@ F: doc/guides/nics/sfc_efx.rst F: doc/guides/nics/features/sfc_efx.ini

Re: [dpdk-dev] [PATCH 2/4] app/eventdev: add burst mode for event timer adapter

2018-03-30 Thread Carrillo, Erik G
Hi Pavan, One comment in-line: > -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Sunday, March 18, 2018 8:12 AM > To: jerin.ja...@caviumnetworks.com; > santosh.shu...@caviumnetworks.com; Carrillo, Erik G > > Cc: dev@dpdk.org; Pavan Nikhilesh >

Re: [dpdk-dev] [PATCH 1/4] app/eventdev: add event timer adapter as a producer

2018-03-30 Thread Carrillo, Erik G
Hi Pavan, Some comments in-line: > -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Sunday, March 18, 2018 8:12 AM > To: jerin.ja...@caviumnetworks.com; > santosh.shu...@caviumnetworks.com; Carrillo, Erik G > > Cc: dev@dpdk.org; Pavan Nikhilesh

Re: [dpdk-dev] [PATCH 1/4] introduce Broadcom Stingray

2018-03-30 Thread Scott Branden
On 18-03-30 03:34 AM, Ferruh Yigit wrote: On 3/21/2018 6:06 PM, Ajit Khaparde wrote: From: Scott Branden Add Broadcom Stingray machine support based on armv8. For product brief see: https://www.broadcom.com/products/ethernet-connectivity/controllers/bcm58800 Signed-off-by: Scott Branden S

Re: [dpdk-dev] [PATCH v8 7/9] test: add event timer adapter auto-test

2018-03-30 Thread Carrillo, Erik G
Hi Pavan, > -Original Message- > From: Bhagavatula, Pavan [mailto:pavan.bhagavat...@cavium.com] > Sent: Friday, March 30, 2018 10:49 AM > To: Carrillo, Erik G ; Jacob, Jerin > ; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v8 7/9] test: add event t

Re: [dpdk-dev] [PATCH 2/4] net/bnxt: add support for Stingray PF devices ids

2018-03-30 Thread Scott Branden
On 18-03-30 03:35 AM, Ferruh Yigit wrote: On 3/21/2018 6:06 PM, Ajit Khaparde wrote: From: Scott Branden Add support for Stingray PF devices ids: BCM58802 = 0xd802 BCM58804 = 0xd804 BCM58808 = 0x16f0 Signed-off-by: Scott Branden Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_eth

Re: [dpdk-dev] [PATCH 3/4] mk: allow kernel artifacts to be located in output directory

2018-03-30 Thread Scott Branden
Hi Ferruh, On 18-03-30 03:35 AM, Ferruh Yigit wrote: On 3/21/2018 6:06 PM, Ajit Khaparde wrote: From: Scott Branden Allow kernel artifacts to be located in output directory specific by RTE_KERNELDIR_OUT. How to use this variable, I tried following but kernel modules are still in same place:

Re: [dpdk-dev] [PATCH v2] net/bnxt: convert to SPDX license tag

2018-03-30 Thread Scott Branden
Hi Ferruh, On 18-03-30 03:35 AM, Ferruh Yigit wrote: On 3/29/2018 5:40 PM, Ajit Khaparde wrote: From: Scott Branden Update the license header on bnxt files to be the standard BSD-3-Clause license used for the rest of DPDK, bring the files in compliance with the DPDK licensing policy. Signed

[dpdk-dev] [PATCH v3 4/4] net/ifcvf: add driver document and release note

2018-03-30 Thread Xiao Wang
Signed-off-by: Xiao Wang --- doc/guides/nics/features/ifcvf.ini | 8 doc/guides/nics/ifcvf.rst | 85 ++ doc/guides/nics/index.rst | 1 + doc/guides/rel_notes/release_18_05.rst | 9 4 files changed, 103 insertions(+) creat

[dpdk-dev] [PATCH v3 2/4] net/virtio: skip device probe in vdpa mode

2018-03-30 Thread Xiao Wang
If we want a virtio device to work in vDPA (vhost data path acceleration) mode, we could add a "vdpa=1" devarg for this device to specify the mode. This patch let virtio pmd skip device probe when detecting this parameter. Signed-off-by: Xiao Wang --- drivers/net/virtio/virtio_ethdev.c | 43 +++

[dpdk-dev] [PATCH v3 3/4] net/ifcvf: add ifcvf vdpa driver

2018-03-30 Thread Xiao Wang
The IFCVF vDPA (vhost data path acceleration) driver provides support for the Intel FPGA 100G VF (IFCVF). IFCVF's datapath is virtio ring compatible, it works as a HW vhost backend which can send/receive packets to/from virtio directly by DMA. Different VF devices serve different virtio frontends

[dpdk-dev] [PATCH v3 0/3] add ifcvf vdpa driver

2018-03-30 Thread Xiao Wang
This patch set has dependency on http://dpdk.org/dev/patchwork/patch/36772/ (vhost: support selective datapath). IFCVF driver The IFCVF vDPA (vhost data path acceleration) driver provides support for the Intel FPGA 100G VF (IFCVF). IFCVF's datapath is virtio ring compatible, it works

[dpdk-dev] [PATCH v3 1/4] eal/vfio: add support for multiple container

2018-03-30 Thread Xiao Wang
From: Junjie Chen Currently eal vfio framework binds vfio group fd to the default container fd, while in some cases, e.g. vDPA (vhost data path acceleration), we want to set vfio group to a new container and program DMA mapping via this new container, so this patch adds APIs to support multiple c

Re: [dpdk-dev] [RFC PATCH 5/5] test: add few eBPF samples

2018-03-30 Thread Ananyev, Konstantin
Hi Jerin, > > > Add few simple eBPF programs as an example. > > > > > > Signed-off-by: Konstantin Ananyev > > > diff --git a/test/bpf/mbuf.h b/test/bpf/mbuf.h > > > new file mode 100644 > > > index 0..aeef6339d > > > --- /dev/null > > > +++ b/test/bpf/mbuf.h > > > @@ -0,0 +1,556 @@ > > > +

[dpdk-dev] [PATCH v2 4/7] bpf: add JIT compilation for x86_64 ISA

2018-03-30 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- lib/librte_bpf/Makefile |3 + lib/librte_bpf/bpf.c |5 + lib/librte_bpf/bpf_jit_x86.c | 1329 ++ lib/librte_bpf/meson.build |4 + 4 files changed, 1341 insertions(+) create mode 100644 lib/li

[dpdk-dev] [PATCH v2 7/7] test: add few eBPF samples

2018-03-30 Thread Konstantin Ananyev
Add few simple eBPF programs as an example. Signed-off-by: Konstantin Ananyev --- test/bpf/dummy.c | 20 ++ test/bpf/mbuf.h | 578 +++ test/bpf/t1.c| 52 + test/bpf/t2.c| 31 +++ test/bpf/t3.c| 36 5 files changed, 717

[dpdk-dev] [PATCH v2 6/7] testpmd: new commands to load/unload BPF filters

2018-03-30 Thread Konstantin Ananyev
Introduce new testpmd commands to load/unload RX/TX BPF-based filters. Signed-off-by: Konstantin Ananyev --- app/test-pmd/bpf_sup.h | 25 app/test-pmd/cmdline.c | 146 +++ app/test-pmd/meson.build | 2 +- 3 files changed, 172 insertions

[dpdk-dev] [PATCH v2 2/7] bpf: add BPF loading and execution framework

2018-03-30 Thread Konstantin Ananyev
librte_bpf provides a framework to load and execute eBPF bytecode inside user-space dpdk based applications. It supports basic set of features from eBPF spec (https://www.kernel.org/doc/Documentation/networking/filter.txt). Not currently supported features: - JIT - cBPF - tail-pointer call - e

[dpdk-dev] [PATCH v2 5/7] bpf: introduce basic RX/TX BPF filters

2018-03-30 Thread Konstantin Ananyev
Introduce API to install BPF based filters on ethdev RX/TX path. Current implementation is pure SW one, based on ethdev RX/TX callback mechanism. Signed-off-by: Konstantin Ananyev --- lib/librte_bpf/Makefile| 2 + lib/librte_bpf/bpf_pkt.c | 607 +++

[dpdk-dev] [PATCH v2 3/7] bpf: add more logic into bpf_validate()

2018-03-30 Thread Konstantin Ananyev
Add checks for: - all instructions are valid ones (known opcodes, correct syntax, valid reg/off/imm values, etc.) - no unreachable instructions - no loops - basic stack boundaries checks - division by zero Still need to add checks for: - use/return only initialized registers and stack dat

[dpdk-dev] [PATCH v2 1/7] net: move BPF related definitions into librte_net

2018-03-30 Thread Konstantin Ananyev
Different linux distro may include partial definitions for eBPF while the linux kernel (or dpdk) may support given eBPF feature. To avoid issues define in one place all that is needed (and/or supported) by various DPDK components. Signed-off-by: Konstantin Ananyev --- drivers/net/tap/tap_bpf.h

[dpdk-dev] [PATCH v2 0/7] add framework to load and execute BPF code

2018-03-30 Thread Konstantin Ananyev
BPF is used quite intensively inside Linux (and BSD) kernels for various different purposes and proved to be extremely useful. BPF inside DPDK might also be used in a lot of places for a lot of similar things. As an example to: - packet filtering/tracing (aka tcpdump) - packet classification - st

Re: [dpdk-dev] [PATCH v3 2/2] octeontx: move mbox to common folder

2018-03-30 Thread Pavan Nikhilesh
Hi Thomas, Thanks for the comments, will send out v4 soon addressing the comments. I have verified static and shared builds already and everything seems to be good. Pavan On Tue, Mar 27, 2018 at 06:15:56PM +0200, Thomas Monjalon wrote: > Hi, > > 26/03/2018 09:53, Pavan Nikhilesh: > > Move common

Re: [dpdk-dev] [PATCH v2] net/mlx5: add ptype table idx for TCP ACK packets

2018-03-30 Thread Yongseok Koh
On Fri, Mar 30, 2018 at 01:13:38PM +0800, Bin Huang wrote: > From: Bin Huang > > According to CQE format: > - l4_hdr_type: > 0 - None > 1 - TCP header was present in the packet > 2 - UDP header was present in the packet > 3 - TCP header was present in the packet with Empty >

Re: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status on start

2018-03-30 Thread Chas Williams
On Fri, Mar 30, 2018 at 12:30 PM, Zhang, Helin wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chas Williams >> Sent: Wednesday, February 14, 2018 6:56 AM >> To: dev@dpdk.org >> Cc: Lu, Wenzhuo; Ananyev, Konstantin; Charles (Chas) Williams >> Subjec

Re: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status on start

2018-03-30 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chas Williams > Sent: Wednesday, February 14, 2018 6:56 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo; Ananyev, Konstantin; Charles (Chas) Williams > Subject: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status o

Re: [dpdk-dev] [PATCH v4 09/20] eal/dev: implement device iteration initialization

2018-03-30 Thread Wiles, Keith
> On Mar 30, 2018, at 10:53 AM, Gaëtan Rivet wrote: > > Hello Keith, Hello Gaëtan, >>> + layers[i].kvlist = rte_kvargs_parse(copy, NULL); >>> + free(copy); >> >> I am sorry this method of not adding blank lines is a bit silly and we need >> to rethink at least adding a f

Re: [dpdk-dev] [PATCH 3/7] app/crypto-perf: enable it for non default mempool

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > Sent: Tuesday, March 27, 2018 1:01 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > akhil.go...@nxp.com > Subject: [PATCH 3/7] app/crypto-perf: enable it for non default mempool > > The current code usages

Re: [dpdk-dev] [PATCH 3/7] app/crypto-perf: enable it for non default mempool

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > Sent: Tuesday, March 27, 2018 1:01 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > akhil.go...@nxp.com > Subject: [PATCH 3/7] app/crypto-perf: enable it for non default mempool > > The current code usages

Re: [dpdk-dev] [PATCH 1/7] test/crypto: add macro for dpaa sec device name

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > Sent: Tuesday, March 27, 2018 1:01 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > akhil.go...@nxp.com > Subject: [PATCH 1/7] test/crypto: add macro for dpaa sec device name > > From: Ashish Jain > > Fi

Re: [dpdk-dev] [PATCH 2/7] app/crypto-perf: fix excess crypto device error

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > Sent: Tuesday, March 27, 2018 1:01 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > akhil.go...@nxp.com > Subject: [PATCH 2/7] app/crypto-perf: fix excess crypto device error > > If number of available dev

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-30 Thread Thomas Monjalon
30/03/2018 17:40, Thomas Monjalon: > I know that this patch is already applied, > but I have some comments below. > Please try to address them. > > 21/03/2018 15:27, Remy Horton: > > + /* If number of queues specified by application for both Rx and Tx is > > +* zero, use driver preferred val

Re: [dpdk-dev] [PATCH v4 09/20] eal/dev: implement device iteration initialization

2018-03-30 Thread Gaëtan Rivet
Hello Keith, On Fri, Mar 30, 2018 at 03:22:59PM +, Wiles, Keith wrote: > > > > On Mar 29, 2018, at 4:23 PM, Gaetan Rivet wrote: > > > > Parse a device description. > > Split this description in their relevant part for each layers. > > No dynamic allocation is performed. > > > > Signed-off

Re: [dpdk-dev] [PATCH v8 7/9] test: add event timer adapter auto-test

2018-03-30 Thread Bhagavatula, Pavan
Hi Erik, Few comments below, On Thu, Mar 29, 2018 at 04:27:30PM -0500, Erik Gabriel Carrillo wrote: > Signed-off-by: Erik Gabriel Carrillo > --- > test/test/Makefile |1 + > test/test/test_event_timer_adapter.c | 1837 > ++ > 2 files change

Re: [dpdk-dev] Survey for final decision about per-port offload API

2018-03-30 Thread Thomas Monjalon
30/03/2018 17:13, Andrew Rybchenko: > On 03/30/2018 04:47 PM, Thomas Monjalon wrote: > > There is the same kind of confusion in the offload capabilities: > > rte_eth_dev_info.[rt]x_offload_capa > > rte_eth_dev_info.[rt]x_queue_offload_capa > > The queue capabilities must be a subset of port

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: remove redundant string compare

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Radu Nicolau > Sent: Thursday, March 29, 2018 11:06 AM > To: Anoob Joseph ; Akhil Goyal > > Cc: Doherty, Declan ; Jerin Jacob > ; Narayana Prasad > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-

Re: [dpdk-dev] [PATCH v1] crypto/aesni_mb: support AES CMAC

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Friday, March 30, 2018 4:29 PM > To: Kovacevic, Marko ; dev@dpdk.org > Cc: Jain, Deepak K > Subject: Re: [dpdk-dev] [PATCH v1] crypto/aesni_mb: support AES CMAC > > > > > -Ori

Re: [dpdk-dev] [PATCH v1 2/2] crypto/aesni_gcm: support IPsec Multi-buffer lib v0.49

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Friday, March 30, 2018 4:16 PM > To: Kovacevic, Marko ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 2/2] crypto/aesni_gcm: support IPsec Multi- > buffer lib v0.49 > > > > > --

Re: [dpdk-dev] [PATCH v1 1/2] crypto/aesni_mb: support IPsec MUlti-buffer lib v0.49

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Friday, March 30, 2018 4:16 PM > To: Kovacevic, Marko ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 1/2] crypto/aesni_mb: support IPsec MUlti- > buffer lib v0.49 > > > > > ---

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-30 Thread Thomas Monjalon
I know that this patch is already applied, but I have some comments below. Please try to address them. 21/03/2018 15:27, Remy Horton: > + /* If number of queues specified by application for both Rx and Tx is > + * zero, use driver preferred values. This cannot be done individually > +

Re: [dpdk-dev] [PATCH v2 2/2] ip_pipeline: add ecmp route example

2018-03-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Friday, March 30, 2018 3:31 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH v2 2/2] ip_pipeline: add ecmp route example > > Add example to build pipeline to demonstrate equal-cost multi-path > routing example. > >

Re: [dpdk-dev] [PATCH v2 1/2] ip_pipleine: fix load balance table action

2018-03-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Friday, March 30, 2018 3:31 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH v2 1/2] ip_pipleine: fix load balance table action > > Fix bug in load balance action for pipeline table. > > Signed-off-by: Cristian Dum

Re: [dpdk-dev] [PATCH] vhost: fix build issue caused by unchecked returned values

2018-03-30 Thread Ferruh Yigit
On 3/30/2018 4:16 PM, Maxime Coquelin wrote: > This patch fixes below build issue seen with some compilers > or build options: > > lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: > lib/librte_vhost/fd_man.c:284:2: error: ignoring return value of ‘read’, > declared with attribute warn

Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev

2018-03-30 Thread David Marchand
On Fri, Mar 30, 2018 at 5:17 PM, Ferruh Yigit wrote: > Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it > although it is common for all ethdev in all buses. > > Replacing pci specific struct with generic device struct and updating > places that are using pci device in a way

Re: [dpdk-dev] [PATCH v1] crypto/aesni_mb: support AES CMAC

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: Kovacevic, Marko > Sent: Tuesday, March 27, 2018 1:16 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Jain, Deepak K > ; Kovacevic, Marko > Subject: [PATCH v1] crypto/aesni_mb: support AES CMAC > > From: Marko Kovacevic > > Signed-off-by: Marko Kovacev

Re: [dpdk-dev] [PATCH] vhost: fix build issue caused by unchecked returned values

2018-03-30 Thread Maxime Coquelin
On 03/30/2018 05:21 PM, Ferruh Yigit wrote: On 3/30/2018 4:18 PM, Andrew Rybchenko wrote: On 03/30/2018 06:16 PM, Maxime Coquelin wrote: This patch fixes below build issue seen with some compilers or build options: lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: lib/librte_vhost

Re: [dpdk-dev] [PATCH v4 09/20] eal/dev: implement device iteration initialization

2018-03-30 Thread Wiles, Keith
> On Mar 29, 2018, at 4:23 PM, Gaetan Rivet wrote: > > Parse a device description. > Split this description in their relevant part for each layers. > No dynamic allocation is performed. > > Signed-off-by: Gaetan Rivet > --- > lib/Makefile| 1 + > lib/librte_eal/bs

Re: [dpdk-dev] [PATCH] vhost: fix build issue caused by unchecked returned values

2018-03-30 Thread Ferruh Yigit
On 3/30/2018 4:18 PM, Andrew Rybchenko wrote: > On 03/30/2018 06:16 PM, Maxime Coquelin wrote: >> This patch fixes below build issue seen with some compilers >> or build options: >> >> lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: >> lib/librte_vhost/fd_man.c:284:2: error: ignoring r

Re: [dpdk-dev] [PATCH] vhost: fix build issue caused by unchecked returned values

2018-03-30 Thread Andrew Rybchenko
On 03/30/2018 06:16 PM, Maxime Coquelin wrote: This patch fixes below build issue seen with some compilers or build options: lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: lib/librte_vhost/fd_man.c:284:2: error: ignoring return value of ‘read’, declared with attribute warn_unused_

Re: [dpdk-dev] [PATCH v4 0/2] convert to new Rx/Tx offloads API

2018-03-30 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Friday, March 30, 2018 6:33 PM > To: Wu, Yanglong; dev@dpdk.org > Cc: Dai, Wei; Xing, Beilei > Subject: Re: [dpdk-dev] [PATCH v4 0/2] convert to new Rx/Tx offloads API > > > > > -Origina

[dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev

2018-03-30 Thread Ferruh Yigit
Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it although it is common for all ethdev in all buses. Replacing pci specific struct with generic device struct and updating places that are using pci device in a way to get this information from generic device. Signed-off-by: F

[dpdk-dev] [PATCH] vhost: fix build issue caused by unchecked returned values

2018-03-30 Thread Maxime Coquelin
This patch fixes below build issue seen with some compilers or build options: lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: lib/librte_vhost/fd_man.c:284:2: error: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Werror=unused-result] read(readfd, cha

Re: [dpdk-dev] [PATCH v1 2/2] crypto/aesni_gcm: support IPsec Multi-buffer lib v0.49

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: Kovacevic, Marko > Sent: Tuesday, March 27, 2018 1:15 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Kovacevic, Marko > > Subject: [PATCH v1 2/2] crypto/aesni_gcm: support IPsec Multi-buffer lib v0.49 > > Signed-off-by: Marko Kovacevic Acked-by: Pablo

Re: [dpdk-dev] [PATCH v1 1/2] crypto/aesni_mb: support IPsec MUlti-buffer lib v0.49

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: Kovacevic, Marko > Sent: Tuesday, March 27, 2018 1:14 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Kovacevic, > Marko > Subject: [PATCH v1 1/2] crypto/aesni_mb: support IPsec MUlti-buffer lib > v0.49 > > From: Marko Kovacevic > > Signed-off-by: Mark

Re: [dpdk-dev] Survey for final decision about per-port offload API

2018-03-30 Thread Andrew Rybchenko
On 03/30/2018 04:47 PM, Thomas Monjalon wrote: There are some discussions about a specific part of the offload API: "To enable per-port offload, the offload should be set on both device configuration and queue setup." It means the application must repeat the port offload flags in

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Tonghao Zhang
On Fri, Mar 30, 2018 at 10:59 PM, Maxime Coquelin wrote: > Thanks Xiangxia, > > I can post it, do you agree if I add below comments? yes, thanks. > On 03/30/2018 04:47 PM, Tonghao Zhang wrote: >> >> I rebuild it on ubuntu 17.10 and cash it. I use the 'RTE_SET_USED' to fix >> it. >> >> >> diff --g

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Maxime Coquelin
Thanks Xiangxia, I can post it, do you agree if I add below comments? On 03/30/2018 04:47 PM, Tonghao Zhang wrote: I rebuild it on ubuntu 17.10 and cash it. I use the 'RTE_SET_USED' to fix it. diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c index 771675718..f11803191 100644

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Maxime Coquelin
On 03/30/2018 04:28 PM, Timothy Redaelli wrote: On Fri, 30 Mar 2018 15:27:55 +0200 Maxime Coquelin wrote: Hi Andrew, On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: Hi all, Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Tonghao Zhang
I rebuild it on ubuntu 17.10 and cash it. I use the 'RTE_SET_USED' to fix it. diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c index 771675718..f11803191 100644 --- a/lib/librte_vhost/fd_man.c +++ b/lib/librte_vhost/fd_man.c @@ -279,7 +279,8 @@ fdset_pipe_read_cb(int readfd, voi

[dpdk-dev] [PATCH v2 2/2] ip_pipeline: add ecmp route example

2018-03-30 Thread Jasvinder Singh
Add example to build pipeline to demonstrate equal-cost multi-path routing example. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- v2: - fix checkpatch warnings on file permission. examples/ip_pipeline/examples/route_ecmp.cli | 57 1 file cha

[dpdk-dev] [PATCH v2 1/2] ip_pipleine: fix load balance table action

2018-03-30 Thread Jasvinder Singh
Fix bug in load balance action for pipeline table. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/action.c | 42 ++ examples/ip_pipeline/cli.c| 9 - 2 files changed, 46 insertions(+), 5 deletions(-)

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Timothy Redaelli
On Fri, 30 Mar 2018 15:27:55 +0200 Maxime Coquelin wrote: > Hi Andrew, > > On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: > > Hi all, > > > > Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: > > > > lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: > > lib/librte_vhost/fd

[dpdk-dev] Cross-compile bug: buildtools/check-experimental-syms.sh

2018-03-30 Thread Raphael Cohn
Hi, I'm getting back into using DPDK after a break of about a year, and have tried to compile it again to run on Linux with the musl libc; I'm cross-compiling using a Mac and and a suitable cross toolchain (that works find for lots of other libraries; eg libverbs, rdma-core, etc). One of the firs

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Maxime Coquelin
On 03/30/2018 04:16 PM, Tonghao Zhang wrote: On Fri, Mar 30, 2018 at 10:13 PM, Ferruh Yigit wrote: On 3/30/2018 2:27 PM, Maxime Coquelin wrote: Hi Andrew, On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: Hi all, Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: lib/librte_vhost/f

[dpdk-dev] [PATCH 1/2] ip_pipleine: fix load balance table action

2018-03-30 Thread Jasvinder Singh
Fix bug in load balance action for pipeline table. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/action.c | 42 ++ examples/ip_pipeline/cli.c| 9 - 2 files changed, 46 insertions(+), 5 deletions(-)

[dpdk-dev] [PATCH 2/2] ip_pipeline: add ecmp route example

2018-03-30 Thread Jasvinder Singh
From: Cristian Dumitrescu Add example to build pipeline to demonstrate equal-cost multi-path routing example. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline_new/examples/route_ecmp.cli | 57 1 file changed, 57 insertions(+)

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Tonghao Zhang
On Fri, Mar 30, 2018 at 10:13 PM, Ferruh Yigit wrote: > On 3/30/2018 2:27 PM, Maxime Coquelin wrote: >> Hi Andrew, >> >> On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: >>> Hi all, >>> >>> Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: >>> >>> lib/librte_vhost/fd_man.c: In function ‘fd

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Ferruh Yigit
On 3/30/2018 2:27 PM, Maxime Coquelin wrote: > Hi Andrew, > > On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: >> Hi all, >> >> Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: >> >> lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: >> lib/librte_vhost/fd_man.c:284:2: error: ig

[dpdk-dev] Survey for final decision about per-port offload API

2018-03-30 Thread Thomas Monjalon
There are some discussions about a specific part of the offload API: "To enable per-port offload, the offload should be set on both device configuration and queue setup." It means the application must repeat the port offload flags in rte_eth_conf.[rt]xmode.offloads and rte_eth_[rt]

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Maxime Coquelin
Hi Andrew, On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: Hi all, Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: lib/librte_vhost/fd_man.c:284:2: error: ignoring return value of ‘read’, declared with attribute warn_unus

[dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Andrew Rybchenko
Hi all, Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: lib/librte_vhost/fd_man.c:284:2: error: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Werror=unused-result] read(readfd, charbuf, siz

[dpdk-dev] [pull-request] next-pipeline 18.05 PRE-RC1

2018-03-30 Thread Cristian Dumitrescu
The following changes since commit 20526313ba41174d3e7831ee800f6e938a1d5b85: usertools: support AVP device (2018-03-28 00:49:53 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-pipeline for you to fetch changes up to 36220e6943edf997941f3375e5a5b4a222e45445

Re: [dpdk-dev] [PATCH v4 00/49] ip_pipeline: refactoring

2018-03-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Thursday, March 29, 2018 7:31 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH v4 00/49] ip_pipeline: refactoring > > Refactored the IP pipeline application. As result, the code base > size (lines of code) reduces b

[dpdk-dev] [pull-request] next-net 18.05 PRE-RC1

2018-03-30 Thread Ferruh Yigit
The following changes since commit 984af543c254be1fc3f0ae46f381d75dcd0af361: mk: fix kernel modules build dependency (2018-03-30 13:01:17 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-net for you to fetch changes up to 8dd1be166be212db7f0cc0d4e3f680772c3

Re: [dpdk-dev] [PATCH] mk: fix kernel modules build dependency

2018-03-30 Thread Thomas Monjalon
30/03/2018 12:15, Ferruh Yigit: > On 3/30/2018 9:32 AM, Thomas Monjalon wrote: > > 29/03/2018 20:43, Ferruh Yigit: > >> On 3/29/2018 7:21 PM, Ferruh Yigit wrote: > >>> On 3/29/2018 6:01 PM, Thomas Monjalon wrote: > 29/03/2018 18:50, Ferruh Yigit: > > On 3/29/2018 5:43 PM, Thomas Monjalon w

Re: [dpdk-dev] [PATCH] ethdev: fix port accessing after release

2018-03-30 Thread Ferruh Yigit
On 3/28/2018 1:25 PM, Thomas Monjalon wrote: > 28/03/2018 14:10, Matan Azrad: >> rte_eth_dev_pci_release() function wrongly releases an ethdev port and >> then releases internal fields of this port. >> This behavior is problematic, because after the release, the port may >> be reallocated again by

Re: [dpdk-dev] [PATCH v2] maintainers: call out subtree committers

2018-03-30 Thread Ferruh Yigit
On 3/28/2018 8:30 PM, Pablo de Lara wrote: > The MAINTAINERS file contains information of the maintainers > of the different components on DPDK. > However, it does not give any information on who maintains the > different subtrees which accept new commits for these components. > > This commit adds

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-03-30 Thread Ferruh Yigit
On 3/28/2018 1:07 PM, Matan Azrad wrote: > Hi Ferruh > >> From: Ferruh Yigit, Wednesday, March 28, 2018 1:38 AM >> On 3/5/2018 3:12 PM, Matan Azrad wrote: >>> Hi Ferruh >>> >>> From: Ferruh Yigit, Sent: Monday, March 5, 2018 5:07 PM On 3/5/2018 2:52 PM, Matan Azrad wrote: > HI > >

Re: [dpdk-dev] [PATCH 1/5] net/qede: convert to new Rx/Tx offloads API

2018-03-30 Thread Ferruh Yigit
On 3/28/2018 1:15 AM, Rasesh Mody wrote: > From: Harish Patil > > Ethdev RX/TX offloads API has changed since: > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") > > This patch makes use of new offload flags as sugg

Re: [dpdk-dev] [PATCH v2] net/bnxt: switch to the new offload API

2018-03-30 Thread Ferruh Yigit
On 3/26/2018 11:47 PM, Ajit Khaparde wrote: > Update bnxt PMD to new ethdev offloads API. > > Signed-off-by: Ajit Khaparde > --- > v1->v2: return an error if requested offload flags do not > match supported offload capabilities. <...> > + > + dev_info->rx_queue_offload_capa = BNXT_DEV_RX_OF

Re: [dpdk-dev] [PATCH v2] net/mrvl: rename PMD driver as mvpp2

2018-03-30 Thread Ferruh Yigit
On 3/27/2018 8:20 PM, Ferruh Yigit wrote: > On 3/26/2018 3:38 PM, Tomasz Duszynski wrote: >> From: Natalie Samsonov >> >> The name "mrvl" for Marvell PMD driver for PPv2 Marvell PPv2 >> (Packet Processor v2) 1/10 Gbps adapter is too generic and causes >> problem for adding new PMD drivers for othe

Re: [dpdk-dev] [PATCH 3/4] doc: update NFP guide

2018-03-30 Thread Ferruh Yigit
On 3/23/2018 5:35 PM, Alejandro Lucero wrote: > New CPP interface changes the way firmware upload is managed by > the PMD. It also supports different firmware file names for > having specific firmware aplications per card. > > Signed-off-by: Alejandro Lucero This conflicts with another nfp doc p

Re: [dpdk-dev] [PATCH 1/4] net/nfp: add NFP CPP support

2018-03-30 Thread Ferruh Yigit
On 3/23/2018 5:35 PM, Alejandro Lucero wrote: > CPP refers to the internal NFP Command Push Pull bus. This patch allows > to create CPP commands from user space allowing to access any single > part of the chip. > > This CPP interface is the base for having other functionalities like > mutexes when

Re: [dpdk-dev] [PATCH v2] net/bnxt: convert to SPDX license tag

2018-03-30 Thread Ferruh Yigit
On 3/29/2018 5:40 PM, Ajit Khaparde wrote: > From: Scott Branden > > Update the license header on bnxt files to be the standard > BSD-3-Clause license used for the rest of DPDK, > bring the files in compliance with the DPDK licensing policy. > > Signed-off-by: Scott Branden > Signed-off-by: Aji

Re: [dpdk-dev] [PATCH 2/4] net/bnxt: add support for Stingray PF devices ids

2018-03-30 Thread Ferruh Yigit
On 3/21/2018 6:06 PM, Ajit Khaparde wrote: > From: Scott Branden > > Add support for Stingray PF devices ids: > BCM58802 = 0xd802 > BCM58804 = 0xd804 > BCM58808 = 0x16f0 > > Signed-off-by: Scott Branden > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_ethdev.c | 6 ++ Can you

Re: [dpdk-dev] [PATCH 3/4] mk: allow kernel artifacts to be located in output directory

2018-03-30 Thread Ferruh Yigit
On 3/21/2018 6:06 PM, Ajit Khaparde wrote: > From: Scott Branden > > Allow kernel artifacts to be located in output directory specific > by RTE_KERNELDIR_OUT. How to use this variable, I tried following but kernel modules are still in same place: - make RTE_KERNELDIR_OUT=/tmp/kmod O=ferruh DE

Re: [dpdk-dev] [PATCH 1/4] introduce Broadcom Stingray

2018-03-30 Thread Ferruh Yigit
On 3/21/2018 6:06 PM, Ajit Khaparde wrote: > From: Scott Branden > > Add Broadcom Stingray machine support based on armv8. > > For product brief see: > https://www.broadcom.com/products/ethernet-connectivity/controllers/bcm58800 > > Signed-off-by: Scott Branden > Signed-off-by: Ajit Khaparde

Re: [dpdk-dev] [PATCH v3] igb_uio: bind error if pcie bridge

2018-03-30 Thread Ferruh Yigit
On 3/29/2018 5:37 PM, Ajit Khaparde wrote: > From: Darren Edamura > > Probe function should exit immediately if pcie bridge detected > > Signed-off-by: Darren Edamura > Signed-off-by: Rahul Gupta > Signed-off-by: Scott Branden > Signed-off-by: Ajit Khaparde Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2 0/4] ethdev: add per-PMD tuning of RxTx parmeters

2018-03-30 Thread Ferruh Yigit
On 3/27/2018 7:43 PM, Ferruh Yigit wrote: > On 3/21/2018 2:27 PM, Remy Horton wrote: >> The optimal values of several transmission & reception related parameters, >> such as burst sizes, descriptor ring sizes, and number of queues, varies >> between different network interface devices. This patchse

Re: [dpdk-dev] [PATCH v4 0/2] convert to new Rx/Tx offloads API

2018-03-30 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Yanglong > Sent: Friday, March 30, 2018 4:22 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Dai, Wei ; Xing, > Beilei ; Wu, Yanglong > Subject: [PATCH v4 0/2] convert to new Rx/Tx offloads API > > This patch support new offloads API in i40e PF and VF. > > Ya

  1   2   >