Re: [dpdk-dev] net/i40e: fix intr callback unregister by adding retry

2018-03-09 Thread wangyunjian
The core-eal-intr-thread-1896 received signal SIGSEGV, Segmentation fault: #1 rte_i40e_dev_atomic_write_link_status (dev=0xa21940 , link=0x7f0d9e2b57d0)at /usr/src/debug/dpdk-16.11/drivers/net/i40e/i40e_ethdev.c:712 #2 i40e_dev_link_update (dev=dev@entry=0xa21940 ,wait_to_complete=wait_to_comp

[dpdk-dev] net/i40e: fix intr callback unregister by adding retry

2018-03-09 Thread wangyunjian
From: Yunjian Wang The nic's interrupt source has some active callbacks, when the port hotplug. Add a retry to give more port's a chance to uninit before returning an error. Fixes: d42aaf30008b ("i40e: support port hotplug") Signed-off-by: Yunjian Wang --- drivers/net/i40e/i40e_ethdev.c | 16

Re: [dpdk-dev] [PATCH v2 0/7] cxgbe: bug fixes and updates

2018-03-09 Thread Rahul Lakkireddy
On Thursday, March 03/08/18, 2018 at 19:20:14 +0530, Ferruh Yigit wrote: > On 3/8/2018 1:44 PM, Ferruh Yigit wrote: > > On 2/28/2018 6:04 PM, Rahul Lakkireddy wrote: > >> Patch 1 reworks rte_eth_dev allocation for other ports under same PF. > >> > >> Patch 2 fixes secondary process initialization f

Re: [dpdk-dev] [PATCH v2 3/7] cxgbe: add support to update RSS hash configuration and key

2018-03-09 Thread Rahul Lakkireddy
On Thursday, March 03/08/18, 2018 at 19:04:31 +0530, Ferruh Yigit wrote: > On 2/28/2018 6:04 PM, Rahul Lakkireddy wrote: > > From: Kumar Sanghvi > > > > Add firmware API for updating RSS hash configuration and key. Move > > RSS hash configuration from cxgb4_write_rss() to a separate function > >

[dpdk-dev] [PATCH v1 6/6] app/testpmd: conserve mbuf indirection flag

2018-03-09 Thread Yongseok Koh
If PMD delivers Rx packets with mbuf indirection, ol_flags should not be overwritten. For mlx5 PMD, if Multi-Packet RQ is enabled, Rx packets could be indirect mbufs. Signed-off-by: Yongseok Koh --- app/test-pmd/csumonly.c | 2 ++ app/test-pmd/macfwd.c | 2 ++ app/test-pmd/macswap.c | 2 ++ 3

[dpdk-dev] [PATCH v1 5/6] net/mlx5: release Tx queue resource earlier than Rx

2018-03-09 Thread Yongseok Koh
Multi-Packet RQ uses mbuf indirection and direct mbufs come from the private Mempool (rxq->mprq_mp) of PMD. To properly release the Mempool, it is better to empty the Tx completeion array (txq->elts) before releasing it. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 16 --

[dpdk-dev] [PATCH v1 4/6] net/mlx5: add Multi-Packet Rx support

2018-03-09 Thread Yongseok Koh
Multi-Packet Rx Queue (MPRQ a.k.a Striding RQ) can further save PCIe bandwidth by posting a single large buffer for multiple packets. Instead of posting a buffer per a packet, one large buffer is posted in order to receive multiple packets on the buffer. A MPRQ buffer consists of multiple fixed-siz

[dpdk-dev] [PATCH v1 3/6] net/mlx5: add a function to rdma-core glue

2018-03-09 Thread Yongseok Koh
mlx5dv_create_wq() is added. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_glue.c | 9 + drivers/net/mlx5/mlx5_glue.h | 4 2 files changed, 13 insertions(+) diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.c index 1c4396ada..e33fc76b5 100644 --- a/driv

[dpdk-dev] [PATCH v1 2/6] net/mlx5: separate filling Rx flags

2018-03-09 Thread Yongseok Koh
Filling in fields of mbuf becomes a separate inline function so that this can be reused. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 84 +++- 1 file changed, 51 insertions(+), 33 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/

[dpdk-dev] [PATCH v1 0/6] net/mlx5: add Multi-Packet Rx support

2018-03-09 Thread Yongseok Koh
Multi-Packet Rx Queue (MPRQ a.k.a Striding RQ) can further save PCIe bandwidth by posting a single large buffer for multiple packets. Instead of posting a buffer per a packet, one large buffer is posted in order to receive multiple packets on the buffer. A MPRQ buffer consists of multiple fixed-siz

[dpdk-dev] [PATCH v1 1/6] mbuf: add buffer offset field for flexible indirection

2018-03-09 Thread Yongseok Koh
When attaching a mbuf, indirect mbuf has to point to start of buffer of direct mbuf. By adding buf_off field to rte_mbuf, this becomes more flexible. Indirect mbuf can point to any part of direct mbuf by calling rte_pktmbuf_attach_at(). Possible use-cases could be: - If a packet has multiple layer

[dpdk-dev] [RFC 4/5] Add Intel FPGA BUS Rawdev Code

2018-03-09 Thread Rosen Xu
Signed-off-by: Rosen Xu Signed-off-by: Yanglong Wu --- drivers/raw/ifpga_rawdev/Makefile | 63 +++ drivers/raw/ifpga_rawdev/ifpga_rawdev.c| 472 + drivers/raw/ifpga_rawdev/ifpga_rawdev.h| 38 ++ drivers/raw/ifpga_rawdev/ifpga_rawde

Re: [dpdk-dev] [PATCH v3 00/10] enic PMD patchset

2018-03-09 Thread Hyong Youb Kim
On Fri, Mar 09, 2018 at 04:00:55PM +, Ferruh Yigit wrote: [...] > Series applied to dpdk-next-net/master, thanks. > > (typo in 2/10 fixed while applying) Thanks a lot for fixing that. Adding "build with assert enabled" to our checklist.. -Hyong

Re: [dpdk-dev] [PATCH v3 03/10] net/enic: heed the requested max Rx packet size

2018-03-09 Thread Hyong Youb Kim
On Fri, Mar 09, 2018 at 03:57:46PM +, Ferruh Yigit wrote: > On 3/9/2018 3:51 PM, Ananyev, Konstantin wrote: [...] > >> Is this work based on an application that uses max_rx_pkt_len and to make > >> PMD > >> compatible with that application? If so we can continue with patch, but if > >> the >

[dpdk-dev] [PATCH] ethdev: Additions to rte_flows to support vTEP encap/decap offload

2018-03-09 Thread Declan Doherty
This V1 patchset contains the revised proposal to manage virtual tunnel endpoints (vTEP) hardware accleration based on community feedback on RFC (http://dpdk.org/ml/archives/dev/2017-December/084676.html). This proposal is purely enabled through rte_flow APIs with the additions of some new features

Re: [dpdk-dev] Question on AESNI PMD

2018-03-09 Thread Thomas Monjalon
Cc Declan and Pablo, the maintainers 09/03/2018 23:08, Luse, Paul E: > Hi, > > I'm working on an SPDK module that uses the DPDK cryptodev framework, > initially I'm using the AESNI PMD and have a few questions. in the doc it > says that only in-place is supported however I see code in > set_mb

[dpdk-dev] [PATCH] vdev: fix name comparison in find_vdev

2018-03-09 Thread Nachiketa Prachanda
Use strcmp to compare device names as the strncmp in original code causes find_vdev to return -EEXIST for names that are prefix of another. The creation of interfaces fails unpredictably based on the order of their creation. An easy way hit this bug is to create eth_vhost1 after eth_vhost11. Sign

[dpdk-dev] [RFC PATCH] ethdev: fix ports enumeration

2018-03-09 Thread Thomas Monjalon
Some DPDK applications wrongly assume these requirements: - no hotplug, i.e. ports are never detached - all allocated ports are available to the application Such application iterates over ports by its own mean. The most common pattern is to request the port count and assume ports with inde

[dpdk-dev] Question on AESNI PMD

2018-03-09 Thread Luse, Paul E
Hi, I'm working on an SPDK module that uses the DPDK cryptodev framework, initially I'm using the AESNI PMD and have a few questions. in the doc it says that only in-place is supported however I see code in set_mb_job_params() just after the comment "Mutable crypto operation parameters" it appe

[dpdk-dev] [PATCH] drivers: rename bbdev directory to baseband

2018-03-09 Thread Thomas Monjalon
The drivers directory contains some sub-directories for each kind of device (or bus, mem): net, crypto, event, raw They are not suffixed with "dev" because it is obvious. For consistency, the sub-directory drivers/bbdev/ is renamed to drivers/baseband/. Signed-off-by: Thomas Monjalon ---

[dpdk-dev] [RFC 2/2] net/tap: implement TAP TSO

2018-03-09 Thread Ophir Munk
This commit implements TCP segmentation offload in TAP. Dpdk rte_gso library is used to segment large TCP payloads (e.g. 64K bytes) into smaller MTU size buffers. By supporting TSO offload capability in software a TAP device can be used as a failsafe sub device and be paired with another PCI device

[dpdk-dev] [RFC 1/2] net/tap: calculate checksum for multi segs packets

2018-03-09 Thread Ophir Munk
In past TAP implementation checksum offload calculations (for IP/UDP/TCP) were skipped in case of a multi segments packet. This commit improves TAP functionality by enabling checksum calculations in multi segments cases. The only restriction now is that the first segment must contain all headers of

[dpdk-dev] [RFC 0/2] TAP TSO Implementation

2018-03-09 Thread Ophir Munk
This RFC suggests TAP TSO (TSP segmentation offload) implementation in SW. It uses dpdk library rte_gso which is also used by testpmd. Dpdk rte_gso library segments large TCP payloads (e.g. 64K bytes) into smaller MTU size buffers. By supporting TSO offload capability in software a TAP device can b

Re: [dpdk-dev] [PATCH v4] ethdev: return named opaque type instead of void pointer

2018-03-09 Thread Neil Horman
On Fri, Mar 09, 2018 at 03:45:49PM +, Ferruh Yigit wrote: > On 3/9/2018 3:16 PM, Neil Horman wrote: > > On Fri, Mar 09, 2018 at 01:00:35PM +, Ferruh Yigit wrote: > >> On 3/9/2018 12:36 PM, Neil Horman wrote: > >>> On Fri, Mar 09, 2018 at 11:25:31AM +, Ferruh Yigit wrote: > "struct

[dpdk-dev] [PATCH 2/2] test/sched: add test for pipe profile add api

2018-03-09 Thread Jasvinder Singh
Update the unit test to check the working of new API. Signed-off-by: Jasvinder Singh --- test/test/test_sched.c | 91 ++ 1 file changed, 69 insertions(+), 22 deletions(-) diff --git a/test/test/test_sched.c b/test/test/test_sched.c index 32e500b..

[dpdk-dev] [PATCH 1/2] librte_sched: add post-init pipe profile api

2018-03-09 Thread Jasvinder Singh
Add new API function to add more pipe configuration profiles post initialization to the set of exisitng profiles specified during the creation of scheduler port. This API removes the current limitation that forces the user to define the full set of pipe profiles as the part of port parameters whil

[dpdk-dev] [PATCH 37/37] ip_pipeline: add flow classification example

2018-03-09 Thread Jasvinder Singh
Add example to build pipeline with hash table to classify the ingress traffic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/examples/flow.cli | 60 ++ 1 file changed, 60 insertions(+) create

Re: [dpdk-dev] [PATCH] app/testpmd: print Rx/Tx offload values

2018-03-09 Thread Ferruh Yigit
On 3/7/2018 9:36 PM, Yongseok Koh wrote: > >> On Mar 6, 2018, at 8:28 AM, Ferruh Yigit wrote: >> >> It is not clear which per port offloads are enabled. Printing offloads >> values at forwarding start. >> >> CRC strip offload value was printed in more verbose manner, it is >> removed since Rx/Tx

[dpdk-dev] [PATCH 35/37] ip_pipeline: add route example

2018-03-09 Thread Jasvinder Singh
Add example to built pipeline with LPM table to demonstrate layer 3 routing. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan --- examples/ip_pipeline/examples/route.cli | 60 + 1 file changed, 60 insertions(+) crea

[dpdk-dev] [PATCH 36/37] ip_pipeline: add firewall example

2018-03-09 Thread Jasvinder Singh
Add example to built pipeline with ACL table to demonstrate the firewall operation. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/examples/firewall.cli | 59 ++ 1 file changed, 59 insertions(+) create mode 100644 examples

[dpdk-dev] [PATCH 32/37] ip_pipeline: add l2fwd example

2018-03-09 Thread Jasvinder Singh
This patch add the configuration file for l2fwd example. It includes commands to build the packet processing stage (pipeline), defining action, add rules to its table, etc. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/exa

[dpdk-dev] [PATCH 34/37] ip_pipeline: add TAP port example

2018-03-09 Thread Jasvinder Singh
Add example to illustrate the pipeline functioning with TAP interface. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/examples/tap.cli | 66 +++ 1 file changed, 66 insertions(+) create mode

[dpdk-dev] [PATCH 33/37] ip_pipeline: add KNI port example

2018-03-09 Thread Jasvinder Singh
Add example to illustrate the pipeline functioning with KNI interface. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/examples/kni.cli | 69 +++ 1 file changed, 69 insertions(+) create mode

[dpdk-dev] [PATCH 31/37] ip_pipeline: add cli to read ttl stats

2018-03-09 Thread Jasvinder Singh
Add command to read the ttl stats. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 22 +++ examples/ip_pipeline/pipeline.h | 7 examples/ip_pipeline/thread.c | 84 + 3 files changed,

[dpdk-dev] [PATCH 30/37] ip_pipeline: add cli to update dscp table

2018-03-09 Thread Jasvinder Singh
Add command to update the dscp table for traffic meter and traffic manager. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 154 examples/ip_pipeline/pipeline.h | 6 ++ examples/ip_pipeline/thread

[dpdk-dev] [PATCH 29/37] ip_pipeline: add cli to read meter stats

2018-03-09 Thread Jasvinder Singh
Add command to read traffic meter stats. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 22 +++ examples/ip_pipeline/pipeline.h | 8 examples/ip_pipeline/thread.c | 88 + 3 files cha

[dpdk-dev] [PATCH 28/37] ip_pipeline: add cli to configure meter profile

2018-03-09 Thread Jasvinder Singh
Add commands to configure the traffic meter profile. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 232 examples/ip_pipeline/pipeline.h | 11 ++ examples/ip_pipeline/thread.c | 144

[dpdk-dev] [PATCH 26/37] ip_pipeline: add cli to delete pipeline table entry

2018-03-09 Thread Jasvinder Singh
Add command to delete the pipeline table entry. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 145 examples/ip_pipeline/pipeline.h | 9 +++ examples/ip_pipeline/thread.c | 140

[dpdk-dev] [PATCH 27/37] ip_pipeline: add cli to read pipeline table entry stats

2018-03-09 Thread Jasvinder Singh
Add command to read the pipeline table entry stats. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/cli.c | 22 +++ examples/ip_pipeline/pipeline.h | 7 examples/ip_pipeline/thread.c | 84 +

[dpdk-dev] [PATCH 25/37] ip_pipeline: add cli for pipeline table entries

2018-03-09 Thread Jasvinder Singh
Add commands to add pipeline table entries which contains match and action part. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 1273 +++ examples/ip_pipeline/pipeline.h | 13 + examples/ip_pipeline/t

[dpdk-dev] [PATCH 22/37] ip_pipeline: add cli to enable and disable pipeline

2018-03-09 Thread Jasvinder Singh
Add commands to enable and disable the pipeline on the thread. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/cli.c| 102 + examples/ip_pipeline/thread.c | 260 +- e

[dpdk-dev] [PATCH 24/37] ip_pipeline: add cli to read pipeline port and table stats

2018-03-09 Thread Jasvinder Singh
Add commands to read the pipeline port in, port out and table stats. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/cli.c | 256 examples/ip_pipeline/pipeline.h | 18 +++ exampl

[dpdk-dev] [PATCH 23/37] ip_pipeline: add cli to enable and disable pipeline port

2018-03-09 Thread Jasvinder Singh
Add commands to enable and disable the pipeline ports. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/cli.c | 112 +++ examples/ip_pipeline/pipeline.h | 8 ++ examples/ip_pipeline/thread.c | 1

[dpdk-dev] [PATCH 20/37] ip_pipeline: add threads

2018-03-09 Thread Jasvinder Singh
Add threads data structure and initialisation functions to run the pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile| 2 +- examples/ip_pipeline/main.c | 8 ++ examples/ip_pipeline/meson.build | 1 + examples/ip_pipeline

[dpdk-dev] [PATCH 21/37] ip_pipeline: add thread runtime

2018-03-09 Thread Jasvinder Singh
Add runtime thread functions for the pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/main.c | 6 ++ examples/ip_pipeline/thread.c | 193 ++ examples/ip_pipeline/thread.h | 5 +- 3 files changed, 2

[dpdk-dev] [PATCH 19/37] ip_pipeline: add pipeline object

2018-03-09 Thread Jasvinder Singh
Add pipeline object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 786 + examples/ip_pipeline/cli.h | 2 - examples/ip_

[dpdk-dev] [PATCH 18/37] ip_pipeline: add action profile object

2018-03-09 Thread Jasvinder Singh
Add action profile object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/Makefile| 3 +- examples/ip_pipeline/cli.c | 309 +++ examples/ip_pip

[dpdk-dev] [PATCH 17/37] ip_pipeline: add kni object

2018-03-09 Thread Jasvinder Singh
Add kni object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 65 +++ examples/ip_pipeline/kni.c | 165 ++

[dpdk-dev] [PATCH 16/37] ip_pipeline: add tap object

2018-03-09 Thread Jasvinder Singh
Add tap object implementation to the application Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 32 + examples/ip_pipeline/main.c | 8 examples/i

[dpdk-dev] [PATCH 14/37] ip_pipeline: add software queue object

2018-03-09 Thread Jasvinder Singh
Add swq object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 55 + examples/ip_pipeline/main.c | 8

[dpdk-dev] [PATCH 15/37] ip_pipeline: add traffic manager object

2018-03-09 Thread Jasvinder Singh
Add traffic manager object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 360 +++ examples/ip_pipeline/main.c | 8 +

[dpdk-dev] [PATCH 13/37] ip_pipeline: add link object

2018-03-09 Thread Jasvinder Singh
Add link object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 122 ++ examples/ip_pipeline/link.c | 268

[dpdk-dev] [PATCH 11/37] ip_pipeline: add cli interface

2018-03-09 Thread Jasvinder Singh
CLI interface allowing connectivity with external agent(e.g. telnet, netcat, Python script, etc) is added to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile| 4 +- examples/ip_pipeline/cli.c | 85 ++ examp

[dpdk-dev] [PATCH 12/37] ip_pipeline: add mempool object for pipeline

2018-03-09 Thread Jasvinder Singh
Add mempool object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 109 ++- examples/ip_pipeline/co

[dpdk-dev] [PATCH 08/37] pipeline: add statistics read action

2018-03-09 Thread Jasvinder Singh
Add implementation of stats read action Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_pipeline_version.map | 1 + lib/librte_pipeline/rte_table_action.c | 112 ++- lib/librte_pipeline/rte_table_action.h | 78 +++ 3 files cha

[dpdk-dev] [PATCH 09/37] pipeline: add timestamp action

2018-03-09 Thread Jasvinder Singh
Add implementation of timestamp action. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_pipeline_version.map | 1 + lib/librte_pipeline/rte_table_action.c | 79 +++- lib/librte_pipeline/rte_table_action.h | 31 +++ 3 files changed, 110

[dpdk-dev] [PATCH 06/37] pipeline: add nat action

2018-03-09 Thread Jasvinder Singh
Add implementation of Network Address Translation(NAT) action. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_table_action.c | 162 + lib/librte_pipeline/rte_table_action.h | 39 2 files changed, 201 insertions(+) diff --git a/lib/librte

[dpdk-dev] [PATCH 02/37] pipeline: get pipeline table action params

2018-03-09 Thread Jasvinder Singh
Add API to specify action related parameters such as action handler, table entry data size, etc. for the pipeline table. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_pipeline_version.map | 1 + lib/librte_pipeline/rte_table_action.c | 132 ++- li

[dpdk-dev] [PATCH 07/37] pipeline: add ttl update action

2018-03-09 Thread Jasvinder Singh
Add implementation of ttl update action. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_pipeline_version.map | 1 + lib/librte_pipeline/rte_table_action.c | 155 +++ lib/librte_pipeline/rte_table_action.h | 66 3 files changed,

[dpdk-dev] [PATCH 03/37] pipeline: add traffic metering action

2018-03-09 Thread Jasvinder Singh
Add traffic metering action implementation. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/Makefile | 3 +- lib/librte_pipeline/meson.build | 2 +- lib/librte_pipeline/rte_pipeline_version.map | 4 + lib/librte_pipeline/rte_table_action.c | 63

[dpdk-dev] [PATCH 05/37] pipeline: add packet encapsulation action

2018-03-09 Thread Jasvinder Singh
Add implementation of different type of packet encap such as vlan, qinq, mpls, pppoe, etc. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_table_action.c | 440 - lib/librte_pipeline/rte_table_action.h | 129 ++ 2 files changed, 568 insertio

[dpdk-dev] [PATCH 04/37] pipeline: add traffic manager action

2018-03-09 Thread Jasvinder Singh
Add implementation of traffic manager action. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/Makefile | 2 +- lib/librte_pipeline/meson.build| 2 +- lib/librte_pipeline/rte_table_action.c | 130 - lib/librte_pipeline/rte_table_act

[dpdk-dev] [PATCH 01/37] pipeline: add pipeline table action APIs

2018-03-09 Thread Jasvinder Singh
This API provides a common set of actions for pipeline tables to speed up application development. Each match-action rule added to a pipeline table has associated data that stores the action context. This data is input to the table action handler called for every input packet that hits the rule as

[dpdk-dev] [PATCH 00/37] ip_pipeline: refactoring

2018-03-09 Thread Jasvinder Singh
Refactored the IP pipeline application. As result, the code base size (lines of code) reduces by ~60%. 1. Moved table actions into the librte_pipeline library. As result, the pre-fabricated pipelines from the application pipeline folder were removed. The flexibility is greatly improved, as n

Re: [dpdk-dev] [PATCH] assign QAT cryptodev to correct NUMA node

2018-03-09 Thread Trahe, Fiona
Hi Lee, Thanks for investigating this. > -Original Message- > From: Lee Roberts [mailto:lee.robe...@hpe.com] > Sent: Friday, March 9, 2018 6:01 PM > To: Griffin, John ; Trahe, Fiona > ; Jain, Deepak K > > Cc: dev@dpdk.org; Lee Roberts > Subject: [PATCH] assign QAT cryptodev to correct N

[dpdk-dev] [PATCH] assign QAT cryptodev to correct NUMA node

2018-03-09 Thread Lee Roberts
rte_cryptodev_pmd_init_params should use NUMA node of the QAT device for its socket_id rather than the socket_id of the initializing process. Signed-off-by: Lee Roberts --- drivers/crypto/qat/rte_qat_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/q

[dpdk-dev] [PATCH] net/dpaa: prefer defines for link speed values

2018-03-09 Thread Ferruh Yigit
Use existing defines instead of hardcoded vales. Signed-off-by: Ferruh Yigit --- drivers/net/dpaa/dpaa_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 9b69ef456..db493648a 100644 --- a/drivers/

[dpdk-dev] [PATCH] net/avf: fix link autoneg value

2018-03-09 Thread Ferruh Yigit
Intention of the logic is: If ETH_LINK_SPEED_FIXED is set in dev_conf, set link_autoneg to ETH_LINK_FIXED, else set it to ETH_LINK_AUTONEG ETH_LINK_SPEED_FIXED value is 1, and ETH_LINK_FIXED is 0; Current logic is broken, fix it according above values. Fixes: 48de41ca11f0 ("net/avf: enable link

Re: [dpdk-dev] [PATCH v4 01/20] crypto/ccp: add AMD ccp skeleton PMD

2018-03-09 Thread Hemant Agrawal
Please ignore my comment, I just checked that you have added a patch to convert the license to SPDX. However, it is not the best way. A new patchset should have this change in the individual patches itself. Regards, Hemant > -Original Message- > From: dev [mailto:dev-boun...@dpdk.or

[dpdk-dev] [PATCH] lib/cryptodev: pass rte driver to REGISTER macro

2018-03-09 Thread Fiona Trahe
Pass an rte_driver to the RTE_PMD_REGISTER_CRYPTO_DRIVER macro rather than an unspecified container which holds an rte_driver. All the macro actually needs is the rte_driver, not the container holding it. This paves the way for a later patch in which a driver will be registered which does not natur

Re: [dpdk-dev] [PATCH 7/7] build: add meson support for dpaaX platforms

2018-03-09 Thread Hemant Agrawal
Hi Thomas, > > ping > > 01/03/2018 15:15, Thomas Monjalon: > > 01/03/2018 07:10, Hemant Agrawal: > > > On 2/28/2018 8:14 PM, Bruce Richardson wrote: > > > > On Tue, Feb 27, 2018 at 10:55:52PM +0530, Hemant Agrawal wrote: > > > >> +includes += > > > >> +include_directories('../../../lib/librte_ea

Re: [dpdk-dev] [PATCH v4 01/20] crypto/ccp: add AMD ccp skeleton PMD

2018-03-09 Thread Hemant Agrawal
Hi Ravi, Since 18.02, DPDK community will prefer all new submission to use SPDX licensing tags. Regards, Hemant On 3/9/2018 2:05 PM, Ravi Kumar wrote: Signed-off-by: Ravi Kumar --- .. diff --git a/drivers/crypto/ccp/Makefile b/drivers/crypto/ccp/Makefile new file mode 100644 index 000.

Re: [dpdk-dev] [PATCH] net/mrvl: convert license headers to SPDX tags

2018-03-09 Thread Hemant Agrawal
Hi, On 3/9/2018 3:35 PM, Ferruh Yigit wrote: On 3/9/2018 9:39 AM, Tomasz Duszynski wrote: Signed-off-by: Tomasz Duszynski --- drivers/net/mrvl/Makefile | 35 --- drivers/net/mrvl/mrvl_ethdev.c | 36 drivers/net/mrvl/m

Re: [dpdk-dev] [PATCH v2 08/10] config: add dpaaX build support in common linuxapp

2018-03-09 Thread Hemant Agrawal
Hi Thomas, > > As you know the config options should be declared in common_base and > overwritten in common_linuxapp. > > That's why there is no need to add comments in common_linuxapp. > And some of the options should be only in common_base, like > CONFIG_RTE_LIBRTE_DPAA_HWDEBUG=n > > P

Re: [dpdk-dev] [PATCH v2 08/10] config: add dpaaX build support in common linuxapp

2018-03-09 Thread Thomas Monjalon
Hi, As you know the config options should be declared in common_base and overwritten in common_linuxapp. That's why there is no need to add comments in common_linuxapp. And some of the options should be only in common_base, like CONFIG_RTE_LIBRTE_DPAA_HWDEBUG=n Please try to move all the

[dpdk-dev] [PATCH] compress/isal: ISA-L compression PMD

2018-03-09 Thread Lee Daly
Compression PMD using the Intel ISA-L library. Features of this PMD: - Stateless compression and decompression. - Fixed/Semi-Dynamic compression, - Supports 32K sliding window size, - ISA-L levels 0 to 3, - Adler32 & CRC32 checksums. Signed-off-by: Lee Daly --- This patch has de

Re: [dpdk-dev] [PATCH 7/7] build: add meson support for dpaaX platforms

2018-03-09 Thread Thomas Monjalon
ping 01/03/2018 15:15, Thomas Monjalon: > 01/03/2018 07:10, Hemant Agrawal: > > On 2/28/2018 8:14 PM, Bruce Richardson wrote: > > > On Tue, Feb 27, 2018 at 10:55:52PM +0530, Hemant Agrawal wrote: > > >> +includes += include_directories('../../../lib/librte_eal/linuxapp/eal') > > > > > > Is this n

[dpdk-dev] [dpdk-announce] CALL for action - Migration to the new ethdev offload API

2018-03-09 Thread Thomas Monjalon
Hi, In DPDK 17.11, the ethdev offloads API has changed. A dozen drivers are not yet converted to this new API. We are in a transition period which is planned to close with this 18.05 release. As a PMD maintainer or contributor, you can improve your karma by converting your PMD in the next few wee

[dpdk-dev] [PATCH v1 4/5] testpmd: new commands to load/unload BPF filters

2018-03-09 Thread Konstantin Ananyev
Introduce new testpmd commands to load/unload RX/TX BPF-based filters. Signed-off-by: Konstantin Ananyev --- app/test-pmd/bpf_sup.h | 25 + app/test-pmd/cmdline.c | 146 + 2 files changed, 171 insertions(+) create mode 100644 app/test-pmd

[dpdk-dev] [PATCH v1 5/5] test: add few eBPF samples

2018-03-09 Thread Konstantin Ananyev
Add few simple eBPF programs as an example. Signed-off-by: Konstantin Ananyev --- test/bpf/dummy.c | 20 ++ test/bpf/mbuf.h | 556 +++ test/bpf/t1.c| 53 ++ test/bpf/t2.c| 30 +++ test/bpf/t3.c| 36 5 files changed, 69

[dpdk-dev] [PATCH v1 3/5] bpf: introduce basic RX/TX BPF filters

2018-03-09 Thread Konstantin Ananyev
Introduce API to install BPF based filters on ethdev RX/TX path. Current implementation is pure SW one, based on ethdev RX/TX callback mechanism. Signed-off-by: Konstantin Ananyev --- lib/librte_bpf/Makefile| 2 + lib/librte_bpf/bpf_pkt.c | 524 +++

[dpdk-dev] [PATCH v1 2/5] bpf: add JIT compilation for x86_64 ISA.

2018-03-09 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- lib/librte_bpf/Makefile |3 + lib/librte_bpf/bpf.c |4 + lib/librte_bpf/bpf_jit_x86.c | 1329 ++ 3 files changed, 1336 insertions(+) create mode 100644 lib/librte_bpf/bpf_jit_x86.c diff --git a/li

[dpdk-dev] [PATCH v1 1/5] bpf: add BPF loading and execution framework

2018-03-09 Thread Konstantin Ananyev
librte_bpf provides a framework to load and execute eBPF bytecode inside user-space dpdk based applications. It supports basic set of features from eBPF spec (https://www.kernel.org/doc/Documentation/networking/filter.txt). Not currently supported features: - JIT - cBPF - tail-pointer call - e

[dpdk-dev] [PATCH v1 0/5] add framework to load and execute BPF code

2018-03-09 Thread Konstantin Ananyev
BPF is used quite intensively inside Linux (and BSD) kernels for various different purposes and proved to be extremely useful. BPF inside DPDK might also be used in a lot of places for a lot of similar things. As an example to: - packet filtering/tracing (aka tcpdump) - packet classification - st

Re: [dpdk-dev] [PATCH v3 01/18] net/axgbe: add minimal dev init and uninit support

2018-03-09 Thread Ferruh Yigit
On 3/9/2018 4:13 PM, Ferruh Yigit wrote: > On 3/9/2018 8:42 AM, Ravi Kumar wrote: >> Signed-off-by: Ravi Kumar > > <...> > >> diff --git a/drivers/net/axgbe/Makefile b/drivers/net/axgbe/Makefile >> new file mode 100644 >> index 000..c8a1e87 >> --- /dev/null >> +++ b/drivers/net/axgbe/Makefil

Re: [dpdk-dev] [PATCH 18.05 v4] eal: add function to return number of detected sockets

2018-03-09 Thread Bruce Richardson
On Thu, Mar 08, 2018 at 02:38:37PM +, Burakov, Anatoly wrote: > On 08-Mar-18 12:12 PM, Bruce Richardson wrote: > > On Wed, Feb 07, 2018 at 09:58:36AM +, Anatoly Burakov wrote: > > > During lcore scan, find maximum socket ID and store it. This will > > > break the ABI, so bump ABI version. >

Re: [dpdk-dev] [PATCH v3 01/18] net/axgbe: add minimal dev init and uninit support

2018-03-09 Thread Ferruh Yigit
On 3/9/2018 8:42 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar <...> > diff --git a/drivers/net/axgbe/Makefile b/drivers/net/axgbe/Makefile > new file mode 100644 > index 000..c8a1e87 > --- /dev/null > +++ b/drivers/net/axgbe/Makefile > @@ -0,0 +1,146 @@ > +# > +# Copyright (c) 2017 Ad

Re: [dpdk-dev] [PATCH v3 00/10] enic PMD patchset

2018-03-09 Thread Ferruh Yigit
On 3/8/2018 2:46 AM, John Daley wrote: > V2: rebase, submit as patchset instead of individual patches so they > apply correctly. > V3: try again submitting patches one at a time so they are applied > in order (tester seems to be applying patches in order received > instead of looking at patch ID).

Re: [dpdk-dev] [PATCH v3 03/10] net/enic: heed the requested max Rx packet size

2018-03-09 Thread Ferruh Yigit
On 3/9/2018 3:51 PM, Ananyev, Konstantin wrote: > > Hi everyone, > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Friday, March 9, 2018 3:04 PM >> To: John Daley >> Cc: dev@dpdk.org; Hyong Youb Kim >> Subject: Re: [dpdk-dev] [PATCH v3

Re: [dpdk-dev] [PATCH v3 03/10] net/enic: heed the requested max Rx packet size

2018-03-09 Thread Ananyev, Konstantin
Hi everyone, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Friday, March 9, 2018 3:04 PM > To: John Daley > Cc: dev@dpdk.org; Hyong Youb Kim > Subject: Re: [dpdk-dev] [PATCH v3 03/10] net/enic: heed the requested max Rx > packet size >

Re: [dpdk-dev] [PATCH v4] ethdev: return named opaque type instead of void pointer

2018-03-09 Thread Ferruh Yigit
On 3/9/2018 3:16 PM, Neil Horman wrote: > On Fri, Mar 09, 2018 at 01:00:35PM +, Ferruh Yigit wrote: >> On 3/9/2018 12:36 PM, Neil Horman wrote: >>> On Fri, Mar 09, 2018 at 11:25:31AM +, Ferruh Yigit wrote: "struct rte_eth_rxtx_callback" is defined as internal data structure and us

[dpdk-dev] [RFC 4/5] Add Intel FPGA BUS Rawdev Code

2018-03-09 Thread Rosen Xu
Signed-off-by: Rosen Xu --- drivers/raw/ifpga_rawdev/Makefile | 63 +++ drivers/raw/ifpga_rawdev/ifpga_rawdev.c| 472 + drivers/raw/ifpga_rawdev/ifpga_rawdev.h| 38 ++ drivers/raw/ifpga_rawdev/ifpga_rawdev_example.c| 99 + ..

[dpdk-dev] [RFC 3/5] Add Intel FPGA BUS Lib Code

2018-03-09 Thread Rosen Xu
Signed-off-by: Rosen Xu --- drivers/bus/ifpga/Makefile | 64 drivers/bus/ifpga/ifpga_bus.c | 573 drivers/bus/ifpga/ifpga_common.c| 154 drivers/bus/ifpga/ifpga_common.h| 25 ++ drivers/bus/ifpga/i

[dpdk-dev] [RFC 2/5] Add Intel FPGA BUS Probe Code

2018-03-09 Thread Rosen Xu
Signed-off-by: Rosen Xu --- lib/librte_eal/common/eal_common_bus.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c index 3e022d5..e3bcebe 100644 --- a/lib/librte_eal/common/eal_comm

[dpdk-dev] [RFC 1/5] Add Intel FPGA BUS Command Parse Code

2018-03-09 Thread Rosen Xu
Signed-off-by: Rosen Xu --- lib/librte_eal/common/eal_common_options.c | 8 +++- lib/librte_eal/common/eal_options.h| 2 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 9f2f

[dpdk-dev] [RFC 0/5] Intel FPGA BUS

2018-03-09 Thread Rosen Xu
With Partial Reconfigure(PR) parts of Bitstream, Field Programmable Gate Array(FPGA) not only provides one kinds of accelerator but also provides many types of accelerators at the same time. How DPDK fully support FPGA? - We use Rawdev to provide FPGA PR - DPDK Driver will not bind to PCI Devi

Re: [dpdk-dev] [RFC 1/4] drivers/bus/ifpga:Intel FPGA Bus Lib Code

2018-03-09 Thread Xu, Rosen
Thanks a lot Rivet, I have modified it, pls see my newest patch. -Original Message- From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] Sent: Tuesday, March 06, 2018 18:06 To: Xu, Rosen Cc: dev@dpdk.org; Doherty, Declan ; Zhang, Tianfei Subject: Re: [dpdk-dev] [RFC 1/4] drivers/bus/ifpg

Re: [dpdk-dev] [PATCH v4] ethdev: return named opaque type instead of void pointer

2018-03-09 Thread Neil Horman
On Fri, Mar 09, 2018 at 01:00:35PM +, Ferruh Yigit wrote: > On 3/9/2018 12:36 PM, Neil Horman wrote: > > On Fri, Mar 09, 2018 at 11:25:31AM +, Ferruh Yigit wrote: > >> "struct rte_eth_rxtx_callback" is defined as internal data structure and > >> used as named opaque type. > >> > >> So the f

Re: [dpdk-dev] [PATCH v3 03/10] net/enic: heed the requested max Rx packet size

2018-03-09 Thread Ferruh Yigit
On 3/8/2018 2:46 AM, John Daley wrote: > From: Hyong Youb Kim > > Currently, enic completely ignores the requested max Rx packet size > (rxmode.max_rx_pkt_len). The desired behavior is that the NIC hardware > drops packets larger than the requested size, even though they are > still smaller than

Re: [dpdk-dev] [PATCH v3 02/10] net/enic: allow the user to change RSS settings

2018-03-09 Thread Ferruh Yigit
On 3/8/2018 2:46 AM, John Daley wrote: > From: Hyong Youb Kim > > Currently, when more than 1 receive queues are configured, the driver > always enables RSS with the driver's own default hash type, key, and > RETA. The user is unable to change any of the RSS settings. Address > this by implementi

  1   2   >