Hi Thomas, > > ping > > 01/03/2018 15:15, Thomas Monjalon: > > 01/03/2018 07:10, Hemant Agrawal: > > > On 2/28/2018 8:14 PM, Bruce Richardson wrote: > > > > On Tue, Feb 27, 2018 at 10:55:52PM +0530, Hemant Agrawal wrote: > > > >> +includes += > > > >> +include_directories('../../../lib/librte_eal/linuxapp/eal') > > > > > > > > Is this not covered by the dependency on eal? Is it accessing > > > > things directly in the EAL internals? > > > > > > We are accessing eal_vfio.h. so it is needed. > > > > Let's try to fix it. > > What is required exactly? Can it be in the exported header? > > Currently we are accessing few of the internal vfio functions such as vfio_get_container_fd or vfio_get_group_fd Yes, they can be moved to rte_vfio.h
Regards, Hemant