On 3/7/2018 9:36 PM, Yongseok Koh wrote:
>
>> On Mar 6, 2018, at 8:28 AM, Ferruh Yigit <ferruh.yi...@intel.com> wrote:
>>
>> It is not clear which per port offloads are enabled. Printing offloads
>> values at forwarding start.
>>
>> CRC strip offload value was printed in more verbose manner, it is
>> removed since Rx/Tx offload values covers it and printing only CRC one
>> can cause confusion.
>>
>> Hexadecimal offloads values are not very user friendly but preferred to
>> not create to much noise during forwarding start.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com>
>> ---
>> Cc: Shahaf Shuler <shah...@mellanox.com>
>> ---
>> app/test-pmd/config.c | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
>> index 4bb255c62..47845d0cb 100644
>> --- a/app/test-pmd/config.c
>> +++ b/app/test-pmd/config.c
>> @@ -1682,10 +1682,9 @@ rxtx_config_display(void)
>> struct rte_eth_txconf *tx_conf = &ports[pid].tx_conf;
>>
>> printf(" port %d:\n", (unsigned int)pid);
>> - printf(" CRC stripping %s\n",
>> - (ports[pid].dev_conf.rxmode.offloads &
>> - DEV_RX_OFFLOAD_CRC_STRIP) ?
>> - "enabled" : "disabled");
>> + printf(" Rx offloads=0x%"PRIx64" Tx Offloads=0x%"PRIx64"\n",
>> + ports[pid].dev_conf.rxmode.offloads,
>> + ports[pid].dev_conf.txmode.offloads);
>
> So, if someone wants to know what these values mean, they should type
> 'show port cap all'.
Indeed I forget about 'show port cap all', it is better way to display offloads,
still I believe it is good a have a brief info in the start, especially it
already has "tx_conf->offloads"
btw, 'show port cap all' is missing some offload values, it needs to be updated.
>
> BTW, tx_conf->offloads is printed a few lines later, then isn't it necessary
> to
> print rx_conf->offloads as well? Or, is it supposed to be identical to
> dev_conf.rxmode.offloads?
They may be different, good idea to add rx_conf->offloads as well. I will add it
in v2.
Thanks,
ferruh
>
> Thanks,
> Yongseok
>
