Re: [dpdk-dev] [PATCH v2 2/3] vhost: protect dirty logging against logging base change

2018-02-13 Thread Maxime Coquelin
Hi Jianfeng, On 02/14/2018 03:03 AM, Tan, Jianfeng wrote: Hi Maxime, On 11/28/2017 6:06 PM, Maxime Coquelin wrote: On 11/24/2017 07:08 PM, Maxime Coquelin wrote: When performing live-migration with multiple queue pairs, VHOST_USER_SET_LOG_BASE request is sent multiple times. If packets ar

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-13 Thread Verma, Shally
Hi Ahmed, >-Original Message- >From: Ahmed Mansour [mailto:ahmed.mans...@nxp.com] >Sent: 02 February 2018 01:53 >To: Trahe, Fiona ; Verma, Shally >; dev@dpdk.org >Cc: Athreya, Narayana Prasad ; Gupta, >Ashish ; Sahu, Sunila >; De Lara Guarch, Pablo >; Challa, Mahipal >; Jain, Deepak K ;

Re: [dpdk-dev] [PATCH 3/4] app/testpmd: add option to avoid lock all memory

2018-02-13 Thread Wu, Jingjing
New options is added, the doc also need to update. > -Original Message- > From: Tan, Jianfeng > Sent: Wednesday, February 14, 2018 12:02 PM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; Lu, Wenzhuo > ; Wu, > Jingjing > Subject: [PATCH 3/4] app/testpmd: add option to avoid lock all memory >

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-13 Thread Verma, Shally
Hi Ahmed >-Original Message- >From: Ahmed Mansour [mailto:ahmed.mans...@nxp.com] >Sent: 02 February 2018 02:20 >To: Trahe, Fiona ; Verma, Shally >; dev@dpdk.org >Cc: Athreya, Narayana Prasad ; Gupta, >Ashish ; Sahu, Sunila >; De Lara Guarch, Pablo >; Challa, Mahipal >; Jain, Deepak K ;

[dpdk-dev] [PATCH 3/4] app/testpmd: add option to avoid lock all memory

2018-02-13 Thread Jianfeng Tan
In some cases, we don't want to lock all memory. Add an option --no-mlockall to avoid lock all memory. Cc: wenzhuo...@intel.com Cc: jingjing...@intel.com Signed-off-by: Jianfeng Tan --- app/test-pmd/parameters.c | 5 - app/test-pmd/testpmd.c| 32 ++-- app/t

[dpdk-dev] [PATCH 4/4] vhost: avoid populate guest memory

2018-02-13 Thread Jianfeng Tan
It's not necessary to polulate guest memory from vhost side. Cc: maxime.coque...@redhat.com Cc: y...@fridaylinux.org Signed-off-by: Jianfeng Tan --- lib/librte_vhost/vhost_user.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vh

[dpdk-dev] [PATCH 2/4] vhost: avoid function call in data path

2018-02-13 Thread Jianfeng Tan
Previously, get_device() is a function call. It's OK for slow path configuration, but takes some cycles for data path. To avoid that, we turn this function to inline type. Cc: maxime.coque...@redhat.com Cc: y...@fridaylinux.org Signed-off-by: Jianfeng Tan --- lib/librte_vhost/vhost.c | 13

[dpdk-dev] [PATCH 1/4] vhost: remove unused macro

2018-02-13 Thread Jianfeng Tan
Cc: tomaszx.kula...@intel.com Cc: maxime.coque...@redhat.com Cc: y...@fridaylinux.org Signed-off-by: Jianfeng Tan --- lib/librte_vhost/vhost.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index d947bc9..ecd5b7b 100644 --- a/lib/librte_v

[dpdk-dev] [PATCH 0/4] some fixes target for 18.05

2018-02-13 Thread Jianfeng Tan
Some trivial fixes, and a vhost memory optimization to avoid polulating guest memory. Jianfeng Tan (4): vhost: remove unused macro vhost: avoid function call in data path app/testpmd: add option to avoid lock all memory vhost: avoid populate guest memory app/test-pmd/parameters.c |

Re: [dpdk-dev] Accessing 2nd cacheline in rte_pktmbuf_prefree_seg()

2018-02-13 Thread Yongseok Koh
> On Feb 13, 2018, at 2:45 PM, Yongseok Koh wrote: > > Hi Olivier > > I'm wondering why rte_pktmbuf_prefree_seg() checks m->next instead of > m->nb_segs? As 'next' is in the 2nd cacheline, checking nb_segs seems > beneficial > to the cases where almost mbufs have single segment. > > A customer

Re: [dpdk-dev] [PATCH v2 2/3] vhost: protect dirty logging against logging base change

2018-02-13 Thread Tan, Jianfeng
Hi Maxime, On 11/28/2017 6:06 PM, Maxime Coquelin wrote: On 11/24/2017 07:08 PM, Maxime Coquelin wrote: When performing live-migration with multiple queue pairs, VHOST_USER_SET_LOG_BASE request is sent multiple times. If packets are being processed by the PMD threads, it is possible that th

Re: [dpdk-dev] [RFC v2 00/23] Dynamic memory allocation for DPDK

2018-02-13 Thread Yongseok Koh
> On Feb 5, 2018, at 2:03 AM, Burakov, Anatoly > wrote: > > Thanks for your feedback, good to hear we're on the right track. I already > have a prototype implementation of this working, due for v1 submission :) Anatoly, One more suggestion. Currently, when populating mempool, there's a chanc

Re: [dpdk-dev] Multi-driver support for Fortville

2018-02-13 Thread Xing, Beilei
Hi Nitin, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nitin Katiyar > Sent: Tuesday, February 13, 2018 11:48 AM > To: dev@dpdk.org > Cc: Venkatesan Pradeep > Subject: [dpdk-dev] Multi-driver support for Fortville > > Hi, > Resending the queries with change

Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind.py: add support for wind river avp device

2018-02-13 Thread Zhang, Xiaohua
Hi Yigit and Anantoly, I checked the nics-17.11.pdf, the following is description: "The Accelerated Virtual Port (AVP) device is a shared memory based device only available on virtualization platforms from Wind River Systems. The Wind River Systems virtualization platform currently uses QEMU/KVM

Re: [dpdk-dev] [PATCH] examples/performance-thread: updates hasan alayli's license

2018-02-13 Thread Hasan Alayli
ack On Tue, Feb 13, 2018 at 7:12 AM, Lee Daly wrote: > This updates hasan alayli's license to be the standard BSD-3-Clause > license used for the rest of DPDK,bringing the files in compliance > with the DPDK licensing policy. > > Signed-off-by: Lee Daly > --- > .../performance-thread/common/ar

Re: [dpdk-dev] [PATCH v3] doc: ethdev ABI change deprecation notice

2018-02-13 Thread Thomas Monjalon
> > >> Signed-off-by: Kirill Rybalchenko > > >> > > >> Acked-by: Marko Kovacevic > > >> --- > > >> +* ethdev: announce ABI change > > >> + The size of variables flow_types_mask in rte_eth_fdir_info structure, > > >> + sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf > > >> s

Re: [dpdk-dev] [PATCH 1/1] doc: announce API change to lcore role function

2018-02-13 Thread Thomas Monjalon
12/01/2018 21:45, Erik Gabriel Carrillo: > This an API/ABI change notice for DPDK 18.05 announcing a change in > the meaning of the return values of the rte_lcore_has_role() function. > > Signed-off-by: Erik Gabriel Carrillo > --- > +* eal: The semantics of the return value for the ``rte_lcore_ha

Re: [dpdk-dev] [PATCH] doc: add ABI change notice for numa_node_count in eal

2018-02-13 Thread Thomas Monjalon
> > > > There will be a new function added in v18.05 that will return number of > > > > detected sockets, which will change the ABI. > > > > > > > > Signed-off-by: Anatoly Burakov > > > > --- > > > > +* eal: new ``numa_node_count`` member will be added to ``rte_config`` > > > > +structure in v18.

Re: [dpdk-dev] [PATCH] doc: announce control mbuf removal

2018-02-13 Thread Thomas Monjalon
29/01/2018 10:30, Olivier Matz: > Link: http://dpdk.org/ml/archives/dev/2017-July/069813.html > Link: http://dpdk.org/dev/patchwork/patch/32041/ > > Signed-off-by: Olivier Matz > --- > +* mbuf: The control mbuf API will be removed in v18.05. The impacted > + functions and macros are: > + > + -

Re: [dpdk-dev] [PATCH] doc: announce PMD API change for set default MAC

2018-02-13 Thread Thomas Monjalon
> > >> +* ethdev: The prototype and the behavior of > > >> + ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return > > >> +code > > >> + will be added to notify the caller if an error occurred in the > > >> +PMD. In > > >> + ``rte_eth_dev_default_mac_addr_set()``, the new default MAC >

Re: [dpdk-dev] [PATCH] doc: add kernel version deprecation notice

2018-02-13 Thread Thomas Monjalon
31/01/2018 16:27, Stephen Hemminger: > Notify users of upcoming change in kernel requirement. > Encourage users to use current LTS kernel version. > > Signed-off-by: Stephen Hemminger > --- > +* linux: Linux kernel version 3.2 (which is the current minimum required > + version for the DPDK) will

Re: [dpdk-dev] [PATCH v3] doc: add preferred burst size support

2018-02-13 Thread Thomas Monjalon
05/02/2018 07:17, Yang, Zhiyong: > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shreyansh Jain > > Sent: Monday, February 5, 2018 2:22 PM > > To: dev@dpdk.org > > Cc: Yigit, Ferruh ; tho...@monjalon.net; > > Richardson, Bruce ; Ananyev, Konstantin > > ; h

Re: [dpdk-dev] [PATCH v1] doc: update deprecation notice of rte_devargs

2018-02-13 Thread Thomas Monjalon
13/02/2018 12:26, Ferruh Yigit: > On 2/7/2018 12:41 PM, Shreyansh Jain wrote: > > On Wednesday 07 February 2018 02:56 PM, Gaetan Rivet wrote: > >> The declaration and identification of devices will change in v18.05. > >> > >> Remove the precedent deprecation notice > >> > >> Add new one reflecting

Re: [dpdk-dev] [PATCH] maintainers: add myself for stable branches

2018-02-13 Thread Thomas Monjalon
14/02/2018 00:34, Luca Boccassi: > On Tue, 2018-02-13 at 23:31 +, Luca Boccassi wrote: > > I am maintaining 16.11 until November 2018 > > > > Signed-off-by: Luca Boccassi > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > ind

Re: [dpdk-dev] [PATCH v3 3/3] doc: update build-sdk-quick txt file

2018-02-13 Thread Thomas Monjalon
13/02/2018 13:18, Ferruh Yigit: > On 6/12/2017 1:50 PM, Mcnamara, John wrote: > >> -Original Message- > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > >> Sent: Wednesday, June 7, 2017 3:38 PM > >> To: dev@dpdk.org > >> Cc: tho...@monjalon.net; shreyansh.j...@nxp.com; H

Re: [dpdk-dev] [PATCH] maintainers: add myself for stable branches

2018-02-13 Thread Luca Boccassi
On Tue, 2018-02-13 at 23:31 +, Luca Boccassi wrote: > I am maintaining 16.11 until November 2018 > > Signed-off-by: Luca Boccassi > --- >  MAINTAINERS | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 4f1f33bd3..a646ca3e1 100644 > --- a/MAINTAINERS >

Re: [dpdk-dev] [PATCH] doc: add virtio GUEST ANNOUNCE to release notes

2018-02-13 Thread Thomas Monjalon
09/02/2018 10:56, Mcnamara, John: > From: Wang, Xiao W > > +* **Added VIRTIO_NET_F_GUEST_ANNOUNCE feature support in virtio pmd.** > > + > > + In scenario where the vhost backend doesn't have the ability to > > + generate RARP packet, the VM running virtio pmd can still be live > > + migrated if

[dpdk-dev] [PATCH] maintainers: add myself for stable branches

2018-02-13 Thread Luca Boccassi
I am maintaining 16.11 until November 2018 Signed-off-by: Luca Boccassi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4f1f33bd3..a646ca3e1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -29,6 +29,7 @@ T: git://dpdk.org/dpdk Stable Branches

Re: [dpdk-dev] [PATCH] doc: improve HTML spacing in release notes

2018-02-13 Thread Thomas Monjalon
13/02/2018 10:33, Thomas Monjalon: > 13/02/2018 10:09, Mcnamara, John: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Vertical spacing is lower before an item title than after. > > > So the items with paragraphs are not well separated. > > > > > > A custom CSS is added to override th

Re: [dpdk-dev] [PATCH v2] doc: add maintainers section to the contributors guide

2018-02-13 Thread Thomas Monjalon
> > Add a maintainers section to the contributors guide to have a low tech > > location to check/link to the current maintainers. This file is included > > dynamically from the MAINTAINERS file in the root directory of the DPDK > > source when the docs are built. This also allows us to link to the

Re: [dpdk-dev] [PATCH v2] doc: add vhost-user live migration features to release notes

2018-02-13 Thread Thomas Monjalon
> > Signed-off-by: Jiayu Hu > > The text has been added between the previous section and a note belonging > to the previous section. > > However, we can fix this in the final revision of the release notes, so: > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] doc: add VxLAN GRO to release notes

2018-02-13 Thread Thomas Monjalon
09/02/2018 11:02, Thomas Monjalon: > 09/02/2018 10:56, Mcnamara, John: > > The text has been added between the previous section and a note belonging > > to the previous section. > > > > However, we can fix this in the final revision of the release notes, so: > > I can fix it. > I also take care o

Re: [dpdk-dev] [PATCH v3] doc: update the usage for shared library

2018-02-13 Thread Thomas Monjalon
> > Add note information to intimate about use of option '-d' for shared > > library in DPDK application. > > > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] net/bonding: fix link properties with autoneg

2018-02-13 Thread Thomas Monjalon
13/02/2018 23:54, Chas Williams: > From: Chas Williams > > If a link is carrier down and using autonegotiation, then the PMD may not > have detected a speed yet. In this case the best we can do is ignore the > link speed and duplex since they aren't valid. To be completely correct, > there shou

[dpdk-dev] [PATCH] net/failsafe: fix Rx interrupt reinstallation

2018-02-13 Thread Matan Azrad
Fail-safe dev_start() operation can be called by both the application and the hot-plug alarm mechanism. The installation of Rx interrupt are triggered from dev_start() in any time it is called while actually the Rx interrupt should be installed only by the application calls. So, each plug-in even

Re: [dpdk-dev] [PATCH v5] checkpatches.sh: Add checks for ABI symbol addition

2018-02-13 Thread Thomas Monjalon
Hi, I wanted to push this patch in 18.02, but when looking more closely, I see few things to improve. As it is a tool, there is no harm to wait one more week and push it early in 18.05. 09/02/2018 16:21, Neil Horman: > check () { # > + local reta > total=$(($total + 1)) > ! $v

[dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status on start

2018-02-13 Thread Chas Williams
From: "Charles (Chas) Williams" dev->data->eth_link isn't updated until the first interrupt. If a link is carrier down, then this interrupt may never happen. Before we finished starting the PMD, call ixgbe_dev_link_update() to ensure we have a valid status. Signed-off-by: Chas Williams --- d

[dpdk-dev] [PATCH] net/bonding: fix link properties with autoneg

2018-02-13 Thread Chas Williams
From: Chas Williams If a link is carrier down and using autonegotiation, then the PMD may not have detected a speed yet. In this case the best we can do is ignore the link speed and duplex since they aren't valid. To be completely correct, there should be additional checks to prevent a slave th

[dpdk-dev] Accessing 2nd cacheline in rte_pktmbuf_prefree_seg()

2018-02-13 Thread Yongseok Koh
Hi Olivier I'm wondering why rte_pktmbuf_prefree_seg() checks m->next instead of m->nb_segs? As 'next' is in the 2nd cacheline, checking nb_segs seems beneficial to the cases where almost mbufs have single segment. A customer reported high rate of cache misses in the code and I thought the follow

Re: [dpdk-dev] [PATCH v4] examples/ip_pipeline: update copyright and license

2018-02-13 Thread Thomas Monjalon
12/02/2018 11:15, Olivier Matz: > On Wed, Feb 07, 2018 at 04:43:59PM +, Lee Daly wrote: > > This updates the Intel and Oliver Matz licenses on a file in examples > > to be the standard BSD-3-Clause license used for the rest of DPDK, > > bringing the files in compliance with the DPDK licensing p

Re: [dpdk-dev] [PATCH] examples/cmdline: update copyright and license

2018-02-13 Thread Thomas Monjalon
12/02/2018 11:16, Olivier Matz: > On Wed, Feb 07, 2018 at 04:15:01PM +, Ferruh Yigit wrote: > > On 1/23/2018 4:43 PM, Lee Daly wrote: > > > This updates the license on files in examples to be the standard > > > BSD-3-Clause license used for the rest of DPDK, > > > bringing the files in complian

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build

2018-02-13 Thread Thomas Monjalon
> > > The type pthread_t is not portable because it is freely defined. > > > On Linux, it is an unsigned long int which can be printed with %l. > > > On FreeBSD, it is a pointer which can be printed with %p. > > > > > > That's why there was this error: > > > drivers/net/failsafe/failsafe_private.h:

Re: [dpdk-dev] [PATCH] examples/performance-thread: updates hasan alayli's license

2018-02-13 Thread Thomas Monjalon
13/02/2018 17:03, Ferruh Yigit: > On 2/13/2018 3:45 PM, Hemant Agrawal wrote: > > From: Lee Daly [mailto:lee.d...@intel.com] > >> > >> This updates hasan alayli's license to be the standard BSD-3-Clause > >> license used > >> for the rest of DPDK,bringing the files in compliance with the DPDK > >

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build

2018-02-13 Thread Matan Azrad
> -Original Message- > From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] > Sent: Wednesday, February 14, 2018 12:19 AM > To: Thomas Monjalon ; Matan Azrad > > Cc: dev@dpdk.org; gaetan.ri...@6wind.com > Subject: RE: [dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build >

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build

2018-02-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, February 13, 2018 10:13 PM > To: ma...@mellanox.com > Cc: dev@dpdk.org; gaetan.ri...@6wind.com > Subject: [dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build > > The type pthrea

[dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build

2018-02-13 Thread Thomas Monjalon
The type pthread_t is not portable because it is freely defined. On Linux, it is an unsigned long int which can be printed with %l. On FreeBSD, it is a pointer which can be printed with %p. That's why there was this error: drivers/net/failsafe/failsafe_private.h:377:53: error: format speci

Re: [dpdk-dev] [PATCH] net/failsafe: fix FreeBSD build

2018-02-13 Thread Thomas Monjalon
13/02/2018 22:33, Thomas Monjalon: > The type pthread_t is not portable because it is freely defined. > On Linux, it is an unsigned long int which can be printed with %l. Forgot to add: On FreeBSD, it is a pointer. That's why there was this error: drivers/net/failsafe/failsafe_private.h:377:53: e

[dpdk-dev] [PATCH] net/failsafe: fix FreeBSD build

2018-02-13 Thread Thomas Monjalon
The type pthread_t is not portable because it is freely defined. On Linux, it is an unsigned long int which can be printed with %l. The debug printing of the thread id is restricted to Linux only. Fixes: 655fcd68c7d2 ("net/failsafe: fix hotplug races") Signed-off-by: Thomas Monjalon --- driver

Re: [dpdk-dev] [PATCH v7 0/3] failsafe: fix hotplug races

2018-02-13 Thread Thomas Monjalon
13/02/2018 22:13, Matan Azrad: > From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] > > There is a compilation error due to this patch on FreeBSD: > > > > drivers/net/failsafe/failsafe_private.h:377:53: error: format specifies type > > 'unsigned long' but the argument has type 'p

Re: [dpdk-dev] [PATCH v7 0/3] failsafe: fix hotplug races

2018-02-13 Thread Matan Azrad
From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] > Hi, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Tuesday, February 13, 2018 4:12 PM > > To: Matan Azrad > > Cc: dev@dpdk.org; Gaëtan Rivet > > Subject:

[dpdk-dev] 32-bit compilation & debug logs

2018-02-13 Thread Thomas Monjalon
Hi all, There is a very common pattern with build failures in DPDK. When compiling in 32-bit mode, there are some mismatches between printf format "%lu" / "%lx" and the size of the data being 64-bit. In 32-bit mode, a long is 32 bits long :) That's why "%lx" must be replaced by "%" PRIx64.

Re: [dpdk-dev] [PATCH v7 0/3] failsafe: fix hotplug races

2018-02-13 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, February 13, 2018 4:12 PM > To: Matan Azrad > Cc: dev@dpdk.org; Gaëtan Rivet > Subject: Re: [dpdk-dev] [PATCH v7 0/3] failsafe: fix hotplug races > > 13/02/2018 14:31, Gaëtan

Re: [dpdk-dev] release/acquire memory barriers and ring

2018-02-13 Thread Alex Kiselev
I am sorry. I should've posted to the user list of couse. My mistake. 2018-02-13 22:37 GMT+03:00 Alex Kiselev : > Hi. > > I've been wondering should I use a release/acquire memory barrier pair > in order to be sure that the other thread will see the fully/corrected > initialized object > passed to

[dpdk-dev] release/acquire memory barriers and ring

2018-02-13 Thread Alex Kiselev
Hi. I've been wondering should I use a release/acquire memory barrier pair in order to be sure that the other thread will see the fully/corrected initialized object passed to it via a dpdk ring or ring itself is a kind of barrier? Let's say I have a pseudo code: Thread1: obj = alloc(); ... obj i

[dpdk-dev] [PATCH v2] net/tap: fix promiscuous rules double insersions

2018-02-13 Thread Ophir Munk
Running testpmd command "port stop all" followed by command "port start all" may result in a TAP error: PMD: Kernel refused TC filter rule creation (17): File exists Root cause analysis: during the execution of "port start all" command testpmd calls rte_eth_promiscuous_enable() while during the ex

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: print correct crypto name

2018-02-13 Thread Thomas Monjalon
12/02/2018 08:02, Anoob Joseph: > > On 09/02/18 16:10, Radu Nicolau wrote: > > When AES-256 was used aes-128 was printed in the console > > > > Fixes: fa9088849e12 ("examples/ipsec-secgw: support AES 256") > > Signed-off-by: Radu Nicolau > Acked-by: Anoob Joseph Applied, thanks

Re: [dpdk-dev] [PATCH v2] example exception_path: cache align per CPU stats

2018-02-13 Thread Thomas Monjalon
13/02/2018 17:58, Dustin Lundquist: > Align stats structure to cache line to prevent bouncing per CPU stats > structure between cache lines. > > Fixes: af75078fece3 ("first public release") > > Signed-off-by: Dustin Lundquist Acked-by: Remy Horton Applied, thanks

Re: [dpdk-dev] [PATCH 0/3] Some fixes on virtio-user/vhost

2018-02-13 Thread Thomas Monjalon
13/02/2018 14:32, Maxime Coquelin: > > On 02/12/2018 04:20 AM, Jianfeng Tan wrote: > > Patch 1: a trivial fix on reword a log message. > > Patch 2: fix the rxq interrupt mode when virtio-user is used > > with vhost kernel. > > Patch 3: a trivial fix on LSC fd init when virtio-user is use

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 0/3] Vhost & Virtio fixes for v18.02

2018-02-13 Thread Thomas Monjalon
12/02/2018 16:46, Maxime Coquelin: > The second revision of this series includes Olivier's patch as first > patch in order to ease Thomas job when applying. > > Patch 2 rewords the commit message with detailed informations > provided by Tiwei and olivier (Thanks!). It also moves call to > virtio_r

[dpdk-dev] [PATCH v1] net/tap: fix promiscuous rules double insersions

2018-02-13 Thread Ophir Munk
Signed-off-by: Ophir Munk --- Full Commit message will follow immediately in v2 drivers/net/tap/tap_flow.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index 65657f0..d1f4a52 100644 --- a/drivers/net/tap/tap_flow.c +++ b

Re: [dpdk-dev] [PATCH] net/mlx5: dump flow create error message

2018-02-13 Thread Thomas Monjalon
> > > > Add error message dump when flow create error happened. > > > > > > > > Signed-off-by: Xueming Li > > Acked-by: Nelio Laranjeiro Applied, thanks

Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2018-02-13 Thread Adrien Mazarguil
Hi, Apologies for being late to this thread, I've read the ensuing discussion (hope I didn't miss any) and also think rte_flow could be improved in several ways to enable TEP support, in particular regarding the ordering of actions. On the other hand I'm not sure a dedicated API for TEP is needed

[dpdk-dev] [PATCH v2] example exception_path: cache align per CPU stats

2018-02-13 Thread Dustin Lundquist
Align stats structure to cache line to prevent bouncing per CPU stats structure between cache lines. Fixes: af75078fece3 ("first public release") Signed-off-by: Dustin Lundquist --- v2: * Include fixes tag Verified alignment of lcore_stats array elements using gdb. examples/exception_path/mai

Re: [dpdk-dev] [PATCH v2] doc: update doc for intel VF usage

2018-02-13 Thread Thomas Monjalon
> > update for intel VF usage: > > - Add note for AVF device ID generation. > > - Add steps for vfio-pci pass through. > > > > Signed-off-by: Jingjing Wu > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] doc: add missing SFN8xxx adapters to the list of supported

2018-02-13 Thread Thomas Monjalon
> > Signed-off-by: Andrew Rybchenko > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] net/nfp: rename nfp PF file

2018-02-13 Thread Thomas Monjalon
12/02/2018 10:57, Alejandro Lucero: > Other NICs with VF support do not use the _pf suffix for these files > but just for the VF description. > > This change makes NFP files consistent in this regard and helps with > how the DPDK web nics features matrix shows NFP devices. > > Signed-off-by: Alej

Re: [dpdk-dev] [PATCH] doc: fix jumbo frames entry in tap features

2018-02-13 Thread Thomas Monjalon
> > The current implementation of the Tap PMD doesn't support packet size > > grater than 1522B, so no need to set jumbo frames in the Tap features. > > > > Fixes: 04b2c3c94346 ("doc: add tap features") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Matan Azrad > Acked-by: Pascal Mazon Applied,

Re: [dpdk-dev] [PATCH v2] net/tap: add CRC stripping capability

2018-02-13 Thread Thomas Monjalon
13/02/2018 09:14, Ophir Munk: > CRC stripping is executed in the kernel outside of TAP PMD scope. > There is no prevention that the TAP PMD will report on Rx CRC > stripping capability. > In the corrupted code, TAP PMD did not report on this capability. > The fix enables TAP PMD to report that Rx C

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/failsafe: fix reconfiguration

2018-02-13 Thread Thomas Monjalon
12/02/2018 19:42, Gaëtan Rivet: > Hi Matan, > > On Sun, Feb 11, 2018 at 05:27:34PM +, Matan Azrad wrote: > > Fail-safe PMD manages the states of its sub-devices gradually: > > DEV_UNDEFINED, DEV_PARSED, DEV_PROBED, DEV_ACTIVE, DEV_STARTED. > > > > When the sub-device arguments successfully wa

Re: [dpdk-dev] [PATCH v7 0/3] failsafe: fix hotplug races

2018-02-13 Thread Thomas Monjalon
13/02/2018 14:31, Gaëtan Rivet: > Hi Matan, > > On Mon, Feb 12, 2018 at 08:51:39PM +, Matan Azrad wrote: > > This series fixes failsafe race between control commands to the asynchronic > > plug-out\in processes. > > > > Thanks for tackling this complicated issue. > For the series: > > Acke

Re: [dpdk-dev] [RFC v3, 2/3] cryptodev: add support to set session private data

2018-02-13 Thread Gujjar, Abhinandan S
Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, February 13, 2018 8:27 PM > To: Gujjar, Abhinandan S ; Doherty, Declan > ; akhil.go...@nxp.com; > jerin.jacobkollanukka...@cavium.com > Cc: dev@dpdk.org; Vangati, Narender ; Rao, > Nikhil > Subject: RE: [RFC v3,

Re: [dpdk-dev] [RFC v3, 1/3] cryptodev: set private data for session-less mode

2018-02-13 Thread Gujjar, Abhinandan S
Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, February 13, 2018 8:24 PM > To: Gujjar, Abhinandan S ; Doherty, Declan > ; akhil.go...@nxp.com; > jerin.jacobkollanukka...@cavium.com > Cc: dev@dpdk.org; Vangati, Narender ; Rao, > Nikhil > Subject: RE: [RFC v3,

Re: [dpdk-dev] [PATCH] net/mlx5: revert multicast rule Verbs flow type

2018-02-13 Thread Thomas Monjalon
13/02/2018 13:41, Nélio Laranjeiro: > On Tue, Feb 13, 2018 at 02:31:55PM +0200, Shahaf Shuler wrote: > > This is to revert the following commits: > > commit da646bd93888 ("net/mlx5: fix all multi verification code position") > > commit 0a40a1363a4d ("net/mlx5: fix flow type for allmulti rules") > >

Re: [dpdk-dev] [PATCH] examples/performance-thread: updates hasan alayli's license

2018-02-13 Thread Ferruh Yigit
On 2/13/2018 3:45 PM, Hemant Agrawal wrote: > >> -Original Message- >> From: Lee Daly [mailto:lee.d...@intel.com] >> Subject: [PATCH] examples/performance-thread: updates hasan alayli's license >> Importance: High >> >> This updates hasan alayli's license to be the standard BSD-3-Clause li

Re: [dpdk-dev] [PATCH] net/mlx5: fix socket assertion error during dev close

2018-02-13 Thread Thomas Monjalon
06/02/2018 14:22, Nélio Laranjeiro: > On Tue, Feb 06, 2018 at 08:54:22PM +0800, Xueming Li wrote: > > This patch fixed primary socket assertion error during close on a device > > that failed to start. > > > > Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file > > descriptor") > >

Re: [dpdk-dev] [PATCH] examples/performance-thread: updates hasan alayli's license

2018-02-13 Thread Hemant Agrawal
> -Original Message- > From: Lee Daly [mailto:lee.d...@intel.com] > Subject: [PATCH] examples/performance-thread: updates hasan alayli's license > Importance: High > > This updates hasan alayli's license to be the standard BSD-3-Clause license > used > for the rest of DPDK,bringing the f

Re: [dpdk-dev] [PATCH] eal: fix rte_errno values for IPC API

2018-02-13 Thread Bruce Richardson
On Tue, Feb 13, 2018 at 02:16:08PM +, Van Haaren, Harry wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Tuesday, February 13, 2018 1:51 PM > > To: Burakov, Anatoly > > Cc: dev@dpdk.org; Tan, Jianfeng > > Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_er

Re: [dpdk-dev] [PATCH] net/dpaa2: remove unused global variable

2018-02-13 Thread Thomas Monjalon
> > Fixes: a5fc38d422a7 ("net/dpaa2: support Rx packet parsing") > > > > Cc: hemant.agra...@nxp.com > > Signed-off-by: Jerin Jacob > > --- > > drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Acked-by: Hemant Agrawal Applied, thanks

Re: [dpdk-dev] [PATCH] ethdev: adjust error log level

2018-02-13 Thread Thomas Monjalon
13/02/2018 16:03, Martin Klozik: > DPDK API does not propagate the reason of device allocation failure > from rte_eth_dev_allocate() up to the DPDK application (e.g. Open > vSwitch). > Log level of associated log entries was changed to warning. So user > can find additional details in log files als

Re: [dpdk-dev] [PATCH v3] ethdev: fix ethdev data alignment

2018-02-13 Thread Thomas Monjalon
12/02/2018 14:13, Jerin Jacob: > The struct rte_eth_dev_data is used in ethdev fastpath routines > and it not aligned to cache line size. This patch fixes the ethdev > data alignment. > > The alignment was broken from the "first public release" changeset > where ethdev data address was aligned onl

Re: [dpdk-dev] [PATCH] examples: update copyrights and license

2018-02-13 Thread Hasan Alayli
Feel free to relicense lthread to BSD-3. On Thu, Feb 8, 2018 at 8:55 PM, Hemant Agrawal wrote: > On 2/8/2018 7:18 PM, Daly, Lee wrote: > >> Subject: Re: [PATCH] examples: update copyrights and license >>> >>> Hi Lee, >>> Hasan Alayli's license seems to be BSD-2-Clause, which is >>> typic

[dpdk-dev] [PATCH] examples/performance-thread: updates hasan alayli's license

2018-02-13 Thread Lee Daly
This updates hasan alayli's license to be the standard BSD-3-Clause license used for the rest of DPDK,bringing the files in compliance with the DPDK licensing policy. Signed-off-by: Lee Daly --- .../performance-thread/common/arch/x86/stack.h | 40 -- 1 file changed, 7 ins

[dpdk-dev] [PATCH] ethdev: adjust error log level

2018-02-13 Thread Martin Klozik
DPDK API does not propagate the reason of device allocation failure from rte_eth_dev_allocate() up to the DPDK application (e.g. Open vSwitch). Log level of associated log entries was changed to warning. So user can find additional details in log files also in production systems, where debug messag

Re: [dpdk-dev] [PATCH] doc: fix jumbo frames entry in tap features

2018-02-13 Thread Pascal Mazon
Acked-by: Pascal Mazon On 13/02/2018 14:22, Matan Azrad wrote: > The current implementation of the Tap PMD doesn't support packet size > grater than 1522B, so no need to set jumbo frames in the Tap features. > > Fixes: 04b2c3c94346 ("doc: add tap features") > Cc: sta...@dpdk.org > > Signed-off-by

Re: [dpdk-dev] [RFC v3, 2/3] cryptodev: add support to set session private data

2018-02-13 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: Gujjar, Abhinandan S > Sent: Thursday, February 1, 2018 9:30 AM > To: Doherty, Declan ; akhil.go...@nxp.com; De > Lara Guarch, Pablo ; > jerin.jacobkollanukka...@cavium.com > Cc: dev@dpdk.org; Vangati, Narender ; > Gujjar, Abhinandan S ; Rao, Nikhil > > Su

Re: [dpdk-dev] [RFC v3, 1/3] cryptodev: set private data for session-less mode

2018-02-13 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: Gujjar, Abhinandan S > Sent: Thursday, February 1, 2018 9:30 AM > To: Doherty, Declan ; akhil.go...@nxp.com; De > Lara Guarch, Pablo ; > jerin.jacobkollanukka...@cavium.com > Cc: dev@dpdk.org; Vangati, Narender ; > Gujjar, Abhinandan S ; Rao, Nikhil > > Su

Re: [dpdk-dev] [PATCH 1/1] doc: announce API change to lcore role function

2018-02-13 Thread Pavan Nikhilesh
On Tue, Feb 13, 2018 at 02:43:39PM +, Van Haaren, Harry wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > > Sent: Tuesday, February 13, 2018 2:38 PM > > To: Carrillo, Erik G ; nhor...@tuxdriver.com > > Cc: dev@dpdk.org; pbhagavat...@caviumnetworks.com; acon...@redha

Re: [dpdk-dev] [PATCH 1/1] doc: announce API change to lcore role function

2018-02-13 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Tuesday, February 13, 2018 2:38 PM > To: Carrillo, Erik G ; nhor...@tuxdriver.com > Cc: dev@dpdk.org; pbhagavat...@caviumnetworks.com; acon...@redhat.com; > tho...@monjalon.net > Subject: Re: [dpdk-dev] [PATCH 1/1] doc: ann

Re: [dpdk-dev] [PATCH 1/1] doc: announce API change to lcore role function

2018-02-13 Thread Ferruh Yigit
On 1/12/2018 8:45 PM, Erik Gabriel Carrillo wrote: > This an API/ABI change notice for DPDK 18.05 announcing a change in > the meaning of the return values of the rte_lcore_has_role() function. > > Signed-off-by: Erik Gabriel Carrillo Acked-by: Ferruh Yigit

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-13 Thread Burakov, Anatoly
On 12-Feb-18 10:00 PM, Ravi Kerur wrote: Let me just give you what has been tested and working/nonworking scenarios. Some of your questions might get answered as well. Test bed is very simple with 2 VF's created under IXGBE PF on host with one VF interface added t

Re: [dpdk-dev] [dpdk-techboard] next techboard meeting 2018-02-14

2018-02-13 Thread Ferruh Yigit
On 2/13/2018 10:37 AM, Olivier Matz wrote: > Hi, > > The next Technical Board meeting will happen on IRC freenode #dpdk-board > this wednesday 14 february 3pm UTC. > > You will find links to the agenda and previous meetings on this page: > http://dpdk.org/dev/techboard-minutes > The last one

Re: [dpdk-dev] [PATCH] eal: fix rte_errno values for IPC API

2018-02-13 Thread Burakov, Anatoly
On 13-Feb-18 2:16 PM, Van Haaren, Harry wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon Sent: Tuesday, February 13, 2018 1:51 PM To: Burakov, Anatoly Cc: dev@dpdk.org; Tan, Jianfeng Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_errno values for IPC API rte_errno val

Re: [dpdk-dev] [PATCH] eal: fix rte_errno values for IPC API

2018-02-13 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, February 13, 2018 1:51 PM > To: Burakov, Anatoly > Cc: dev@dpdk.org; Tan, Jianfeng > Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_errno values for IPC API > > > > rte_errno values should not be negative. > >

Re: [dpdk-dev] [PATCH] eal: fix rte_errno values for IPC API

2018-02-13 Thread Thomas Monjalon
> > rte_errno values should not be negative. > > > > Fixes: bacaa2754017 ("eal: add channel for multi-process communication") > > Fixes: 783b6e54971d ("eal: add synchronous multi-process communication") > > Cc: jianfeng@intel.com > > Signed-off-by: Anatoly Burakov > > Reviewed-by: Jianfeng T

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: remove unused map symbols

2018-02-13 Thread Thomas Monjalon
12/02/2018 18:41, Neil Horman: > On Mon, Feb 12, 2018 at 07:53:05PM +0530, Pavan Nikhilesh wrote: > > Remove some unused map symbol. > > > > Signed-off-by: Pavan Nikhilesh > Acked-by: Neil Horman Applied, thanks

Re: [dpdk-dev] [PATCH 0/3] Some fixes on virtio-user/vhost

2018-02-13 Thread Maxime Coquelin
On 02/12/2018 04:20 AM, Jianfeng Tan wrote: Patch 1: a trivial fix on reword a log message. Patch 2: fix the rxq interrupt mode when virtio-user is used with vhost kernel. Patch 3: a trivial fix on LSC fd init when virtio-user is used with vhost kernel. Jianfeng Tan (3):

Re: [dpdk-dev] [PATCH v7 0/3] failsafe: fix hotplug races

2018-02-13 Thread Gaëtan Rivet
Hi Matan, On Mon, Feb 12, 2018 at 08:51:39PM +, Matan Azrad wrote: > This series fixes failsafe race between control commands to the asynchronic > plug-out\in processes. > Thanks for tackling this complicated issue. For the series: Acked-by: Gaetan Rivet I hope there will be more work on

[dpdk-dev] [PATCH] doc: fix jumbo frames entry in tap features

2018-02-13 Thread Matan Azrad
The current implementation of the Tap PMD doesn't support packet size grater than 1522B, so no need to set jumbo frames in the Tap features. Fixes: 04b2c3c94346 ("doc: add tap features") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- doc/guides/nics/features/tap.ini | 1 - 1 file changed, 1

Re: [dpdk-dev] [PATCH v3] doc: ethdev ABI change deprecation notice

2018-02-13 Thread Olivier Matz
On Tue, Feb 13, 2018 at 12:09:19PM +, Ferruh Yigit wrote: > On 1/12/2018 2:38 PM, Neil Horman wrote: > > On Fri, Jan 12, 2018 at 10:29:46AM +, Kirill Rybalchenko wrote: > >> Signed-off-by: Kirill Rybalchenko > >> > >> Acked-by: Marko Kovacevic > >> --- > >> doc/guides/rel_notes/deprecati

Re: [dpdk-dev] [PATCH] doc: announce API change for ethdev port info

2018-02-13 Thread Olivier Matz
On Mon, Oct 16, 2017 at 04:27:47PM +0200, Ivan Boule wrote: > To help administrative tasks on ports, new per-port information need > to be added into the data structure rte_eth_dev_info supplied by the > dev_infos_get() function exported by a Poll Mode Driver. > > See http://dpdk.org/ml/archives/d

  1   2   >