Re: [dpdk-dev] [PATCH] net/mlx5: revert multicast rule Verbs flow type

[Thomas Monjalon]

13/02/2018 13:41, Nélio Laranjeiro:
> On Tue, Feb 13, 2018 at 02:31:55PM +0200, Shahaf Shuler wrote:
> > This is to revert the following commits:
> > commit da646bd93888 ("net/mlx5: fix all multi verification code position")
> > commit 0a40a1363a4d ("net/mlx5: fix flow type for allmulti rules")
> > 
> > The last one introduced a bug in the following diff:
> > @ -1262,6 +1274,7 @@ struct ibv_spec_header {
> >                 eth.val.ether_type &= eth.mask.ether_type;
> >         }
> >         mlx5_flow_create_copy(parser, &eth, eth_size);
> > +       parser->allmulti = eth.val.dst_mac[0] & 1;
> >         return 0;
> >  }
> > 
> > As broadcast rules will be considered of type allmulti as well.
> > 
> > The patch was originally intended to enable VF to receive all multicast
> > traffic by using the IBV_FLOW_ATTR_MC_DEFAULT flow type.
> > Since the support was removed from the kernel there is no point with
> > fixing this issue, hence the revert.
> > 
> > Cc: nelio.laranje...@6wind.com
> > Cc: rasl...@mellanox.com
> > Cc: sta...@dpdk.org
> > 
> > Signed-off-by: Shahaf Shuler <shah...@mellanox.com>
> 
> Acked-by: Nelio Laranjeiro <nelio.laranje...@6wind.com>

Applied, thanks