Re: [dpdk-dev] [PATCH] arch/arm: optimization for memcpy on AArch64

2017-12-01 Thread Pavan Nikhilesh Bhagavatula
On Mon, Nov 27, 2017 at 03:49:45PM +0800, Herbert Guan wrote: > This patch provides an option to do rte_memcpy() using 'restrict' > qualifier, which can induce GCC to do optimizations by using more > efficient instructions, providing some performance gain over memcpy() > on some AArch64 platforms/e

Re: [dpdk-dev] [PATCH v2] net/virtio: fix an incorrect behavior of device stop/start

2017-12-01 Thread Tiwei Bie
Hi Antonio, On Sat, Dec 02, 2017 at 01:17:58AM +0800, Fischetti, Antonio wrote: > Hi All, > I've got an update on this. > I could replicate the same issue by using testpmd + a VM (= Virtual Machine). > > The test topology I'm using is: > > > [Traffic gen][NIC port #0][testpmd][vhost

Re: [dpdk-dev] [PATCH 1/7] ethdev: remove unused flag from header

2017-12-01 Thread Vlad Zolotarov
On 12/01/2017 06:51 PM, Ferruh Yigit wrote: On 12/1/2017 2:17 PM, Vlad Zolotarov wrote: On 11/30/2017 09:29 PM, Ferruh Yigit wrote: remove RTE_ETHDEV_HAS_LRO_SUPPORT flag from header. Flag seems added with the patch that adds LRO support, and intention looks like giving a pointer to applica

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix MTU settings

2017-12-01 Thread Ferruh Yigit
On 11/24/2017 6:23 AM, Alejandro Lucero wrote: > The wrong mtu length was used for configuring the hardware. The > max_rx_pktlen reported was also wrong. > > Fixes: defb9a5dd156 ("nfp: introduce driver initialization") Cc: sta...@dpdk.org > > Signed-off-by: Alejandro Lucero Applied to dpdk-nex

Re: [dpdk-dev] [PATCH] net/bnxt: remove unused rx_tpa from bnxt_rx_queue{}

2017-12-01 Thread Ferruh Yigit
On 11/28/2017 2:50 PM, Ferruh Yigit wrote: > On 11/14/2017 4:42 AM, Ilya Matveychikov wrote: > > Please add maintainer to cc next time. > >> Signed-off-by: Ilya V. Matveychikov > > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/bonding: fix bonding in 8023ad mode

2017-12-01 Thread Ferruh Yigit
On 9/4/2017 6:37 AM, radu.nicolau at intel.com (Radu Nicolau) wrote: > On 8/8/2017 1:56 PM, Jacek Piasecki wrote: >> This patch blocks possibility to set master bonding by >> rte_eth_bond_mode_set() in 802.3ad mode, as the API >> doesn't prevent this. >> >> Fixes: 6d72657ce379 ("net/bonding: add ot

Re: [dpdk-dev] [PATCH v2] net/virtio: fix an incorrect behavior of device stop/start

2017-12-01 Thread Tiwei Bie
On Wed, Nov 15, 2017 at 01:38:32AM +0800, Fischetti, Antonio wrote: > Hi Tiwei, > > I'm doing some regression tests with v17.11-rc4. I ran > into a hitch with testpmd running into a guest VM. It happens > that no packet gets forwarded by testpmd. > The issue seems to appear after this patch was

[dpdk-dev] [Bug 5] This is a Bug, Please Disabled Create new Account

2017-12-01 Thread bugzilla
http://dpdk.org/tracker/show_bug.cgi?id=5 Bug ID: 5 Summary: This is a Bug, Please Disabled Create new Account Product: DPDK Version: unspecified Hardware: All OS: All Status: CONFIRMED Severity: critical

Re: [dpdk-dev] [PATCH] mmap(2) returns MAP_FAILED, not NULL, on failure

2017-12-01 Thread Ferruh Yigit
On 11/30/2017 10:51 PM, Michael McConville wrote: > Signed-off-by: Michael McConville > --- > lib/librte_eal/bsdapp/eal/eal_memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/bsdapp/eal/eal_memory.c > b/lib/librte_eal/bsdapp/eal/eal_memory.c > index 6

Re: [dpdk-dev] [PATCH] mmap(2) returns MAP_FAILED, not NULL, on failure

2017-12-01 Thread Ferruh Yigit
On 12/1/2017 4:50 PM, Ferruh Yigit wrote: > On 11/30/2017 10:51 PM, Michael McConville wrote: >> Signed-off-by: Michael McConville > > Reviewed-by: Ferruh Yigit > > > Hi Michael, > > Thanks you for the patch, can you please check the contribution guide [1] for > expected patch format for next

Re: [dpdk-dev] [PATCH] mmap(2) returns MAP_FAILED, not NULL, on failure

2017-12-01 Thread Ferruh Yigit
On 11/30/2017 10:51 PM, Michael McConville wrote: > Signed-off-by: Michael McConville Reviewed-by: Ferruh Yigit Hi Michael, Thanks you for the patch, can you please check the contribution guide [1] for expected patch format for next patches. [1] http://dpdk.org/doc/guides/contributing/patche

Re: [dpdk-dev] [PATCH 7/7] ethdev: use opaque user callback object

2017-12-01 Thread Ferruh Yigit
On 12/1/2017 5:17 AM, Bruce Richardson wrote: > On Fri, Dec 01, 2017 at 11:22:12AM +, Ananyev, Konstantin wrote: >> >> >>> -Original Message- >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson >>> Sent: Friday, December 1, 2017 10:33 AM >>> To: Yigit, Ferruh >>>

Re: [dpdk-dev] [PATCH 2/7] ethdev: fix port id storage

2017-12-01 Thread Ferruh Yigit
On 11/30/2017 6:29 PM, Ferruh Yigit wrote: > port_id is now 16bits, update function parameter according. > > Fixes: 4c270218aa26 ("ethdev: support security APIs") > Cc: sta...@dpdk.org > Cc: declan.dohe...@intel.com > > Signed-off-by: Ferruh Yigit > --- > Cc: Boris Pismenny > Cc: Aviad Yehezkel

Re: [dpdk-dev] [PATCH 3/7] ethdev: separate driver APIs

2017-12-01 Thread Ferruh Yigit
On 12/1/2017 12:59 AM, Hemant Agrawal wrote: > On 12/1/2017 7:59 AM, Ferruh Yigit wrote: > > ... >> diff --git a/lib/librte_ether/rte_ethdev_driver.h >> b/lib/librte_ether/rte_ethdev_driver.h >> new file mode 100644 >> index 0..3e77d1439 >> --- /dev/null >> +++ b/lib/librte_ether/rte_ethd

Re: [dpdk-dev] [PATCH 1/7] ethdev: remove unused flag from header

2017-12-01 Thread Ferruh Yigit
On 12/1/2017 2:17 PM, Vlad Zolotarov wrote: > > > On 11/30/2017 09:29 PM, Ferruh Yigit wrote: >> remove RTE_ETHDEV_HAS_LRO_SUPPORT flag from header. >> >> Flag seems added with the patch that adds LRO support, and intention >> looks like giving a pointer to application that library supports LRO.

Re: [dpdk-dev] [PATCH 2/2] eal/x86: Use lock-prefixed instructions to reduce cost of rte_smp_mb()

2017-12-01 Thread Ananyev, Konstantin
Hi Stephen, > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, December 1, 2017 6:04 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] eal/x86: Use lock-prefixed instructions > to reduce cost of rte_smp_m

Re: [dpdk-dev] [PATCH 1/7] ethdev: remove unused flag from header

2017-12-01 Thread Vlad Zolotarov
resending after registering with the new email domain ;) Please, see my comments below. On 12/01/2017 05:17 PM, Vlad Zolotarov wrote: On 11/30/2017 09:29 PM, Ferruh Yigit wrote: remove RTE_ETHDEV_HAS_LRO_SUPPORT flag from header. Flag seems added with the patch that adds LRO support, and int

Re: [dpdk-dev] [PATCH 2/3] power: switching to unbuffered access for /sys files

2017-12-01 Thread Radoslaw Biernacki
Hi David, Sorry for log delay. I will make V3 with your suggestions. Thanks. On 23 November 2017 at 15:42, Hunt, David wrote: > Hi Radoslaw, > > > > On 11/11/2017 6:55 PM, Radoslaw Biernacki wrote: > >> This patch fixes the bug caused by improper use of buffered stdio file >> access for switchi

Re: [dpdk-dev] [RFC PATCH v4 2/4] eventtimer: add common code

2017-12-01 Thread Carrillo, Erik G
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > [mailto:pbhagavat...@caviumnetworks.com] > Sent: Thursday, November 30, 2017 11:13 PM > To: Carrillo, Erik G > Cc: dev@dpdk.org > Subject: Re: [RFC PATCH v4 2/4] eventtimer: add common code > > On Thu, Nov 30, 2017 at 08:59:19PM

[dpdk-dev] [RFC PATCH v5 1/5] eventtimer: introduce event timer adapter

2017-12-01 Thread Erik Gabriel Carrillo
Signed-off-by: Erik Gabriel Carrillo --- doc/api/doxy-api-index.md | 1 + lib/librte_eventdev/Makefile | 1 + lib/librte_eventdev/rte_event_timer_adapter.h | 518 ++ lib/librte_eventdev/rte_eventdev.h| 4 +- 4 files ch

[dpdk-dev] [RFC PATCH v5 2/5] eventtimer: add common code

2017-12-01 Thread Erik Gabriel Carrillo
This commit adds the logic that is shared by all event timer adapter drivers; the common code handles instance allocation and some initialization. Signed-off-by: Erik Gabriel Carrillo --- config/common_base| 1 + drivers/event/sw/sw_evdev.c

[dpdk-dev] [RFC PATCH v5 0/5] eventtimer: introduce event timer adapter

2017-12-01 Thread Erik Gabriel Carrillo
This set of RFC patches contains a reworked version of the "front-end" of the event timer adapter, i.e., the API and common logic. This patch set produces the following checkpatch warning: "macro with flow control". I have left the macros in since such usage seems common in DPDK. v5 - Addressed

[dpdk-dev] [RFC PATCH v5 5/5] test: add event timer adapter auto-test

2017-12-01 Thread Erik Gabriel Carrillo
This commit adds enough test infrastructure to exercise the allocation/deallocation routines of the event timer adapter library minimally. Signed-off-by: Erik Gabriel Carrillo --- test/test/Makefile | 1 + test/test/test_event_timer_adapter.c | 249 +++

[dpdk-dev] [RFC PATCH v5 4/5] eventtimer: add default software implementation stub

2017-12-01 Thread Erik Gabriel Carrillo
If an eventdev PMD does not wish to provide event timer adapter ops definitions, the library will fall back to a default software implementation whose entry points are added by this commit. Signed-off-by: Erik Gabriel Carrillo --- lib/librte_eventdev/rte_event_timer_adapter.c | 107 +

[dpdk-dev] [RFC PATCH v5 3/5] eventtimer: add config variable for adapter

2017-12-01 Thread Erik Gabriel Carrillo
This commit introduces a configuration variable that can be used to enable or disable compilation of the event timer adapter. Signed-off-by: Erik Gabriel Carrillo --- config/common_base | 1 + drivers/event/sw/sw_evdev.c| 4 lib/librte_eventdev/Makefile

Re: [dpdk-dev] [RFC v1] doc compression API for DPDK

2017-12-01 Thread Trahe, Fiona
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Thursday, November 30, 2017 11:13 AM > To: Trahe, Fiona ; dev@dpdk.org > Cc: Athreya, Narayana Prasad ; Challa, > Mahipal > > Subject: Re: [RFC v1] doc compression API for DPDK > > HI Fiona > > > -

[dpdk-dev] [PATCH 2/4] compat: Add __experimental macro

2017-12-01 Thread Neil Horman
The __experimental macro tags a given exported function as being part of the EXPERIMENTAL api. Use of this tag will cause any caller of the function (that isn't removed by dead code elimination) to emit a warning that the user is making use of an API whos stabilty isn't guaranteed. It also places

[dpdk-dev] [PATCH 3/4] dpdk: add __experimental tag to appropriate api calls

2017-12-01 Thread Neil Horman
Append the __experimental tag to api calls appearing in the EXPERIMENTAL section of their libraries version map Signed-off-by: Neil Horman CC: Thomas Monjalon CC: "Mcnamara, John" --- lib/librte_eal/common/eal_common_dev.c | 5 ++- lib/librte_eal/common/eal_common_devargs.c

[dpdk-dev] [PATCH 1/4] buildtools: Add tool to check EXPERIMENTAL api exports

2017-12-01 Thread Neil Horman
This tools reads the given version map for a directory, and checks to ensure that, for each symbol listed in the export list, the corresponding definition is tagged as __experimental, erroring out if its not. In this way, we can ensure that the EXPERIMENTAL api is kept in sync with the tags Signe

[dpdk-dev] [PATCH 4/4] Makefiles: Add experimental tag check and warnings to trigger on use

2017-12-01 Thread Neil Horman
Add checks during build to ensure that all symbols in the EXPERIMENTAL version map section have __experimental tags on their definitions, and enable the warnings needed to announce their use. Also add a ALLOW_EXPERIMENTAL_FUNCTIONS variable check to allow for in-tree dpdk libraries to override tho

[dpdk-dev] [PATCH 0/4] dpdk: enhance EXPERIMENTAL api tagging

2017-12-01 Thread Neil Horman
Hey all- A few days ago, I was lamenting the fact that, when reviewing patches I would frequently complain about ABI changes that were actually considered safe because they were part of the EXPERIMENTAL api set. John M. asked me then what I might do to improve the situation, and the follow

[dpdk-dev] [PATCH 1/2] doc: Clarify wording regarding actions and flow rules.

2017-12-01 Thread Roy Franz
Current wording regarding actions and flow rules doesn't make sense. Signed-off-by: Roy Franz --- Maybe a better word than 'assigned' could be chosen? (attached, associated with, etc) I'm happy to spin this if needed. doc/guides/prog_guide/rte_flow.rst | 2 +- 1 file changed, 1 insertion(+)

[dpdk-dev] [PATCH 2/2] doc: Fix typo

2017-12-01 Thread Roy Franz
Fix trivial typo (an -> and) in description of service core masks. Signed-off-by: Roy Franz --- doc/guides/prog_guide/service_cores.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/service_cores.rst b/doc/guides/prog_guide/service_cores.rst index 3a0

Re: [dpdk-dev] [PATCH 2/2] eal/x86: Use lock-prefixed instructions to reduce cost of rte_smp_mb()

2017-12-01 Thread Stephen Hemminger
On Fri, 1 Dec 2017 11:12:51 + Konstantin Ananyev wrote: > On x86 it is possible to use lock-prefixed instructions to get > the similar effect as mfence. > As pointed by Java guys, on most modern HW that gives a better > performance than using mfence: > https://shipilev.net/blog/2014/on-the-

Re: [dpdk-dev] [PATCH v2] net/virtio: fix an incorrect behavior of device stop/start

2017-12-01 Thread Fischetti, Antonio
Hi All, I've got an update on this. I could replicate the same issue by using testpmd + a VM (= Virtual Machine). The test topology I'm using is: [Traffic gen][NIC port #0][testpmd][vhost port #2]+ |

Re: [dpdk-dev] rte_ctrlmbuf_init() and CTRL_MBUF_FLAG are not used - shouldn't they be removed and deprecated ?

2017-12-01 Thread Olivier MATZ
Hi Kevin, On Sat, Nov 25, 2017 at 01:43:17PM +0200, Kevin Wilson wrote: > Hi all, > > >Let's see if someone complains, and if no, we can plan to remove it > >for 17.11. > > Well, unless I missed it, I did not encounter any complaints, and > 17.11 was already released. > And the status is of cour

Re: [dpdk-dev] [PATCH 1/2] mbuf: check sanity of data_len and pkt_len as well

2017-12-01 Thread Olivier MATZ
Hi Ilya, On Thu, Nov 16, 2017 at 06:04:43PM +0400, Ilya Matveychikov wrote: > Signed-off-by: Ilya V. Matveychikov Please, add a commit log. > --- > lib/librte_mbuf/rte_mbuf.c | 23 +++ > 1 file changed, 15 insertions(+), 8 deletions(-) > > diff --git a/lib/librte_mbuf/rte_

Re: [dpdk-dev] [PATCH 2/2] mbuf: reset nb_segs of chained packet

2017-12-01 Thread Olivier MATZ
Hi Ilya, On Thu, Nov 16, 2017 at 11:15:18PM +0400, Ilya Matveychikov wrote: > > > On Nov 16, 2017, at 9:01 PM, Stephen Hemminger > > wrote: > > > > On Thu, 16 Nov 2017 18:05:35 +0400 > > Ilya Matveychikov wrote: > > > >> Fixes: 139debc42dc0 ("mbuf: move chaining from ip_frag library") > >> C

Re: [dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), remove useless variable

2017-12-01 Thread Olivier MATZ
Hi Ilya, On Tue, Nov 14, 2017 at 05:44:49PM +0400, Ilya Matveychikov wrote: > Fixes: af75078fece3 ("first public release") > Cc: intel.com The Cc tag seems wrong, should be removed. > Signed-off-by: Ilya V. Matveychikov > --- > > There is no reason to have local variable m2 or am I wrong? Yes

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-01 Thread Nelio Laranjeiro
Hi Annob On Fri, Dec 01, 2017 at 08:34:04PM +0530, Anoob Joseph wrote: > > > > I think we have an agreement here, in order the final action to be > > tested: > > > > 1. PASSTHRU > > 2. RSS > > 3. QUEUE > > > > If those 3 fails, the functions fails to create the rule, the first > > succee

[dpdk-dev] [PATCH] net/i40e: do not turn on flexible payload on driver init

2017-12-01 Thread Kirill Rybalchenko
Function i40e_GLQF_reg_init() overwrites global register for flexible payload, forcing extraction of first 16 bytes of L2/L3/L4 payload to the field vector even if flexible payload is not used by an application. Such unconditional turn on of flexible payload effectively disables ability to use oute

[dpdk-dev] [PATCH 7/7] net/mrvl: update MRVL NET PMD documentation

2017-12-01 Thread Tomasz Duszynski
Update MRVL NET PMD documentation. Signed-off-by: Tomasz Duszynski --- doc/guides/nics/mrvl.rst | 69 +++- 1 file changed, 45 insertions(+), 24 deletions(-) diff --git a/doc/guides/nics/mrvl.rst b/doc/guides/nics/mrvl.rst index fbfdf47..67b254c 100644

[dpdk-dev] [PATCH 6/7] devtools/test-build: add MRVL NET PMD to test-build

2017-12-01 Thread Tomasz Duszynski
Add MRVL NET PMD to test build tool. Signed-off-by: Tomasz Duszynski --- devtools/test-build.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/devtools/test-build.sh b/devtools/test-build.sh index 092d3a7..78609c9 100755 --- a/devtools/test-build.sh +++ b/devtools/test-build.sh @@ -197,6 +1

[dpdk-dev] [PATCH 5/7] net/mrvl: add extra error logs

2017-12-01 Thread Tomasz Duszynski
Add extra error logs in a few places. Signed-off-by: Tomasz Duszynski --- drivers/net/mrvl/mrvl_ethdev.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_ethdev.c index 40f2ead..127ce44 100644 --- a/drivers/n

[dpdk-dev] [PATCH 4/7] net/mrvl: check if ppio is initialized

2017-12-01 Thread Tomasz Duszynski
Uninitialized ppio cannot be passed to MUSDK library routines as application will crash. Fix this by first checking whether ppio has been initialized. Signed-off-by: Tomasz Duszynski --- drivers/net/mrvl/mrvl_ethdev.c | 42 ++ 1 file changed, 42 insertion

[dpdk-dev] [PATCH 3/7] net/mrvl: do not enable port after setting MAC address

2017-12-01 Thread Tomasz Duszynski
Setting enabled port's mac address caused it to stop receiving packets. Now as that issue is fixed in library renabling port is no longer necessary. Signed-off-by: Tomasz Duszynski --- drivers/net/mrvl/mrvl_ethdev.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --gi

[dpdk-dev] [PATCH 2/7] net/mrvl: query link status using library API

2017-12-01 Thread Tomasz Duszynski
Up to now link status was updated unconditionally during link_up()/link_down() calls thus one was never sure about it's true status. Using dedicated library api makes sure the true link status is set. Signed-off-by: Tomasz Duszynski --- drivers/net/mrvl/mrvl_ethdev.c | 16 +--- 1 fi

[dpdk-dev] [PATCH 1/7] net/mrvl: sync compilation with musdk-17.10

2017-12-01 Thread Tomasz Duszynski
Followig changes are needed to switch to musdk-17.10: - With a new version of the musdk library it's no longer necessary to explicitly define MVCONF_ARCH_DMA_ADDR_T_64BIT and CONF_PP2_BPOOL_COOKIE_SIZE. Proper defines are autogenerated by ./configure script based on passed options and ava

[dpdk-dev] [PATCH 0/7] Sync with MUSDK-17.10

2017-12-01 Thread Tomasz Duszynski
This patchset brings following changes: o Sync with MUSDK-17.10. Latest version of the library comes with many improvements and fixes thus switching to it is beneficial. o A few code and documentation updates. Changes since v1: o Add extra error log in case setting link up fails. o Cram all MU

[dpdk-dev] [PATCH] examples/eventdev_pipeline: add Rx adapter support

2017-12-01 Thread Pavan Nikhilesh
Use event Rx adapter for packets Rx instead of explicit producer logic. Use service run iter function for granular control instead of using dedicated service lcore. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline_sw_pmd/main.c | 149 +-- 1 file changed,

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-01 Thread Anoob Joseph
Hi Nelio, On 30-11-2017 17:58, Nelio Laranjeiro wrote: Hi Annob, On Thu, Nov 30, 2017 at 04:16:23PM +0530, Anoob wrote: On 11/29/2017 06:20 PM, Nelio Laranjeiro wrote: Hi Anoob, On Wed, Nov 29, 2017 at 06:00:38PM +0530, Anoob wrote: Hi Nelio, Since support of RSS with inline cryp

Re: [dpdk-dev] [RFC PATCH 0/3] *** SUBJECT HERE ***

2017-12-01 Thread Ananyev, Konstantin
Oops sorry, resending with proper subject. > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, December 1, 2017 2:48 PM > To: dev@dpdk.org; dev@dpdk.org > Cc: Ananyev, Konstantin > Subject: [RFC PATCH 0/3] *** SUBJECT HERE *** > > The series introduces 2 main changes: > > 1

[dpdk-dev] [RFC PATCH 0/3] ethdev: few changes in rte_ethdev layer

2017-12-01 Thread Konstantin Ananyev
The series introduces 2 main changes: 1.Introduce a separate data structure (rte_eth_queue_local) to store local to given process (i.e. no-shareable) information for each configured rx/tx queue. Memory for that structure is allocated/freed dynamically during rte_eth_dev_configure(). Reserve a spac

[dpdk-dev] [RFC PATCH 2/3] ethdev: make it safe to remove rx/tx callback at runtime

2017-12-01 Thread Konstantin Ananyev
Right now it is not possible for the application to know when it is safe to free removed callback handle and associated with it resources (unless the queue is stopped). That patch changes that behavior to: - if the rte_eth_remove_(rx|tx)_callback() completes successfully, then it will automatically

[dpdk-dev] [RFC PATCH 3/3] doc: ethdev ABI change deprecation notice

2017-12-01 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 13e85432f..038b55fd5 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/g

[dpdk-dev] [RFC PATCH 0/3] *** SUBJECT HERE ***

2017-12-01 Thread Konstantin Ananyev
The series introduces 2 main changes: 1.Introduce a separate data structure (rte_eth_queue_local) to store local to given process (i.e. no-shareable) information for each configured rx/tx queue. Memory for that structure is allocated/freed dynamically during rte_eth_dev_configure(). Reserve a spac

[dpdk-dev] [RFC PATCH 1/3] ethdev: introduce eth_queue_local

2017-12-01 Thread Konstantin Ananyev
Introduce a separate data structure (rte_eth_queue_local) to store local to given process (i.e. no-shareable) information for each configured rx/tx queue. Memory for that structure is allocated/freed dynamically during rte_eth_dev_configure(). Put a placeholder pointers for queue specific (rx|tx)_p

[dpdk-dev] [dpdk-announce] features review and integration for 18.02

2017-12-01 Thread Thomas Monjalon
Reminder of the planning for the release 18.02: - Proposal deadline: November 30, 2017 - Integration deadline: January 10, 2018 - Release: February 5, 2018 The proposal period is now over. It is time to focus on proposals which were done. It means everybody should review de

Re: [dpdk-dev] [PATCH] maintainers: claim responsibility for virtio PMD

2017-12-01 Thread Tiwei Bie
On Fri, Dec 01, 2017 at 02:46:46PM +0100, Maxime Coquelin wrote: > On 12/01/2017 12:04 PM, Tiwei Bie wrote: > > Add myself as co-maintainer for virtio driver. > > > > Signed-off-by: Tiwei Bie > > --- > > Hi Yuanhan and Maxime, > > > > As there will be more and more virtio related stuffs (e.g. vh

Re: [dpdk-dev] [PATCH] maintainers: claim responsibility for virtio PMD

2017-12-01 Thread Maxime Coquelin
On 12/01/2017 12:04 PM, Tiwei Bie wrote: Add myself as co-maintainer for virtio driver. Signed-off-by: Tiwei Bie --- Hi Yuanhan and Maxime, As there will be more and more virtio related stuffs (e.g. vhost-pci, virtio crypto, vhost crypto) in DPDK, more maintaining efforts will be needed for

Re: [dpdk-dev] [PATCH] contigmem: include to fix FreeBSD build

2017-12-01 Thread Bruce Richardson
On Fri, Dec 01, 2017 at 07:22:39PM +0800, kefu chai wrote: > otherwise the build fails with FreeBSD 12, like > > In file included from contigmem.c:57: > /usr/srcs/head/src/sys/vm/vm_phys.h:122:10: error: use of undeclared > identifier 'vm_cnt' > return (vm_cnt.v_free_count += adj); >

Re: [dpdk-dev] [PATCH 7/7] ethdev: use opaque user callback object

2017-12-01 Thread Bruce Richardson
On Fri, Dec 01, 2017 at 11:22:12AM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Friday, December 1, 2017 10:33 AM > > To: Yigit, Ferruh > > Cc: Thomas Monjalon ; dev@dpdk.org; > > vl...@c

Re: [dpdk-dev] 16.11.4 (LTS) patches review and test

2017-12-01 Thread Luca Boccassi
Hi all, Unfortunately the result of some of the regression tests (from AT&T) are not available yet due to a lab move. Regression tests from Intel look good (thanks for the help!) but just to be safe I'll delay tagging 16.11.4 by a week. Kind regards, Luca Boccassi On 21 Nov 2017 14:27, "Luca Boc

Re: [dpdk-dev] [PATCH] maintainers: claim responsibility for virtio PMD

2017-12-01 Thread Tiwei Bie
On Fri, Dec 01, 2017 at 08:06:04PM +0800, Yuanhan Liu wrote: > On Fri, Dec 01, 2017 at 07:04:35PM +0800, Tiwei Bie wrote: > > Add myself as co-maintainer for virtio driver. > > > > Signed-off-by: Tiwei Bie > > --- > > Hi Yuanhan and Maxime, > > > > As there will be more and more virtio related s

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-01 Thread Neil Horman
On Thu, Nov 30, 2017 at 02:24:43PM +0100, Gaëtan Rivet wrote: > Hello Matan, Neil, > > I like the port ownership concept. I think it is needed to clarify some > operations and should be useful to several subsystems. > > This patch could certainly be sub-divided however, and your current 1/5 > sho

Re: [dpdk-dev] [PATCH] maintainers: claim responsibility for virtio PMD

2017-12-01 Thread Yuanhan Liu
On Fri, Dec 01, 2017 at 07:04:35PM +0800, Tiwei Bie wrote: > Add myself as co-maintainer for virtio driver. > > Signed-off-by: Tiwei Bie > --- > Hi Yuanhan and Maxime, > > As there will be more and more virtio related stuffs (e.g. vhost-pci, > virtio crypto, vhost crypto) in DPDK, more maintaini

[dpdk-dev] [PATCH] contigmem: include to fix FreeBSD build

2017-12-01 Thread kefu chai
otherwise the build fails with FreeBSD 12, like In file included from contigmem.c:57: /usr/srcs/head/src/sys/vm/vm_phys.h:122:10: error: use of undeclared identifier 'vm_cnt' return (vm_cnt.v_free_count += adj); ^ 1 error generated. *** Error code 1 Signed-off-by: Kefu Cha

Re: [dpdk-dev] [PATCH 7/7] ethdev: use opaque user callback object

2017-12-01 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, December 1, 2017 10:33 AM > To: Yigit, Ferruh > Cc: Thomas Monjalon ; dev@dpdk.org; > vl...@cloudius-systems.com > Subject: Re: [dpdk-dev] [PATCH 7/7] ethdev: use opaque user cal

[dpdk-dev] [PATCH 2/2] eal/x86: Use lock-prefixed instructions to reduce cost of rte_smp_mb()

2017-12-01 Thread Konstantin Ananyev
On x86 it is possible to use lock-prefixed instructions to get the similar effect as mfence. As pointed by Java guys, on most modern HW that gives a better performance than using mfence: https://shipilev.net/blog/2014/on-the-fence-with-dependencies/ That patch adopts that technique for rte_smp_mb(

[dpdk-dev] [PATCH 1/2] test/test: introduce new test-case for rte_smp_mb()

2017-12-01 Thread Konstantin Ananyev
Simple functional test for rte_smp_mb() implementations. Also when executed on a single lcore could be used as rough estimation how many cycles particular implementation of rte_smp_mb() might take. Signed-off-by: Konstantin Ananyev --- test/test/Makefile | 1 + test/test/test_mb.c | 278 +

[dpdk-dev] [PATCH] maintainers: claim responsibility for virtio PMD

2017-12-01 Thread Tiwei Bie
Add myself as co-maintainer for virtio driver. Signed-off-by: Tiwei Bie --- Hi Yuanhan and Maxime, As there will be more and more virtio related stuffs (e.g. vhost-pci, virtio crypto, vhost crypto) in DPDK, more maintaining efforts will be needed for virtio/vhost. So I volunteer to co-maintain v

[dpdk-dev] [PATCH v2 2/2] app/testpmd: support GENEVE pattern item in flow rules

2017-12-01 Thread Andrew Rybchenko
From: Roman Zhukov Add the ability to match VNI and protocol fields of GENEVE protocol header. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline_flow.c | 31 + app/test-pmd/config.c | 1 + do

[dpdk-dev] [PATCH v2 0/2] ethdev: add GENEVE to flow API

2017-12-01 Thread Andrew Rybchenko
v2: - add after ESP to avoid ABI breakage - make default mask to include VNI only - minor style fixes Roman Zhukov (2): ethdev: add GENEVE flow pattern item app/testpmd: support GENEVE pattern item in flow rules app/test-pmd/cmdline_flow.c | 31

[dpdk-dev] [PATCH v2 1/2] ethdev: add GENEVE flow pattern item

2017-12-01 Thread Andrew Rybchenko
From: Roman Zhukov Add new pattern item RTE_FLOW_ITEM_TYPE_GENEVE in flow API. Add default mask for the item. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko --- doc/guides/prog_guide/rte_flow.rst | 12 lib/librte_ether/rte_flow.c| 1 + lib/librte_ether/rte_f

Re: [dpdk-dev] [PATCH 7/7] ethdev: use opaque user callback object

2017-12-01 Thread Bruce Richardson
On Fri, Dec 01, 2017 at 02:29:57AM +, Ferruh Yigit wrote: > "struct rte_eth_rxtx_callback" is defined as internal data structure but > used in public APIs. > > Checking the API documentation shows that intention was using this > object as opaque object. Data structure only used in delete APIs

Re: [dpdk-dev] [PATCH] contigmem: include to fix FreeBSD build

2017-12-01 Thread Bruce Richardson
On Thu, Nov 30, 2017 at 02:00:38PM +0800, kefu chai wrote: > otherwise the build fails with > > In file included from contigmem.c:57: > /usr/srcs/head/src/sys/vm/vm_phys.h:122:10: error: use of undeclared > identifier 'vm_cnt' > return (vm_cnt.v_free_count += adj); > ^ > 1

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-12-01 Thread Gaëtan Rivet
On Thu, Nov 30, 2017 at 10:44:58PM +0100, Thomas Monjalon wrote: > 30/11/2017 22:21, Stephen Hemminger: > > On Thu, 30 Nov 2017 18:35:11 +0100 > > Thomas Monjalon wrote: > > > > > 30/11/2017 18:15, Stephen Hemminger: > > > > Some thoughts. > > > > 1) Not all devices are PCI; look at recent VMBUS

Re: [dpdk-dev] [PATCH] eal/x86: get hypervisor name

2017-12-01 Thread Jerin Jacob
-Original Message- > Date: Fri, 01 Dec 2017 09:52:26 +0100 > From: Thomas Monjalon > To: Jerin Jacob > Cc: dev@dpdk.org, chao...@linux.vnet.ibm.com > Subject: Re: [dpdk-dev] [PATCH] eal/x86: get hypervisor name > > 01/12/2017 09:12, Jerin Jacob: > > -Original Message- > > > Date:

Re: [dpdk-dev] [PATCH 1/7] net/mrvl: sync compilation with musdk-17.10

2017-12-01 Thread Tomasz Duszynski
On Fri, Dec 01, 2017 at 11:29:07AM +0800, Jianbo Liu wrote: > The 11/30/2017 14:32, Tomasz Duszynski wrote: > > Followig changes are needed to switch to musdk-17.10: > > > > - With a new version of the musdk library it's no longer necessary to > > explicitly define MVCONF_ARCH_DMA_ADDR_T_64BIT an

Re: [dpdk-dev] [PATCH 2/7] ethdev: fix port id storage

2017-12-01 Thread Hemant Agrawal
On 12/1/2017 7:59 AM, Ferruh Yigit wrote: port_id is now 16bits, update function parameter according. Fixes: 4c270218aa26 ("ethdev: support security APIs") Cc: sta...@dpdk.org Cc: declan.dohe...@intel.com Signed-off-by: Ferruh Yigit --- Cc: Boris Pismenny Cc: Aviad Yehezkel Cc: Radu Nicolau

Re: [dpdk-dev] [PATCH 3/7] ethdev: separate driver APIs

2017-12-01 Thread Hemant Agrawal
On 12/1/2017 7:59 AM, Ferruh Yigit wrote: ... diff --git a/lib/librte_ether/rte_ethdev_driver.h b/lib/librte_ether/rte_ethdev_driver.h new file mode 100644 index 0..3e77d1439 --- /dev/null +++ b/lib/librte_ether/rte_ethdev_driver.h @@ -0,0 +1,163 @@ +/*- + * BSD LICENSE + * + * Copy

[dpdk-dev] [PATCH] net/i40e: add fdir nvgre parameters check

2017-12-01 Thread Wei Zhao
Add mask parameters check in nvgre parser for flow API. Fixes: 30965ca341278 ("net/i40e: add NVGRE flow parsing") Signed-off-by: Wei Zhao --- drivers/net/i40e/i40e_flow.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/i40e/i40e_flow.c b/driv

Re: [dpdk-dev] [PATCH] eal/x86: get hypervisor name

2017-12-01 Thread Thomas Monjalon
01/12/2017 09:12, Jerin Jacob: > -Original Message- > > Date: Thu, 30 Nov 2017 22:47:20 +0100 > > From: Thomas Monjalon > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] eal/x86: get hypervisor name > > X-Mailer: git-send-email 2.15.0 > > > > The CPUID instruction is catched by hypervi

Re: [dpdk-dev] [PATCH] bus/vdev: add custom scan hook

2017-12-01 Thread Thomas Monjalon
Hi, 01/12/2017 06:48, Tan, Jianfeng: > Hi Thomas, > > Please help us to understand why we need this. > > > On 12/1/2017 8:36 AM, Thomas Monjalon wrote: > > The scan callback allows to spawn a vdev automatically > > given some custom scan rules. > > These two new APIs (rte_vdev_add_custom_scan

Re: [dpdk-dev] [PATCH 2/2] Change root makefile license to SPDX tag

2017-12-01 Thread Hemant Agrawal
On 11/27/2017 5:31 PM, Bruce Richardson wrote: On Mon, Nov 27, 2017 at 01:16:04PM +0530, Hemant Agrawal wrote: Signed-off-by: Hemant Agrawal --- GNUmakefile | 27 +-- Makefile| 27 +-- 2 files changed, 2 insertions(+), 52 deletions(-) diff -

[dpdk-dev] [PATCH v2 1/2] Introducing SPDX License Identifiers

2017-12-01 Thread Hemant Agrawal
The DPDK uses the Open Source BSD-3-Clause license for the core libraries and drivers. The kernel components are naturally GPLv2 licensed. Many of the files in the DPDK source code contain the full text of the applicable license. For example, most of the BSD-3-Clause files contain a full copy of t

[dpdk-dev] [PATCH v2 2/2] Change root makefile license to SPDX tag

2017-12-01 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- GNUmakefile | 28 +--- Makefile| 28 +--- 2 files changed, 2 insertions(+), 54 deletions(-) diff --git a/GNUmakefile b/GNUmakefile index 45b7fbb..5b07b61 100644 --- a/GNUmakefile +++ b/GNUmakefile @@ -1,33 +1,7

[dpdk-dev] [PATCH 3/7] ethdev: separate driver APIs

2017-12-01 Thread Ferruh Yigit
Create a rte_ethdev_driver.h file and move PMD specific APIs here. Drivers updated to include this new header file. There is no update in header content and since ethdev.h included by ethdev_driver.h, nothing changed from driver point of view, only logically grouping of APIs. From applications poi

Re: [dpdk-dev] [PATCH 5/7] net/mrvl: add extra error logs

2017-12-01 Thread Tomasz Duszynski
On Fri, Dec 01, 2017 at 11:32:15AM +0800, Jianbo Liu wrote: > The 11/30/2017 14:32, Tomasz Duszynski wrote: > > Add extra error logs in a few places. > > > > Signed-off-by: Tomasz Duszynski > > --- > > drivers/net/mrvl/mrvl_ethdev.c | 9 ++--- > > 1 file changed, 6 insertions(+), 3 deletions(

Re: [dpdk-dev] [PATCH] eal/x86: get hypervisor name

2017-12-01 Thread Jerin Jacob
-Original Message- > Date: Thu, 30 Nov 2017 22:47:20 +0100 > From: Thomas Monjalon > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] eal/x86: get hypervisor name > X-Mailer: git-send-email 2.15.0 > > The CPUID instruction is catched by hypervisor which can return > a flag indicating one is