Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-18 Thread Thomas Monjalon
19/10/2017 04:45, Li, Xiaoyun: > Hi > > > > > > > > The significant change of this patch is to call a function pointer > > > > for packet size > 128 (RTE_X86_MEMCPY_THRESH). > > > The perf drop is due to function call replacing inline. > > > > > > > Please could you provide some benchmark numbers?

Re: [dpdk-dev] [PATCH v4] doc: update mlx5 flow count limitations

2017-10-18 Thread Olga Shern
Hi Ferruh, MLNX_OFED 4.2 will be released by the end of October Best Regards, Olga > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, October 19, 2017 9:19 AM > To: Ori Kam ; Adrien Mazarguil > ; Nélio Laranjeiro > ; Yongseok Koh ;

[dpdk-dev] [PATCH] doc: add basic howto for flow API

2017-10-18 Thread Ori Kam
As the rte flow is a new complex module in the DPDK. In order to ease developers in to using this feature it was suggested to supply a simple howto doc. Signed-off-by: Ori Kam --- doc/guides/howto/index.rst|1 + doc/guides/howto/rte_flow.rst | 307 +++

Re: [dpdk-dev] [PATCH v4] doc: update mlx5 flow count limitations

2017-10-18 Thread Ferruh Yigit
On 10/18/2017 11:09 PM, Ori Kam wrote: > Signed-off-by: Ori Kam > Acked-by: Shahaf Shuler > --- > v4: > * Clarify which OFED versionis required. > > v3: > * Remove unnecessary line. > > doc/guides/nics/mlx5.rst | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/doc/gu

[dpdk-dev] [PATCH v4] doc: update mlx5 flow count limitations

2017-10-18 Thread Ori Kam
Signed-off-by: Ori Kam Acked-by: Shahaf Shuler --- v4: * Clarify which OFED versionis required. v3: * Remove unnecessary line. doc/guides/nics/mlx5.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index d24941a..bcc3

Re: [dpdk-dev] [PATCH v2] examples/l2fwd-crypto: fix port id type

2017-10-18 Thread Yang, Zhiyong
Hi, Sorry I miss the changes in v2. Add it after SOB. Zhiyong > -Original Message- > From: Yang, Zhiyong > Sent: Thursday, October 19, 2017 10:57 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; De Lara Guarch, Pablo > ; Yang, Zhiyong > Subject: [PATCH v2] examples/l2fwd-crypto: fix port id

[dpdk-dev] [PATCH v2] examples/l2fwd-crypto: fix port id type

2017-10-18 Thread Zhiyong Yang
Fix port id issues and keep variables related to port ids in consistent data type definition "uint16_t". Remove unnecessary cast in the meanwhile. Fixes: f8244c6399d9 ("ethdev: increase port id range") Signed-off-by: Zhiyong Yang Acked-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 42 ++

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-18 Thread Li, Xiaoyun
Hi > > > > > > The significant change of this patch is to call a function pointer > > > for packet size > 128 (RTE_X86_MEMCPY_THRESH). > > The perf drop is due to function call replacing inline. > > > > > Please could you provide some benchmark numbers? > > I ran memcpy_perf_test which would show t

Re: [dpdk-dev] [PATCH v8 1/2] net/i40e: queue region set and flush

2017-10-18 Thread Zhao1, Wei
Hi, Andrey Yes, it is the number of queue pairs for pf. > -Original Message- > From: Chilikin, Andrey > Sent: Wednesday, October 18, 2017 9:01 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Yigit, Ferruh ; Xing, Beilei > ; Wu, Jingjing > Subject: RE: [dpdk-dev] [PATCH v8 1/2] net/i40e: queue

[dpdk-dev] [PATCH 3/3] net/qede: fix to re-enable LRO during device start

2017-10-18 Thread Rasesh Mody
From: Harish Patil Move LRO configuration from dev_configure to dev_start so that LRO configuration can be re-enabled following a port restart. Fixes: 9a6d30ae6d46 ("net/qede: refactoring vport handling code") Cc: sta...@dpdk.org Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c

[dpdk-dev] [PATCH 1/3] net/qede: fix supported packet types

2017-10-18 Thread Rasesh Mody
From: Harish Patil Update/fix supported ptypes to return both inner and outer headers, tunnel_type, fragmented and VLAN packet types. Fixes: 3d4bb4411683 ("net/qede: add fastpath support for VXLAN tunneling") Fixes: 2ea6f76aff40 ("qede: add core driver") Signed-off-by: Harish Patil Signed-off-

[dpdk-dev] [PATCH 2/3] net/qede: add support for VXLAN UDP port config over VF

2017-10-18 Thread Rasesh Mody
From: Harish Patil - Allow VXLAN enable/disable over VF using udp_tunnel_port_add/del APIs. Only default MAC/VLAN classification is supported. - Enable VxLAN before UDP port configuration. - Change VxLAN default UDP port to 4789 instead of 8472. Signed-off-by: Harish Patil --- drivers/net/qe

Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type

2017-10-18 Thread Yang, Zhiyong
Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, October 18, 2017 9:10 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: Yigit, Ferruh ; Yang, Zhiyong > > Subject: RE: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type > > Hi Zhiyong, > > > -Original

Re: [dpdk-dev] [PATCH v2] ethdev: fix xstats retrieve by id API

2017-10-18 Thread Ferruh Yigit
On 10/18/2017 4:10 AM, Ivan Malov wrote: > On 10/12/2017 2:31 PM, Lee Daly wrote: >> From: Lee >> >> Fix xstats functions, rte_eth_xstats_get_names_by_id() >> and rte_eth_xstats_get_by_id(), in current implementation >> ethdev level reads all xstat values and filters out >> the ones requested by t

Re: [dpdk-dev] [RFC PATCH v2 0/1] eventtimer: introduce event timer adapter

2017-10-18 Thread Carrillo, Erik G
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > [mailto:pbhagavat...@caviumnetworks.com] > Sent: Monday, October 16, 2017 7:37 AM > To: Carrillo, Erik G > Cc: dev@dpdk.org > Subject: Re: [RFC PATCH v2 0/1] eventtimer: introduce event timer adapter > > On Mon, Oct 16, 2017 at

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-18 Thread Ananyev, Konstantin
Hi Radu, Few comments from me below. Konstantin > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Saturday, October 14, 2017 11:18 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > Nicolau, Radu ; bor...@mellanox.

Re: [dpdk-dev] [PATCH] doc: fix highlight of bumped libs in release notes

2017-10-18 Thread Ferruh Yigit
On 10/13/2017 5:09 PM, Thomas Monjalon wrote: > The libraries which have their ABI version increased in this release > must be prepended with a + sign to make them appear clearly. > > Fixes: f8244c6399d9 ("ethdev: increase port id range") > Fixes: ec51443cc99a ("gso: add Generic Segmentation Offlo

Re: [dpdk-dev] Does cxgbe support multiple processes mode

2017-10-18 Thread Ferruh Yigit
On 10/17/2017 11:26 PM, He JianJun wrote: > Does cxgbe support multiple processes mode? If not, how can we implement it? > > I tried with 17.08 code, secondary process will crash at sge.c line 1098. > t4_eth_xmit() > because txq->eth_dev->data is NULL. > > I am guessing cxgbe driver does not supp

Re: [dpdk-dev] [PATCH] igb_uio: revert open and release operations

2017-10-18 Thread Ferruh Yigit
On 10/17/2017 11:27 PM, Shijith Thotton wrote: > On Tue, Oct 17, 2017 at 09:14:36PM +0100, Ferruh Yigit wrote: >> This reverts commit 6b9ed026a8704b9e5ee5da7997617ef7cc82e114. >> This reverts commit 5f6ff30dc5075c49069d684bab229aef7ff0fdc3. >> This reverts commit b58eedfc7dd57eef6d12e2c654a52c834f3

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-18 Thread Thomas Monjalon
18/10/2017 21:13, Aaron Conole: > Luca Boccassi writes: > > On Wed, 2017-10-18 at 15:20 +0100, Bruce Richardson wrote: > >> On Wed, Oct 18, 2017 at 01:24:54PM +0100, Bruce Richardson wrote: > >> > On Wed, Oct 18, 2017 at 11:14:07AM +0100, Luca Boccassi wrote: > >> > > On Wed, 2017-10-18 at 10:51 +

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-18 Thread Aaron Conole
Luca Boccassi writes: > On Wed, 2017-10-18 at 15:20 +0100, Bruce Richardson wrote: >> On Wed, Oct 18, 2017 at 01:24:54PM +0100, Bruce Richardson wrote: >> > On Wed, Oct 18, 2017 at 11:14:07AM +0100, Luca Boccassi wrote: >> > > On Wed, 2017-10-18 at 10:51 +0100, Bruce Richardson wrote: >> > > > On

Re: [dpdk-dev] [PATCH 8/8] doc: update app eventdev options

2017-10-18 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pavan Nikhilesh > Sent: Wednesday, October 18, 2017 1:39 PM > To: Richardson, Bruce ; Van Haaren, Harry > ; Eads, Gage ; > hemant.agra...@nxp.com; nipun.gu...@nxp.com; Rao, Nikhil > ; santosh.shu...@caviumnetworks

Re: [dpdk-dev] [PATCH v3 18/18] doc: remove deprecation notice for librte_table

2017-10-18 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Cristian Dumitrescu > Sent: Wednesday, October 18, 2017 4:04 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net > Subject: [dpdk-dev] [PATCH v3 18/18] doc: remove deprecation notice for > librte_table > > Signed-off

Re: [dpdk-dev] [PATCH 0/8] Support sample applications with new build system

2017-10-18 Thread Luca Boccassi
On Tue, 2017-10-17 at 17:12 +0100, Bruce Richardson wrote: > This patchset enables sample apps to be used with the new meson build > system. The work is really three-fold: > > * fix issues and pre-requisites to get the sample apps compiling, > such as >   ensuring that all needed PMDs are enabled,

[dpdk-dev] [pull-request] next-pipeline 17.11 pre-rc2

2017-10-18 Thread Cristian Dumitrescu
The following changes since commit 6b9ed026a8704b9e5ee5da7997617ef7cc82e114: igb_uio: fix build with kernel <= 3.17 (2017-10-16 13:07:11 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-pipeline for you to fetch changes up to 32ba3d320664a84bbd4575af3d85b78

Re: [dpdk-dev] [PATCH v3 00/18] librte_table: add key mask for hash tables

2017-10-18 Thread Dumitrescu, Cristian
> Cristian Dumitrescu (18): > test: removing calls to deprecated hash tables > librte_table: remove deprecated 8-byte key hash tables > librte_table: remove deprecated 16-byte key hash tables > librte_table: remove deprecated variable size key ext hash tables > librte_table: remove deprec

Re: [dpdk-dev] [PATCH] maintainers: updated ipsec_secgw

2017-10-18 Thread Sergio Gonzalez Monroy
On 18/10/2017 13:06, Radu Nicolau wrote: Signed-off-by: Radu Nicolau --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2a58378..5fd5acf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -920,6 +920,7 @@ F: examples/helloworld/ F: doc/guides/samp

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: set ip6_plen to the proper value

2017-10-18 Thread Sergio Gonzalez Monroy
On 13/10/2017 09:04, Tomasz Duszynski wrote: ipv6 payload length header field should contain only the number of bytes following the ipv6 header and not the entire packet size. Fixes: f159e70b0922 ("examples/ipsec-secgw: support transport mode") Fixes: 906257e965b7 ("examples/ipsec-secgw: support

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-18 Thread Luca Boccassi
On Wed, 2017-10-18 at 15:20 +0100, Bruce Richardson wrote: > On Wed, Oct 18, 2017 at 01:24:54PM +0100, Bruce Richardson wrote: > > On Wed, Oct 18, 2017 at 11:14:07AM +0100, Luca Boccassi wrote: > > > On Wed, 2017-10-18 at 10:51 +0100, Bruce Richardson wrote: > > > > On Wed, Oct 18, 2017 at 10:35:48

Re: [dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx mempool device

2017-10-18 Thread Thomas Monjalon
18/10/2017 16:36, Jerin Jacob: > From: santosh > > > > On Wednesday 18 October 2017 07:15 PM, Thomas Monjalon wrote: > > > 18/10/2017 14:17, santosh: > > >> Hi Thomas, > > >> > > >> > > >> On Monday 09 October 2017 02:49 PM, santosh wrote: > > >>> On Monday 09 October 2017 02:18 PM, Thomas Monjal

[dpdk-dev] [PATCH v3 14/18] test: add mask-based hash functions

2017-10-18 Thread Cristian Dumitrescu
Introduce mask-based hash functions in hash_func.h. Propagate their usage in test/test, test/test-pipeline and examples/ip_pipeline. Remove the non-mask-based hash function prototype from API (which was previously used as build workaround). Signed-off-by: Cristian Dumitrescu --- examples/ip_pi

[dpdk-dev] [PATCH v3 13/18] librte_table: rework cuckoo hash table

2017-10-18 Thread Cristian Dumitrescu
Rework for the cuckoo hash table to use the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h| 26 -- lib/librte_table/rte_table_hash_cuckoo.c | 149 +-- test/test-pipeline/pipeline_hash.c | 18 ++

[dpdk-dev] [PATCH v3 11/18] librte_table: rework 16-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
Rework for the 16-byte key hash tables (both the extendible bucket and LRU)to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 14 +- lib/librte_table/rte_table_hash.h

[dpdk-dev] [PATCH v3 12/18] librte_table: rework 32-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
Rework for the 32-byte key hash tables (both the extendible bucket and LRU)to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h | 50 - lib/librte_table/rte_table_hash_key32.c | 386 ++

[dpdk-dev] [PATCH v3 10/18] librte_table: rework 8-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
Rework for the 8-byte key hash tables (both the extendible bucket and LRU)to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 14 +- .../ip_pipeline/pipeline/pipeline_routing_be.c

[dpdk-dev] [PATCH v3 18/18] doc: remove deprecation notice for librte_table

2017-10-18 Thread Cristian Dumitrescu
Signed-off-by: Cristian Dumitrescu --- doc/guides/rel_notes/deprecation.rst | 6 -- 1 file changed, 6 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 52058f5..2ea19e7 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guid

[dpdk-dev] [PATCH v3 17/18] librte_table: map file updates

2017-10-18 Thread Cristian Dumitrescu
Updated map file to current API. Several API items were removed, so not using inheritance. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_version.map | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/lib/librte_table/rte_table_version.

[dpdk-dev] [PATCH v3 09/18] librte_table: rework variable size key lru hash table

2017-10-18 Thread Cristian Dumitrescu
Rework for the variable size key LRU hash table to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h | 26 lib/librte_table/rte_table_hash_lru.c | 277 +- test/t

[dpdk-dev] [PATCH v3 15/18] librte_table: cosmetic enhancements in api file

2017-10-18 Thread Cristian Dumitrescu
Consolidated hash tables into functional groups. Minor changes in comments. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h | 34 +- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/lib/librte_table/rte_table_hash.h b/lib/li

[dpdk-dev] [PATCH v3 16/18] librte_table: copyright cosmetic updates

2017-10-18 Thread Cristian Dumitrescu
Removed incorrect white spaces and updated year in copyrigh headers. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h| 2 +- lib/librte_table/rte_table_hash_cuckoo.c | 52 lib/librte_table/rte_table_hash_ext.c| 52

[dpdk-dev] [PATCH v3 06/18] librte_table: rename cuckoo hash table ops

2017-10-18 Thread Cristian Dumitrescu
The dosig particle is eliminated from the cuckoo hash ops name. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h| 3 +-- lib/librte_table/rte_table_hash_cuckoo.c | 6 ++--- test/test-pipeline/pipeline_hash.c | 2 +- test/test/test_table_combined.c

[dpdk-dev] [PATCH v3 08/18] librte_table: rework variable size key ext hash tables

2017-10-18 Thread Cristian Dumitrescu
Rework for the variable size key extendible bucket (EXT) hash table to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 12 +- lib/librte_table/rte_table_hash.h | 3

[dpdk-dev] [PATCH v3 07/18] librte_table: add unified params structure and mask-based hash func

2017-10-18 Thread Cristian Dumitrescu
Add unified parameter structure for all hash tables in librte_table. Add mask-based hash function prototype, which is input parameter for all hash tables. Renamed the non-mask-based hash function prototype and all the calls to it (to be removed later). Signed-off-by: Cristian Dumitrescu --- ..

[dpdk-dev] [PATCH v3 04/18] librte_table: remove deprecated variable size key ext hash tables

2017-10-18 Thread Cristian Dumitrescu
The non-dosig version of the variable size key extendible bucket hash tables are removed. The remaining hash tables are renamed to eliminate the dosig particle from their name. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 2 +- lib/librte_table/rt

[dpdk-dev] [PATCH v3 05/18] librte_table: remove deprecated variable size key lru hash tables

2017-10-18 Thread Cristian Dumitrescu
The non-dosig version of the variable size key Least Recently Used (LRU) hash tables are removed. The remaining hash tables are renamed to eliminate the dosig particle from their name. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h | 4 - lib/librte_table/rte_tabl

[dpdk-dev] [PATCH v3 03/18] librte_table: remove deprecated 16-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
The non-dosig version of the 16-byte key hash tables (both extendable bucket and LRU) are removed. The remaining hash tables are renamed to eliminate the dosig particle from their name. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 2 +- lib/librte

[dpdk-dev] [PATCH v3 02/18] librte_table: remove deprecated 8-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
The non-dosig version of the 8-byte key hash tables (both extendable bucket and LRU) are removed. The remaining hash tables are renamed to eliminate the dosig particle from their name. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 2 +- .../ip_pipe

[dpdk-dev] [PATCH v3 01/18] test: removing calls to deprecated hash tables

2017-10-18 Thread Cristian Dumitrescu
Removing calls to hash tables that are going to be removed later. The calls are removed from test/test, test/test-pipeline, examples/ip_pipeline. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 18 +++--- test/test-pipeline/pipeline_hash.c

[dpdk-dev] [PATCH v3 00/18] librte_table: add key mask for hash tables

2017-10-18 Thread Cristian Dumitrescu
Main changes: 1. The key_mask parameter is added to all the hash tables that were previously missing it, as well to the hash compute function. This was first started in DPDK 2.0, but was only implemented for a couple of hash tables. The benefit of this approach is that it allows for bette

[dpdk-dev] [PATCH v3 16/18] librte_table: copyright cosmetic updates

2017-10-18 Thread Cristian Dumitrescu
Removed incorrect white spaces and updated year in copyrigh headers. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h| 2 +- lib/librte_table/rte_table_hash_cuckoo.c | 52 lib/librte_table/rte_table_hash_ext.c| 52

[dpdk-dev] [PATCH v3 17/18] librte_table: map file updates

2017-10-18 Thread Cristian Dumitrescu
Updated map file to current API. Several API items were removed, so not using inheritance. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_version.map | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) mode change 100644 => 100755 lib/librte_table/rt

[dpdk-dev] [PATCH v3 18/18] doc: remove deprecation notice for librte_table

2017-10-18 Thread Cristian Dumitrescu
Signed-off-by: Cristian Dumitrescu --- doc/guides/rel_notes/deprecation.rst | 6 -- 1 file changed, 6 deletions(-) mode change 100644 => 100755 doc/guides/rel_notes/deprecation.rst diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst old mode 100644 new

[dpdk-dev] [PATCH v3 15/18] librte_table: cosmetic enhancements in api file

2017-10-18 Thread Cristian Dumitrescu
Consolidated hash tables into functional groups. Minor changes in comments. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h | 34 +- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/lib/librte_table/rte_table_hash.h b/lib/li

[dpdk-dev] [PATCH v3 13/18] librte_table: rework cuckoo hash table

2017-10-18 Thread Cristian Dumitrescu
Rework for the cuckoo hash table to use the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h| 26 -- lib/librte_table/rte_table_hash_cuckoo.c | 149 +-- test/test-pipeline/pipeline_hash.c | 18 ++

[dpdk-dev] [PATCH v3 14/18] test: add mask-based hash functions

2017-10-18 Thread Cristian Dumitrescu
Introduce mask-based hash functions in hash_func.h. Propagate their usage in test/test, test/test-pipeline and examples/ip_pipeline. Remove the non-mask-based hash function prototype from API (which was previously used as build workaround). Signed-off-by: Cristian Dumitrescu --- examples/ip_pi

[dpdk-dev] [PATCH v3 12/18] librte_table: rework 32-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
Rework for the 32-byte key hash tables (both the extendible bucket and LRU)to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h | 50 - lib/librte_table/rte_table_hash_key32.c | 386 ++

[dpdk-dev] [PATCH v3 06/18] librte_table: rename cuckoo hash table ops

2017-10-18 Thread Cristian Dumitrescu
The dosig particle is eliminated from the cuckoo hash ops name. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h| 3 +-- lib/librte_table/rte_table_hash_cuckoo.c | 6 ++--- test/test-pipeline/pipeline_hash.c | 2 +- test/test/test_table_combined.c

[dpdk-dev] [PATCH v3 10/18] librte_table: rework 8-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
Rework for the 8-byte key hash tables (both the extendible bucket and LRU)to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 14 +- .../ip_pipeline/pipeline/pipeline_routing_be.c

[dpdk-dev] [PATCH v3 11/18] librte_table: rework 16-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
Rework for the 16-byte key hash tables (both the extendible bucket and LRU)to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 14 +- lib/librte_table/rte_table_hash.h

[dpdk-dev] [PATCH v3 09/18] librte_table: rework variable size key lru hash table

2017-10-18 Thread Cristian Dumitrescu
Rework for the variable size key LRU hash table to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h | 26 lib/librte_table/rte_table_hash_lru.c | 277 +- test/t

[dpdk-dev] [PATCH v3 08/18] librte_table: rework variable size key ext hash tables

2017-10-18 Thread Cristian Dumitrescu
Rework for the variable size key extendible bucket (EXT) hash table to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 12 +- lib/librte_table/rte_table_hash.h | 3

[dpdk-dev] [PATCH v3 07/18] librte_table: add unified params structure and mask-based hash func

2017-10-18 Thread Cristian Dumitrescu
Add unified parameter structure for all hash tables in librte_table. Add mask-based hash function prototype, which is input parameter for all hash tables. Renamed the non-mask-based hash function prototype and all the calls to it (to be removed later). Signed-off-by: Cristian Dumitrescu --- ..

[dpdk-dev] [PATCH v3 05/18] librte_table: remove deprecated variable size key lru hash tables

2017-10-18 Thread Cristian Dumitrescu
The non-dosig version of the variable size key Least Recently Used (LRU) hash tables are removed. The remaining hash tables are renamed to eliminate the dosig particle from their name. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h | 4 - lib/librte_table/rte_tabl

[dpdk-dev] [PATCH v3 04/18] librte_table: remove deprecated variable size key ext hash tables

2017-10-18 Thread Cristian Dumitrescu
The non-dosig version of the variable size key extendible bucket hash tables are removed. The remaining hash tables are renamed to eliminate the dosig particle from their name. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 2 +- lib/librte_table/rt

[dpdk-dev] [PATCH v3 03/18] librte_table: remove deprecated 16-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
The non-dosig version of the 16-byte key hash tables (both extendable bucket and LRU) are removed. The remaining hash tables are renamed to eliminate the dosig particle from their name. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 2 +- lib/librte

[dpdk-dev] [PATCH v3 00/18] librte_table: add key mask for hash tables

2017-10-18 Thread Cristian Dumitrescu
Main changes: 1. The key_mask parameter is added to all the hash tables that were previously missing it, as well to the hash compute function. This was first started in DPDK 2.0, but was only implemented for a couple of hash tables. The benefit of this approach is that it allows for bette

[dpdk-dev] [PATCH v3 01/18] test: removing calls to deprecated hash tables

2017-10-18 Thread Cristian Dumitrescu
Removing calls to hash tables that are going to be removed later. The calls are removed from test/test, test/test-pipeline, examples/ip_pipeline. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 18 +++--- test/test-pipeline/pipeline_hash.c

[dpdk-dev] [PATCH v3 02/18] librte_table: remove deprecated 8-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
The non-dosig version of the 8-byte key hash tables (both extendable bucket and LRU) are removed. The remaining hash tables are renamed to eliminate the dosig particle from their name. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 2 +- .../ip_pipe

[dpdk-dev] [ dpdk-dev ] PF set mac address api

2017-10-18 Thread Harouat, Karim (Nokia - FR/Lannion)
Hello Could someone advise me the more appropriate api to use to set pf mac address please ? It is to set it after the pf is bound. Specially for fm10k pf please The search tool on online document is not efficient to find it. thanks Best Regards, Cordialement Karim H

Re: [dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx mempool device

2017-10-18 Thread Jerin Jacob
-Original Message- > Date: Wed, 18 Oct 2017 19:32:44 +0530 > From: santosh > To: Thomas Monjalon , John McNamara > > Cc: dev@dpdk.org, olivier.m...@6wind.com, jerin.ja...@caviumnetworks.com, > hemant.agra...@nxp.com, ferruh.yi...@intel.com > Subject: Re: [dpdk-dev] [PATCH v3 10/10] doc:

Re: [dpdk-dev] [PATCH v5 10/20] pci: avoid inlining functions

2017-10-18 Thread Aaron Conole
Gaëtan Rivet writes: > On Tue, Oct 17, 2017 at 02:20:45PM -0400, Aaron Conole wrote: >> Gaetan Rivet writes: >> >> > Parsing operations should not happen in performance critical sections. >> > Headers should not propose implementations unless duly required. >> > >> > Signed-off-by: Gaetan Rivet

Re: [dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx mempool device

2017-10-18 Thread Thomas Monjalon
18/10/2017 16:02, santosh: > > On Wednesday 18 October 2017 07:15 PM, Thomas Monjalon wrote: > > 18/10/2017 14:17, santosh: > >> Hi Thomas, > >> > >> > >> On Monday 09 October 2017 02:49 PM, santosh wrote: > >>> On Monday 09 October 2017 02:18 PM, Thomas Monjalon wrote: > 09/10/2017 07:46, sa

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-18 Thread Bruce Richardson
On Wed, Oct 18, 2017 at 01:24:54PM +0100, Bruce Richardson wrote: > On Wed, Oct 18, 2017 at 11:14:07AM +0100, Luca Boccassi wrote: > > On Wed, 2017-10-18 at 10:51 +0100, Bruce Richardson wrote: > > > On Wed, Oct 18, 2017 at 10:35:48AM +0100, Bruce Richardson wrote: > > > > On Tue, Oct 17, 2017 at 0

Re: [dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx mempool device

2017-10-18 Thread santosh
On Wednesday 18 October 2017 07:15 PM, Thomas Monjalon wrote: > 18/10/2017 14:17, santosh: >> Hi Thomas, >> >> >> On Monday 09 October 2017 02:49 PM, santosh wrote: >>> On Monday 09 October 2017 02:18 PM, Thomas Monjalon wrote: 09/10/2017 07:46, santosh: > On Monday 09 October 2017 10:31

Re: [dpdk-dev] [PATCH 2/2] power: check if userspace governor is available

2017-10-18 Thread Radoslaw Biernacki
Hi David, On 18 October 2017 at 12:53, Hunt, David wrote: > Hi Radoslaw, > > > On 16/10/2017 2:47 PM, Radoslaw Biernacki wrote: > >> Since for new Intel CPU's kernel use intel_pstate driver, >> which does not offer userspace governor, it is vise to check >> > > typo here, "wise" > > the userspac

Re: [dpdk-dev] [PATCH 1/2] power: switching to unbuffered stdio for /sys file access

2017-10-18 Thread Radoslaw Biernacki
Hi David, Thank you for comments. On 18 October 2017 at 12:33, Hunt, David wrote: > Hi Radoslaw, > > > On 16/10/2017 2:47 PM, Radoslaw Biernacki wrote: > >> This patch fixes the bug caused by improper use of buffered >> stdio file access for switching the CPU frequency and >> governor. Each wri

Re: [dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx mempool device

2017-10-18 Thread Thomas Monjalon
18/10/2017 14:17, santosh: > Hi Thomas, > > > On Monday 09 October 2017 02:49 PM, santosh wrote: > > On Monday 09 October 2017 02:18 PM, Thomas Monjalon wrote: > >> 09/10/2017 07:46, santosh: > >>> On Monday 09 October 2017 10:31 AM, santosh wrote: > Hi Thomas, > > > On Sunday

Re: [dpdk-dev] [PATCH] doc: update release note for DPAA PMD support

2017-10-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shreyansh Jain > Sent: Wednesday, October 18, 2017 12:45 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Yigit, Ferruh ; > Shreyansh Jain > Subject: [dpdk-dev] [PATCH] doc: update release note for DPAA PMD > sup

Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type

2017-10-18 Thread De Lara Guarch, Pablo
Hi Zhiyong, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhiyong Yang > Sent: Wednesday, October 18, 2017 10:50 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Yang, Zhiyong > > Subject: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type > > Fix port id

Re: [dpdk-dev] [PATCH v8 1/2] net/i40e: queue region set and flush

2017-10-18 Thread Chilikin, Andrey
Hi Wei, Is there number of RX queues configured for the port? If main_vsi->nb_used_qps reflects number of enabled RX queues, then it can be used. Regards, Andrey > -Original Message- > From: Zhao1, Wei > Sent: Wednesday, October 18, 2017 4:01 AM > To: Chilikin, Andrey ; dev@dpdk.org >

[dpdk-dev] [PATCH 8/8] doc: update app eventdev options

2017-10-18 Thread Pavan Nikhilesh
Update documentation about new --prod_type_ethdev option in app/eventdev. Signed-off-by: Pavan Nikhilesh --- doc/guides/tools/testeventdev.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/guides/tools/testeventdev.rst b/doc/guides/tools/testeventdev.rst index 34b1c31

[dpdk-dev] [PATCH 7/8] app/eventdev: add service core configuration

2017-10-18 Thread Pavan Nikhilesh
Add service core configuration for Rx adapter. The configuration picks the least used service core to run the service on. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/evt_common.h | 41 app/test-eventdev/test_perf_atq.c| 12 +++ app/

[dpdk-dev] [PATCH 6/8] app/eventdev: add event Rx adapter setup

2017-10-18 Thread Pavan Nikhilesh
Add functions to setup and configure Rx adapter based on the number of ethdev ports setup. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_common.c | 97 ++-- app/test-eventdev/test_perf_common.h | 1 + 2 files changed, 84 insertions(+), 14 deletio

[dpdk-dev] [PATCH 1/8] app/eventdev: add ethernet device producer option

2017-10-18 Thread Pavan Nikhilesh
Add command line option --prod_type_ethdev to specify that the events are generated by ethernet device. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/evt_options.c | 11 +++ app/test-eventdev/evt_options.h | 29 + app/test-eventdev/test_perf_c

[dpdk-dev] [PATCH 5/8] app/eventdev: add ethernet device tear down

2017-10-18 Thread Pavan Nikhilesh
Add ethernet device destroy functions to stop and close ethdev ports if they are configured when prod_type_ethdev option is enabled. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_atq.c| 1 + app/test-eventdev/test_perf_common.c | 13 + app/test-eventdev/test_per

[dpdk-dev] [PATCH 4/8] app/eventdev: add ethernet device setup helpers

2017-10-18 Thread Pavan Nikhilesh
Add ethernet device setup functions to configure ethdev ports incase prod_type_ethdev option is enabled. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_atq.c| 1 + app/test-eventdev/test_perf_common.c | 72 app/test-eventdev/test_perf_com

[dpdk-dev] [PATCH 2/8] app/eventdev: modify app setup to support ethdev

2017-10-18 Thread Pavan Nikhilesh
Modify app setup to accommodate event port and queue setup based on the number of ethernet ports. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_atq.c| 18 ++ app/test-eventdev/test_perf_common.c | 27 +-- app/test-eventdev/test_perf_co

[dpdk-dev] [PATCH 3/8] app/eventdev: add pktmbuf pool for ethdev

2017-10-18 Thread Pavan Nikhilesh
Add pktmbuf pool creation used when configuring ethernet device as event producer. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_common.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/t

[dpdk-dev] [PATCH 0/8] app/eventdev: add event eth Rx adapter support

2017-10-18 Thread Pavan Nikhilesh
The eventdev application uses producer lcores to inject packets as events into the event device. This approach is suitable for doing synthetic performance benchmarks. In most real-world scenarios the packets are received by an Ethernet device. The Event Ethernet Rx Adapter library enables packet t

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-18 Thread Bruce Richardson
On Wed, Oct 18, 2017 at 01:20:11PM +0200, Thomas Monjalon wrote: > 18/10/2017 11:51, Bruce Richardson: > > On Wed, Oct 18, 2017 at 10:35:48AM +0100, Bruce Richardson wrote: > > > On Tue, Oct 17, 2017 at 07:17:09PM +0100, Luca Boccassi wrote: > > > > On Tue, 2017-10-17 at 19:11 +0100, Luca Boccassi

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-18 Thread Bruce Richardson
On Wed, Oct 18, 2017 at 11:14:07AM +0100, Luca Boccassi wrote: > On Wed, 2017-10-18 at 10:51 +0100, Bruce Richardson wrote: > > On Wed, Oct 18, 2017 at 10:35:48AM +0100, Bruce Richardson wrote: > > > On Tue, Oct 17, 2017 at 07:17:09PM +0100, Luca Boccassi wrote: > > > > On Tue, 2017-10-17 at 19:11

Re: [dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx mempool device

2017-10-18 Thread santosh
Hi Thomas, On Monday 09 October 2017 02:49 PM, santosh wrote: > On Monday 09 October 2017 02:18 PM, Thomas Monjalon wrote: >> 09/10/2017 07:46, santosh: >>> On Monday 09 October 2017 10:31 AM, santosh wrote: Hi Thomas, On Sunday 08 October 2017 10:13 PM, Thomas Monjalon wrote:

[dpdk-dev] [PATCH] maintainers: updated ipsec_secgw

2017-10-18 Thread Radu Nicolau
Signed-off-by: Radu Nicolau --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2a58378..5fd5acf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -920,6 +920,7 @@ F: examples/helloworld/ F: doc/guides/sample_app_ug/hello_world.rst M: Sergio Gonzale

[dpdk-dev] [PATCH] ipsec_secgw: added cmdline option for jumbo frames and switched to the new offload API.

2017-10-18 Thread Radu Nicolau
Signed-off-by: Radu Nicolau --- doc/guides/sample_app_ug/ipsec_secgw.rst | 6 +- examples/ipsec-secgw/ipsec-secgw.c | 32 +--- 2 files changed, 30 insertions(+), 8 deletions(-) diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst b/doc/guides/sample_app_u

[dpdk-dev] [PATCH] doc: update release note for DPAA PMD support

2017-10-18 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- doc/guides/rel_notes/release_17_11.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst index 8db35f5..966af7c 100644 --- a/doc/guides/rel_notes/release_17_11.rst +++

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-18 Thread Thomas Monjalon
18/10/2017 11:51, Bruce Richardson: > On Wed, Oct 18, 2017 at 10:35:48AM +0100, Bruce Richardson wrote: > > On Tue, Oct 17, 2017 at 07:17:09PM +0100, Luca Boccassi wrote: > > > On Tue, 2017-10-17 at 19:11 +0100, Luca Boccassi wrote: > > > > On Tue, 2017-10-17 at 17:12 +0100, Bruce Richardson wrote:

Re: [dpdk-dev] [PATCH 2/2] power: check if userspace governor is available

2017-10-18 Thread Hunt, David
Hi Radoslaw, On 16/10/2017 2:47 PM, Radoslaw Biernacki wrote: Since for new Intel CPU's kernel use intel_pstate driver, which does not offer userspace governor, it is vise to check typo here, "wise" the userspace governor availability before trying to perform governor switch. The outcome fr

Re: [dpdk-dev] [PATCH 1/2] power: switching to unbuffered stdio for /sys file access

2017-10-18 Thread Hunt, David
Hi Radoslaw, On 16/10/2017 2:47 PM, Radoslaw Biernacki wrote: This patch fixes the bug caused by improper use of buffered stdio file access for switching the CPU frequency and governor. Each write operation when using buffered stdio must be flushed out and the return code from fflush() must be

Re: [dpdk-dev] [PATCH 1/2] power: switching to unbuffered stdio for /sys file access

2017-10-18 Thread Hunt, David
Hi Radoslaw, Thanks for the patch. Some comments below. On 16/10/2017 2:47 PM, Radoslaw Biernacki wrote: This patch fixes the bug caused by improper use of buffered stdio file access for switching the CPU frequency and governor. Each write operation when using buffered stdio must be flushed ou

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-18 Thread Luca Boccassi
On Wed, 2017-10-18 at 10:51 +0100, Bruce Richardson wrote: > On Wed, Oct 18, 2017 at 10:35:48AM +0100, Bruce Richardson wrote: > > On Tue, Oct 17, 2017 at 07:17:09PM +0100, Luca Boccassi wrote: > > > On Tue, 2017-10-17 at 19:11 +0100, Luca Boccassi wrote: > > > > On Tue, 2017-10-17 at 17:12 +0100,

  1   2   >