Re: [dpdk-dev] [PATCH v3 2/5] gso: add TCP/IPv4 GSO support

2017-09-13 Thread Jiayu Hu
Hi Konstantin, On Thu, Sep 14, 2017 at 06:10:37AM +0800, Ananyev, Konstantin wrote: > > Hi Jiayu, > > > > > > > > > > > -Original Message- > > > > From: Ananyev, Konstantin > > > > Sent: Tuesday, September 12, 2017 12:18 PM > > > > To: Hu, Jiayu ; dev@dpdk.org > > > > Cc: Kavanagh, Mark

Re: [dpdk-dev] [PATCH v2] armv8/config: enable igb_uio on arm64 platform

2017-09-13 Thread santosh
On Thursday 14 September 2017 09:23 AM, Jianbo Liu wrote: > The kernel patch was merged to support pci resource mapping. > https://patchwork.kernel.org/patch/9677441/ > > So enable igu_uio in the default arm64 configuration. > > v2: > - keep headline format > > Signed-off-by: Jianbo Liu > ---

Re: [dpdk-dev] [PATCH v4 4/4] net/mlx5: enforce Tx num of segments limitation

2017-09-13 Thread Shahaf Shuler
Hi Yongseok, Wednesday, September 13, 2017 10:52 PM, Yongseok Koh: > > > > +/* Maximum number of DS in WQE. */ > > +#define MLX5_MAX_DS 63 > How about make it consistent with MLX5_MPW_DSEG_MAX by naming > MLX5_DSEG_MAX? > It doesn't have the same meaning. The MLX5_MPW_DSEG_MAX is to limit the

Re: [dpdk-dev] [PATCH v3 2/4] eventdev: Add eth Rx adapter caps callback to SW evdev

2017-09-13 Thread Nipun Gupta
> -Original Message- > From: Rao, Nikhil [mailto:nikhil@intel.com] > Sent: Thursday, September 14, 2017 8:34 > To: Nipun Gupta ; jerin.ja...@caviumnetworks.com; > bruce.richard...@intel.com > Cc: gage.e...@intel.com; dev@dpdk.org; tho...@monjalon.net; > harry.van.haa...@intel.com; Hem

[dpdk-dev] About enqueue_zero_copy?

2017-09-13 Thread ??????
Hi All, I want to know if the community has implemented the "enqueue_zero_copy" ? Thanks all, Best regards

[dpdk-dev] [PATCH v2] armv8/config: enable igb_uio on arm64 platform

2017-09-13 Thread Jianbo Liu
The kernel patch was merged to support pci resource mapping. https://patchwork.kernel.org/patch/9677441/ So enable igu_uio in the default arm64 configuration. v2: - keep headline format Signed-off-by: Jianbo Liu --- config/common_armv8a_linuxapp | 2 -- 1 file changed, 2 deletions(-) diff -

Re: [dpdk-dev] [PATCH] config: enable igb_uio on arm64 platform

2017-09-13 Thread Jerin Jacob
-Original Message- > Date: Thu, 14 Sep 2017 11:00:03 +0800 > From: Jianbo Liu > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, Jianbo Liu > Subject: [PATCH] config: enable igb_uio on arm64 platform > X-Mailer: git-send-email 1.9.1 > > The kernel patch was merged to support pci re

Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file

2017-09-13 Thread Yang, Qiming
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, September 14, 2017 1:06 AM > To: Hu, Xuekun ; Shijith Thotton > ; Yang, Qiming > ; Gregory Etelson > Cc: dev@dpdk.org; Tan, Jianfeng > Subject: Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during > open > and rele

Re: [dpdk-dev] [PATCH v3 2/4] eventdev: Add eth Rx adapter caps callback to SW evdev

2017-09-13 Thread Rao, Nikhil
On 9/13/2017 7:06 PM, Nipun Gupta wrote: -Original Message- From: Nikhil Rao [mailto:nikhil@intel.com] --- lib/librte_eventdev/rte_eventdev_pmd.h | 6 ++ drivers/event/sw/sw_evdev.c| 13 + 2 files changed, 19 insertions(+) diff --git a/lib/librte_e

[dpdk-dev] [PATCH] config: enable igb_uio on arm64 platform

2017-09-13 Thread Jianbo Liu
The kernel patch was merged to support pci resource mapping. https://patchwork.kernel.org/patch/9677441/ So enable igu_uio in the default arm64 configuration. Signed-off-by: Jianbo Liu --- config/common_armv8a_linuxapp | 2 -- 1 file changed, 2 deletions(-) diff --git a/config/common_armv8a_li

[dpdk-dev] [PATCH v2 4/6] xen: remove xen dependency in drivers, ether, mempool

2017-09-13 Thread Jianfeng Tan
Signed-off-by: Jianfeng Tan Acked-by: Bruce Richardson --- drivers/crypto/qat/qat_qp.c | 7 +-- drivers/net/i40e/i40e_rxtx.c | 8 ++-- lib/librte_ether/rte_ethdev.c| 7 +-- lib/librte_mempool/rte_mempool.c | 8 ++-- 4 files changed, 6 insertions(+), 24 deletions(-)

[dpdk-dev] [PATCH v2 3/6] xen: remove xen dependency in app, examples, test

2017-09-13 Thread Jianfeng Tan
Signed-off-by: Jianfeng Tan Acked-by: Bruce Richardson --- examples/ip_pipeline/app.h | 4 -- examples/ip_pipeline/config_parse.c | 19 - examples/ip_pipeline/init.c | 5 --- examples/kni/main.c | 3 -- test/test/process.h | 10 - t

[dpdk-dev] [PATCH v2 5/6] eal: remove API rte_mem_phy2mch

2017-09-13 Thread Jianfeng Tan
Previously, to get MFN address in dom0, this API is a wrapper to obtain the "physical address". As we will removed xen dom0 support, this API is not necessary. Signed-off-by: Jianfeng Tan Acked-by: Bruce Richardson --- doc/guides/rel_notes/release_17_11.rst | 2 ++ drivers/net/e1000/em_rx

[dpdk-dev] [PATCH v2 0/6] remove xen dom0 support in DPDK

2017-09-13 Thread Jianfeng Tan
v2: - Address Bruce's comment on testpmd's memory init for xenvirt in patch 2. - Update rte_eal_version.map in bsd and eal. - Switch patch 5 and patch 6 so that we bump library version just once. Following the calls on the mailing list: http://dpdk.org/ml/archives/dev/2017-June/068151.ht

[dpdk-dev] [PATCH v2 2/6] net/xenvirt: remove

2017-09-13 Thread Jianfeng Tan
Signed-off-by: Jianfeng Tan Acked-by: Bruce Richardson --- MAINTAINERS | 2 - app/test-pmd/Makefile | 4 - app/test-pmd/testpmd.c | 51 +- config/common_base | 5 - config/d

[dpdk-dev] [PATCH v2 1/6] examples/vhost_xen: remove

2017-09-13 Thread Jianfeng Tan
Signed-off-by: Jianfeng Tan Acked-by: Bruce Richardson --- MAINTAINERS |1 - examples/Makefile |1 - examples/vhost_xen/Makefile | 52 -- examples/vhost_xen/main.c | 1522 --- examples/vhost_xen

Re: [dpdk-dev] git trees organization

2017-09-13 Thread Stephen Hemminger
On Sep 13, 2017 7:54 AM, "Adrien Mazarguil" wrote: On Wed, Sep 13, 2017 at 02:21:00PM +0100, Ferruh Yigit wrote: > On 9/13/2017 1:25 PM, Adrien Mazarguil wrote: > > On Wed, Sep 13, 2017 at 12:38:37PM +0100, Ferruh Yigit wrote: > >> On 9/13/2017 8:58 AM, Adrien Mazarguil wrote: > >>> Hi, > >>> > >

Re: [dpdk-dev] [PATCH v3] net/i40e: fix memory leak if VF init fails

2017-09-13 Thread Xing, Beilei
> -Original Message- > From: Wu, Jingjing > Sent: Wednesday, September 13, 2017 7:54 AM > To: Xing, Beilei > Cc: dev@dpdk.org; Wu, Jingjing ; sta...@dpdk.org > Subject: [PATCH v3] net/i40e: fix memory leak if VF init fails > > Cc: sta...@dpdk.org > Fixes: 4861cde46116 ("i40e: new poll m

Re: [dpdk-dev] [PATCH v9 0/5] Support of NIC reset and keep same port id

2017-09-13 Thread Dai, Wei
Hi, Thomas Thanks for your great support ! > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, September 14, 2017 5:02 AM > To: Dai, Wei > Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, > Konstantin ; Wu, Jingjing > ; Xing, Beilei > Subject: Re: [dpdk-d

Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file

2017-09-13 Thread Yang, Qiming
> -Original Message- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Wednesday, September 13, 2017 6:49 PM > To: Yang, Qiming ; Gregory Etelson > > Cc: dev@dpdk.org; Tan, Jianfeng ; Yigit, Ferruh > > Subject: Re: vf init issue with patch igb_uio: issue FLR duri

Re: [dpdk-dev] [PATCH v3 2/5] gso: add TCP/IPv4 GSO support

2017-09-13 Thread Hu, Jiayu
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, September 13, 2017 11:13 PM > To: Kavanagh, Mark B ; Hu, Jiayu > > Cc: dev@dpdk.org; Tan, Jianfeng > Subject: RE: [PATCH v3 2/5] gso: add TCP/IPv4 GSO support > > Hi Mark, > > > -Original Message

[dpdk-dev] [PATCH] net/i40e: fix incorrect var assignment

2017-09-13 Thread Jingjing Wu
rx/tx_queue_setup functions are shared between PF and VF drivers. So the var 'pf' should not be assigned at the beginning. This patch fixes the issue, and also corrects the return err code. Cc: sta...@dpdk.org Fixes: b6583ee40265 ("i40e: full VMDQ pools support") Signed-off-by: Jingjing Wu ---

Re: [dpdk-dev] [PATCH v3 2/5] gso: add TCP/IPv4 GSO support

2017-09-13 Thread Ananyev, Konstantin
Hi Jiayu, > > > > > > > -Original Message- > > > From: Ananyev, Konstantin > > > Sent: Tuesday, September 12, 2017 12:18 PM > > > To: Hu, Jiayu ; dev@dpdk.org > > > Cc: Kavanagh, Mark B ; Tan, Jianfeng > > > > > > Subject: RE: [PATCH v3 2/5] gso: add TCP/IPv4 GSO support > > > > > > > r

[dpdk-dev] [PATCH v3 3/3] doc: update timer lib docs

2017-09-13 Thread Erik Gabriel Carrillo
This change updates the timer library documentation to reflect a change to the organization of the skiplists in the implementation. Signed-off-by: Erik Gabriel Carrillo --- v3 * Updated implementation details section of timer_lib.rst to reflect the addition of the option to use multiple pendin

[dpdk-dev] [PATCH v3 0/3] timer library enhancement

2017-09-13 Thread Erik Gabriel Carrillo
In the current implementation of the DPDK timer library, timers can be created and set to be handled by a target lcore by adding it to a skiplist that corresponds to that lcore. However, if an application enables multiple lcores, and each of these lcores repeatedly attempts to install timers on th

[dpdk-dev] [PATCH v3 2/3] timer: handle timers installed from non-EAL threads

2017-09-13 Thread Erik Gabriel Carrillo
This commit adds support for timers being created from non-EAL threads; it maps timers from all such threads to lcore id RTE_MAX_LCORE, and puts them all in a corresponding skiplist. Signed-off-by: Erik Gabriel Carrillo --- V3: * Rebased patch on reworked parent commit v2: * Address checkpatch

[dpdk-dev] [PATCH v3 1/3] timer: add multiple pending lists option for each lcore

2017-09-13 Thread Erik Gabriel Carrillo
This commit adds support for enabling multiple pending timer lists in each lcore's priv_timer struct with a new function; a single list is still used by default. In the case that multiple lcores repeatedly install timers on the same target lcore, this option reduces lock contention for the target l

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-13 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, September 13, 2017 2:21 PM > To: Ananyev, Konstantin ; > step...@networkplumber.org > Cc: dev@dpdk.org; Shahaf Shuler > Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new

Re: [dpdk-dev] [PATCH v9 0/5] Support of NIC reset and keep same port id

2017-09-13 Thread Thomas Monjalon
> Wei Dai (5): > ethdev: add support of NIC reset > net/ixgbe: add support of reset > net/i40e: add support of reset > app/testpmd: enhance command to test NIC reset > doc: add description of the NIC reset API Sorry for being so late to get back to it. Applied, thanks for the improvemen

[dpdk-dev] [PATCH] net/nfp: write PF MAC to config BAR

2017-09-13 Thread Alejandro Lucero
VFs rely on config BAR for getting the MAC address, although a random one is created a valid address is not found. A PF port has a fixed MAC which is currently acquired using the NSPU interface. Some NFP firmwares require the MAC being writing back to the config BAR for doing proper MAC filtering.

Re: [dpdk-dev] [PATCH v9 2/5] net/ixgbe: add support of reset

2017-09-13 Thread Thomas Monjalon
23/07/2017 11:15, Wei Dai: > +/* > + * Reest PF device. > + */ Small typo here. I will fix it.

Re: [dpdk-dev] [PATCH v9 1/5] ethdev: add support of NIC reset

2017-09-13 Thread Thomas Monjalon
23/07/2017 11:15, Wei Dai: > --- a/lib/librte_ether/rte_ether_version.map > +++ b/lib/librte_ether/rte_ether_version.map This file is now lib/librte_ether/rte_ethdev_version.map > @@ -155,6 +155,7 @@ DPDK_17.08 { > rte_eth_dev_adjust_nb_rx_tx_desc; > rte_flow_copy; > rte_f

Re: [dpdk-dev] [PATCH v4 4/4] net/mlx5: enforce Tx num of segments limitation

2017-09-13 Thread Yongseok Koh
On Wed, Sep 13, 2017 at 01:50:39PM +0300, Shahaf Shuler wrote: > Mellanox NICs has a limitation on the number of mbuf segments a multi > segment mbuf can have. The max number depends on the Tx offloads requested. > > The current code not enforce such limitation, which might cause > malformed work

Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file

2017-09-13 Thread Patil, Harish
-Original Message- From: dev on behalf of Ferruh Yigit Date: Wednesday, September 13, 2017 at 10:06 AM To: "Hu, Xuekun" , "Thotton, Shijith" , "Yang, Qiming" , Gregory Etelson Cc: "dev@dpdk.org" , "Tan, Jianfeng" Subject: Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR duri

Re: [dpdk-dev] [PATCH v4 3/4] net/mlx5: fix Tx stats error counter logic

2017-09-13 Thread Yongseok Koh
> On Sep 13, 2017, at 3:50 AM, Shahaf Shuler wrote: > > Tx error counter lacks the logic of incrementation, making it useless for > applications. > > Fixes: 87011737b715 ("mlx5: add software counters") > Cc: sta...@dpdk.org > Cc: adrien.mazarg...@6wind.com > > Signed-off-by: Shahaf Shuler > -

Re: [dpdk-dev] [PATCH v4 2/4] net/mlx5: fix Tx stats error counter definition

2017-09-13 Thread Yongseok Koh
> On Sep 13, 2017, at 3:50 AM, Shahaf Shuler wrote: > > The current Tx error counter counts, according to its description, > the total number of packets not sent when TX ring full. It is reported > to application as part of oerrors field. > > The drop due to full ring is not the statistic that

[dpdk-dev] [PATCH 4/4] maintainers: add maintainer for AMD AXGBE PMD

2017-09-13 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- MAINTAINERS | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index a0cd75e..0110d54 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -308,6 +308,12 @@ F: drivers/net/ena/ F: doc/guides/nics/ena.rst F: doc/guides/nics/

[dpdk-dev] [PATCH 3/4] doc: Add documents for AMD XGBE Ethernet

2017-09-13 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- doc/guides/nics/axgbe.rst | 214 + doc/guides/nics/features/axgbe.ini | 18 doc/guides/nics/index.rst | 1 + 3 files changed, 233 insertions(+) create mode 100644 doc/guides/nics/axgbe.rst create mode 10

[dpdk-dev] [PATCH 1/4] Add AMD XGBE Ethernet config support in DPDK

2017-09-13 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- config/common_base | 6 ++ mk/rte.app.mk | 1 + 2 files changed, 7 insertions(+) diff --git a/config/common_base b/config/common_base index 5e97a08..fab46b5 100644 --- a/config/common_base +++ b/config/common_base @@ -405,6 +405,12 @@ CONFIG_RTE_LIBRTE_AVP_

Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file

2017-09-13 Thread Ferruh Yigit
On 9/13/2017 3:25 PM, Hu, Xuekun wrote: > I met the same issue too, only with i40e 2.1.26 PF kernel driver. > > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Wednesday, September 13, 2017 7:04 PM > To: Shijith Thotton ; Yang, Qiming > ; Gr

Re: [dpdk-dev] [PATCH v2 16/17] build: add option to version libs using DPDK version

2017-09-13 Thread Luca Boccassi
On Wed, 2017-09-13 at 14:11 +0100, Bruce Richardson wrote: > On Wed, Sep 13, 2017 at 12:32:24PM +0100, Luca Boccassi wrote: > > On Tue, 2017-09-12 at 11:38 +0100, Bruce Richardson wrote: > > > Normally, each library has it's own version number based on the > > > ABI. > > > Add an option to have all

Re: [dpdk-dev] [PATCH v3 00/17] build DPDK libs and some drivers with meson/ninja

2017-09-13 Thread Luca Boccassi
On Wed, 2017-09-13 at 15:12 +0100, Bruce Richardson wrote: > V3 changes: > * used two-digit version numbers when globally versioning > libs+drivers > * removed symlinks with single-digit version numbers in same case > * moved driver install location from $prefix/dpdk to > $prefix/share/dpdk > > V2

Re: [dpdk-dev] [PATCH] Fix bash path in shebangs

2017-09-13 Thread Thomas Monjalon
13/09/2017 17:55, alan somers: > On Wed, Sep 13, 2017 at 9:39 AM, Thomas Monjalon wrote: > > 13/09/2017 16:35, alan somers: > >> On Wed, Sep 13, 2017 at 3:37 AM, Thomas Monjalon > >> wrote: > >> > 27/07/2017 22:12, asom...@gmail.com: > >> >> From: Alan Somers > >> >> > >> >> "/bin/bash" is a Li

Re: [dpdk-dev] Why cuckoo based hashing in DPDK library?

2017-09-13 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andriy Berestovskyy > Sent: Friday, September 1, 2017 5:15 PM > To: Evgeny Agronsky > Cc: DPDK > Subject: Re: [dpdk-dev] Why cuckoo based hashing in DPDK library? > > Hey Evgeny, > Please see inline. > > On Th

Re: [dpdk-dev] [PATCH] Fix bash path in shebangs

2017-09-13 Thread alan somers
On Wed, Sep 13, 2017 at 9:39 AM, Thomas Monjalon wrote: > 13/09/2017 16:35, alan somers: >> On Wed, Sep 13, 2017 at 3:37 AM, Thomas Monjalon wrote: >> > 27/07/2017 22:12, asom...@gmail.com: >> >> From: Alan Somers >> >> >> >> "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. >> > >> >

Re: [dpdk-dev] [PATCH] Fix bash path in shebangs

2017-09-13 Thread Thomas Monjalon
13/09/2017 16:35, alan somers: > On Wed, Sep 13, 2017 at 3:37 AM, Thomas Monjalon wrote: > > 27/07/2017 22:12, asom...@gmail.com: > >> From: Alan Somers > >> > >> "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. > > > > Why is it an issue? > > > > Can you run dpdk-setup.sh on a non-Li

[dpdk-dev] [PATCH v2 7/7] app/crypto-perf: use single mempool

2017-09-13 Thread Pablo de Lara
In order to improve memory utilization, a single mempool is created, containing the crypto operation and mbufs (one if operation is in-place, two if out-of-place). This way, a single object is allocated and freed per operation, reducing the amount of memory in cache, which improves scalability. Si

[dpdk-dev] [PATCH v2 5/7] app/crypto-perf: do not populate the mbufs at init

2017-09-13 Thread Pablo de Lara
For throughput and latency tests, it is not required to populate the mbufs with any test vector. For verify test, there is already a function that rewrites the mbufs every time they are going to be used with crypto operations. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_test_late

[dpdk-dev] [PATCH v2 6/7] app/crypto-perf: support multiple queue pairs

2017-09-13 Thread Pablo de Lara
Add parameter "qps" in crypto performance app, to create multiple queue pairs per device. This new parameter is useful to have multiple logical cores using a single crypto device, without needing to initialize a crypto device per core. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf

[dpdk-dev] [PATCH v2 4/7] app/crypto-perf: overwrite mbuf when verifying

2017-09-13 Thread Pablo de Lara
When running the verify test, mbufs in the pool were populated with the test vector loaded from a file. To avoid limiting the number of operations to the pool size, mbufs will be rewritten with the test vector, before linking them to the crypto operations. Signed-off-by: Pablo de Lara --- app/te

[dpdk-dev] [PATCH v2 1/7] app/crypto-perf: set AAD after the crypto operation

2017-09-13 Thread Pablo de Lara
Instead of prepending the AAD (Additional Authenticated Data) in the mbuf, it is easier to set after the crypto operation, as it is a read-only value, like the IV, and then it is not restricted to the size of the mbuf headroom. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_ops.c

[dpdk-dev] [PATCH v2 2/7] app/crypto-perf: parse AEAD data from vectors

2017-09-13 Thread Pablo de Lara
Since DPDK 17.08, there is specific parameters for AEAD algorithm, like AES-GCM. When verifying crypto operations with test vectors, the parser was not reading AEAD data (such as IV or key). Fixes: 8a5b494a7f99 ("app/test-crypto-perf: add AEAD parameters") Cc: sta...@dpdk.org Signed-off-by: Pablo

[dpdk-dev] [PATCH v2 3/7] app/crypto-perf: parse segment size

2017-09-13 Thread Pablo de Lara
Instead of parsing number of segments, from the command line, parse segment size, as it is a more usual case to have the segment size fixed and then different packet sizes will require different number of segments. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_ops.c | 2

[dpdk-dev] [PATCH v2 0/7] Crypto-perf app improvements

2017-09-13 Thread Pablo de Lara
This patchset includes some improvements in the Crypto performance application, including app fixes and new parameter additions. The last patch, in particular, introduces performance improvements. Currently, crypto operations are allocated in a mempool and mbufs in a different one. Then mbufs are

[dpdk-dev] [PATCH v2 5/7] app/crypto-perf: do not populate the mbufs at init

2017-09-13 Thread Pablo de Lara
For throughput and latency tests, it is not required to populate the mbufs with any test vector. For verify test, there is already a function that rewrites the mbufs every time they are going to be used with crypto operations. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_test_late

[dpdk-dev] [PATCH v2 4/7] app/crypto-perf: overwrite mbuf when verifying

2017-09-13 Thread Pablo de Lara
When running the verify test, mbufs in the pool were populated with the test vector loaded from a file. To avoid limiting the number of operations to the pool size, mbufs will be rewritten with the test vector, before linking them to the crypto operations. Signed-off-by: Pablo de Lara --- app/te

[dpdk-dev] [PATCH v2 3/7] app/crypto-perf: parse segment size

2017-09-13 Thread Pablo de Lara
Instead of parsing number of segments, from the command line, parse segment size, as it is a more usual case to have the segment size fixed and then different packet sizes will require different number of segments. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_ops.c | 2

[dpdk-dev] [PATCH v2 1/7] app/crypto-perf: set AAD after the crypto operation

2017-09-13 Thread Pablo de Lara
Instead of prepending the AAD (Additional Authenticated Data) in the mbuf, it is easier to set after the crypto operation, as it is a read-only value, like the IV, and then it is not restricted to the size of the mbuf headroom. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_ops.c

[dpdk-dev] [PATCH v2 2/7] app/crypto-perf: parse AEAD data from vectors

2017-09-13 Thread Pablo de Lara
Since DPDK 17.08, there is specific parameters for AEAD algorithm, like AES-GCM. When verifying crypto operations with test vectors, the parser was not reading AEAD data (such as IV or key). Fixes: 8a5b494a7f99 ("app/test-crypto-perf: add AEAD parameters") Cc: sta...@dpdk.org Signed-off-by: Pablo

[dpdk-dev] [PATCH v2 0/7] Crypto-perf app improvements

2017-09-13 Thread Pablo de Lara
This patchset includes some improvements in the Crypto performance application, including app fixes and new parameter additions. The last patch, in particular, introduces performance improvements. Currently, crypto operations are allocated in a mempool and mbufs in a different one. Then mbufs are

Re: [dpdk-dev] [PATCH v3 2/5] gso: add TCP/IPv4 GSO support

2017-09-13 Thread Ananyev, Konstantin
Hi Mark, > -Original Message- > From: Kavanagh, Mark B > Sent: Wednesday, September 13, 2017 3:52 PM > To: Ananyev, Konstantin ; Hu, Jiayu > > Cc: dev@dpdk.org; Tan, Jianfeng > Subject: RE: [PATCH v3 2/5] gso: add TCP/IPv4 GSO support > > >From: Ananyev, Konstantin > >Sent: Wednesday,

[dpdk-dev] [PATCH v3 17/17] doc: add documentation on how to add new components to DPDK

2017-09-13 Thread Bruce Richardson
Add to the contributors guide details on how to add libraries and drivers and integrate them with the DPDK build system(s). Signed-off-by: Bruce Richardson --- doc/guides/contributing/coding_style.rst | 214 +++ 1 file changed, 214 insertions(+) diff --git a/doc/guid

[dpdk-dev] [PATCH v3 14/17] app/test-pmd: add test-pmd to meson build

2017-09-13 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- app/meson.build | 32 + app/test-pmd/meson.build | 74 meson.build | 3 +- 3 files changed, 108 insertions(+), 1 deletion(-) create mode 100644 app/meson.build create

[dpdk-dev] [PATCH v3 16/17] build: add option to version libs using DPDK version

2017-09-13 Thread Bruce Richardson
Normally, each library has it's own version number based on the ABI. Add an option to have all libs just use the DPDK version number as the .so version. Signed-off-by: Bruce Richardson --- drivers/meson.build | 13 - lib/librte_eal/bsdapp/eal/meson.build | 12 ++

[dpdk-dev] [PATCH v3 13/17] drivers/net: add drivers for Intel NICs to meson build

2017-09-13 Thread Bruce Richardson
Add the e1000, fm10k, i40e and ixgbe drivers to the meson & ninja build. Signed-off-by: Bruce Richardson --- config/rte_config.h| 12 +++ drivers/net/e1000/base/meson.build | 65 ++ drivers/net/e1000/meson.build | 44 ++

[dpdk-dev] [PATCH v3 15/17] usertools: add usertools installation to meson build

2017-09-13 Thread Bruce Richardson
Have the "usertools" scripts installed when doing a DPDK install using ninja. They will be copies to $prefix/bin, generally /usr/local/bin, alongside testpmd. Signed-off-by: Bruce Richardson --- meson.build | 3 ++- usertools/meson.build | 32 2 files

[dpdk-dev] [PATCH v3 11/17] drivers/net: add net driver support to meson build

2017-09-13 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- drivers/meson.build | 2 +- drivers/net/meson.build | 35 +++ 2 files changed, 36 insertions(+), 1 deletion(-) create mode 100644 drivers/net/meson.build diff --git a/drivers/meson.build b/drivers/meson.build index be87918

[dpdk-dev] [PATCH v3 12/17] drivers/net: add set of vdev PMDs to build

2017-09-13 Thread Bruce Richardson
Add the af_packet, null, pcap and ring PMDs to the meson build. Signed-off-by: Bruce Richardson --- config/rte_config.h | 4 drivers/net/af_packet/meson.build | 35 + drivers/net/meson.build | 2 +- drivers/net/null/meson.build

[dpdk-dev] [PATCH v3 09/17] crypto/openssl: add driver to meson build

2017-09-13 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- drivers/crypto/meson.build | 2 +- drivers/crypto/openssl/meson.build | 38 ++ 2 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 drivers/crypto/openssl/meson.build diff --git a/drivers/crypto/meso

[dpdk-dev] [PATCH v3 10/17] crypto/qat: add driver to meson build

2017-09-13 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- config/rte_config.h| 8 drivers/crypto/meson.build | 2 +- drivers/crypto/qat/meson.build | 41 + 3 files changed, 50 insertions(+), 1 deletion(-) create mode 100644 drivers/crypto/qat/meson.bu

[dpdk-dev] [PATCH v3 07/17] drivers/mempool: add SW mempool drivers to meson build

2017-09-13 Thread Bruce Richardson
With build infrastructure in place, add in mempool drivers to the build. Signed-off-by: Bruce Richardson --- drivers/mempool/meson.build | 35 +++ drivers/mempool/ring/meson.build | 32 drivers/mempool/stack/meson.build | 32

[dpdk-dev] [PATCH v3 08/17] drivers/crypto: add crypto drv class and null PMD to meson

2017-09-13 Thread Bruce Richardson
Add in a crypto driver class, and implement compiling the null crypto instance. Signed-off-by: Bruce Richardson --- drivers/crypto/meson.build | 35 +++ drivers/crypto/null/meson.build | 33 + drivers/meson.build |

[dpdk-dev] [PATCH v3 06/17] build: add infrastructure for building PMDs

2017-09-13 Thread Bruce Richardson
Add in the top-level drivers meson.build file to start adding in building of PMDs. Since all PMDs are built in pretty much the same way, the logic for building each PMD, including extracting the pmdinfo, is included in the top level build file. This means that each individual driver class only need

[dpdk-dev] [PATCH v3 05/17] build: add buildtools to meson build

2017-09-13 Thread Bruce Richardson
Add the buildtools folder, and more specifically the pmdinfogen binary to the meson and ninja build. This will be needed for building the PMDs in the driver folder later, as the pmd info output from the tool needs to be included in those libs. Signed-off-by: Bruce Richardson --- buildtools/gen-p

[dpdk-dev] [PATCH v3 04/17] build: add DPDK libraries to build

2017-09-13 Thread Bruce Richardson
Add non-EAL libraries to DPDK build. The compat lib is a special case, along with the previously-added EAL, but all other libs can be build using the same set of commands, where the individual meson.build files only need to specify their dependencies, source files, header files and ABI versions. S

[dpdk-dev] [PATCH v3 02/17] eal: add eal library to meson build

2017-09-13 Thread Bruce Richardson
Support building the EAL with meson and ninja. This involves a number of different meson.build files for iterating through all the different subdirectories in the EAL. The library itself will be compiled on build but the header files are only copied from their initial location once "ninja install"

[dpdk-dev] [PATCH v3 03/17] igb_uio: add igb_uio kmod to meson build

2017-09-13 Thread Bruce Richardson
Support building igb_uio using meson and ninja. For this, we still use the kernel's kbuild system, by calling out to make, since it's safer and easier than trying to reproduce that in meson. A list of suitable file dependencies is given so that we have a reasonable chance of a rebuild when necessar

[dpdk-dev] [PATCH v3 01/17] build: add initial infrastructure for meson & ninja builds

2017-09-13 Thread Bruce Richardson
To build with meson and ninja, we need some initial infrastructure in place. The build files for meson always need to be called "meson.build", and options get placed in meson_options.txt This commit adds a top-level meson.build file, which sets up the global variables for tracking drivers, librari

[dpdk-dev] [PATCH v3 00/17] build DPDK libs and some drivers with meson/ninja

2017-09-13 Thread Bruce Richardson
V3 changes: * used two-digit version numbers when globally versioning libs+drivers * removed symlinks with single-digit version numbers in same case * moved driver install location from $prefix/dpdk to $prefix/share/dpdk V2 changes: * fixed copyright notices, updated 2016 to 2017 * removed depende

Re: [dpdk-dev] [PATCH v3] devtools: rework abi checker script

2017-09-13 Thread Neil Horman
On Mon, Sep 11, 2017 at 10:46:35AM +0200, Olivier Matz wrote: > The initial version of the script had some limitations: > - cannot work on a non-clean workspace > - environment variables are not documented > - no compilation log in case of failure > - return success even it abi is incompatible > >

Re: [dpdk-dev] git trees organization

2017-09-13 Thread Adrien Mazarguil
On Wed, Sep 13, 2017 at 02:21:00PM +0100, Ferruh Yigit wrote: > On 9/13/2017 1:25 PM, Adrien Mazarguil wrote: > > On Wed, Sep 13, 2017 at 12:38:37PM +0100, Ferruh Yigit wrote: > >> On 9/13/2017 8:58 AM, Adrien Mazarguil wrote: > >>> Hi, > >>> > >>> On Tue, Sep 12, 2017 at 09:32:07AM +0100, Bruce Ri

Re: [dpdk-dev] [PATCH v3 2/5] gso: add TCP/IPv4 GSO support

2017-09-13 Thread Kavanagh, Mark B
>From: Ananyev, Konstantin >Sent: Wednesday, September 13, 2017 10:38 AM >To: Hu, Jiayu >Cc: dev@dpdk.org; Kavanagh, Mark B ; Tan, Jianfeng > >Subject: RE: [PATCH v3 2/5] gso: add TCP/IPv4 GSO support > > > >> > > + >> > > +int >> > > +gso_tcp4_segment(struct rte_mbuf *pkt, >> > > +

Re: [dpdk-dev] [PATCH] Fix bash path in shebangs

2017-09-13 Thread alan somers
On Wed, Sep 13, 2017 at 3:37 AM, Thomas Monjalon wrote: > 27/07/2017 22:12, asom...@gmail.com: >> From: Alan Somers >> >> "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. > > Why is it an issue? > > Can you run dpdk-setup.sh on a non-Linux system? > Nope, because even dpdk-setup.sh a

Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file

2017-09-13 Thread Hu, Xuekun
I met the same issue too, only with i40e 2.1.26 PF kernel driver. -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit Sent: Wednesday, September 13, 2017 7:04 PM To: Shijith Thotton ; Yang, Qiming ; Gregory Etelson Cc: dev@dpdk.org; Tan, Jianfeng Subjec

Re: [dpdk-dev] [PATCH v3 2/4] eventdev: Add eth Rx adapter caps callback to SW evdev

2017-09-13 Thread Nipun Gupta
> -Original Message- > From: Nikhil Rao [mailto:nikhil@intel.com] > Sent: Tuesday, September 12, 2017 17:59 > To: jerin.ja...@caviumnetworks.com; bruce.richard...@intel.com > Cc: gage.e...@intel.com; dev@dpdk.org; tho...@monjalon.net; > harry.van.haa...@intel.com; Hemant Agrawal ; > N

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: increase port_id range

2017-09-13 Thread Ferruh Yigit
On 9/13/2017 1:18 PM, Thomas Monjalon wrote: > 13/09/2017 13:56, Ferruh Yigit: >> On 9/13/2017 3:26 AM, Yang, Zhiyong wrote: >>> From: Yigit, Ferruh On 9/9/2017 3:47 PM, Zhiyong Yang wrote: > Extend port_id definition from uint8_t to uint16_t in lib and drivers > data structures, speci

Re: [dpdk-dev] git trees organization

2017-09-13 Thread Ferruh Yigit
On 9/13/2017 1:25 PM, Adrien Mazarguil wrote: > On Wed, Sep 13, 2017 at 12:38:37PM +0100, Ferruh Yigit wrote: >> On 9/13/2017 8:58 AM, Adrien Mazarguil wrote: >>> Hi, >>> >>> On Tue, Sep 12, 2017 at 09:32:07AM +0100, Bruce Richardson wrote: On Tue, Sep 12, 2017 at 12:03:30AM +0200, Thomas Monj

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-13 Thread Thomas Monjalon
13/09/2017 14:56, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 13/09/2017 13:16, Shahaf Shuler: > > > Wednesday, September 13, 2017 12:28 PM, Thomas Monjalon: > > > > I still think we must streamline ethdev API instead of complexifying. > > > > We should drop the bi

Re: [dpdk-dev] [PATCH v2 16/17] build: add option to version libs using DPDK version

2017-09-13 Thread Bruce Richardson
On Wed, Sep 13, 2017 at 12:32:24PM +0100, Luca Boccassi wrote: > On Tue, 2017-09-12 at 11:38 +0100, Bruce Richardson wrote: > > Normally, each library has it's own version number based on the ABI. > > Add an option to have all libs just use the DPDK version number as > > the > > .so version. > > >

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-13 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, September 13, 2017 1:42 PM > To: dev@dpdk.org; Shahaf Shuler > Cc: Ananyev, Konstantin ; > step...@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-13 Thread Shahaf Shuler
Wednesday, September 13, 2017 3:42 PM, Thomas MonjalonL > 13/09/2017 13:16, Shahaf Shuler: > > Wednesday, September 13, 2017 12:28 PM, Thomas Monjalon: > > > I still think we must streamline ethdev API instead of complexifying. > > > We should drop the big "configure everything" and configure offlo

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: introduce Tx queue offloads API

2017-09-13 Thread Shahaf Shuler
Wednesday, September 13, 2017 11:41 AM, Andrew Rybchenko: >>+Mbuf fast free >>+-- >>+ >>+Supports optimization for fast release of mbufs following successful Tx. >>+Requires all mbufs to come from the same mempool and has refcnt = 1. >It is ambiguous here in the case of fast free

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-13 Thread Shahaf Shuler
Wednesday, September 13, 2017 11:13 AM, Andrew Rybchenko: On 09/13/2017 09:37 AM, Shahaf Shuler wrote: >I think it would be useful to have the description in the documentation. >It is really important topic on how per-port and per-queue offloads coexist >and rules should be 100% clear for PMD main

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-13 Thread Thomas Monjalon
13/09/2017 13:16, Shahaf Shuler: > Wednesday, September 13, 2017 12:28 PM, Thomas Monjalon: > > I still think we must streamline ethdev API instead of complexifying. > > We should drop the big "configure everything" and configure offloads one by > > one, and per queue (the finer grain). > > The is

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-13 Thread Andrew Rybchenko
On 09/13/2017 03:33 PM, Shahaf Shuler wrote: Wednesday, September 13, 2017 12:13 PM, Andrew Rybchenko: >>return -EBUSY; >>  } >>  +    /* >>+ * Convert between the offloads API to enable PMDs to support >>+ * only one of them.

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-13 Thread Shahaf Shuler
Wednesday, September 13, 2017 12:13 PM, Andrew Rybchenko: >>return -EBUSY; >> } >> +/* >>+ * Convert between the offloads API to enable PMDs to support >>+ * only one of them. >>+ */ >>+if ((dev_conf->rxmode.ignore_offload_bitfield == 0)) { >>+rte_eth_convert_rx_of

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-13 Thread Aaron Conole
Thomas Monjalon writes: > 12/09/2017 22:29, Aaron Conole: >> Thomas Monjalon writes: >> >> > 12/09/2017 16:50, Aaron Conole: >> >> Eelco Chaudron writes: >> >> >> >> > Call the mlockall() function, to attempt to lock all of its process >> >> > memory into physical RAM, and preventing the kern

Re: [dpdk-dev] git trees organization

2017-09-13 Thread Adrien Mazarguil
On Wed, Sep 13, 2017 at 12:38:37PM +0100, Ferruh Yigit wrote: > On 9/13/2017 8:58 AM, Adrien Mazarguil wrote: > > Hi, > > > > On Tue, Sep 12, 2017 at 09:32:07AM +0100, Bruce Richardson wrote: > >> On Tue, Sep 12, 2017 at 12:03:30AM +0200, Thomas Monjalon wrote: > >>> Hi all, > >>> > >>> As you kno

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: increase port_id range

2017-09-13 Thread Thomas Monjalon
13/09/2017 13:56, Ferruh Yigit: > On 9/13/2017 3:26 AM, Yang, Zhiyong wrote: > > From: Yigit, Ferruh > >> On 9/9/2017 3:47 PM, Zhiyong Yang wrote: > >>> Extend port_id definition from uint8_t to uint16_t in lib and drivers > >>> data structures, specifically rte_eth_dev_data. > >>> Modify the APIs,

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: increase port_id range

2017-09-13 Thread Yang, Zhiyong
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, September 13, 2017 7:57 PM > To: Yang, Zhiyong ; dev@dpdk.org; Doherty, Declan > ; Lu, Wenzhuo > Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Hunt, David > ; Richardson, Bruce ; > Ananyev, Konstantin > Subject:

  1   2   >