> -----Original Message----- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Wednesday, September 13, 2017 6:49 PM > To: Yang, Qiming <qiming.y...@intel.com>; Gregory Etelson > <greg...@weka.io> > Cc: dev@dpdk.org; Tan, Jianfeng <jianfeng....@intel.com>; Yigit, Ferruh > <ferruh.yi...@intel.com> > Subject: Re: vf init issue with patch igb_uio: issue FLR during open and > release of > device file > > On Wed, Sep 13, 2017 at 07:51:30AM +0000, Yang, Qiming wrote: > > Hi, Shijith > > > > > > > > VF init error will happen after apply your patch, error log as below. If > > revert your commit, all things work well. And this issue is not only > > occur > > in i40 VF but also ixgbe. > > > > Could you help to check it soon? > > > > > > > > [root@localhost app]# ./testpmd -c 7 -n 4 -- -i > > > > EAL: Detected 10 lcore(s) > > > > EAL: No free hugepages reported in hugepages-1048576kB > > > > EAL: Probing VFIO support... > > > > EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using > > unreliable clock cycles ! > > > > EAL: PCI device 0000:00:03.0 on NUMA socket -1 > > > > EAL: Invalid NUMA socket, default to 0 > > > > EAL: probe driver: 8086:154c net_i40e_vf > > > > i40evf_init_vf(): init_adminq failed: -53 > > > > i40evf_dev_init(): Init vf failed > > > > EAL: Requested device 0000:00:03.0 cannot be used > > > > > > > > commit b58eedfc7dd57eef6d12e2c654a52c834f36084a > > Author: Shijith Thotton <shijith.thot...@caviumnetworks.com> > > Date: Fri Jul 7 16:43:51 2017 +0530 > > > > igb_uio: issue FLR during open and release of device file > > > > Set UIO info device file operations open and release. Call pci reset > > function inside open and release to clear device state at start and end. > > Copied this behaviour from vfio_pci kernel module code. With this patch, > > it is not mandatory to issue FLR by PMD's during init and close. > > > > Bus master enable and disable are added in open and release respectively > > to take care of device DMA. > > > > Signed-off-by: Shijith Thotton <shijith.thot...@caviumnetworks.com> > > Reviewed-by: Jianfeng Tan <jianfeng....@intel.com> > > Acked-by: Ferruh Yigit <ferruh.yi...@intel.com> > > Acked-by: Gregory Etelson <greg...@weka.io> > > > > > > > > Best Regard, > > > > Yang Qiming > > > > > > Hi Yang Qiming, > > We didn't face this issue while preparing patch. I think, Gregory tested it > for Intel > NICs. Adding more people to the loop for help. > > Shijith
Thanks a lot, Shijith Qiming
