Re: [dpdk-dev] [PATCH v4 2/4] net/mlx5: fix Tx stats error counter definition

[Yongseok Koh]

> On Sep 13, 2017, at 3:50 AM, Shahaf Shuler <shah...@mellanox.com> wrote:
> 
> The current Tx error counter counts, according to its description,
> the total number of packets not sent when TX ring full. It is reported
> to application as part of oerrors field.
> 
> The drop due to full ring is not the statistic that should be set on
> oerrors field. Such number can be counted by the application using the
> return value of the Tx burst function.
> The number that should be set there is the number of packets the device
> could not transmit in any way, even when it has resources.
> 
> Therefore, replace this counter to count the total number of failed
> transmitted packets.
> 
> Fixes: 87011737b715 ("mlx5: add software counters")
> Cc: sta...@dpdk.org
> Cc: adrien.mazarg...@6wind.com
> 
> Signed-off-by: Shahaf Shuler <shah...@mellanox.com>
> ---
Acked-by: Yongseok Koh <ys...@mellanox.com>