Re: [dpdk-dev] [PATCH v2] doc: announce API and ABI change for ethdev

2017-08-03 Thread Remy Horton
On 04/08/2017 06:27, Zhiyong Yang wrote: This is an API/ABI change notice for DPDK 17.11 on redefinition of port_id. port_id is defined as uint8_t by now, which is just ranged from 0 to 255. For more and more scenerioes, more than 256 ports are needed to support for vdev scalability. It is nece

Re: [dpdk-dev] [PATCH] doc: announce API and ABI change for ethdev

2017-08-03 Thread Yang, Zhiyong
Hi, yuanhan: > -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Friday, August 4, 2017 12:07 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org; Wang, Zhihong ; Mcnamara, > John ; oilvier.m...@6wind.com; > tho...@monjalon.net > Subject: Re: [dpdk-dev] [PATCH] doc: annou

[dpdk-dev] [PATCH v2] doc: announce API and ABI change for ethdev

2017-08-03 Thread Zhiyong Yang
This is an API/ABI change notice for DPDK 17.11 on redefinition of port_id. port_id is defined as uint8_t by now, which is just ranged from 0 to 255. For more and more scenerioes, more than 256 ports are needed to support for vdev scalability. It is necessary for redefinition of port_id to extend

Re: [dpdk-dev] [PATCH] doc: announce ABI change for cryptodev and ethdev

2017-08-03 Thread Hemant Agrawal
On 8/3/2017 9:02 PM, Akhil Goyal wrote: Support for security operations is planned to be added in ethdev and cryptodev for the 17.11 release. For this following changes are required. - rte_cryptodev and rte_eth_dev structures need to be added new parameter rte_security_ops which extend support f

Re: [dpdk-dev] [PATCH] eal: add notice to make DPDK IOVA aware

2017-08-03 Thread Hemant Agrawal
On 8/4/2017 9:11 AM, santosh wrote: On Tuesday 11 July 2017 03:31 PM, Jerin Jacob wrote: When we run DPDK on guest or VFIO mode on host, the dpdk library or device will not be directly accessing the physical address. Instead, the device does go through an IO address translation memory managemen

Re: [dpdk-dev] [PATCH] doc: announce API and ABI change for ethdev

2017-08-03 Thread Jerin Jacob
-Original Message- > Date: Fri, 4 Aug 2017 12:07:28 +0800 > From: Yuanhan Liu > To: Zhiyong Yang > Cc: dev@dpdk.org, zhihong.w...@intel.com, john.mcnam...@intel.com, > oilvier.m...@6wind.com, tho...@monjalon.net > Subject: Re: [dpdk-dev] [PATCH] doc: announce API and ABI change for ethde

Re: [dpdk-dev] [PATCH] doc: announce API and ABI change for ethdev

2017-08-03 Thread Yuanhan Liu
On Wed, Jul 12, 2017 at 03:58:46PM +0800, Zhiyong Yang wrote: > This is an API/ABI change notice for DPDK 17.11 on redefinition of Don't put 2 whitespace char indentation here. > port_id. port_id is defined as uint8_t by now, which is just ranged > from 0 to 255. For more and more scenerioes, m

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-08-03 Thread santosh
Hi Thomas, On Monday 10 July 2017 08:07 PM, Thomas Monjalon wrote: > 10/07/2017 16:22, santosh: >> On Monday 10 July 2017 07:39 PM, Thomas Monjalon wrote: >> >>> 10/07/2017 15:56, santosh: On Monday 10 July 2017 07:21 PM, Thomas Monjalon wrote: > 10/07/2017 15:30, santosh: >> Hi

Re: [dpdk-dev] [PATCH] eal: add notice to make DPDK IOVA aware

2017-08-03 Thread santosh
On Tuesday 11 July 2017 03:31 PM, Jerin Jacob wrote: > When we run DPDK on guest or VFIO mode on host, > the dpdk library or device will not be directly accessing > the physical address. Instead, the device does go through > an IO address translation memory management unit. On x86, > we call it as

[dpdk-dev] [PATCH] doc: fix a typo in kni documentation

2017-08-03 Thread Jerin Jacob
Fixes: fc1f2750a3ec ("doc: programmers guide") Signed-off-by: Jerin Jacob --- doc/guides/prog_guide/kernel_nic_interface.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/kernel_nic_interface.rst b/doc/guides/prog_guide/kernel_nic_interface.rst index

[dpdk-dev] DPDK qos support for 40G port

2017-08-03 Thread Kevin Yan
Hi, I have a question about dpdk qos feature, in rte_sched.h, /** Port configuration parameters. */ struct rte_sched_port_params { const char *name;/**< String to be associated */ int socket; /**<

Re: [dpdk-dev] [PATCH] doc: announce API and ABI change for ethdev

2017-08-03 Thread Tan, Jianfeng
On 7/12/2017 12:58 AM, Zhiyong Yang wrote: This is an API/ABI change notice for DPDK 17.11 on redefinition of A nit: we usually don't indent at the commit message paragraph. port_id. port_id is defined as uint8_t by now, which is just ranged from 0 to 255. For more and more scenerioes, m

Re: [dpdk-dev] [PATCH] app/testpmd: fix wrong cmdline message

2017-08-03 Thread Hu, Jiayu
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, August 4, 2017 5:40 AM > To: Hu, Jiayu > Cc: dev@dpdk.org; Yigit, Ferruh ; Wu, Jingjing > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix wrong cmdline message > > 03/08/2017 13:11, F

Re: [dpdk-dev] [PATCH] doc: update programmer's guide for the GRO library

2017-08-03 Thread Hu, Jiayu
Hi John, > -Original Message- > From: Mcnamara, John > Sent: Thursday, August 3, 2017 10:42 PM > To: Thomas Monjalon ; Hu, Jiayu > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] doc: update programmer's guide for the > GRO library > > > > > -Original Message- > > From: de

[dpdk-dev] [PATCH] examples/l3fwd: fix IPv6 packet type parse

2017-08-03 Thread Qi Zhang
Fix a typo that cause IPv6 packet type not be parsed. Fixes: 71a7e2424e07 ("examples/l3fwd: fix using packet type blindly") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- examples/l3fwd/l3fwd_em.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l3fwd/l3fwd_em.c b/e

[dpdk-dev] [dpdk-announce] release candidate 17.08-rc4

2017-08-03 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: http://dpdk.org/browse/dpdk/tag/?id=v17.08-rc4 It should be the last release candidate before the release on Monday. Most of the high priority bugs should be fixed hopefully. Some critical fixes can be integrated in the last days if they a

Re: [dpdk-dev] [PATCH] doc: remove unnecessary deprecation announcement

2017-08-03 Thread Thomas Monjalon
> > The original purpose of this deprecation is to make sure pci devices are > > reset whenever DPDK apps crash. Since the commit b58eedfc7dd5 ("igb_uio: > > issue FLR during open and release of device file") from Shijith can fix > > this problem without deprecating anything, now there is no need t

Re: [dpdk-dev] [PATCH] maintainers: add event ring test to eventdev

2017-08-03 Thread Thomas Monjalon
> > This file was not referenced in MAINTAINERS list. > > The miss is spotted with devtools/check-maintainers.sh. > > > > As this test file is related to eventdev, they should both > > have the same maintainer. > > > > Fixes: 1ee55d7a6e4d ("test/eventdev: add auto-tests for event ring > > functi

Re: [dpdk-dev] [PATCH] doc: move keepalive to multicore API section

2017-08-03 Thread Thomas Monjalon
> > The keepalive header was listed in misc section, despite its doxygen > > comment is "LCore Keepalive Monitor". > > > > Fixes: 75583b0d1efd ("eal: add keep alive monitoring") > > > > Signed-off-by: Thomas Monjalon > > Acked-by: John McNamara Applied

Re: [dpdk-dev] [PATCH] doc: move metrics libs to device API section

2017-08-03 Thread Thomas Monjalon
> > The metrics headers were listed in misc section, whereas they belong to > > the device API family. > > > > Fixes: 349950ddb9c5 ("metrics: add information metrics library") > > Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library") > > Fixes: 5cd3cac9ed22 ("latency: added new library f

Re: [dpdk-dev] [PATCH] doc: remove outdate list of supported OS

2017-08-03 Thread Thomas Monjalon
> > It is very difficult to list OS which are really supported. > > Instead of continuing this unrealistic effort, a more reliable list of > > tested platforms and OS is updated in the release notes. > > > > Signed-off-by: Thomas Monjalon > > > Acked-by: John McNamara Applied

Re: [dpdk-dev] [PATCH] doc: add tested Intel platforms with Intel NICs

2017-08-03 Thread Thomas Monjalon
> > Add tested Intel platforms with Intel NICs to the release note. > > > > Signed-off-by: Yulong Pei > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH v1] doc: add note about uio not working with uefi secure boot

2017-08-03 Thread Thomas Monjalon
03/08/2017 19:19, John McNamara: > Added notes to the documentation warning that if UEFI secure boot > is enabled the Linux kernel may disallow the use of UIO on the > system, and a suggested workaround of using the vfio-pci kernel > module instead of igb_uio or uio_pci_generic. > > Signed-off-by:

Re: [dpdk-dev] [PATCH v2] doc: add how-to on packet capture framework

2017-08-03 Thread Thomas Monjalon
03/08/2017 15:09, Reshma Pattan: > Add How-To doc to describe the use of the pdump library > and the dpdk-pdump tool to capture traffic on DPDK > ports. > > Signed-off-by: Reshma Pattan > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] doc: add description of the traffic management api

2017-08-03 Thread Thomas Monjalon
> > This patch adds description of the traffic management api to dpdk > > programmers guide. > > > > Signed-off-by: Jasvinder Singh > > Signed-off-by: Cristian Dumitrescu > > > ... > > > > +* Part of DPDK rte_ethdev API > > +* Capability query API per port, per hierarchy level and per hirearc

Re: [dpdk-dev] [PATCH v6] doc: document NIC features

2017-08-03 Thread Thomas Monjalon
01/08/2017 17:23, Ferruh Yigit: > +:orphan: > + > +.. _nic_overview_features: Why have you done an orphan page? I think it should be in doc/guides/nics/overview.rst

Re: [dpdk-dev] [PATCH v3] doc: add new targets to "make help" output

2017-08-03 Thread Thomas Monjalon
Hi, Sorry for the very very late review. 07/07/2017 19:09, Gabriel Carrillo: > Commit aafaea3d3b70 ("devtools: add tags > and cscope index generation") introduced > new make targets. This change updates the > help target output to reflect the additions. > > Signed-off-by: Gabriel Carrillo > ---

Re: [dpdk-dev] [PATCH v3 2/3] mk: allow use of environment var for template

2017-08-03 Thread Thomas Monjalon
07/06/2017 16:37, David Hunt: > Added new environment variable RTE_TEMPLATE which is an additional > variable that can be set in the users environment. This maps on to the > existing 'T' command line variable typically used when 'make config' > or 'make install' is invoked. > > So, instead of typi

Re: [dpdk-dev] [PATCH v3 1/3] mk: add sensible default target with defconfig

2017-08-03 Thread Thomas Monjalon
07/06/2017 16:37, David Hunt: > Users can now use 'make defconfig' to generate a configuration using > the most appropriate defaults for the current machine. > > > arch taken from uname -m > machine defaults to native > execenv is taken from uname, Linux=linuxapp, otherwise bsdapp > toolc

Re: [dpdk-dev] [PATCH] test/crypto: fix error message

2017-08-03 Thread Thomas Monjalon
> > Fixes: 7a364faef185 ("cryptodev: remove crypto device type enumeration") > > > > Signed-off-by: Pablo de Lara > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix incorrect IV allocation

2017-08-03 Thread Thomas Monjalon
01/08/2017 02:33, Pablo de Lara: > Memory is reserved after each crypto operation > for the necessary IV(s), which could be for cipher, > authentication or AEAD algorithms. > However, for AEAD algorithms (such as AES-GCM), this > memory was not being reserved, leading to potential > memory overflow

Re: [dpdk-dev] [PATCH v1] app/testpmd: fix Tx first with LSC interrupt

2017-08-03 Thread Thomas Monjalon
> > The lsc_interrupt flag is enabled by default, and when the --tx-first is > > used > > as a command line parameter, the 32 packets can be sent out before the > > link state is up, resulting in the loss of the packets, and no further > > forwarding will take place. > > > > E.g. ./build/app/test

Re: [dpdk-dev] [PATCH] app/testpmd: fix wrong cmdline message

2017-08-03 Thread Thomas Monjalon
03/08/2017 13:11, Ferruh Yigit: > On 8/3/2017 10:45 AM, Jiayu Hu wrote: > > In testpmd, GRO is supported by csum forwarding engine, but the cmdline > > message shows GRO is supported by io forwarding engine. This patch is > > to fix this issue. > > > > Fixes: b40f8d782ba1 ("app/testpmd: enable TCP

Re: [dpdk-dev] [PATCH v2] net/mlx5: add parameters to enable/disable vector code

2017-08-03 Thread Thomas Monjalon
02/08/2017 17:32, Nelio Laranjeiro: > Vector code is very young and can present some issues for users, to avoid > them to modify the selections function by commenting the code and recompile > the PMD, new devices parameters are added to deactivate the Tx and/or Rx > vector code. > By using such dev

Re: [dpdk-dev] [PATCH] net/mlx5: fix statistics for error packets on vectorized Rx

2017-08-03 Thread Thomas Monjalon
02/08/2017 19:25, Yongseok Koh: > If there's a Rx completion with error (e.g, MTU mismatch), it is handled > later out of main burst loop as a slow path for performance reason. > Statistics should be corrected by subtracting counters of errored packets. > Also, the last entry of mlx5_ptype_table[]

Re: [dpdk-dev] [PATCH] net/mlx5: fix calculation of offload flags on vectorized Rx

2017-08-03 Thread Thomas Monjalon
02/08/2017 19:29, Yongseok Koh: > The pinfo variable has wrong data. This has to have merged data of two > fields from Rx completion - pkt_info and hdr_type_etc. > > Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86") > > Signed-off-by: Yongseok Koh > Acked-by: Nelio Laranjeiro

Re: [dpdk-dev] [PATCH] net/mlx5: fix trimming SW ring for vectorized Rx

2017-08-03 Thread Thomas Monjalon
03/08/2017 23:12, Yongseok Koh: > Unlike mlx5_rx_burst(), mlx5_rx_burst_vec() doesn't replace completed > buffers one by one right after completion is processed but replenishes > multiple buffers later with rte_mempool_get_bulk(). Therefore, there could > be some buffer addresses left in the SW rin

Re: [dpdk-dev] [PATCH] net/mlx5: fix buffer address posting in vectorized Rx

2017-08-03 Thread Thomas Monjalon
01/08/2017 18:35, Yongseok Koh: > The data_off field of newly allocated mbufs is stale data. This shouldn't > be used in calculating Rx address for device when posting free buffers. > RTE_PKTMBUF_HEADROOM should be used instead and data_off of a mbuf will be > reset on packet reception anyway. > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/mlx5: fix MTU update

2017-08-03 Thread Thomas Monjalon
03/08/2017 11:31, Nelio Laranjeiro: > Changing the MTU is not related to changing the number of segments, > activating or not the multi-segment support should be handled by the > application. > > Fixes: 9964b965ad69 ("net/mlx5: re-add Rx scatter support") > Cc: sta...@dpdk.org > > Signed-off-by:

[dpdk-dev] [PATCH] net/mlx5: fix trimming SW ring for vectorized Rx

2017-08-03 Thread Yongseok Koh
Unlike mlx5_rx_burst(), mlx5_rx_burst_vec() doesn't replace completed buffers one by one right after completion is processed but replenishes multiple buffers later with rte_mempool_get_bulk(). Therefore, there could be some buffer addresses left in the SW ring (rxq->elts[]) which have already been

Re: [dpdk-dev] [PATCH v2] net/mlx4: workaround to verbs wrong error return

2017-08-03 Thread Thomas Monjalon
02/08/2017 21:00, Matan Azrad: > Current mlx4 OFED version has bug which returns error to > ibv destroy functions when the device was plugged out, in > spite of the resources were destroyed correctly. > > Hence, failsafe PMD was aborted, only in debug mode, when > it tries to remove the device in

Re: [dpdk-dev] [dpdk-stable] [PATCH] enic: check for nb_free > 0

2017-08-03 Thread Thomas Monjalon
> > Occasionally, the amount of packets to free from the work queue ends > > perfectly on a boundary to have nb_free = 0 and pool = 0. This causes a > > segfault as follows: > > > > (gdb) bt > > #0 rte_mempool_default_cache (mp=, mp= > out>, > > lcore_id=) > > at /usr/src/debug/o

Re: [dpdk-dev] [PATCH] net/i40e: fix data segment buffer length

2017-08-03 Thread Thomas Monjalon
> >Buffer length be configured for each data segment should not exceed > >the requested value, or device may fill data that exceed the boundary > >of memory that be reserved. > > > >Fixes: 4861cde46116 ("i40e: new poll mode driver") > >Cc: sta...@dpdk.org > > > >Signed-off-by: Jianfeng Tan > >Sign

[dpdk-dev] [PATCH v2] doc: deprecate Xen support

2017-08-03 Thread Jianfeng Tan
Following the calls on the mailing list: http://dpdk.org/ml/archives/dev/2017-June/068151.html The Technical Board decided to drop Xen dom0 support from EAL: http://dpdk.org/ml/archives/dev/2017-June/068615.html Signed-off-by: Thomas Monjalon Signed-off-by: Jianfeng Tan --- doc/

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix blank line parsing

2017-08-03 Thread Thomas Monjalon
03/08/2017 17:08, Gaetan Rivet: > When the output of an exec() slave definition is only a single newline > character, the fail-safe currently fails to parse the device with the > value returned by the rte_devargs library. > > This behavior is incorrect, because the fail-safe should make a > differ

Re: [dpdk-dev] [PATCH] net/failsafe: fix for missing pclose after popen

2017-08-03 Thread Thomas Monjalon
03/08/2017 15:58, Gaëtan Rivet: > Hi Raslan, > > I sent a patch earlier regarding this but we will use yours. > Two small nits below. > > On Thu, Aug 03, 2017 at 04:09:58PM +0300, rasl...@mellanox.com wrote: > > From: Raslan Darawsheh > > > > When there is no prefered device, failsafe will alwa

Re: [dpdk-dev] [PATCH] net/vmxnet3: restore correct filtering

2017-08-03 Thread Thomas Monjalon
> > We should only restore shadow_vfta when hw_vlan_filter is active. > > Otherwise, we should restore the previous filtering behavior. > > > > Fixes: f003fc383487("vmxnet3: enable vlan filtering") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Chas Williams > > Acked-by: Shrikrishna Khare Ap

Re: [dpdk-dev] [PATCH] vhost: make the page logging atomic

2017-08-03 Thread Thomas Monjalon
01/08/2017 14:05, Maxime Coquelin: > On 08/01/2017 11:01 AM, Tiwei Bie wrote: > > Each dirty page logging operation should be atomic. But it's not > > atomic in current implementation. So it's possible that some dirty > > pages can't be logged successfully when different threads try to > > log diff

Re: [dpdk-dev] [PATCH] eal: fix leak in hotplug add on parse error

2017-08-03 Thread Thomas Monjalon
03/08/2017 14:34, Gaetan Rivet: > If rte_eal_devargs_parse fails, the rte_devargs has not yet been inserted > in the global list. When jumping to err_devarg, the removal fails and it > is not properly freed. > > Free the allocated rte_devargs if its removal failed. > > Coverity issue: 158658 > Fi

Re: [dpdk-dev] [RFC] ethdev: add ioctl-like API to control device specific features

2017-08-03 Thread Thomas Monjalon
03/08/2017 18:15, Stephen Hemminger: > On Thu, 3 Aug 2017 14:21:38 +0100 > Bruce Richardson wrote: > > > On Thu, Aug 03, 2017 at 01:21:35PM +0100, Chilikin, Andrey wrote: > > > To control some device-specific features public device-specific functions > > > rte_pmd_*.h are used. > > > > > > But t

Re: [dpdk-dev] [PATCH] eal: fix possible segfault in hotplug add

2017-08-03 Thread Thomas Monjalon
03/08/2017 14:34, Gaetan Rivet: > If devargs is NULL, building the full_dev_name will segfault > when using strlen on it. > > Coverity issue: 158630 > Fixes: 7e8b26650146 ("eal: fix hotplug add / remove") > > Signed-off-by: Gaetan Rivet Applied, thanks

Re: [dpdk-dev] [PATCH] test/crypto: fix error message

2017-08-03 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Thursday, August 3, 2017 11:34 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] test/crypto: fix error message > > Fixes: 7a364faef185 ("cryptodev: remove cry

Re: [dpdk-dev] [PATCH v2] devargs: fix policy check in rte_eal_devargs_add

2017-08-03 Thread Thomas Monjalon
02/08/2017 19:12, Gaetan Rivet: > Do not fail upon detecting a set bus configuration when adding an > rte_devargs. i.e. adding a blacklisted PCI device while the bus is > configured in whitelist mode. > > This failure condition has been introduced when the bus policies > were implemented. This imp

[dpdk-dev] [PATCH] test/crypto: fix error message

2017-08-03 Thread Pablo de Lara
Fixes: 7a364faef185 ("cryptodev: remove crypto device type enumeration") Signed-off-by: Pablo de Lara --- test/test/test_cryptodev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c index 9803e66..a4116c6 100644 --- a

Re: [dpdk-dev] [PATCH v3] eal: read and parse device option separately

2017-08-03 Thread Thomas Monjalon
02/08/2017 19:10, Gaetan Rivet: > When the EAL parses the common options given to the application, > not all subsystems are available. Some device drivers are registered > afterward upon dynamic plugin loading. > > Devices using those drivers are thus unable to be parsed by any drivers > and are r

[dpdk-dev] [PATCH] net/ark: remove empty header file

2017-08-03 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- doc/guides/nics/ark.rst | 3 --- drivers/net/ark/ark_ethdev.c| 1 - drivers/net/ark/ark_ethdev.h| 37 - drivers/net/ark/ark_ethdev_rx.c | 1 - drivers/net/ark/ark_ethdev_tx.c | 1 - 5 files changed, 43 deletio

[dpdk-dev] [PATCH] net/virtio-user: send kick to tx queue to notify backend on initialization

2017-08-03 Thread Steven
Acccording to the spec, https://fossies.org/linux/qemu/docs/specs/vhost-user.txt client must start ring upon receiving a kick (that is, detecting that file descriptor is reachable) on the descriptor specified by VHOST_USER_SET_VRING_KICK. The code sends a kick to the rx queue. It is missing sendi

[dpdk-dev] [PATCH v1] doc: add note about uio not working with uefi secure boot

2017-08-03 Thread John McNamara
Added notes to the documentation warning that if UEFI secure boot is enabled the Linux kernel may disallow the use of UIO on the system, and a suggested workaround of using the vfio-pci kernel module instead of igb_uio or uio_pci_generic. Signed-off-by: John McNamara --- doc/guides/faq/faq.rst

Re: [dpdk-dev] [RFC] ethdev: add ioctl-like API to control device specific features

2017-08-03 Thread Stephen Hemminger
On Thu, 3 Aug 2017 14:21:38 +0100 Bruce Richardson wrote: > On Thu, Aug 03, 2017 at 01:21:35PM +0100, Chilikin, Andrey wrote: > > To control some device-specific features public device-specific functions > > rte_pmd_*.h are used. > > > > But this solution requires applications to distinguish dev

Re: [dpdk-dev] [PATCH] doc: postpone legacy log functions removal

2017-08-03 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, August 3, 2017 3:30 PM > To: dev@dpdk.org > Cc: olivier.m...@6wind.com > Subject: [dpdk-dev] [PATCH] doc: postpone legacy log functions removal > > The replacement function rte_l

Re: [dpdk-dev] [PATCH] doc: move metrics libs to device API section

2017-08-03 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, August 3, 2017 4:56 PM > To: Horton, Remy > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: move metrics libs to device API section > > The metrics headers were listed in mi

Re: [dpdk-dev] [PATCH] doc: remove outdate list of supported OS

2017-08-03 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, August 3, 2017 3:54 PM > To: Mcnamara, John > Cc: dev@dpdk.org > Subject: [PATCH] doc: remove outdate list of supported OS > > It is very difficult to list OS which are really supported. > Instea

Re: [dpdk-dev] [PATCH] doc: move keepalive to multicore API section

2017-08-03 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, August 3, 2017 4:55 PM > To: Horton, Remy > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: move keepalive to multicore API section > > The keepalive header was listed in mi

Re: [dpdk-dev] [PATCH] doc: deprecate Xen dom0 support

2017-08-03 Thread Thomas Monjalon
03/08/2017 17:33, Tan, Jianfeng: > Hi Thomas, > > On 8/3/2017 7:49 AM, Thomas Monjalon wrote: > > Following the calls on the mailing list: > > http://dpdk.org/ml/archives/dev/2017-June/068151.html > > The Technical Board decided to drop Xen dom0 support from EAL: > > http://dpdk.org/ml/arc

[dpdk-dev] [PATCH] doc: move metrics libs to device API section

2017-08-03 Thread Thomas Monjalon
The metrics headers were listed in misc section, whereas they belong to the device API family. Fixes: 349950ddb9c5 ("metrics: add information metrics library") Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library") Fixes: 5cd3cac9ed22 ("latency: added new library for latency stats") Sign

Re: [dpdk-dev] [PATCH] maintainers: add event ring test to eventdev

2017-08-03 Thread Jerin Jacob
-Original Message- > Date: Thu, 3 Aug 2017 17:51:55 +0200 > From: Thomas Monjalon > To: jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org > Subject: [PATCH] maintainers: add event ring test to eventdev > X-Mailer: git-send-email 2.13.2 > > This file was not referenced in MAINTAINERS list

[dpdk-dev] [PATCH] doc: move keepalive to multicore API section

2017-08-03 Thread Thomas Monjalon
The keepalive header was listed in misc section, despite its doxygen comment is "LCore Keepalive Monitor". Fixes: 75583b0d1efd ("eal: add keep alive monitoring") Signed-off-by: Thomas Monjalon --- doc/api/doxy-api-index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/

[dpdk-dev] [PATCH] maintainers: add event ring test to eventdev

2017-08-03 Thread Thomas Monjalon
This file was not referenced in MAINTAINERS list. The miss is spotted with devtools/check-maintainers.sh. As this test file is related to eventdev, they should both have the same maintainer. Fixes: 1ee55d7a6e4d ("test/eventdev: add auto-tests for event ring functions") Signed-off-by: Thomas Monj

Re: [dpdk-dev] eventdev API - experimental

2017-08-03 Thread Jerin Jacob
-Original Message- > Date: Thu, 03 Aug 2017 16:57:44 +0200 > From: Thomas Monjalon > To: Jerin Jacob > Cc: bruce.richard...@intel.com, dev@dpdk.org > Subject: eventdev API - experimental > > Hi, > > The eventdev API is still experimental. > Is it too early to drop the experimental flag

Re: [dpdk-dev] [PATCH v11 00/11] introduce fail-safe PMD

2017-08-03 Thread Ferruh Yigit
On 8/3/2017 2:49 PM, Gaëtan Rivet wrote: > On Thu, Aug 03, 2017 at 02:00:15PM +0100, Ferruh Yigit wrote: >> On 7/18/2017 5:08 PM, Ferruh Yigit wrote: >>> On 7/18/2017 1:48 PM, Gaetan Rivet wrote: This PMD intercepts and manages Ethernet device removal events issued by slave PMDs and re-in

Re: [dpdk-dev] [PATCH] pci: fix level of scan debug log on BSD

2017-08-03 Thread Thomas Monjalon
03/08/2017 12:16, Bruce Richardson: > On Tue, Jul 11, 2017 at 07:10:46PM +0200, Thomas Monjalon wrote: > > Printing the number of scanned devices should be a debug log, > > not an error. > > > > Signed-off-by: Thomas Monjalon > > --- [...] > > - RTE_LOG(ERR, EAL, "PCI scan found %u devices\n",

[dpdk-dev] [PATCH] doc: announce ABI change for cryptodev and ethdev

2017-08-03 Thread Akhil Goyal
Support for security operations is planned to be added in ethdev and cryptodev for the 17.11 release. For this following changes are required. - rte_cryptodev and rte_eth_dev structures need to be added new parameter rte_security_ops which extend support for security ops to the corresponding drive

Re: [dpdk-dev] [PATCH] doc: deprecate Xen dom0 support

2017-08-03 Thread Tan, Jianfeng
Hi Thomas, On 8/3/2017 7:49 AM, Thomas Monjalon wrote: Following the calls on the mailing list: http://dpdk.org/ml/archives/dev/2017-June/068151.html The Technical Board decided to drop Xen dom0 support from EAL: http://dpdk.org/ml/archives/dev/2017-June/068615.html As dom0 is

[dpdk-dev] [PATCH v2] net/failsafe: fix blank line parsing

2017-08-03 Thread Gaetan Rivet
When the output of an exec() slave definition is only a single newline character, the fail-safe currently fails to parse the device with the value returned by the rte_devargs library. This behavior is incorrect, because the fail-safe should make a difference between the absence of a device, and an

[dpdk-dev] eventdev API - experimental

2017-08-03 Thread Thomas Monjalon
Hi, The eventdev API is still experimental. Is it too early to drop the experimental flag in 17.08? Is it planned to be removed in 17.11?

[dpdk-dev] [PATCH] doc: remove outdate list of supported OS

2017-08-03 Thread Thomas Monjalon
It is very difficult to list OS which are really supported. Instead of continuing this unrealistic effort, a more reliable list of tested platforms and OS is updated in the release notes. Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/index.rst| 1 - doc/guides/rel_notes/suppor

[dpdk-dev] [PATCH] net/failsafe: fix blank line parsing

2017-08-03 Thread Gaetan Rivet
When the output of an exec() slave definition is only a single newline character, the fail-safe currently fails to parse the device with the value returned by the rte_devargs library. This behavior is incorrect, because the fail-safe should make a difference between the absence of a device, and an

[dpdk-dev] [PATCH] doc: deprecate Xen dom0 support

2017-08-03 Thread Thomas Monjalon
Following the calls on the mailing list: http://dpdk.org/ml/archives/dev/2017-June/068151.html The Technical Board decided to drop Xen dom0 support from EAL: http://dpdk.org/ml/archives/dev/2017-June/068615.html Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/deprecation.

Re: [dpdk-dev] [PATCH] doc: update programmer's guide for the GRO library

2017-08-03 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, July 21, 2017 4:09 PM > To: Hu, Jiayu > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: update programmer's guide for the GRO > library > > 11/07/2017 06:27, Jiayu Hu: > >

Re: [dpdk-dev] [PATCH] doc: notify libnuma dependency in release notes

2017-08-03 Thread Thomas Monjalon
> > Fixes: 066731939589 ("doc: add libnuma as dependency") > > Cc: john.mcnam...@intel.com > > > > Signed-off-by: Thomas Monjalon > > --- [...] > > +* **Starting with version 17.08, libnuma is required to build DPDK.** > > Acked-by: John McNamara Applied

Re: [dpdk-dev] [PATCH v2] doc: announce API/ABI changes for mempool

2017-08-03 Thread santosh
On Thursday 03 August 2017 07:51 PM, Jerin Jacob wrote: > -Original Message- >> Date: Thu, 20 Jul 2017 15:59:15 +0530 >> From: Santosh Shukla >> To: olivier.m...@6wind.com, dev@dpdk.org >> CC: thomas.monja...@6wind.com, Santosh Shukla >> >> Subject: [dpdk-dev] [PATCH v2] doc: announce A

[dpdk-dev] [PATCH] doc: postpone legacy log functions removal

2017-08-03 Thread Thomas Monjalon
The replacement function rte_log_get_level() has just been implemented in 17.08. Better to postpone the removal of legacy functions to 17.11. Fixes: 4f0981e6ec6c ("eal: deprecate log functions") Cc: olivier.m...@6wind.com Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/deprecation.rst |

Re: [dpdk-dev] [PATCH] doc: notify libnuma dependency in release notes

2017-08-03 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, August 3, 2017 2:55 PM > To: Mcnamara, John > Cc: dev@dpdk.org > Subject: [PATCH] doc: notify libnuma dependency in release notes > > Fixes: 066731939589 ("doc: add libnuma as dependency") > Cc:

Re: [dpdk-dev] [PATCH v2] doc: announce API/ABI changes for mempool

2017-08-03 Thread Jerin Jacob
-Original Message- > Date: Thu, 20 Jul 2017 15:59:15 +0530 > From: Santosh Shukla > To: olivier.m...@6wind.com, dev@dpdk.org > CC: thomas.monja...@6wind.com, Santosh Shukla > > Subject: [dpdk-dev] [PATCH v2] doc: announce API/ABI changes for mempool > X-Mailer: git-send-email 2.11.0 > >

Re: [dpdk-dev] [PATCH] doc: announce API change in crypto driver allocation

2017-08-03 Thread Jain, Deepak K
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, August 3, 2017 2:03 AM > To: tho...@monjalon.net; jerin.ja...@caviumnetworks.com; > akhil.go...@nxp.com; hemant.agra...@nxp.com; Trahe, Fiona > ; Jain, Deepak K ; > Griffin, John ; Doherty, Declan > > Cc: dev@dpdk.org; D

Re: [dpdk-dev] [PATCH] doc: announce crypto vdev init removal

2017-08-03 Thread Jain, Deepak K
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, August 3, 2017 3:12 AM > To: tho...@monjalon.net; jerin.ja...@caviumnetworks.com; > akhil.go...@nxp.com; hemant.agra...@nxp.com; Trahe, Fiona > ; Jain, Deepak K ; > Griffin, John ; Doherty, Declan > ; Mcnamara, John > >

Re: [dpdk-dev] [PATCH] net/virtio-user: send kick to tx queue to notify backend on initialization

2017-08-03 Thread Steven Luong (sluong)
Maxime, Thank you so much for the reply. 1. It’s about conforming to the spec. Please read the text as I quoted in the email. A non-conforming implementation does not communicate with a conforming implementation such as VPP. 2. QEMU’s implementation is conforming and it is sending kick for both

Re: [dpdk-dev] [PATCH] doc: notify x86 SSE4.2 requirement in release notes

2017-08-03 Thread Thomas Monjalon
03/08/2017 15:50, Bruce Richardson: > On Thu, Aug 03, 2017 at 03:46:11PM +0200, Thomas Monjalon wrote: > > Signed-off-by: Thomas Monjalon [...] > > +* **Bumped minimal x86 ISA to SSE4.2.** > > + > > + Starting with version 17.08, DPDK requires SSE4.2 to run on x86. > > For clarification, I think

Re: [dpdk-dev] [PATCH] doc: announce crypto vdev init removal

2017-08-03 Thread Jain, Deepak K
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, August 3, 2017 3:12 AM > To: tho...@monjalon.net; jerin.ja...@caviumnetworks.com; > akhil.go...@nxp.com; hemant.agra...@nxp.com; Trahe, Fiona > ; Jain, Deepak K ; > Griffin, John ; Doherty, Declan > ; Mcnamara, John > >

Re: [dpdk-dev] [PATCH] net/failsafe: fix resource leak on parse error

2017-08-03 Thread Gaëtan Rivet
self-nack. This issue has been fixed by Raslan in [1]. [1]: http://dpdk.org/ml/archives/dev/2017-August/072429.html On Thu, Aug 03, 2017 at 02:34:00PM +0200, Gaetan Rivet wrote: > If fgets fails, the handle fp is not properly closed. > > Coverity issue: 158633 > Fixes: a0194d828100 ("net/failsa

Re: [dpdk-dev] [PATCH] dev: update git fixline alias

2017-08-03 Thread Thomas Monjalon
03/08/2017 15:42, Harry van Haaren: > The git fixline was updated in the dpdk.org repository to add the original > author of the line being "fixed", using Cc: > > This patch updates the fixline here in the website. See patch for details: > http://dpdk.org/dev/patchwork/patch/26860/ > > Signed-off

Re: [dpdk-dev] [PATCH] net/failsafe: fix for missing pclose after popen

2017-08-03 Thread Gaëtan Rivet
Hi Raslan, I sent a patch earlier regarding this but we will use yours. Two small nits below. On Thu, Aug 03, 2017 at 04:09:58PM +0300, rasl...@mellanox.com wrote: > From: Raslan Darawsheh > > When there is no prefered device, failsafe will always > try to scan for prefered device. And if there

[dpdk-dev] [PATCH] doc: notify libnuma dependency in release notes

2017-08-03 Thread Thomas Monjalon
Fixes: 066731939589 ("doc: add libnuma as dependency") Cc: john.mcnam...@intel.com Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/release_17_08.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08.rst inde

Re: [dpdk-dev] [PATCH] doc: notify x86 SSE4.2 requirement in release notes

2017-08-03 Thread Bruce Richardson
On Thu, Aug 03, 2017 at 03:46:11PM +0200, Thomas Monjalon wrote: > Signed-off-by: Thomas Monjalon > --- > doc/guides/rel_notes/release_17_08.rst | 4 > 1 file changed, 4 insertions(+) > > diff --git a/doc/guides/rel_notes/release_17_08.rst > b/doc/guides/rel_notes/release_17_08.rst > index

Re: [dpdk-dev] [PATCH v11 00/11] introduce fail-safe PMD

2017-08-03 Thread Gaëtan Rivet
On Thu, Aug 03, 2017 at 02:00:15PM +0100, Ferruh Yigit wrote: > On 7/18/2017 5:08 PM, Ferruh Yigit wrote: > > On 7/18/2017 1:48 PM, Gaetan Rivet wrote: > >> This PMD intercepts and manages Ethernet device removal events issued by > >> slave PMDs and re-initializes them transparently when brought ba

[dpdk-dev] [PATCH] doc: notify x86 SSE4.2 requirement in release notes

2017-08-03 Thread Thomas Monjalon
Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/release_17_08.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08.rst index c3554761c..d5a708a09 100644 --- a/doc/guides/rel_notes/release_17_08.rst +++ b/d

[dpdk-dev] [PATCH] dev: update git fixline alias

2017-08-03 Thread Harry van Haaren
The git fixline was updated in the dpdk.org repository to add the original author of the line being "fixed", using Cc: This patch updates the fixline here in the website. See patch for details: http://dpdk.org/dev/patchwork/patch/26860/ Signed-off-by: Harry van Haaren --- dev.html | 2 +- 1 fil

Re: [dpdk-dev] Use rte_malloc in application

2017-08-03 Thread Stefan Puiu
Hi, This is not strictly DPDK-related, but still... On Thu, Aug 3, 2017 at 9:12 AM, Rohit Saini (Stellus) wrote: > With below code, I am getting this warning. > > warning: cast to pointer from integer of different size > [-Wint-to-pointer-cast] > > my_node_t *data_ptr = (my_node_t *) rte_malloc

Re: [dpdk-dev] [PATCH] doc: add author on cc to git fixline alias

2017-08-03 Thread Thomas Monjalon
> > With this commit, the correct method to use git fixline to indicate a fix > > of a previous commit has changed. The new rules require the author of the > > original code that is being fixed to be on CC. > > > > The logic behind this improvement is that if there is a genuine bug, one > > of the

Re: [dpdk-dev] [RFC] ethdev: add ioctl-like API to control device specific features

2017-08-03 Thread Bruce Richardson
On Thu, Aug 03, 2017 at 01:21:35PM +0100, Chilikin, Andrey wrote: > To control some device-specific features public device-specific functions > rte_pmd_*.h are used. > > But this solution requires applications to distinguish devices at runtime > and, depending on the device type, call correspondin

  1   2   >