Hi John, > -----Original Message----- > From: Mcnamara, John > Sent: Thursday, August 3, 2017 10:42 PM > To: Thomas Monjalon <tho...@monjalon.net>; Hu, Jiayu > <jiayu...@intel.com> > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] doc: update programmer's guide for the > GRO library > > > > > -----Original Message----- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Friday, July 21, 2017 4:09 PM > > To: Hu, Jiayu <jiayu...@intel.com> > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] doc: update programmer's guide for the > GRO > > library > > > > 11/07/2017 06:27, Jiayu Hu: > > > Add description to programmer's guide to explain the design of the GRO > > > library. > > > > > > Signed-off-by: Jiayu Hu <jiayu...@intel.com> > > > --- > > > MAINTAINERS | 1 + > > > .../prog_guide/generic_receive_offload_lib.rst | 163 > > +++++++++++++++++++++ > > > doc/guides/prog_guide/index.rst | 1 + > > > doc/guides/prog_guide/source_org.rst | 1 + > > > 4 files changed, 166 insertions(+) > > > create mode 100644 > > > doc/guides/prog_guide/generic_receive_offload_lib.rst > > > > Looking for a reviewer of this new doc. Any volunteer? > > > I'll review and reply to Jiayu directly.
Thanks a lot and wait for your important comments. > > > > > > > --- a/doc/guides/prog_guide/source_org.rst > > > +++ b/doc/guides/prog_guide/source_org.rst > > > @@ -68,6 +68,7 @@ The lib directory contains:: > > > +-- librte_distributor # Packet distributor > > > +-- librte_eal # Environment abstraction layer > > > +-- librte_ether # Generic interface to poll mode driver > > > + +-- librte_gro # Generic receive offload library > > > +-- librte_hash # Hash library > > > +-- librte_ip_frag # IP fragmentation library > > > +-- librte_kni # Kernel NIC interface > > > > I really want we remove this file. > > It is useless and not well maintained. > > > Agreed. It is guaranteed to be out of date. It could be replaced with a much > shorter and more generic description of the main source dirs without > mentioning any of the sub-folders or files. Thanks, I will remove these changes. BRs, Jiayu > > John >
