07/06/2017 16:37, David Hunt: > Added new environment variable RTE_TEMPLATE which is an additional > variable that can be set in the users environment. This maps on to the > existing 'T' command line variable typically used when 'make config' > or 'make install' is invoked. > > So, instead of typing 'make config T=x86_64-native-linuxapp-gcc', the user > can now do 'export RTE_TEMPLATE=x86_64-native-linuxapp-gcc' followed by > 'make config'. If the user instead chooses to 'make install', this will > do the configure, build, and install in one step. [...] > --- a/mk/rte.sdkinstall.mk > +++ b/mk/rte.sdkinstall.mk > @@ -47,6 +47,10 @@ ifneq ($(MAKECMDGOALS),pre_install) > include $(RTE_SDK)/mk/rte.vars.mk > endif > > +ifndef T > +T := $(RTE_TEMPLATE) > +endif
"make install T=" is an old syntax. We should drop this non-standard syntax. So I prefer we do not encourage it with this variable. > --- a/mk/rte.sdkroot.mk > +++ b/mk/rte.sdkroot.mk > +ifdef RTE_TEMPLATE > +RTE_CONFIG_TEMPLATE := $(RTE_SRCDIR)/config/defconfig_$(RTE_TEMPLATE) > +endif What is the benefit of exporting RTE_TEMPLATE instead of T= ? I am afraid it get more confusion.
