Re: [dpdk-dev] [pull-request] next-eventdev 17.08 rc2

2017-07-19 Thread Thomas Monjalon
20/07/2017 07:22, Jerin Jacob: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks

Re: [dpdk-dev] [pull-request] next-net 17.08 RC2

2017-07-19 Thread Thomas Monjalon
19/07/2017 18:23, Ferruh Yigit: > http://dpdk.org/git/next/dpdk-next-net Pulled, thanks

Re: [dpdk-dev] [PATCH] all: refactor coding style

2017-07-19 Thread Tiwei Bie
On Thu, Jul 20, 2017 at 10:34:39AM +0530, Shreyansh Jain wrote: > On Wednesday 19 July 2017 02:36 PM, Tiwei Bie wrote: > > Remove the unwanted spaces before `;' across DPDK source code > > by below one-liner with some minor manual refinements. > > > > find . -name '*.[ch]' | xargs sed -i 's/\([^;(

Re: [dpdk-dev] [PATCH] all: refactor coding style

2017-07-19 Thread Shreyansh Jain
On Wednesday 19 July 2017 02:36 PM, Tiwei Bie wrote: Remove the unwanted spaces before `;' across DPDK source code by below one-liner with some minor manual refinements. find . -name '*.[ch]' | xargs sed -i 's/\([^;(]\) \+;/\1;/g' The fixes for cmdline library are skipped, because it has a diff

[dpdk-dev] [PATCH 8/8] net/bnxt: fix to free a filter before reusing it

2017-07-19 Thread Ajit Khaparde
This patch sends the HWRM command to free a filter in the hardware, before using it again. Fixes: f92735db1e4c ("net/bnxt: add L2 filter alloc/init/free") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/bnxt/bnxt_h

[dpdk-dev] [PATCH 7/8] net/bnxt: check invalid l2_filter_id

2017-07-19 Thread Ajit Khaparde
Add code to check for invalid filter_id in bnxt_hwrm_clear_filter Fixes: f92735db1e4c ("net/bnxt: add L2 filter alloc/init/free") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/

[dpdk-dev] [PATCH 6/8] net/bnxt: fix VLAN antispoof configuration code

2017-07-19 Thread Ajit Khaparde
We are wrongly using a Rx side HWRM command set_rx_mask to configure VLAN anti-spoof. This being a Tx side feature, this patch tries to fix it. Since the HWRM command to do it ringt is available only in the newer firmware versions, the patch verifies the firmware version before attempting to send

[dpdk-dev] [PATCH 5/8] net/bnxt: reset VF stats during initialization

2017-07-19 Thread Ajit Khaparde
This patch resets the VF stats during initialization Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bnxt/bnxt_h

[dpdk-dev] [PATCH 1/8] net/bnxt: fix log levels for non error conditions.

2017-07-19 Thread Ajit Khaparde
1) handle_async_event is a DEBUG level log message. 2) Log "Unable to get default VNIC for VF %d" at INFO level. Fixes: 36735a932ca7 ("support set VF QOS and MAC anti spoof") Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_cpr.c | 2 +- drivers/net/bnxt/r

[dpdk-dev] [PATCH 3/8] net/bnxt: fix vnic cleanup

2017-07-19 Thread Ajit Khaparde
Check if the vnic_id and rss_rule is not invalid before passing it to the firmware to cleanup the VNIC. Log a message if the vnic_id is invalid. Fixes: db678d5c2b54 ("net/bnxt: add HWRM VNIC configure") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 19 ++- 1 fi

[dpdk-dev] [PATCH 0/8] bnxt patchset

2017-07-19 Thread Ajit Khaparde
Hi, This patch set fixes some of the issues found during testing. Please apply. Thanks net/bnxt: fix log levels for non error conditions. net/bnxt: fix to avoid a segfault net/bnxt: fix vnic cleanup net/bnxt: fix set link config net/bnxt: reset VF stats during initialization net/bnxt:

[dpdk-dev] [PATCH 4/8] net/bnxt: fix set link config

2017-07-19 Thread Ajit Khaparde
remove the unnecessary rte_delay in bnxt_set_hwrm_link_config Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_h

[dpdk-dev] [PATCH 2/8] net/bnxt: fix to avoid a segfault

2017-07-19 Thread Ajit Khaparde
Fix use of local variable to avoid segfault. cnt was incorrectly tested and decremented in the loop that removes a VLAN from the table. Fixes: 36735a932ca7 ("support set VF QOS and MAC anti spoof") Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/rte_pmd_bnxt.c | 1

[dpdk-dev] only two of the four queues work on the VF interface of Intel X553 nic.

2017-07-19 Thread Bill Bonaparte
Hi all, I encounter a problem that there are two of the four queues working for dpdk-apps when using the VF interface of intel x553 10G-ethernet NIC. Straightly speaking, there are no packets coming into the last two queues, no matter what packets I send to the dpdk-apps. I checked

[dpdk-dev] [pull-request] next-eventdev 17.08 rc2

2017-07-19 Thread Jerin Jacob
The following changes since commit da94a999d3eae6a4c565f2a23c3ab303909e9b53: examples/vhost_scsi: introduce a new sample app (2017-07-19 22:49:47 +0300) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to cb78ef9859ff68b9e260a8

[dpdk-dev] [PATCH v2] net/ixgbe: net/ixgbe: fix sctp port support limitation

2017-07-19 Thread Qi Zhang
Only x550 family support sctp port in fdir filter, so add this limiation when parse consistent API. Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- v2: - rebase to next-net drivers/net/ixgbe/ixgbe_flow.c | 57 +++

Re: [dpdk-dev] [PATCH] jobstats: fix a typo in rte_jobstats.h.

2017-07-19 Thread Thomas Monjalon
19/07/2017 23:06, Rami Rosen: > This patch fixes a trivial typo in rte_jobstats.h. > > Signed-off-by: Rami Rosen Applied, thanks

Re: [dpdk-dev] [PATCH] devargs: restore rte_devtype API

2017-07-19 Thread Thomas Monjalon
15/07/2017 20:59, Gaetan Rivet: > Revert "devargs: make device types generic" > > This commit broke the rte_devargs API by changing the meaning of > the rte_devtype enum. > > Restore the previous API, unit tests and function calls. > Introduce parallel enum that acts as translation between previo

Re: [dpdk-dev] [PATCH v4 0/8] fix hotplug API

2017-07-19 Thread Thomas Monjalon
15/07/2017 20:56, Gaetan Rivet: > Sending those fixes as separate patches as they stand on their own. > This series improves usability of the hotplug API and fixes a few issues > with existing implementations. > > The hotplug API can be tested with the fail-safe PMD[1]. Its > documentation describ

Re: [dpdk-dev] [PATCH] doc/metrics: fix variable undefined error

2017-07-19 Thread Thomas Monjalon
18/07/2017 16:10, Remy Horton: > On 18/07/2017 13:03, Yong Wang wrote: > > Signed-off-by: Yong Wang > > Acked-by: Remy Horton Applied, thanks

Re: [dpdk-dev] Occasional instability in RSS Hashes/Queues from X540 NIC

2017-07-19 Thread Li, Xiaoyun
Hi, Yuanhan ! I did the same tests on DPDK 16.11 this morning and cannot reproduce the problem on 16.11. It seems that the problem has been fixed on version 16.11. So could you reproduce the problem on 16.11 LTS release? I think maybe it has been fixed already. Best regards Xiaoyun Li -Orig

[dpdk-dev] [PATCH] jobstats: fix a typo in rte_jobstats.h.

2017-07-19 Thread Rami Rosen
This patch fixes a trivial typo in rte_jobstats.h. Signed-off-by: Rami Rosen --- lib/librte_jobstats/rte_jobstats.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_jobstats/rte_jobstats.h b/lib/librte_jobstats/rte_jobstats.h index b3686030e820..7e76fd50c6fa 100644

Re: [dpdk-dev] [PATCH v5] examples/vhost: introduce a new vhost-user-scsi sample application

2017-07-19 Thread Yuanhan Liu
On Thu, Jul 20, 2017 at 05:16:29PM +0800, Changpeng Liu wrote: > vhost-user protocol is common to many virtio devices, such as > virtio_net/virtio_scsi/virtio_blk. Since DPDK vhost library > removed the NET specific data structures, the vhost library > is common to other virtio devices, such as vir

Re: [dpdk-dev] Rx Can't receive anymore packet after received 1.5 billion packet.

2017-07-19 Thread Dumitrescu, Cristian
> -Original Message- > From: vuon...@viettel.com.vn [mailto:vuon...@viettel.com.vn] > Sent: Tuesday, July 18, 2017 2:37 AM > To: Dumitrescu, Cristian > Cc: us...@dpdk.org; dev@dpdk.org > Subject: Re: [dpdk-dev] Rx Can't receive anymore packet after received 1.5 > billion packet. > > >

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-19 Thread Gregory Etelson
On Wednesday, 19 July 2017 16:32:34 IDT Ferruh Yigit wrote: > On 7/12/2017 4:40 AM, Tan, Jianfeng wrote: > > > > > >> -Original Message- > >> From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > >> Sent: Friday, July 7, 2017 7:14 PM > >> To: dev@dpdk.org > >> Cc: Yigit, Fe

Re: [dpdk-dev] [PATCH v1] metrics: fix missing NULL termination

2017-07-19 Thread Thomas Monjalon
18/07/2017 12:43, Remy Horton: > The public API (struct rte_metric_name) includes the NULL terminator > byte in RTE_METRICS_MAX_NAME_LENGTH but the library itself internally > excludes it. This makes it possible for an application to receive an > unterminated name string. Fix be enforcing the NULL

Re: [dpdk-dev] [PATCH] net/virtio: fix fail to configure rxq interrupt

2017-07-19 Thread Tan, Jianfeng
On 7/19/2017 4:08 AM, Yuanhan Liu wrote: On Wed, Jul 19, 2017 at 11:18:23AM +0800, Jiayu Hu wrote: When use rte_eth_dev_configure() to enable rx queue interrupt for virtio devices, virtio_configure_intr() isn't called to set up the interrupt environment, which causes rx queue interrupt setup f

[dpdk-dev] [pull-request] next-net 17.08 RC2

2017-07-19 Thread Ferruh Yigit
The following changes since commit 838d6b775bfab436859764ea734cddaf95c7b5fd: mbuf: fix VXLAN port in comment (2017-07-19 09:17:35 +0300) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-net for you to fetch changes up to 283fd29236f4e4fde25cc9a1540a224ce0326ea1:

Re: [dpdk-dev] [PATCH v2 2/3] testpmd: add cmndlines to support different aggregation modes

2017-07-19 Thread Ferruh Yigit
On 7/19/2017 3:46 PM, Daniel Mrzyglod wrote: > This patch add support for different aggregator modes in similar manner > that is provided in linux kernel. > > testpmd> set bonding agg_mode > testpmd> show bonding config > > Signed-off-by: Daniel Mrzyglod I got this as it is, to be able to in

Re: [dpdk-dev] [PATCH v2 0/3] Bonding add additional aggregators mode for 802.3AD

2017-07-19 Thread Ferruh Yigit
On 7/19/2017 3:31 PM, Daniel Mrzyglod wrote: > This patchseries add support for other aggregators in similar manner > that is provided in Linux kernel. > > Modes added in patches: > stable - this is default mode from IEEE802.11AX/IEEE802.3AD documentation > bandwidth - takes aggregator with the bi

Re: [dpdk-dev] [PATCH v2 3/3] test/bonding: add test case for agg selection in mode4

2017-07-19 Thread Declan Doherty
On 19/07/2017 3:54 PM, Daniel Mrzyglod wrote: Signed-off-by: Daniel Mrzyglod --- ... Acked-by: Declan Doherty

Re: [dpdk-dev] [PATCH v2 2/3] testpmd: add cmndlines to support different aggregation modes

2017-07-19 Thread Declan Doherty
On 19/07/2017 3:46 PM, Daniel Mrzyglod wrote: This patch add support for different aggregator modes in similar manner that is provided in linux kernel. testpmd> set bonding agg_mode testpmd> show bonding config Signed-off-by: Daniel Mrzyglod --- ... Acked-by: Declan Doherty

Re: [dpdk-dev] [PATCH v2 1/3] drivers/bonding: add other agg selection modes

2017-07-19 Thread Declan Doherty
On 19/07/2017 3:31 PM, Daniel Mrzyglod wrote: This patch add support for setting additional aggregator modes for IEEE802.3AD in similar manner that are supported in kernel mode. This will add support for other manner: stable - default mode taken from IEEE802.11AX this is default aggregator mode

[dpdk-dev] [PATCH v2 3/3] test/bonding: add test case for agg selection in mode4

2017-07-19 Thread Daniel Mrzyglod
Signed-off-by: Daniel Mrzyglod --- test/test/test_link_bonding_mode4.c | 83 +++-- 1 file changed, 79 insertions(+), 4 deletions(-) diff --git a/test/test/test_link_bonding_mode4.c b/test/test/test_link_bonding_mode4.c index 8b64bbf71..8e9e23db5 100644 --- a/test

[dpdk-dev] [PATCH v2 2/3] testpmd: add cmndlines to support different aggregation modes

2017-07-19 Thread Daniel Mrzyglod
This patch add support for different aggregator modes in similar manner that is provided in linux kernel. testpmd> set bonding agg_mode testpmd> show bonding config Signed-off-by: Daniel Mrzyglod --- app/test-pmd/cmdline.c | 94 +- 1 file chang

[dpdk-dev] [pull-request] next-crypto 17.08 rc2

2017-07-19 Thread Pablo de Lara
The following changes since commit 838d6b775bfab436859764ea734cddaf95c7b5fd: mbuf: fix VXLAN port in comment (2017-07-19 09:17:35 +0300) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to 488587bb9a327f195379ced5650043189d05584d

Re: [dpdk-dev] [PATCH] event/dpaa2: advertise the burst mode capability

2017-07-19 Thread Jerin Jacob
-Original Message- > Date: Wed, 19 Jul 2017 19:48:32 +0530 > From: Nipun Gupta > To: dev@dpdk.org > CC: hemant.agar...@nxp.com, jerin.ja...@caviumnetworks.com, > tho...@monjalon.net, Nipun Gupta > Subject: [PATCH] event/dpaa2: advertise the burst mode capability > X-Mailer: git-send-emai

Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: add option --[no-]mac-updating

2017-07-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Wednesday, July 19, 2017 2:17 PM > To: Kozak, KubaX ; dev@dpdk.org > Cc: Jain, Deepak K ; Jastrzebski, MichalX K > > Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: add opti

Re: [dpdk-dev] [PATCH] crypto/qat: fix session initialization

2017-07-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Wednesday, July 19, 2017 3:06 PM > To: De Lara Guarch, Pablo ; Jain, Deepak K > ; Griffin, John > Cc: dev@dpdk.org; Trahe, Fiona > Subject: RE: [PATCH] crypto/qat: fix session initialization > > > > > -Original Message- > > Fr

Re: [dpdk-dev] [PATCH v7 0/5] Support NIC reset and keep same port id

2017-07-19 Thread Dai, Wei
Remy is a Native English speaker. He will help me review my v8 patch set. Thank you, Remy. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, July 17, 2017 3:26 AM > To: Dai, Wei > Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, > Konstantin ; Wu, Jingjing

Re: [dpdk-dev] [PATCH] cryptodev: remove crypto operation status value

2017-07-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Declan Doherty > Sent: Wednesday, July 19, 2017 3:00 PM > To: Rybalchenko, Kirill ; Zhang, Roy Fan > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] cryptodev: remove crypto operation status > value > > On

Re: [dpdk-dev] [PATCH v1] crypto/scheduler: fix multicore scheduler reordering

2017-07-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Declan Doherty > Sent: Wednesday, July 19, 2017 3:03 PM > To: Rybalchenko, Kirill ; Zhang, Roy Fan > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] crypto/scheduler: fix multicore > scheduler reordering

[dpdk-dev] [PATCH v2 1/3] drivers/bonding: add other agg selection modes

2017-07-19 Thread Daniel Mrzyglod
This patch add support for setting additional aggregator modes for IEEE802.3AD in similar manner that are supported in kernel mode. This will add support for other manner: stable - default mode taken from IEEE802.11AX this is default aggregator mode bandwidth - takes aggregator with highest bandwi

[dpdk-dev] [PATCH v2 0/3] Bonding add additional aggregators mode for 802.3AD

2017-07-19 Thread Daniel Mrzyglod
This patchseries add support for other aggregators in similar manner that is provided in Linux kernel. Modes added in patches: stable - this is default mode from IEEE802.11AX/IEEE802.3AD documentation bandwidth - takes aggregator with the biggest available speed count - takes aggregators with the

[dpdk-dev] [PATCH] event/dpaa2: advertise the burst mode capability

2017-07-19 Thread Nipun Gupta
Burst mode capability flag was introduced in 73e6b8c9 for event drivers. DPAA2 event driver supports burst mode so this patch adds this capability flag in DPAA2 event driver Signed-off-by: Nipun Gupta --- drivers/event/dpaa2/dpaa2_eventdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-

Re: [dpdk-dev] [PATCH] crypto/qat: fix session initialization

2017-07-19 Thread Trahe, Fiona
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, July 19, 2017 5:59 AM > To: Trahe, Fiona ; Jain, Deepak K > ; Griffin, John > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] crypto/qat: fix session initialization > > When creating a session, if there

Re: [dpdk-dev] [PATCH v1] crypto/scheduler: fix multicore scheduler reordering

2017-07-19 Thread Declan Doherty
On 18/07/2017 11:35 AM, Kirill Rybalchenko wrote: Operations can be dequeued from the reordering ring only after they were dequeued from the crypto pmd with rte_cryptodev_dequeue_burst() function. It is not correct to dequeue them when status just changed from RTE_CRYPTO_OP_STATUS_NOT_PROCESSED t

Re: [dpdk-dev] [PATCH] cryptodev: remove crypto operation status value

2017-07-19 Thread Declan Doherty
On 17/07/2017 4:25 PM, Kirill Rybalchenko wrote: Crypto operation status RTE_CRYPTO_OP_STATUS_ENQUEUED is removed from rte_crypto.h as it is not needed for crypto operation processing. This status value is redundant to RTE_CRYPTO_OP_STATUS_NOT_PROCESSED value and it was not intended to be part of

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-19 Thread Ferruh Yigit
On 7/12/2017 4:40 AM, Tan, Jianfeng wrote: > > >> -Original Message- >> From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] >> Sent: Friday, July 7, 2017 7:14 PM >> To: dev@dpdk.org >> Cc: Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; Stephen Hemminger; >> Tan, Jianfeng;

Re: [dpdk-dev] [PATCH v2 0/4] cryptodev vdev changes for -rc2

2017-07-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jan Blunck [mailto:jblu...@gmail.com] On Behalf Of Jan Blunck > Sent: Wednesday, July 12, 2017 8:59 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > > Subject: [PATCH v2 0/4] cryptodev vdev changes for -rc2 > > This series is a preparati

Re: [dpdk-dev] [PATCH] net/failsafe: fix compilation issues on GCC 4.8.5

2017-07-19 Thread Ferruh Yigit
On 7/19/2017 2:18 PM, Gaetan Rivet wrote: > Reintroduce the -pedantic flag to highlight those mistakes. > > Fixes: 57a089a5020f ("net/failsafe: add fail-safe PMD") > > Signed-off-by: Gaetan Rivet Squashed into relevant commit in next-net, thanks.

[dpdk-dev] [PATCH] net/failsafe: fix compilation issues on GCC 4.8.5

2017-07-19 Thread Gaetan Rivet
Reintroduce the -pedantic flag to highlight those mistakes. Fixes: 57a089a5020f ("net/failsafe: add fail-safe PMD") Signed-off-by: Gaetan Rivet --- drivers/net/failsafe/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/failsafe/Makefile b/drivers/net/failsafe/Makefile

Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: add option --[no-]mac-updating

2017-07-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: Kozak, KubaX > Sent: Wednesday, July 19, 2017 1:20 PM > To: dev@dpdk.org > Cc: Jain, Deepak K ; De Lara Guarch, Pablo > ; Jastrzebski, MichalX K > ; Kozak, KubaX > > Subject: [PATCH] examples/l2fwd-crypto: add option --[no-]mac-updating > > This patch adds a

[dpdk-dev] [PATCH] crypto/qat: fix session initialization

2017-07-19 Thread Pablo de Lara
When creating a session, if there is a failure when setting some of the parameters, QAT was not propagating the error to the session initialization function. Therefore, it was reporting a success, when it should be report a failure. Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessi

Re: [dpdk-dev] [PATCH v2] eal/armv8: fix poly64/128 compile issue in old GCC(<4.9.0)

2017-07-19 Thread Thomas Monjalon
19/07/2017 11:21, Herbert Guan: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 13/07/2017 05:16, Herbert Guan: > > > --- a/lib/librte_eal/common/include/arch/arm/rte_vect.h > > > +++ b/lib/librte_eal/common/include/arch/arm/rte_vect.h > > > +#if (GCC_VERSION < 40900) > > > +typedef uint64

[dpdk-dev] [PATCH] examples/l2fwd-crypto: add option --[no-]mac-updating

2017-07-19 Thread Kuba Kozak
This patch adds a new option to enable/disable the MAC addresses updating done at forwarding time: --[no-]mac-updating By default, MAC address updating remains enabled, to keep consistency with previous usage. Signed-off-by: Kuba Kozak --- doc/guides/sample_app_ug/l2_forward_crypto.rst | 7 ++-

Re: [dpdk-dev] [PATCH v2] crypto/dpaa2_sec: fix the return of supported API

2017-07-19 Thread Yuanhan Liu
On Tue, Jul 18, 2017 at 05:32:44PM +, Hemant Agrawal wrote: > > > > > Subject: [PATCH v2] crypto/dpaa2_sec: fix the return of supported > > > > > API > > > > > > > > > > call to dpaa2_sec_dev_configure() is made mandatory, but > > > > > dpaa2_sec_pmd returns a ENOTSUP which results in device no

Re: [dpdk-dev] [PATCH v2] net/i40e: vf add/del mac error log issue

2017-07-19 Thread Ferruh Yigit
On 7/19/2017 12:11 PM, Xing, Beilei wrote: > > >> -Original Message- >> From: Guo, Jia >> Sent: Wednesday, July 19, 2017 5:01 PM >> To: Xing, Beilei ; Wu, Jingjing >> >> Cc: dev@dpdk.org; Guo, Jia >> Subject: [PATCH v2] net/i40e: vf add/del mac error log issue >> >> when i40e vf close,

Re: [dpdk-dev] [PATCH v2] net/i40e: vf add/del mac error log issue

2017-07-19 Thread Xing, Beilei
> -Original Message- > From: Guo, Jia > Sent: Wednesday, July 19, 2017 5:01 PM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org; Guo, Jia > Subject: [PATCH v2] net/i40e: vf add/del mac error log issue > > when i40e vf close, it would stop vf at first, if vf had been stopped, that >

Re: [dpdk-dev] [PATCH] net/virtio: fix fail to configure rxq interrupt

2017-07-19 Thread Yuanhan Liu
On Wed, Jul 19, 2017 at 11:18:23AM +0800, Jiayu Hu wrote: > When use rte_eth_dev_configure() to enable rx queue interrupt for virtio > devices, virtio_configure_intr() isn't called to set up the interrupt > environment, which causes rx queue interrupt setup failed. This patch is > to fix this issue

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/crypto-perf: stop crypto devices after test is finished

2017-07-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of De Lara > Guarch, Pablo > Sent: Wednesday, July 19, 2017 11:58 AM > To: Rybalchenko, Kirill ; Doherty, Declan > > Cc: dev@dpdk.org; Rybalchenko, Kirill ; > sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATC

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/crypto-perf: stop crypto devices after test is finished

2017-07-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Kirill > Rybalchenko > Sent: Wednesday, June 14, 2017 9:44 AM > To: Doherty, Declan > Cc: dev@dpdk.org; Rybalchenko, Kirill ; > sta...@dpdk.org > Subject: [dpdk-stable] [PATCH] app/crypto-perf: stop crypto

Re: [dpdk-dev] Occasional instability in RSS Hashes/Queues from X540 NIC

2017-07-19 Thread Yuanhan Liu
On Wed, Jul 19, 2017 at 08:13:02AM +, Li, Xiaoyun wrote: > Hi, Yuanhan ! > I did the same tests on DPDK 16.11 this morning and cannot reproduce the > problem on 16.11. It seems that the problem has been fixed on version 16.11. Good to know. --yliu > So could you reproduce the proble

Re: [dpdk-dev] [PATCH] all: refactor coding style

2017-07-19 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tiwei Bie > Sent: Wednesday, July 19, 2017 10:07 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net > Subject: [dpdk-dev] [PATCH] all: refactor coding style > > Remove the unwanted spaces before `;' across DPDK sour

Re: [dpdk-dev] [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000

2017-07-19 Thread Ferruh Yigit
On 6/26/2017 10:42 AM, Radu Nicolau wrote: > From: Michal Jastrzebski > > If-MIB xstats: > ifNumber > ifIndex > ifType > ifMtu > ifSpeed > ifPhysAddress > ifOperStatus > ifLastChange > ifHighSpeed > ifConnectorPresent > ifCounterDiscontinuityTime > > EtherLike-MIB xstats: > dot3PauseOperMode > d

Re: [dpdk-dev] [PATCH] all: refactor coding style

2017-07-19 Thread Tiwei Bie
On Wed, Jul 19, 2017 at 05:24:38PM +0800, Van Haaren, Harry wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tiwei Bie > > Sent: Wednesday, July 19, 2017 10:07 AM > > To: dev@dpdk.org > > Cc: tho...@monjalon.net > > Subject: [dpdk-dev] [PATCH] all: refactor coding style > > > > Remo

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices

2017-07-19 Thread Ferruh Yigit
On 7/19/2017 10:22 AM, Dai, Wei wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang >> Sent: Tuesday, July 18, 2017 10:29 AM >> To: dev@dpdk.org >> Cc: sta...@dpdk.org; Lu, Wenzhuo ; Yang, Qiming >> >> Subject: [dpdk-dev] [PATCH v2] net/ix

Re: [dpdk-dev] [PATCH] all: refactor coding style

2017-07-19 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tiwei Bie > Sent: Wednesday, July 19, 2017 10:07 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net > Subject: [dpdk-dev] [PATCH] all: refactor coding style > > Remove the unwanted spaces before `;' across DPDK source code > by below one-liner wi

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices

2017-07-19 Thread Dai, Wei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Tuesday, July 18, 2017 10:29 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Lu, Wenzhuo ; Yang, Qiming > > Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix Rx/Tx queue interrupt for x550 > devices

Re: [dpdk-dev] [PATCH] net/ixgbe: fix NIC 82599ES type check error

2017-07-19 Thread Ferruh Yigit
On 7/19/2017 4:33 AM, Wei Zhao wrote: > This NIC type check is specific for 82599ES. > > Fixes: 16f534e508d ("net/ixgbe: add support 82599ES SCTP packet drop action") > > Signed-off-by: Wei Zhao Squashed into relevant commit in next-net, thanks.

[dpdk-dev] [PATCH] all: refactor coding style

2017-07-19 Thread Tiwei Bie
Remove the unwanted spaces before `;' across DPDK source code by below one-liner with some minor manual refinements. find . -name '*.[ch]' | xargs sed -i 's/\([^;(]\) \+;/\1;/g' The fixes for cmdline library are skipped, because it has a different coding style. It deserves a separate cleanup if n

[dpdk-dev] [PATCH v2] net/i40e: vf add/del mac error log issue

2017-07-19 Thread Jeff Guo
when i40e vf close, it would stop vf at first, if vf had been stopped, that would result of duplicating to add/del mac address, then the failed of executing admin queue command info would exposure. The patch fix that by add vf stop status check and sync up the vf mac number when add/del. Signed-of

[dpdk-dev] [PATCH v5] examples/vhost: introduce a new vhost-user-scsi sample application

2017-07-19 Thread Changpeng Liu
vhost-user protocol is common to many virtio devices, such as virtio_net/virtio_scsi/virtio_blk. Since DPDK vhost library removed the NET specific data structures, the vhost library is common to other virtio devices, such as virtio-scsi. Here we introduce a simple memory based block device that ca

Re: [dpdk-dev] [PATCH v2] net/ixgbe: add queue index check in filter

2017-07-19 Thread Ferruh Yigit
On 7/19/2017 4:34 AM, Wei Zhao wrote: > Add queue index check when create filter rule, or > filter with invalid queue id can be created successfully. > > Signed-off-by: Wei Zhao Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH v5] ether: add support for vtune task tracing

2017-07-19 Thread ilia . kurakin
From: Ilia Kurakin The patch adds tracing of loop iterations that yielded no packets in a DPDK application. It is using ITT task API: https://software.intel.com/en-us/node/544206 We suppose the flow of using this tracing would assume the user has ITT lib and header on machine and re-build DP

Re: [dpdk-dev] [PATCH v2] eal/armv8: fix poly64/128 compile issue in old GCC(<4.9.0)

2017-07-19 Thread Herbert Guan
Thomas, Thanks a lot for your review and comment. But I have some concern in this approach. "poly128_t" is for ARM64 platform only and in fact it's more likely that rte_v128u8_t (generic DPDK data type) could be defined from poly128_t (ARM data type) which seems more reasonable. Best regards

[dpdk-dev] [PATCH v2] examples/load_balancer: enable the build for lesser lcores

2017-07-19 Thread Hemant Agrawal
load_balancer app can also work for lower number of cores. Limit the cores Worker and IO cores to 16 as defined in original App. Otherwise use the actual number of lcores as MAX. Signed-off-by: Hemant Agrawal --- v2: Revert back the condition check examples/load_balancer/main.h | 8 1

[dpdk-dev] [PATCH v3] examples/qos_sched: fix core limit for lower num of lcore

2017-07-19 Thread Hemant Agrawal
APP_MAX_LCORES is hardcoded as 64. This will cause build err when RTE_MAX_LCORE is less then 64. "args.c:127:22: error: iteration 8 invokes undefined behavior [-Werror=aggressive-loop-optimizations] if (cfg->lcore_role[i] == ROLE_RTE) ~~~^~~ args.c:126:2: note: within

Re: [dpdk-dev] Occasional instability in RSS Hashes/Queues from X540 NIC

2017-07-19 Thread Li, Xiaoyun
Hi, Yuanhan ! I did the same tests on DPDK 16.11 this morning and cannot reproduce the problem on 16.11. It seems that the problem has been fixed on version 16.11. So could you reproduce the problem on 16.11 LTS release? I think maybe it has been fixed already. Best Regards, Xiaoyun Li -

Re: [dpdk-dev] [PATCH 0/3] L2fwd-crypto fixes

2017-07-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, July 18, 2017 8:58 AM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > Subject: [PATCH 0/3] L2fwd-crypto fixes > > After the changes added to include AEAD algorithm specific parameters, > there were

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] examples/qos_sched: fix core limit for lower num of lcore

2017-07-19 Thread Hemant Agrawal
On 7/19/2017 10:54 AM, Thomas Monjalon wrote: 17/07/2017 11:37, Hemant Agrawal: --- a/examples/qos_sched/main.h +++ b/examples/qos_sched/main.h @@ -69,8 +69,13 @@ extern "C" { #define BURST_TX_DRAIN_US 100 #ifndef APP_MAX_LCORE +#if (APP_MAX_LCORE > 64) #define APP_MAX_LCORE 64 If APP_MAX_

Re: [dpdk-dev] [PATCH] examples/load_balancer: enable the build for lesser lcores

2017-07-19 Thread Hemant Agrawal
On 7/19/2017 10:51 AM, Thomas Monjalon wrote: 17/07/2017 11:41, Hemant Agrawal: --- a/examples/load_balancer/main.h +++ b/examples/load_balancer/main.h #ifndef APP_MAX_IO_LCORES +#if (APP_MAX_LCORES > 16) #define APP_MAX_IO_LCORES 16 +#else +#define APP_MAX_IO_LCORES APP_MAX_LCORES #endif -#i

Re: [dpdk-dev] [dpdk-stable] [PATCH] mbuf: fix comment about vxlan destination port used

2017-07-19 Thread Thomas Monjalon
10/07/2017 15:33, Olivier Matz: > On Fri, 7 Jul 2017 15:17:40 +0100, Cian Ferriter > wrote: > > IANA assigns a destination port of 4789 for the VXLAN in the Service > > Name and Transport Protocol Port Number Registry. This is mentioned in > > RFC 7348. > > > > Signed-off-by: Cian Ferriter >