Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

2017-07-12 Thread Thomas Monjalon
12/07/2017 23:59, Stephen Hemminger: > On Tue, 11 Jul 2017 22:33:55 +0200 > Thomas Monjalon wrote: > > > Thank you for this script, but... it is written in Perl! > > I don't think it is a good idea to add yet another language to DPDK. > > We already have shell and python scripts. > > And I am not

Re: [dpdk-dev] [PATCH] net/failsafe: do not probe device if plugged out

2017-07-12 Thread Thomas Monjalon
12/07/2017 22:39, Gaëtan Rivet: > Hi Thomas, > > Nice idea. A few remarks below: > > On Wed, Jul 12, 2017 at 08:28:12PM +0200, Thomas Monjalon wrote: > > FOREACH_SUBDEV(sdev, i, dev) { > > if (sdev->state != DEV_PARSED) > > continue; > > da = &sdev-

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-07-12 Thread Rao, Nikhil
On 7/10/2017 4:11 PM, Jerin Jacob wrote: -Original Message- I also think that the application should be able to call create() with > 1 ports. This would allow a single service to poll multiple NICs with WRR priority. Good point. Can we realize the same use case like below? - Instead

Re: [dpdk-dev] [PATCH] ARMv8: Use built-in data types for unsupported poly64/128 types for GCC version lower than 4.9.0.

2017-07-12 Thread Herbert Guan
Thank, Jerin. I've fixed the git-log warnings and raised a v2 patch just now. Best Regards, Herbert -Original Message- From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] Sent: Thursday, July 13, 2017 1:45 To: Herbert Guan Cc: dev@dpdk.org; jianbo@linaro.org Subject: Re: [PATC

[dpdk-dev] [PATCH v2] eal/armv8: fix poly64/128 compile issue in old GCC(<4.9.0)

2017-07-12 Thread Herbert Guan
Use built-in data types for unsupported poly64/128 types for GCC version lower than 4.9.0 Fixes: 3c4b4024c225 ("arch/arm: add vcopyq_laneq_u32 for old gcc") Signed-off-by: Herbert Guan --- lib/librte_eal/common/include/arch/arm/rte_vect.h | 7 +++ 1 file changed, 7 insertions(+) diff --git

[dpdk-dev] [PATCH] net/mlx5: change start pointer of compressed completion

2017-07-12 Thread Yongseok Koh
On a host having 128B cacheline size, some devices insert 64B padding in each completion entry to avoid partial cacheline write by HW. But, as the padding is ahead of completion data, casting a completion entry to compressed mini-completions must start from the middle of the completion. Signed-off

Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

2017-07-12 Thread Stephen Hemminger
On Tue, 11 Jul 2017 22:33:55 +0200 Thomas Monjalon wrote: > Thank you for this script, but... it is written in Perl! > I don't think it is a good idea to add yet another language to DPDK. > We already have shell and python scripts. > And I am not sure a lot of (young) people are able to parse it

Re: [dpdk-dev] [PATCH] net/failsafe: do not probe device if plugged out

2017-07-12 Thread Gaëtan Rivet
Hi Thomas, Nice idea. A few remarks below: On Wed, Jul 12, 2017 at 08:28:12PM +0200, Thomas Monjalon wrote: > When probing a sub-devices which does not exist in the system, > some errors are logged: > EAL: Cannot find unplugged device (0002:00:02.0) > PMD: net_failsafe: ERROR: sub_dev

[dpdk-dev] [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev()

2017-07-12 Thread Jan Blunck
This function is an alias for rte_vdev_init() which is scheduled to move out of the rte_eal library. Lets deprecate this function to be able to remove it from the cryptodev library in 17.11. Signed-off-by: Jan Blunck --- doc/guides/rel_notes/deprecation.rst | 5 + lib/librte_cryptodev/rte_cr

[dpdk-dev] [PATCH v2 4/4] cryptodev: move parameter parsing to its own header

2017-07-12 Thread Jan Blunck
This moves the parameter parsing functions out of the rte_cryptodev_vdev.h header to not require the rte_vdev.h header at build time of the library. Signed-off-by: Jan Blunck --- lib/librte_cryptodev/Makefile| 1 + lib/librte_cryptodev/rte_cryptodev_pmd.c | 2 +- li

[dpdk-dev] [PATCH v2 3/4] cryptodev: rework PMD init to not require rte_vdev.h

2017-07-12 Thread Jan Blunck
The rte_cryptodev_vdev_pmd_init() is a helper for vdev-based drivers. By moving the helper to the header we don't require rte_vdev.h at build-time of the librte_cryptodev library. This is a preparation to move the vdev bus into a standalone library. Signed-off-by: Jan Blunck --- lib/librte_crypt

[dpdk-dev] [PATCH v2 1/4] cryptodev: remove obsolete include

2017-07-12 Thread Jan Blunck
Signed-off-by: Jan Blunck Acked-by: Pablo de Lara --- lib/librte_cryptodev/rte_cryptodev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index 1d975e5f9..2048d6e29 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h

[dpdk-dev] [PATCH v2 2/4] cryptodev: move initialization

2017-07-12 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_cryptodev/rte_cryptodev.c | 3 +++ lib/librte_cryptodev/rte_cryptodev_pmd.c | 6 -- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 8ee5d47a9..09e4671

[dpdk-dev] [PATCH v2 0/4] cryptodev vdev changes for -rc2

2017-07-12 Thread Jan Blunck
This series is a preparation to move the vdev bus out of librte_eal. For that the newly added cryptodev vdev functions need to change signature to not require the rte_vdev.h header. Changes since v1: - move params parsing into new header - make rte_cryptodev_vdev_pmd_init() static inline Jan Blun

[dpdk-dev] [PATCH] net/failsafe: do not probe device if plugged out

2017-07-12 Thread Thomas Monjalon
When probing a sub-devices which does not exist in the system, some errors are logged: EAL: Cannot find unplugged device (0002:00:02.0) PMD: net_failsafe: ERROR: sub_device 0 probe failed It is normal to have these errors when initializing the failsafe device and its sub-devices. B

Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port andnbsegments

2017-07-12 Thread Wiles, Keith
> On Jul 12, 2017, at 11:23 AM, Thomas Monjalon wrote: > > 12/07/2017 17:57, Morten Brørup: >> From: Stephen Hemminger >>> Morten Brørup wrote: From: Yang, Zhiyong [mailto:zhiyong.y...@intel.com] > From: Morten Brørup >> From: Wiles, Keith On Jul 11, 2017, at 10:23 AM, Mor

Re: [dpdk-dev] [RFC 3/3] rte_flow: add new action for traffic metering and policing

2017-07-12 Thread Dumitrescu, Cristian
Hi Adrien, > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Monday, July 10, 2017 4:21 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; tho...@monjalon.net; > jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; Doherty, > Declan ; Wiles, Keith

Re: [dpdk-dev] [PATCH] ARMv8: Use built-in data types for unsupported poly64/128 types for GCC version lower than 4.9.0.

2017-07-12 Thread Jerin Jacob
-Original Message- > Date: Wed, 12 Jul 2017 18:50:19 +0800 > From: Herbert Guan > To: dev@dpdk.org, jerin.ja...@caviumnetworks.com, jianbo@linaro.org > CC: Herbert Guan > Subject: [PATCH] ARMv8: Use built-in data types for unsupported poly64/128 > types for GCC version lower than 4.9

Re: [dpdk-dev] [PATCH v3 4/8] eal: fix hotplug add / remove

2017-07-12 Thread Gaëtan Rivet
On Wed, Jul 12, 2017 at 04:44:28AM -0400, Jan Blunck wrote: > On Tue, Jul 11, 2017 at 7:25 PM, Gaetan Rivet wrote: > > The hotplug API requires a few properties that were not previously > > explicitly enforced: > > > > - Idempotency, two consecutive scans should result in the same state. > > -

Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1

2017-07-12 Thread Thomas Monjalon
11/07/2017 20:20, Dumitrescu, Cristian: > Hi Thomas, > > Fixed everything you asked on the next-tm repository, please resume the pull. > > I am working to send documentation as separate patch most likely next week. > > Changes: > 1. rte_ethdev.[hc]: removed unused function rte_eth_dev_tm_ops_ge

Re: [dpdk-dev] [PATCH v3 2/8] devargs: introduce removal function

2017-07-12 Thread Gaëtan Rivet
On Wed, Jul 12, 2017 at 04:27:34AM -0400, Jan Blunck wrote: > On Tue, Jul 11, 2017 at 7:25 PM, Gaetan Rivet wrote: > > Hotplug support introduces the possibility of removing devices from the > > system. Allocated resources must be freed. > > > > Extend the rte_devargs API to allow freeing allocate

Re: [dpdk-dev] [PATCH v3 3/8] devargs: introduce insert function

2017-07-12 Thread Gaëtan Rivet
On Wed, Jul 12, 2017 at 04:20:48AM -0400, Jan Blunck wrote: > On Tue, Jul 11, 2017 at 7:25 PM, Gaetan Rivet wrote: > > Some buses will operate either in whitelist or blacklist mode. > > This mode is currently passed down by the rte_eal_devargs_add function > > with the devtype argument. > > > > Wh

Re: [dpdk-dev] [PATCH v5 0/7] service cores: cover letter

2017-07-12 Thread Jerin Jacob
-Original Message- > Date: Tue, 11 Jul 2017 15:19:26 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: tho...@monjalon.net, jerin.ja...@caviumnetworks.com, > keith.wi...@intel.com, bruce.richard...@intel.com, Harry van Haaren > > Subject: [PATCH v5 0/7] service cores: cover letter

Re: [dpdk-dev] [PATCH v5 1/7] service cores: header and implementation

2017-07-12 Thread Jerin Jacob
-Original Message- > Date: Tue, 11 Jul 2017 15:19:27 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: tho...@monjalon.net, jerin.ja...@caviumnetworks.com, > keith.wi...@intel.com, bruce.richard...@intel.com, Harry van Haaren > > Subject: [PATCH v5 1/7] service cores: header and i

Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port andnbsegments

2017-07-12 Thread Thomas Monjalon
12/07/2017 17:57, Morten Brørup: > From: Stephen Hemminger > > Morten Brørup wrote: > > > From: Yang, Zhiyong [mailto:zhiyong.y...@intel.com] > > > > From: Morten Brørup > > > > > From: Wiles, Keith > > > > > > > On Jul 11, 2017, at 10:23 AM, Morten Brørup wrote: > > > > > > > From: Thomas Monjalo

Re: [dpdk-dev] [PATCH v2] doc: add missing devices in test-crypto-perf

2017-07-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, July 12, 2017 4:13 PM > To: dev@dpdk.org > Cc: hemant.agra...@nxp.com; De Lara Guarch, Pablo > ; Doherty, Declan > ; Akhil Goyal > Subject: [PATCH v2] doc: add missing devices in test-crypto-perf >

Re: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of NIC reset

2017-07-12 Thread Jerin Jacob
-Original Message- > Date: Tue, 11 Jul 2017 14:36:57 + > From: "Dai, Wei" > To: Jerin Jacob > CC: "tho...@monjalon.net" , "Lu, Wenzhuo" > , "Ananyev, Konstantin" > , "Wu, Jingjing" , > "Xing, Beilei" , "dev@dpdk.org" > Subject: RE: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of

Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port andnbsegments

2017-07-12 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Wednesday, July 12, 2017 5:36 PM > To: Morten Brørup > Cc: Yang, Zhiyong; Wiles, Keith; Thomas Monjalon; DPDK; Olivier Matz; > Wang, Zhihong; Yuanhan Liu; Ananyev, Konstantin; Richardson, B

Re: [dpdk-dev] [PATCH] ARMv8: Use built-in data types for unsupported poly64/128 types for GCC version lower than 4.9.0.

2017-07-12 Thread Jianbo Liu
On 12 July 2017 at 18:50, Herbert Guan wrote: > Fixes: 3c4b4024c2 (arch/arm: add vcopyq_laneq_u32 for old gcc) > > Signed-off-by: Herbert Guan > --- > lib/librte_eal/common/include/arch/arm/rte_vect.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/lib/librte_eal/common/include/a

Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port andnbsegments

2017-07-12 Thread Stephen Hemminger
On Wed, 12 Jul 2017 11:50:38 +0200 Morten Brørup wrote: > > -Original Message- > > From: Yang, Zhiyong [mailto:zhiyong.y...@intel.com] > > Sent: Wednesday, July 12, 2017 11:02 AM > > To: Morten Brørup; Wiles, Keith > > Cc: Thomas Monjalon; DPDK; Olivier Matz; Wang, Zhihong; Yuanhan Liu; >

Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port and nbsegments

2017-07-12 Thread Wiles, Keith
> On Jul 12, 2017, at 2:25 AM, Morten Brørup wrote: > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wiles, Keith >> Sent: Tuesday, July 11, 2017 6:48 PM >> To: Morten Brørup >> Cc: Thomas Monjalon; DPDK; Olivier Matz; Wang, Zhihong; Yuanhan Liu; >> Ananyev

[dpdk-dev] [PATCH v2] doc: add missing devices in test-crypto-perf

2017-07-12 Thread Akhil Goyal
crypto_armv8, crypto_scheduler and crypto_dpaa2_sec are added in the documentation Signed-off-by: Akhil Goyal --- changes in v2: added crypto_armv8 and crypto_scheduler doc/guides/tools/cryptoperf.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/tools/cryptoperf.rst b/doc/g

Re: [dpdk-dev] [PATCH v3] examples/vhost: introduce a new vhost-user-scsi sample application

2017-07-12 Thread Wodkowski, PawelX
Hi, sorry for late review but just spotted this patch. Please see my comments > diff --git a/examples/vhost_scsi/scsi.c b/examples/vhost_scsi/scsi.c > new file mode 100644 > index 000..08dfe61 > --- /dev/null > +++ b/examples/vhost_scsi/scsi.c > @@ -0,0 +1,507 @@ > +static int > +vhost_hex2bi

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix the incorrect free usage for dpsec

2017-07-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, July 12, 2017 1:35 PM > To: dev@dpdk.org > Cc: hemant.agra...@nxp.com; De Lara Guarch, Pablo > ; Doherty, Declan > ; Akhil Goyal > Subject: [PATCH] crypto/dpaa2_sec: fix the incorrect free usage for

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix typo error in comments

2017-07-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, July 12, 2017 1:35 PM > To: dev@dpdk.org > Cc: hemant.agra...@nxp.com; De Lara Guarch, Pablo > ; Doherty, Declan > ; Akhil Goyal > Subject: [PATCH] crypto/dpaa2_sec: fix typo error in comments > > C

Re: [dpdk-dev] [PATCH] crypto/qat: fix NULL auth hang problem

2017-07-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Wednesday, July 12, 2017 1:56 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Griffin, John > ; Jain, Deepak K > Subject: RE: [PATCH] crypto/qat: fix NULL auth hang problem > > > > > -Original Message-

Re: [dpdk-dev] [PATCH] net/sfc: add support for xstats retrieval by ID

2017-07-12 Thread Andrew Rybchenko
On 07/12/2017 05:18 PM, Remy Horton wrote: On 08/07/2017 16:45, Andrew Rybchenko wrote: From: Ivan Malov Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko [..] Reviewed-by: Remy Horton +rc = sfc_port_update_mac_stats(sa); +if (rc != 0) { +SFC_ASSERT(rc > 0); +

Re: [dpdk-dev] [PATCH] net/sfc: add support for xstats retrieval by ID

2017-07-12 Thread Remy Horton
On 08/07/2017 16:45, Andrew Rybchenko wrote: From: Ivan Malov Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko [..] Reviewed-by: Remy Horton + rc = sfc_port_update_mac_stats(sa); + if (rc != 0) { + SFC_ASSERT(rc > 0); + ret = -rc; sfc_

[dpdk-dev] [PATCH] doc: add how to use packet capture framework

2017-07-12 Thread Reshma Pattan
Describes how to use pdump library and dpdk-pdump tool to capture traffic on dpdk ports. Signed-off-by: Reshma Pattan --- doc/guides/howto/img/packet_capture_framework.svg | 128 +++ doc/guides/howto/index.rst| 1 + doc/guides/howto/packet_capture_framew

Re: [dpdk-dev] [RFC 0/7] ipsec inline

2017-07-12 Thread Boris Pismenny
Hi Declan, > Hey Boris, we've been working on v2 of the RFC based on the feedback you > and others gave on our original , but as what we were going to propose > is largely inline with your proposal here, with one or 2 exceptions, > mainly on the IPsec SA management elements, I'll just comment here

[dpdk-dev] [PATCH] doc: add author on cc to git fixline alias

2017-07-12 Thread Harry van Haaren
With this commit, the correct method to use git fixline to indicate a fix of a previous commit has changed. The new rules require the author of the original code that is being fixed to be on CC. The logic behind this improvement is that if there is a genuine bug, one of the ideal people to review

Re: [dpdk-dev] [Process] Git Fixline Suggestion

2017-07-12 Thread Van Haaren, Harry
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, July 12, 2017 11:50 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [Process] Git Fixline Suggestion > > 12/07/2017 10:40, Van Haaren, Harry: > > Hi All, > > > > I propose to add CC: to the output of

Re: [dpdk-dev] [PATCH 2/2] cryptodev: rework cryptodev PMD init to not require rte_vdev.h

2017-07-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Wednesday, July 12, 2017 1:40 PM > To: Jan Blunck ; dev@dpdk.org > Cc: Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH 2/2] cryptodev: rework cryptodev PMD init > to not require r

Re: [dpdk-dev] [PATCH] app/crypto-perf: add minimise-offload-cost flag

2017-07-12 Thread Trahe, Fiona
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, May 9, 2017 5:14 PM > To: dev@dpdk.org; Mrozowicz, SlawomirX > Cc: Doherty, Declan ; Griffin, John > ; De Lara Guarch, > Pablo ; Trahe, Fiona > Subject: [PATCH] app/crypto-perf: add minimise-offload-cost flag > > The throughpu

Re: [dpdk-dev] [PATCH] crypto/qat: fix NULL auth hang problem

2017-07-12 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, April 21, 2017 9:12 AM > To: dev@dpdk.org > Cc: Trahe, Fiona ; De Lara Guarch, Pablo > ; > Griffin, John ; Jain, Deepak K > ; Kusztal, ArkadiuszX > > Subject: [PATCH] crypto/qat: fix NULL auth hang problem > > This commi

Re: [dpdk-dev] [PATCH] doc: add dpaa2-sec in test-crypto-perf

2017-07-12 Thread De Lara Guarch, Pablo
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, July 12, 2017 1:35 PM > To: dev@dpdk.org > Cc: hemant.agra...@nxp.com; De Lara Guarch, Pablo > ; Doherty, Declan > ; Akhil Goyal > Subject: [PATCH] doc: add dpaa2-sec in test-crypto-perf >

Re: [dpdk-dev] [PATCH] cryptodev: fix icc build

2017-07-12 Thread Thomas Monjalon
12/07/2017 12:09, Declan Doherty: > On 10/07/17 03:59, Pablo de Lara wrote: > > Removed unnecessary macro RTE_STD_C11, which is used > > for unnamed structs. > > Since there is no longer an unnamed structure in > > rte_cryptodev_sym_session, this is not needed and > > it is actually breaking compil

Re: [dpdk-dev] [PATCH 2/2] cryptodev: rework cryptodev PMD init to not require rte_vdev.h

2017-07-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jan Blunck > Sent: Wednesday, July 12, 2017 9:00 AM > To: dev@dpdk.org > Cc: Doherty, Declan > Subject: [dpdk-dev] [PATCH 2/2] cryptodev: rework cryptodev PMD init to > not require rte_vdev.h > > This reworks th

[dpdk-dev] [PATCH] crypto/dpaa2_sec: fix the incorrect free usage for dpsec

2017-07-12 Thread Akhil Goyal
dpseci is allocated using rte_calloc() but it is freed using free(). Fixing it to use rte_free() Fixes: e5cbdfc53765 ("crypto/dpaa2_sec: add basic operations") Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH] doc: add dpaa2-sec in test-crypto-perf

2017-07-12 Thread Akhil Goyal
Signed-off-by: Akhil Goyal --- doc/guides/tools/cryptoperf.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/tools/cryptoperf.rst b/doc/guides/tools/cryptoperf.rst index 075a2bc..f24c26e 100644 --- a/doc/guides/tools/cryptoperf.rst +++ b/doc/guides/tools/cryptoperf.rst @@ -186,6

[dpdk-dev] [PATCH] crypto/dpaa2_sec: fix typo error in comments

2017-07-12 Thread Akhil Goyal
Comment for device name is corrected. Also the name string is made similar to other pmds Fixes: a3277ad47feb ("cryptodev: remove crypto device driver name") Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

Re: [dpdk-dev] [PATCH 1/2] cryptodev: remove obsolete include

2017-07-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jan Blunck > Sent: Wednesday, July 12, 2017 9:00 AM > To: dev@dpdk.org > Cc: Doherty, Declan > Subject: [dpdk-dev] [PATCH 1/2] cryptodev: remove obsolete include > > Signed-off-by: Jan Blunck > --- > lib/librt

Re: [dpdk-dev] [PATCH v2 0/3] vdev patches for -rc2

2017-07-12 Thread Thomas Monjalon
12/07/2017 10:05, Gaëtan Rivet: > On Tue, Jul 11, 2017 at 07:15:45PM -0400, Jan Blunck wrote: > > Three trivial vdev patches for -rc2. Please review and apply. > > > > For the series: > Acked-by: Gaetan Rivet Applied, thanks

[dpdk-dev] [PATCH] ARMv8: Use built-in data types for unsupported poly64/128 types for GCC version lower than 4.9.0.

2017-07-12 Thread Herbert Guan
Fixes: 3c4b4024c2 (arch/arm: add vcopyq_laneq_u32 for old gcc) Signed-off-by: Herbert Guan --- lib/librte_eal/common/include/arch/arm/rte_vect.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/librte_eal/common/include/arch/arm/rte_vect.h b/lib/librte_eal/common/include/arch/arm/

Re: [dpdk-dev] [Process] Git Fixline Suggestion

2017-07-12 Thread Thomas Monjalon
12/07/2017 10:40, Van Haaren, Harry: > Hi All, > > I propose to add CC: to the output of the git fixline command[1]. > > The logic here is that if it is a fix to the previous code, the original > author of that code should be informed. Currently the author must read the > mailing-list carefull

Re: [dpdk-dev] [PATCH v2] test: Fix memory corruption issues which fails the link_bonding test.

2017-07-12 Thread Declan Doherty
On 10/07/17 12:13, Herbert Guan wrote: Patch V2: fix build warnings by deleting unused variables. There were double-free problems in some test cases, which will cause a duplicated mbuf will be added into mempool. After double-free, some new allocated mbuf will hold a same address and thus cause

Re: [dpdk-dev] [PATCH] test: Fix memory corruption issues which fails the link_bonding test.

2017-07-12 Thread Declan Doherty
On 12/07/17 10:59, Declan Doherty wrote: On 10/07/2017 8:20 AM, Herbert Guan wrote: ... Hey Herbert, I'm seeing compilation warnings for unused variables when I apply this patch, otherwise these changes look good. CC test_link_bonding.o /home/declan/Development/dpdk-org/master/test/test

Re: [dpdk-dev] [PATCH] cryptodev: fix icc build

2017-07-12 Thread Declan Doherty
On 10/07/17 03:59, Pablo de Lara wrote: Removed unnecessary macro RTE_STD_C11, which is used for unnamed structs. Since there is no longer an unnamed structure in rte_cryptodev_sym_session, this is not needed and it is actually breaking compilation on icc: lib/librte_cryptodev/rte_cryptodev.h(88

Re: [dpdk-dev] [PATCH] test: Fix memory corruption issues which fails the link_bonding test.

2017-07-12 Thread Declan Doherty
On 10/07/2017 8:20 AM, Herbert Guan wrote: There were double-free problems in some test cases of link_bonding, which will cause a duplicated mbuf will be added into mempool. After double-free, some new allocated mbuf will hold a same address and thus cause the memory corruption. Another minor i

Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port andnbsegments

2017-07-12 Thread Morten Brørup
> -Original Message- > From: Yang, Zhiyong [mailto:zhiyong.y...@intel.com] > Sent: Wednesday, July 12, 2017 11:02 AM > To: Morten Brørup; Wiles, Keith > Cc: Thomas Monjalon; DPDK; Olivier Matz; Wang, Zhihong; Yuanhan Liu; > Ananyev, Konstantin; Richardson, Bruce; Chilikin, Andrey; Jan Blunc

Re: [dpdk-dev] [PATCH 00/13] devargs fixes

2017-07-12 Thread Jan Blunck
On Wed, Jul 12, 2017 at 4:50 AM, Thomas Monjalon wrote: > 12/07/2017 10:09, Jan Blunck: >> On Wed, Jul 12, 2017 at 3:29 AM, Thomas Monjalon wrote: >> > 12/07/2017 01:24, Jan Blunck: >> >> The changes to enum rte_devtype that got merged into 17.08-rc1 are >> >> breaking >> >> API without prior no

[dpdk-dev] [PATCH] doc: notify callback process API change

2017-07-12 Thread Bernard Iremonger
The _rte_eth_dev_callback_process function has been modified. The return value has been changed form void to int and an extra parameter "void *ret_param" has been added. Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_17_08.rst | 7 ++- 1 file changed, 6 insertions(+), 1 de

Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port and nbsegments

2017-07-12 Thread Yang, Zhiyong
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Morten Brørup > Sent: Wednesday, July 12, 2017 3:25 PM > To: Wiles, Keith > Cc: Thomas Monjalon ; DPDK ; Olivier > Matz ; Wang, Zhihong ; > Yuanhan Liu ; Ananyev, Konstantin > ; Richardson, Bruce > ; Chilikin, An

Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process

2017-07-12 Thread Tan, Jianfeng
> -Original Message- > From: Gonzalez Monroy, Sergio > Sent: Wednesday, July 12, 2017 3:32 PM > To: Tan, Jianfeng; Stephen Hemminger; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary > process > > On 12/07/2017 03:45, Tan, Jianfeng wrote: > > > >>

Re: [dpdk-dev] [PATCH 00/13] devargs fixes

2017-07-12 Thread Thomas Monjalon
12/07/2017 10:09, Jan Blunck: > On Wed, Jul 12, 2017 at 3:29 AM, Thomas Monjalon wrote: > > 12/07/2017 01:24, Jan Blunck: > >> The changes to enum rte_devtype that got merged into 17.08-rc1 are breaking > >> API without prior notice. This series is reworking the rte_devargs changes > >> in a way h

Re: [dpdk-dev] [PATCH v3 4/8] eal: fix hotplug add / remove

2017-07-12 Thread Jan Blunck
On Tue, Jul 11, 2017 at 7:25 PM, Gaetan Rivet wrote: > The hotplug API requires a few properties that were not previously > explicitly enforced: > > - Idempotency, two consecutive scans should result in the same state. > - Upon returning, internal devices are now allocated and available >

[dpdk-dev] [Process] Git Fixline Suggestion

2017-07-12 Thread Van Haaren, Harry
Hi All, I propose to add CC: to the output of the git fixline command[1]. The logic here is that if it is a fix to the previous code, the original author of that code should be informed. Currently the author must read the mailing-list carefully in order to ensure that no patches are missed, th

Re: [dpdk-dev] [PATCH v3 2/8] devargs: introduce removal function

2017-07-12 Thread Jan Blunck
On Tue, Jul 11, 2017 at 7:25 PM, Gaetan Rivet wrote: > Hotplug support introduces the possibility of removing devices from the > system. Allocated resources must be freed. > > Extend the rte_devargs API to allow freeing allocated resources. > > This API is experimental and bound to change. It is c

Re: [dpdk-dev] [PATCH v3 3/8] devargs: introduce insert function

2017-07-12 Thread Jan Blunck
On Tue, Jul 11, 2017 at 7:25 PM, Gaetan Rivet wrote: > Some buses will operate either in whitelist or blacklist mode. > This mode is currently passed down by the rte_eal_devargs_add function > with the devtype argument. > > When inserting devices using the hotplug API, the implicit assumption is >

Re: [dpdk-dev] [PATCH v3 04/11] linuxapp/eal_pci: get iommu class

2017-07-12 Thread Sergio Gonzalez Monroy
On 11/07/2017 07:16, Santosh Shukla wrote: Get iommu class of PCI device on the bus and returns preferred iova mapping mode for that bus. Algorithm for iova scheme selection for PCI bus: 0. Look for device attached to vfio kdrv and has .drv_flag set to RTE_PCI_DRV_NEED_IOVA_VA. 1. Look for any d

Re: [dpdk-dev] [PATCH 00/13] devargs fixes

2017-07-12 Thread Jan Blunck
On Wed, Jul 12, 2017 at 3:29 AM, Thomas Monjalon wrote: > 12/07/2017 01:24, Jan Blunck: >> The changes to enum rte_devtype that got merged into 17.08-rc1 are breaking >> API without prior notice. This series is reworking the rte_devargs changes >> in a way hopefully compliant to the new failover P

Re: [dpdk-dev] [PATCH v2 0/3] vdev patches for -rc2

2017-07-12 Thread Gaëtan Rivet
On Tue, Jul 11, 2017 at 07:15:45PM -0400, Jan Blunck wrote: > Three trivial vdev patches for -rc2. Please review and apply. > For the series: Acked-by: Gaetan Rivet > Changes since v0: > - Fix review comments by Gaetan > > Jan Blunck (3): > vdev: get name from embedded device > vdev: direc

[dpdk-dev] [PATCH 1/2] cryptodev: remove obsolete include

2017-07-12 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_cryptodev/rte_cryptodev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index ca7cbdd8d..989db0f36 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib/librte_cryptode

[dpdk-dev] [PATCH 0/2] cryptodev vdev changes for -rc2

2017-07-12 Thread Jan Blunck
This series is a preparation to move the vdev bus out of librte_eal. For that the newly added cryptodev vdev functions need to change signature to not require the rte_vdev.h header. Jan Blunck (2): cryptodev: remove obsolete include cryptodev: rework cryptodev PMD init to not require rte_vdev.

[dpdk-dev] [PATCH 2/2] cryptodev: rework cryptodev PMD init to not require rte_vdev.h

2017-07-12 Thread Jan Blunck
This reworks the library code so that it doesn't require to include rte_vdev.h. This is a preparation to move the vdev bus into a standalone library. Signed-off-by: Jan Blunck --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 4 ++-- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 4 ++-- dr

[dpdk-dev] [PATCH] doc: announce API and ABI change for ethdev

2017-07-12 Thread Zhiyong Yang
This is an API/ABI change notice for DPDK 17.11 on redefinition of port_id. port_id is defined as uint8_t by now, which is just ranged from 0 to 255. For more and more scenerioes, more than 256 devices are needed to support for vdev scalability. It is necessary for redefinition of port_id to e

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: add hot plug monitor in i40e

2017-07-12 Thread Guo, Jia
On 7/10/2017 6:35 AM, Thomas Monjalon wrote: 07/07/2017 16:08, Guo, Jia: On 7/7/2017 6:17 PM, Thomas Monjalon wrote: 07/07/2017 09:56, Thomas Monjalon: 29/06/2017 07:01, Jeff Guo: --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -1283,6 +1283,7 @@ static inline vo

Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process

2017-07-12 Thread Sergio Gonzalez Monroy
On 12/07/2017 03:45, Tan, Jianfeng wrote: -Original Message- From: Gonzalez Monroy, Sergio Sent: Tuesday, July 11, 2017 7:36 PM To: Tan, Jianfeng; Stephen Hemminger; dev@dpdk.org Subject: Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process On 11/07/2017 02:56, Tan,

Re: [dpdk-dev] [PATCH 00/13] devargs fixes

2017-07-12 Thread Thomas Monjalon
12/07/2017 01:24, Jan Blunck: > The changes to enum rte_devtype that got merged into 17.08-rc1 are breaking > API without prior notice. This series is reworking the rte_devargs changes > in a way hopefully compliant to the new failover PMD and still keeping API > compatible with earlier releases.

Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port and nbsegments

2017-07-12 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wiles, Keith > Sent: Tuesday, July 11, 2017 6:48 PM > To: Morten Brørup > Cc: Thomas Monjalon; DPDK; Olivier Matz; Wang, Zhihong; Yuanhan Liu; > Ananyev, Konstantin; Richardson, Bruce; Chilikin, Andrey; Jan Blunck;

Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process

2017-07-12 Thread Sergio Gonzalez Monroy
On 11/07/2017 21:00, Stephen Hemminger wrote: On Tue, 11 Jul 2017 12:35:39 +0100 Sergio Gonzalez Monroy wrote: On 11/07/2017 02:56, Tan, Jianfeng wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger Sent: Tuesday, July 11, 2017 9:13 AM To: d

[dpdk-dev] [PATCH] eal : fix primary alive function

2017-07-12 Thread Harouat, Karim (Nokia - FR/Lannion)