12/07/2017 10:09, Jan Blunck: > On Wed, Jul 12, 2017 at 3:29 AM, Thomas Monjalon <tho...@monjalon.net> wrote: > > 12/07/2017 01:24, Jan Blunck: > >> The changes to enum rte_devtype that got merged into 17.08-rc1 are breaking > >> API without prior notice. This series is reworking the rte_devargs changes > >> in a way hopefully compliant to the new failover PMD and still keeping API > >> compatible with earlier releases. > > > > I have not reviewed this series yet. > > I have just seen that your are introducing "bus=" in devargs. > > Do you keep compatibility with old scheme without "bus=" option? > > We need to keep this compat for 17.08 and deprecate it for 17.11. > > The old scheme which got introduced with 17.08-rc1 is using the > concatenation of bus name, a one character separator and the device > name: > > rte_eal_devargs_parse( "busname*devname,args" )
No I was talking about the real old scheme without any bus name :) > The new scheme I propose is changing this to take an explicit 'bus=' > argument into account. In case the 'bus=' argument isn't given but the > device is found by iterating the devices on the buses this will also > work. OK > > Please, could you also review the fixes from Gaetan and ack those > > which are relevant from your point of view? > > We cannot progress if we don't apply the fixes we agree on. > > Yes, will do today. Thanks > > Last note: we should make RC2 in few days (hopefully on Sunday), > > so please reply quickly. > > Thanks
