Re: [dpdk-dev] [PATCH v10 20/20] ethdev: add control interface support

2017-07-07 Thread Yuanhan Liu
On Tue, Jul 04, 2017 at 05:13:37PM +0100, Ferruh Yigit wrote: > @@ -157,8 +164,12 @@ rte_eth_dev_pci_generic_probe(struct rte_pci_device > *pci_dev, > > RTE_FUNC_PTR_OR_ERR_RET(*dev_init, -EINVAL); > ret = dev_init(eth_dev); > - if (ret) > + if (ret) { > rte_eth

Re: [dpdk-dev] [PATCH 0/2] virtio fix false offload claims

2017-07-07 Thread Yuanhan Liu
On Fri, Jul 07, 2017 at 12:52:48PM -0700, Stephen Hemminger wrote: > While doing code for Hyper-V, noticed that the virtio driver was > confused about receive versus transmit offloads. The virtio > checksum offload is L4 (TCP/UDP) only, not IPv4. Also, TSO > and LRO are not the same. > > This may

Re: [dpdk-dev] [PATCH v3] examples/vhost: introduce a new vhost-user-scsi sample application

2017-07-07 Thread Yuanhan Liu
On Fri, Jul 07, 2017 at 02:21:28PM +0200, Thomas Monjalon wrote: > 08/07/2017 07:21, Changpeng Liu: > > MAINTAINERS | 2 + > > doc/guides/sample_app_ug/vhost_scsi.rst | 110 +++ > > examples/Makefile | 2 +- > > examples/vhost_scsi/Makefile

Re: [dpdk-dev] [PATCH v3] doc: document NIC features

2017-07-07 Thread Wiles, Keith
> On Jul 7, 2017, at 3:37 PM, Thomas Monjalon wrote: > > 07/07/2017 16:20, Wiles, Keith: >> >>> On Jul 7, 2017, at 9:13 AM, Ferruh Yigit wrote: >>> >>> On 7/7/2017 3:02 PM, Thomas Monjalon wrote: 07/07/2017 15:57, Ferruh Yigit: > On 7/7/2017 2:53 PM, Thomas Monjalon wrote: >> 07/

Re: [dpdk-dev] [pull-request] next-eventdev 17.08 rc1

2017-07-07 Thread Thomas Monjalon
07/07/2017 10:03, Jerin Jacob: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks

Re: [dpdk-dev] DPDK ethdev/mbuf features and reviews

2017-07-07 Thread Thomas Monjalon
07/07/2017 21:12, Shrikrishna Khare: > Table 1.1 from the above 17.08 doc is missing vmxnet3. The vmxnet3 driver > is missing from 17.05 doc as well > (http://dpdk.readthedocs.io/en/v17.05/nics/overview.html) but it is > present in 17.02 > (http://dpdk.readthedocs.io/en/v17.02/nics/overview.htm

Re: [dpdk-dev] [PATCH v3] doc: document NIC features

2017-07-07 Thread Thomas Monjalon
07/07/2017 16:20, Wiles, Keith: > > > On Jul 7, 2017, at 9:13 AM, Ferruh Yigit wrote: > > > > On 7/7/2017 3:02 PM, Thomas Monjalon wrote: > >> 07/07/2017 15:57, Ferruh Yigit: > >>> On 7/7/2017 2:53 PM, Thomas Monjalon wrote: > 07/07/2017 15:37, Ferruh Yigit: > > On 7/7/2017 11:55 AM, An

[dpdk-dev] [PATCH 2/2] virtio: don't claim to support LRO

2017-07-07 Thread Stephen Hemminger
The current virtio supports Transmit Segmentation Offload, but does not really support Large Receive Offload. The driver was confusing the two offloads. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_ethdev.c | 22 ++ 1 file changed, 2 insertions(+), 20 deleti

[dpdk-dev] [PATCH 0/2] virtio fix false offload claims

2017-07-07 Thread Stephen Hemminger
While doing code for Hyper-V, noticed that the virtio driver was confused about receive versus transmit offloads. The virtio checksum offload is L4 (TCP/UDP) only, not IPv4. Also, TSO and LRO are not the same. This may break some program that was assuming it was getting offloads that it wasn't.

[dpdk-dev] [PATCH 1/2] virtio: don't falsely claim to do IP checksum

2017-07-07 Thread Stephen Hemminger
The virtio driver is confused about the meaning of the ip_checksum flag. In DPDK, ip_checksum means the hardware is capable of checking the Layer 3 IP checksum. But KVM/QEMU does not do that. The flag VIRTIO_NET_F_GUEST_CSUM controls whether the receive side does Layer 4 (TCP/UDP) checksum offloa

Re: [dpdk-dev] DPDK ethdev/mbuf features and reviews

2017-07-07 Thread Shrikrishna Khare
On Fri, 7 Jul 2017, Thomas Monjalon wrote: > Hi, > > The ethdev library is very special as it defines the services (ops) > to be implemented in every DPDK networking drivers. > It defines also some configuration bits to support. > The mbuf library defines also some offloads to support in driver

[dpdk-dev] DPDK Meet-up in Boston: Wed July 12th

2017-07-07 Thread Dave Neary
Hi all, Thanks to Rashid Khan and Aaron Conole, we have secured some space for a DPDK meet-up in our home town of Boston next Wednesday, July 12th, at the Red Hat offices in Fort Point (300 A St, Boston, MA). This is a first one, so the agenda is light, we will have an introduction to the meet-up

[dpdk-dev] [PATCH v4] doc: document NIC features

2017-07-07 Thread Ferruh Yigit
Document NIC features, add more information about them and add more implementation related support. Signed-off-by: Ferruh Yigit Signed-off-by: John McNamara --- Cc: Olivier Matz v4: * Apply review comments from Andrew Rybchenko * Add tags to the information, to clarify in, out, related data.

[dpdk-dev] [PATCH v3] doc: add new targets to "make help" output

2017-07-07 Thread Gabriel Carrillo
Commit aafaea3d3b70 ("devtools: add tags and cscope index generation") introduced new make targets. This change updates the help target output to reflect the additions. Signed-off-by: Gabriel Carrillo --- v3: * Updated formatting. doc/build-sdk-quick.txt | 2 ++ 1 file changed, 2 insertions(+)

Re: [dpdk-dev] [PATCH v2] doc: add new targets to "make help" output

2017-07-07 Thread Carrillo, Erik G
Response in-line: > -Original Message- > From: Mcnamara, John > Sent: Monday, June 26, 2017 10:38 AM > To: Carrillo, Erik G ; tho...@monjalon.net > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] doc: add new targets to "make help" > output > > > > > -Original Message- > >

[dpdk-dev] [PATCH v4 6/7] doc: add service cores to doc and release notes

2017-07-07 Thread Harry van Haaren
Add a section describing the fundamental concepts behind service cores. Where service cores originate from, and how to enable services. The release notes for 17.08 are updated, with an introductory paragraph on the service cores concept. Finally the Eventdev SW PMD documentation is amended to refle

[dpdk-dev] [PATCH v4 7/7] maintainers: claim service cores

2017-07-07 Thread Harry van Haaren
Sign-up to be the maintainer of public header files and implementation of the service-cores infrastructure. Signed-off-by: Harry van Haaren --- v4: - fix rte_service.c filename - Include service_cores.rst file --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINE

[dpdk-dev] [PATCH v4 4/7] service cores: add unit tests

2017-07-07 Thread Harry van Haaren
Add a bunch of unit tests, to ensure that the service core functions are operating as expected. As part of these tests a dummy service is registered which allows identifying if a service callback has been invoked by using the CPU tick counter. This allows identifying if functions to start and stop

[dpdk-dev] [PATCH v4 5/7] event/sw: enable SW PMD with service capability

2017-07-07 Thread Harry van Haaren
This commit shows how easy it is to enable a specific DPDK component with a service callback, in order to get CPU cycles for it. The beauty of this method is that the service is unaware of how much CPU time it is getting - the application can decide how to split and slice cores and map them to the

[dpdk-dev] [PATCH v4 3/7] service cores: coremask parsing

2017-07-07 Thread Harry van Haaren
Add logic for parsing a coremask from EAL, which allows the application to be unaware of the cores being taken from its coremask. Signed-off-by: Harry van Haaren Acked-by: Jerin Jacob --- v4: - Add --help print output (Jerin) - Fixed coremask parsing to ensure master core is ROLE_RTE (Jerin)

[dpdk-dev] [PATCH v4 2/7] service cores: EAL init changes

2017-07-07 Thread Harry van Haaren
This commit shows the changes required in rte_eal_init() to transparently launch the service threads. The threads are launched into the service worker functions here because after rte_eal_init() the application is not gauranteed to call any other DPDK API. As the registration of services happens a

[dpdk-dev] [PATCH v4 1/7] service cores: header and implementation

2017-07-07 Thread Harry van Haaren
Add header files, update .map files with new service functions, and add the service header to the doxygen for building. This service header API allows DPDK to use services as a concept of something that requires CPU cycles. An example is a PMD that runs in software to schedule events, where a hard

[dpdk-dev] [PATCH v4 0/7] service cores: cover letter

2017-07-07 Thread Harry van Haaren
This patchset introduces service cores to DPDK. A service core is an lcore that performs functions to abstract away details of differences in environment of the application. An example is using the eventdev API, where either a software or hardware PMD performs scheduling. In the case of the softwa

Re: [dpdk-dev] [PATCH v3 2/7] service cores: EAL init changes

2017-07-07 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Tuesday, July 4, 2017 12:36 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; tho...@monjalon.net; Wiles, Keith ; > Richardson, > Bruce > Subject: Re: [PATCH v3 2/7] service cores: EAL init changes > > -Original Message- >

Re: [dpdk-dev] [PATCH v3 5/7] service cores: enable event/sw with service

2017-07-07 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Tuesday, July 4, 2017 11:53 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; tho...@monjalon.net; Wiles, Keith ; > Richardson, > Bruce > Subject: Re: [PATCH v3 5/7] service cores: enable event/sw with service > > -Original Me

[dpdk-dev] [PATCH] eal/armv7: emulate vaddvq u16 variant

2017-07-07 Thread Jerin Jacob
vaddvq_u16() is not available for armv7. Emulate the vaddvq_u16() using armv7 NEON intrinsics. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/arm/rte_vect.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/librte_eal/common/include/arch/arm/rte_vect.h b/li

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-07-07 Thread Jerin Jacob
-Original Message- > Date: Fri, 7 Jul 2017 20:33:19 +0530 > From: Jerin Jacob > To: "Rao, Nikhil" > CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, > bruce.richard...@intel.com, harry.van.haa...@intel.com, > hemant.agra...@nxp.com, nipun.gu...@nxp.com, narender.vang...@intel

Re: [dpdk-dev] compilation error in l3fwd for ARMv7 NEON

2017-07-07 Thread Jan Viktorin
On Fri, 07 Jul 2017 17:24:38 +0200 Thomas Monjalon wrote: > Hi Jianbo, > > It seems your NEON acceleration of the example l3fwd > is not compiling for ARMv7: > examples/l3fwd/l3fwd_neon.h:113:6: error: > implicit declaration of function ‘vaddvq_u16’ > > I am using gcc-linaro-6.3.1-2

Re: [dpdk-dev] [ovs-dev] [PATCH v2 0/4] rhel/fedora: non-root OvS out of the box

2017-07-07 Thread Aaron Conole
Aaron Conole writes: > This series attempts to introduce the ability to start and use > Open vSwitch 'out of the box' as a non-root user. It does this by > modifying the service files to pass the recently introduced --ovs-user > argument around, and by making some minor tweaks to the passwd, gr

Re: [dpdk-dev] [PATCH v3] doc: document NIC features

2017-07-07 Thread Andrew Rybchenko
On 07/07/2017 06:06 PM, Ferruh Yigit wrote: On 7/7/2017 11:55 AM, Andrew Rybchenko wrote: <...> +TSO +--- + +Supports TCP Segmentation Offloading. + +* **mbuf**: ``mbuf.ol_flags:PKT_TX_TCP_SEG``. DEV_TX_OFFLOAD_*_TSO in tx_offload_capa Is support of one TSO option sufficient to say Yes? This

Re: [dpdk-dev] [PATCH v2] net/bonding: support bifurcated driver in eal cli using --vdev

2017-07-07 Thread Declan Doherty
On 04/07/2017 12:57 PM, Gowrishankar wrote: From: Gowrishankar Muthukrishnan At present, creating bonding devices using --vdev is broken for PMD like mlx5 as it is neither UIO nor VFIO based and hence PMD driver is unknown to find_port_id_by_pci_addr(), as below. testpmd --vdev 'net_bonding0,

[dpdk-dev] compilation error in l3fwd for ARMv7 NEON

2017-07-07 Thread Thomas Monjalon
Hi Jianbo, It seems your NEON acceleration of the example l3fwd is not compiling for ARMv7: examples/l3fwd/l3fwd_neon.h:113:6: error: implicit declaration of function ‘vaddvq_u16’ I am using gcc-linaro-6.3.1-2017.05-x86_64_arm-linux-gnueabihf. Is it something we can fix easily?

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-07 Thread Ferruh Yigit
On 7/7/2017 12:13 PM, Shijith Thotton wrote: > Set UIO info device file operations open and release. Call pci reset > function inside open and release to clear device state at start and end. > Copied this behaviour from vfio_pci kernel module code. With this patch, > it is not mandatory to issue FL

Re: [dpdk-dev] [PATCH v3] doc: document NIC features

2017-07-07 Thread Ferruh Yigit
On 7/7/2017 11:55 AM, Andrew Rybchenko wrote: <...> >> +TSO >> +--- >> + >> +Supports TCP Segmentation Offloading. >> + >> +* **mbuf**: ``mbuf.ol_flags:PKT_TX_TCP_SEG``. > > DEV_TX_OFFLOAD_*_TSO in tx_offload_capa > Is support of one TSO option sufficient to say Yes? This is common question for

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-07-07 Thread Jerin Jacob
-Original Message- > Date: Fri, 7 Jul 2017 11:51:01 +0530 > From: "Rao, Nikhil" > To: Jerin Jacob > CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, > bruce.richard...@intel.com, harry.van.haa...@intel.com, > hemant.agra...@nxp.com, nipun.gu...@nxp.com, narender.vang...@intel

Re: [dpdk-dev] [PATCH v3] doc: document NIC features

2017-07-07 Thread Wiles, Keith
> On Jul 7, 2017, at 9:13 AM, Ferruh Yigit wrote: > > On 7/7/2017 3:02 PM, Thomas Monjalon wrote: >> 07/07/2017 15:57, Ferruh Yigit: >>> On 7/7/2017 2:53 PM, Thomas Monjalon wrote: 07/07/2017 15:37, Ferruh Yigit: > On 7/7/2017 11:55 AM, Andrew Rybchenko wrote: >> Also some PMDs have

[dpdk-dev] [PATCH] mbuf: fix comment about vxlan destination port used

2017-07-07 Thread Cian Ferriter
IANA assigns a destination port of 4789 for the VXLAN in the Service Name and Transport Protocol Port Number Registry. This is mentioned in RFC 7348. Signed-off-by: Cian Ferriter --- lib/librte_mbuf/rte_mbuf_ptype.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/

Re: [dpdk-dev] [PATCH v3] doc: document NIC features

2017-07-07 Thread Ferruh Yigit
On 7/7/2017 3:02 PM, Thomas Monjalon wrote: > 07/07/2017 15:57, Ferruh Yigit: >> On 7/7/2017 2:53 PM, Thomas Monjalon wrote: >>> 07/07/2017 15:37, Ferruh Yigit: On 7/7/2017 11:55 AM, Andrew Rybchenko wrote: > Also some PMDs have few implementations of the datapath (like vector and > u

[dpdk-dev] [PATCH] doc: fix typo in contributing guide

2017-07-07 Thread Cian Ferriter
Signed-off-by: Cian Ferriter --- doc/guides/contributing/patches.rst |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst index 84a5dab..7926c96 100644 --- a/doc/guides/contributing/patches.rst +++ b/

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: add hot plug monitor in i40e

2017-07-07 Thread Guo, Jia
On 7/7/2017 6:17 PM, Thomas Monjalon wrote: 07/07/2017 09:56, Thomas Monjalon: 29/06/2017 07:01, Jeff Guo: --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -1283,6 +1283,7 @@ static inline void i40e_GLQF_reg_init(struct i40e_hw *hw) /* enable uio intr after c

Re: [dpdk-dev] [PATCH v3] doc: document NIC features

2017-07-07 Thread Thomas Monjalon
07/07/2017 15:57, Ferruh Yigit: > On 7/7/2017 2:53 PM, Thomas Monjalon wrote: > > 07/07/2017 15:37, Ferruh Yigit: > >> On 7/7/2017 11:55 AM, Andrew Rybchenko wrote: > >>> Also some PMDs have few implementations of the datapath (like vector and > >>> usual). Ideally > >>> we need common way to high

Re: [dpdk-dev] [PATCH v3] doc: document NIC features

2017-07-07 Thread Ferruh Yigit
On 7/7/2017 2:53 PM, Thomas Monjalon wrote: > 07/07/2017 15:37, Ferruh Yigit: >> On 7/7/2017 11:55 AM, Andrew Rybchenko wrote: >>> Also some PMDs have few implementations of the datapath (like vector and >>> usual). Ideally >>> we need common way to highlight it. May be it is OK that control path

Re: [dpdk-dev] [PATCH] __rte_hash_add_key_with_hash not releasing multiwriter_lock in failure paths

2017-07-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Wednesday, July 5, 2017 3:51 PM > To: mstolarchuk ; Richardson, Bruce > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] __rte_hash_add_key_with_hash not > releasing multiwrite

[dpdk-dev] [PATCH v2] hash: fix lock release on add

2017-07-07 Thread Pablo de Lara
From: mstolarchuk When adding items to a hash table with multiple threads, there is an spinlock used to prevent data corruption (unless Transactional Memory is supported). If there is a failure, the spinlock should be released, but there were cases where that was not happening. Fixes: be856325c

Re: [dpdk-dev] [PATCH v3] doc: document NIC features

2017-07-07 Thread Thomas Monjalon
07/07/2017 15:37, Ferruh Yigit: > On 7/7/2017 11:55 AM, Andrew Rybchenko wrote: > > Also some PMDs have few implementations of the datapath (like vector and > > usual). Ideally > > we need common way to highlight it. May be it is OK that control path > > features are duplicated > > in this case,

Re: [dpdk-dev] [PATCH v3] doc: document NIC features

2017-07-07 Thread Ferruh Yigit
Hi Andrew, On 7/7/2017 11:55 AM, Andrew Rybchenko wrote: > On 07/05/2017 04:20 PM, Ferruh Yigit wrote: >> Document NIC features, add more information about them and add more >> implementation related support. > > It is very useful information and very good start. Thanks for review, I rely on mor

[dpdk-dev] [PATCH] doc: use new crypto driver names

2017-07-07 Thread Pablo de Lara
Crypto driver names were changed in 16.11, but some guides were still using the old ones (which are still valid, only kept for compatibility reasons). To keep consistency and avoid confusion, all guides should be using the same driver names. Signed-off-by: Pablo de Lara --- doc/guides/prog_guid

Re: [dpdk-dev] [PATCH] doc: fix crypto scheduler command line examples

2017-07-07 Thread Mcnamara, John
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Friday, July 7, 2017 5:37 AM > To: Mcnamara, John ; Doherty, Declan > > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH] doc: fix crypto scheduler command line examples > > Sample command lines for

[dpdk-dev] [PATCH] doc: fix crypto scheduler command line examples

2017-07-07 Thread Pablo de Lara
Sample command lines for crypto scheduler were not correct, due to: - Typo in "crypto_scheduler" driver name - Multiple virtual devices require having unique names, driver name + a suffix, otherwise, just a single device is created. Fixes: d58a3f312545 ("crypto/scheduler: add documentation") C

Re: [dpdk-dev] [PATCH v3] examples/vhost: introduce a new vhost-user-scsi sample application

2017-07-07 Thread Thomas Monjalon
08/07/2017 07:21, Changpeng Liu: > MAINTAINERS | 2 + > doc/guides/sample_app_ug/vhost_scsi.rst | 110 +++ > examples/Makefile | 2 +- > examples/vhost_scsi/Makefile| 59 > examples/vhost_scsi/scsi.c | 507 >

[dpdk-dev] How to set the multiple queues per port in Virtual Machine

2017-07-07 Thread Mohanraj Venkat
Hi, We are using the ubuntu VM in openstack environment. We have set the below option in Openstack to enable multi queue per port. hw_vif_multiqueue_enabled=true After launching the instance, we set the queue using the command "ethtool -L ens4 combined 3". While checking the same as below. ro

Re: [dpdk-dev] [pull-request] next-net 17.08 RC1

2017-07-07 Thread Thomas Monjalon
06/07/2017 15:26, Ferruh Yigit: > http://dpdk.org/git/next/dpdk-next-net Pulled, thanks

[dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-07 Thread Shijith Thotton
Set UIO info device file operations open and release. Call pci reset function inside open and release to clear device state at start and end. Copied this behaviour from vfio_pci kernel module code. With this patch, it is not mandatory to issue FLR by PMD's during init and close. Bus master enable

Re: [dpdk-dev] [PATCH v4 2/2] net/ixgbe: enable PTYPE offload for x86 vector PMD

2017-07-07 Thread Ferruh Yigit
On 6/13/2017 9:58 AM, Qi Zhang wrote: > Hardware PTYPE in Rx desc will be parsed to fill > mbuf's packet_type. > > Signed-off-by: Ray Kinsella > Signed-off-by: Qi Zhang <...> > @@ -125,6 +125,11 @@ SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += > ixgbe_82599_bypass.c > endif > SRCS-$(CONFIG_RTE_LIB

Re: [dpdk-dev] [PATCH v4 1/2] net/ixgbe: add SSE4.1 support to vPMD's minimum requirement

2017-07-07 Thread Ferruh Yigit
On 6/15/2017 11:26 AM, Ferruh Yigit wrote: > On 6/13/2017 9:58 AM, Qi Zhang wrote: >> x86 vPMD will be disabled if currently platform does not support SSE4.1. >> This is the prework to enable vPMD ptype offload where SSE4.1 instrunctions >> will be involved. >> >> Signed-off-by: Qi Zhang > > Seri

Re: [dpdk-dev] [PATCH v3 3/7] service cores: coremask parsing

2017-07-07 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Friday, July 7, 2017 11:46 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; tho...@monjalon.net; Wiles, Keith ; > Richardson, > Bruce > Subject: Re: [PATCH v3 3/7] service cores: coremask parsing > > -Original Message- >

Re: [dpdk-dev] [PATCH v3] doc: document NIC features

2017-07-07 Thread Andrew Rybchenko
On 07/05/2017 04:20 PM, Ferruh Yigit wrote: Document NIC features, add more information about them and add more implementation related support. It is very useful information and very good start. I think it would be very useful to explain how PMD advertises support of the feature and how applic

Re: [dpdk-dev] [PATCH v3 3/7] service cores: coremask parsing

2017-07-07 Thread Jerin Jacob
-Original Message- > Date: Thu, 6 Jul 2017 14:47:20 + > From: "Van Haaren, Harry" > To: Jerin Jacob > CC: "dev@dpdk.org" , "tho...@monjalon.net" > , "Wiles, Keith" , > "Richardson, Bruce" > Subject: RE: [PATCH v3 3/7] service cores: coremask parsing > > > From: Jerin Jacob [mailto

[dpdk-dev] [PATCH v12 3/3] app/testpmd: enable TCP/IPv4 GRO

2017-07-07 Thread Jiayu Hu
This patch enables TCP/IPv4 GRO library in csum forwarding engine. By default, GRO is turned off. Users can use command "gro (on|off) (port_id)" to enable or disable GRO for a given port. If a port is enabled GRO, all TCP/IPv4 packets received from the port are performed GRO. Besides, users can set

[dpdk-dev] [PATCH v12 1/3] lib: add Generic Receive Offload API framework

2017-07-07 Thread Jiayu Hu
Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by reassembling small packets into large ones. This patchset is to support GRO in DPDK. To support GRO, this patch implements a GRO API framework. To enable m

[dpdk-dev] [PATCH v12 2/3] lib/gro: add TCP/IPv4 GRO support

2017-07-07 Thread Jiayu Hu
In this patch, we introduce five APIs to support TCP/IPv4 GRO. - gro_tcp4_reassemble: reassemble an inputted TCP/IPv4 packet. - gro_tcp4_tbl_create: create a TCP/IPv4 reassembly table, which is used to merge packets. - gro_tcp4_tbl_destroy: free memory space of a TCP/IPv4 reassembly table. - gr

[dpdk-dev] [PATCH v12 0/3] Support TCP/IPv4 GRO in DPDK

2017-07-07 Thread Jiayu Hu
Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by reassembling small packets into large ones. Therefore, we propose to support GRO in DPDK. To enable more flexibility to applications, DPDK GRO is implement

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: add hot plug monitor in i40e

2017-07-07 Thread Thomas Monjalon
07/07/2017 09:56, Thomas Monjalon: > 29/06/2017 07:01, Jeff Guo: > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -1283,6 +1283,7 @@ static inline void i40e_GLQF_reg_init(struct i40e_hw > > *hw) > > > > /* enable uio intr after callback register */ > >

Re: [dpdk-dev] [PATCH] igb_uio: issue FLR during open and release of device file

2017-07-07 Thread Ferruh Yigit
On 7/7/2017 11:03 AM, Shijith Thotton wrote: > On Thu, Jul 06, 2017 at 08:27:17PM +0300, Gregory Etelson wrote: >> I could not reproduce server crash with >> http://dpdk.org/dev/patchwork/patch/25267/ [1] >> However, pci_try_reset_function() API used in that patch is not defined in >> RedHat-6.x

Re: [dpdk-dev] [PATCH v6 00/22] introduce fail-safe PMD

2017-07-07 Thread Gaëtan Rivet
On Fri, Jul 07, 2017 at 11:05:22AM +0100, Ferruh Yigit wrote: > On 7/7/2017 1:09 AM, Gaetan Rivet wrote: > > This PMD intercepts and manages Ethernet device removal events issued by > > slave PMDs and re-initializes them transparently when brought back so that > > existing applications do not need

Re: [dpdk-dev] [PATCH v6 00/22] introduce fail-safe PMD

2017-07-07 Thread Ferruh Yigit
On 7/7/2017 1:09 AM, Gaetan Rivet wrote: > This PMD intercepts and manages Ethernet device removal events issued by > slave PMDs and re-initializes them transparently when brought back so that > existing applications do not need to be modified to benefit from true > hot-plugging support. > > The s

Re: [dpdk-dev] [PATCH v3] doc: release notes 17.08, API change description

2017-07-07 Thread Mcnamara, John
> -Original Message- > From: Nicolau, Radu > Sent: Friday, July 7, 2017 10:21 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Mcnamara, John ; > Nicolau, Radu > Subject: [PATCH v3] doc: release notes 17.08, API change description > > Added API change description - moved bypass function

Re: [dpdk-dev] [PATCH] igb_uio: issue FLR during open and release of device file

2017-07-07 Thread Shijith Thotton
On Thu, Jul 06, 2017 at 08:27:17PM +0300, Gregory Etelson wrote: > I could not reproduce server crash with > http://dpdk.org/dev/patchwork/patch/25267/ [1] > However, pci_try_reset_function() API used in that patch is not defined in > RedHat-6.x Linux-2.6.32 kernels > Therefore I work with http:

Re: [dpdk-dev] [PATCH v4 0/5] net/mlx5: add vectorized Rx/Tx burst for x86

2017-07-07 Thread Ferruh Yigit
On 7/6/2017 7:41 PM, Yongseok Koh wrote: > This is to introduce more efficient Rx/Tx burst functions using SIMD > instructions. Currently it is only supported by 64bit x86 having SSE4.1. > > From functional perspective, Rx burst function is equivalent to the > existing mlx5_rx_burst() except for s

Re: [dpdk-dev] [PATCH v3] examples/vhost: introduce a new vhost-user-scsi sample application

2017-07-07 Thread Yuanhan Liu
On Fri, Jul 07, 2017 at 02:10:57PM +0530, Hemant Agrawal wrote: > On 7/7/2017 10:37 AM, Yuanhan Liu wrote: > >On Sat, Jul 08, 2017 at 01:21:37PM +0800, Changpeng Liu wrote: > >>vhost-user protocol is common to many virtio devices, such as > >>virtio_net/virtio_scsi/virtio_blk. Since DPDK vhost libr

[dpdk-dev] [PATCH v3] doc: release notes 17.08, API change description

2017-07-07 Thread Radu Nicolau
Added API change description - moved bypass functions from the rte_ether library to ixgbe PMD Signed-off-by: Radu Nicolau --- v3: fixed indentation issue doc/guides/rel_notes/release_17_08.rst | 25 + 1 file changed, 25 insertions(+) diff --git a/doc/guides/rel_notes/r

[dpdk-dev] DPDK ethdev/mbuf features and reviews

2017-07-07 Thread Thomas Monjalon
Hi, The ethdev library is very special as it defines the services (ops) to be implemented in every DPDK networking drivers. It defines also some configuration bits to support. The mbuf library defines also some offloads to support in drivers. Some of these features are not enough supported and ne

Re: [dpdk-dev] [PATCH v11 1/3] lib: add Generic Receive Offload API framework

2017-07-07 Thread Tan, Jianfeng
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tan, Jianfeng > Sent: Friday, July 7, 2017 2:56 PM > To: Hu, Jiayu; dev@dpdk.org > Cc: Ananyev, Konstantin; y...@fridaylinux.org; > step...@networkplumber.org; Wu, Jingjing; Yao, Lei A > Subject: Re: [dpdk-dev] [P

Re: [dpdk-dev] [PATCH v3] examples/vhost: introduce a new vhost-user-scsi sample application

2017-07-07 Thread Hemant Agrawal
On 7/7/2017 10:37 AM, Yuanhan Liu wrote: On Sat, Jul 08, 2017 at 01:21:37PM +0800, Changpeng Liu wrote: vhost-user protocol is common to many virtio devices, such as virtio_net/virtio_scsi/virtio_blk. Since DPDK vhost library removed the NET specific data structures, the vhost library is common

Re: [dpdk-dev] [PATCH v5 2/4] net/ixgbe: add support of reset

2017-07-07 Thread Thomas Monjalon
07/07/2017 10:25, Thomas Monjalon: > Hi, > > 30/06/2017 12:12, Wei Dai: > > +/* > > + * Reest PF device. > > + */ > > +static int > > +ixgbe_dev_reset(struct rte_eth_dev *dev) > > +{ > > + int ret; > > + > > + /* To avoid unexpected behavior in VF, disable PF reset */ > > + if (d

Re: [dpdk-dev] [PATCH v8 6/6] devargs: parse bus info

2017-07-07 Thread Gaëtan Rivet
On Thu, Jul 06, 2017 at 05:45:02PM -0700, Stephen Hemminger wrote: > On Fri, 7 Jul 2017 02:03:12 +0200 > Gaetan Rivet wrote: > > > +static int > > +bus_name_cmp(const struct rte_bus *bus, const void *_name) > > +{ > > + const char *name = _name; > > + > > + return strncmp(bus->name, name, >

Re: [dpdk-dev] [PATCH v5 2/4] net/ixgbe: add support of reset

2017-07-07 Thread Thomas Monjalon
Hi, 30/06/2017 12:12, Wei Dai: > +/* > + * Reest PF device. > + */ > +static int > +ixgbe_dev_reset(struct rte_eth_dev *dev) > +{ > + int ret; > + > + /* To avoid unexpected behavior in VF, disable PF reset */ > + if (dev->data->sriov.active) > + return -ENOTSUP; >

[dpdk-dev] [pull-request] next-eventdev 17.08 rc1

2017-07-07 Thread Jerin Jacob
The following changes since commit cfea1f3048d1bfda61036e6f823949fba4d692d4: app/testpmd: print statistics periodically (2017-07-06 14:03:34 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to 76ee670f6a91f27eed7e06d2272

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: add hot plug monitor in i40e

2017-07-07 Thread Thomas Monjalon
29/06/2017 07:01, Jeff Guo: > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -1283,6 +1283,7 @@ static inline void i40e_GLQF_reg_init(struct i40e_hw > *hw) > > /* enable uio intr after callback register */ > rte_intr_enable(intr_handle); > + >

Re: [dpdk-dev] [RFC 01/19] vhost: protect virtio_net device struct

2017-07-07 Thread Maxime Coquelin
On 07/05/2017 12:07 PM, Jens Freimann wrote: On Tue, Jul 04, 2017 at 11:49:04AM +0200, Maxime Coquelin wrote: virtio_net device might be accessed while being reallocated in case of NUMA awareness. This case might be theoretical, but it will be needed anyway to protect vrings pages against inva