> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Tuesday, July 4, 2017 11:53 AM
> To: Van Haaren, Harry <harry.van.haa...@intel.com>
> Cc: dev@dpdk.org; tho...@monjalon.net; Wiles, Keith <keith.wi...@intel.com>; 
> Richardson,
> Bruce <bruce.richard...@intel.com>
> Subject: Re: [PATCH v3 5/7] service cores: enable event/sw with service
> 
> -----Original Message-----
> > Date: Sun, 2 Jul 2017 22:35:12 +0100
> > From: Harry van Haaren <harry.van.haa...@intel.com>
> > To: dev@dpdk.org
> > CC: jerin.ja...@caviumnetworks.com, tho...@monjalon.net,
> >  keith.wi...@intel.com, bruce.richard...@intel.com, Harry van Haaren
> >  <harry.van.haa...@intel.com>
> > Subject: [PATCH v3 5/7] service cores: enable event/sw with service
> > X-Mailer: git-send-email 2.7.4
> >
> > This commit shows how easy it is to enable a specific
> > DPDK component with a service callback, in order to get
> > CPU cycles for it.
> >
> > The beauty of this method is that the service is unaware
> > of how much CPU time it is getting - the application can
> > decide how to split and slice cores and map them to the
> > registered services.
> >
> > Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com>

<snip>

> > +
> > +   /* check a service core is mapped to this service */
> > +   struct rte_service_spec *s = rte_service_get_by_name(sw->service_name);
> > +   if (!rte_service_is_running(s))
> > +           SW_LOG_ERR("Warning: No Service core enabled on service %s\n",
> > +                           s->name);
> 
> For now, we can print just Warning. Once we remove schedule api from
> eventdev then we can make it as error. Right?

Yes correct.

> Acked-by: Jerin Jacob <jerin.ja...@caviumnetworks.com>

Thanks, will include in v+1.

Reply via email to