Response in-line: > -----Original Message----- > From: Mcnamara, John > Sent: Monday, June 26, 2017 10:38 AM > To: Carrillo, Erik G <erik.g.carri...@intel.com>; tho...@monjalon.net > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] doc: add new targets to "make help" > output > > > > > -----Original Message----- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gabriel Carrillo > > Sent: Tuesday, June 6, 2017 5:43 PM > > To: tho...@monjalon.net > > Cc: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v2] doc: add new targets to "make help" > > output > > > > Commit aafaea3d3b70 ("devtools: add tags and cscope index generation") > > introduced new make targets. This change updates the help target > > output to reflect the additions. > > > > Signed-off-by: Gabriel Carrillo <erik.g.carri...@intel.com> > > --- > > doc/build-sdk-quick.txt | 21 +++++++++++---------- > > 1 file changed, 11 insertions(+), 10 deletions(-) > > > > diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt index > > 8d41052..8ed9d80 100644 > > --- a/doc/build-sdk-quick.txt > > +++ b/doc/build-sdk-quick.txt > > @@ -1,16 +1,17 @@ > > Basic build > > make config T=x86_64-native-linuxapp-gcc && make Build > commands > > - config get configuration from target template (T=) > > - all same as build (default rule) > > - build build in a configured directory > > - clean remove files but keep configuration > > - install T= configure, build and install a target in DESTDIR > > - install install optionally staged in DESTDIR > > - examples build examples for given targets (T=) > > - examples_clean clean examples for given targets (T=) > > - test compile tests and run basic unit tests > > - test-* run specific subset of unit tests > > + config get configuration from target template (T=) > > + all same as build (default rule) > > + build build in a configured directory > > + clean remove files but keep configuration > > + install T= configure, build and install a target in DESTDIR > > + install install optionally staged in DESTDIR > > + examples build examples for given targets (T=) > > + examples_clean clean examples for given targets (T=) > > + test compile tests and run basic unit tests > > + test-* run specific subset of unit tests > > + tags|gtags|cscope [T=] generate tags or cscope index > > Build variables > > EXTRA_CPPFLAGS preprocessor options > > EXTRA_CFLAGS compiler options > > -- > > Hi, > > Thanks for this. Unfortunately there is a mix of tabs and spaces used for the > alignment so the output cat look funny depending on tab settings. > > I know that Thomas commented that the previous version was too verbose > but it looked better to me. Maybe we could compromise on: > > tags|gtags T= generate tags/gtags for given targets (T=) > cscope T= generate cscope database for given targets (T=) > > John >
Thanks for the feedback, John. I'll submit an updated patch. Regards, Gabriel
