Re: [dpdk-dev] [PATCH 5/6] eal/ppc64: rte pause implementation for ppc64

2017-05-17 Thread Chao Zhu
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: 2017年5月11日 18:11 > To: dev@dpdk.org > Cc: tho...@monjalon.net; jianbo@linaro.org; vikto...@rehivetech.com; > Jerin Jacob ; Chao Zhu > > Subject: [dpdk-dev] [PATCH 5/6] eal/ppc64: rte pause implemen

Re: [dpdk-dev] [PATCH] examples/performance-thread: add arm64 support

2017-05-17 Thread Jianbo Liu
On 18 May 2017 at 02:44, Jerin Jacob wrote: > -Original Message- >> Date: Wed, 17 May 2017 11:19:49 -0700 >> From: Ashwin Sekhar T K >> To: jerin.ja...@caviumnetworks.com, john.mcnam...@intel.com, >> jianbo@linaro.org >> Cc: dev@dpdk.org, Ashwin Sekhar T K >> Subject: [dpdk-dev] [PA

[dpdk-dev] [PATCH] net/i40e/base: fix TX error stats on VF

2017-05-17 Thread Wenzhuo Lu
Unfortunately the datasheet has a mistake. The address of the TX error counter is wrong. Fixes: 8db9e2a1b232 ("i40e: base driver") CC: sta...@dpdk.org Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/base/i40e_register.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

[dpdk-dev] [PATCH 23/23] bnxt: add code to support vlan_pvid_set dev_op

2017-05-17 Thread Ajit Khaparde
This patch adds code to support vlan_pvid_set dev_op Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 21 + drivers/net/bnxt/bnxt_hwrm.c | 31 +++ drivers/net/bnxt/bnxt_hwrm.h | 1 + 3 files changed, 53 insertions(+) diff --g

[dpdk-dev] [PATCH 20/23] bnxt: reorg the query stats code

2017-05-17 Thread Ajit Khaparde
1) Use hwrm_stat_ctx_query command to query statistics Using hwrm_stat_ctx_query command will allow polling the statistics from hardware instead of using the current push model from the hardware which does a DMA of the stats to the host at fixed intervals. 2) Use the rx_mbuf_alloc_fail to track mbu

[dpdk-dev] [PATCH 19/23] bnxt: add additonal HWRM debug info to error messages

2017-05-17 Thread Ajit Khaparde
Add the cmd_err and opaque_0 and opaque_1 fields to HWRM error messages. These allow better debugging of some classes of HWRM errors. Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 19 -- drivers/net/bnxt/hsi_struct_def_dpd

[dpdk-dev] [PATCH 22/23] bnxt: Add support to set VF rxmode

2017-05-17 Thread Ajit Khaparde
This patch adds support to configure the VF L2 Rx settings. The per VF setting is maintained in bnxt_child_vf_info.l2_rx_mask Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 20 +++- drivers/net/bnxt/bnxt_hwrm.h | 2 ++ drivers/net/bnxt/bnxt_rxq

[dpdk-dev] [PATCH 14/23] bnxt: add support for set_mc_addr_list and mac_addr_set

2017-05-17 Thread Ajit Khaparde
This patch adds support for set_mc_addr_list and mac_addr_set dev_ops Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 68 ++ drivers/net/bnxt/bnxt_hwrm.c | 11 +-- drivers/net/bnxt/bnxt_vnic.c | 7 - drivers/net/bnxt/bnxt_vni

[dpdk-dev] [PATCH 18/23] bnxt: add rxq_info_get and txq_info_get dev_ops

2017-05-17 Thread Ajit Khaparde
Add support for txq_info_get and rxq_info_get dev_ops Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 7fafd02..d6c36b

[dpdk-dev] [PATCH 17/23] bnxt: add support for LRO

2017-05-17 Thread Ajit Khaparde
This patch adds support to enable and disable LRO To support this feature, the driver creates an aggregrator ring. When the hardware starts doing LRO, it sends a tpa_start completion. When the driver receives a tpa_end completion, it indicates that the LRO chaining is complete. Signed-off-by: Stee

[dpdk-dev] [PATCH 15/23] bnxt: add support for fw_version_get dev_op

2017-05-17 Thread Ajit Khaparde
This patch adds support for fw_version_get dev_op Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 9a0acee..9d503b7 100644 --- a/drivers/

[dpdk-dev] [PATCH 16/23] bnxt: add support to set MTU

2017-05-17 Thread Ajit Khaparde
This patch adds support to modify MTU using the set_mtu dev_op. To support frames > 2k, the PMD creates an aggregator ring. When a frame greater than 2k is received, it is fragmented and the resulting fragments are DMA'ed to the aggregator ring. Now the driver can support jumbo frames upto 9500 byt

[dpdk-dev] [PATCH 10/23] bnxt: add support to add a VF MAC address

2017-05-17 Thread Ajit Khaparde
This patch adds support to allocate a filter and program it in the hardware for every MAC address added to the specified function. Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filter.c| 22 ++ drivers/net/bnxt/bnxt_filter.h|

[dpdk-dev] [PATCH 13/23] bnxt: add code to configure a default VF VLAN

2017-05-17 Thread Ajit Khaparde
This patch adds code to insert a default VF VLAN. Also track the current default VLAN per vnic for the VF. When setting the default VLAN, avoid setting it to the current value. Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 1 + drivers

[dpdk-dev] [PATCH 11/23] bnxt: add support for xstats get/reset

2017-05-17 Thread Ajit Khaparde
This patch adds support to get and reset xstats dev_ops dev_ops added: xstats_get, xstats_get_name, xstats_reset HWRM commands added: hwrm_port_qstats, hwrm_port_clr_stats Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 7 + drivers/net/bnxt/bnxt_ethdev.c |

[dpdk-dev] [PATCH 12/23] bnxt: Add support for VLAN filter and strip dev_ops

2017-05-17 Thread Ajit Khaparde
This patch adds VLAN strip and offload callbacks. To add a VLAN filter: For each VNIC and each associated filter(s) if VLAN exists: if VLAN matches vlan_id VLAN filter already exists, just skip and continue else add a new MAC+VLAN

[dpdk-dev] [PATCH 09/23] bnxt: add code to determine the Rx status of VF

2017-05-17 Thread Ajit Khaparde
This patch adds code to determine the Rx status of a VF. It adds the rte_pmd_bnxt_get_vf_rx_status call, which calculates the VNIC count of the function to get the Rx status. Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 24

[dpdk-dev] [PATCH 08/23] bnxt: add support to get and clear VF specific stats

2017-05-17 Thread Ajit Khaparde
This patch adds code to get and clear VF stats. It also adds the necessary HWRM structures to send the command to the firmware. Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 75 drivers/net/bnxt/bnxt_hwrm.h | 5 +

[dpdk-dev] [PATCH 07/23] bnxt: add support for VLAN stripq, VLAN anti spoof and VLAN filtering for VFs

2017-05-17 Thread Ajit Khaparde
This patch adds support for VF VLAN stripq, VF VLAN anti spoof and VF VLAN filtering. The VF VLAN filtering needs the VLAN anti spoof setting to be set first before the command to program the VLAN table is sent to the firmware. Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- driver

[dpdk-dev] [PATCH 06/23] bnxt: add support for set VF QOS and MAC anti spoof

2017-05-17 Thread Ajit Khaparde
This patch adds support to 1) enable VF MAC anti spoof. 2) QOS configuration for specified VF. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 2 + drivers/net/bnxt/bnxt_hwrm.c | 33 +++ drivers/net/bnxt/bnxt_hwrm.h | 3 + drivers/

[dpdk-dev] [PATCH 05/23] bnxt: add functions for tx_loopback, set_vf_mac and queues_drop_en

2017-05-17 Thread Ajit Khaparde
Add functions rte_pmd_bnxt_set_tx_loopback, rte_pmd_bnxt_set_all_queues_drop_en and rte_pmd_bnxt_set_vf_mac_addr to configure tx_loopback, queue_drop and VF MAC address setting in the hardware. It also adds the necessary functions to send the HWRM commands to the firmware. Signed-off-by: Steeven L

[dpdk-dev] [PATCH 01/23] bnxt: add various hwrm input/output structures

2017-05-17 Thread Ajit Khaparde
This patch adds various hwrm API which allows the configuration and allocation of resources for a PCI function depending on whether it is a PF or a VF. These structures will be used in subsequent patches. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 1497

[dpdk-dev] [PATCH 04/23] bnxt: support lack of huge pages

2017-05-17 Thread Ajit Khaparde
rte_malloc_virt2phy() does not return a physical address if huge pages aren't in use. Further, rte_memzone->phys_addr is not a physical address. Use rte_mem_virt2phy() and manually lock pages to support lack of huge pages. Also check the return value of rte_mem_virt2phy() Verify the function re

[dpdk-dev] [PATCH 03/23] bnxt: add tunneling support

2017-05-17 Thread Ajit Khaparde
Add support for udp_tunnel_port_add/del dev_ops to configure a UDP port for VXLAN and Geneve Tunnel protocols. The HWRM supports only one global destination port for a tunnel type, use a referene counter to keep track of its usage. Cache the configured VXLAN/Geneve ports and use that value to check

[dpdk-dev] [PATCH 02/23] bnxt: code reorg to properly allocate resources in PF/VF modes

2017-05-17 Thread Ajit Khaparde
1) Move the function reset to bnxt_dev_init() 2) After a function reset, configure the VFs. Distribute resources evenly between all functions (PF and VF) for now. In the future, this should be controllable. 3) Since PF/VF need to allocate resources from a pool in the hardware, use func_qcaps and f

[dpdk-dev] [PATCH 00/23] bnxt patchset

2017-05-17 Thread Ajit Khaparde
This patchset amongst other changes adds support few more dev_ops, updates HWRM to version 1.7.5, switches to polling stats from the hardware, support for LRO etc.. bnxt: add various hwrm input/output structures bnxt: code reorg to properly allocate resources in PF/VF modes bnxt: add tunneli

Re: [dpdk-dev] [RFC] Enable primary/secondary model for vdev

2017-05-17 Thread Tan, Jianfeng
Any comments please? > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tan, Jianfeng > Sent: Thursday, May 11, 2017 2:20 PM > To: dev@dpdk.org > Cc: Thomas Monjalon; Richardson, Bruce; Ananyev, Konstantin; Stephen > Hemminger; Yuanhan Liu; Yigit, Ferruh; Yang, Zhi

Re: [dpdk-dev] [PATCH v8] net/i40e: improved FDIR programming times

2017-05-17 Thread Xing, Beilei
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michael Lilja > Sent: Wednesday, May 17, 2017 10:58 PM > To: Zhang, Helin ; Wu, Jingjing > > Cc: dev@dpdk.org; Michael Lilja > Subject: [dpdk-dev] [PATCH v8] net/i40e: improved FDIR programming times > > Pre

Re: [dpdk-dev] [PATCH] net/e1000: support MAC filters for i210 and i211 chips

2017-05-17 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Markus Theil [mailto:markus.th...@tu-ilmenau.de] > Sent: Thursday, May 18, 2017 2:06 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Markus Theil > Subject: [PATCH] net/e1000: support MAC filters for i210 and i211 chips > > i210 and i211 also support unicast MAC

[dpdk-dev] [PATCH v4 8/8] net/enic: flow API documentation

2017-05-17 Thread John Daley
Update enic NIC guide, release notes and add flow API to the supported features list. Signed-off-by: John Daley Reviewed-by: Nelson Escobar --- doc/guides/nics/enic.rst | 52 ++ doc/guides/nics/features/enic.ini | 1 + doc/guides/rel_notes/rel

[dpdk-dev] [PATCH v4 6/8] net/enic: flow API for Legacy NICs

2017-05-17 Thread John Daley
5-tuple exact Flow support for 1200 series adapters. This allows: Attributes: ingress Items: ipv4, ipv6, udp, tcp (must exactly match src/dst IP addresses and ports and all must be specified). Actions: queue and void Selectors: 'is' Signed-off-by: John Daley Reviewed-by: Nelson Escobar --

[dpdk-dev] [PATCH v4 7/8] net/enic: flow API debug

2017-05-17 Thread John Daley
Added a debug function to print enic filters and actions when rte_validate_flow is called. Compiled in CONFIG_RTE_LIBRTE_ENIC_DEBUG_FLOW is enabled and log level is INFO. Signed-off-by: John Daley Reviewed-by: Nelson Escobar --- drivers/net/enic/enic_flow.c | 138 +++

[dpdk-dev] [PATCH v4 1/8] net/enic: bring NIC interface functions up to date

2017-05-17 Thread John Daley
Update the base functions for the Cisco VIC. These files are mostly common with other VIC drivers so are left alone is as much as possilbe. Includes in a new filter/action interface which is needed for Generic Flow API PMD support. Update FDIR code to use the new interface. Signed-off-by: John Dal

[dpdk-dev] [PATCH v4 3/8] net/enic: flow API for NICs with advanced filters enabled

2017-05-17 Thread John Daley
Flow support for 1300 series adapters with the 'Advanced Filter' mode enabled via the UCS management interface. This enables: Attributes: ingress Items: Outer eth, ipv4, ipv6, udp, sctp, tcp, vxlan. Inner eth, ipv4, ipv6, udp, tcp. Actions: queue, and void Selectors: 'is', 'spec' and 'mask'.

[dpdk-dev] [PATCH v4 0/8] enic flow api support

2017-05-17 Thread John Daley
Sorry for the inconvenience Ferruh, hopefully this set will work better. V4 patchset changes: - include patch that was missing in V3 which caused compile errors - put mark and flag support into a separate patch to make it more clear what the code changes in enic_rxtx.c were for - fixed a documen

[dpdk-dev] [PATCH v4 5/8] net/enic: flow API for NICs with advanced filters disabled

2017-05-17 Thread John Daley
Flow support for 1300 series adapters with the 'Advanced Filter' mode disabled via the UCS management interface. This allows: Attributes: ingress Items: Outer eth, ipv4, ipv6, udp, sctp, tcp, vxlan. Inner eth, ipv4, ipv6, udp, tcp. Actions: queue and void Selectors: 'is', 'spec' and 'mask'.

[dpdk-dev] [PATCH v4 2/8] net/enic: flow API skeleton

2017-05-17 Thread John Daley
Stub callbacks for the generic flow API and a new FLOW debug define. Signed-off-by: John Daley Reviewed-by: Nelson Escobar --- config/common_base | 1 + drivers/net/enic/Makefile | 1 + drivers/net/enic/enic.h| 1 + drivers/net/enic/enic_ethdev.c | 18 - driv

[dpdk-dev] [PATCH v4 4/8] net/enic: flow API mark and flag support

2017-05-17 Thread John Daley
For VICs with filter tagging, support the MARK and FLAG actions by setting appropriate mbuf ol_flags if there is a filter match. Signed-off-by: John Daley Reviewed-by: Nelson Escobar --- drivers/net/enic/enic_rxtx.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff -

Re: [dpdk-dev] [PATCH] examples/performance-thread: add arm64 support

2017-05-17 Thread Jerin Jacob
-Original Message- > Date: Wed, 17 May 2017 11:19:49 -0700 > From: Ashwin Sekhar T K > To: jerin.ja...@caviumnetworks.com, john.mcnam...@intel.com, > jianbo@linaro.org > Cc: dev@dpdk.org, Ashwin Sekhar T K > Subject: [dpdk-dev] [PATCH] examples/performance-thread: add arm64 support >

[dpdk-dev] [PATCH] examples/performance-thread: add arm64 support

2017-05-17 Thread Ashwin Sekhar T K
Updated Makefile to allow compilation for arm64 architecture. Moved the code for setting the initial stack to architecture specific directory. Added implementation of context-switch for arm64 architecture. Fixed minor compilation errors for arm64 compilation. Signed-off-by: Ashwin Sekhar T K -

Re: [dpdk-dev] [PATCH v2] eventdev: clarify atomic and ordered queue config

2017-05-17 Thread Jerin Jacob
-Original Message- > Date: Mon, 15 May 2017 14:40:14 -0500 > From: Gage Eads > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com > Subject: [PATCH v2] eventdev: clarify atomic and ordered queue config > X-Mailer: git-send-email 2.7.4 > > The nb_atomic_flows and nb_atomic_order_sequenc

[dpdk-dev] [PATCH] net/e1000: support MAC filters for i210 and i211 chips

2017-05-17 Thread Markus Theil
i210 and i211 also support unicast MAC filters. The patch was tested on i210 based hw, for i211 support was looked up in the specs. Signed-off-by: Markus Theil --- drivers/net/e1000/igb_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/e1000/igb_ethdev.c

[dpdk-dev] [PATCH 3/3] net/af_packet: fix packet bytes counting

2017-05-17 Thread Charles (Chas) Williams
On error, we also need to zero the bytes transmitted. Signed-off-by: Charles (Chas) Williams --- drivers/net/af_packet/rte_eth_af_packet.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_pack

[dpdk-dev] [PATCH 1/3] net/af_packet: handle strdup() failures

2017-05-17 Thread Charles (Chas) Williams
Fixes: 1b93c2aa81b4 ("net/af_packet: add interface name to internals") Signed-off-by: Chas Williams --- drivers/net/af_packet/rte_eth_af_packet.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index a03

[dpdk-dev] [PATCH 2/3] net/af_packet: add accessor for iface

2017-05-17 Thread Charles (Chas) Williams
Provide an accessor for the name of the underlying linux interface used by the AF_PACKET-based interface. Signed-off-by: Charles (Chas) Williams --- drivers/net/af_packet/Makefile | 2 + drivers/net/af_packet/rte_eth_af_packet.c | 17 +++ drivers/net/af_packet/r

Re: [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: added sample app

2017-05-17 Thread Jerin Jacob
-Original Message- > Date: Fri, 21 Apr 2017 10:51:37 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, Harry van Haaren > , Gage Eads , Bruce > Richardson > Subject: [PATCH 1/3] examples/eventdev_pipeline: added sample app > X-Mailer: git-send-email

Re: [dpdk-dev] [RFC][PATCH] vfio: allow to map other memory regions

2017-05-17 Thread Stephen Hemminger
On Wed, 17 May 2017 16:44:46 +0200 Pawel Wodkowski wrote: > /* IOMMU types we support */ > static const struct vfio_iommu_type iommu_types[] = { > /* x86 IOMMU, otherwise known as type 1 */ > - { RTE_VFIO_TYPE1, "Type 1", &vfio_type1_dma_map}, > + { RTE_VFIO_TYPE1, "Type 1", &vfio

Re: [dpdk-dev] [PATCH v2 00/13] introduce fail-safe PMD

2017-05-17 Thread Gaëtan Rivet
On Wed, May 17, 2017 at 01:50:40PM +0100, Ferruh Yigit wrote: On 3/20/2017 3:00 PM, Thomas Monjalon wrote: There have been some discussions on this new PMD and it will be discussed today in the techboard meeting. I would like to expose my view and summarize the solutions I have heard. First it

Re: [dpdk-dev] [RFC 17.08] flow_classify: add librte_flow_classify library

2017-05-17 Thread Gaëtan Rivet
Hi Ferruh, On Wed, May 17, 2017 at 05:02:50PM +0100, Ferruh Yigit wrote: On 5/17/2017 3:54 PM, Ananyev, Konstantin wrote: Hi Ferruh, Please see my comments/questions below. Thanks for review. Thanks Konstantin <...> I think it was discussed already, but I still wonder why rte_flow_item

Re: [dpdk-dev] [RFC 17.08] flow_classify: add librte_flow_classify library

2017-05-17 Thread Ananyev, Konstantin
> > On 5/17/2017 3:54 PM, Ananyev, Konstantin wrote: > > Hi Ferruh, > > Please see my comments/questions below. > > Thanks for review. > > > Thanks > > Konstantin > > <...> > > > I think it was discussed already, but I still wonder why rte_flow_item > > can't be used for that approach? > >

Re: [dpdk-dev] [RFC 17.08] flow_classify: add librte_flow_classify library

2017-05-17 Thread Ananyev, Konstantin
> > Hi Ferruh, > > Please see my comments/questions below. > > Thanks > > Konstantin > > > >> + > >> +/** > >> + * @file > >> + * > >> + * RTE Flow Classify Library > >> + * > >> + * This library provides flow record information with some measured > >> properties. > >> + * > >> + * Application can

Re: [dpdk-dev] [RFC 17.08] flow_classify: add librte_flow_classify library

2017-05-17 Thread Ferruh Yigit
On 5/17/2017 3:54 PM, Ananyev, Konstantin wrote: > Hi Ferruh, > Please see my comments/questions below. Thanks for review. > Thanks > Konstantin <...> > I think it was discussed already, but I still wonder why rte_flow_item can't > be used for that approach? Missed this one: Gaëtan also had

Re: [dpdk-dev] Discuss plugin threading model for DPDK.

2017-05-17 Thread Thomas Monjalon
17/05/2017 16:51, Wiles, Keith: > > > On May 17, 2017, at 4:28 AM, Thomas Monjalon wrote: > > > > OK to register CPU needs for services (including interrupts processing). > > > > Then we could take this opportunity to review how threads are managed. > > We will have three types of cores: > > -

Re: [dpdk-dev] [RFC 17.08] flow_classify: add librte_flow_classify library

2017-05-17 Thread Ferruh Yigit
On 5/17/2017 3:54 PM, Ananyev, Konstantin wrote: > Hi Ferruh, > Please see my comments/questions below. > Thanks > Konstantin > >> + >> +/** >> + * @file >> + * >> + * RTE Flow Classify Library >> + * >> + * This library provides flow record information with some measured >> properties. >> + * >>

Re: [dpdk-dev] [PATCH v8] net/i40e: improved FDIR programming times

2017-05-17 Thread Michael Lilja
Please fix while applying. -Original Message- From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] Sent: 17 May 2017 17:17 To: Michael Lilja ; helin.zh...@intel.com; jingjing...@intel.com Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v8] net/i40e: improved FDIR programming times On 5/17

Re: [dpdk-dev] [PATCH v8] net/i40e: improved FDIR programming times

2017-05-17 Thread Ferruh Yigit
On 5/17/2017 3:57 PM, Michael Lilja wrote: > Previously, the FDIR programming time is +11ms on i40e. > This patch will result in an average programming time of > 22usec with a max of 60usec . > > Signed-off-by: Michael Lilja <...> > /* totally delay 10 ms to check programming status*/ > -

[dpdk-dev] [PATCH v8] net/i40e: improved FDIR programming times

2017-05-17 Thread Michael Lilja
Previously, the FDIR programming time is +11ms on i40e. This patch will result in an average programming time of 22usec with a max of 60usec . Signed-off-by: Michael Lilja --- v8: * Merged two defines into one handling max wait time v7: * Code style changes v6: * Fixed code style issues v5: *

Re: [dpdk-dev] [RFC 17.08] flow_classify: add librte_flow_classify library

2017-05-17 Thread Ananyev, Konstantin
Hi Ferruh, Please see my comments/questions below. Thanks Konstantin > + > +/** > + * @file > + * > + * RTE Flow Classify Library > + * > + * This library provides flow record information with some measured > properties. > + * > + * Application can select variety of flow types based on various fl

Re: [dpdk-dev] [PATCH v7] net/i40e: improved FDIR programming times

2017-05-17 Thread Michael Lilja
Ok, I'll make a v8 removing the define. /Michael -Original Message- From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] Sent: 17 May 2017 16:50 To: Michael Lilja ; helin.zh...@intel.com; jingjing...@intel.com Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7] net/i40e: improved FDIR pro

[dpdk-dev] Discuss plugin threading model for DPDK.

2017-05-17 Thread Wiles, Keith
> On May 17, 2017, at 4:28 AM, Thomas Monjalon wrote: > > OK to register CPU needs for services (including interrupts processing). > > Then we could take this opportunity to review how threads are managed. > We will have three types of cores: > - not used > - reserved for services > - used for

Re: [dpdk-dev] [PATCH v7] net/i40e: improved FDIR programming times

2017-05-17 Thread Ferruh Yigit
On 5/17/2017 3:46 PM, Michael Lilja wrote: > It's ok. I didn't write the original code so I cannot tell why the two > defines were made in the initial case. It make sense to remove them, but the > maintainers must have had a reason, maybe they are needed in a future version > of the code? In or

Re: [dpdk-dev] [PATCH v7] net/i40e: improved FDIR programming times

2017-05-17 Thread Michael Lilja
It's ok. I didn't write the original code so I cannot tell why the two defines were made in the initial case. It make sense to remove them, but the maintainers must have had a reason, maybe they are needed in a future version of the code? /Michael -Original Message- From: Ferruh Yigit

Re: [dpdk-dev] [PATCH v7] net/i40e: improved FDIR programming times

2017-05-17 Thread Ferruh Yigit
On 5/17/2017 3:31 PM, Michael Lilja wrote: > Previously, the FDIR programming time is +11ms on i40e. > This patch will result in an average programming time of > 22usec with a max of 60usec . > > Signed-off-by: Michael Lilja Sorry for multiple, minor change requests ... > > --- > v7: > * Code

[dpdk-dev] [PATCH v7] net/i40e: improved FDIR programming times

2017-05-17 Thread Michael Lilja
Previously, the FDIR programming time is +11ms on i40e. This patch will result in an average programming time of 22usec with a max of 60usec . Signed-off-by: Michael Lilja --- v7: * Code style changes v6: * Fixed code style issues v5: * Reinitialization of "i" inconsistent with original intent

Re: [dpdk-dev] [PATCH] examples/helloworld: add output of core id and socket id

2017-05-17 Thread Ferruh Yigit
On 5/17/2017 3:29 PM, Dai, Wei wrote: >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, May 17, 2017 10:16 PM >> To: Dai, Wei ; Richardson, Bruce >> ; Mcnamara, John >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] examples/helloworld: add output of core id >> and >>

Re: [dpdk-dev] [PATCH] examples/helloworld: add output of core id and socket id

2017-05-17 Thread Dai, Wei
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, May 17, 2017 10:16 PM > To: Dai, Wei ; Richardson, Bruce > ; Mcnamara, John > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/helloworld: add output of core id and > socket id > > On 5/17/2017 2:49 PM, Wei Dai wrote

Re: [dpdk-dev] [PATCH] examples/helloworld: add output of core id and socket id

2017-05-17 Thread Ferruh Yigit
On 5/17/2017 2:49 PM, Wei Dai wrote: > Adding output of core id and socket id of each lcore/pthread > can help to understand their relationship. > And this can also help to examine the usage of the EAL lcore > settings like -c, -l and --lcore . > > Signed-off-by: Wei Dai > --- > examples/hellowo

Re: [dpdk-dev] [PATCH v6] net/i40e: improved FDIR programming times

2017-05-17 Thread Ferruh Yigit
On 5/17/2017 2:45 PM, Michael Lilja wrote: > Previously, the FDIR programming time is +11ms on i40e. > This patch will result in an average programming time of > 22usec with a max of 60usec . > > Signed-off-by: Michael Lilja Please cc maintainers in the patch. > > --- > v6: > * Fixed code styl

[dpdk-dev] [PATCH] examples/helloworld: add output of core id and socket id

2017-05-17 Thread Wei Dai
Adding output of core id and socket id of each lcore/pthread can help to understand their relationship. And this can also help to examine the usage of the EAL lcore settings like -c, -l and --lcore . Signed-off-by: Wei Dai --- examples/helloworld/main.c | 4 +++- 1 file changed, 3 insertions(+),

Re: [dpdk-dev] [RFC] service core concept header implementation

2017-05-17 Thread Ananyev, Konstantin
Hi Bruce, > > > > Hi Konstantin, > > Thanks for the feedback, the specific detail of which I'll perhaps leave > for Harry to reply to or include in a later version of this patchset. > However, from a higher level, I think the big difference in what we > envisage compared to what you suggest in y

[dpdk-dev] [PATCH v6] net/i40e: improved FDIR programming times

2017-05-17 Thread Michael Lilja
Previously, the FDIR programming time is +11ms on i40e. This patch will result in an average programming time of 22usec with a max of 60usec . Signed-off-by: Michael Lilja --- v6: * Fixed code style issues v5: * Reinitialization of "i" inconsistent with original intent v4: * Code style fix v3

Re: [dpdk-dev] [PATCH v4] net/ixgbe: ensure link status is updated

2017-05-17 Thread Roger B Melton
Hi Laurent/Wei, As I continue to integrate DPDK 17.05 into my application, I have hit another issue with this patch while testing in a VM with multispeed fiber ixgbe PCI passthrough. My application periodically invokes rte_eth_link_get_nowait() to detect link state changes. If the link is d

Re: [dpdk-dev] [PATCH v3] drivers/net: document missing speed capabilities feature

2017-05-17 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Monday, May 15, 2017 1:31 PM > To: Shepard Siegel ; Ed Czeck > ; John Miller ; > Mcnamara, John ; Harish Patil > ; Rasesh Mody ; Rahul > Lakkireddy ; Hemant Agrawal > ; Shreyansh Jain ; Lu, > Wenzhuo ; Marcin Wojtas ; Michal > Krawczyk ;

Re: [dpdk-dev] Proposed schedule dates for DPDK 17.08, 17.11 and 18.02

2017-05-17 Thread Thomas Monjalon
Hi, 04/05/2017 18:52, Mcnamara, John: > The current 17.08 schedule dates are: > > 17.08 > * Proposal deadline:May 28, 2017 > * Integration deadline: June 29, 2017 > * Release: August1, 2017 I think these dates are good and must be strictl

Re: [dpdk-dev] [RFC] service core concept header implementation

2017-05-17 Thread Bruce Richardson
On Wed, May 17, 2017 at 12:47:52PM +, Ananyev, Konstantin wrote: > Hi Harry, > I had a look, my questions/comments below. > From my perspective it looks like an attempt to introduce simple scheduling > library inside DPDK. > Though some things left unclear from my perspective, but probably I

Re: [dpdk-dev] [PATCH v2 00/13] introduce fail-safe PMD

2017-05-17 Thread Ferruh Yigit
On 3/20/2017 3:00 PM, Thomas Monjalon wrote: > There have been some discussions on this new PMD and it will be > discussed today in the techboard meeting. > > I would like to expose my view and summarize the solutions I have heard. > First it is important to remind that everyone agrees on the need

Re: [dpdk-dev] [RFC] service core concept header implementation

2017-05-17 Thread Ananyev, Konstantin
Hi Harry, I had a look, my questions/comments below. >From my perspective it looks like an attempt to introduce simple scheduling >library inside DPDK. Though some things left unclear from my perspective, but probably I just misunderstood your intentions here. Thanks Konstantin > > This patch

Re: [dpdk-dev] [RFC] Service Cores concept

2017-05-17 Thread Bruce Richardson
On Wed, May 17, 2017 at 01:28:14PM +0200, Thomas Monjalon wrote: > 17/05/2017 12:32, Bruce Richardson: > > On Wed, May 17, 2017 at 12:11:10AM +0200, Thomas Monjalon wrote: > > > 03/05/2017 13:29, Harry van Haaren: > > > > The concept is to allow a software function register itself with EAL as > > >

[dpdk-dev] [PATCH 3/3] net/sfc: support multi-process

2017-05-17 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/features/sfc_efx.ini | 1 + drivers/net/sfc/sfc.h| 11 +++ drivers/net/sfc/sfc_dp_rx.h | 1 + drivers/net/sfc/sfc_dp_tx.h | 1 + drivers/net/sfc/sfc_ef10_rx.c| 2 +- d

[dpdk-dev] [PATCH 2/3] net/sfc: use locally stored data for logging

2017-05-17 Thread Andrew Rybchenko
Required to be able to use logging in the secondary process where Ethernet device pointer stored in sfc_adapter is invalid. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc.h| 2 ++ drivers/net/sfc/sfc_debug.h | 10 -- drivers/net/sfc/sfc_ethde

[dpdk-dev] [PATCH 1/3] net/sfc: carefully cleanup on init failure and shutdown

2017-05-17 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_ethdev.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index d5583ec..e4f051a 100644 --- a/drivers/

Re: [dpdk-dev] [PATCH v1] net: support PPPOE in software packet type parser

2017-05-17 Thread Chilikin, Andrey
PPPoE consists of two stages with different ethertypes - Discovery and Session, so RTE_PTYPE_L2_ETHER_PPPOE looks ambiguous to me. This patch adds only PPPoE Session Stage packet type. Should it include PPPoE Discovery Stage as well (Ethertype x8863)? /Andrey > -Original Message- > F

Re: [dpdk-dev] [RFC PATCH 00/11] net/virtio: packed ring layout

2017-05-17 Thread Jens Freimann
Hi Yuanhan, On Mon, May 08, 2017 at 01:02:57PM +0800, Yuanhan Liu wrote: > On Fri, May 05, 2017 at 09:57:11AM -0400, Jens Freimann wrote: > > I'm implementing the receive path now to eventually get some benchmark > > results for that as well (Patches not included yet) > > Good to know. Any progre

Re: [dpdk-dev] [RFC] Service Cores concept

2017-05-17 Thread Thomas Monjalon
17/05/2017 12:32, Bruce Richardson: > On Wed, May 17, 2017 at 12:11:10AM +0200, Thomas Monjalon wrote: > > 03/05/2017 13:29, Harry van Haaren: > > > The concept is to allow a software function register itself with EAL as > > > a "service", which requires CPU time to perform its duties. Multiple > >

Re: [dpdk-dev] [RFC 17.08] Flow classification library

2017-05-17 Thread Ferruh Yigit
On 5/9/2017 8:24 PM, Morten Brørup wrote: >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Tuesday, May 9, 2017 3:38 PM >> To: Morten Brørup; Mcnamara, John; dev@dpdk.org >> Cc: Tahhan, Maryam; Gaëtan Rivet >> Subject: Re: [dpdk-dev] [RFC 1

Re: [dpdk-dev] [PATCH v5] net/i40e: improved FDIR programming times

2017-05-17 Thread Ferruh Yigit
On 5/17/2017 11:38 AM, Michael Lilja wrote: > Previously, the FDIR programming time is +11ms on i40e. > This patch will result in an average programming time of > 22usec with a max of 60usec . > > Signed-off-by: Michael Lilja Please keeps maintainers in CC while sending patches. > > --- > v5:

Re: [dpdk-dev] [PATCH v3 2/6] net/enic: flow API for NICs with advanced filters enabled

2017-05-17 Thread Ferruh Yigit
On 5/17/2017 4:03 AM, John Daley wrote: > Flow support for 1300 series adapters with the 'Advanced Filter' > mode enabled via the UCS management interface. This enables: > Attributes: ingress > Items: Outer eth, ipv4, ipv6, udp, sctp, tcp, vxlan. Inner eth, ipv4, >ipv6, udp, tcp. > Actions:

Re: [dpdk-dev] [PATCH v3 6/6] net/enic: flow API documentation

2017-05-17 Thread Ferruh Yigit
On 5/17/2017 4:03 AM, John Daley wrote: > Update enic NIC guide, release notes and add flow API to the > supported features list. > > Signed-off-by: John Daley > Reviewed-by: Nelson Escobar <...> > How to build the suite > -- > +=== This part looks like git merge err

Re: [dpdk-dev] [PATCH v3 1/6] net/enic: flow API skeleton

2017-05-17 Thread Ferruh Yigit
On 5/17/2017 4:03 AM, John Daley wrote: > Stub callbacks for the generic flow API and a new FLOW debug define. > > Signed-off-by: John Daley > Reviewed-by: Nelson Escobar <...> > diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c > index 8e16a71b7..4e8a0d9e0 100644 >

Re: [dpdk-dev] [PATCH v3 3/6] net/enic: flow API for NICs with advanced filters disabled

2017-05-17 Thread Ferruh Yigit
On 5/17/2017 4:03 AM, John Daley wrote: > Flow support for 1300 series adapters with the 'Advanced Filter' > mode disabled via the UCS management interface. This allows: > Attributes: ingress > Items: Outer eth, ipv4, ipv6, udp, sctp, tcp, vxlan. Inner eth, ipv4, >ipv6, udp, tcp. > Actions:

Re: [dpdk-dev] [PATCH v3 0/6] enic flow api support

2017-05-17 Thread Ferruh Yigit
On 5/17/2017 4:03 AM, John Daley wrote: > This V3 is rebased on dpdk-next-net and retargeted at 17.08. Also, > inner ipv4, ipv6, udp, tcp support added for 1300 series VICs. > > thank you, > johnd > > John Daley (6): > net/enic: flow API skeleton > net/enic: flow API for NICs with advanced f

[dpdk-dev] [RFC][PATCH] vfio: allow to map other memory regions

2017-05-17 Thread Pawel Wodkowski
Currently it is not possible to use memory that is not owned by DPDK to perform DMA. This scenarion might be used in vhost applications (like SPDK) where guest send its own memory table. To fill this gap provide API to allow registering arbitrary address in VFIO container. Signed-off-by: Pawel Wod

Re: [dpdk-dev] [PATCH v5] net/i40e: improved FDIR programming times

2017-05-17 Thread Xing, Beilei
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michael Lilja > Sent: Wednesday, May 17, 2017 6:38 PM > To: dev@dpdk.org > Cc: Michael Lilja > Subject: [dpdk-dev] [PATCH v5] net/i40e: improved FDIR programming times > > Previously, the FDIR programming tim

[dpdk-dev] [PATCH v5] net/i40e: improved FDIR programming times

2017-05-17 Thread Michael Lilja
Previously, the FDIR programming time is +11ms on i40e. This patch will result in an average programming time of 22usec with a max of 60usec . Signed-off-by: Michael Lilja --- v5: * Reinitialization of "i" inconsistent with original intent --- --- drivers/net/i40e/i40e_fdir.c | 20 ++---

Re: [dpdk-dev] [RFC 0/2] ethdev: add new attribute for signature match

2017-05-17 Thread Adrien Mazarguil
On Sun, May 14, 2017 at 03:50:04PM -0400, Qi Zhang wrote: > We try to enable ixgbe's signature match with rte_flow, but didn't > find a way with current APIs, so the RFC propose to add a new flow > attribute "sig_match" to indicate if current flow is "perfect match" > or "signature match" > With pe

Re: [dpdk-dev] [RFC] Service Cores concept

2017-05-17 Thread Bruce Richardson
On Wed, May 17, 2017 at 12:11:10AM +0200, Thomas Monjalon wrote: > 03/05/2017 13:29, Harry van Haaren: > > The concept is to allow a software function register itself with EAL as > > a "service", which requires CPU time to perform its duties. Multiple > > services can be registered in an applicatio

Re: [dpdk-dev] [PATCH v4] net/i40e: improved FDIR programming times

2017-05-17 Thread Xing, Beilei
Hi Michael, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michael Lilja > Sent: Wednesday, May 17, 2017 5:12 PM > To: dev@dpdk.org > Cc: Michael Lilja > Subject: [dpdk-dev] [PATCH v4] net/i40e: improved FDIR programming times > > Previously, the FDIR program

[dpdk-dev] [PATCH v4] net/i40e: improved FDIR programming times

2017-05-17 Thread Michael Lilja
Previously, the FDIR programming time is +11ms on i40e. This patch will result in an average programming time of 22usec with a max of 60usec . Signed-off-by: Michael Lilja --- v4: * Code style fix --- --- drivers/net/i40e/i40e_fdir.c | 20 ++-- 1 file changed, 10 insertions(+),

Re: [dpdk-dev] [PATCH] cryptodev: remove crypto device type enumeration

2017-05-17 Thread De Lara Guarch, Pablo
Hi Slawomir, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Slawomir > Mrozowicz > Sent: Monday, May 15, 2017 10:56 AM > To: Doherty, Declan > Cc: dev@dpdk.org; Mrozowicz, SlawomirX > Subject: [dpdk-dev] [PATCH] cryptodev: remove crypto device type > enumeratio

Re: [dpdk-dev] [PATCH v3] net/i40e: Improved FDIR programming times

2017-05-17 Thread Ferruh Yigit
On 5/17/2017 3:22 AM, Xing, Beilei wrote: > Hi, > > Seems my comments in v2 are not addressed, add the comments here again. Hi Michael, And can you please use "--in-reply-to" option of the git send-email when sending the new version of the patch. To make new version of the patch in same mail thr

  1   2   >