[dpdk-dev] [PATCH] eventdev: clarify atomic and ordered queue config

2017-05-12 Thread Gage Eads
The nb_atomic_flows and nb_atomic_order_sequences fields are only inspected if the queue is configured for atomic or ordered scheduling, respectively. This commit updates the documentation to reflect that. Signed-off-by: Gage Eads --- lib/librte_eventdev/rte_eventdev.h | 15 ++- 1 fi

Re: [dpdk-dev] active_backup link bonding and mac address

2017-05-12 Thread Kyle Larose
> -Original Message- > From: Declan Doherty [mailto:declan.dohe...@intel.com] > Sent: Friday, May 12, 2017 11:47 AM > To: Kyle Larose; us...@dpdk.org; dev@dpdk.org > Subject: Re: active_backup link bonding and mac address > > > Yes it would be into the hw tables, rte_eth_dev_mac_addr_add(

Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature

2017-05-12 Thread Thomas Monjalon
12/05/2017 12:49, Ferruh Yigit: > On 5/10/2017 2:51 PM, Thomas Monjalon wrote: > > 10/05/2017 15:10, Ferruh Yigit: > >> --- a/doc/guides/nics/features/bnx2x.ini > >> +++ b/doc/guides/nics/features/bnx2x.ini > >> @@ -4,6 +4,7 @@ > >> ; Refer to default.ini for the full list of available PMD feature

Re: [dpdk-dev] active_backup link bonding and mac address

2017-05-12 Thread Declan Doherty
On 12/05/2017 4:34 PM, Kyle Larose wrote: -Original Message- From: Declan Doherty [mailto:declan.dohe...@intel.com] Sent: Friday, May 12, 2017 10:56 AM To: Kyle Larose; us...@dpdk.org; dev@dpdk.org Subject: Re: active_backup link bonding and mac address On 12/05/2017 3:31 PM, Kyle Lar

Re: [dpdk-dev] active_backup link bonding and mac address

2017-05-12 Thread Kyle Larose
> -Original Message- > From: Declan Doherty [mailto:declan.dohe...@intel.com] > Sent: Friday, May 12, 2017 10:56 AM > To: Kyle Larose; us...@dpdk.org; dev@dpdk.org > Subject: Re: active_backup link bonding and mac address > > On 12/05/2017 3:31 PM, Kyle Larose wrote: > > I'm adding the d

Re: [dpdk-dev] "Port 0 is not present on the board" when building DPDK libraries as shared

2017-05-12 Thread Mastorakis, Spyridon
Hi Bruce, Thank you for your response. This seems to have resolved the issue. Spyros -Original Message- From: Richardson, Bruce Sent: Friday, May 12, 2017 1:41 AM To: Mastorakis, Spyridon Cc: dev@dpdk.org Subject: Re: [dpdk-dev] "Port 0 is not present on the board" when building DPDK

Re: [dpdk-dev] active_backup link bonding and mac address

2017-05-12 Thread Declan Doherty
On 12/05/2017 3:31 PM, Kyle Larose wrote: I'm adding the dev mailing list/link bonding maintainer, because I've done some more investigation and I'm beginning to think something is wrong. -Original Message- From: Kyle Larose Sent: Thursday, May 11, 2017 4:55 PM To: us...@dpdk.org Subje

Re: [dpdk-dev] [RFC PATCH v2 0/3] specifications for asymmetric crypto algorithms

2017-05-12 Thread Umesh Kartha
Hi Neil, On Fri, May 12, 2017 at 08:15:57AM -0400, Neil Horman wrote: > On Thu, May 11, 2017 at 06:05:29PM +0530, Umesh Kartha wrote: > > This RFC contains specifications for asymmetric crypto algorithms. > > Asymmetric crypto algorithms are essential part of protocols such as > > SSL/TLS. As the

Re: [dpdk-dev] active_backup link bonding and mac address

2017-05-12 Thread Kyle Larose
I'm adding the dev mailing list/link bonding maintainer, because I've done some more investigation and I'm beginning to think something is wrong. > -Original Message- > From: Kyle Larose > Sent: Thursday, May 11, 2017 4:55 PM > To: us...@dpdk.org > Subject: active_backup link bonding and

Re: [dpdk-dev] [PATCH v3 0/5] improve tap behavior

2017-05-12 Thread Ferruh Yigit
On 5/12/2017 2:01 PM, Pascal Mazon wrote: > The tap does not behave properly in some cases. > > It is generally expected that a real device should be available once the > probing has been done. > > It is also better to check if an operation (here, setting MAC) is > mandatory before performing it.

Re: [dpdk-dev] [PATCH 3/4] bus/fslmc: support for multiple parallel dq requests

2017-05-12 Thread Ferruh Yigit
On 4/19/2017 2:09 PM, Hemant Agrawal wrote: Can you please note what dq stands for in commit log, and if it is an abbreviation can you please use it uppercase in patch title? > Signed-off-by: Hemant Agrawal <...>

Re: [dpdk-dev] [PATCH 2/4] net/dpaa2: improve the error handling in dev init

2017-05-12 Thread Ferruh Yigit
On 4/19/2017 2:09 PM, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal <...> > - /*Close the device at underlying layer*/ > - ret = dpni_close(dpni, CMD_PRI_LOW, priv->token); > - if (ret) { > - PMD_INIT_LOG(ERR, "Failure closing dpni device with" > -

Re: [dpdk-dev] [PATCH 4/4] net/dpaa2: support parallel recv mode

2017-05-12 Thread Ferruh Yigit
On 4/19/2017 2:09 PM, Hemant Agrawal wrote: > Typically when the PMD issues a RX command to DPAA2 hardware, > the hw writes the available descriptors into the given memory. > The RX function then processes the frames and prepare them as > mbufs. > > This patch adds support to issue another pull re

[dpdk-dev] [PATCH v3 5/5] net/tap: do not set remote MAC if not necessary

2017-05-12 Thread Pascal Mazon
Check for the current MAC address on both the remote and the tap netdevices before setting a new value. While there, remove wrong empty lines and ensure tap_ioctl() return value is negative, just like what is done throughout this code. Fixes: 2bc06869cd94 ("net/tap: add remote netdevice traffic c

[dpdk-dev] [PATCH v3 4/5] net/tap: create netdevice during probing

2017-05-12 Thread Pascal Mazon
This has three main benefits: - tun_alloc is now generic again for any queue, - mtu no longer needs to be handled in tap_setup_queue(), - an actual netdevice is created as soon as the device is probed. On top of it, code in eth_dev_tap_create() has been reworked to have a more logical behavior;

[dpdk-dev] [PATCH v3 2/5] net/tap: remove unnecessary functions

2017-05-12 Thread Pascal Mazon
These functions are only two lines each and are used only once. Signed-off-by: Pascal Mazon --- drivers/net/tap/rte_eth_tap.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 3d08ef

[dpdk-dev] [PATCH v3 3/5] net/tap: drop unnecessary nested block

2017-05-12 Thread Pascal Mazon
This is cosmetic; the code is functionally equivalent. Signed-off-by: Pascal Mazon --- drivers/net/tap/rte_eth_tap.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 5b99a8

[dpdk-dev] [PATCH v3 1/5] net/tap: add debug messages

2017-05-12 Thread Pascal Mazon
Print a detailed debug message inside tap_ioctl() directly. The caller now only needs to check for return value. Signed-off-by: Pascal Mazon --- drivers/net/tap/rte_eth_tap.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/drivers/net/t

[dpdk-dev] [PATCH v3 0/5] improve tap behavior

2017-05-12 Thread Pascal Mazon
The tap does not behave properly in some cases. It is generally expected that a real device should be available once the probing has been done. It is also better to check if an operation (here, setting MAC) is mandatory before performing it. Typically in cases where the remote netdevice is a VF w

Re: [dpdk-dev] [PATCH 0/5] improve tap behavior

2017-05-12 Thread Ferruh Yigit
On 4/18/2017 9:17 AM, Pascal Mazon wrote: > The tap does not behave properly in some cases. > > It is generally expected that a real device should be available once the > probing has been done. > > It is also better to check if an operation (here, setting MAC) is > mandatory before performing it.

Re: [dpdk-dev] [PATCH v1] doc: change doc line length limit in contributors guide

2017-05-12 Thread Shreyansh Jain
Sorry for the triviality, once again: On Thursday 11 May 2017 07:39 PM, John McNamara wrote: The DPDK documentation guidelines state that lines should be wrapped as follows: [..] - Here is an example sentence. - Long sentences over the limit shown below can be wrapped onto - a

Re: [dpdk-dev] [PATCH v2] net/tap: add support for fixed mac addresses

2017-05-12 Thread Ferruh Yigit
On 4/12/2017 8:30 AM, Pascal Mazon wrote: > Support for a fixed MAC address for testing with the last octet > incrementing by one for each interface defined with the new 'mac=fixed' > string on the --vdev option. The default option is still to randomize > the MAC address for each tap interface. >

Re: [dpdk-dev] [RFC PATCH v2 0/3] specifications for asymmetric crypto algorithms

2017-05-12 Thread Neil Horman
On Thu, May 11, 2017 at 06:05:29PM +0530, Umesh Kartha wrote: > This RFC contains specifications for asymmetric crypto algorithms. > Asymmetric crypto algorithms are essential part of protocols such as > SSL/TLS. As the current DPDK crypto library lacks support for asymmetric > crypto algorithms, t

Re: [dpdk-dev] [PATCH v2 7/7] net/enic: flow API documentation

2017-05-12 Thread Ferruh Yigit
On 3/31/2017 3:06 AM, John Daley wrote: > Update enic NIC guide, release notes and add flow API to the > supported features list. > > Signed-off-by: John Daley > --- > doc/guides/nics/enic.rst | 44 > ++ > doc/guides/nics/features/enic.ini | 1

Re: [dpdk-dev] [DPDK] net/i40e: add return value checks

2017-05-12 Thread Ferruh Yigit
On 5/11/2017 2:04 AM, Zhang, Helin wrote: > > >> -Original Message- >> From: Lipiec, Herakliusz >> Sent: Tuesday, May 9, 2017 10:38 PM >> To: Zhang, Helin; Wu, Jingjing >> Cc: dev@dpdk.org >> Subject: [DPDK] net/i40e: add return value checks >> >> Coverity issue: 1379362 >> Coverity issue

Re: [dpdk-dev] [PATCH] net/null: do not touch mbuf next or nb segs on Rx

2017-05-12 Thread Ferruh Yigit
On 5/9/2017 8:24 AM, Olivier Matz wrote: > On Thu, 4 May 2017 16:43:58 +0100, Ferruh Yigit > wrote: >> mbuf next and nb_segs fields already have the default values when get >> from mempool, no need to update them in PMD. >> >> See: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool") >> >> Signe

Re: [dpdk-dev] [PATCH] driver/net: remove unnecessary macro for unused variables

2017-05-12 Thread Legacy, Allain
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, May 12, 2017 6:33 AM > To: John W. Linville; Legacy, Allain; Peters, Matt; Harish Patil; Rasesh Mody; > Stephen Hurd; Ajit Khaparde; DOHERTY, DECLAN; LU, WENZHUO; Marcin > Wojtas; Michal Krawczyk; Guy

Re: [dpdk-dev] [PATCH] net/ixgbe: do not touch mbuf initialized fields

2017-05-12 Thread Ferruh Yigit
On 5/5/2017 1:57 AM, Lu, Wenzhuo wrote: > Hi, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Thursday, May 4, 2017 11:59 PM >> To: Lu, Wenzhuo; Ananyev, Konstantin >> Cc: dev@dpdk.org; Olivier Matz >> Subject: [PATCH] net/ixgbe: do not touch mbuf initialized fields >> >> See: 8f09

Re: [dpdk-dev] [PATCH] net/thunderx: add compile-time checks

2017-05-12 Thread Ferruh Yigit
On 5/1/2017 7:40 AM, Jerin Jacob wrote: > The thunderx PMD is sensitive to the layout of the mbuf on > the RX path. Add in some compile-time checks to make sure the mbuf layout > assumptions are valid, and to provide hints to anyone changing the mbuf > where things may need to be updated. > > Sign

Re: [dpdk-dev] [PATCH 0/4] Rel 17.08: add compile time checks to vpmds

2017-05-12 Thread Ferruh Yigit
On 4/28/2017 5:21 PM, Bruce Richardson wrote: > As previously discussed*, add some compile time checks to the vpmds to > help sanity-check their dependencies on the mbuf layout. > > * http://dpdk.org/ml/archives/dev/2017-April/064988.html > > Bruce Richardson (4): > net/ixgbe: add compile-time

Re: [dpdk-dev] [PATCH] net/ark: fix for Coverity issues

2017-05-12 Thread Ferruh Yigit
On 5/11/2017 12:02 PM, John Miller wrote: > Fixes: 9c7188a68d7b ("net/ark: provide API for hardware modules pktchkr and > pktgen") > Coverity issue: 144513 > > Fixes: 727b3fe292bc ("net/ark: integrate PMD") > Coverity issue: 144514 > > Fixes: 9c7188a68d7b ("net/ark: provide API for hardware modu

Re: [dpdk-dev] [PATCH] vfio: fix array bounds check

2017-05-12 Thread Burakov, Anatoly
> From: Alejandro Lucero [mailto:alejandro.luc...@netronome.com] > Sent: Friday, May 12, 2017 11:18 AM > To: dev@dpdk.org > Cc: Burakov, Anatoly > Subject: [PATCH] vfio: fix array bounds check > > Checking against VFIO_MAX_GROUPS goes beyond the maximum array > index which should be (VFIO_MAX_GRO

Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature

2017-05-12 Thread Ferruh Yigit
On 5/10/2017 2:51 PM, Thomas Monjalon wrote: > 10/05/2017 15:10, Ferruh Yigit: >> --- a/doc/guides/nics/features/bnx2x.ini >> +++ b/doc/guides/nics/features/bnx2x.ini >> @@ -4,6 +4,7 @@ >> ; Refer to default.ini for the full list of available PMD features. >> ; >> [Features] >> +Speed capabiliti

[dpdk-dev] [PATCH] driver/net: remove unnecessary macro for unused variables

2017-05-12 Thread Ferruh Yigit
remove __rte_unused instances that are not required. Signed-off-by: Ferruh Yigit --- drivers/net/af_packet/rte_eth_af_packet.c | 7 ++- drivers/net/avp/avp_ethdev.c | 3 +-- drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++-- drivers/net/bnxt/bnxt_ethdev.c | 2

[dpdk-dev] [PATCH] vfio: fix array bounds check

2017-05-12 Thread Alejandro Lucero
Checking against VFIO_MAX_GROUPS goes beyond the maximum array index which should be (VFIO_MAX_GROUPS - 1). Fixes: 94c0776b1bad("support hotplug") Coverity issue: 144555 Coverity issue: 144556 Coverity issue: 144557 Signed-off-by: Alejandro Lucero --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 6

[dpdk-dev] [PATCH v5 4/4] test: add tests for arm64 CRC neon versions

2017-05-12 Thread Ashwin Sekhar T K
Verified the changes with crc_autotest unit test case Signed-off-by: Ashwin Sekhar T K --- test/test/test_crc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/test/test/test_crc.c b/test/test/test_crc.c index cd5af69a2..9f2a17d49 100644 --- a/test/test/test_crc.c +++ b/test/test/te

[dpdk-dev] [PATCH v5 3/4] net: add arm64 neon version of CRC compute APIs

2017-05-12 Thread Ashwin Sekhar T K
Added CRC compute APIs for arm64 utilizing the pmull capability. Added new file net_crc_neon.h to hold the arm64 pmull CRC implementation. Added wrappers in rte_vect.h for those neon intrinsics which are not supported in GCC version < 7. Verified the changes with crc_autotest unit test case Sig

[dpdk-dev] [PATCH v5 2/4] eal: move gcc version definition to common header

2017-05-12 Thread Ashwin Sekhar T K
Moved the definition of GCC_VERSION from lib/librte_table/rte_lru.h to lib/librte_eal/common/include/rte_common.h. Tested compilation on: * arm64 with gcc * x86 with gcc and clang Signed-off-by: Ashwin Sekhar T K Reviewed-by: Jan Viktorin --- lib/librte_eal/common/include/rte_common.h | 6 +

[dpdk-dev] [PATCH v5 1/4] mk: add crypto capability for generic armv8a and thunderx

2017-05-12 Thread Ashwin Sekhar T K
armv8-a has optional CRYPTO extension which adds the AES, PMULL, SHA1 and SHA2 capabilities. -march=armv8-a+crypto enables code generation for the ARMv8-A architecture together with the optional CRYPTO extensions. Added the following flags to detect the corresponding capability at compile time. *

[dpdk-dev] [PATCH v5 0/4] add arm64 neon version of CRC compute APIs

2017-05-12 Thread Ashwin Sekhar T K
This patch series adds arm64 neon version of CRC compute APIs utilizing the pmull capability (which is available as part of crypto extensions). * Patch 1 adds crypto capability in compilation of generic armv8a and thunderx targets. * Patch 2 moves GCC_VERSION defintion to a more common locati

Re: [dpdk-dev] [PATCH v1] doc: change doc line length limit in contributors guide

2017-05-12 Thread Thomas Monjalon
12/05/2017 11:10, Mcnamara, John: > From: Iremonger, Bernard > > From: Thomas Monjalon > > > 11/05/2017 18:11, Mcnamara, John: > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > > > > > > ... > > > > > > -* The recommended style for the DPDK documentation is to put > > > > > > sen

Re: [dpdk-dev] [PATCH v5 19/26] app/testpmd: add item raw to flow command

2017-05-12 Thread Adrien Mazarguil
Hi Wei, On Thu, May 11, 2017 at 06:53:52AM +, Zhao1, Wei wrote: > Hi, Adrien > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrien Mazarguil > > Sent: Wednesday, December 21, 2016 10:52 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v5 19/26]

Re: [dpdk-dev] [PATCH v1] doc: change doc line length limit in contributors guide

2017-05-12 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Thursday, May 11, 2017 6:31 PM > To: Thomas Monjalon ; Mcnamara, John > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v1] doc: change doc line length limit in > contributors guide > > > > -Original Message- > > From:

Re: [dpdk-dev] [PATCH v4 3/4] net: add arm64 neon version of CRC compute APIs

2017-05-12 Thread Sekhar, Ashwin
On Fri, 2017-05-12 at 16:49 +0800, Jianbo Liu wrote: > On 12 May 2017 at 15:25, Sekhar, Ashwin > wrote: > > > > On Fri, 2017-05-12 at 13:51 +0800, Jianbo Liu wrote: > > > > > > On 9 May 2017 at 17:53, Ashwin Sekhar T K > > > wrote: > > > > > > > > > > > > Added CRC compute APIs for arm64 util

Re: [dpdk-dev] [PATCH v4 3/4] net: add arm64 neon version of CRC compute APIs

2017-05-12 Thread Jianbo Liu
On 12 May 2017 at 15:25, Sekhar, Ashwin wrote: > On Fri, 2017-05-12 at 13:51 +0800, Jianbo Liu wrote: >> On 9 May 2017 at 17:53, Ashwin Sekhar T K >> wrote: >> > >> > Added CRC compute APIs for arm64 utilizing the pmull >> > capability >> > >> > Added new file net_crc_neon.h to hold the arm64 pmu

Re: [dpdk-dev] [PATCH] memzone: Check socket_id value when creating memzone.

2017-05-12 Thread Bruce Richardson
On Thu, May 11, 2017 at 11:03:43PM -0700, Tonghao Zhang wrote: > If the socket_id is invalid (e.g. -2, -3), the > memzone_reserve_aligned_thread_unsafe should return the > EINVAL and not ENOMEM. To avoid it, we should check the > socket_id before calling malloc_heap_alloc. > > Signed-off-by: Tongh

Re: [dpdk-dev] "Port 0 is not present on the board" when building DPDK libraries as shared

2017-05-12 Thread Bruce Richardson
On Thu, May 11, 2017 at 09:33:32PM +, Mastorakis, Spyridon wrote: > Hi guys, > > When I compile the DPDK libraries as shared (by modifying the base_config > file) and try to run an application (e.g., l3fwd), I get an error that port 0 > is not present on board. > > I have cleaned the system

Re: [dpdk-dev] [PATCH] app/testpmd: fix failure of creating E-Tag and NVGRE flows

2017-05-12 Thread Adrien Mazarguil
On Fri, May 12, 2017 at 03:13:09PM +0800, Beilei Xing wrote: > Application fails to create NVGRE and E_Tag flows with > current configuration, this commit fixes the issue by > adding flow items for E_TAG and NVGRE. > > Fixes: e4840ef2685d ("ethdev: fix incomplete items in flow API") > Cc: sta...@d

Re: [dpdk-dev] [PATCH v4 3/4] net: add arm64 neon version of CRC compute APIs

2017-05-12 Thread Sekhar, Ashwin
On Fri, 2017-05-12 at 13:51 +0800, Jianbo Liu wrote: > On 9 May 2017 at 17:53, Ashwin Sekhar T K > wrote: > > > > Added CRC compute APIs for arm64 utilizing the pmull > > capability > > > > Added new file net_crc_neon.h to hold the arm64 pmull > > CRC implementation > > > > Verified the changes

[dpdk-dev] [PATCH] app/testpmd: fix failure of creating E-Tag and NVGRE flows

2017-05-12 Thread Beilei Xing
Application fails to create NVGRE and E_Tag flows with current configuration, this commit fixes the issue by adding flow items for E_TAG and NVGRE. Fixes: e4840ef2685d ("ethdev: fix incomplete items in flow API") Cc: sta...@dpdk.org Signed-off-by: Beilei Xing --- app/test-pmd/config.c | 2 ++ 1