On 4/19/2017 2:09 PM, Hemant Agrawal wrote:
> Typically when the PMD issues a RX command to DPAA2 hardware,
> the hw writes the available descriptors into the given memory.
> The RX function then processes the frames and prepare them as
> mbufs.
> 
> This patch adds support to issue another pull request to hardware
> in another memory location, before we start processing the output
> of the first request. This help in controlling the cpu cycles
> wasted during the wait for the hardware to write the descriptors.
> 
> During hw debugging, it may be desired to keep the original
> mode, so the original mode is also preserved and can be controlled
> with an env flag.
> 
> Signed-off-by: Hemant Agrawal <hemant.agra...@nxp.com>

<...>

>  
> +     /*If no prefetch is configured. */
> +     if (getenv("DPAA2_RX_NO_PREFETCH")) {

Instead of getting configuration option from environment variable, can
you please make it argument to the driver?
This will be more consistent to the DPDK usage.

> +             eth_dev->rx_pkt_burst = dpaa2_dev_rx;
> +             PMD_INIT_LOG(INFO, "No Prefetch enabled");
> +     }
> +

<...>

Reply via email to