[dpdk-dev] [PATCH v5 3/3] app/testpmd: add a command to add many MAC addrs

2017-04-28 Thread Wei Dai
This patch is added to introduce a testpmd command which is used to add more than one MAC addresses one time. This command can simplify the test for the change where the type of return value of adding MAC address. Normally a MAC address may fails to be added only after many MAC addresses have been

[dpdk-dev] [PATCH v5 2/3] doc: change type of return value of adding MAC addr

2017-04-28 Thread Wei Dai
Add following lines in section of API change in release note. If a MAC address fails to be added without this change, it is still stored and may be regarded as a valid one. This may lead to errors in application. The type of return value of eth_mac_addr_add_t in rte_ethdev.h is changed. Any specif

[dpdk-dev] [PATCH v5 0/3] MAC address fail to be added shouldn't be stored

2017-04-28 Thread Wei Dai
Current ethdev always stores MAC address even it fails to be added. Other function may regard the failed MAC address valid and lead to some errors. So There is a need to check if the addr is added successfully or not and discard it if it fails. In 3rd patch, add a command "add_more_mac_addr port_i

[dpdk-dev] [PATCH v5 1/3] ethdev: fix adding invalid MAC addr

2017-04-28 Thread Wei Dai
Some customers find adding MAC addr to VF sometimes can fail, but it is still stored in dev->data->mac_addrs[ ]. So this can lead to some errors that assumes the non-zero entry in dev->data->mac_addrs[ ] is valid. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Wei

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr

2017-04-28 Thread Dai, Wei
HI, Wenzhuo > > > > int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int > > wait_to_complete) diff --git a/drivers/net/e1000/base/e1000_api.c > > b/drivers/net/e1000/base/e1000_api.c > > index f7cf83b..dcb53f7 100644 > > --- a/drivers/net/e1000/base/e1000_api.c > > +++ b/drivers/net/e1000/ba

Re: [dpdk-dev] [PATCH dpdk v2] bnx2x: Update firmware versions

2017-04-28 Thread Alexey Kardashevskiy
On 29/04/17 10:31, Mody, Rasesh wrote: > Hi Alexey, > >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Wednesday, April 26, 2017 2:18 AM >> >> On 4/26/2017 9:08 AM, Alexey Kardashevskiy wrote: >>> Recent kernels/distros have updated firmware images, use them. >>> In order to keep sup

[dpdk-dev] [PATCH] net/qede: fix to increment Tx packets

2017-04-28 Thread Rasesh Mody
Inadvertently we failed to increment tx_pkts pointer while addressing coverity issue, this patch fixes that. Fixes: 41b52b732ec5 ("net/qede/base: fix code flow and remove unused code") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_rxtx.c |2 +- 1 file changed, 1 i

Re: [dpdk-dev] [PATCH dpdk v2] bnx2x: Update firmware versions

2017-04-28 Thread Mody, Rasesh
Hi Alexey, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, April 26, 2017 2:18 AM > > On 4/26/2017 9:08 AM, Alexey Kardashevskiy wrote: > > Recent kernels/distros have updated firmware images, use them. > > In order to keep support of older distros (such as Fedora 19 or Ub

[dpdk-dev] [PATCH] doc: announce crypto structures rework

2017-04-28 Thread Pablo de Lara
The current crypto operation and symmetric crypto operation structures will be reworked for correctness and improvement, reducing also their sizes, to fit into less cache lines, as stated in the following RFC: http://dpdk.org/dev/patchwork/patch/24011/ Signed-off-by: Pablo de Lara --- doc/guide

[dpdk-dev] [PATCH] [RFC] cryptodev: crypto operation restructuring

2017-04-28 Thread Pablo de Lara
This is a proposal to correct and improve the current crypto operation (rte_crypto_op) and symmetric crypto operation (rte_crypto_sym_op) structures, shrinking their sizes to fit both structures into two 64-byte cache lines as one of the goals. The following changes are proposed: In rte_crypto_

[dpdk-dev] [PATCH] devtools: add script to get maintainers from patch

2017-04-28 Thread Ferruh Yigit
This is a wrapper to Linux kernel get_maintainer.pl file and only supports parsing MAINTAINERS file (no git fallback etc..) Requires DPDK_GETMAINTAINER_PATH devel config option set, please check devtools/load-devel-config. DPDK_GETMAINTAINER_PATH should be full patch to the get_maintainer.pl scri

[dpdk-dev] [PATCH 3/4] net/i40e: add compile-time checks to vector driver

2017-04-28 Thread Bruce Richardson
The vector PMD is very sensitive to the layout of the mbuf, especially on the RX path. Add in some compile-time checks to make sure the mbuf layout assumptions are valid, and to provide hints to anyone changing the mbuf where things may need to be updated. Signed-off-by: Bruce Richardson --- dri

[dpdk-dev] [PATCH 4/4] net/fm10k: add compile-time checks to vector driver

2017-04-28 Thread Bruce Richardson
The vector PMD is very sensitive to the layout of the mbuf, especially on the RX path. Add in some compile-time checks to make sure the mbuf layout assumptions are valid, and to provide hints to anyone changing the mbuf where things may need to be updated. Signed-off-by: Bruce Richardson --- dri

[dpdk-dev] [PATCH 2/4] net/ixgbe: enable ixgbe vector PMD for i686

2017-04-28 Thread Bruce Richardson
The ixgbe vector PMD was disabled for i686 unnecessarily. Enable it. Signed-off-by: Bruce Richardson --- config/defconfig_i686-native-linuxapp-gcc | 5 - 1 file changed, 5 deletions(-) diff --git a/config/defconfig_i686-native-linuxapp-gcc b/config/defconfig_i686-native-linuxapp-gcc index

[dpdk-dev] [PATCH 1/4] net/ixgbe: add compile-time checks to vector driver

2017-04-28 Thread Bruce Richardson
The vector PMD is very sensitive to the layout of the mbuf, especially on the RX path. Add in some compile-time checks to make sure the mbuf layout assumptions are valid, and to provide hints to anyone changing the mbuf where things may need to be updated. Signed-off-by: Bruce Richardson --- dri

[dpdk-dev] [PATCH 0/4] Rel 17.08: add compile time checks to vpmds

2017-04-28 Thread Bruce Richardson
As previously discussed*, add some compile time checks to the vpmds to help sanity-check their dependencies on the mbuf layout. * http://dpdk.org/ml/archives/dev/2017-April/064988.html Bruce Richardson (4): net/ixgbe: add compile-time checks to vector driver net/ixgbe: enable ixgbe vector PMD

[dpdk-dev] [pull-request] next-crypto 17.05 RC3

2017-04-28 Thread Pablo de Lara
The following changes since commit f051679dc577d93d177e6eddefaba28a69d9955f: devtools: list stable commits without fixline (2017-04-28 12:05:03 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to d295885b29b8aa4bf11e54bd31

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix API digest length comments

2017-04-28 Thread De Lara Guarch, Pablo
> -Original Message- > From: Doherty, Declan > Sent: Friday, April 28, 2017 3:57 PM > To: Trahe, Fiona; dev@dpdk.org > Cc: De Lara Guarch, Pablo; sta...@dpdk.org > Subject: Re: [PATCH] lib/cryptodev: fix API digest length comments > > On 25/04/2017 5:56 PM, Trahe, Fiona wrote: > > Fix mi

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix API digest length comments

2017-04-28 Thread Declan Doherty
On 25/04/2017 5:56 PM, Trahe, Fiona wrote: Fix misleading comments clarifying setting of digest length. Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- ... Acked-by: Declan Doherty

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix API digest length comments

2017-04-28 Thread Declan Doherty
On 28/04/2017 2:38 PM, Trahe, Fiona wrote: Hi Declan, -Original Message- ... I don't think this comment change is valid, we already validate many of the parameters which are passed into session creation, such as key lengths etc, if we are not validating digest length now I think we s

Re: [dpdk-dev] [dpdk-users] Adding multiple fields as key in ip_pipeline application

2017-04-28 Thread Singh, Jasvinder
Hi Nidhia, I am developing an application in which I need to use both incoming port and vlan as the key for the flow table. Port field is available at 24th byte of mbuf and vlan(single tagged) will be at 268th byte (128 mbuf + 128 headroom + 12 ethernet header). How can I represent this in my

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix API digest length comments

2017-04-28 Thread Trahe, Fiona
Hi Declan, > -Original Message- > From: Doherty, Declan > Sent: Friday, April 28, 2017 10:22 AM > To: Trahe, Fiona ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: Re: [PATCH] lib/cryptodev: fix API digest length comments > > On 25/04/2017 5:56 PM, Trahe, Fiona wr

Re: [dpdk-dev] [RFC PATCH] timer: inform periodic timers of multiple expiries

2017-04-28 Thread Bruce Richardson
+maintainer On Fri, Apr 28, 2017 at 02:25:38PM +0100, Bruce Richardson wrote: > if timer_manage is called much less frequently than the period of a > periodic timer, then timer expiries will be missed. For example, if a timer > has a period of 300us, but timer_manage is called every 1ms, then ther

Re: [dpdk-dev] [RFC PATCH] timer: inform periodic timers of multiple expiries

2017-04-28 Thread Bruce Richardson
I'd like some agreement soon on the approach to be taken to fix this issue, in case we need an ABI change notice in 17.05 - i.e. if we take the approach given in the patch below. Also, while the alternative solution of calling a function multiple times is not an ABI/API change, I view it as more p

[dpdk-dev] [RFC PATCH] timer: inform periodic timers of multiple expiries

2017-04-28 Thread Bruce Richardson
if timer_manage is called much less frequently than the period of a periodic timer, then timer expiries will be missed. For example, if a timer has a period of 300us, but timer_manage is called every 1ms, then there will only be one timer callback called every 1ms instead of 3 within that time. Wh

Re: [dpdk-dev] [PATCH] vfio: fix device unplug when several devices per vfio group

2017-04-28 Thread Burakov, Anatoly
> From: Alejandro Lucero [mailto:alejandro.luc...@netronome.com] > Sent: Wednesday, April 26, 2017 11:50 AM > To: dev@dpdk.org > Cc: Burakov, Anatoly > Subject: [PATCH] vfio: fix device unplug when several devices per vfio group > > VFIO allows a secure way of assigning devices to user space and

Re: [dpdk-dev] [PATCH] vfio: set IOMMU type for the container once

2017-04-28 Thread Burakov, Anatoly
> From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Tuesday, April 4, 2017 5:06 PM > To: dev@dpdk.org > Cc: Burakov, Anatoly ; Alejandro Lucero > > Subject: [PATCH] vfio: set IOMMU type for the container once > > If more than one used PCI device belongs to one IOMMU group, it is s

[dpdk-dev] [PATCH v2] mbuf: fix 64bit address alignment in 32-bit builds

2017-04-28 Thread Bruce Richardson
On i686 builds, the uin64_t type is 64-bits in size but is aligned to 32-bits only. This causes mbuf fields for rearm_data to not be 16-byte aligned on 32-bit builds, which causes errors with some vector PMDs which expect the rearm data to be aligned as on 64-bit. Given that we cannot use the extr

[dpdk-dev] [pull-request] next-net 17.05 RC3

2017-04-28 Thread Ferruh Yigit
The following changes since commit f051679dc577d93d177e6eddefaba28a69d9955f: devtools: list stable commits without fixline (2017-04-28 12:05:03 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-net for you to fetch changes up to e8b1ae3f3e9bccd2b328c863dec3c

Re: [dpdk-dev] [PATCH] net/avp: fix interrupt migration check

2017-04-28 Thread Ferruh Yigit
On 4/28/2017 11:52 AM, Legacy, Allain wrote: >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Friday, April 28, 2017 2:49 AM >> To: Peters, Matt >> Cc: dev@dpdk.org; YIGIT, FERRUH >> Subject: [PATCH] net/avp: fix interrupt migration check >> >> Bitwise OR

Re: [dpdk-dev] [PATCH] examples/performance-thread: fix compilation on FreeBSD 10.0

2017-04-28 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, April 28, 2017 11:18 AM > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [dpdk-dev] [PATCH] examples/performance-thread: fix compilation > on FreeBSD 10.0 > > While later rel

Re: [dpdk-dev] [PATCH] net/i40e: consider QinQ when setting MTU

2017-04-28 Thread Ferruh Yigit
On 4/28/2017 9:27 AM, Wu, Jingjing wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Friday, April 28, 2017 1:55 PM >> To: Lu, Wenzhuo ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] net/i40e: consider QinQ when setting MTU >>

Re: [dpdk-dev] [PATCH] usertools: fix cpu_layout script for multithreads of more than 2

2017-04-28 Thread Andriy Berestovskyy
Works fine on ThunderX and does not brake Intel either. Reviewed-by: Andriy Berestovskyy Tested-by: Andriy Berestovskyy Andriy On 28.04.2017 13:58, Thomas Monjalon wrote: Andriy, please would you like to review this patch? 28/04/2017 12:34, Gowrishankar: From: Gowrishankar Muthukrishnan

Re: [dpdk-dev] [PATCH] usertools: fix cpu_layout script for multithreads of more than 2

2017-04-28 Thread Thomas Monjalon
Andriy, please would you like to review this patch? 28/04/2017 12:34, Gowrishankar: > From: Gowrishankar Muthukrishnan > > Current usertools/cpu_layout.py is broken to handle multithreads of count more > than 2 as in IBM powerpc P8 servers. Below patch addressed this issue. Also, > added minor e

Re: [dpdk-dev] [PATCH dpdk v2] vfio/ppc64/spapr: Warn if DMA window was created at unexpected offset

2017-04-28 Thread Burakov, Anatoly
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Alexey > Kardashevskiy > Sent: Wednesday, April 26, 2017 9:09 AM > To: dev@dpdk.org > Cc: Alexey Kardashevskiy > Subject: [dpdk-dev] [PATCH dpdk v2] vfio/ppc64/spapr: Warn if DMA > window was created at unexpected offset > > VFIO_IOMMU_SPAPR_

Re: [dpdk-dev] [PATCH v1 4/6] app/proc-info: support xstats by ID and by name

2017-04-28 Thread Van Haaren, Harry
> From: Jastrzebski, MichalX K > Sent: Thursday, April 27, 2017 3:43 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Jain, Deepak K > ; > Kozak, KubaX > Subject: [PATCH v1 4/6] app/proc-info: support xstats by ID and by name > > From: Kuba Kozak > > There are new arguments --xstats-ids and --x

Re: [dpdk-dev] [PATCH v1 6/6] net/ixgbe: support xstats by ID

2017-04-28 Thread Van Haaren, Harry
> From: Jastrzebski, MichalX K > Sent: Thursday, April 27, 2017 3:43 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Jain, Deepak K > ; > Kozak, KubaX > Subject: [PATCH v1 6/6] net/ixgbe: support xstats by ID > > From: Kuba Kozak > > To achieve functionality of retrieving only specific statist

Re: [dpdk-dev] [PATCH v1 3/6] ethdev: get xstats ID by name

2017-04-28 Thread Van Haaren, Harry
> From: Jastrzebski, MichalX K > Sent: Thursday, April 27, 2017 3:43 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Jain, Deepak K > ; > Kozak, KubaX > Subject: [PATCH v1 3/6] ethdev: get xstats ID by name > > From: Kuba Kozak > > Introduced new function: rte_eth_xstats_get_id_by_name > to re

Re: [dpdk-dev] [PATCH v1 5/6] net/e1000: support xstats by ID

2017-04-28 Thread Van Haaren, Harry
> From: Jastrzebski, MichalX K > Sent: Thursday, April 27, 2017 3:43 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Jain, Deepak K > ; > Kozak, KubaX > Subject: [PATCH v1 5/6] net/e1000: support xstats by ID > > From: Kuba Kozak > > To achieve functionality of retrieving only specific statist

Re: [dpdk-dev] [PATCH v1 1/6] ethdev: revert patches extending xstats API in ethdev

2017-04-28 Thread Van Haaren, Harry
> From: Jastrzebski, MichalX K > Sent: Thursday, April 27, 2017 3:43 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Jain, Deepak K > ; > Kozak, KubaX > Subject: [PATCH v1 1/6] ethdev: revert patches extending xstats API in ethdev > > From: Kuba Kozak > > Revert patches to provide clear view f

Re: [dpdk-dev] [PATCH v1 2/6] ethdev: retrieve xstats by ID

2017-04-28 Thread Van Haaren, Harry
> From: Jastrzebski, MichalX K > Sent: Thursday, April 27, 2017 3:43 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Jain, Deepak K > ; > Kozak, KubaX > Subject: [PATCH v1 2/6] ethdev: retrieve xstats by ID > > From: Kuba Kozak > > Extended xstats API in ethdev library to allow grouping of sta

[dpdk-dev] [PATCH v2] app/testpmd: add bitrate stats option

2017-04-28 Thread Pablo de Lara
From: Remy Horton Bit-rate collation should only be done by one core. This patch adds an option to select which core performs the bit-rate calculation, which is also disabled by default. Fixes: 7e4441c8efb9 ("app/testpmd: add bitrate statistics calculation") Signed-off-by: Remy Horton Acked-by

Re: [dpdk-dev] [PATCH] net/avp: fix interrupt migration check

2017-04-28 Thread Legacy, Allain
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, April 28, 2017 2:49 AM > To: Peters, Matt > Cc: dev@dpdk.org; YIGIT, FERRUH > Subject: [PATCH] net/avp: fix interrupt migration check > > Bitwise OR within if statement is always true, fix bitwise ope

[dpdk-dev] [PATCH v2] examples/l3fwd-power: fix zero rxq handling

2017-04-28 Thread Jingjing Wu
If the number of rx queues is zero, it is meaningless to enable rx interrupt. This patch fixes it. Fixes: aee3bc79cc34 ("examples/l3fwd-power: enable one-shot Rx interrupt and polling switch") Cc: sta...@dpdk.org Signed-off-by: Jingjing Wu --- v2 changes: - fix typo. examples/l3fwd-power/main

Re: [dpdk-dev] [PATCH v2] efd: support lookup using neon intrinsics

2017-04-28 Thread Sekhar, Ashwin
On Friday 28 April 2017 03:36 PM, Jianbo Liu wrote: > On 27 April 2017 at 20:44, Ashwin Sekhar T K > wrote: >> * Added file lib/librte_efd/rte_efd_arm64.h to hold arm64 >> specific definitions >> * Verified the changes with efd_autotest unit test case >> >> Signed-off-by: Ashwin Sekhar T K >> -

[dpdk-dev] [PATCH] usertools: fix cpu_layout script for multithreads of more than 2

2017-04-28 Thread Gowrishankar
From: Gowrishankar Muthukrishnan Current usertools/cpu_layout.py is broken to handle multithreads of count more than 2 as in IBM powerpc P8 servers. Below patch addressed this issue. Also, added minor exception catch on failing to open unavailable sys file in case of multithread=off configuration

Re: [dpdk-dev] [PATCH 1/2] net: add arm64 neon version of CRC compute APIs

2017-04-28 Thread Sekhar, Ashwin
Hi Jan, Thanks for the comments. Please see my responses inline. On Friday 28 April 2017 03:25 PM, Jan Viktorin wrote: > Hello Ashwin Sekhar, > > some comments below... > > On Thu, 27 Apr 2017 07:10:20 -0700 > Ashwin Sekhar T K wrote: > >> * Added CRC compute APIs for arm64 utilizing the pmull ca

[dpdk-dev] [PATCH] examples/performance-thread: fix compilation on FreeBSD 10.0

2017-04-28 Thread Bruce Richardson
While later releases in the FreeBSD 10 series have a CPU_COUNT macro defined, FreeBSD 10.0 and 10.1 do not have this macro. Therefore we provide a basic fallback implementation of the macro for platforms where it is not defined. Fixes: 433ba6228f9a ("examples/performance-thread: add pthread_shim a

Re: [dpdk-dev] [PATCH] eal: fix 64bit address alignment in 32-bit builds

2017-04-28 Thread Bruce Richardson
On Fri, Apr 28, 2017 at 11:56:54AM +0200, Olivier Matz wrote: > Hi, > > On Fri, 28 Apr 2017 10:32:03 +0100, Bruce Richardson > wrote: > > On Fri, Apr 28, 2017 at 11:21:27AM +0200, Thomas Monjalon wrote: > > > 28/04/2017 11:03, Bruce Richardson: > > > > On Fri, Apr 28, 2017 at 10:56:56AM +0200,

[dpdk-dev] [PATCH] app/testpmd: configure event display

2017-04-28 Thread Gaetan Rivet
Add two parameters to testpmd: --print-event --mask-event To enable or disable to printing of events. This display is configured on a per-event basis. By default, all except VF_MBOX are displayed. Fixes: 76ad4a2d82d4 ("app/testpmd: add generic event handler") Cc: "Lu, Wenzhuo" Signed-off

Re: [dpdk-dev] [PATCH] devtools: list stable commits do not have fixline

2017-04-28 Thread Thomas Monjalon
28/04/2017 09:21, Yuanhan Liu: > Some commits for stable releases (with Cc stable tag) may not have the > fixline. For example: > http://dpdk.org/dev/patchwork/patch/23955/ > > It disables a feature we have implemented in last release. The feature > is done right. It's the QEMU implementaton b

Re: [dpdk-dev] [PATCH v2] efd: support lookup using neon intrinsics

2017-04-28 Thread Jianbo Liu
On 27 April 2017 at 20:44, Ashwin Sekhar T K wrote: > * Added file lib/librte_efd/rte_efd_arm64.h to hold arm64 > specific definitions > * Verified the changes with efd_autotest unit test case > > Signed-off-by: Ashwin Sekhar T K > --- > v2: > * Slightly modified the content of the commit messa

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: enabled control for packet timestamps

2017-04-28 Thread Olivier Matz
Hi, On Fri, 28 Apr 2017 11:12:29 +0200, Thomas Monjalon wrote: > 28/04/2017 02:19, Wu, Jingjing: > > > 25/04/2017 16:02, Wu, Jingjing: > > > > From: Oleg Kuporosov > > > > > Implemented two methods of control > > > > > > > > > > - by --enable-timestamps CL testpmd application we can enable

Re: [dpdk-dev] [PATCH] eal: fix 64bit address alignment in 32-bit builds

2017-04-28 Thread Olivier Matz
Hi, On Fri, 28 Apr 2017 10:32:03 +0100, Bruce Richardson wrote: > On Fri, Apr 28, 2017 at 11:21:27AM +0200, Thomas Monjalon wrote: > > 28/04/2017 11:03, Bruce Richardson: > > > On Fri, Apr 28, 2017 at 10:56:56AM +0200, Thomas Monjalon wrote: > > > > 28/04/2017 10:15, Bruce Richardson: > >

Re: [dpdk-dev] [PATCH 1/2] net: add arm64 neon version of CRC compute APIs

2017-04-28 Thread Jan Viktorin
Hello Ashwin Sekhar, some comments below... On Thu, 27 Apr 2017 07:10:20 -0700 Ashwin Sekhar T K wrote: > * Added CRC compute APIs for arm64 utilizing the pmull capability > * Added new file net_crc_neon.h to hold the arm64 pmull CRC > implementation > * Added crypto capability in compilation

[dpdk-dev] Adding multiple fields as key in ip_pipeline application

2017-04-28 Thread Nidhia Varghese
Hi, I am developing an application in which I need to use both incoming port and vlan as the key for the flow table. Port field is available at 24th byte of mbuf and vlan(single tagged) will be at 268th byte (128 mbuf + 128 headroom + 12 ethernet header). How can I represent this in my config file

Re: [dpdk-dev] [PATCH] tools/dpdkdevbind.py: remove call to lower case for mod path

2017-04-28 Thread Thomas Monjalon
25/11/2016 04:16, alloc: > If the module path has upper case chars, the dpdk-devbind.py script will > crunch them to lower case. This will result in the script never > finding a module. I wonder why this "lower" was done. I'm afraid we are missing something. Nobody else is complaining about this

Re: [dpdk-dev] [PATCH 0/3 v2] disable vector PMD for i686

2017-04-28 Thread Ferruh Yigit
On 4/28/2017 10:26 AM, Bruce Richardson wrote: > On Fri, Apr 28, 2017 at 11:14:24AM +0200, Thomas Monjalon wrote: >> 27/04/2017 11:25, Bruce Richardson: >>> On Thu, Apr 27, 2017 at 03:01:04AM -0400, Qi Zhang wrote: Vector PMD is not designed for i686 orginally, but it still can be active

[dpdk-dev] [PATCH v2 1/2] net: add arm64 neon version of CRC compute APIs

2017-04-28 Thread Ashwin Sekhar T K
* Added CRC compute APIs for arm64 utilizing the pmull capability * Added new file net_crc_neon.h to hold the arm64 pmull CRC implementation * Added crypto capability in compilation of generic armv8 and thunderx targets * pmull CRC version is used only after checking the pmull capability at r

[dpdk-dev] [PATCH v2 2/2] test: add tests for arm64 CRC neon versions

2017-04-28 Thread Ashwin Sekhar T K
Verified the changes with crc_autotest unit test case Signed-off-by: Ashwin Sekhar T K --- v2: * Fixed checkpatch errors/warnings test/test/test_crc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/test/test/test_crc.c b/test/test/test_crc.c index cd5af69..9f2a17d 100644 --- a/tes

Re: [dpdk-dev] [PATCH] eal: fix 64bit address alignment in 32-bit builds

2017-04-28 Thread Bruce Richardson
On Fri, Apr 28, 2017 at 11:21:27AM +0200, Thomas Monjalon wrote: > 28/04/2017 11:03, Bruce Richardson: > > On Fri, Apr 28, 2017 at 10:56:56AM +0200, Thomas Monjalon wrote: > > > 28/04/2017 10:15, Bruce Richardson: > > > > On i686 builds, the uint64_t type is 64-bits in size but is aligned to > > >

Re: [dpdk-dev] [PATCH 0/3 v2] disable vector PMD for i686

2017-04-28 Thread Bruce Richardson
On Fri, Apr 28, 2017 at 11:14:24AM +0200, Thomas Monjalon wrote: > 27/04/2017 11:25, Bruce Richardson: > > On Thu, Apr 27, 2017 at 03:01:04AM -0400, Qi Zhang wrote: > > > Vector PMD is not designed for i686 orginally, but it still can be active > > > with i686 compile option. > > > Below are observ

Re: [dpdk-dev] [PATCH] l2fwd_fork: fix missing updating the prev_tsc

2017-04-28 Thread Yang, Zhiyong
Hi, Thomas: The patch is always not noticed by anyone. Could it be applied to 17.05 ? it indeed is a bug. Thanks Zhiyong > -Original Message- > From: Yang, Zhiyong > Sent: Thursday, February 23, 2017 10:01 AM > To: dev@dpdk.org > Cc: Gonzalez Monroy, Sergio ; Yang, > Zhiyong >

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix API digest length comments

2017-04-28 Thread Declan Doherty
On 25/04/2017 5:56 PM, Trahe, Fiona wrote: Fix misleading comments clarifying setting of digest length. Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- lib/librte_cryptodev/rte_crypto_sym.h | 11 ++-

Re: [dpdk-dev] [PATCH] eal: fix 64bit address alignment in 32-bit builds

2017-04-28 Thread Thomas Monjalon
28/04/2017 11:03, Bruce Richardson: > On Fri, Apr 28, 2017 at 10:56:56AM +0200, Thomas Monjalon wrote: > > 28/04/2017 10:15, Bruce Richardson: > > > On i686 builds, the uint64_t type is 64-bits in size but is aligned to > > > 32-bits only. This causes mbuf fields for rearm_data to not be 16-byte >

Re: [dpdk-dev] [PATCH 0/3 v2] disable vector PMD for i686

2017-04-28 Thread Thomas Monjalon
27/04/2017 11:25, Bruce Richardson: > On Thu, Apr 27, 2017 at 03:01:04AM -0400, Qi Zhang wrote: > > Vector PMD is not designed for i686 orginally, but it still can be active > > with i686 compile option. > > Below are observed failure when vPMD is invovled on i686 > > (but may not limited to) > >

Re: [dpdk-dev] [PATCH] lib/librte_cmdline: fix CLI parsing issue

2017-04-28 Thread Olivier Matz
Hi Wenzhuo, On Fri, 28 Apr 2017 08:38:21 +, "Lu, Wenzhuo" wrote: > Hi Oilvier, > As we discussed before, I send this patch. Would you like to take a look at > it? Better fix it before release 17.05, thanks. > > > > -Original Message- > > From: Lu, Wenzhuo > > Sent: Tuesday, April 2

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: enabled control for packet timestamps

2017-04-28 Thread Thomas Monjalon
28/04/2017 02:19, Wu, Jingjing: > > 25/04/2017 16:02, Wu, Jingjing: > > > From: Oleg Kuporosov > > > > Implemented two methods of control > > > > > > > > - by --enable-timestamps CL testpmd application we can enable > > timestamping > > > > for all ports; > > > > - in interactive mode port config

Re: [dpdk-dev] [PATCH] devtools: list stable commits do not have fixline

2017-04-28 Thread Yuanhan Liu
On Fri, Apr 28, 2017 at 11:00:07AM +0200, Thomas Monjalon wrote: > 28/04/2017 10:27, Yuanhan Liu: > > On Fri, Apr 28, 2017 at 10:15:46AM +0200, Thomas Monjalon wrote: > > > 28/04/2017 09:21, Yuanhan Liu: > > > > Some commits for stable releases (with Cc stable tag) may not have the > > > > fixline.

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix number of mbufs in pool

2017-04-28 Thread Wu, Jingjing
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, April 24, 2017 8:34 PM > To: dev@dpdk.org; Wu, Jingjing > Cc: Richardson, Bruce ; sta...@dpdk.org > Subject: [PATCH 2/2] app/testpmd: fix number of mbufs in pool > > The number of mbufs in pools is

Re: [dpdk-dev] [PATCH] eal: fix 64bit address alignment in 32-bit builds

2017-04-28 Thread Bruce Richardson
On Fri, Apr 28, 2017 at 10:56:56AM +0200, Thomas Monjalon wrote: > 28/04/2017 10:15, Bruce Richardson: > > On i686 builds, the uint64_t type is 64-bits in size but is aligned to > > 32-bits only. This causes mbuf fields for rearm_data to not be 16-byte > > aligned on 32-bit builds, which causes err

Re: [dpdk-dev] [PATCH] devtools: list stable commits do not have fixline

2017-04-28 Thread Thomas Monjalon
28/04/2017 10:27, Yuanhan Liu: > On Fri, Apr 28, 2017 at 10:15:46AM +0200, Thomas Monjalon wrote: > > 28/04/2017 09:21, Yuanhan Liu: > > > Some commits for stable releases (with Cc stable tag) may not have the > > > fixline. For example: > > > http://dpdk.org/dev/patchwork/patch/23955/ > > > >

[dpdk-dev] [PATCH v2 1/2] table: separate out arch specific defines from lru header

2017-04-28 Thread Ashwin Sekhar T K
* Moved all x86 related lru defines to rte_lru_x86.h while retaining all common defines in rte_lru.h * Verified the changes with table_autotest unit test case Signed-off-by: Ashwin Sekhar T K --- v2: * Fixed checkpatch warnings/errors * Symlink lib/librte_table/rte_lru_x86.h only for x86 archit

[dpdk-dev] [PATCH v2 2/2] table: add neon version for lru strategy 3

2017-04-28 Thread Ashwin Sekhar T K
* Added new file rte_lru_arm64.h for holding arm64 specific definitions * Verified the changes with table_autotest unit test case Signed-off-by: Ashwin Sekhar T K --- v2: * Fixed checkpatch warnings/errors * Fixed merge conflict in MAINTAINERS * Symlink rte_lru_arm64.h only for arm64 architectu

Re: [dpdk-dev] [PATCH] eal: fix 64bit address alignment in 32-bit builds

2017-04-28 Thread Thomas Monjalon
28/04/2017 10:15, Bruce Richardson: > On i686 builds, the uint64_t type is 64-bits in size but is aligned to > 32-bits only. This causes mbuf fields for rearm_data to not be 16-byte > aligned on 32-bit builds, which causes errors with some vector PMDs which > expect the rearm data to be aligned as

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix crash at mbuf pool creation

2017-04-28 Thread Wu, Jingjing
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, April 24, 2017 8:34 PM > To: dev@dpdk.org; Wu, Jingjing > Cc: Richardson, Bruce ; sta...@dpdk.org > Subject: [PATCH 1/2] app/testpmd: fix crash at mbuf pool creation > > Since > commit 999b2ee0fe45

Re: [dpdk-dev] [PATCH v2] sched: add neon optimizations

2017-04-28 Thread Jianbo Liu
On 28 April 2017 at 14:15, Ashwin Sekhar T K wrote: > * Removed setting CONFIG_RTE_SCHED_VECTOR=n from armv8a config > so that the setting from common_base is taken as the default > setting for armv8a > * Verified the changes with sched_autotest unit test case > > Signed-off-by: Ashwin Sekhar

Re: [dpdk-dev] [PATCH v5] devtools: add tags and cscope index file generation support

2017-04-28 Thread Thomas Monjalon
Hi, I have some comments about behaviour, naming and coding style. 22/03/2017 09:30, Jerin Jacob: > +verbose=false > +linuxapp=false > +bsdapp=false linuxapp/bsdapp could be renamed to simpler linux/bsd. > +x86_64=false > +arm=false Why not arm32 for consistency? > +arm64=false > +ia_32=false

Re: [dpdk-dev] [PATCH] lib/librte_cmdline: fix CLI parsing issue

2017-04-28 Thread Lu, Wenzhuo
Hi Oilvier, As we discussed before, I send this patch. Would you like to take a look at it? Better fix it before release 17.05, thanks. > -Original Message- > From: Lu, Wenzhuo > Sent: Tuesday, April 25, 2017 11:11 AM > To: dev@dpdk.org > Cc: olivier.m...@6wind.com; Lu, Wenzhuo; sta...@d

Re: [dpdk-dev] [PATCH v1 2/2] examples/l2fwd-keepalive: add SHM cleanup on exit

2017-04-28 Thread Mcnamara, John
> -Original Message- > From: Horton, Remy > Sent: Thursday, April 27, 2017 1:37 PM > To: dev@dpdk.org > Cc: Mcnamara, John > Subject: [PATCH v1 2/2] examples/l2fwd-keepalive: add SHM cleanup on exit > > This patch adds the unlinking/unmapping of shared host memory on > termination of l2

Re: [dpdk-dev] [PATCH v1 1/2] examples/l2fwd-keepalive: add graceful exit

2017-04-28 Thread Mcnamara, John
> -Original Message- > From: Horton, Remy > Sent: Thursday, April 27, 2017 1:37 PM > To: dev@dpdk.org > Cc: Mcnamara, John > Subject: [PATCH v1 1/2] examples/l2fwd-keepalive: add graceful exit > > The l2fwd-keepalive example has infinite processing loops and as a result > the only way t

Re: [dpdk-dev] [PATCH v4] app/testpmd: initialize port_numa and ring_numa

2017-04-28 Thread Wu, Jingjing
> -Original Message- > From: Pei, Yulong > Sent: Friday, April 28, 2017 10:02 AM > To: dev@dpdk.org > Cc: Wu, Jingjing ; tho...@monjalon.net > Subject: [PATCH v4] app/testpmd: initialize port_numa and ring_numa > > Previous numa_support = 0 by default, it need to add --numa to testpmd >

Re: [dpdk-dev] [PATCH] net/i40e: consider QinQ when setting MTU

2017-04-28 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Wu, Jingjing > Sent: Friday, April 28, 2017 4:27 PM > To: Yigit, Ferruh; Lu, Wenzhuo; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/i40e: consider QinQ when setting MTU > > > > > -Original Message- > > From: dev [mailto:dev-boun...@dp

Re: [dpdk-dev] [PATCH] devtools: list stable commits do not have fixline

2017-04-28 Thread Yuanhan Liu
On Fri, Apr 28, 2017 at 10:15:46AM +0200, Thomas Monjalon wrote: > 28/04/2017 09:21, Yuanhan Liu: > > Some commits for stable releases (with Cc stable tag) may not have the > > fixline. For example: > > http://dpdk.org/dev/patchwork/patch/23955/ > > > > It disables a feature we have implemente

Re: [dpdk-dev] [PATCH] net/i40e: consider QinQ when setting MTU

2017-04-28 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Friday, April 28, 2017 1:55 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: consider QinQ when setting MTU > > On 4/28/2017 2:55 AM, Wenzhuo Lu wrote: > > When

Re: [dpdk-dev] [PATCH v1] app/testpmd: add bitrate stats option

2017-04-28 Thread Wu, Jingjing
> -Original Message- > From: Horton, Remy > Sent: Wednesday, April 26, 2017 9:03 PM > To: dev@dpdk.org > Cc: Wu, Jingjing > Subject: [PATCH v1] app/testpmd: add bitrate stats option > > Bit-rate collation should only be done by one core. This patch adds an option > to > select which co

Re: [dpdk-dev] [PATCH] eal: fix 64bit address alignment in 32-bit builds

2017-04-28 Thread Bruce Richardson
On Fri, Apr 28, 2017 at 09:15:51AM +0100, Bruce Richardson wrote: > On i686 builds, the uint64_t type is 64-bits in size but is aligned to > 32-bits only. This causes mbuf fields for rearm_data to not be 16-byte > aligned on 32-bit builds, which causes errors with some vector PMDs which > expect th

[dpdk-dev] [PATCH] eal: fix 64bit address alignment in 32-bit builds

2017-04-28 Thread Bruce Richardson
On i686 builds, the uint64_t type is 64-bits in size but is aligned to 32-bits only. This causes mbuf fields for rearm_data to not be 16-byte aligned on 32-bit builds, which causes errors with some vector PMDs which expect the rearm data to be aligned as on 64-bit. Given that we cannot use the ext

Re: [dpdk-dev] [PATCH] devtools: list stable commits do not have fixline

2017-04-28 Thread Thomas Monjalon
28/04/2017 09:21, Yuanhan Liu: > Some commits for stable releases (with Cc stable tag) may not have the > fixline. For example: > http://dpdk.org/dev/patchwork/patch/23955/ > > It disables a feature we have implemented in last release. The feature > is done right. It's the QEMU implementaton b

Re: [dpdk-dev] [PATCH] app/testpmd: initalize port_numa and ring_numa

2017-04-28 Thread Pei, Yulong
Hi Jingjing, Thanks for the review, already sent v4 patch and fixes line in it. Best Regards Yulong Pei -Original Message- From: Wu, Jingjing Sent: Friday, April 28, 2017 3:36 PM To: Pei, Yulong ; dev@dpdk.org Cc: Richardson, Bruce ; tho...@monjalon.net Subject: RE: [PATCH] app/testpmd:

[dpdk-dev] [PATCH v4] app/testpmd: initialize port_numa and ring_numa

2017-04-28 Thread Yulong Pei
Previous numa_support = 0 by default, it need to add --numa to testpmd command line to enable numa, so port_numa and ring_numa were initialized at function launch_args_parse(), now testpmd change numa_support = 1 as default, so port_numa and ring_numa also need to initialize by default, otherwise p

Re: [dpdk-dev] [PATCH] net/i40e: add check for ethertype filter

2017-04-28 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Thursday, April 27, 2017 7:02 PM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: [PATCH] net/i40e: add check for ethertype filter > > LLDP rule is not supported in ethertype filter. > > Signed-off-by: Beilei Xing > --- > drivers/net/

Re: [dpdk-dev] [PATCH] vhost: fix MQ fails to startup

2017-04-28 Thread Yuanhan Liu
On Fri, Apr 28, 2017 at 09:57:20AM +0200, Maxime Coquelin wrote: > >>>Maybe we could introduce a version message? With that, we could tell > >>>whether the frontend has fixed the known bug or not. > >> > >>That's a possibility, but this is not really the role of a protocol > >>version. As in this c

Re: [dpdk-dev] [PATCH] vhost: fix MQ fails to startup

2017-04-28 Thread Maxime Coquelin
On 04/28/2017 09:35 AM, Yuanhan Liu wrote: On Fri, Apr 28, 2017 at 09:23:54AM +0200, Maxime Coquelin wrote: On 04/28/2017 04:25 AM, Yuanhan Liu wrote: On Thu, Apr 27, 2017 at 10:52:20AM +0200, Maxime Coquelin wrote: On 04/27/2017 10:20 AM, Yuanhan Liu wrote: On Thu, Apr 27, 2017 at 09:5

Re: [dpdk-dev] [dpdk-stable] [PATCH] crypto/qat: fix dequeue count stats retrieval

2017-04-28 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Trahe, Fiona > Sent: Thursday, April 27, 2017 4:47 PM > To: Eads, Gage; dev@dpdk.org > Cc: Griffin, John; Jain, Deepak K; sta...@dpdk.org; Trahe, Fiona > Subject: Re: [dpdk-stable] [PATCH] crypto/qat: fix de

Re: [dpdk-dev] [PATCH] drivers/net/i40e/i40e_fdir.c: Improved i40e FDIR programming times

2017-04-28 Thread Wu, Jingjing
Hi, Lijia Thanks for the patch? Are you using git send-email. The mail is html format, not friendly to discuss by mail thread. About the change, just one comments: >+ uint32_t w; Could you move it above? Thanks From: Michael Lilja [mailto:m...@napatech.com] Sent: Wednesday, April 26, 2017 7:

Re: [dpdk-dev] [PATCH] examples/l3fwd-power: fix Rx descriptor size

2017-04-28 Thread Yao, Lei A
I have test this patch based on 17.05-rc2 , issue is fixed. Host frequency can be changed according to the data throughput. Tested-by: Lei Yao (lei.a@intel.com) > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Wednesday, April 26, 2017

Re: [dpdk-dev] [PATCH] app/testpmd: add bus info when display port info

2017-04-28 Thread Wu, Jingjing
> -Original Message- > From: Pei, Yulong > Sent: Wednesday, April 26, 2017 12:32 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; tho...@monjalon.net > Subject: [PATCH] app/testpmd: add bus info when display port info > > Display pci device bus info when show port info. > > Signed-off-by: Yul

Re: [dpdk-dev] [PATCH] vhost: fix MQ fails to startup

2017-04-28 Thread Yuanhan Liu
On Fri, Apr 28, 2017 at 03:35:53PM +0800, Yuanhan Liu wrote: > > >Maybe we could introduce a version message? With that, we could tell > > >whether the frontend has fixed the known bug or not. > > > > That's a possibility, but this is not really the role of a protocol > > version. As in this case,

[dpdk-dev] [PATCH] net/ark: fix kvargs memory leak

2017-04-28 Thread Ferruh Yigit
Coverity issue: 1428042 Fixes: 1131cbf0fb2b ("net/ark: stub PMD for Atomic Rules Arkville") Signed-off-by: Ferruh Yigit --- Please check next-net coverity project for more issues detected: https://scan.coverity.com/projects/dpdk-next-net?tab=overview --- drivers/net/ark/ark_ethdev.c | 14 +++

  1   2   >